DO NOT REPLY [Bug 25688] New: - install target broken for sample webapp - java.util.zip.ZipException

2003-12-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25688.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25688

install target broken for sample webapp - java.util.zip.ZipException

   Summary: install target broken for sample webapp -
java.util.zip.ZipException
   Product: Tomcat 5
   Version: 5.0.16
  Platform: All
OS/Version: All
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Webapps:Documentation
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


In the binary distribution of tomcat-5.0.16

Using ant and the build file for the sample webapp
jakarta-tomcat-5.0.16\webapps\tomcat-docs\appdev\sample\build.xml

The install target fails with
[deploy] FAIL - Encountered exception java.util.zip.ZipException: error in
opening zip file

This problem has been answered on one of the mailing lists
http://www.mail-archive.com/[EMAIL PROTECTED]/msg111456.html

To solve this problem 2 changes are required to the build.xml file.

1) an extra taskdef line is required.  Add the following line to build.xml where
the other taskdefs are.
taskdef name=install   classname=org.apache.catalina.ant.InstallTask/

2) The deploy task within the install target needs to be changed to an
install task.  All the arguments/ parameters remain the same, just change the
line.
from;
deploy url=${manager.url}
to;
install url=${manager.url}

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 25596] - application briefly unavailable when using manager to reload

2003-12-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25596.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25596

application briefly unavailable when using manager to reload





--- Additional Comments From [EMAIL PROTECTED]  2003-12-22 07:29 ---
If I set the Context to be reloadable, doesn't that involve a Stop and Start 
sequence as well. Just for your info Remmy most of the commercial webserver 
provides a way for waiting while reload. When a client is making a POST 
request like submitting a billing request (with credit card or a lot of data ) 
and gets the application is unavailable, they don't know to click refresh to 
try again and if they know they will be prompted with the message if they are 
sure to repost the request.
 If TC maintains the session between reloads why can't wait be one of the 
features of TC as well. It might not be as easy to develop as Stop/Start but 
it is definetly worth the effort.

Anyways I would appreciate if you can post the location to patch TC with the 
older implementation if possible.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 25596] - application briefly unavailable when using manager to reload

2003-12-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25596.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25596

application briefly unavailable when using manager to reload

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WONTFIX |



--- Additional Comments From [EMAIL PROTECTED]  2003-12-22 07:50 ---
I looked at some of the code and just wanted to ask you guys if there is any 
problem with replacing the ContainerBase.invoke implementation with something 
along the lines of.
public final void invoke(Request request, Response response)
throws IOException, ServletException {
while ( getPaused () ) 
{ 
   synchronized(this){ wait(1000);}
}
pipeline.invoke(request, response);

}

According to the StandardContext implementation the reload method call 
setPaused(true ) 
setPaused(false)
during the process of reloading.

Please let me know of the side effects for this solution that you might 
anticipate so that I might be aware of it. 
Thanks

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 25689] New: - Request attributes are unavailable to jspf included by pageContext.include()

2003-12-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25689.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25689

Request attributes are unavailable to jspf included by pageContext.include()

   Summary: Request attributes are unavailable to jspf included by
pageContext.include()
   Product: Tomcat 4
   Version: 4.1.19
  Platform: Other
OS/Version: Windows XP
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Jasper 2
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I've a custom tag.  In its doStartTag, a request attribute is set before a jspf
is included, as follows:

this.pageContext.getRequest().setAttribute(foo, value);   
this.pageContext.include(/WEB-INF/jspf/part/text.jspf);

In the text.jspf, the request attribute should be printed out by:

c:out value=${requestScope['foo']}/

However, no value is displayed.  

The same c:out line can display the request attribute if it is in the original
jsp that contains the custom tag.

If the text.jspf is renamed to text.jsp, the request value is printed out. 
Another workaround is to add the following into tomcat's web.xml:

servlet-mapping
  servlet-namejsp/servlet-name
  url-pattern*.jspf/url-pattern
/servlet-mapping

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 25596] - application briefly unavailable when using manager to reload

2003-12-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25596.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25596

application briefly unavailable when using manager to reload





--- Additional Comments From [EMAIL PROTECTED]  2003-12-22 07:56 ---
I apologize for the previous implementation I didn't notice that the paused 
flag is a private variable in the StandardContext, may be the solution for me 
would be to change the invoke method in the ContainerBase to be not final and 
override the method with 

 public final void invoke(Request request, Response response)
throws IOException, ServletException {
while ( getPaused () ) 
{ 
   synchronized(this){ wait(1000);}
}
super.invoke(request, response);

}
I understand that changing a method not to be final is a direct violation of 
the Tomcat structure and API but this patch is only for my version and I just 
wanted to know if this is something that you guys would find some other 
problem that I am not aware of in this solution.
Thanks Again

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 25680] - Exception thrown when including a jsp mapped to a custom servlet name

2003-12-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25680.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25680

Exception thrown when including a jsp mapped to a custom servlet name





--- Additional Comments From [EMAIL PROTECTED]  2003-12-22 09:07 ---
I am extremely glad that the fix is trivial, but I don't like your patch. I also
find the explanation of the problem to be not trivial. Please restate what the
problem actually is, and how to reproduce the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 25676] - ISE thrown when accessing a session with cross context

2003-12-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25676.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25676

ISE thrown when accessing a session with cross context

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||INVALID
Summary|Why the session is  |ISE thrown when accessing a
   |invalidaed? |session with cross context



--- Additional Comments From [EMAIL PROTECTED]  2003-12-22 09:13 ---
This works for me. I did already spend time trying to reproduce this, but
couldn't. If you want me to waste more time on this issue, then you should
attach two ready to run WARs to this report.

Again, please do not reopen this report. You know, not knowing how to write
proper english, and submitting test cases which don't build, casts big doubts
on the credibility of your reports. So when I actually test them, and it works,
then that credibility drops to zero.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: DO NOT REPLY [Bug 25681] - HTTP request params lost when sent with a URL ending with a folder w/o '/' at the end of URL

2003-12-22 Thread Remy Maucherat
Reshat Sabiq wrote:
[EMAIL PROTECTED] wrote:
I guess this means i can get the fix in the latest nightly build?
I would think this issue alone justifies release of 5.0.17 soon. When 
could i expect it?
I disagree, this is a very minor issue. Since it has parameters, you 
control the links. Generating links to a folder with the trailing / 
seems very logical, and more efficient, so there should be a problem 
only in very few situations.

Rémy



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


DO NOT REPLY [Bug 25688] - install target broken for sample webapp - java.util.zip.ZipException

2003-12-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25688.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25688

install target broken for sample webapp - java.util.zip.ZipException

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX



--- Additional Comments From [EMAIL PROTECTED]  2003-12-22 09:20 ---
What you suggest is incorrect. The example needs to be fixed, though.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/webapps/docs/appdev build.xml.txt

2003-12-22 Thread remm
remm2003/12/22 01:22:02

  Modified:webapps/docs/appdev build.xml.txt
  Log:
  - Use localWar attribute.
  
  Revision  ChangesPath
  1.5   +2 -2  jakarta-tomcat-catalina/webapps/docs/appdev/build.xml.txt
  
  Index: build.xml.txt
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/appdev/build.xml.txt,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- build.xml.txt 21 Sep 2003 23:13:03 -  1.4
  +++ build.xml.txt 22 Dec 2003 09:22:02 -  1.5
  @@ -361,7 +361,7 @@
  username=${manager.username}
  password=${manager.password}
  path=${app.path}
  -war=file://${build.home}/
  +   localWar=file://${build.home}/
   
 /target
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationHttpRequest.java

2003-12-22 Thread remm
remm2003/12/22 01:28:50

  Modified:catalina/src/share/org/apache/catalina/core
ApplicationHttpRequest.java
  Log:
  - Improve creation of cross context sessions:
- they will now timeout correctly
- they will appear as new when created
  
  Revision  ChangesPath
  1.14  +9 -5  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationHttpRequest.java
  
  Index: ApplicationHttpRequest.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationHttpRequest.java,v
  retrieving revision 1.13
  retrieving revision 1.14
  diff -u -r1.13 -r1.14
  --- ApplicationHttpRequest.java   16 Sep 2003 18:56:35 -  1.13
  +++ ApplicationHttpRequest.java   22 Dec 2003 09:28:50 -  1.14
  @@ -544,8 +544,12 @@
   }
   if (localSession == null) {
   localSession = context.getManager().createEmptySession();
  -localSession.setId(other.getId());
  +localSession.setNew(true);
   localSession.setValid(true);
  +localSession.setCreationTime(System.currentTimeMillis());
  +localSession.setMaxInactiveInterval
  +(context.getManager().getMaxInactiveInterval());
  +localSession.setId(other.getId());
   }
   session = localSession.getSession();
   return session;
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 25596] - application briefly unavailable when using manager to reload

2003-12-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25596.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25596

application briefly unavailable when using manager to reload

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|Normal  |Enhancement



--- Additional Comments From [EMAIL PROTECTED]  2003-12-22 09:29 ---
I would be glad if you tested your proposed changes before submitting patches.
BTW, your proposed change will likely not work.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 25610] - javadocs of TLV.validate() need

2003-12-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25610.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25610

javadocs of TLV.validate() need

[EMAIL PROTECTED] changed:

   What|Removed |Added

  Component|Jasper  |Servlet  JSP API
Summary|javadocs of TLV.validate()  |javadocs of TLV.validate()
   |need|need
   |javadocs of TLV.validate()  |
   |need to be clarified to |
   |match the spec  |

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Important information about jakarta-servletapi-*

2003-12-22 Thread Remy Maucherat
Mark Roth wrote:
Unfortunately, the answer is no, even though it seems rather silly.  The 
reason is that the specifications themselves have an auto-generated copy 
of the javadocs in PDF format, and the assertion list for the TCK is 
generated, in part, based on the javadoc tags.  Converting an incorrect 
@returns to a correct @return would make both the spec PDF and assertion 
list get out of sync with the API workspace.  There are other 
side-effects as well.

Thanks in advance for the summary to the specification aliases!
I think we should refuse reports against the APIs, and direct folks to 
Sun or the JCP.

Rémy



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


DO NOT REPLY [Bug 25676] - ISE thrown when accessing a session with cross context

2003-12-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25676.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25676

ISE thrown when accessing a session with cross context

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED



--- Additional Comments From [EMAIL PROTECTED]  2003-12-22 11:02 ---

The cause about my exception is that I have used tomcat 5.0.12.The other 
release which is 5.0.16 did not throw this exception.

I downloaded Tomcat 5.0.16 and all is right today. 

I'm so sorry about my mistake.

Thank you!

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 25689] - Request attributes are unavailable to jspf included by pageContext.include()

2003-12-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25689.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25689

Request attributes are unavailable to jspf included by pageContext.include()

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2003-12-22 11:44 ---
Your workaround is what is supposed to be done. If you use a non standard
extension for jsp (other than .jsp)  - you need to map that in web.xml.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/util DOMWriter.java

2003-12-22 Thread markt
markt   2003/12/22 04:38:02

  Modified:catalina/src/share/org/apache/catalina/servlets
WebdavServlet.java
   catalina/src/share/org/apache/catalina/util DOMWriter.java
  Log:
  - Fix bug 8859. Correct namespace handling for lock owners in WebDAV servlet.
  
  Revision  ChangesPath
  1.8   +9 -6  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets/WebdavServlet.java
  
  Index: WebdavServlet.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets/WebdavServlet.java,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- WebdavServlet.java10 Dec 2003 21:29:06 -  1.7
  +++ WebdavServlet.java22 Dec 2003 12:38:02 -  1.8
  @@ -261,9 +261,11 @@
   protected DocumentBuilder getDocumentBuilder()
   throws ServletException {
   DocumentBuilder documentBuilder = null;
  +DocumentBuilderFactory documentBuilderFactory = null;
   try {
  -documentBuilder = 
  -DocumentBuilderFactory.newInstance().newDocumentBuilder();
  +documentBuilderFactory = DocumentBuilderFactory.newInstance();
  +documentBuilderFactory.setNamespaceAware(true);
  +documentBuilder = documentBuilderFactory.newDocumentBuilder();
   } catch(ParserConfigurationException e) {
   throw new ServletException
   (sm.getString(webdavservlet.jaxpfailed));
  @@ -1014,6 +1016,7 @@
   case Node.ELEMENT_NODE:
   strWriter = new StringWriter();
   domWriter = new DOMWriter(strWriter, true);
  +domWriter.setQualifiedNames(false);
   domWriter.print(currentNode);
   lock.owner += strWriter.toString();
   break;
  
  
  
  1.3   +52 -10
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/util/DOMWriter.java
  
  Index: DOMWriter.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/util/DOMWriter.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- DOMWriter.java2 Sep 2003 21:22:06 -   1.2
  +++ DOMWriter.java22 Dec 2003 12:38:02 -  1.3
  @@ -98,6 +98,8 @@
 EBCDIC-CP-IS, EBCDIC-CP-AR2, UTF-16
   };
   
  +   /** Output qualified names */
  +   private boolean qualifiedNames = true;
   
  /** Print writer. */
  protected PrintWriter out;
  @@ -126,6 +128,14 @@
   this.canonical = canonical;
   }
   
  +   public boolean getQualifiedNames() {
  +  return this.qualifiedNames;
  +   }
  +
  +   public void setQualifiedNames(boolean qualifiedNames) {
  +  this.qualifiedNames = qualifiedNames;
  +   }
  +
  public static String getWriterEncoding( ) {
 return (PRINTWRITER_ENCODING);
  }// getWriterEncoding
  @@ -181,12 +191,21 @@
   // print element with attributes
case Node.ELEMENT_NODE: {
  out.print('');
  -   out.print(node.getNodeName());
  +   if (this.qualifiedNames) { 
  +  out.print(node.getNodeName());
  +   } else {
  +  out.print(node.getLocalName());
  +   }
  Attr attrs[] = sortAttributes(node.getAttributes());
  for ( int i = 0; i  attrs.length; i++ ) {
 Attr attr = attrs[i];
 out.print(' ');
  -  out.print(attr.getNodeName());
  +  if (this.qualifiedNames) {
  + out.print(attr.getNodeName());
  +  } else {
  + out.print(attr.getLocalName());
  +  }
  +  
 out.print(=\);
 out.print(normalize(attr.getNodeValue()));
 out.print('');
  @@ -214,7 +233,11 @@
 }
  } else {
 out.print('');
  -  out.print(node.getNodeName());
  +  if (this.qualifiedNames) {
  + out.print(node.getNodeName());
  +  } else {
  + out.print(node.getLocalName());
  +  }
 out.print(';');
  }
  break;
  @@ -241,7 +264,12 @@
   // print processing instruction
case Node.PROCESSING_INSTRUCTION_NODE: {
  out.print(?);
  -   out.print(node.getNodeName());
  +   if (this.qualifiedNames) {
  +  out.print(node.getNodeName());
  +   } else {
  +  

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/util DOMWriter.java

2003-12-22 Thread markt
markt   2003/12/22 04:38:54

  Modified:catalina/src/share/org/apache/catalina/servlets
WebdavServlet.java
   catalina/src/share/org/apache/catalina/util DOMWriter.java
  Log:
  - Port patch.
  - Fix bug 8859. Correct namespace handling for lock owners in WebDAV servlet.
  
  Revision  ChangesPath
  1.31  +9 -6  
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/servlets/WebdavServlet.java
  
  Index: WebdavServlet.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/servlets/WebdavServlet.java,v
  retrieving revision 1.30
  retrieving revision 1.31
  diff -u -r1.30 -r1.31
  --- WebdavServlet.java10 Dec 2003 21:36:05 -  1.30
  +++ WebdavServlet.java22 Dec 2003 12:38:54 -  1.31
  @@ -261,9 +261,11 @@
   protected DocumentBuilder getDocumentBuilder()
   throws ServletException {
   DocumentBuilder documentBuilder = null;
  +DocumentBuilderFactory documentBuilderFactory = null;
   try {
  -documentBuilder = 
  -DocumentBuilderFactory.newInstance().newDocumentBuilder();
  +documentBuilderFactory = DocumentBuilderFactory.newInstance();
  +documentBuilderFactory.setNamespaceAware(true);
  +documentBuilder = documentBuilderFactory.newDocumentBuilder();
   } catch(ParserConfigurationException e) {
   throw new ServletException
   (sm.getString(webdavservlet.jaxpfailed));
  @@ -1014,6 +1016,7 @@
   case Node.ELEMENT_NODE:
   strWriter = new StringWriter();
   domWriter = new DOMWriter(strWriter, true);
  +domWriter.setQualifiedNames(false);
   domWriter.print(currentNode);
   lock.owner += strWriter.toString();
   break;
  
  
  
  1.3   +52 -11
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/util/DOMWriter.java
  
  Index: DOMWriter.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/util/DOMWriter.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- DOMWriter.java22 Jul 2001 20:25:13 -  1.2
  +++ DOMWriter.java22 Dec 2003 12:38:54 -  1.3
  @@ -69,7 +69,6 @@
   import org.w3c.dom.NamedNodeMap;
   import org.w3c.dom.Node;
   import org.w3c.dom.NodeList;
  -import org.xml.sax.InputSource;
   
   /**
* A sample DOM writer. This sample program illustrates how to
  @@ -95,6 +94,8 @@
 EBCDIC-CP-IS, EBCDIC-CP-AR2, UTF-16
   };
   
  +   /** Output qualified names */
  +   private boolean qualifiedNames = true;
   
  /** Print writer. */
  protected PrintWriter out;
  @@ -123,6 +124,14 @@
   this.canonical = canonical;
   }
   
  +   public boolean getQualifiedNames() {
  +  return this.qualifiedNames;
  +   }
  +
  +   public void setQualifiedNames(boolean qualifiedNames) {
  +  this.qualifiedNames = qualifiedNames;
  +   }
  +
  public static String getWriterEncoding( ) {
 return (PRINTWRITER_ENCODING);
  }// getWriterEncoding
  @@ -178,12 +187,21 @@
   // print element with attributes
case Node.ELEMENT_NODE: {
  out.print('');
  -   out.print(node.getNodeName());
  +   if (this.qualifiedNames) { 
  +  out.print(node.getNodeName());
  +   } else {
  +  out.print(node.getLocalName());
  +   }
  Attr attrs[] = sortAttributes(node.getAttributes());
  for ( int i = 0; i  attrs.length; i++ ) {
 Attr attr = attrs[i];
 out.print(' ');
  -  out.print(attr.getNodeName());
  +  if (this.qualifiedNames) {
  + out.print(attr.getNodeName());
  +  } else {
  + out.print(attr.getLocalName());
  +  }
  +  
 out.print(=\);
 out.print(normalize(attr.getNodeValue()));
 out.print('');
  @@ -211,7 +229,11 @@
 }
  } else {
 out.print('');
  -  out.print(node.getNodeName());
  +  if (this.qualifiedNames) {
  + out.print(node.getNodeName());
  +  } else {
  + out.print(node.getLocalName());
  +  }
 out.print(';');
  }
  break;
  @@ -238,7 +260,12 @@
   // print processing instruction
case Node.PROCESSING_INSTRUCTION_NODE: 

DO NOT REPLY [Bug 8859] - Out-of-namespace A:href with locked files

2003-12-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8859.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8859

Out-of-namespace A:href with locked files

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2003-12-22 12:41 ---
Fixed in CVS and will be included in the next release.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 25689] - Request attributes are unavailable to jspf included by pageContext.include()

2003-12-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25689.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25689

Request attributes are unavailable to jspf included by pageContext.include()





--- Additional Comments From [EMAIL PROTECTED]  2003-12-22 13:09 ---
jspf is a recommended extension for jsp segment/fragment (JSP 1.2 spec, 
section JSP.2.1.7 and JSP 2.0 spec, section JSP.1.1.8)

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 25689] - Request attributes are unavailable to jspf included by pageContext.include()

2003-12-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25689.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25689

Request attributes are unavailable to jspf included by pageContext.include()





--- Additional Comments From [EMAIL PROTECTED]  2003-12-22 13:27 ---
JSP fragments are statically included (@include) segments of code. They are not
meant to be standalone jsps to be included by .include().

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/catalina/src/bin service.bat

2003-12-22 Thread mturk
mturk   2003/12/22 05:48:52

  Added:   catalina/src/bin service.bat
  Log:
  Add service.bat for NT service installation/uninstallation.
  It will einter install service using default name Tomcat5 or
  uninstall.
  
  Revision  ChangesPath
  1.1  jakarta-tomcat-catalina/catalina/src/bin/service.bat
  
  Index: service.bat
  ===
  @echo off
  if %OS% == Windows_NT setlocal
  rem ---
  rem NT Service Install/Uninstall script
  rem
  rem Options
  rem installInstall the service using Tomcat5 as service name.
  remService is installed using default settings.
  rem remove Remove the service from the System.
  rem
  rem name(optional) If the second argument is present it is considered
  remto be new service name
   
  rem
  rem $Id: service.bat,v 1.1 2003/12/22 13:48:52 mturk Exp $
  rem ---
  
  rem Guess CATALINA_HOME if not defined
  set CURRENT_DIR=%cd%
  if not %CATALINA_HOME% ==  goto gotHome
  set CATALINA_HOME=%cd%
  if exist %CATALINA_HOME%\bin\tomcat.exe goto okHome
  rem CD to the upper dir
  cd ..
  set CATALINA_HOME=%cd%
  :gotHome
  if exist %CATALINA_HOME%\bin\tomcat.exe goto okHome
  echo The tomcat.exe was not found...
  echo The CATALINA_HOME environment variable is not defined correctly.
  echo This environment variable is needed to run this program
  goto end
  :okHome
  
  set EXECUTABLE=%CATALINA_HOME%\bin\tomcat.exe
  
  rem Set default Service name
  set SERVICE_NAME=Tomcat5
  
  if %1 ==  goto displayUsage
  if %2 ==  goto setServiceName
  set SERVICE_NAME=%2
  :setServiceName
  if %1 == install goto doInstall
  if %1 == remove goto doRemove
  echo Unknown parameter %1
  :displayUsage
  echo 
  echo Usage: service.bat install/remove [service_name]
  goto end
  
  :doRemove
  rem Remove the service
  %EXECUTABLE% //DS//%SERVICE_NAME%
  echo The service '%SERVICE_NAME%' has been removed
  goto end
  
  :doInstall
  rem Install the service
  %EXECUTABLE% //IS//%SERVICE_NAME% --DisplayName Apache Tomcat --Description 
Apache Tomcat Server - http://jakarta.apache.org/tomcat/;  --Install %EXECUTABLE% 
--ImagePath %CATALINA_HOME%\bootstrap.jar --StartupClass 
org.apache.catalina.startup.Bootstrap;main;start --ShutdownClass 
org.apache.catalina.startup.Bootstrap;main;stop --Java java --Startup manual
  rem Set extra parameters
  %EXECUTABLE% //US//%SERVICE_NAME% --JavaOptions 
-Dcatalina.home=\%CATALINA_HOME%\#-Djava.endorsed.dirs=\%CATALINA_HOME%\common\endorsed\#-Xrs
 --StdOutputFile %CATALINA_HOME%\logs\stdout.log --StdErrorFile 
%CATALINA_HOME%\logs\stderr.log --WorkingPath %CATALINA_HOME%\bin
  echo The service '%SERVICE_NAME%' has been installed
  
  :end
  cd %CURRENT_DIR%
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: New releases

2003-12-22 Thread Shapira, Yoav

Howdy,

I think 5.0.16 quality is quite good, given the bug reports we got so
far, and this is extremely encouraging for the quality of future
releases made from that branch.

I strongly agree, and am pleasantly surprised given the large amount of
people who were waiting for 5.x stable and didn't bother testing
alphas/betas,

Yoav Shapira



This e-mail, including any attachments, is a confidential business communication, and 
may contain information that is confidential, proprietary and/or privileged.  This 
e-mail is intended only for the individual(s) to whom it is addressed, and may not be 
saved, copied, printed, disclosed or used by anyone else.  If you are not the(an) 
intended recipient, please immediately delete this e-mail from your computer system 
and notify the sender.  Thank you.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-site/xdocs-faq misc.xml

2003-12-22 Thread yoavs
yoavs   2003/12/22 06:53:20

  Modified:docs/faq misc.html
   docs/faq/printer misc.html
   xdocs-faq misc.xml
  Log:
  Added external JNDI question to FAQ Misc section.
  
  Revision  ChangesPath
  1.14  +14 -0 jakarta-tomcat-site/docs/faq/misc.html
  
  Index: misc.html
  ===
  RCS file: /home/cvs/jakarta-tomcat-site/docs/faq/misc.html,v
  retrieving revision 1.13
  retrieving revision 1.14
  diff -u -r1.13 -r1.14
  --- misc.html 19 Dec 2003 16:08:35 -  1.13
  +++ misc.html 22 Dec 2003 14:53:20 -  1.14
  @@ -147,6 +147,11 @@
   Is tomcat an EJB server?  Can I use EJBs with tomcat?
 /a
   /li
  +li
  +  a href=#externalJndi
  +Can I access Tomcat's JNDI provider from outside tomcat?
  +  /a
  +/li
 /ul
   /p
   
  @@ -663,6 +668,15 @@
   for Servlets, such as a subset of JNDI functionality.
   Furthermore, you can connect to remote J2EE servers, or
   run tomcat embedded inside a full J2EE server.
  +  /divbr
  +
  +  b style=font-size: larger
  +a name=externalJndi
  +  Can I access Tomcat's JNDI provider from outside tomcat?
  +/a
  +  /b
  +  div style=padding-left : 20px;
  +Not at this time.
 /divbr
   /blockquote/td/tr/table/td/tr!--FOOTER SEPARATOR--trtd 
colspan=2hr size=1 noshade=/td/tr!--PAGE FOOTER--trtd 
colspan=2div align=centerfont size=-1 color=#525D76em
   Copyright copy; 1999-2003, Apache Software Foundation
  
  
  
  1.11  +14 -0 jakarta-tomcat-site/docs/faq/printer/misc.html
  
  Index: misc.html
  ===
  RCS file: /home/cvs/jakarta-tomcat-site/docs/faq/printer/misc.html,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -r1.10 -r1.11
  --- misc.html 19 Dec 2003 16:08:35 -  1.10
  +++ misc.html 22 Dec 2003 14:53:20 -  1.11
  @@ -146,6 +146,11 @@
   Is tomcat an EJB server?  Can I use EJBs with tomcat?
 /a
   /li
  +li
  +  a href=#externalJndi
  +Can I access Tomcat's JNDI provider from outside tomcat?
  +  /a
  +/li
 /ul
   /p
   
  @@ -662,6 +667,15 @@
   for Servlets, such as a subset of JNDI functionality.
   Furthermore, you can connect to remote J2EE servers, or
   run tomcat embedded inside a full J2EE server.
  +  /divbr
  +
  +  b style=font-size: larger
  +a name=externalJndi
  +  Can I access Tomcat's JNDI provider from outside tomcat?
  +/a
  +  /b
  +  div style=padding-left : 20px;
  +Not at this time.
 /divbr
   /blockquote/td/tr/table/td/tr!--FOOTER SEPARATOR--trtd 
colspan=2hr size=1 noshade=/td/tr!--PAGE FOOTER--trtd 
colspan=2div align=centerfont size=-1 color=#525D76em
   Copyright copy; 1999-2003, Apache Software Foundation
  
  
  
  1.10  +14 -0 jakarta-tomcat-site/xdocs-faq/misc.xml
  
  Index: misc.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-site/xdocs-faq/misc.xml,v
  retrieving revision 1.9
  retrieving revision 1.10
  diff -u -r1.9 -r1.10
  --- misc.xml  19 Dec 2003 16:04:53 -  1.9
  +++ misc.xml  22 Dec 2003 14:53:20 -  1.10
  @@ -159,6 +159,11 @@
   Is tomcat an EJB server?  Can I use EJBs with tomcat?
 /a
   /li
  +li
  +  a href=#externalJndi
  +Can I access Tomcat's JNDI provider from outside tomcat?
  +  /a
  +/li
 /ul
   /p
   
  @@ -678,6 +683,15 @@
   for Servlets, such as a subset of JNDI functionality.
   Furthermore, you can connect to remote J2EE servers, or
   run tomcat embedded inside a full J2EE server.
  +  /answer
  +
  +  question
  +a name=externalJndi
  +  Can I access Tomcat's JNDI provider from outside tomcat?
  +/a
  +  /question
  +  answer
  +Not at this time.
 /answer
   /section
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/webapps/docs cluster-howto.xml

2003-12-22 Thread yoavs
yoavs   2003/12/22 07:18:24

  Modified:webapps/docs cluster-howto.xml
  Log:
  Added note to clustering about JDK 1.4 requirement.  Rememebr to remove
  this note if clustering code is modified to work on JDK 1.3.
  
  Revision  ChangesPath
  1.3   +1 -0  jakarta-tomcat-catalina/webapps/docs/cluster-howto.xml
  
  Index: cluster-howto.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/cluster-howto.xml,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- cluster-howto.xml 17 Dec 2003 21:00:40 -  1.2
  +++ cluster-howto.xml 22 Dec 2003 15:18:24 -  1.3
  @@ -30,6 +30,7 @@
  as a load balancer. Apache/mod_jk will also do or hardware of course/p
   pNote: Remember that your session state is tracked by a cookie, so your URL must 
look the same from the out
  side otherwise, a new session will be created./p
  +pNote: Clustering support currently requires the JDK version 1.4 or later./p
   /section
   
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 25703] New: - ExtendedLogValve use wrong filename after rotate or checkexits case

2003-12-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25703.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25703

ExtendedLogValve use wrong filename after rotate or checkexits case

   Summary: ExtendedLogValve use wrong filename after rotate or
checkexits case
   Product: Tomcat 5
   Version: 5.0.16
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


ExtendedLogValve use wrong dateFormater after rotate or checkexists
when used with fileDateFormat=-MM-dd-HH.

Example:
Valve className=org.apache.catalina.valves.ExtendedAccessLogValve
directory=logs
prefix=myapps_ext_access_log.
suffix=.txt
pattern=date time c-ip x-H(remoteUser) cs-method cs-
uri-stem sc-status bytes c-dns cs(User-Agent) cs(Referer) x-S(Hello) 
resolveHosts=false
fileDateFormat=-MM-dd-HH
condition=nolog / 

I look at code base and found that the wrong formatter are used.
I switch to fileDateFormatter and it works (s. patch).

Peter

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 25703] - ExtendedLogValve use wrong filename after rotate or checkexits case

2003-12-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25703.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25703

ExtendedLogValve use wrong filename after rotate or checkexits case





--- Additional Comments From [EMAIL PROTECTED]  2003-12-22 16:26 ---
Created an attachment (id=9663)
Fix wrong ExtendedAccessLogValve

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardWrapper.java StandardWrapperValve.java mbeans-descriptors.xml

2003-12-22 Thread remm
remm2003/12/22 09:47:43

  Modified:catalina/src/share/org/apache/catalina/core
StandardWrapper.java StandardWrapperValve.java
mbeans-descriptors.xml
  Log:
  - Add a minTime attribute on servlets.
  
  Revision  ChangesPath
  1.35  +12 -4 
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardWrapper.java
  
  Index: StandardWrapper.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardWrapper.java,v
  retrieving revision 1.34
  retrieving revision 1.35
  diff -u -r1.34 -r1.35
  --- StandardWrapper.java  15 Oct 2003 18:47:49 -  1.34
  +++ StandardWrapper.java  22 Dec 2003 17:47:43 -  1.35
  @@ -1408,6 +1408,14 @@
   swValve.setMaxTime(maxTime);
   }
   
  +public long getMinTime() {
  +return swValve.getMinTime();
  +}
  +
  +public void setMinTime(long minTime) {
  +swValve.setMinTime(minTime);
  +}
  +
   public int getRequestCount() {
   return swValve.getRequestCount();
   }
  
  
  
  1.24  +11 -1 
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardWrapperValve.java
  
  Index: StandardWrapperValve.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardWrapperValve.java,v
  retrieving revision 1.23
  retrieving revision 1.24
  diff -u -r1.23 -r1.24
  --- StandardWrapperValve.java 15 Oct 2003 18:47:49 -  1.23
  +++ StandardWrapperValve.java 22 Dec 2003 17:47:43 -  1.24
  @@ -109,6 +109,7 @@
   // are here for performance.
   private long processingTime;
   private long maxTime;
  +private long minTime = Long.MAX_VALUE;
   private int requestCount;
   private int errorCount;
   
  @@ -371,6 +372,7 @@
   long time=t2-t1;
   processingTime += time;
   if( time  maxTime) maxTime=time;
  +if( time  minTime) minTime=time;
   
   }
   
  @@ -466,6 +468,14 @@
   
   public void setMaxTime(long maxTime) {
   this.maxTime = maxTime;
  +}
  +
  +public long getMinTime() {
  +return minTime;
  +}
  +
  +public void setMinTime(long minTime) {
  +this.minTime = minTime;
   }
   
   public int getRequestCount() {
  
  
  
  1.27  +5 -0  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/mbeans-descriptors.xml
  
  Index: mbeans-descriptors.xml
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/mbeans-descriptors.xml,v
  retrieving revision 1.26
  retrieving revision 1.27
  diff -u -r1.26 -r1.27
  --- mbeans-descriptors.xml30 Nov 2003 14:33:29 -  1.26
  +++ mbeans-descriptors.xml22 Dec 2003 17:47:43 -  1.27
  @@ -772,6 +772,11 @@
  type=long
  writeable=false /
   
  +attribute name=minTime
  +   description=Minimum processing time of a request
  +   type=long
  +   writeable=false /
  +
   attribute name=requestCount
  description=Number of requests processed by this wrapper
  type=int
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5 MapperListener.java

2003-12-22 Thread remm
remm2003/12/22 09:49:12

  Modified:catalina/src/share/org/apache/coyote/tomcat5
MapperListener.java
  Log:
  - Oops, a try/catch when adding a wrapper, similar to what is done when
handling contexts.
  
  Revision  ChangesPath
  1.12  +5 -1  
jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5/MapperListener.java
  
  Index: MapperListener.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5/MapperListener.java,v
  retrieving revision 1.11
  retrieving revision 1.12
  diff -u -r1.11 -r1.12
  --- MapperListener.java   11 Aug 2003 13:18:03 -  1.11
  +++ MapperListener.java   22 Dec 2003 17:49:12 -  1.12
  @@ -440,7 +440,11 @@
   // name attribute is the same... - then it's ours
   String targetDomain=objectName.getDomain();
   if( ! domain.equals( targetDomain )) {
  -targetDomain=(String) mBeanServer.getAttribute(objectName, 
engineName);
  +try {
  +targetDomain=(String) mBeanServer.getAttribute(objectName, 
engineName);
  +} catch (Exception e) {
  +// Ignore
  +}
   if( ! domain.equals( targetDomain )) {
   // not ours
   return;
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardWrapper.java StandardWrapperValve.java mbeans-descriptors.xml

2003-12-22 Thread Tim Funk
Is there more to this? What is this for?

-Tim

[EMAIL PROTECTED] wrote:

remm2003/12/22 09:47:43

  Modified:catalina/src/share/org/apache/catalina/core
StandardWrapper.java StandardWrapperValve.java
mbeans-descriptors.xml
  Log:
  - Add a minTime attribute on servlets.
  


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardWrapper.java StandardWrapperValve.java mbeans-descriptors.xml

2003-12-22 Thread Remy Maucherat
Tim Funk wrote:
Is there more to this? What is this for?
It gives the minimum amount of time for processing a request for the 
servlet. I think this is not 100% useless (but probably very close to), 
and I found the idea for the attribute in JBoss (in the JSR 77 code).

Rémy



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


DO NOT REPLY [Bug 9786] - org/apache/catalina/valves/RequestDumperValve logs all values x all headers

2003-12-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9786.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9786

org/apache/catalina/valves/RequestDumperValve logs all values x all headers

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WORKSFORME



--- Additional Comments From [EMAIL PROTECTED]  2003-12-22 18:38 ---
This works for me. The version of tomcat this is reported against is rather 
old. Without know which connector you were using, I can say exactly when this 
was fixed.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 9816] - Programmatic Requests to JSP fail with Error Code 404

2003-12-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9816.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9816

Programmatic Requests to JSP fail with Error Code 404

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2003-12-22 19:07 ---
This doesn't look like a tomcat problem to me either. The most likely cause is 
something in your test app or your webapp although without access to either I 
can't be more explicit.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 9979] - load-on-startup without explicit order doesn't work with jsp-file

2003-12-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9979.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9979

load-on-startup without explicit order doesn't work with jsp-file

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2003-12-22 20:14 ---
This has been fixed as reported in bug 12985.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves ExtendedAccessLogValve.java

2003-12-22 Thread funkman
funkman 2003/12/22 12:31:15

  Modified:catalina/src/share/org/apache/catalina/valves
ExtendedAccessLogValve.java
  Log:
  BZ 25703 - ExtendedLogValve use wrong filename after rotate or checkexits case
  Patch submitted by Peter Rossbach pr at webapp dot de
  
  Revision  ChangesPath
  1.6   +7 -9  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves/ExtendedAccessLogValve.java
  
  Index: ExtendedAccessLogValve.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves/ExtendedAccessLogValve.java,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- ExtendedAccessLogValve.java   2 Sep 2003 21:22:03 -   1.5
  +++ ExtendedAccessLogValve.java   22 Dec 2003 20:31:15 -  1.6
  @@ -680,9 +680,8 @@
   }
   
   /* Make sure date is correct */
  -currentDate = new Date();
  -fileDateFormatter = new SimpleDateFormat(-MM-dd);
  -dateStamp = dateFormatter.format(currentDate);
  +currentDate = new Date(System.currentTimeMillis());
  +dateStamp = fileDateFormatter.format(currentDate);
   
   open();
   return true;
  @@ -953,8 +952,7 @@
   
   /* Make sure date is correct */
   currentDate = new Date(System.currentTimeMillis());
  -fileDateFormatter = new SimpleDateFormat(-MM-dd);
  -dateStamp = dateFormatter.format(currentDate);
  +dateStamp = fileDateFormatter.format(currentDate);
   
   open();
   }
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 25703] - ExtendedLogValve use wrong filename after rotate or checkexits case

2003-12-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25703.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25703

ExtendedLogValve use wrong filename after rotate or checkexits case

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2003-12-22 20:36 ---
Fixed thanks!

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/valves ExtendedAccessLogValve.java

2003-12-22 Thread funkman
funkman 2003/12/22 12:37:25

  Modified:catalina/src/share/org/apache/catalina/valves
ExtendedAccessLogValve.java
  Log:
  port patch from 5
  
  Revision  ChangesPath
  1.3   +7 -9  
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/valves/ExtendedAccessLogValve.java
  
  Index: ExtendedAccessLogValve.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/valves/ExtendedAccessLogValve.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- ExtendedAccessLogValve.java   18 Jul 2003 01:24:45 -  1.2
  +++ ExtendedAccessLogValve.java   22 Dec 2003 20:37:24 -  1.3
  @@ -682,9 +682,8 @@
   }
   
   /* Make sure date is correct */
  -currentDate = new Date();
  -fileDateFormatter = new SimpleDateFormat(-MM-dd);
  -dateStamp = dateFormatter.format(currentDate);
  +currentDate = new Date(System.currentTimeMillis());
  +dateStamp = fileDateFormatter.format(currentDate);
   
   open();
   return true;
  @@ -955,8 +954,7 @@
   
   /* Make sure date is correct */
   currentDate = new Date(System.currentTimeMillis());
  -fileDateFormatter = new SimpleDateFormat(-MM-dd);
  -dateStamp = dateFormatter.format(currentDate);
  +dateStamp = fileDateFormatter.format(currentDate);
   
   open();
   }
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/catalina/src/bin service.bat

2003-12-22 Thread billbarker
billbarker2003/12/22 20:31:49

  Modified:catalina/src/bin service.bat
  Log:
  bootstrap.jar is in %CATALINA_HOME%\bin, not %CATALINA_HOME
  
  Revision  ChangesPath
  1.2   +2 -2  jakarta-tomcat-catalina/catalina/src/bin/service.bat
  
  Index: service.bat
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/bin/service.bat,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- service.bat   22 Dec 2003 13:48:52 -  1.1
  +++ service.bat   23 Dec 2003 04:31:49 -  1.2
  @@ -55,7 +55,7 @@
   
   :doInstall
   rem Install the service
  -%EXECUTABLE% //IS//%SERVICE_NAME% --DisplayName Apache Tomcat --Description 
Apache Tomcat Server - http://jakarta.apache.org/tomcat/;  --Install %EXECUTABLE% 
--ImagePath %CATALINA_HOME%\bootstrap.jar --StartupClass 
org.apache.catalina.startup.Bootstrap;main;start --ShutdownClass 
org.apache.catalina.startup.Bootstrap;main;stop --Java java --Startup manual
  +%EXECUTABLE% //IS//%SERVICE_NAME% --DisplayName Apache Tomcat --Description 
Apache Tomcat Server - http://jakarta.apache.org/tomcat/;  --Install %EXECUTABLE% 
--ImagePath %CATALINA_HOME%\bin\bootstrap.jar --StartupClass 
org.apache.catalina.startup.Bootstrap;main;start --ShutdownClass 
org.apache.catalina.startup.Bootstrap;main;stop --Java java --Startup manual
   rem Set extra parameters
   %EXECUTABLE% //US//%SERVICE_NAME% --JavaOptions 
-Dcatalina.home=\%CATALINA_HOME%\#-Djava.endorsed.dirs=\%CATALINA_HOME%\common\endorsed\#-Xrs
 --StdOutputFile %CATALINA_HOME%\logs\stdout.log --StdErrorFile 
%CATALINA_HOME%\logs\stderr.log --WorkingPath %CATALINA_HOME%\bin
   echo The service '%SERVICE_NAME%' has been installed
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Licenses for .bat and .sh files

2003-12-22 Thread Bill Barker
While editing 'service.bat', I noticed that it seems that we are shipping
all of the '.bat' and '.sh' files without including an Apache license.
Before I launch into a realy boring project of fixing this, I wanted to
hear other opinions on how necessary it is.


This message is intended only for the use of the person(s) listed above as the 
intended recipient(s), and may contain information that is PRIVILEGED and 
CONFIDENTIAL.  If you are not an intended recipient, you may not read, copy, or 
distribute this message or any attachment. If you received this communication in 
error, please notify us immediately by e-mail and then delete all copies of this 
message and any attachments.

In addition you should be aware that ordinary (unencrypted) e-mail sent through the 
Internet is not secure. Do not send confidential or sensitive information, such as 
social security numbers, account numbers, personal identification numbers and 
passwords, to us via ordinary (unencrypted) e-mail.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]