DO NOT REPLY [Bug 26622] - WebappClassLoader is inconsistent on delegation of resource loading
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26622. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26622 WebappClassLoader is inconsistent on delegation of resource loading [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2004-02-03 08:19 --- WCL implements public Enumeration findResources(String) from URLCL (this method is protected in ClassLoader). As for getResources(String) from ClassLoader, well, its declaration is: public final Enumeration getResources(String name) It indeed looks in the parent first, but there's nothing I can do about it. So you have to use findResources in addition to getResources if you're using a URLCL. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
[EMAIL PROTECTED] wrote: luehe 2004/02/02 15:08:29 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Expose handshake failure as error, so it gets logged unconditionally -1. Unlike what occurs for normal sockets, errors at this point are rather common, because the process is fairly long. So this was done on purpose to minimise the amount of logging. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java
remm2004/02/03 00:27:43
Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java
Log:
- Revert patch.
Revision ChangesPath
1.218 +32 -28
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java
Index: Generator.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java,v
retrieving revision 1.217
retrieving revision 1.218
diff -u -r1.217 -r1.218
--- Generator.java2 Feb 2004 18:18:00 - 1.217
+++ Generator.java3 Feb 2004 08:27:43 - 1.218
@@ -1261,37 +1261,41 @@
className =
attributeValue(beanName, false, String.class);
}
+out.printil(try {);
+out.pushIndent();
+out.printin(name);
+out.print( = ();
+out.print(type);
+out.print() java.beans.Beans.instantiate();
+out.print(this.getClass().getClassLoader(), );
+out.print(className);
+out.println(););
+out.popIndent();
+/*
+ * Note: Beans.instantiate throws ClassNotFoundException
+ * if the bean class is abstract.
+ */
+out.printil(} catch (ClassNotFoundException exc) {);
+out.pushIndent();
+out.printil(
+throw new InstantiationException(exc.getMessage()););
+out.popIndent();
+out.printil(} catch (Exception exc) {);
+out.pushIndent();
+out.printin(throw new ServletException();
+out.print(\Cannot create bean of class \ + );
+out.print(className);
+out.println(, exc););
+out.popIndent();
+out.printil(}); // close of try
} else {
// Implies klass is not null
-className = quote(klass);
+// Generate codes to instantiate the bean class
+out.printin(name);
+out.print( = new );
+out.print(klass);
+out.println((););
}
-out.printil(try {);
-out.pushIndent();
-out.printin(name);
-out.print( = ();
-out.print(type);
-out.print() java.beans.Beans.instantiate();
-out.print(this.getClass().getClassLoader(), );
-out.print(className);
-out.println(););
-out.popIndent();
-/*
- * Note: Beans.instantiate throws ClassNotFoundException
- * if the bean class is abstract.
- */
-out.printil(} catch (ClassNotFoundException exc) {);
-out.pushIndent();
-out.printil(
-throw new InstantiationException(exc.getMessage()););
-out.popIndent();
-out.printil(} catch (Exception exc) {);
-out.pushIndent();
-out.printin(throw new ServletException();
-out.print(\Cannot create bean of class \ + );
-out.print(className);
-out.println(, exc););
-out.popIndent();
-out.printil(}); // close of try
/*
* Set attribute for bean in the specified scope
*/
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java
Mark Roth wrote: Okay, I took a look at the patch and the bug report and I think I know what's going on now. Please let me know if I do not understand the scenario correctly. It seems there are some JSP 1.2 pages that misuse jsp:useBean by doing one of the following: 1. The class attribute is used for a Java type that cannot be instantiated as a JavaBean. 2. Type or class specifies a type that cannot be found. There are some cases where pages can get away with (1) if the container decides to flag this as a runtime error. These pages are invalid but the container never calls them on it because the objects already exist in some scope. This is probably less likely with (2), but still possible (e.g. if the jsp:useBean never gets executed at all). It would be nice to get a translation error in this case so that you realize your page is invalid. However, the JSP 1.2 specification (on which Tomcat 4.x is based) does not allow for a translation error - it requires that a runtime exception must be thrown. In JSP 2.0 (on which Tomcat 5.x is based), a number of JSP container vendors complained about this and wanted the freedom to throw a translation error in this case. Doing so is better for the page author (since they know up front their page is invalid) and better for the container (since doing a 'new' is MUCH more efficient than doing a call to Beans.instantiate()). So, we added a provision to allow containers to optionally produce a translation error on these invalid pages. One unfortunate side-effect is that some pages that used to compile in Tomcat 4 will no longer compile in Tomcat 5. But it's important to realize that these pages are invalid in both specs. It's just that Tomcat 4 was not allowed to cause an error at translation time. It had to wait until runtime to do so. So where does this leave us with respect to this patch? Tomcat 5 is free to exhibit either behavior. It can throw a translation error or a runtime error for these invalid pages. In my opinion, it is much better for both the page author and the container if we produce a translation-time error. The page author knows their page is invalid right away (without having to exercise the code path), and the container can gain the performance benefits associated with doing a 'new' call directly (instead of Beans.instantiate()). So it's your call, but if I had a vote I'd say stick with Kin-Man's patch. Hope this helps. Thanks for the explanations :) Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 26507] - Jasper Generator java Error (useBean ObjectArray)
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26507. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26507 Jasper Generator java Error (useBean ObjectArray) [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | --- Additional Comments From [EMAIL PROTECTED] 2004-02-03 08:31 --- . - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 26507] - Jasper Generator java Error (useBean ObjectArray)
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26507. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26507 Jasper Generator java Error (useBean ObjectArray) [EMAIL PROTECTED] changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2004-02-03 08:33 --- The patch for this has been reverted as throuwing a translation error has been deemed better by the specification gurus. Please don't reopen the report. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [GUMP@lsd]: jakarta-tomcat-connectors/jakarta-tomcat-jk-native2 failed
Quoting Craig McClanahan [EMAIL PROTECTED]: Project: jakarta-tomcat-jk-native2 State: Failed URL: http://lsd.student.utwente.nl/gump/jakarta-tomcat-connectors/jakarta-tomcat-jk-native2.html - G U M P Y Please remove whatever configuration file setting that indicates that Gump and Gumpy nag messages come from [EMAIL PROTECTED]. The objective fact is that these messages are *not* initiated by me, and the subjective experience that I receive from having these messages attribute to me is even more spam and false-positive virus reports than I would otherwise receive (which is already many hundreds per day). Craig - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: tomcat-connectors distribution
martin grotzke a écrit : On Mon, 2004-02-02 at 18:16, Henri Gomez wrote: at jpackage, there's the question now if it would be better to provide an rpm built with the connectors shipped with the latest tomcat-release, or if it should be built with the connectors 2.0.2. what would you suggest? We'll try to provide a jk2 release soon : - We need to fix some little problems, but Gunter is providing many patches in such area. great! i appreciate this very much, it will clarify the situation at jpackage, too. I'm also involved in jpackage :) an open issue is if jpackage should build from the released connectors or those provided with the tomcat-sources. suggestions? JPackage should only provide released version. - We need a release manager and candidates are welcome :) well, i'd really like to do such job, but i suppose the release manager should know what gets released - i would not - d'oh ,-) so hopefully anybody will volunteer to manage this... If nobody is volunteer, I think I'll do the job - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [GUMP@lsd]: jakarta-tomcat-connectors/jakarta-tomcat-jk-native2 failed
Of course, you can do this all by your self, since any ASF committer is a Gump committer :). I've removed you from all of the nags for j-t-c. If you want to remove your name from other projects nags, I'd suggest doing it yourself :). - Original Message - From: Craig R. McClanahan [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Tuesday, February 03, 2004 12:47 AM Subject: Re: [EMAIL PROTECTED]: jakarta-tomcat-connectors/jakarta-tomcat-jk-native2 failed Quoting Craig McClanahan [EMAIL PROTECTED]: Project: jakarta-tomcat-jk-native2 State: Failed URL: http://lsd.student.utwente.nl/gump/jakarta-tomcat-connectors/jakarta-tomcat-jk-native2.html - G U M P Y Please remove whatever configuration file setting that indicates that Gump and Gumpy nag messages come from [EMAIL PROTECTED]. The objective fact is that these messages are *not* initiated by me, and the subjective experience that I receive from having these messages attribute to me is even more spam and false-positive virus reports than I would otherwise receive (which is already many hundreds per day). Craig - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments. In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 26628] New: - Function without parameters never found
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26628.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26628
Function without parameters never found
Summary: Function without parameters never found
Product: Tomcat 5
Version: 5.0.18
Platform: All
OS/Version: All
Status: NEW
Severity: Normal
Priority: Other
Component: Jasper
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
I have a very simple function call in a JSP page:
${test:foo()}
This function is defined in my taglib as:
function
namefoo/name
function-classfunctions.Foo/function-class
function-signaturejava.lang.String foo()/function-signature
/function
No parameters are to be provided. However, the method
org.apache.jasper.compiler.Validator#getParameters(ELNode.Function)
assumes that parameters are always present. In the abscence of
parameters, an attempt is made to load a class .class, which is
of course not found by any classloader.
I will attach a simple test case for this bug as a war file.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 26628] - Function without parameters never found
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26628. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26628 Function without parameters never found --- Additional Comments From [EMAIL PROTECTED] 2004-02-03 11:13 --- Created an attachment (id=10201) Test case for this bug (scwcd/jsp/test.jsp). - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 26507] - Jasper Generator java Error (useBean ObjectArray)
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26507. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26507 Jasper Generator java Error (useBean ObjectArray) --- Additional Comments From [EMAIL PROTECTED] 2004-02-03 11:42 --- For future reference ... the clarification email to the tomcat-dev list from Mark Roth, JSP 2.0 Co-Specification Lead http://marc.theaimsgroup.com/?l=tomcat-devm=107576431813265w=2 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Validator.java
remm2004/02/03 04:16:59
Modified:jasper2/src/share/org/apache/jasper/compiler Validator.java
Log:
- Don't add blank parameters (bug 26628).
Revision ChangesPath
1.115 +7 -4
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Validator.java
Index: Validator.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Validator.java,v
retrieving revision 1.114
retrieving revision 1.115
diff -u -r1.114 -r1.115
--- Validator.java2 Sep 2003 21:39:58 - 1.114
+++ Validator.java3 Feb 2004 12:16:59 - 1.115
@@ -1346,7 +1346,10 @@
}
lastArg = true;
}
- params.add(signature.substring(start, p).trim());
+String arg = signature.substring(start, p).trim();
+if (!.equals(arg)) {
+params.add(arg);
+}
if (lastArg) {
break;
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 26628] - Function without parameters never found
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26628. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26628 Function without parameters never found [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2004-02-03 12:17 --- Fixed. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[PATCH] Bug 26628
Attached the patch file I created for bug 26628, concerning
the class org.apache.jasper.compiler.Validator.
Regards,
Ronald Wildenberg
Finalist IT Group
Index: Validator.java
===
RCS file:
/home/cvspublic/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Validator.java,v
retrieving revision 1.114
diff -u -r1.114 Validator.java
--- Validator.java 2 Sep 2003 21:39:58 - 1.114
+++ Validator.java 3 Feb 2004 12:14:39 -
@@ -1346,7 +1346,10 @@
}
lastArg = true;
}
- params.add(signature.substring(start, p).trim());
+ String parameter = signature.substring(start, p).trim();
+ if (!parameter.equals()) {
+ params.add(parameter);
+ }
if (lastArg) {
break;
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote Request.java
remm2004/02/03 05:03:53
Modified:coyote/src/java/org/apache/coyote Request.java
Log:
- Hashtable - HashMap.
Revision ChangesPath
1.26 +3 -3
jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/Request.java
Index: Request.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/Request.java,v
retrieving revision 1.25
retrieving revision 1.26
diff -u -r1.25 -r1.26
--- Request.java 2 Dec 2003 23:01:00 - 1.25
+++ Request.java 3 Feb 2004 13:03:53 - 1.26
@@ -61,7 +61,7 @@
package org.apache.coyote;
import java.io.IOException;
-import java.util.Hashtable;
+import java.util.HashMap;
import org.apache.tomcat.util.buf.ByteChunk;
import org.apache.tomcat.util.buf.MessageBytes;
@@ -189,7 +189,7 @@
private MessageBytes remoteUser=new MessageBytes();
private MessageBytes authType=new MessageBytes();
-private Hashtable attributes=new Hashtable();
+private HashMap attributes=new HashMap();
private Response response;
private ActionHook hook;
@@ -432,7 +432,7 @@
attributes.put( name, o );
}
-public Hashtable getAttributes() {
+public HashMap getAttributes() {
return attributes;
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/handler HandlerManager.java TcHandler.java TcHandlerCtx.java
remm2004/02/03 05:12:16 Removed: util/java/org/apache/tomcat/util/handler HandlerManager.java TcHandler.java TcHandlerCtx.java Log: - Remove handlers. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Converting Coyote to Java2 collections
Bill Barker wrote: I suppose that Coyote can be optional for TC 3.3. I'm a bit less comfortable on using them in o.a.t.u (since that would force a Java2 requirement on 3.3). Stuff I'm considering for removal: - o.a.t.util.collections (except MultiMap - which might as well be merged into Parameters, BTW) - o.a.t.util.log (except SLH and CL) - o.a.t.util.mx (experiments for commons-modeler) - o.a.t.util.threads: Epirer, Reaper, ThreadPoolMX Of course, I'm only using TC 5, so ... ;) Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native2 CHANGES.txt
hgomez 2004/02/03 05:21:39 Modified:jk/native2 CHANGES.txt Log: Update changes to reflect changes on port (apr_port_t and def port) Revision ChangesPath 1.10 +4 -2 jakarta-tomcat-connectors/jk/native2/CHANGES.txt Index: CHANGES.txt === RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/CHANGES.txt,v retrieving revision 1.9 retrieving revision 1.10 diff -u -r1.9 -r1.10 --- CHANGES.txt 16 Oct 2003 07:51:26 - 1.9 +++ CHANGES.txt 3 Feb 2004 13:21:39 - 1.10 @@ -7,7 +7,9 @@ * Add hasinput method for channel, which will check if datas are available on input channel (TC-WEBSERVER). [Henri Gomez] - +* Make use apr_port_t instead of short to fix problem to have port higher than 32K. +* Make default port configurable (9009 on Netware, 8009 elsewhere) + Changes with JK2 2.0.4: * Added the load balancer stickySession property. If set to 0 requests with servlet SESSION ID's can be routed to any Tomcat - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [PATCH] Bug 26628
Ronald Wildenberg wrote: Attached the patch file I created for bug 26628, concerning the class org.apache.jasper.compiler.Validator. Too late ;) The patch isn't perfect: it wouldn't complain about something like ( , , ,,,). This is not a big problem obviously, so I'm not very motivated to fix it (but Kin-Man might be). Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_channel_socket.c
From: mmanders Modified:jk/native2/common jk_channel_socket.c Log: Fix problem with port higher than 32K. Provided by Guenter Knauf. Fixed compile problem for NetWare even though this isn't built for NetWare (or any other platform.) jk_channel_socket is depriciated, and it won't compile at all. at line 74 you have: #error jk_channel_socket is deprecated the entire file should be removed from CVS. MT. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_channel_socket.c
+1. Two reasons I haven't 1. I'm not a CVS expert and don't want to screw it up :-) 2. The only reason I patched it was because someone else (Henri I believe) was concerned about removing it and this was a more conservative approach. I did comment out that line to make sure that it would compile, but left it active when I checked it in. Mike Anderson [EMAIL PROTECTED] 2/3/2004 8:11:34 AM From: mmanders Modified:jk/native2/common jk_channel_socket.c Log: Fix problem with port higher than 32K. Provided by Guenter Knauf. Fixed compile problem for NetWare even though this isn't built for NetWare (or any other platform.) jk_channel_socket is depriciated, and it won't compile at all. at line 74 you have: #error jk_channel_socket is deprecated the entire file should be removed from CVS. MT. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_channel_socket.c
Mike Anderson a écrit : +1. Two reasons I haven't 1. I'm not a CVS expert and don't want to screw it up :-) 2. The only reason I patched it was because someone else (Henri I believe) was concerned about removing it and this was a more conservative approach. I did comment out that line to make sure that it would compile, but left it active when I checked it in. Ok, I remove it from CVS right now :) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native2/jni jkjni.dsp
hgomez 2004/02/03 07:28:25 Modified:jk/native2/server/apache13 mod_jk2.dsp jk/native2/server/isapi isapi.dsp jk/native2/server/aolserver nsjk2.dsp jk/native2/jni jkjni.dsp Removed: jk/native2/common jk_channel_socket.c Log: Remove obsolete jk_channel_socket.c Revision ChangesPath 1.4 +0 -4 jakarta-tomcat-connectors/jk/native2/server/apache13/mod_jk2.dsp Index: mod_jk2.dsp === RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/server/apache13/mod_jk2.dsp,v retrieving revision 1.3 retrieving revision 1.4 diff -u -r1.3 -r1.4 --- mod_jk2.dsp 3 May 2003 18:09:26 - 1.3 +++ mod_jk2.dsp 3 Feb 2004 15:28:25 - 1.4 @@ -162,10 +162,6 @@ # End Source File # Begin Source File -SOURCE=..\..\common\jk_channel_socket.c -# End Source File -# Begin Source File - SOURCE=..\..\common\jk_channel_un.c # End Source File # Begin Source File 1.23 +406 -410 jakarta-tomcat-connectors/jk/native2/server/isapi/isapi.dsp Index: isapi.dsp === RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/server/isapi/isapi.dsp,v retrieving revision 1.22 retrieving revision 1.23 diff -u -r1.22 -r1.23 --- isapi.dsp 30 Oct 2003 20:14:33 - 1.22 +++ isapi.dsp 3 Feb 2004 15:28:25 - 1.23 @@ -1,410 +1,406 @@ -# Microsoft Developer Studio Project File - Name=isapi - Package Owner=4 -# Microsoft Developer Studio Generated Build File, Format Version 6.00 -# ** DO NOT EDIT ** - -# TARGTYPE Win32 (x86) Dynamic-Link Library 0x0102 - -CFG=isapi - Win32 Debug -!MESSAGE This is not a valid makefile. To build this project using NMAKE, -!MESSAGE use the Export Makefile command and run -!MESSAGE -!MESSAGE NMAKE /f isapi.mak. -!MESSAGE -!MESSAGE You can specify a configuration when running NMAKE -!MESSAGE by defining the macro CFG on the command line. For example: -!MESSAGE -!MESSAGE NMAKE /f isapi.mak CFG=isapi - Win32 Debug -!MESSAGE -!MESSAGE Possible choices for configuration are: -!MESSAGE -!MESSAGE isapi - Win32 Debug (based on Win32 (x86) Dynamic-Link Library) -!MESSAGE isapi - Win32 Release (based on Win32 (x86) Dynamic-Link Library) -!MESSAGE - -# Begin Project -# PROP AllowPerConfigDependencies 0 -# PROP Scc_ProjName -# PROP Scc_LocalPath -CPP=cl.exe -MTL=midl.exe -RSC=rc.exe - -!IF $(CFG) == isapi - Win32 Debug - -# PROP BASE Use_MFC 0 -# PROP BASE Use_Debug_Libraries 1 -# PROP BASE Output_Dir DebugS -# PROP BASE Intermediate_Dir DebugS -# PROP BASE Ignore_Export_Lib 0 -# PROP BASE Target_Dir -# PROP Use_MFC 0 -# PROP Use_Debug_Libraries 1 -# PROP Output_Dir Debug -# PROP Intermediate_Dir Debug -# PROP Ignore_Export_Lib 0 -# PROP Target_Dir -# ADD BASE CPP /nologo /MTd /W3 /Gm /GX /ZI /Od /I ..\..\include /I $(JAVA_HOME)\include /I $(JAVA_HOME)\include\win32 /I $(APACHE2_HOME)\include /I $(APACHE2_HOME)\os\win32 /D WIN32 /D _DEBUG /D _WINDOWS /D _MBCS /D _USRDLL /D ISAPI_EXPORTS /D HAVE_JNI /D HAS_APR /FR /YX /FD /GZ /c -# ADD CPP /nologo /MDd /W3 /Gm /GX /ZI /Od /I ..\..\include /I $(JAVA_HOME)\include /I $(JAVA_HOME)\include\win32 /I ..\..\srclib\apr\include /I ..\..\srclib\apr-util\include /I ..\..\srclib\apr-iconv\include /I ..\..\srclib\pcre /D _DEBUG /D APR_DECLARE_STATIC /D APU_DECLARE_STATIC /D API_DECLARE_STATIC /D WIN32 /D _WINDOWS /D _MBCS /D _USRDLL /D ISAPI_EXPORTS /D HAVE_JNI /D HAS_APR /D HAS_PCRE /FR /YX /FD /GZ /c -# ADD BASE MTL /nologo /D _DEBUG /mktyplib203 /win32 -# ADD MTL /nologo /D _DEBUG /mktyplib203 /win32 -# ADD BASE RSC /l 0x409 /d _DEBUG -# ADD RSC /l 0x409 /d _DEBUG -BSC32=bscmake.exe -# ADD BASE BSC32 /nologo -# ADD BSC32 /nologo -LINK32=link.exe -# ADD BASE LINK32 libapr.lib libaprutil.lib wsock32.lib advapi32.lib /nologo /dll /debug /machine:I386 /out:Debug/isapi_redirector2.dll /pdbtype:sept /libpath:$(APACHE2_HOME)\lib -# SUBTRACT BASE LINK32 /nodefaultlib -# ADD LINK32 apr.lib aprutil.lib apriconv.lib ws2_32.lib wsock32.lib advapi32.lib pcre.lib pcreposix.lib /nologo /dll /debug /machine:I386 /out:Debug/isapi_redirector2.dll /pdbtype:sept /libpath:..\..\srclib\apr\libD /libpath:..\..\srclib\apr-util\libD /libpath:..\..\srclib\apr-iconv\libD /libpath:..\..\srclib\pcre\libD -# SUBTRACT LINK32 /nodefaultlib - -!ELSEIF $(CFG) == isapi - Win32 Release - -# PROP BASE Use_MFC 0 -# PROP BASE Use_Debug_Libraries 0 -# PROP BASE Output_Dir Release -# PROP BASE Intermediate_Dir Release -# PROP BASE Ignore_Export_Lib 0 -# PROP BASE Target_Dir -# PROP Use_MFC 0 -# PROP Use_Debug_Libraries 0 -# PROP Output_Dir Release -# PROP Intermediate_Dir Release -# PROP Ignore_Export_Lib 0 -# PROP Target_Dir -# ADD
jk2 2.0.4 release plan
Hi to all, Since many people ask for a jk2 release, 2.0.4, I'll act as release manager if nobody else want to take the job before Friday. I'd like to know what are showstoppers (blocking bugs) which should be fixed in the current release. Planning : Up to Friday 6 Feb, determine all bugs which should (could be fixed) and try to fix the blocking bugs. On Thursday 12 Feb, tag the CVS with jk2_2_0_4_rc1, make build and tests. If everything goes fine, on 13 Feb, tag the CVS with jk2_2_0_4, make tarball, and binaries (need help here for windows, netware, macosx, ...). Comments welcome - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: jk2 2.0.4 release plan
Henri Gomez wrote: Hi to all, Since many people ask for a jk2 release, 2.0.4, I'll act as release manager if nobody else want to take the job before Friday. I'd like to know what are showstoppers (blocking bugs) which should be fixed in the current release. Planning : Up to Friday 6 Feb, determine all bugs which should (could be fixed) and try to fix the blocking bugs. On Thursday 12 Feb, tag the CVS with jk2_2_0_4_rc1, make build and tests. If everything goes fine, on 13 Feb, tag the CVS with jk2_2_0_4, make tarball, and binaries (need help here for windows, netware, macosx, ...). +1, great :) As for the issues I have with mod_jk 2: - From the feedback I got from support issues, it seems LB only works with the worker MPM on Apache 2. With the default MPM (which is threaded I think), all requests go to the first node (but failover works fine, that's already something). (maybe this has been fixed already) - Failover with POST requests also seems to have issues (although it's definitely something complex, and since buffering is needed, we may not want to fix this issue). There's the exact same problem with HTTP LB, obviously. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_channel_socket.c
Henri Gomez wrote: Mike Anderson a écrit : +1. Two reasons I haven't 1. I'm not a CVS expert and don't want to screw it up :-) 2. The only reason I patched it was because someone else (Henri I believe) was concerned about removing it and this was a more conservative approach. I did comment out that line to make sure that it would compile, but left it active when I checked it in. Ok, I remove it from CVS right now :) I am too slow... :-) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: [PATCH] Bug 26628
-Oorspronkelijk bericht- Van: Remy Maucherat [mailto:[EMAIL PROTECTED] Onderwerp: Re: [PATCH] Bug 26628 Ronald Wildenberg wrote: Attached the patch file I created for bug 26628, concerning the class org.apache.jasper.compiler.Validator. Too late ;) The patch isn't perfect: it wouldn't complain about something like ( , , ,,,). This is not a big problem obviously, so I'm not very motivated to fix it (but Kin-Man might be). Too late indeed :) There is no need to complain about a syntax like ( , ,,) at this point of execution. The goal of the method is to extract parameters from the method signature. If these parameters are wrong, as in your example, someone will complain about it later on. However, if no parameters were meant to be found, then this method should not add any to the list (and certainly not the parameter ). Rémy Ronald - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_pool.c
jfclere 2004/02/03 08:17:24 Removed: jk/native2/common jk_pool.c Log: Remove depricated file. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_channel_socket.c
jean-frederic clere a écrit : Henri Gomez wrote: Mike Anderson a écrit : +1. Two reasons I haven't 1. I'm not a CVS expert and don't want to screw it up :-) 2. The only reason I patched it was because someone else (Henri I believe) was concerned about removing it and this was a more conservative approach. I did comment out that line to make sure that it would compile, but left it active when I checked it in. Ok, I remove it from CVS right now :) I am too slow... :-) Next time you pay me a beer :) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: jk2 2.0.4 release plan
Hi, Since many people ask for a jk2 release, 2.0.4, I'll act as release manager if nobody else want to take the job before Friday. great, thanks! Comments welcome two things I would like to discuss: 1) I would like to see all binaries packed to tar.gz or zip; this is definitely better in two ways: the original file timestamp keeps intact, and if the download is broken normally the archiver reports that. Oh, I've just checked, and this is only true for win32 and netware with mod_jk, with mod_jk2 win32 has zip... please Mike, can you put up zip files instead of renamed NLMs - also with future mod_jk releases? 2) ask for a reason why the file extension was not changed to .so on Win32 when Apache 1.3.15 moved to this...? thanks, Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native2/jni jkjni.dsp
hgomez 2004/02/03 08:27:56 Modified:jk/native2/server/apache13 mod_jk2.dsp jk/native2/server/isapi isapi.dsp jk/native2/server/aolserver nsjk2.dsp jk/native2/jni jkjni.dsp Log: Remove ref to jk_pool.c (just removed by JFC). I win another beer ;) Revision ChangesPath 1.5 +0 -4 jakarta-tomcat-connectors/jk/native2/server/apache13/mod_jk2.dsp Index: mod_jk2.dsp === RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/server/apache13/mod_jk2.dsp,v retrieving revision 1.4 retrieving revision 1.5 diff -u -r1.4 -r1.5 --- mod_jk2.dsp 3 Feb 2004 15:28:25 - 1.4 +++ mod_jk2.dsp 3 Feb 2004 16:27:56 - 1.5 @@ -234,10 +234,6 @@ # End Source File # Begin Source File -SOURCE=..\..\common\jk_pool.c -# End Source File -# Begin Source File - SOURCE=..\..\common\jk_pool_apr.c # End Source File # Begin Source File 1.24 +0 -4 jakarta-tomcat-connectors/jk/native2/server/isapi/isapi.dsp Index: isapi.dsp === RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/server/isapi/isapi.dsp,v retrieving revision 1.23 retrieving revision 1.24 diff -u -r1.23 -r1.24 --- isapi.dsp 3 Feb 2004 15:28:25 - 1.23 +++ isapi.dsp 3 Feb 2004 16:27:56 - 1.24 @@ -192,10 +192,6 @@ # End Source File # Begin Source File -SOURCE=..\..\common\jk_pool.c -# End Source File -# Begin Source File - SOURCE=..\..\common\jk_pool_apr.c # End Source File # Begin Source File 1.3 +0 -4 jakarta-tomcat-connectors/jk/native2/server/aolserver/nsjk2.dsp Index: nsjk2.dsp === RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/server/aolserver/nsjk2.dsp,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- nsjk2.dsp 3 Feb 2004 15:28:25 - 1.2 +++ nsjk2.dsp 3 Feb 2004 16:27:56 - 1.3 @@ -296,10 +296,6 @@ # End Source File # Begin Source File -SOURCE=..\..\common\jk_pool.c -# End Source File -# Begin Source File - SOURCE=..\..\common\jk_pool_apr.c # End Source File # Begin Source File 1.7 +0 -4 jakarta-tomcat-connectors/jk/native2/jni/jkjni.dsp Index: jkjni.dsp === RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/jni/jkjni.dsp,v retrieving revision 1.6 retrieving revision 1.7 diff -u -r1.6 -r1.7 --- jkjni.dsp 3 Feb 2004 15:28:25 - 1.6 +++ jkjni.dsp 3 Feb 2004 16:27:56 - 1.7 @@ -176,10 +176,6 @@ # End Source File # Begin Source File -SOURCE=..\common\jk_pool.c -# End Source File -# Begin Source File - SOURCE=..\common\jk_pool_apr.c # End Source File # Begin Source File - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: jk2 2.0.4 release plan
Günter Knauf a écrit : Hi, Since many people ask for a jk2 release, 2.0.4, I'll act as release manager if nobody else want to take the job before Friday. great, thanks! Comments welcome two things I would like to discuss: 1) I would like to see all binaries packed to tar.gz or zip; Well it could be done easily, if nobody object, I'll choose .gz for Unixes and .zip for Windows. this is definitely better in two ways: the original file timestamp keeps intact, and if the download is broken normally the archiver reports that. Oh, I've just checked, and this is only true for win32 and netware with mod_jk, with mod_jk2 win32 has zip... please Mike, can you put up zip files instead of renamed NLMs - also with future mod_jk releases? 2) ask for a reason why the file extension was not changed to .so on Win32 when Apache 1.3.15 moved to this...? Do you want it to revert to .dll ? On my Windows box the Apache 2.0.47 came with module named .so and not .dll. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: jk2 2.0.4 release plan
I'll be happy to deliver zips instead of NLMS. for NetWare. Henri (and others) since we are tagging and releasing jk2 can/should we do the same for jk since I know there is added functionality (Ping/Pong and timeouts) there as well? Thanks, Mike Anderson [EMAIL PROTECTED] 2/3/2004 9:27:14 AM Hi, Since many people ask for a jk2 release, 2.0.4, I'll act as release manager if nobody else want to take the job before Friday. great, thanks! Comments welcome two things I would like to discuss: 1) I would like to see all binaries packed to tar.gz or zip; this is definitely better in two ways: the original file timestamp keeps intact, and if the download is broken normally the archiver reports that. Oh, I've just checked, and this is only true for win32 and netware with mod_jk, with mod_jk2 win32 has zip... please Mike, can you put up zip files instead of renamed NLMs - also with future mod_jk releases? 2) ask for a reason why the file extension was not changed to .so on Win32 when Apache 1.3.15 moved to this...? thanks, Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: jk2 2.0.4 release plan
I think Guenter is asking that we change mod_jk2 do be .so. Right now we build a .dll (at least if we build from the project files) but it would be easy to change this to .so and I'd be happy to do it. Mike Anderson [EMAIL PROTECTED] 2/3/2004 9:57:00 AM Günter Knauf a écrit : Hi, Since many people ask for a jk2 release, 2.0.4, I'll act as release manager if nobody else want to take the job before Friday. great, thanks! Comments welcome two things I would like to discuss: 1) I would like to see all binaries packed to tar.gz or zip; Well it could be done easily, if nobody object, I'll choose .gz for Unixes and .zip for Windows. this is definitely better in two ways: the original file timestamp keeps intact, and if the download is broken normally the archiver reports that. Oh, I've just checked, and this is only true for win32 and netware with mod_jk, with mod_jk2 win32 has zip... please Mike, can you put up zip files instead of renamed NLMs - also with future mod_jk releases? 2) ask for a reason why the file extension was not changed to .so on Win32 when Apache 1.3.15 moved to this...? Do you want it to revert to .dll ? On my Windows box the Apache 2.0.47 came with module named .so and not .dll. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: jk2 2.0.4 release plan
Mike Anderson a écrit : I'll be happy to deliver zips instead of NLMS. for NetWare. Henri (and others) since we are tagging and releasing jk2 can/should we do the same for jk since I know there is added functionality (Ping/Pong and timeouts) there as well? Well, one release at a time, users urge us for jk2 release, jk release could wait some time (Bill ?) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Converting Coyote to Java2 collections
As long as they go back to j-t (esp. Expirer Reaper), I'm +1. - Original Message - From: Remy Maucherat [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Tuesday, February 03, 2004 5:14 AM Subject: Re: Converting Coyote to Java2 collections Bill Barker wrote: I suppose that Coyote can be optional for TC 3.3. I'm a bit less comfortable on using them in o.a.t.u (since that would force a Java2 requirement on 3.3). Stuff I'm considering for removal: - o.a.t.util.collections (except MultiMap - which might as well be merged into Parameters, BTW) - o.a.t.util.log (except SLH and CL) - o.a.t.util.mx (experiments for commons-modeler) - o.a.t.util.threads: Epirer, Reaper, ThreadPoolMX Of course, I'm only using TC 5, so ... ;) Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments. In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_channel_socket.c
Henri Gomez wrote: jean-frederic clere a écrit : Henri Gomez wrote: Mike Anderson a écrit : +1. Two reasons I haven't 1. I'm not a CVS expert and don't want to screw it up :-) 2. The only reason I patched it was because someone else (Henri I believe) was concerned about removing it and this was a more conservative approach. I did comment out that line to make sure that it would compile, but left it active when I checked it in. Ok, I remove it from CVS right now :) I am too slow... :-) Next time you pay me a beer :) No problems :-)) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet JspServlet.java
remm2004/02/03 09:31:40
Modified:jasper2/src/share/org/apache/jasper/servlet JspServlet.java
Log:
- Fix logging level.
Revision ChangesPath
1.32 +5 -5
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet/JspServlet.java
Index: JspServlet.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet/JspServlet.java,v
retrieving revision 1.31
retrieving revision 1.32
diff -u -r1.31 -r1.32
--- JspServlet.java 10 Sep 2003 01:47:24 - 1.31
+++ JspServlet.java 3 Feb 2004 17:31:40 - 1.32
@@ -240,8 +240,8 @@
while (e.hasMoreElements()) {
String name = (String) e.nextElement();
-log.info(\t\t + name + = +
- request.getParameter(name));
+log.debug(\t\t + name + =
+ + request.getParameter(name));
}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: Converting Coyote to Java2 collections
Bill Barker wrote: As long as they go back to j-t (esp. Expirer Reaper), I'm +1. I can leave those two classes, no problem. It's not as if they were really big. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler TagLibraryInfoImpl.java
luehe 2004/02/03 12:20:19
Modified:jasper2/src/share/org/apache/jasper/compiler
TagLibraryInfoImpl.java
Log:
Convert selected tag attribute types to their Fully-Qualified-Name
equivalents if the taglib is JSP 1.2 based.
This has been discussed with Mark Roth, the JSP spec lead, and will
allow JSP 1.2 taglibs to continue to work on Tomcat 5. Notice that JSP
1.2 did not require that tag attribute types be specified using their
fully-qualified class names. This restriction was added in Tomcat 5.
Revision ChangesPath
1.52 +22 -7
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/TagLibraryInfoImpl.java
Index: TagLibraryInfoImpl.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/TagLibraryInfoImpl.java,v
retrieving revision 1.51
retrieving revision 1.52
diff -u -r1.51 -r1.52
--- TagLibraryInfoImpl.java 7 Jan 2004 00:37:47 - 1.51
+++ TagLibraryInfoImpl.java 3 Feb 2004 20:20:19 - 1.52
@@ -288,7 +288,7 @@
else if (validator.equals(tname))
this.tagLibraryValidator = createValidator(element);
else if (tag.equals(tname))
-tagVector.addElement(createTagInfo(element));
+tagVector.addElement(createTagInfo(element, jspversion));
else if (tag-file.equals(tname)) {
TagFileInfo tagFileInfo = createTagFileInfo(element, uri,
jarFileUrl);
@@ -382,7 +382,9 @@
return location;
}
-private TagInfo createTagInfo(TreeNode elem) throws JasperException {
+private TagInfo createTagInfo(TreeNode elem, String jspVersion)
+throws JasperException {
+
String tagName = null;
String tagClassName = null;
String teiClassName = null;
@@ -430,7 +432,7 @@
} else if (variable.equals(tname)) {
variableVector.addElement(createVariable(element));
} else if (attribute.equals(tname)) {
-attributeVector.addElement(createAttribute(element));
+attributeVector.addElement(createAttribute(element, jspVersion));
} else if (dynamic-attributes.equals(tname)) {
dynamicAttributes = JspUtil.booleanValue(element.getBody());
} else if (example.equals(tname)) {
@@ -526,7 +528,7 @@
return new TagFileInfo(name, path, tagInfo);
}
-TagAttributeInfo createAttribute(TreeNode elem) {
+TagAttributeInfo createAttribute(TreeNode elem, String jspVersion) {
String name = null;
String type = null;
boolean required = false, rtexprvalue = false, reqTime = false,
@@ -549,6 +551,19 @@
rtexprvalue = JspUtil.booleanValue(s);
} else if (type.equals(tname)) {
type = element.getBody();
+if (1.2.equals(jspVersion)
+ (type.equals(Boolean)
+|| type.equals(Byte)
+|| type.equals(Character)
+|| type.equals(Double)
+|| type.equals(Float)
+|| type.equals(Integer)
+|| type.equals(Long)
+|| type.equals(Object)
+|| type.equals(Short)
+|| type.equals(String))) {
+type = java.lang. + type;
+}
} else if (fragment.equals(tname)) {
String s = element.getBody();
if (s != null)
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler TagLibraryInfoImpl.java
[EMAIL PROTECTED] wrote:
luehe 2004/02/03 12:20:19
Modified:jasper2/src/share/org/apache/jasper/compiler
TagLibraryInfoImpl.java
Log:
Convert selected tag attribute types to their Fully-Qualified-Name
equivalents if the taglib is JSP 1.2 based.
This has been discussed with Mark Roth, the JSP spec lead, and will
allow JSP 1.2 taglibs to continue to work on Tomcat 5. Notice that JSP
1.2 did not require that tag attribute types be specified using their
fully-qualified class names. This restriction was added in Tomcat 5.
I meant: JSP 2.0.
Jan
Revision ChangesPath
1.52 +22 -7 jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/TagLibraryInfoImpl.java
Index: TagLibraryInfoImpl.java
===
RCS file: /home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/TagLibraryInfoImpl.java,v
retrieving revision 1.51
retrieving revision 1.52
diff -u -r1.51 -r1.52
--- TagLibraryInfoImpl.java 7 Jan 2004 00:37:47 - 1.51
+++ TagLibraryInfoImpl.java 3 Feb 2004 20:20:19 - 1.52
@@ -288,7 +288,7 @@
else if (validator.equals(tname))
this.tagLibraryValidator = createValidator(element);
else if (tag.equals(tname))
-tagVector.addElement(createTagInfo(element));
+tagVector.addElement(createTagInfo(element, jspversion));
else if (tag-file.equals(tname)) {
TagFileInfo tagFileInfo = createTagFileInfo(element, uri,
jarFileUrl);
@@ -382,7 +382,9 @@
return location;
}
-private TagInfo createTagInfo(TreeNode elem) throws JasperException {
+private TagInfo createTagInfo(TreeNode elem, String jspVersion)
+throws JasperException {
+
String tagName = null;
String tagClassName = null;
String teiClassName = null;
@@ -430,7 +432,7 @@
} else if (variable.equals(tname)) {
variableVector.addElement(createVariable(element));
} else if (attribute.equals(tname)) {
-attributeVector.addElement(createAttribute(element));
+attributeVector.addElement(createAttribute(element, jspVersion));
} else if (dynamic-attributes.equals(tname)) {
dynamicAttributes = JspUtil.booleanValue(element.getBody());
} else if (example.equals(tname)) {
@@ -526,7 +528,7 @@
return new TagFileInfo(name, path, tagInfo);
}
-TagAttributeInfo createAttribute(TreeNode elem) {
+TagAttributeInfo createAttribute(TreeNode elem, String jspVersion) {
String name = null;
String type = null;
boolean required = false, rtexprvalue = false, reqTime = false,
@@ -549,6 +551,19 @@
rtexprvalue = JspUtil.booleanValue(s);
} else if (type.equals(tname)) {
type = element.getBody();
+if (1.2.equals(jspVersion)
+ (type.equals(Boolean)
+|| type.equals(Byte)
+|| type.equals(Character)
+|| type.equals(Double)
+|| type.equals(Float)
+|| type.equals(Integer)
+|| type.equals(Long)
+|| type.equals(Object)
+|| type.equals(Short)
+|| type.equals(String))) {
+type = java.lang. + type;
+}
} else if (fragment.equals(tname)) {
String s = element.getBody();
if (s != null)
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
luehe 2004/02/03 12:28:56
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
Reverted change that was done in revision 1.34
Revision ChangesPath
1.35 +4 -4
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/PoolTcpEndpoint.java
Index: PoolTcpEndpoint.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/PoolTcpEndpoint.java,v
retrieving revision 1.34
retrieving revision 1.35
diff -u -r1.34 -r1.35
--- PoolTcpEndpoint.java 2 Feb 2004 23:08:29 - 1.34
+++ PoolTcpEndpoint.java 3 Feb 2004 20:28:56 - 1.35
@@ -633,7 +633,7 @@
}
} catch (Throwable t) {
if (step == 2) {
-PoolTcpEndpoint.log.error(Handshake failed, t);
+PoolTcpEndpoint.log.debug(Handshake failed, t);
} else {
PoolTcpEndpoint.log.error(Unexpected error, t);
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler TagLibraryInfoImpl.java
Jan Luehe wrote:
[EMAIL PROTECTED] wrote:
luehe 2004/02/03 12:20:19
Modified:jasper2/src/share/org/apache/jasper/compiler
TagLibraryInfoImpl.java
Log:
Convert selected tag attribute types to their Fully-Qualified-Name
equivalents if the taglib is JSP 1.2 based.
This has been discussed with Mark Roth, the JSP spec lead, and will
allow JSP 1.2 taglibs to continue to work on Tomcat 5. Notice that JSP
1.2 did not require that tag attribute types be specified using their
fully-qualified class names. This restriction was added in Tomcat 5.
I meant: JSP 2.0.
Just to be clear: I meant the restriction was added to JSP 2.0
(and implemented by Tomcat 5, of course).
Sorry if there was any confusion. :)
Jan
Jan
Revision ChangesPath
1.52 +22 -7
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/TagLibraryInfoImpl.java
Index: TagLibraryInfoImpl.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/TagLibraryInfoImpl.java,v
retrieving revision 1.51
retrieving revision 1.52
diff -u -r1.51 -r1.52
--- TagLibraryInfoImpl.java7 Jan 2004 00:37:47 -1.51
+++ TagLibraryInfoImpl.java3 Feb 2004 20:20:19 -1.52
@@ -288,7 +288,7 @@
else if (validator.equals(tname))
this.tagLibraryValidator = createValidator(element);
else if (tag.equals(tname))
-tagVector.addElement(createTagInfo(element));
+tagVector.addElement(createTagInfo(element,
jspversion));
else if (tag-file.equals(tname)) {
TagFileInfo tagFileInfo =
createTagFileInfo(element, uri,
jarFileUrl);
@@ -382,7 +382,9 @@
return location;
}
-private TagInfo createTagInfo(TreeNode elem) throws
JasperException {
+private TagInfo createTagInfo(TreeNode elem, String jspVersion)
+throws JasperException {
+
String tagName = null;
String tagClassName = null;
String teiClassName = null;
@@ -430,7 +432,7 @@
} else if (variable.equals(tname)) {
variableVector.addElement(createVariable(element));
} else if (attribute.equals(tname)) {
-attributeVector.addElement(createAttribute(element));
+attributeVector.addElement(createAttribute(element,
jspVersion));
} else if (dynamic-attributes.equals(tname)) {
dynamicAttributes =
JspUtil.booleanValue(element.getBody());
} else if (example.equals(tname)) {
@@ -526,7 +528,7 @@
return new TagFileInfo(name, path, tagInfo);
}
-TagAttributeInfo createAttribute(TreeNode elem) {
+TagAttributeInfo createAttribute(TreeNode elem, String
jspVersion) {
String name = null;
String type = null;
boolean required = false, rtexprvalue = false, reqTime =
false,
@@ -549,6 +551,19 @@
rtexprvalue = JspUtil.booleanValue(s);
} else if (type.equals(tname)) {
type = element.getBody();
+if (1.2.equals(jspVersion)
+ (type.equals(Boolean)
+|| type.equals(Byte)
+|| type.equals(Character)
+|| type.equals(Double)
+|| type.equals(Float)
+|| type.equals(Integer)
+|| type.equals(Long)
+|| type.equals(Object)
+|| type.equals(Short)
+|| type.equals(String))) {
+type = java.lang. + type;
+}
} else if (fragment.equals(tname)) {
String s = element.getBody();
if (s != null)
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: Jakarta Collections 3.0?
Craig R. McClanahan wrote: Subscribers to COMMONS-DEV will see that I'm proposing to remove the dependency on [collections] from both [beanutils] and [digester]. Both dependencies are very thin, and doing this will avoid penalizing [beanutils]/[digester] customers for what [collections] did. Great! I'm feeling a bit guilty ( and I think other should too ) about missing the release vote for collections. Costin - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: jk2 2.0.4 release plan
Henri, What is the current state of JK2. Is it alpha, beta or GA. If this is going to be an alpha release, what is the plan for a GA release. I would like to migrate from JK when it is stable. Cheers. Dave. Henri Gomez wrote: Hi to all, Since many people ask for a jk2 release, 2.0.4, I'll act as release manager if nobody else want to take the job before Friday. I'd like to know what are showstoppers (blocking bugs) which should be fixed in the current release. Planning : Up to Friday 6 Feb, determine all bugs which should (could be fixed) and try to fix the blocking bugs. On Thursday 12 Feb, tag the CVS with jk2_2_0_4_rc1, make build and tests. If everything goes fine, on 13 Feb, tag the CVS with jk2_2_0_4, make tarball, and binaries (need help here for windows, netware, macosx, ...). Comments welcome - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- * Dave Oxley * * +44 (0)7966 249 344 * * * * [EMAIL PROTECTED] * * mailto:[EMAIL PROTECTED] * * * * http://www.daveoxley.co.uk * * http://www.daveoxley.co.uk * * Linux: Because reboots are for hardware upgrades! * * * * * - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: jk2 2.0.4 release plan
Dave Oxley wrote: Henri, What is the current state of JK2. Is it alpha, beta or GA. If this is going to be an alpha release, what is the plan for a GA release. I would like to migrate from JK when it is stable. This is a *very* good question. Last time I dared to ask the consensus was mod_jk was a better idea for a production system -- but there was a good deal of dissent on this question... -- Jess Holle - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Jakarta Collections 3.0?
Costin Manolache wrote: Craig R. McClanahan wrote: Subscribers to COMMONS-DEV will see that I'm proposing to remove the dependency on [collections] from both [beanutils] and [digester]. Both dependencies are very thin, and doing this will avoid penalizing [beanutils]/[digester] customers for what [collections] did. Great! I'm feeling a bit guilty ( and I think other should too ) about missing the release vote for collections. I agree: this would be great (too many cascading dependencies causing trouble in the end). Thx :) Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[GUMP@lsd]: jakarta-tomcat-5/jakarta-tomcat-5 failed
Project: jakarta-tomcat-5 State: Failed URL: http://lsd.student.utwente.nl/gump/jakarta-tomcat-5/jakarta-tomcat-5.html - G U M P Y Annotations: - Error - Failed with reason build failed - G U M P Y Work Name: build_jakarta-tomcat-5_jakarta-tomcat-5 (Type: Build) State: Failed Elapsed: 0 hours, 0 minutes, 49 seconds Command Line: java -Djava.awt.headless=true -Xbootclasspath/p:/data/gump/xml-xerces2/java/build/xercesImpl.jar:/data/gump/xml-xerces2/java/build/xmlParserAPIs.jar:/data/gump/xml-xalan/java/build/xalan-unbundled.jar:/data/gump/xml-commons/java/external/build/xml-apis.jar org.apache.tools.ant.Main -Dbuild.clonevm=true -Dgump.merge=/data/gump/gump/work/merge.xml -Dbuild.sysclasspath=only -Dtomcat33.home=*Unset* -Djsp-api.jar=/data/gump/jakarta-servletapi-5/jsr152/dist/lib/jsp-api.jar -Djndi.jar=/data/gump/opt/jndi1_2_1/lib/jndi.jar -Dcommons-launcher.jar=/data/gump/jakarta-commons/launcher/dist/bin/commons-launcher.jar -Dcommons-collections.jar=/data/gump/jakarta-commons/collections/build/commons-collections-20040204.jar -Djmx.jar=/data/gump/opt/jmx-1_2-ri/lib/jmxri.jar -Dactivation.home=/data/gump/opt/jaf-1.0.1 -Djmx.home=/data/gump/opt/jmx-1_2-ri -Dcommons-modeler.home=/data/gump/jakarta-commons/modeler -Djmx-tools.jar=/data/gump/opt/jmx-1_2-ri/lib/jmxtools.jar -Dregexp.jar=/data/gump/jakarta-regexp/build/jakarta-regexp-20040204.jar -Djasper.home=/data/gump/jakarta-tomcat-jasper_tc5/jasper2 -Dant.home=/data/gump/ant/dist -DxmlParserAPIs.jar=/data/gump/xml-xerces2/java/build/xercesImpl.jar -Djdbc20ext.jar=/data/gump/opt/jdbc2_0/jdbc2_0-stdext.jar -Dsite2.home=/data/gump/jakarta-site2 -Dcommons-daemon.jsvc.tar.gz=/data/gump/jakarta-commons/daemon/dist/bin/jsvc.tar.gz -Dldap.jar=/data/gump/opt/ldap-1_2_4/lib/ldap.jar -Dregexp.home=/data/gump/jakarta-regexp/build -Dcommons-beanutils.jar=/data/gump/jakarta-commons/beanutils/dist/commons-beanutils.jar -DxercesImpl.jar=/data/gump/xml-xerces2/java/build/xercesImpl.jar -Djsse.home=/data/gump/opt/jsse1.0.3 -Dcommons-pool.jar=/data/gump/jakarta-commons/pool/dist/commons-pool.jar -Dmail.home=/data/gump/opt/javamail-1.3 -Djndi.home=/data/gump/opt/jndi1_2_1 -Djaas.jar=/data/gump/opt/jaas1_0/lib/jaas.jar -Dtomcat-coyote.home=/data/gump/jakarta-tomcat-connectors/coyote -Dcommons-daemon.jar=/data/gump/jakarta-commons/daemon/dist/commons-daemon-20040204.jar -Dcommons-dbcp.jar=/data/gump/jakarta-commons/dbcp/dist/commons-dbcp.jar -Dtomcat-util.jar=/data/gump/jakarta-tomcat-connectors/util/build/lib/tomcat-util.jar -Dservlet-api.jar=/data/gump/jakarta-servletapi-5/jsr154/dist/lib/servlet-api.jar -Dcommons-logging-api.jar=/data/gump/jakarta-commons/logging/dist/commons-logging-api.jar -Dcommons-fileupload.jar=/data/gump/jakarta-commons/fileupload/target/commons-fileupload-20040204.jar -Dcommons-modeler.jar=/data/gump/jakarta-commons/modeler/dist/commons-modeler.jar -Dcommons-logging.jar=/data/gump/jakarta-commons/logging/dist/commons-logging.jar -Dcommons-el.jar=/data/gump/jakarta-commons/el/dist/commons-el.jar -Dcommons-digester.jar=/data/gump/jakarta-commons/digester/dist/commons-digester.jar -Dmail.jar=/data/gump/opt/javamail-1.3/mail.jar -Djta.jar=/data/gump/opt/jta-spec1_0_1/jta-spec1_0_1.jar -Dactivation.jar=/data/gump/opt/jaf-1.0.1/activation.jar gumpy-build [Working Directory: /data/gump/jakarta-tomcat-5] - deploy-prepare: [mkdir] Created dir: /data/gump/jakarta-tomcat-5/build/server/classes build-catalina-core: [javac] Compiling 324 source files to /data/gump/jakarta-tomcat-5/build/classes [javac] /data/gump/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector/RequestFacade.java:266: cannot resolve symbol [javac] symbol : method getRemotePort () [javac] location: interface javax.servlet.ServletRequest [javac] return request.getRemotePort(); [javac] ^ [javac] /data/gump/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector/RequestFacade.java:275: cannot resolve symbol [javac] symbol : method getLocalName () [javac] location: interface javax.servlet.ServletRequest [javac] return request.getLocalName(); [javac] ^ [javac] /data/gump/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector/RequestFacade.java:283: cannot resolve symbol [javac] symbol : method getLocalAddr () [javac] location: interface javax.servlet.ServletRequest [javac] return request.getLocalAddr(); [javac] ^ [javac] /data/gump/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector/RequestFacade.java:292: cannot resolve symbol [javac] symbol : method getLocalPort () [javac] location: interface javax.servlet.ServletRequest [javac] return
Edward Furlong/IE/TLS/PwC is out of the office.
I will be out of the office starting 02/02/2004 and will not return until 09/02/2004. I will respond to your message when I return. _ The information transmitted is intended only for the person or entity to which it is addressed and may contain confidential and/or privileged material. Any review, retransmission, dissemination or other use of, or taking of any action in reliance upon, this information by persons or entities other than the intended recipient is prohibited. If you received this in error, please contact the sender and delete the material from any computer. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[OT] Re: Edward Furlong/IE/TLS/PwC is out of the office.
Man, I hope this is a Canadian date. If this is American, we are going to get these for the next seven months. LOL. At 10:30 PM 2/3/2004, [EMAIL PROTECTED] wrote: I will be out of the office starting 02/02/2004 and will not return until 09/02/2004. I will respond to your message when I return. _ The information transmitted is intended only for the person or entity to which it is addressed and may contain confidential and/or privileged material. Any review, retransmission, dissemination or other use of, or taking of any action in reliance upon, this information by persons or entities other than the intended recipient is prohibited. If you received this in error, please contact the sender and delete the material from any computer. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
