cvs commit: jakarta-tomcat-connectors/jk/native2/server/isapi jk_service_iis.c

2004-02-28 Thread mturk
mturk   2004/02/28 00:12:43

  Modified:jk/native2/server/isapi jk_service_iis.c
  Log:
  Fix the POST data reads, rewriting service-read.
  The previous implementation was total mess, dealing with
  negative numbers to see if we read past the contol buffer,
  etc...
  
  Revision  ChangesPath
  1.27  +83 -49
jakarta-tomcat-connectors/jk/native2/server/isapi/jk_service_iis.c
  
  Index: jk_service_iis.c
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jk/native2/server/isapi/jk_service_iis.c,v
  retrieving revision 1.26
  retrieving revision 1.27
  diff -u -r1.26 -r1.27
  --- jk_service_iis.c  24 Feb 2004 08:44:42 -  1.26
  +++ jk_service_iis.c  28 Feb 2004 08:12:43 -  1.27
  @@ -43,7 +43,7 @@
   extern int send_groups;
   
   static int JK_METHOD jk2_service_iis_head(jk_env_t *env, jk_ws_service_t *s ){
  -static char crlf[3] = { (char)13, (char)10, '\0' };
  +static char crlf[3] = { '\r', '\n', '\0' };
   const char *reason;
   LPEXTENSION_CONTROL_BLOCK  lpEcb=(LPEXTENSION_CONTROL_BLOCK)s-ws_private;
   DWORD len_of_status;
  @@ -124,66 +124,100 @@
   }
   
   static int JK_METHOD jk2_service_iis_read(jk_env_t *env, jk_ws_service_t *s,
  -  void *b, unsigned len, unsigned 
*actually_read)
  +  void *b, unsigned int len,
  +  unsigned int *actually_read)
   {
  +
   env-l-jkLog(env, env-l, JK_LOG_DEBUG, 
  -  Into jk_ws_service_t::read\n);
  +  Into jk_ws_service_t::read\n);
   
  -if (s  s-ws_private  b  actually_read) {
  -LPEXTENSION_CONTROL_BLOCK  lpEcb=(LPEXTENSION_CONTROL_BLOCK)s-ws_private;
  +*actually_read = 0;
  +if (!len) {
  +env-l-jkLog(env, env-l, JK_LOG_INFO, 
  +  jk_ws_service_t::read, requested read length is zero\n);
  +return JK_OK;
  +}
  +if (s  s-ws_private  b) {
  +LPEXTENSION_CONTROL_BLOCK lpEcb = (LPEXTENSION_CONTROL_BLOCK)s-ws_private;
   
  -*actually_read = 0;
  -if ((s-content_read  (long)lpEcb-cbTotalBytes) !s-end_of_stream ){
  -if (len) {
  -char *buf = b;
  -long already_read = (long)lpEcb-cbAvailable - s-content_read;
  -  
  -if (already_read = (long)len) {
  -memcpy(buf, lpEcb-lpbData + s-content_read, len);
  -*actually_read = len;
  -} else {
  -/*
  - * Try to copy what we already have 
  - */
  -if (already_read  0) {
  -memcpy(buf, lpEcb-lpbData + s-content_read, already_read);
  -buf   += already_read;
  -len   -= already_read;
  -//s-content_read = lpEcb-cbAvailable;
  -
  -*actually_read = already_read;
  -}
  -if ((s-content_read+*actually_read)==lpEcb-cbTotalBytes) {
  -s-end_of_stream=JK_TRUE;
  -}
  -/*
  - * Now try to read from the client ...
  - */
  -if (!s-end_of_stream ) {
  -if ( lpEcb-ReadClient(lpEcb-ConnID, buf, len)) {
  -*actually_read +=  len;
  -} else {
  -env-l-jkLog(env,env-l, JK_LOG_ERROR, 
  -   jk_ws_service_t::read, ReadClient failed\n);
  -return JK_OK;
  -}
  -}
  +if (s-end_of_stream) {
  +env-l-jkLog(env, env-l, JK_LOG_INFO, 
  +  jk_ws_service_t::read, end of stram allready reached\n);
  +return JK_OK;
  +}
  +
  +if ((DWORD)s-content_read  lpEcb-cbTotalBytes) {
  +DWORD  rdlen, toread = len;
  +LPBYTE buff  = (LPBYTE)b;
  +
  +/* 
  + * Fix the read length in case the requested
  + * is larger then what's available
  + */
  +if (s-content_read + toread  lpEcb-cbTotalBytes)
  +toread = lpEcb-cbTotalBytes - s-content_read;
  +rdlen = toread;
  +
  +/* 
  + * First read the already sent data from the client
  + * No need to call the ReadClient fuction for the
  + * data held in the control buffer
  + */
  +if ((DWORD)s-content_read  lpEcb-cbAvailable) {
  +/* Read the avail buffer */
  +if (s-content_read + toread  lpEcb-cbAvailable)
  +toread = 

DO NOT REPLY [Bug 27310] New: - CLASSPATH reset in intialization script

2004-02-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=27310.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=27310

CLASSPATH reset in intialization script

   Summary: CLASSPATH reset in intialization script
   Product: Tomcat 5
   Version: 5.0.19
  Platform: PC
   URL: http://localhost:8080/soap/servlet/rpcrouter
OS/Version: Windows XP
Status: NEW
  Severity: Minor
  Priority: Other
 Component: Native:Integration
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


In order to specify jar libraries to load at startup I authored a setenv.bat
file and put it in /bin, however Tomcat consistently failed to use jar files
that were specified in the setenv.bat. I then carefully traced the setting of
the CLASSPATH through the multiple initialization scripts and found the
following line in setclasspath.bat:

set CLASSPATH=%JAVA_HOME%\lib\tools.jar

This line will wipe out the previous CLASSPATH that has been built up to this
point. I replcaed this line with:

set CLASSPATH=%CLASSPATH%;%JAVA_HOME%\lib\tools.jar

This can easily be tested. If you remove the soap.jar file from the /common/lib
directory, place it outside of the CATALINA_HOME directory, specify its location
in the CLASSPATH, and then try to hit localhost:8080/soap/servlet/rpcrouter,
Tomcat will complain. If you then fix the line mentioned above in
setclasspath.bat, and rerun Tomcat, it will run quite gracefully.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 15278] - [PATCH] mod_jk2 for IIS, Bugfix corrupted data ]

2004-02-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15278.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15278

[PATCH] mod_jk2 for IIS, Bugfix corrupted data ]

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2004-02-28 08:23 ---
Fixed in the CVS.
The current implementation is total rewrite of service-read.
It works for me (200K+ post data), so do not reopen this bug unless the
test case is provided.
The only thing I didn't test is when using _very_ slow connections, meaning
that the client is unable to provide 8192 bytes of data withing 60 second
interval. But IMO that's not the problem of this connector.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 22665] - isapi_redirector2.dll fails to load in IIS5

2004-02-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22665.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22665

isapi_redirector2.dll fails to load in IIS5

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2004-02-28 08:34 ---
Use the code from CVS, it works, and its been tested both on 2K and XP.
The 2.0.4 release should be released soon.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27310] - CLASSPATH reset in intialization script

2004-02-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=27310.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=27310

CLASSPATH reset in intialization script

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2004-02-28 08:34 ---
This behaviour is not a bug, it's a feature.

Tomcat replaces the CLASSPATH by design. This is intended behaviour.

If you wish to share the soap.jar file between your web apps, place the jar in 
the common/lib folder.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/jk/native2/server/isapi jk_isapi_plugin.c

2004-02-28 Thread mturk
mturk   2004/02/28 01:01:11

  Modified:jk/native2/server/isapi jk_isapi_plugin.c
  Log:
  Fix the Bug 14538.
  Use the url rewrite for non mapped url's that contain session path
  identifier.
  
  Revision  ChangesPath
  1.61  +9 -1  
jakarta-tomcat-connectors/jk/native2/server/isapi/jk_isapi_plugin.c
  
  Index: jk_isapi_plugin.c
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jk/native2/server/isapi/jk_isapi_plugin.c,v
  retrieving revision 1.60
  retrieving revision 1.61
  diff -u -r1.60 -r1.61
  --- jk_isapi_plugin.c 27 Feb 2004 19:28:51 -  1.60
  +++ jk_isapi_plugin.c 28 Feb 2004 09:01:11 -  1.61
  @@ -366,6 +366,14 @@
   SetHeader(pfc, Translate:, NULL);
   }
   } else {
  +char *jsessionid = strstr(uri, JK_PATH_SESSION_IDENTIFIER); 
  +if (jsessionid) {
  +env-l-jkLog(env, env-l,  JK_LOG_INFO, 
  +  HttpFilterProc removing session identifier 
[%s] for non servlet url\n, 
  +  jsessionid);
  +*jsessionid = '\0';
  +SetHeader(pfc, url, uri);
  +}
   env-l-jkLog(env, env-l,  JK_LOG_DEBUG, 
  HttpFilterProc [%s] is not a servlet url\n, 
  uri);
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 14538] - ISAPI filter does not remove the jsessionid parameter

2004-02-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14538.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14538

ISAPI filter does not remove the jsessionid parameter

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2004-02-28 09:03 ---
Fixed in the CVS...
We are using url rewrite for session path parameter.
The drawback is that ';jsessionid' will get removed from all requests
send to IIS not matched by jk2, but IMO that's OK.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationHttpRequest.java

2004-02-28 Thread remm
remm2004/02/28 02:56:53

  Modified:catalina/src/share/org/apache/catalina/core
ApplicationHttpRequest.java
  Log:
  - NPE fix if there's no local session.
  - Bug 27309.
  
  Revision  ChangesPath
  1.20  +3 -2  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationHttpRequest.java
  
  Index: ApplicationHttpRequest.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationHttpRequest.java,v
  retrieving revision 1.19
  retrieving revision 1.20
  diff -u -r1.19 -r1.20
  --- ApplicationHttpRequest.java   27 Feb 2004 14:58:42 -  1.19
  +++ ApplicationHttpRequest.java   28 Feb 2004 10:56:52 -  1.20
  @@ -496,7 +496,6 @@
   try {
   localSession =
   context.getManager().findSession(other.getId());
  -localSession.access();
   } catch (IOException e) {
   // Ignore
   }
  @@ -508,6 +507,8 @@
   localSession.setMaxInactiveInterval
   (context.getManager().getMaxInactiveInterval());
   localSession.setId(other.getId());
  +} else {
  +localSession.access();
   }
   session = localSession;
   return session.getSession();
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27309] - NPE in ApplicationHttpRequest.java:546

2004-02-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=27309.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=27309

NPE in ApplicationHttpRequest.java:546

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2004-02-28 11:04 ---
Sorry for the trouble. This is fixed now.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27307] - Suggestions to improve JNDI/DataSource Howto

2004-02-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=27307.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=27307

Suggestions to improve JNDI/DataSource Howto

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|Normal  |Enhancement



--- Additional Comments From [EMAIL PROTECTED]  2004-02-28 11:06 ---
Yes, please submit a patch.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 15688] - full-qualified names instead of imports

2004-02-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15688.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15688

full-qualified names instead of imports

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|Normal  |Enhancement



--- Additional Comments From [EMAIL PROTECTED]  2004-02-28 13:38 ---
There are several obvious workarounds if you experience problems of this type:
- use fully-qualified domain names rather than imports yourself;
- write the servlet directly.

I am changing this to an enhancement request although I doubt that there will 
be much enthusiasm to make the proposed changes.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 15688] - full-qualified names instead of imports

2004-02-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15688.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15688

full-qualified names instead of imports





--- Additional Comments From [EMAIL PROTECTED]  2004-02-28 14:01 ---
It would be cleverer to avoid problems, so think about it.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 15711] - build.xml line 321 uses invalid attribute

2004-02-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15711.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15711

build.xml line 321 uses invalid attribute

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2004-02-28 16:13 ---
This was fixed some time ago.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 15746] - Possible concurrency problem in StandardSession.recycle()

2004-02-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15746.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15746

Possible concurrency problem in StandardSession.recycle()

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2004-02-28 16:25 ---
Have you actually seen this happening? I have reviewed the code and can't 
identify any circumstances where this could occur. If I have missed the 
obvious, please re-open this report.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27315] New: - java.util.ConcurrentModificationException

2004-02-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=27315.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=27315

java.util.ConcurrentModificationException

   Summary: java.util.ConcurrentModificationException
   Product: Tomcat 4
   Version: 4.1.30
  Platform: PC
OS/Version: Other
Status: NEW
  Severity: Major
  Priority: Other
 Component: Connector:Coyote HTTP/1.1
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Hello,

I have recently upgraded from Tomcat 4.1.29 to 4.1.30, primarily to avoid bug 
#24970.  Since the upgraded, everything seems to work OK, but intermittently I 
get the following error:

java.util.ConcurrentModificationException
at java.util.AbstractList$Itr.checkForComodification
(AbstractList.java:448)
at java.util.AbstractList$Itr.next(AbstractList.java:419)
at java.util.AbstractCollection.remove(AbstractCollection.java:254)
at org.apache.coyote.RequestGroupInfo.removeRequestProcessor
(RequestGroupInfo.java:17)
at org.apache.coyote.RequestInfo.setGlobalProcessor(RequestInfo.java:96)
at org.apache.coyote.http11.Http11Protocol$MXPoolListener.threadEnd
(Http11Protocol.java:620)
at org.apache.tomcat.util.threads.ThreadPool.removeThread
(ThreadPool.java:279)
at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run
(ThreadPool.java:727)
at java.lang.Thread.run(Thread.java:534)

The system seems to operate OK even with this issue.  I have not made any 
change to my codebase since the upgrade from 4.1.29 to 4.1.30.

I would be grateful if anyone could shed any light on this issue.

Kind regards,

Minh Tran

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27310] - CLASSPATH reset in intialization script

2004-02-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=27310.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=27310

CLASSPATH reset in intialization script

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |



--- Additional Comments From [EMAIL PROTECTED]  2004-02-28 20:39 ---
  Providing the user/administrator a way to specify envirnoment variables is a
feature, erasing them afterwards is an engineering fault.

  If it IS a feature, it is woefully underengineered. The reinitialization of
the CLASSPATH happens very late in the startup process, after the CLASSPATH has
been amended by other scripts that are run earlier in the startup sequence.
Namely, it will rewrite the CLASSPATH after the setenv.bat file (if you specify
one) has been run. This means that if you change the CLASSPATH, an environment
variable, in the setenv.bat script, then your changes will be lost. It is quite
clear then that this can not be the desired function, namely; creating a special
hook in the startup sequence to allow you to change environment variables, and
then afterwards overwriting changes that were made. Obviously either the line in
setclasspath.bat needs to be altered as suggested, or the call to setenv.bat
moved farther along in the startup sequence after the offending line of code, or
the call to setenv.bat removed entirely.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27310] - CLASSPATH reset in intialization script

2004-02-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=27310.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=27310

CLASSPATH reset in intialization script

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||WONTFIX

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27307] - Suggestions to improve JNDI/DataSource Howto

2004-02-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=27307.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=27307

Suggestions to improve JNDI/DataSource Howto





--- Additional Comments From [EMAIL PROTECTED]  2004-02-29 02:02 ---
Created an attachment (id=10612)
Result of 'cvs diff -u' on directory jakarta-tomcat-catalina/webapps/docs

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27307] - Suggestions to improve JNDI/DataSource Howto

2004-02-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=27307.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=27307

Suggestions to improve JNDI/DataSource Howto





--- Additional Comments From [EMAIL PROTECTED]  2004-02-29 02:07 ---
Created an attachment (id=10613)
New patch with a warning about copying the JDBC driver jar

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27307] - Suggestions to improve JNDI/DataSource Howto

2004-02-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=27307.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=27307

Suggestions to improve JNDI/DataSource Howto





--- Additional Comments From [EMAIL PROTECTED]  2004-02-29 02:08 ---
Created an attachment (id=10614)
New howto after running ant

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27307] - Suggestions to improve JNDI/DataSource Howto

2004-02-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=27307.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=27307

Suggestions to improve JNDI/DataSource Howto





--- Additional Comments From [EMAIL PROTECTED]  2004-02-29 02:10 ---
Ok, patch added:

http://nagoya.apache.org/bugzilla/showattachment.cgi?attach_id=10613

And also a screenshot of the results:

http://nagoya.apache.org/bugzilla/showattachment.cgi?attach_id=10614

-- Felipe

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27276] - JAASCallbackHandler gives erroneous warning due to buggy implementation

2004-02-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=27276.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=27276

JAASCallbackHandler gives erroneous warning due to buggy implementation





--- Additional Comments From [EMAIL PROTECTED]  2004-02-29 02:45 ---
Something like this should do it.
$ diff JAASCallbackHandler.java{.orig,}
156,157c156,161
 ((PasswordCallback) callbacks[i]).setPassword
 (password.toCharArray());
---
 final char[] passwordcontents;
 if (password != null)
 passwordcontents = passowrd.toCharArray();
 else
 passwordcontents = new char[0];
 ((PasswordCallback) callbacks[i]).setPassword(passwordcontents
);

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[GUMP@lsd]: jakarta-tomcat-5/jakarta-tomcat-5 failed

2004-02-28 Thread bobh
To whom it may engage...

This is an automated request, but not an unsolicited one. For help 
understanding the request please visit 
http://jakarta.apache.org/gump/nagged.html, 
and/or contact [EMAIL PROTECTED]

Project jakarta-tomcat-5 has an issue affecting it's community integration, and has 
been outstanding for 8 runs. The current state is 'Failed', for reason 'Build Failed'

Full details are available at: 
http://lsd.student.utwente.nl/gump/jakarta-tomcat-5/jakarta-tomcat-5.html, however 
some snippets follow:

-  -  -  -  - -- --  G U M P

Gump provided these annotations:

 - Warning - Jar [/data3/gump/jakarta-tomcat-5/dist/server/lib/servlets-default.jar] 
identifier set to jar basename: [servlets-default.jar]
 - Warning - Jar [/data3/gump/jakarta-tomcat-5/dist/common/lib/naming-common.jar] 
identifier set to jar basename: [naming-common.jar]
 - Warning - Jar [/data3/gump/jakarta-tomcat-5/dist/common/lib/naming-resources.jar] 
identifier set to jar basename: [naming-resources.jar]
 - Warning - Jar [/data3/gump/jakarta-tomcat-5/dist/server/lib/catalina.jar] 
identifier set to jar basename: [catalina.jar]
 - Warning - Jar [/data3/gump/jakarta-tomcat-5/dist/bin/bootstrap.jar] identifier set 
to jar basename: [bootstrap.jar]
 - Warning - Jar [/data3/gump/jakarta-tomcat-5/dist/server/lib/servlets-common.jar] 
identifier set to jar basename: [servlets-common.jar]
 - Warning - Jar [/data3/gump/jakarta-tomcat-5/dist/server/lib/servlets-invoker.jar] 
identifier set to jar basename: [servlets-invoker.jar]
 - Info - Dependency on javamail exists, no need to add for property mail.jar.
 - Info - Dependency on jaf exists, no need to add for property activation.jar.
 - Info - Dependency on jakarta-servletapi-5-servlet exists, no need to add for 
property servlet-api.jar.
 - Info - Dependency on jakarta-servletapi-5-jsp exists, no need to add for property 
jsp-api.jar.
 - Info - Dependency on xml-xerces exists, no need to add for property xercesImpl.jar.
 - Info - Dependency on xml-xerces exists, no need to add for property 
xmlParserAPIs.jar.
 - Info - Dependency on jakarta-tomcat-util exists, no need to add for property 
tomcat-util.jar.
 - Info - Dependency on commons-el exists, no need to add for property commons-el.jar.
 - Info - Dependency on commons-logging exists, no need to add for property 
commons-logging-api.jar.
 - Info - Dependency on commons-modeler exists, no need to add for property 
commons-modeler.jar.
 - Info - Dependency on ant exists, no need to add for property ant.home.
 - Info - Dependency on jsse exists, no need to add for property jsse.home.
 - Info - Dependency on jmx exists, no need to add for property jmx.home.
 - Info - Dependency on jmx exists, no need to add for property jmx.jar.
 - Info - Dependency on jmx exists, no need to add for property jmx-tools.jar.
 - Info - Dependency on jndi exists, no need to add for property jndi.home.
 - Info - Dependency on jakarta-regexp exists, no need to add for property regexp.home.
 - Info - Dependency on jakarta-regexp exists, no need to add for property regexp.jar.
 - Info - Dependency on javamail exists, no need to add for property mail.home.
 - Info - Dependency on jakarta-tomcat-coyote exists, no need to add for property 
tomcat-coyote.home.
 - Info - Dependency on jakarta-tomcat-jasper_tc5 exists, no need to add for property 
jasper.home.
 - Info - Dependency on jaf exists, no need to add for property activation.home.
 - Info - Dependency on commons-modeler exists, no need to add for property 
commons-modeler.home.
 - Info - Dependency on commons-daemon exists, no need to add for property 
commons-daemon.jsvc.tar.gz.
 - Info - Dependency on jakarta-struts exists, no need to add for property struts.home.
 - Error - Failed with reason build failed


-  -  -  -  - -- --  G U M P
Gump performed this work:

Work Name: build_jakarta-tomcat-5_jakarta-tomcat-5 (Type: Build)
State: Failed
Elapsed: 0 hours, 1 minutes, 7 seconds
Command Line: java -Djava.awt.headless=true -Dbuild.clonevm=true 
-Xbootclasspath/p:/data3/gump/xml-xerces2/java/build/xercesImpl.jar:/data3/gump/xml-xerces2/java/build/xmlParserAPIs.jar:/data3/gump/xml-xalan/java/build/xalan-unbundled.jar:/data3/gump/xml-commons/java/external/build/xml-apis.jar
 org.apache.tools.ant.Main -Dgump.merge=/data3/gump/gump/work/merge.xml 
-Dbuild.sysclasspath=only -Dtomcat33.home=*Unset* 
-Djsp-api.jar=/data3/gump/jakarta-servletapi-5/jsr152/dist/lib/jsp-api.jar 
-Dtomcat-coyote.home=/data3/gump/jakarta-tomcat-connectors/coyote 
-Djndi.jar=/data3/gump/opt/jndi1_2_1/lib/jndi.jar 
-Dsite2.home=/data3/gump/jakarta-site2 
-DxmlParserAPIs.jar=/data3/gump/xml-xerces2/java/build/xercesImpl.jar 
-Dactivation.home=/data3/gump/opt/jaf-1.0.1 -Djmx.home=/data3/gump/opt/jmx-1_2-ri 
-Djdbc20ext.jar=/data3/gump/opt/jdbc2_0/jdbc2_0-stdext.jar 
-Djmx-tools.jar=/data3/gump/opt/jmx-1_2-ri/lib/jmxtools.jar 

DO NOT REPLY [Bug 20406] - Truncated Uploaded File

2004-02-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20406.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20406

Truncated Uploaded File

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2004-02-29 07:05 ---
Fixed in the CVS.
This was the duplicate of the #15278.
It work with large files, tested with multi MB files.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 20688] - Documentation is misleading for ver attribute in workers2.properties

2004-02-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20688.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20688

Documentation is misleading for ver attribute in workers2.properties

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX



--- Additional Comments From [EMAIL PROTECTED]  2004-02-29 07:16 ---

The documentation states:
Every time the config file is read, jk will check the version number in the
component, 
and reconfigure if it is different.

It's perfectly clear to me. No need to increment, just change the value different
then it was.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 11008] - Win32/cygwin compile report + patch (gcc 3.1.1 compile warnings)

2004-02-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11008.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11008

Win32/cygwin compile report + patch (gcc 3.1.1 compile warnings)

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2004-02-29 07:21 ---

This belongs to jk not jk2.
Please check and file the correct bug report.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 16160] - Upload problem: Stream ended unexpectedly

2004-02-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16160.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16160

Upload problem: Stream ended unexpectedly

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2004-02-29 07:25 ---
Fixed in the CVS.
This was too the duplicate of #15278.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]