DO NOT REPLY [Bug 29420] New: - file upload failed for IE-Client
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=29420. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=29420 file upload failed for IE-Client Summary: file upload failed for IE-Client Product: Tomcat 5 Version: 5.0.24 Platform: PC OS/Version: Linux Status: NEW Severity: Normal Priority: Other Component: Connector:Coyote AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Upload of large files on Tomcat 5.0.24 with Commons-fileupload fails with IE under WinXP and NT4. Konqueror and Mozilla under Linux as well as IE under Win2000 work fine. With Tomcat 4.1.xx there are no problems with the same code and all Clients. My configuration: Connector port=8080 maxThreads=150 minSpareThreads=25 maxSpareThreads=75 enableLookups=false redirectPort=8443 acceptCount=100 debug=0 connectionTimeout=2 disableUploadTimeout=true / The exception in the logfile appears after 20 seconds, but it takes severall minutes until the browser shows the error page. If I increase the connectionTimeout, the upload succeds under XP, while the IE under WinNT crashes. org.apache.commons.fileupload.FileUploadException: Processing of multipart/form-data request failed. Read timed out at org.apache.commons.fileupload.FileUploadBase.parseRequest(FileUploadBase.java:429) at org.apache.commons.fileupload.DiskFileUpload.parseRequest(DiskFileUpload.java:245) at docstatus.DocStatus.doPost(DocStatus.java:406) at javax.servlet.http.HttpServlet.service(HttpServlet.java:717) at javax.servlet.http.HttpServlet.service(HttpServlet.java:810) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:237) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:157) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:214) at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:104) at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:520) at org.apache.catalina.core.StandardContextValve.invokeInternal(StandardContextValve.java:198) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:152) at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:104) at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:520) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:137) at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:104) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:117) at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:102) at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:535) at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:102) at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:520) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:104) at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:520) at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:929) at org.apache.coyote.tomcat5.CoyoteAdapter.service(CoyoteAdapter.java:160) at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:799) at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.processConnection(Http11Protocol.java:705) at org.apache.tomcat.util.net.TcpWorkerThread.runIt(PoolTcpEndpoint.java:577) at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:683) at java.lang.Thread.run(Thread.java:534) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 29093] - When reloading context IllegalStateException is not catched
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=29093. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=29093 When reloading context IllegalStateException is not catched --- Additional Comments From [EMAIL PROTECTED] 2004-06-07 07:27 --- Ok, I'll comment: I think not, this case requires user intervention. How about trying to find the cause of the exception instead ? (which I don't get, but was the only reason why I didn't close your bug as INVALID in the first place) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 29420] - file upload failed for IE-Client
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=29420. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=29420 file upload failed for IE-Client [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2004-06-07 07:27 --- Why do you file a bug if it looks fairly obvious it's a browser issue ? You're going to get far better tips on tomcat-user, as BZ is solely for dealing with bugs (ie, an issue where there's something to fix). - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 29093] - When reloading context IllegalStateException is not catched
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=29093. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=29093 When reloading context IllegalStateException is not catched --- Additional Comments From [EMAIL PROTECTED] 2004-06-07 09:36 --- Yes, I agree, I have to find a reason of this behavior. But please imagine the situation: server is loaded with 500 – 1000 sessions or even more. And there is a necessity of reloading context. And if this situation occurs, application will not be available for several minutes, because the only thing we can do – restart tomcat. It is very convenient – possibility of context reload, but now we afraid reload context because if this happens, it is the same as tomcat restart. I am sorry, I do not know tomcat structure well enough. I may be wrong, but I have a hypothesis how this can happen. There is background thread that calls StoreBase.processExpires() method. This method walks through sessions and it may call StandardSession.recycle() or StandardSession.expire(). Both of this methods may set the following fields of Session object: expiring to false; isValid to false; accessCount to 0; Suppose, we reloading context - in StandardManager.doUnload we walk through sessions and call writeObjectData on each session, which will call writeObject method. It calls removeAttribute method, which may throw a runtime exception, if isValid() == false. isValid() == false if expiring == false; isValid == false; accessCount == 0; Suppose, at the same time background thread sets this fields to expiring = false; isValid = false; accessCount = 0; Than we will have this situation. I do not know is this hypothesis true or not. I may be wrong, but it is important for us that is why I am moving a suggestion. Could you please tell your opinion? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardWrapper.java
remm2004/06/07 05:02:34
Modified:catalina/src/share/org/apache/catalina/core
StandardWrapper.java
Log:
- Merge init-params from the JSP servlet when using a JSP file, as it is intuitive
users will expect the usual shared parameters to be used for the compilation of
this servlet.
Revision ChangesPath
1.43 +12 -2
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardWrapper.java
Index: StandardWrapper.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardWrapper.java,v
retrieving revision 1.42
retrieving revision 1.43
diff -u -r1.42 -r1.43
--- StandardWrapper.java 26 May 2004 15:41:29 - 1.42
+++ StandardWrapper.java 7 Jun 2004 12:02:34 - 1.43
@@ -892,8 +892,18 @@
if ((actualClass == null) (jspFile != null)) {
Wrapper jspWrapper = (Wrapper)
((Context) getParent()).findChild(Constants.JSP_SERVLET_NAME);
-if (jspWrapper != null)
+if (jspWrapper != null) {
actualClass = jspWrapper.getServletClass();
+// Merge init parameters
+String paramNames[] = jspWrapper.findInitParameters();
+for (int i = 0; i paramNames.length; i++) {
+if (parameters.get(paramNames[i]) == null) {
+parameters.put
+(paramNames[i],
+ jspWrapper.findInitParameter(paramNames[i]));
+}
+}
+}
}
// Complain if no servlet class has been specified
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-watchdog-4.0 BUILDING.txt
yoavs 2004/06/07 06:21:17
Modified:.BUILDING.txt
Log:
Added ant-launcher.jar copy in order to make build work with Ant 1.6,
in order to fix Bugzilla http://nagoya.apache.org/bugzilla/show_bug.cgi?id=29226.
Also updated BUILDING.txt to have directions for Ant 1.6 and later.
Revision ChangesPath
1.6 +5 -18 jakarta-watchdog-4.0/BUILDING.txt
Index: BUILDING.txt
===
RCS file: /home/cvs/jakarta-watchdog-4.0/BUILDING.txt,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- BUILDING.txt 5 Aug 2002 01:21:48 - 1.5
+++ BUILDING.txt 7 Jun 2004 13:21:17 - 1.6
@@ -23,30 +23,17 @@
(1) Download and Install the Ant Binary Distribution
-NOTE: These instructions assume that you are using the Ant 1.4 or above.
+NOTE: These instructions assume that you are using the Ant 1.6 or above.
-* Download a binary distribution of Ant 1.4 from:
+* Download a binary distribution of Ant 1.6 from:
-http://jakarta.apache.org/builds/jakarta-ant/release/v1.4/bin/
-
- On a Windows platform, you will need:
-jakarta-ant-1.4-bin.zip
-jakarta-ant-1.4-optional.jar
-
- On a Unix platform, you will need:
-jakarta-ant-1.4-bin.tar.gz
-jakarta-ant-1.4-optional.jar
+http://ant.apache.org
* Unpack the binary distribution into a convenient location so that the
Ant release resides in its own directory (conventionally named
- jakarta-ant-1.4). For the purposes of the remainder of this document,
+ apache-ant-1.6). For the purposes of the remainder of this document,
the symbolic name ${ant.home} is used to refer to the full pathname of
the release directory.
-
-* Copy the file jakarta-ant-1.4-optional.jar, downloaded above, into
- the directory ${ant.home}/lib. This makes available several Ant
- extension commands that are commonly required when building Jakarta
- based projects.
* Modify the PATH environment variable to include directory
${ant.home}/bin in its list. This makes the ant command line script
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
vielen dank für ihre email
Hallo, vielen dank für Ihre Mail dieser eMail Account wird nicht mehr verwendet. Neue Adresse: [EMAIL PROTECTED] viele Grüsse http://www.sex3.de - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-watchdog-4.0 build.xml
yoavs 2004/06/07 06:21:12
Modified:.build.xml
Log:
Added ant-launcher.jar copy in order to make build work with Ant 1.6,
in order to fix Bugzilla http://nagoya.apache.org/bugzilla/show_bug.cgi?id=29226.
Also updated BUILDING.txt to have directions for Ant 1.6 and later.
Revision ChangesPath
1.25 +4 -4 jakarta-watchdog-4.0/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-watchdog-4.0/build.xml,v
retrieving revision 1.24
retrieving revision 1.25
diff -u -r1.24 -r1.25
--- build.xml 5 Aug 2002 12:59:18 - 1.24
+++ build.xml 7 Jun 2004 13:21:11 - 1.25
@@ -103,10 +103,10 @@
!-- Library files --
copytodir=${watchdog.build}/lib
- fileset dir=${ant.home}/lib includes=ant.jar/
- fileset dir=${ant.home}/lib includes=crimson.jar/
- fileset dir=${ant.home}/lib includes=jaxp.jar/
- fileset dir=${ant.home}/lib includes=parser.jar/
+ fileset dir=${ant.home}/lib
+include name=ant.jar/
+include name=ant-launcher.jar /
+ /fileset
/copy
copy tofile=${watchdog.build}/lib/servlet.jar
file=${servlet23.jar} /
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-watchdog-4.0/site - New directory
yoavs 2004/06/07 07:10:23 jakarta-watchdog-4.0/site - New directory - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-watchdog-4.0/site index.html
yoavs 2004/06/07 07:10:53 Added: site index.html Log: I figured the web site should be backed up in CVS ;) Revision ChangesPath 1.1 jakarta-watchdog-4.0/site/index.html Index: index.html === html head titleThe Watchdog Validation Test Suite/title meta http-equiv=Content-Type content=text/html; charset=iso-8859-1 /head body bgcolor=#FF text=#00 link=#525D76 !-- Banner element, all hail the Project! -- table width=100% border=0 cellspacing=4 tr td colspan=2 a href=/index.htmlimg src=/images/jakarta-logo.gif alt=The Jakarta Project border=0/a /td /tr trtd colspan=2 hr noshade= size=1/ /td/tr tr !-- LEFT SIDE NAVIGATION -- td valign=top nowrap=true strongEssentials/strong ul lia href=/index.htmlFront Page/a/li lia href=/site/news.htmlNews Status/a/li lia href=/site/mission.htmlMission/a/li lia href=/site/guidelines.htmlGuidelines Notes/a/li lia href=/site/faqs.htmlFAQs/a/li /ul strongDownload/strong ul lia href=/site/binindex.htmlBinaries/a/li lia href=/site/sourceindex.htmlSource Code/a/li /ul strongGet Involved/strong ul lia href=/site/getinvolved.htmlOverview/a/li lia href=/site/cvsindex.htmlCVS Repositories/a/li lia href=/site/mail.htmlMailing Lists/a/li lia href=/site/library.htmlReference Library/a/li lia href=/site/bugs.htmlBug Database/a/li /ul strongSubProjects/strong ul lia href=/ant/index.htmlAnt/a/li lia href=/avalon/index.htmlAvalon/a/li lia href=/ecs/index.htmlECS/a/li lia href=/james/index.htmlJames/a/li lia href=/jetspeed/index.htmlJetspeed/a/li lia href=/jmeter/index.htmlJMeter/a/li lia href=/log4j/index.htmlLog4J/a/li lia href=/oro/index.htmlORO/a/li lia href=/regexp/index.htmlRegexp/a/li lia href=/slide/index.htmlSlide/a/li lia href=/struts/index.htmlStruts/a/li lia href=/taglibs/index.htmlTaglibs/a/li lia href=/tomcat/index.htmlTomcat/a/li lia href=/turbine/index.htmlTurbine/a/li lia href=/velocity/index.htmlVelocity/a/li lia href=/watchdog/index.htmlWatchdog/a/li /ul strongMisc/strong ul lia href=/site/whoweare.htmlWho We Are/a/li lia href=/site/acknowledgements.htmlAcknowledgements/a/li lia href=/site/contact.htmlContact/a/li lia href=/site/legal.htmlLegal/a/li /ul /td td align=left valign=top h1Watchdog/h1 p font color=redPlease note/font that the Watchdog project is ibdormant/b/i. There has been no development activity on this project for a while, since late 2002. The last version released, 4.0, tests the Servlet Specification version 2.3 and the JSP Specification v 1.2: both of these specifications now have newer versions (Servlet 2.4 and JSP 2.0), and there is no Watchdog release to test conformance with these specifications. The main reason for this status is that Sun has made the official Servlet/JSP TCK (Technology Comptability Kit, the official spec conformance test suite) more easily available to us. /p p Given the above, we will continue to make the Watchdog project available for download, and the source code available for your use. If you would like to revive and/or participate in the project, please subscribe to the user list and send a note indicating your interest. The ASF continues to encourage all contributions to this and other projects: the project may be revived at any time if interest if shown. It'd be great to have a true open-source TCK for these specifications. /p pstrongWatchdog/strong is a set of validation tests that can be run against a Servlet 2.3 / JSP 1.2 container (such as Tomcat 4.x) to identify potential problems with conformance to the corresponding specifications. While it is not the official TCK for the Servlet or JSP specifications, the tests it performs are similar./p /td /tr !-- FOOTER -- trtd colspan=2 hr noshade= size=1/ /td/tr trtd colspan=2 div align=centerfont color=#525D76 size=-1em Copyright #169; 1999-2004, Apache Software Foundation /em/font/div /td/tr /table /body /html - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 29410] - confusing digester error while parsing data-sources element
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=29410. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=29410 confusing digester error while parsing data-sources element [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2004-06-07 14:11 --- This eror is niether from Tomcat nor Digester. It come from Xerces. Since Tomcat is parser free (you will not get the same error if you use the Crimson parser), your recommendation doesn't apply. Thanks -- Jeanfrancois - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardContext.java mbeans-descriptors.xml
remm2004/06/07 08:30:06
Modified:catalina/src/share/org/apache/catalina/core
StandardContext.java mbeans-descriptors.xml
Log:
- Add flag to disable save-context-file, which can be useful in embedded mode.
Revision ChangesPath
1.130 +24 -2
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java
Index: StandardContext.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java,v
retrieving revision 1.129
retrieving revision 1.130
diff -u -r1.129 -r1.130
--- StandardContext.java 26 May 2004 15:36:28 - 1.129
+++ StandardContext.java 7 Jun 2004 15:30:06 - 1.130
@@ -615,6 +615,12 @@
private boolean tldNamespaceAware = false;
+/**
+ * Should we save the configuration.
+ */
+private boolean saveConfig = true;
+
+
// - Context Properties
public void setName( String name ) {
@@ -1676,6 +1682,22 @@
}
+/**
+ * Save config ?
+ */
+public boolean isSaveConfig() {
+return saveConfig;
+}
+
+
+/**
+ * Set save config flag.
+ */
+public void setSaveConfig(boolean saveConfig) {
+this.saveConfig = saveConfig;
+}
+
+
// Context Methods
@@ -4047,7 +4069,7 @@
// Set config file name
File configBase = getConfigBase();
-if (configBase != null) {
+if ((configBase != null) saveConfig) {
if (getConfigFile() == null) {
File file = new File(configBase, getDefaultConfigFile());
setConfigFile(file.getPath());
1.29 +5 -0
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/mbeans-descriptors.xml
Index: mbeans-descriptors.xml
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/mbeans-descriptors.xml,v
retrieving revision 1.28
retrieving revision 1.29
diff -u -r1.28 -r1.29
--- mbeans-descriptors.xml25 Feb 2004 21:08:07 - 1.28
+++ mbeans-descriptors.xml7 Jun 2004 15:30:06 - 1.29
@@ -256,6 +256,11 @@
type=[Ljava.lang.String;
writeable=false/
+attribute name=saveConfig
+ description=Should the configuration be written as needed on
startup
+ is=true
+ type=boolean/
+
attribute name=server
description=The J2EE Server this module is deployed on
type=java.lang.String/
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28709] - javax.servlet.http.HttpServletRequest.isRequestedSessionIdValid() returns true for an invalidated session!
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28709. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28709 javax.servlet.http.HttpServletRequest.isRequestedSessionIdValid() returns true for an invalidated session! --- Additional Comments From [EMAIL PROTECTED] 2004-06-07 15:41 --- The excerpts from the code base look fine for me too. What makes me wonder is that if the test-web-application uses coServletContext.getNamedDispatcher(coServlet) instead of coServletContext.getRequestDispatcher(coServletPath) then everything works as expected. I think there must be a consistent behavior. Did you run the test code that I have provided with the attachments? Is the bug in test code? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5 CoyoteRequest.java
remm2004/06/07 09:54:58
Modified:catalina/src/share/org/apache/coyote/tomcat5
CoyoteRequest.java
Log:
- Bug 29387: There's no good place to log a bad cookie right now, so ignore it.
Revision ChangesPath
1.37 +2 -3
jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5/CoyoteRequest.java
Index: CoyoteRequest.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5/CoyoteRequest.java,v
retrieving revision 1.36
retrieving revision 1.37
diff -u -r1.36 -r1.37
--- CoyoteRequest.java14 Apr 2004 22:26:42 - 1.36
+++ CoyoteRequest.java7 Jun 2004 16:54:58 - 1.37
@@ -2340,8 +2340,7 @@
}
cookies[idx++] = cookie;
} catch(IllegalArgumentException e) {
-log.info(Bad Cookie: Name: + scookie.getName()
- + Value: + scookie.getValue());
+// Ignore bad cookie
}
}
if( idx count ) {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 29387] - Null pointer exception in CoyoteRequest in parseCookies() method when cookie name is reserved word
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=29387. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=29387 Null pointer exception in CoyoteRequest in parseCookies() method when cookie name is reserved word [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2004-06-07 16:56 --- Fixed. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28709] - javax.servlet.http.HttpServletRequest.isRequestedSessionIdValid() returns true for an invalidated session!
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28709. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28709 javax.servlet.http.HttpServletRequest.isRequestedSessionIdValid() returns true for an invalidated session! --- Additional Comments From [EMAIL PROTECTED] 2004-06-07 17:02 --- The request wrapper used by the regular RD doesn't override this method (while the named RD won't wrap). No matter how I look at this, the answer to this issue remains the same: sorry, but we don't care about it. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28709] - javax.servlet.http.HttpServletRequest.isRequestedSessionIdValid() returns true for an invalidated session!
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28709. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28709 javax.servlet.http.HttpServletRequest.isRequestedSessionIdValid() returns true for an invalidated session! --- Additional Comments From [EMAIL PROTECTED] 2004-06-07 17:31 --- Ok, actually, my first sentence is a problem: not wrapping for named forwards would mean trouble with cross context and session handling. That's a separate issue, but will explain the different session behavior in that case (you're going to interact with the session from the first context, which is a problem). This is the only case, because named includes will wrap. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationDispatcher.java
remm2004/06/07 10:32:15 Modified:catalina/src/share/org/apache/catalina/core ApplicationDispatcher.java Log: - Remove some dead code. - Also wrap when doing named forwards (otherwise session handling will be bad). Revision ChangesPath 1.34 +12 -11 jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationDispatcher.java Index: ApplicationDispatcher.java === RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationDispatcher.java,v retrieving revision 1.33 retrieving revision 1.34 diff -u -r1.33 -r1.34 --- ApplicationDispatcher.java24 Apr 2004 16:01:19 - 1.33 +++ ApplicationDispatcher.java7 Jun 2004 17:32:15 - 1.34 @@ -359,8 +359,19 @@ if ( log.isDebugEnabled() ) log.debug( Named Dispatcher Forward); +ApplicationHttpRequest wrequest = +(ApplicationHttpRequest) wrapRequest(); +wrequest.setRequestURI(hrequest.getRequestURI()); +wrequest.setContextPath(hrequest.getContextPath()); +wrequest.setServletPath(hrequest.getServletPath()); +wrequest.setPathInfo(hrequest.getPathInfo()); +wrequest.setQueryString(hrequest.getQueryString()); + processRequest(request,response); +wrequest.recycle(); +unwrapRequest(); + } // Handle an HTTP path-based forward @@ -555,16 +566,6 @@ ApplicationHttpRequest wrequest = (ApplicationHttpRequest) wrapRequest(); String contextPath = context.getPath(); -/* -StringBuffer sb = new StringBuffer(); -if (contextPath != null) -sb.append(contextPath); -if (servletPath != null) -sb.append(servletPath); -if (pathInfo != null) -sb.append(pathInfo); -if (sb.length() 0) -*/ if (requestURI != null) wrequest.setAttribute(Globals.INCLUDE_REQUEST_URI_ATTR, requestURI); - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native2/server/isapi install4iis.js
keith 2004/06/07 15:15:32
Modified:jk/native2/server/isapi install4iis.js
Log:
Actually filter can be on service or server, so move it back to server.
However, we may have to create our own Filters container as IIS
only creates one automatically for the service.
Revision ChangesPath
1.5 +3 -4 jakarta-tomcat-connectors/jk/native2/server/isapi/install4iis.js
Index: install4iis.js
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/jk/native2/server/isapi/install4iis.js,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- install4iis.js7 Jun 2004 21:08:26 - 1.4
+++ install4iis.js7 Jun 2004 22:15:32 - 1.5
@@ -255,9 +255,8 @@
try {
filters = findADSIObject(webServer, _IIS_FILTERS, Filters);
if (filters == null) {
-TRACE(Unable to find the + _IIS_FILTERS + for +
- webServer.ServerComment);
-return null;
+//may have to create the website-level filters container
+filters = webserver.create(_IIS_FILTERS, Filters);
}
newFilter = findADSIObject(filters, _IIS_FILTER, appParams.FilterName);
if (newFilter == null) {
@@ -488,7 +487,7 @@
ERROR(args, Unable to create virual directory / + params.WebName);
}
-if (!createISAPIFilter(IIsWebService, params)) {
+if (!createISAPIFilter(IIsWebServer, params)) {
/* TODO: roll-back virtual dir */
ERROR(args, Unable to create the ' + params.FilterName + ' filter.);
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native2/server/isapi install4iis.js
keith 2004/06/07 14:08:26
Modified:jk/native2/server/isapi install4iis.js
Log:
Filters is on the service object
Revision ChangesPath
1.4 +2 -2 jakarta-tomcat-connectors/jk/native2/server/isapi/install4iis.js
Index: install4iis.js
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/jk/native2/server/isapi/install4iis.js,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- install4iis.js26 Apr 2004 17:41:46 - 1.3
+++ install4iis.js7 Jun 2004 21:08:26 - 1.4
@@ -487,8 +487,8 @@
if (!createVirtualExecDir(IIsROOT, params)) {
ERROR(args, Unable to create virual directory / + params.WebName);
}
-
-if (!createISAPIFilter(IIsWebServer, params)) {
+
+if (!createISAPIFilter(IIsWebService, params)) {
/* TODO: roll-back virtual dir */
ERROR(args, Unable to create the ' + params.FilterName + ' filter.);
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native2/server/isapi install4iis.js
keith 2004/06/07 16:58:17
Modified:jk/native2/server/isapi install4iis.js
Log:
s-S
Revision ChangesPath
1.6 +1 -1 jakarta-tomcat-connectors/jk/native2/server/isapi/install4iis.js
Index: install4iis.js
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/jk/native2/server/isapi/install4iis.js,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- install4iis.js7 Jun 2004 22:15:32 - 1.5
+++ install4iis.js7 Jun 2004 23:58:17 - 1.6
@@ -256,7 +256,7 @@
filters = findADSIObject(webServer, _IIS_FILTERS, Filters);
if (filters == null) {
//may have to create the website-level filters container
-filters = webserver.create(_IIS_FILTERS, Filters);
+filters = webServer.create(_IIS_FILTERS, Filters);
}
newFilter = findADSIObject(filters, _IIS_FILTER, appParams.FilterName);
if (newFilter == null) {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[PATCH] jakarta-servletapi-5: javax/servlet/http/HttpServlet.java
This fixes an ArrayIndexOutOfBoundsException when superclass does
not declare any methods (see Bugtraq 4968841).
Jan
[EMAIL PROTECTED]'s password:
Warning: Remote host denied X11 forwarding, perhaps xauth program could not be run on
the server side.
Index: jsr154/src/share/javax/servlet/http/HttpServlet.java
===
RCS file:
/home/cvs/jakarta-servletapi-5/jsr154/src/share/javax/servlet/http/HttpServlet.java,v
retrieving revision 1.7
diff -u -r1.7 HttpServlet.java
--- jsr154/src/share/javax/servlet/http/HttpServlet.java18 Mar 2004 16:40:35
- 1.7
+++ jsr154/src/share/javax/servlet/http/HttpServlet.java8 Jun 2004 00:14:28
-
@@ -465,36 +465,28 @@
}
+private static Method[] getAllDeclaredMethods(Class c) {
+if (c.equals(javax.servlet.http.HttpServlet.class)) {
+return null;
+}
-
-private Method[] getAllDeclaredMethods(Class c) {
- if (c.getName().equals(javax.servlet.http.HttpServlet))
- return null;
-
- int j=0;
- Method[] parentMethods = getAllDeclaredMethods(c.getSuperclass());
- Method[] thisMethods = c.getDeclaredMethods();
+Method[] parentMethods = getAllDeclaredMethods(c.getSuperclass());
+Method[] thisMethods = c.getDeclaredMethods();
- if (parentMethods!=null) {
- Method[] allMethods =
- new Method[parentMethods.length + thisMethods.length];
- for (int i=0; iparentMethods.length; i++) {
- allMethods[i]=parentMethods[i];
- j=i;
- }
- j++;
- for (int i=j; ithisMethods.length+j; i++) {
- allMethods[i] = thisMethods[i-j];
- }
- return allMethods;
+if ((parentMethods != null) (parentMethods.length 0)) {
+Method[] allMethods =
+new Method[parentMethods.length + thisMethods.length];
+ System.arraycopy(parentMethods, 0, allMethods, 0,
+ parentMethods.length);
+ System.arraycopy(thisMethods, 0, allMethods, parentMethods.length,
+ thisMethods.length);
+
+ thisMethods = allMethods;
}
+
return thisMethods;
}
-
-
-
-
/**
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-servletapi-5/jsr154/src/share/javax/servlet/http HttpServlet.java
jfarcand2004/06/07 18:28:52
Modified:jsr154/src/share/javax/servlet/http HttpServlet.java
Log:
This fixes an ArrayIndexOutOfBoundsException when superclass does
not declare any methods (see Bugtraq 4968841).
Patch submitted by: Jan Luehe
Revision ChangesPath
1.8 +16 -24
jakarta-servletapi-5/jsr154/src/share/javax/servlet/http/HttpServlet.java
Index: HttpServlet.java
===
RCS file:
/home/cvs/jakarta-servletapi-5/jsr154/src/share/javax/servlet/http/HttpServlet.java,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- HttpServlet.java 18 Mar 2004 16:40:35 - 1.7
+++ HttpServlet.java 8 Jun 2004 01:28:52 - 1.8
@@ -465,36 +465,28 @@
}
+private static Method[] getAllDeclaredMethods(Class c) {
+if (c.equals(javax.servlet.http.HttpServlet.class)) {
+return null;
+}
-
-private Method[] getAllDeclaredMethods(Class c) {
- if (c.getName().equals(javax.servlet.http.HttpServlet))
- return null;
-
- int j=0;
- Method[] parentMethods = getAllDeclaredMethods(c.getSuperclass());
- Method[] thisMethods = c.getDeclaredMethods();
+Method[] parentMethods = getAllDeclaredMethods(c.getSuperclass());
+Method[] thisMethods = c.getDeclaredMethods();
- if (parentMethods!=null) {
- Method[] allMethods =
- new Method[parentMethods.length + thisMethods.length];
- for (int i=0; iparentMethods.length; i++) {
- allMethods[i]=parentMethods[i];
- j=i;
- }
- j++;
- for (int i=j; ithisMethods.length+j; i++) {
- allMethods[i] = thisMethods[i-j];
- }
- return allMethods;
+if ((parentMethods != null) (parentMethods.length 0)) {
+Method[] allMethods =
+new Method[parentMethods.length + thisMethods.length];
+ System.arraycopy(parentMethods, 0, allMethods, 0,
+ parentMethods.length);
+ System.arraycopy(thisMethods, 0, allMethods, parentMethods.length,
+ thisMethods.length);
+
+ thisMethods = allMethods;
}
+
return thisMethods;
}
-
-
-
-
/**
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-servletapi-5/jsr154/src/share/javax/servlet/http HttpServlet.java
§Ú¤w¸g¦¬¨ì¨Ó«H¤F, ÁÂÁ±z. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Martina Rupprecht/SEND/LHS/SGH ist außer Haus.
Ich werde ab 26.05.2004 nicht im Büro sein. Ich kehre zurück am 14.06.2004. In dringenden Fällen wenden Sie sich bitte an meine Kollegin, Frau Sabine Holzbrecher. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
