cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup ContextConfig.java

2004-10-02 Thread remm 
remm2004/10/02 02:22:18

  Modified:catalina/src/share/org/apache/catalina/core
StandardContext.java
   catalina/src/share/org/apache/catalina/startup
ContextConfig.java
  Log:
  - Fix (again) the check for an uncompressed folder ending with .war.
  
  Revision  ChangesPath
  1.150 +2 -2  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java
  
  Index: StandardContext.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java,v
  retrieving revision 1.149
  retrieving revision 1.150
  diff -u -r1.149 -r1.150
  --- StandardContext.java  30 Sep 2004 19:29:04 -  1.149
  +++ StandardContext.java  2 Oct 2004 09:22:18 -   1.150
  @@ -3926,7 +3926,7 @@
   if (log.isDebugEnabled())
   log.debug(Configuring default Resources);
   try {
  -if ((docBase != null)  (docBase.endsWith(.war))  (!(new 
File(docBase)).isDirectory()))
  +if ((docBase != null)  (docBase.endsWith(.war))  (!(new 
File(getBasePath())).isDirectory()))
   setResources(new WARDirContext());
   else
   setResources(new FileDirContext());
  
  
  
  1.59  +2 -1  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/ContextConfig.java
  
  Index: ContextConfig.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/ContextConfig.java,v
  retrieving revision 1.58
  retrieving revision 1.59
  diff -u -r1.58 -r1.59
  --- ContextConfig.java24 Sep 2004 07:25:07 -  1.58
  +++ ContextConfig.java2 Oct 2004 09:22:18 -   1.59
  @@ -782,6 +782,7 @@
   } else {
   docBase = file.getCanonicalPath();
   }
  +file = new File(docBase);
   
   if (docBase.toLowerCase().endsWith(.war)  !file.isDirectory()  
unpackWARs) {
   URL war = new URL(jar: + (new File(docBase)).toURL() + !/);
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardContext.java

2004-10-02 Thread remm 
remm2004/10/02 02:22:59

  Modified:catalina/src/share/org/apache/catalina/core
StandardContext.java
  Log:
  - Remove dead code.
  
  Revision  ChangesPath
  1.151 +1 -44 
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java
  
  Index: StandardContext.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java,v
  retrieving revision 1.150
  retrieving revision 1.151
  diff -u -r1.150 -r1.151
  --- StandardContext.java  2 Oct 2004 09:22:18 -   1.150
  +++ StandardContext.java  2 Oct 2004 09:22:59 -   1.151
  @@ -3878,49 +3878,6 @@
   setConfigured(false);
   boolean ok = true;
   
  -// Set config file name
  -/*
  -File configBase = getConfigBase();
  -if ((configBase != null)  saveConfig) {
  -if (getConfigFile() == null) {
  -File file = new File(configBase, getDefaultConfigFile());
  -setConfigFile(file.getPath());
  -// If the docbase is outside the appBase, we should save our
  -// config
  -try {
  -File appBaseFile = new File(getAppBase());
  -if (!appBaseFile.isAbsolute()) {
  -appBaseFile = new File(engineBase(), getAppBase());
  -}
  -String appBase = appBaseFile.getCanonicalPath();
  -String basePath = 
  -(new File(getBasePath())).getCanonicalPath();
  -if (!basePath.startsWith(appBase)) {
  -Server server = ServerFactory.getServer();
  -((StandardServer) server).storeContext(this);
  -}
  -} catch (Exception e) {
  -log.warn(Error storing config file, e);
  -}
  -} else {
  -try {
  -String canConfigFile = 
  -(new File(getConfigFile())).getCanonicalPath();
  -if (!canConfigFile.startsWith
  -(configBase.getCanonicalPath())) {
  -File file = 
  -new File(configBase, getDefaultConfigFile());
  -if (copy(new File(canConfigFile), file)) {
  -setConfigFile(file.getPath());
  -}
  -}
  -} catch (Exception e) {
  -log.warn(Error setting config file, e);
  -}
  -}
  -}
  -*/
  -
   // Add missing components as necessary
   if (webappResources == null) {   // (1) Required by Loader
   if (log.isDebugEnabled())
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

321greetings auto responder

2004-10-02 Thread list 
Hi,

Due to the amount of e-mails we get per day we have setup this auto responder for your 
convenience.  
This is not a monitored e-mail address

To unsubscribe 
http://321greetings.com/unsubscribenewlist.htm
a href=\ http://321greetings.com/unsubscribenewlist.htm \ AOL Link /a

To subscribe please go here:
http://321greetings.com/sub321greetings-newsletter.htm
a href=\ http://321greetings.com/sub321greetings-newsletter.htm \ AOL Link /a


If you need technical assistance, please go here:
http://321greetings.com/contactus.htm
a href=\ http://321greetings.com/contactus.htm \ AOL-link /a



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[GUMP@brutus]: jakarta-tomcat-5/jakarta-tomcat-dbcp failed

2004-10-02 Thread bobh 
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact folk at [EMAIL PROTECTED]

Project jakarta-tomcat-dbcp has an issue affecting its community integration.
This issue affects 14 projects, and has been outstanding for 102L runs.
Project State : 'Failed'
The following are affected:
- avalon-http-context :  Avalon SVN
- avalon-http-demo :  Avalon SVN
- avalon-http-examples :  Avalon SVN
- avalon-http-impl :  Avalon SVN
- avalon-http-server :  Avalon SVN
- avalon-http-servlet :  Avalon SVN
- avalon-http-static :  Avalon SVN
- avalon-http-test :  Avalon SVN
- avalon-planet-facilities :  Avalon SVN
- jakarta-tomcat-5 :  Servlet 2.4 and JSP 2.0 Reference Implementation
- jakarta-tomcat-catalina :  Servlet 2.4 Reference Implementation
- jakarta-tomcat-dbcp :  Servlet 2.4 and JSP 2.0 Reference Implementation
- jakarta-tomcat-jk :  Connectors to various web servers
- metro-reflector-blocks-complete :  Avalon SVN


Full details are available at:


http://brutus.apache.org/gump/public/jakarta-tomcat-5/jakarta-tomcat-dbcp/index.html

That said, some snippets follow:


The following annotations were provided:
 -DEBUG- Sole output [naming-factory-dbcp.jar] identifier set to project name
 -INFO- Made directory [/usr/local/gump/public/workspace/jakarta-tomcat-5/tomcat-deps]
 -INFO- Failed with reason build failed
 -DEBUG- Extracted fallback artifacts from Gump Repository


The following work was performed:
http://brutus.apache.org/gump/public/jakarta-tomcat-5/jakarta-tomcat-dbcp/gump_work/build_jakarta-tomcat-5_jakarta-tomcat-dbcp.html
Work Name: build_jakarta-tomcat-5_jakarta-tomcat-dbcp (Type: Build)
State: Failed
Elapsed: 3 secs
Command Line: java -Djava.awt.headless=true org.apache.tools.ant.Main 
-Dgump.merge=/usr/local/gump/public/gump/work/merge.xml -Dbuild.sysclasspath=only 
-Dcommons-collections.home=/usr/local/gump/public/workspace/jakarta-commons/collections
 -Dcommons-dbcp.home=/usr/local/gump/public/workspace/jakarta-commons/dbcp 
-Dcommons-dbcp.version=02102004 
-Dtomcat-dbcp.home=/usr/local/gump/public/workspace/jakarta-tomcat-5/tomcat-deps 
-Dcommons-pool.home=/usr/local/gump/public/workspace/jakarta-commons/pool 
build-tomcat-dbcp 
[Working Directory: /usr/local/gump/public/workspace/jakarta-tomcat-5]
CLASSPATH : 
/usr/local/j2sdk1.4.2_04/lib/tools.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-stylebook.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar-
Buildfile: build.xml

build-tomcat-dbcp:

-build-tomcat-dbcp:
 [copy] Copying 65 files to 
/usr/local/gump/public/workspace/jakarta-tomcat-5/tomcat-deps
[mkdir] Created dir: 
/usr/local/gump/public/workspace/jakarta-tomcat-5/tomcat-deps/src/java/org/apache/tomcat/dbcp

BUILD FAILED
/usr/local/gump/public/workspace/jakarta-tomcat-5/build.xml:628: The following error 
occurred while executing this line:
/usr/local/gump/public/workspace/jakarta-tomcat-5/build.xml:663: Cannot replace 
directory 
/usr/local/gump/public/workspace/jakarta-tomcat-5/tomcat-deps/src/java/org/apache/tomcat/dbcp
 with directory 
/usr/local/gump/public/workspace/jakarta-tomcat-5/tomcat-deps/src/java/org/apache/commons

Total time: 3 seconds
-




To subscribe to this information via syndicated feeds:
 RSS: http://brutus.apache.org/gump/public/jakarta-tomcat-5/jakarta-tomcat-dbcp/rss.xml
 Atom: 
http://brutus.apache.org/gump/public/jakarta-tomcat-5/jakarta-tomcat-dbcp/atom.xml


--
Gump E-mail Identifier (within run) #15.
Produced by Gump 2.1.0-alpha-0003.
[Run (4002102004, brutus:brutus-public:4002102004)]
http://brutus.apache.org/gump/public/index.html
http://brutus.apache.org/gump/public/options.html

--
Apache Gump
http://gump.apache.org/ [Instance: brutus]

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31510] New: - Memory leaks due to JspWriterImpl keeping reference to ServletResponse after recycle()

2004-10-02 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=31510.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31510

Memory leaks due to JspWriterImpl keeping reference to ServletResponse after recycle()

   Summary: Memory leaks due to JspWriterImpl keeping reference to
ServletResponse after recycle()
   Product: Tomcat 5
   Version: 5.0.28
  Platform: All
OS/Version: All
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Jasper
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


This problem causes severe memory leaks in JBoss app server with Jetty servlet 
container installed (that is using Jasper). I tested it with JBoss 3.2.6RC1 and 
Jetty 5.0.0. Please see related bug reports: https://sourceforge.net/tracker/?
func=detailaid=973162group_id=22866atid=376685 and 
https://sourceforge.net/tracker/?
func=detailaid=1038066group_id=7322atid=107322. In short, after JBoss web 
application context is destroyed, there is still a hard reference chain (see 
http://kanika.yi.org/~alexei/jbossleaks/refs-from-jasper5-PageContext-pool-to-
UnifiedClassLoader3.html) from Jasper's pool of JspContexts to JBoss' 
UnifiedClassLoader3. The most logical place to break the chain is, in my 
opinion, to set org.apache.jasper.runtime.JspWriterImpl.response field to null 
inside JspWriterImpl.recycle() method. It looks safe, because JspWriterImpl is 
always initialized with a new response object before use. And it looks logical, 
because why should a recycled JspWriter keep reference to a response which it 
will never make use of, being recycled. In my test instalation, adding 

response = null;

to JspWriterImpl.recycle() resolves the problem.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31201] - Encoding bug when using jsp:include ... action

2004-10-02 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=31201.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31201

Encoding bug when using jsp:include ... action





--- Additional Comments From [EMAIL PROTECTED]  2004-10-02 14:33 ---
The default encoding for included pages is defined in 
http://www.jcp.org/aboutJava/communityprocess/maintenance/jsr053/errata_1_2_a_2
0020321.html
Comments and suggestions for the JSP spec should be directed to the spec team 
([EMAIL PROTECTED]) rather than this mailing list.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31201] - Encoding bug when using jsp:include ... action

2004-10-02 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=31201.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31201

Encoding bug when using jsp:include ... action

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX



--- Additional Comments From [EMAIL PROTECTED]  2004-10-02 14:47 ---
The patch suggested above would be a Tomcat specific solution to a wider i18n 
problem. Whilst it would work for Tomcat I would not wish to encourage an 
approach such as this as if you ever need to move to an alternative container, 
it will break again. Therefore, this patch will not be applied. (Hence the 
WONTFIX).

There are, however, a number of alternative approaches that are spec compliant 
and are hence container neutral.

The simplest approach is to convert the HTML to JSPs and specify the correct 
page encoding in the new JSPs using %@ page pageEncoding=... %.

There are other approaches and if the one suggested above isn't appropriate I 
suggest that you post a question on the tomcat-user mailing list rather than 
this bug report.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31511] New: - setenv.bat missing, but required by shutdown-using-launcher

2004-10-02 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=31511.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31511

setenv.bat missing, but required by shutdown-using-launcher

   Summary: setenv.bat missing, but required by shutdown-using-
launcher
   Product: Tomcat 5
   Version: 5.0.28
  Platform: Other
OS/Version: Windows XP
Status: NEW
  Severity: Minor
  Priority: Other
 Component: Unknown
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


startup-using-launcher.bat uses setenv.bat if it finds it.

However shutdown-using-launcher.bat always calls setenv.bat even if it did not
find it in the local directory, thus reports an error.

== code extract ==
rem %0 must have been found by DOS using the %PATH% so we assume that
rem setenv.bat will also be found in the %PATH%
call setenv.bat
== ends ==

The same code is to be found in tool-wrapper-using-launcher.bat

Whereas catalina.bat (and some other BAT files) use the construct:
if exist %CATALINA_HOME%\bin\setenv.bat call %CATALINA_HOME%\bin\setenv.bat

It seems to me that either setenv.bat should be provided, or it should not be
required.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/startup Main.java

2004-10-02 Thread billbarker 
billbarker2004/10/02 13:29:21

  Modified:src/share/org/apache/tomcat/startup Main.java
  Log:
  Set the ContextCL before loading loading EmbededTomcat.
  
  EmbededTomcat will reset it, but this seems to make log4j configuration easier.
  
  Revision  ChangesPath
  1.46  +2 -1  jakarta-tomcat/src/share/org/apache/tomcat/startup/Main.java
  
  Index: Main.java
  ===
  RCS file: /home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/startup/Main.java,v
  retrieving revision 1.45
  retrieving revision 1.46
  diff -u -r1.45 -r1.46
  --- Main.java 25 Feb 2004 07:25:48 -  1.45
  +++ Main.java 2 Oct 2004 20:29:21 -   1.46
  @@ -256,6 +256,7 @@
initSecurityFile();
initClassLoader();
   
  + jdk11Compat.setContextClassLoader(commonCL);
   Class cls=commonCL.loadClass((String)tasks.get(task));

   Object proxy=cls.newInstance();
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]