Re: [VOTE] 5.5.9 Stability

2005-04-10 Thread Henri Gomez
I voted it stable but I'm not using clustering support :(

On Apr 9, 2005 8:54 PM, Remy Maucherat [EMAIL PROTECTED] wrote:
 Yoav Shapira wrote:
  Hi,
 
 Ok, this give me and Filip time for real stability testing and review
 the 5.5.10 codebase.
 I also package my fixes to the 5.5.9 codebase for some test user as bug
 report..
 
 I'll let Yoav decide what he wants to do with all these builds before he
 gets married (congratulations ;)). I'm very happy to not be the release
 manager and have to make the tough decisions :) Go Yoav !
 
  Peter, when you have a Bugzilla item and a cluster fix/test package attached
  to that item, please let us know.  At that time I'll send out the vote
  results, calling 5.5.9 beta and nothing that this issue (and I'll provide a
  link to bugzilla) is the only thing preventing 5.5.9 from being stable, and
  that users not needing/using clustering should consider 5.5.9 stable.
 
 Good.
 
 The vote still does count though: since it is not a regression nor a
 security issue, if there are three committers who vote stable, then it's
 stable. Of course, it won't happen, as nobody ever cares about voting ;)
 
 Rémy
 
 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]
 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Building Question

2005-04-10 Thread Henri Gomez
CLR ?


On Apr 10, 2005 3:33 AM, Yoav Shapira [EMAIL PROTECTED] wrote:
 Hi,
 
  I'm thinking of starting on implementing CLRs for Tomcat 5.5.  However,
  it's
  a PITA for  1.5.  I wanted to check that the binary builds for TC 5.5 are
  being built with JDK 1.5, or, I'm probably wasting my time (not many
  people
  use the source distro :).
 
 I've been building with 1.4, using the build as a final check that we have
 no 1.5-only code.
 
 Yoav Shapira
 System Design and Management Fellow
 MIT Sloan School of Management / School of Engineering
 Cambridge, MA USA
 [EMAIL PROTECTED] / [EMAIL PROTECTED]
 
 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]
 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[GUMP@brutus]: Project jakarta-tomcat-jk-native (in module jakarta-tomcat-connectors) failed

2005-04-10 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project jakarta-tomcat-jk-native has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 86 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- jakarta-tomcat-jk-native :  Connectors to various web servers


Full details are available at:

http://brutus.apache.org/gump/public/jakarta-tomcat-connectors/jakarta-tomcat-jk-native/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -INFO- Failed with reason build failed



The following work was performed:
http://brutus.apache.org/gump/public/jakarta-tomcat-connectors/jakarta-tomcat-jk-native/gump_work/build_jakarta-tomcat-connectors_jakarta-tomcat-jk-native.html
Work Name: build_jakarta-tomcat-connectors_jakarta-tomcat-jk-native (Type: 
Build)
Work ended in a state of : Failed
Elapsed: 
Command Line: make 
[Working Directory: 
/usr/local/gump/public/workspace/jakarta-tomcat-connectors/jk/native]
-
Making all in common
make[1]: Entering directory 
`/home/gump/workspaces2/public/workspace/jakarta-tomcat-connectors/jk/native/common'
/bin/sh 
/usr/local/gump/public/workspace/apache-httpd/dest-10042005/build/libtool 
--silent --mode=compile gcc 
-I/usr/local/gump/public/workspace/apache-httpd/dest-10042005/include -g -O2 -g 
-O2 -pthread -DHAVE_APR  
-I/usr/local/gump/public/workspace/apr/dest-10042005/include/apr-1 -g -O2 
-DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE 
-I/home/gump/workspaces2/public/workspace/apache-httpd/srclib/pcre -I 
/opt/jdk1.4/include -I /opt/jdk1.4/include/ -c jk_ajp12_worker.c 
/usr/local/gump/public/workspace/apache-httpd/dest-10042005/build/libtool: 
/usr/local/gump/public/workspace/apache-httpd/dest-10042005/build/libtool: No 
such file or directory
make[1]: *** [jk_ajp12_worker.lo] Error 127
make[1]: Leaving directory 
`/home/gump/workspaces2/public/workspace/jakarta-tomcat-connectors/jk/native/common'
make: *** [all-recursive] Error 1
-

To subscribe to this information via syndicated feeds:
- RSS: 
http://brutus.apache.org/gump/public/jakarta-tomcat-connectors/jakarta-tomcat-jk-native/rss.xml
- Atom: 
http://brutus.apache.org/gump/public/jakarta-tomcat-connectors/jakarta-tomcat-jk-native/atom.xml

== Gump Tracking Only ===
Produced by Gump version 2.2.
Gump Run 2510042005, brutus:brutus-public:2510042005
Gump E-mail Identifier (unique within run) #10.

--
Apache Gump
http://gump.apache.org/ [Instance: brutus]

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 34389] New: - Tomcat 5.5.9 Cluster fix pack

2005-04-10 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=34389.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34389

   Summary: Tomcat 5.5.9 Cluster fix pack
   Product: Tomcat 5
   Version: 5.5.9
  Platform: Other
OS/Version: other
Status: NEW
  Severity: blocker
  Priority: P2
 Component: Catalina:Cluster
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


Readme - Clustering Jakarta Tomcat 5.5.9 fix
Date: 10.04.2005
Author: Peter Rossbach

After some load test the current clustering shows some bugs.

=
- At some case the complete cluster hang ( Linux Suse 9.1, Windows XP)
- Memory consume with fastasyncqueue is to high under heavy load.
   Probleme with waitAck and sync DataSender#pushMessage
- No request processing sometimes.
   Trouble with SessionManager background thread and wrong autoConnect sync
block

Here my fixes

DataSender
*   No sync pushMessage with async background thread
*   KeepAliveMaxRequestCount set to -1 ( disable), only timebased keep alive
*   Socket Open Counter afer successfull open!
*   More Trace messages
*   better wait ack handling

FastAsyncSocketSender
*   move counter queuedNrOfBytes to background thread
*   snyc only the counter and not the message queueing ( very important perf 
gap)
*   More Trace messages

AsyncSocketSender
*   move counter queuedNrOfBytes to background thread
*   snyc only the counter and not the message queueing ( very important perf 
gap)
*   More Trace messages

Jdk13ReplicationListener
*   Add Socket Listener -- Rename at  5.5.9 to SocketReplicationListener
*   More Trace messages to better understanding

ReplicationTransmitter
*   set autoConnect to false ( Very bad thing second thread can close a socket
that other thread can use!)
*   sync autoConnect sender check

ReplicationListener
*   More Trace messages to better understanding

PooledSocket
*   sendMessage used autoConnect ( not heavy tested)

===S
With 5.5.9 are following cluster sender config possible:

### pooled ###
 Sender
  
className=org.apache.catalina.cluster.tcp.ReplicationTransmitter
  replicationMode=pooled
  ackTimeout=@node.ackTimeout@/
 
### fastasyncqueue ###
// When you set compress=false you mus also do that at receiver!
// Make test that maxQueueLength is big!
 Sender
  
className=org.apache.catalina.cluster.tcp.ReplicationTransmitter
  replicationMode=fastasyncqueue
  compress=false
  doProcessingStats=true
  queueTimeWait=true
  maxQueueLength=1000
  queueDoStats=true
  queueCheckLock=true
  ackTimeout=15000
  waitForAck=true
  autoConnect=false
  keepAliveTimeout=@node.ackTimeout@
  keepAliveMaxRequestCount=-1/

### asynchronous ###
// When you set compress=false you mus also do that at receiver!
 Sender
  
className=org.apache.catalina.cluster.tcp.ReplicationTransmitter
  replicationMode=asynchronous
  compress=false
  ackTimeout=15000
  waitForAck=true
  autoConnect=false
  keepAliveTimeout=@node.ackTimeout@
  keepAliveMaxRequestCount=-1/


### synchronous ###
 Sender
  
className=org.apache.catalina.cluster.tcp.ReplicationTransmitter
  replicationMode=synchronous
  compress=false
  ackTimeout=15000
  waitForAck=true
  keepAliveTimeout=@node.ackTimeout@
  keepAliveMaxRequestCount=-1/

With this fix I implement a simple Socket Receiver that not used NIO!
Jdk13ReplicationListener
At  5.5.9 I change the name to SocketReplicationListener
   Receiver 
 
className=org.apache.catalina.cluster.tcp.Jdk13ReplicationListener
  tcpListenAddress=@node.clustertcp.address@
  tcpListenPort=@node.clustertcp.port@
  /
==
Compile from source,

* get Tomcat 5.5.9 binary release
* get this fix pack jakarta-tomcat-5.5.9-cluster-fix-src-date.tar.gz and 
extract.
* edit build.properties set catalina.home to you 5.5.9 release
catalina.home=d:/server/jakarta-tomcat-5.5.9
* than compile and install
ant compile install

* Install manually
Copy build/classes to 

DO NOT REPLY [Bug 34389] - Tomcat 5.5.9 Cluster fix pack

2005-04-10 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=34389.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34389





--- Additional Comments From [EMAIL PROTECTED]  2005-04-10 12:11 ---
Created an attachment (id=14671)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=14671action=view)
Binary Cluster 5.5.9 fix pack

jakarta-tomcat-5.5.9 cluster fix pack /server/classes

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 34389] - Tomcat 5.5.9 Cluster fix pack

2005-04-10 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=34389.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34389





--- Additional Comments From [EMAIL PROTECTED]  2005-04-10 12:12 ---
Created an attachment (id=14672)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=14672action=view)
Source Custer 5.5.9 Cluster Fix pack

Source of the cluster fix pack

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] 5.5.9 Stability

2005-04-10 Thread Peter Rossbach
Hi,
I have add my 5.5.9 clustering fix pack to the following bug report:
http://issues.apache.org/bugzilla/show_bug.cgi?id=34389
Vote for stable 5.5.9 [X]
All clustering user can extract the fix pack and all is working well. :-)
Peter
Yoav Shapira schrieb:
Hi,
 

Ok, this give me and Filip time for real stability testing and review
the 5.5.10 codebase.
I also package my fixes to the 5.5.9 codebase for some test user as bug
report..
 

I'll let Yoav decide what he wants to do with all these builds before he
gets married (congratulations ;)). I'm very happy to not be the release
manager and have to make the tough decisions :) Go Yoav !
   

Peter, when you have a Bugzilla item and a cluster fix/test package attached
to that item, please let us know.  At that time I'll send out the vote
results, calling 5.5.9 beta and nothing that this issue (and I'll provide a
link to bugzilla) is the only thing preventing 5.5.9 from being stable, and
that users not needing/using clustering should consider 5.5.9 stable.
Yoav Shapira
System Design and Management Fellow
MIT Sloan School of Management / School of Engineering
Cambridge, MA USA
[EMAIL PROTECTED] / [EMAIL PROTECTED]
 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: Building Question

2005-04-10 Thread Remy Maucherat
Henri Gomez wrote:
CLR ?
Bill's doing .not stuff now. He must be using some hidden JDK features, 
as I didn't read about any .not compatibility features in JDK 1.5. Neat 
stuff.

:D
More seriously, Tomcat is built with JDK 1.4, for best compatibility. I 
don't know what the consequences of moving to JDK 1.5 would be.

Rémy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: [VOTE] 5.5.9 Stability

2005-04-10 Thread Remy Maucherat
Peter Rossbach wrote:
I have add my 5.5.9 clustering fix pack to the following bug report:
http://issues.apache.org/bugzilla/show_bug.cgi?id=34389
Wow, it's great you could come up with a patch for 5.5.9 so quickly :)
Rémy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: [VOTE] 5.5.9 Stability

2005-04-10 Thread Peter Rossbach
Thanks,
and I hope Filip has time to review and test it.
Peter.
PS: I am now start to port the fix to my changed 5.5.10 code.
Remy Maucherat schrieb:
Peter Rossbach wrote:
I have add my 5.5.9 clustering fix pack to the following bug report:
http://issues.apache.org/bugzilla/show_bug.cgi?id=34389

Wow, it's great you could come up with a patch for 5.5.9 so quickly :)
Rémy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


DO NOT REPLY [Bug 34390] New: - SEVERE: Exception opening database connection

2005-04-10 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=34390.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34390

   Summary: SEVERE: Exception opening database connection
   Product: Tomcat 5
   Version: 5.5.7
  Platform: PC
   URL: http://kisslet.alphabit.org
OS/Version: Linux
Status: NEW
  Severity: critical
  Priority: P2
 Component: Catalina
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


I was running Sun J2SDK 1.5.0 with Tomcat 5.5.4 and everything was fine.

Then I tried to update to Sun J2RE 1.5.0_02 with Tomcat 5.5.7 and got the error
bellow, now I'm running the new Sun J2SDK 1.5.0_02 with old Tomcat 5.5.4.

With this error I cannot login users (though I have a servlet that accesses the
same database using the same driver with no problem at all).

here it is:

Using CATALINA_BASE: /oem/java/tomcat Using CATALINA_HOME: /oem/java/tomcat
Using CATALINA_TMPDIR: /oem/java/tomcat/temp Using JRE_HOME: 
/usr/lib/j2re1.5-sun

Apr 10, 2005 2:06:19 PM org.apache.coyote.http11.Http11Protocol init
INFO: Initializing Coyote HTTP/1.1 on http-443
Apr 10, 2005 2:06:19 PM org.apache.coyote.http11.Http11Protocol init
INFO: Initializing Coyote HTTP/1.1 on http-80
Apr 10, 2005 2:06:19 PM org.apache.catalina.startup.Catalina load
INFO: Initialization processed in 2813 ms
Apr 10, 2005 2:06:19 PM org.apache.catalina.core.StandardService start
INFO: Starting service HTTPS public service
Apr 10, 2005 2:06:19 PM org.apache.catalina.core.StandardEngine start
INFO: Starting Servlet Engine: Apache Tomcat/5.5.7
Apr 10, 2005 2:06:19 PM org.apache.catalina.core.StandardHost start
INFO: XML validation disabled
Apr 10, 2005 2:06:20 PM org.apache.catalina.startup.ContextConfig
validateSecurityRoles
INFO: WARNING: Security role name blog used in an auth-constraint without
being defined in a security-role
Apr 10, 2005 2:06:20 PM org.apache.catalina.realm.JAASRealm setContainer
INFO: Set JAAS app name SSL public engine engine
Apr 10, 2005 2:06:21 PM org.apache.catalina.startup.ContextConfig
applicationWebConfig
INFO: Missing application web.xml, using defaults only StandardEngine[SSL public
engine engine].StandardHost[private.alphabit.org].StandardContext[/static]
Apr 10, 2005 2:06:22 PM org.apache.coyote.http11.Http11Protocol start
INFO: Starting Coyote HTTP/1.1 on http-443
Apr 10, 2005 2:06:22 PM org.apache.catalina.core.StandardService start
INFO: Starting service HTTP public service
Apr 10, 2005 2:06:22 PM org.apache.catalina.core.StandardEngine start
INFO: Starting Servlet Engine: Apache Tomcat/5.5.7
Apr 10, 2005 2:06:22 PM org.apache.catalina.realm.JDBCRealm start
SEVERE: Exception opening database connection
java.sql.SQLException: org.postgresql.Driver
at org.apache.catalina.realm.JDBCRealm.open(JDBCRealm.java:646)
at org.apache.catalina.realm.JDBCRealm.start(JDBCRealm.java:720)
at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1003)
at 
org.apache.catalina.core.StandardEngine.start(StandardEngine.java:440)
at 
org.apache.catalina.core.StandardService.start(StandardService.java:450)
at 
org.apache.catalina.core.StandardServer.start(StandardServer.java:683)
at org.apache.catalina.startup.Catalina.start(Catalina.java:537)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:271)
at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:409)
Apr 10, 2005 2:06:22 PM org.apache.catalina.core.StandardHost start

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 34390] - SEVERE: Exception opening database connection

2005-04-10 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=34390.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34390


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2005-04-10 15:48 ---
Although the JDBC realm has severe issues in 5.5.7, this is caused by an
unrelated failure to load the driver.

Feel free to use 5.5.4 all you want, however ;)

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Building Question

2005-04-10 Thread Bill Barker
- Original Message - 
From: Henri Gomez [EMAIL PROTECTED]
To: Tomcat Developers List tomcat-dev@jakarta.apache.org
Sent: Saturday, April 09, 2005 11:45 PM
Subject: Re: Building Question


CLR ?
Typo.  It should be CRLs.  As in java.security.cert.CRL.
On Apr 10, 2005 3:33 AM, Yoav Shapira [EMAIL PROTECTED] wrote:
Hi,
 I'm thinking of starting on implementing CLRs for Tomcat 5.5.  However,
 it's
 a PITA for  1.5.  I wanted to check that the binary builds for TC 5.5 
 are
 being built with JDK 1.5, or, I'm probably wasting my time (not many
 people
 use the source distro :).

I've been building with 1.4, using the build as a final check that we 
have
no 1.5-only code.

Yoav Shapira
System Design and Management Fellow
MIT Sloan School of Management / School of Engineering
Cambridge, MA USA
[EMAIL PROTECTED] / [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


This message is intended only for the use of the person(s) listed above as 
the intended recipient(s), and may contain information that is PRIVILEGED and 
CONFIDENTIAL.  If you are not an intended recipient, you may not read, copy, or 
distribute this message or any attachment. If you received this communication 
in error, please notify us immediately by e-mail and then delete all copies of 
this message and any attachments.
In addition you should be aware that ordinary (unencrypted) e-mail sent through 
the Internet is not secure. Do not send confidential or sensitive information, 
such as social security numbers, account numbers, personal identification 
numbers and passwords, to us via ordinary (unencrypted) e-mail.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/io SocketObjectReader.java Jdk13ObjectReader.java

2005-04-10 Thread pero
pero2005/04/10 09:20:46

  Modified:modules/cluster/src/share/org/apache/catalina/cluster
CatalinaCluster.java ClusterReceiver.java
ClusterSender.java
   modules/cluster/src/share/org/apache/catalina/cluster/session
DeltaManager.java JvmRouteBinderValve.java
JvmRouteSessionIDBinderListener.java
ReplicatedSession.java SessionIDMessage.java
mbeans-descriptors.xml
   modules/cluster/src/share/org/apache/catalina/cluster/tcp
AsyncSocketSender.java DataSender.java
FastAsyncSocketSender.java LocalStrings.properties
PooledSocketSender.java ReplicationListener.java
ReplicationTransmitter.java ReplicationValve.java
SendMessageData.java SimpleTcpCluster.java
TcpReplicationThread.java WorkerThread.java
mbeans-descriptors.xml
   modules/cluster/test/src/share/org/apache/catalina/cluster/tcp
DataSenderTest.java
   modules/cluster to-do.txt
  Added:   modules/cluster/src/share/org/apache/catalina/cluster
ClusterValve.java
   modules/cluster/src/share/org/apache/catalina/cluster/session
ClusterListener.java ClusterSessionListener.java
   modules/cluster/src/share/org/apache/catalina/cluster/tcp
ClusterReceiverBase.java
SocketReplicationListener.java
SocketReplicationThread.java
   modules/cluster/src/share/org/apache/catalina/cluster/io
SocketObjectReader.java
  Removed: modules/cluster/src/share/org/apache/catalina/cluster/tcp
Jdk13ReplicationListener.java
   modules/cluster/src/share/org/apache/catalina/cluster/io
Jdk13ObjectReader.java
  Log:
  Refactor and redesign a lot.
  s. changelog.
  
  Revision  ChangesPath
  1.10  +9 -2  
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/CatalinaCluster.java
  
  
http://cvs.apache.org/viewcvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/CatalinaCluster.java.diff?r1=1.9r2=1.10
  
  
  1.5   +4 -1  
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/ClusterReceiver.java
  
  
http://cvs.apache.org/viewcvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/ClusterReceiver.java.diff?r1=1.4r2=1.5
  
  
  1.6   +3 -0  
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/ClusterSender.java
  
  
http://cvs.apache.org/viewcvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/ClusterSender.java.diff?r1=1.5r2=1.6
  
  
  1.1  
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/ClusterValve.java
  
  
http://cvs.apache.org/viewcvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/ClusterValve.java?rev=1.1
  
  
  1.42  +298 -123  
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaManager.java
  
  
http://cvs.apache.org/viewcvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaManager.java.diff?r1=1.41r2=1.42
  
  
  1.6   +42 -18
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/JvmRouteBinderValve.java
  
  
http://cvs.apache.org/viewcvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/JvmRouteBinderValve.java.diff?r1=1.5r2=1.6
  
  
  1.3   +7 -37 
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/JvmRouteSessionIDBinderListener.java
  
  
http://cvs.apache.org/viewcvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/JvmRouteSessionIDBinderListener.java.diff?r1=1.2r2=1.3
  
  
  1.17  +2 -3  
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/ReplicatedSession.java
  
  
http://cvs.apache.org/viewcvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/ReplicatedSession.java.diff?r1=1.16r2=1.17
  
  
  1.4   +1 -0  
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/SessionIDMessage.java
  
  
http://cvs.apache.org/viewcvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/SessionIDMessage.java.diff?r1=1.3r2=1.4
  
  
  1.3   +197 -2
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/mbeans-descriptors.xml
  
  

cvs commit: jakarta-tomcat-catalina/modules/storeconfig/src/share/org/apache/catalina/storeconfig CatalinaClusterSF.java StandardHostSF.java server-registry.xml

2005-04-10 Thread pero
pero2005/04/10 09:22:15

  Modified:modules/storeconfig build.xml
   modules/storeconfig/src/share/org/apache/catalina/storeconfig
CatalinaClusterSF.java StandardHostSF.java
server-registry.xml
  Log:
  Add new Listener, ClusterListener and Valve Cluster subelement config options
  
  Revision  ChangesPath
  1.3   +11 -7 jakarta-tomcat-catalina/modules/storeconfig/build.xml
  
  Index: build.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/modules/storeconfig/build.xml,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- build.xml 11 Feb 2005 19:46:01 -  1.2
  +++ build.xml 10 Apr 2005 16:22:15 -  1.3
  @@ -5,13 +5,13 @@
   
!-- See build.properties.sample in the top level directory for all   
  --
!-- property values you must customize for successful building!!!  
  --
  - !--property file=build.properties/
  -  property file=../build.properties/
  -  property file=${user.home}/build.properties/--
  -
  - !-- Build Defaults --
  - property name=catalina.build location=../.. /
  - property name=config.build 
value=${catalina.home}/modules/storeconfig/build /
  +property file=../../../build.properties /
  +property file=../../../jakarta-tomcat-5/build.properties.default /
  +
  +!-- Build Defaults --
  +property name=catalina.home  location=../../
  +property name=catalina.build 
location=../../../jakarta-tomcat-5/build/
  +property name=config.build 
value=${catalina.home}/modules/storeconfig/build /
property name=config.dist 
value=${catalina.home}/modules/storeconfig/dist /
   
!-- Construct Catalina classpath --
  @@ -119,6 +119,10 @@
/jar
/target
   
  +target name=copy depends=dist 
  +   copy file=${cluster.dist}/catalina-storeconfig.jar 
todir=${catalina.build}/server/lib /
  +   /target
  +
!--  DIST: Clean Directory 
= --
   
   
  
  
  
  1.3   +5 -20 
jakarta-tomcat-catalina/modules/storeconfig/src/share/org/apache/catalina/storeconfig/CatalinaClusterSF.java
  
  Index: CatalinaClusterSF.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/modules/storeconfig/src/share/org/apache/catalina/storeconfig/CatalinaClusterSF.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- CatalinaClusterSF.java3 Apr 2005 16:05:10 -   1.2
  +++ CatalinaClusterSF.java10 Apr 2005 16:22:15 -  1.3
  @@ -81,24 +81,10 @@
   storeElement(aWriter, indent, deployer);
   }
   // Store nested Valve element
  -// ReplicationValve are not store at Hosts element, see
  -// Host transient child list!
  -Valve valve = cluster.getValve();
  -if (valve != null) {
  -IStoreFactory elementFactory = 
getRegistry().findStoreFactory(
  -valve.getClass());
  -if (elementFactory != null) {
  -StoreDescription desc = getRegistry().findDescription(
  -valve.getClass());
  -elementFactory.store(aWriter, indent, valve);
  -}
  -}
  -// Store nested Valve pipeline elements
  -/*   if (aCluster instanceof SimpleTcpCluster) {
  -   Valve valves[] = ((Pipeline) 
((SimpleTcpCluster)cluster).getValves();
  -   storeElementArray(aWriter, indent, valves);
  -   }
  -   */
  +// ClusterValve are not store at Hosts element, see
  +Valve valves[] = cluster.getValves();
  +storeElementArray(aWriter, indent, valves);
  + 
   if (aCluster instanceof SimpleTcpCluster) {
   // Store nested Listener elements
   LifecycleListener listeners[] = 
((SimpleTcpCluster)cluster).findLifecycleListeners();
  @@ -106,8 +92,7 @@
   // Store nested ClusterListener elements
   MessageListener mlisteners[] = 
((SimpleTcpCluster)cluster).findClusterListeners();
   storeElementArray(aWriter, indent, mlisteners);
  -}
  -
  +}
   }
   }
   }
  \ No newline at end of file
  
  
  
  1.2   +11 -1 
jakarta-tomcat-catalina/modules/storeconfig/src/share/org/apache/catalina/storeconfig/StandardHostSF.java
  
  Index: StandardHostSF.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/modules/storeconfig/src/share/org/apache/catalina/storeconfig/StandardHostSF.java,v
  retrieving revision 1.1
  

cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk mbeans-descriptors.xml

2005-04-10 Thread pero
pero2005/04/10 09:23:08

  Modified:jk/java/org/apache/jk/common HandlerRequest.java
   jk/java/org/apache/jk mbeans-descriptors.xml
  Log:
  Add some JMX Attributes and operations.
  
  Revision  ChangesPath
  1.44  +4 -1  
jakarta-tomcat-connectors/jk/java/org/apache/jk/common/HandlerRequest.java
  
  Index: HandlerRequest.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jk/java/org/apache/jk/common/HandlerRequest.java,v
  retrieving revision 1.43
  retrieving revision 1.44
  diff -u -r1.43 -r1.44
  --- HandlerRequest.java   29 Jan 2005 19:29:55 -  1.43
  +++ HandlerRequest.java   10 Apr 2005 16:23:08 -  1.44
  @@ -557,6 +557,8 @@
   msg.getBytes( tmpMB );
   String v=tmpMB.toString();
   req.setAttribute(n, v );
  +if(log.isTraceEnabled())
  +log.trace(jk Attribute set  + n + = + v);
   }
   
   
  @@ -627,7 +629,8 @@
   case SC_A_SECRET  :
   msg.getBytes(tmpMB);
   String secret=tmpMB.toString();
  -log.info(Secret:  + secret );
  +if(log.isInfoEnabled())
  +log.info(Secret:  + secret );
   // endpoint note
   ep.setNote( secretNote, secret );
   break;
  
  
  
  1.4   +69 -3 
jakarta-tomcat-connectors/jk/java/org/apache/jk/mbeans-descriptors.xml
  
  Index: mbeans-descriptors.xml
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jk/java/org/apache/jk/mbeans-descriptors.xml,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- mbeans-descriptors.xml11 Apr 2003 20:21:39 -  1.3
  +++ mbeans-descriptors.xml10 Apr 2005 16:23:08 -  1.4
  @@ -15,9 +15,75 @@
group=Jk
type=org.apache.jk.common.ChannelSocket
   
  -attribute name=port
  -   description=Destination port
  -   type=java.lang.Integer/
  +attribute   name=port
  +  description=The port number on which we listen for ajp13 requests
  +type=int/
  +attribute   name=maxPort
  +  description=The max port number on which we listen for ajp13 
requests
  +type=int/
  +attribute   name=address
  +  description=The IP address on which to bind
  + type=java.lang.String/
  +attribute   name=maxSpareThreads
  +  description=The maximum number of unused request processing 
threads
  + type=int/
  +attribute   name=maxThreads
  +  description=The maximum number of request processing threads to 
be created
  + type=int/
  +attribute   name=minSpareThreads
  +  description=The number of request processing threads that will be 
created
  + type=int/
  +attribute   name=tcpNoDelay
  +  description=Should we use TCP no delay?
  + type=boolean/
  +attribute   name=soLinger
  +  description=Linger value on the incoming connection
  + type=int/
  +attribute   name=soTimeout
  +  description=Socket timeout
  + type=int/
  +attribute   name=requestCount
  +  description=current request count
  + type=int
  +writeable=false/
  +attribute   name=daemon
  +  description=are worker threads on daemon mode
  + type=boolean
  +writeable=false/
  +
  +operation name=start
  +   description=Start, if server socket no create call init
  +   impact=ACTION
  +   returnType=void /
  +operation name=stop
  +   description=Stop
  +   impact=ACTION
  +   returnType=void /
  +operation name=pause
  +   description=Pause ajp socket, no new connection accepted
  +   impact=ACTION
  +   returnType=void/
  +operation name=resume
  +   description=Resume socket for new connections
  +   impact=ACTION
  +   returnType=void/
  +operation name=reinit
  +   description=Init and Destroy
  +   impact=ACTION
  +   returnType=void /
  +operation name=init
  +   description=Init
  +   impact=ACTION
  +   returnType=void /
  +operation name=destroy
  +   description=Destroy
  +   impact=ACTION
  +   returnType=void /
  +operation name=resetCounters
  +   description=reset request counter
  +   impact=ACTION
  +   returnType=void/
  +
   
 /mbean
   
  
  
  


cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml

2005-04-10 Thread pero
pero2005/04/10 09:27:13

  Modified:webapps/docs changelog.xml
  Log:
  Cluster refactor and redesign a lot and porting the cluster 5.5.9 fix pack 
result.
  s. bug report http://issues.apache.org/bugzilla/show_bug.cgi?id=34389
  
  Revision  ChangesPath
  1.285 +42 -6 jakarta-tomcat-catalina/webapps/docs/changelog.xml
  
  Index: changelog.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v
  retrieving revision 1.284
  retrieving revision 1.285
  diff -u -r1.284 -r1.285
  --- changelog.xml 9 Apr 2005 19:30:37 -   1.284
  +++ changelog.xml 10 Apr 2005 16:27:13 -  1.285
  @@ -56,7 +56,8 @@
 [Modified patch from Ralf Hauser] (yoavs)
 /add
 add
  -  Add MessageListener and LifecylceListener cluster saving to 
storeconfig module (pero)
  +  Add MessageListener and LifecylceListener cluster saving to 
storeconfig module
  +  (lt;Cluster ... gt;lt;ClusterListener 
className=org.apache.catalina.cluster.session.JvmRouteSessionIDBinderListener 
gt;) (pero)
 /add  
 fix
   bug33743/bug: Add additional synchronization in webapp 
classloader to avoid
  @@ -87,6 +88,9 @@
 update
   Add support for using Smart Cards as trust/keyStore. (billbarker)
 /update
  +  update
  +Add some Mbean attributes and operations to ChannelSocket (pero)
  +  /update
/changelog
 /subsection
   
  @@ -109,12 +113,42 @@
 /subsection
 
 subsection name=Cluster
  -changelog
  +changelog
  +  add
  +DataSender doWaitAckStats for better understanding wait ack problems 
(pero)   
  +  /add  
  +  update
  +Refactor DeltaManager and add counter for cluster message 
send/receive message (pero)  
  +  /update  
  +  fix
  +bug34389/bug:Porting Clustering fix pack to 5.5.10 code base.
  +Remove synchonized from DataSender.pushMessage(). Very offen the 
  +complete cluster blocking after replicated a bulk of new session 
messages under heavy load.
  +All cluster node standing for a lot of time and made nothing. 
  +Fix it for pooled, asynchronous and fastasyncqueue replication mode. 
Very bad thing, sorry! (pero)  
  +  /fix
  +  add
  +Add notifySessionListenersOnReplication attribute to 
SimpleTcpCluster to stop notify 
  +event to SessionListener at backup nodes from create and destroy 
replicated session (pero)
  +  /add
  +  add
  +Add compress attribute to ClusterSender and ClusterReceiver 
interface. Now compress config
  +transfer from sender to receiver at SimpleTcpCluster. (pero) 
  +  /add
  +  add
  +Add ClusterValve interface and implement it as ReplicationValve and 
JvmRouteBinderValve. Now both
  +Valves can be directly configured at server.xml Host/Cluster/Valve 
subelements.
  +Also this configuration are correctly handled with the StoreConfig 
module. (pero)  
  +  /add
  +  update
  +Deactivate DataSender keepAliveMaxRequestCount change default to -1. 
  +Cluster replication sockets are fast and very stable! (pero)  
  +  /update  
 update
   Setup JvmRouteBinderValve as host valve instead context valve. 
Refactor the API a little bit. (pero)
 /update
 fix
  -Don't increment open socket counter before socket is really open, 
counte socket open failures (pero) 
  +Don't increment open socket counter before socket is really open. 
Add socket open failures counter (pero) 
 /fix  
 add
   Add MessageListener support to cluster server.xml element 
(ClusterListener) to 
  @@ -130,9 +164,11 @@
   at ReplicationTransmitter.  Check frequency can be change with 
attribute 
   processSenderFrequency (default 2). (pero)
 /add
  -  fix
  -Jdk13ReplicationListener active threads closed, when stop called 
(pero)
  -  /fix
  +  add
  +Remove useless Jdk13ReplicationListener,Jdk13ObjectReader. 
  +Add SocketReplicationListener and SocketObjectReader to have nativ 
socket ClusterReceiver. 
  +Also extract ClusterReceiverBase superclass for 
SocketReplicationListener and ReplicationListener (pero) 
  +  /add
 update
   Add and update some API documentation (pero)
 /update
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp FastAsyncSocketSender.java

2005-04-10 Thread pero
pero2005/04/10 09:54:06

  Modified:modules/cluster/src/share/org/apache/catalina/cluster/tcp
FastAsyncSocketSender.java
  Log:
  fix correct nr of queued bytes stats.
  missing sync
  
  Revision  ChangesPath
  1.4   +4 -4  
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/FastAsyncSocketSender.java
  
  Index: FastAsyncSocketSender.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/FastAsyncSocketSender.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- FastAsyncSocketSender.java10 Apr 2005 16:20:46 -  1.3
  +++ FastAsyncSocketSender.java10 Apr 2005 16:54:06 -  1.4
  @@ -401,15 +401,15 @@
   return queuedNrOfBytes ;
   }
   
  -protected void setQueuedNrOfBytes(long queuedNrOfBytes) {
  +protected synchronized void setQueuedNrOfBytes(long queuedNrOfBytes) 
{
   this.queuedNrOfBytes = queuedNrOfBytes;
   }
   
  -protected void incQueuedNrOfBytes(long size) {
  +protected synchronized void incQueuedNrOfBytes(long size) {
   queuedNrOfBytes += size;
   }
   
  -protected void decQueuedNrOfBytes(long size) {
  +protected synchronized void decQueuedNrOfBytes(long size) {
   queuedNrOfBytes -= size;
   }
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core ApplicationDispatcher.java ApplicationHttpRequest.java

2005-04-10 Thread markt
markt   2005/04/10 11:22:56

  Modified:catalina/src/share/org/apache/catalina/core
ApplicationDispatcher.java
ApplicationHttpRequest.java
  Log:
  Fix bug 22013. RequestDispatcher.forward doesn't work with a relative path on
  a forwarded request
  - Patch supplied by Cedric Benazech
  
  Revision  ChangesPath
  1.33  +3 -2  
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/ApplicationDispatcher.java
  
  Index: ApplicationDispatcher.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/ApplicationDispatcher.java,v
  retrieving revision 1.32
  retrieving revision 1.33
  diff -u -r1.32 -r1.33
  --- ApplicationDispatcher.java26 Aug 2004 21:31:21 -  1.32
  +++ ApplicationDispatcher.java10 Apr 2005 18:22:56 -  1.33
  @@ -861,7 +861,8 @@
   if ((current instanceof ApplicationHttpRequest) ||
   (current instanceof HttpRequest) ||
   (current instanceof HttpServletRequest))
  -wrapper = new ApplicationHttpRequest((HttpServletRequest) 
current);
  +wrapper = new ApplicationHttpRequest(
  +(HttpServletRequest) current, context);
   else
   wrapper = new ApplicationRequest(current);
   if (previous == null)
  
  
  
  1.16  +51 -8 
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/ApplicationHttpRequest.java
  
  Index: ApplicationHttpRequest.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/ApplicationHttpRequest.java,v
  retrieving revision 1.15
  retrieving revision 1.16
  diff -u -r1.15 -r1.16
  --- ApplicationHttpRequest.java   15 Jan 2005 20:27:05 -  1.15
  +++ ApplicationHttpRequest.java   10 Apr 2005 18:22:56 -  1.16
  @@ -23,8 +23,12 @@
   import java.util.HashMap;
   import java.util.Iterator;
   import java.util.Map;
  +
  +import javax.servlet.RequestDispatcher;
   import javax.servlet.http.HttpServletRequest;
   import javax.servlet.http.HttpServletRequestWrapper;
  +
  +import org.apache.catalina.Context;
   import org.apache.catalina.Globals;
   import org.apache.catalina.util.Enumerator;
   import org.apache.catalina.util.RequestUtil;
  @@ -49,7 +53,6 @@
   
   class ApplicationHttpRequest extends HttpServletRequestWrapper {
   
  -
   // --- Static 
Variables
   
   
  @@ -62,24 +65,28 @@
 Globals.QUERY_STRING_ATTR };
   
   
  -// --- 
Constructors
   
  +// --- 
Constructors
   
   /**
  - * Construct a new wrapped request around the specified servlet request.
  + * Construct a new wrapped request around the specified servlet request 
in
  + * the specified context.
*
* @param request The servlet request being wrapped
  + * @param context The Context this ApplicationHttpRequest is associated 
with
*/
  -public ApplicationHttpRequest(HttpServletRequest request) {
  -
  +public ApplicationHttpRequest(HttpServletRequest request, Context 
context) {
   super(request);
   setRequest(request);
  -
  +this.context = context;
   }
   
  -
   // - Instance 
Variables
   
  +/**
  + * The Context this ApplicationHttpRequest is associated with.
  + */
  +protected Context context;
   
   /**
* The request attributes for this request.  This is initialized from the
  @@ -377,6 +384,42 @@
   
   
   /**
  + * Return a RequestDispatcher that wraps the resource at the specified
  + * path, which may be interpreted as relative to the current request 
path.
  + *
  + * @param path Path of the resource to be wrapped
  + */
  +public RequestDispatcher getRequestDispatcher(String path) {
  +
  +if (context == null)
  +return (null);
  +
  +// If the path is already context-relative, just pass it through
  +if (path == null)
  +return (null);
  +else if (path.startsWith(/))
  +return (context.getServletContext().getRequestDispatcher(path));
  +
  +// Convert a request-relative path to a context-relative one
  +String servletPath = (String) 
getAttribute(Globals.SERVLET_PATH_ATTR);
  +if (servletPath == null)
  +servletPath = getServletPath();
  +
  +int pos = servletPath.lastIndexOf('/');
  +String relative = null;
  +if (pos = 0) {
  +relative = RequestUtil.normalize
  +(servletPath.substring(0, pos + 1) + path);
  +   

DO NOT REPLY [Bug 22013] - RequestDispatcher.forward doesn't work with a relative path on a forwarded request

2005-04-10 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=22013.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=22013


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-04-10 20:23 ---
This is now fixed in TC4. It was fixed in TC5 some time ago (in 5.0.7).

Many thanks for the patch.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: New TLP draft

2005-04-10 Thread Yoav Shapira
Hi,

 Code changes to jakarta-servletapi are still 'special' - since it must
 be an exact copy of the spec. But I see no reason for watchdog - it was
 supposed to be the semi-official test suite, but now Sun provides an
 official one, so watchdog is useless anyway.

Watchdog is dormant.  As such, any Jakarta committer requesting karma for it
will have it granted.  There's no need for a vote or anything.

 But both should go with tomcat - since the servlet API implementation is
 part of tomcat charter ( and I assume it will be removed from jakarta
 charter :-)

Yes.

 I think the avail should be consistent in the new TLP - i.e. all tomcat
 committers have access to all tomcat modules.

Yup, except servletapi-x, which is special as you mentioned above, to my
chagrin ;)

I'd like to join the expert group and have karma for it as well.  I suppose
I'll go read up on that process.

Yoav Shapira
System Design and Management Fellow
MIT Sloan School of Management / School of Engineering
Cambridge, MA USA
[EMAIL PROTECTED] / [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml

2005-04-10 Thread pero
pero2005/04/10 12:29:09

  Modified:modules/cluster/src/share/org/apache/catalina/cluster/session
DeltaManager.java mbeans-descriptors.xml
   webapps/docs changelog.xml
  Log:
  DeltaManager has now JMX expireAllLocalSessions and processExipre operation
  for better cluster node shutdown handling
  
  Revision  ChangesPath
  1.43  +32 -1 
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaManager.java
  
  Index: DeltaManager.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaManager.java,v
  retrieving revision 1.42
  retrieving revision 1.43
  diff -u -r1.42 -r1.43
  --- DeltaManager.java 10 Apr 2005 16:20:46 -  1.42
  +++ DeltaManager.java 10 Apr 2005 19:29:09 -  1.43
  @@ -1033,6 +1033,37 @@
   }
   
   /**
  + * Exipre all find sessions.
  + */
  +public void expireAllLocalSessions()
  +{
  +long timeNow = System.currentTimeMillis();
  +Session sessions[] = findSessions();
  +int expireDirect  = 0 ;
  +int expireIndirect = 0 ;
  +
  +if(log.isDebugEnabled())
  +log.debug(Start expire all sessions  + getName() +  at  + 
timeNow +  sessioncount  + sessions.length);
  +for (int i = 0; i  sessions.length; i++) {
  +if (sessions[i] instanceof DeltaSession) {
  +DeltaSession session = (DeltaSession) sessions[i];
  +if (session.isPrimarySession()) {
  +if (session.isValid()) {
  +session.expire();
  +expireDirect++;
  +} else {
  +expireIndirect++;
  +}
  +}
  +}
  +}
  +long timeEnd = System.currentTimeMillis();
  +if(log.isDebugEnabled())
  + log.debug(End expire sessions  + getName() +  exipre 
processingTime  + (timeEnd - timeNow) +  expired direct sessions:  + 
expireDirect +  expired direct sessions:  + expireIndirect);
  +  
  +}
  +
  +/**
* When the manager expires session not tied to a request. The cluster 
will
* periodically ask for a list of sessions that should expire and that
* should be sent across the wire.
  
  
  
  1.4   +12 -0 
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/mbeans-descriptors.xml
  
  Index: mbeans-descriptors.xml
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/mbeans-descriptors.xml,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- mbeans-descriptors.xml10 Apr 2005 16:20:46 -  1.3
  +++ mbeans-descriptors.xml10 Apr 2005 19:29:09 -  1.4
  @@ -215,6 +215,18 @@
type=java.lang.String/
   /operation
   
  + operation name=expireAllLocalSessions
  +   description=Exipre all active local sessions and replicate 
the invalid sessions
  +   impact=ACTION
  +   returnType=void
  +/operation
  +
  + operation name=processExpires
  +   description=force process to expire sessions
  +   impact=ACTION
  +   returnType=void
  +/operation
  +
operation name=resetStatistics
  description=Reset all statistics
  impact=ACTION
  
  
  
  1.286 +4 -0  jakarta-tomcat-catalina/webapps/docs/changelog.xml
  
  Index: changelog.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v
  retrieving revision 1.285
  retrieving revision 1.286
  diff -u -r1.285 -r1.286
  --- changelog.xml 10 Apr 2005 16:27:13 -  1.285
  +++ changelog.xml 10 Apr 2005 19:29:09 -  1.286
  @@ -115,6 +115,10 @@
 subsection name=Cluster
   changelog
 add
  +DeltaManager has now JMX expireAllLocalSessions and processExipre 
operation 
  +for better cluster node shutdown handling (pero)   
  +  /add  
  +  add
   DataSender doWaitAckStats for better understanding wait ack problems 
(pero)   
 /add  
 update
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 34299] - Http11Processor intermittently throwing ArrayIndexOutOfBoundsException

2005-04-10 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=34299.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34299


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2005-04-10 23:00 ---
It happens when the maximum http header size is exceeded.

For Tomcat 4.1.31 (and the latest 5.0.x and 5.5.x releases) the
maxHttpHeaderSize attribute on the http connector may be used to set the maximum
allowed size of http headers.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 34159] - Charset extension through jdk1.4 CharsetProvider does not work in web applications

2005-04-10 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=34159.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34159


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2005-04-10 23:03 ---
Since there has been no response to my previous comment I am going to assume
that this was a configuration/file location issue and therefore resolve this as
invalid.

If this is not the case, please re-open the bug and if possible provide a test
case that demonstrates the issue you are seeing.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/util build.xml

2005-04-10 Thread billbarker
billbarker2005/04/10 15:19:00

  Modified:util build.xml
  Log:
  Add checks for JDK 1.5.
  
  Revision  ChangesPath
  1.31  +3 -0  jakarta-tomcat-connectors/util/build.xml
  
  Index: build.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/util/build.xml,v
  retrieving revision 1.30
  retrieving revision 1.31
  diff -u -r1.30 -r1.31
  --- build.xml 6 Oct 2004 15:41:44 -   1.30
  +++ build.xml 10 Apr 2005 22:19:00 -  1.31
  @@ -43,6 +43,7 @@
   available property=commons-logging.present 
file=${commons-logging.jar}/
   available property=modeler.present file=${commons-modeler.jar}/
available property=jdk1.4.present classname=java.lang.CharSequence 
/
  +available property=jdk1.5.present 
classname=javax.net.ssl.CertPathTrustManagerParameters /
   /target
   
   target name=build-prepare depends=detect
  @@ -61,6 +62,7 @@
   echo message=-- jmx = ${jmx.present} ${jmx.jar}/
   echo message=-- modeler = ${modeler.present} 
${commons-modeler.jar}/
   echo message=-- JDK14 = ${jdk1.4.present}/
  +echo message=-- JDK15 = ${jdk1.5.present} /
   
   javac srcdir=java
   destdir=${tomcat-util.build}/classes
  @@ -77,6 +79,7 @@
   exclude name=**/util/threads/ThreadPoolMX* 
unless=modeler.present/
   exclude name=**/util/compat/Jdk14Compat.java 
unless=jdk1.4.present /
   exclude name=**/util/net/jsse/JSSE14* unless=jdk1.4.present 
/
  +exclude name=**/util/net/jsse/JSSE15* unless=jdk1.5.present 
/
   exclude name=**/util/net/jsse/JSSEKeyManager.java 
unless=jdk1.4.present /
   /javac
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse JSSE15Factory.java JSSE15SocketFactory.java JSSEImplementation.java

2005-04-10 Thread billbarker
billbarker2005/04/10 16:48:44

  Modified:util/java/org/apache/tomcat/util/net/jsse
JSSEImplementation.java
  Added:   util/java/org/apache/tomcat/util/net/jsse JSSE15Factory.java
JSSE15SocketFactory.java
  Log:
  Adding support for CRLs, at least with JDK 1.5
  
  Revision  ChangesPath
  1.10  +24 -14
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse/JSSEImplementation.java
  
  Index: JSSEImplementation.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse/JSSEImplementation.java,v
  retrieving revision 1.9
  retrieving revision 1.10
  diff -u -r1.9 -r1.10
  --- JSSEImplementation.java   24 Feb 2004 08:50:05 -  1.9
  +++ JSSEImplementation.java   10 Apr 2005 23:48:44 -  1.10
  @@ -32,6 +32,8 @@
   
   public class JSSEImplementation extends SSLImplementation
   {
  +static final String JSSE15Factory =
  + org.apache.tomcat.util.net.jsse.JSSE15Factory;
   static final String JSSE14Factory = 
   org.apache.tomcat.util.net.jsse.JSSE14Factory;
   static final String JSSE13Factory = 
  @@ -41,24 +43,32 @@
   static org.apache.commons.logging.Log logger = 
   
org.apache.commons.logging.LogFactory.getLog(JSSEImplementation.class);
   
  -private JSSEFactory factory;
  +private JSSEFactory factory = null;
   
   public JSSEImplementation() throws ClassNotFoundException {
   // Check to see if JSSE is floating around somewhere
   Class.forName(SSLSocketClass);
  - if( JdkCompat.isJava14() ) {
  - try {
  - Class factcl = Class.forName(JSSE14Factory);
  - factory = (JSSEFactory)factcl.newInstance();
  - } catch(Exception ex) {
  - factory = new JSSE13Factory();
  - if(logger.isDebugEnabled()) {
  - logger.debug(Error getting factory:  + JSSE14Factory, ex);
  - }
  - }
  - } else {
  - factory = new JSSE13Factory();
  - }
  +if( JdkCompat.isJava15() ) {
  +try {
  +Class factcl = Class.forName(JSSE15Factory);
  +factory = (JSSEFactory)factcl.newInstance();
  +} catch(Exception ex) {
  +if(logger.isDebugEnabled())
  +logger.debug(Error getting factory:  + JSSE15Factory, 
ex);
  +}
  +}
  +if(factory == null  JdkCompat.isJava14() ) {
  +try {
  +Class factcl = Class.forName(JSSE14Factory);
  +factory = (JSSEFactory)factcl.newInstance();
  +} catch(Exception ex) {
  +if(logger.isDebugEnabled()) {
  +logger.debug(Error getting factory:  + JSSE14Factory, 
ex);
  +}
  +}
  +} if(factory == null) {
  +factory = new JSSE13Factory();
  +}
   }
   
   
  
  
  
  1.1  
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse/JSSE15Factory.java
  
  Index: JSSE15Factory.java
  ===
  /*
   *  Copyright 1999-2004 The Apache Software Foundation
   *
   *  Licensed under the Apache License, Version 2.0 (the License);
   *  you may not use this file except in compliance with the License.
   *  You may obtain a copy of the License at
   *
   *  http://www.apache.org/licenses/LICENSE-2.0
   *
   *  Unless required by applicable law or agreed to in writing, software
   *  distributed under the License is distributed on an AS IS BASIS,
   *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
   *  See the License for the specific language governing permissions and
   *  limitations under the License.
   */
  
  package org.apache.tomcat.util.net.jsse;
  
  import java.net.Socket;
  import javax.net.ssl.SSLSocket;
  import org.apache.tomcat.util.net.SSLSupport;
  import org.apache.tomcat.util.net.ServerSocketFactory;
  
  /**
   * Implementation class for JSSEFactory for JSSE 1.1.x (that ships with the
   * 1.5 JVM).
   *
   * @author Bill Barker
   */
  
  class JSSE15Factory extends JSSE14Factory {
  
  JSSE15Factory() {
  super();
  }
  
  public ServerSocketFactory getSocketFactory() {
  return new JSSE15SocketFactory();
  }
  
  }
  
  
  
  1.1  
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse/JSSE15SocketFactory.java
  
  Index: JSSE15SocketFactory.java
  ===
  /*
   *  Copyright 1999-2004 The Apache Software Foundation
   *
   *  Licensed under the Apache License, Version 2.0 (the License);
   *  you may not use this file except in compliance with the License.
   *  You may obtain a copy of the License at

DO NOT REPLY [Bug 33106] - SSI Processing Enhancements (patch provided)

2005-04-10 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33106.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33106





--- Additional Comments From [EMAIL PROTECTED]  2005-04-11 04:08 ---
Created an attachment (id=14675)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=14675action=view)
Final set of diffs

Here it is at long last.  A new set of diffs based on 5.5.9 with the fixes you
proposed.  I've also included web.xml, build.xml and documentation patches. 
Please review the section on the query string decoding you had concerns about
and see if you think I handled it properly.

I've also taken the liberty of making the SSIFilter the default behavior and
deprecating the SSIServlet.  I hope this is OK with everyone.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33106] - SSI Processing Enhancements (patch provided)

2005-04-10 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33106.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33106





--- Additional Comments From [EMAIL PROTECTED]  2005-04-11 04:09 ---
Created an attachment (id=14676)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=14676action=view)
Full set of modified files

Here are the same set of files, but the full files in case you don't feel like
manually applying the patches.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33106] - SSI Processing Enhancements (patch provided)

2005-04-10 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33106.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33106





--- Additional Comments From [EMAIL PROTECTED]  2005-04-11 04:12 ---
BTW, I also made a few other minor fixes based on my experiences working with
these changes in a production environment.  The date parsing of the
last-modified header is a bit more robust and the contentType init parameter was
changed to a regex pattern for more flexibility.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[GUMP@brutus]: Project jakarta-tomcat-jasper_tc5 (in module jakarta-tomcat-jasper_tc5) failed

2005-04-10 Thread bobh
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project jakarta-tomcat-jasper_tc5 has an issue affecting its community 
integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- jakarta-tomcat-jasper_tc5 :  JavaServer Pages JSP 2.0 implementation (for 
Tomcat 5.x)


Full details are available at:

http://brutus.apache.org/gump/public/jakarta-tomcat-jasper_tc5/jakarta-tomcat-jasper_tc5/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Output [jasper-runtime.jar] identifier set to output basename: 
[jasper-runtime]
 -DEBUG- Output [jasper-compiler.jar] identifier set to output basename: 
[jasper-compiler]
 -DEBUG- Dependency on ant exists, no need to add for property ant.jar.
 -INFO- Failed with reason build failed
 -DEBUG- Extracted fallback artifacts from Gump Repository



The following work was performed:
http://brutus.apache.org/gump/public/jakarta-tomcat-jasper_tc5/jakarta-tomcat-jasper_tc5/gump_work/build_jakarta-tomcat-jasper_tc5_jakarta-tomcat-jasper_tc5.html
Work Name: build_jakarta-tomcat-jasper_tc5_jakarta-tomcat-jasper_tc5 (Type: 
Build)
Work ended in a state of : Failed
Elapsed: 5 secs
Command Line: java -Djava.awt.headless=true 
-Xbootclasspath/p:/usr/local/gump/public/workspace/xml-xerces2/java/build/xercesImpl.jar
 org.apache.tools.ant.Main 
-Dgump.merge=/home/gump/workspaces2/public/gump/work/merge.xml 
-Dbuild.sysclasspath=only 
-Djsp-api.jar=/usr/local/gump/public/workspace/jakarta-servletapi-5/jsr152/dist/lib/jsp-api.jar
 
-Dcommons-el.jar=/usr/local/gump/public/workspace/jakarta-commons/el/dist/commons-el.jar
 
-Djasper-compiler-jdt.jar=/usr/local/gump/packages/eclipse-3.0.1/plugins/org.eclipse.jdt.core_3.0.1/jdtcore.jar
 -Dant.jar=/usr/local/gump/public/workspace/ant/dist/lib/ant.jar 
-Dservlet-api.jar=/usr/local/gump/public/workspace/jakarta-servletapi-5/jsr154/dist/lib/servlet-api.jar
 -Dcompile.source=1.4 dist 
[Working Directory: 
/usr/local/gump/public/workspace/jakarta-tomcat-jasper_tc5/jasper2]
CLASSPATH: 
/opt/jdk1.4/lib/tools.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-api.jar:/usr/local/gump/public/workspace/jakarta-commons/el/dist/commons-el.jar:/usr/local/gump/public/workspace/jakarta-servletapi-5/jsr154/dist/lib/servlet-api.jar:/usr/local/gump/public/workspace/jakarta-servletapi-5/jsr152/dist/lib/jsp-api.jar:/usr/local/gump/packages/eclipse-3.0.1/plugins/org.eclipse.jdt.core_3.0.1/jdtcore.jar
-
Buildfile: build.xml

build-prepare:
[mkdir] Created dir: 
/home/gump/workspaces2/public/workspace/jakarta-tomcat-jasper_tc5/jasper2/build
[mkdir] Created dir: 
/home/gump/workspaces2/public/workspace/jakarta-tomcat-jasper_tc5/jasper2/build/bin
[mkdir] Created dir: 
/home/gump/workspaces2/public/workspace/jakarta-tomcat-jasper_tc5/jasper2/build/common/classes
[mkdir] Created dir: 
/home/gump/workspaces2/public/workspace/jakarta-tomcat-jasper_tc5/jasper2/build/common/lib
[mkdir] Created dir: 
/home/gump/workspaces2/public/workspace/jakarta-tomcat-jasper_tc5/jasper2/build/shared/classes
[mkdir] Created dir: 
/home/gump/workspaces2/public/workspace/jakarta-tomcat-jasper_tc5/jasper2/build/shared/lib

copy-launcher.jars:

build-static:
 [copy] Copying 4 files to 
/home/gump/workspaces2/public/workspace/jakarta-tomcat-jasper_tc5/jasper2/build/bin

build-only:
[javac] Compiling 87 source files to 
/home/gump/workspaces2/public/workspace/jakarta-tomcat-jasper_tc5/jasper2/build/shared/classes
[javac] 
/home/gump/workspaces2/public/workspace/jakarta-tomcat-jasper_tc5/jasper2/src/share/org/apache/jasper/compiler/JDTCompiler.java:180:
 cannot resolve symbol
[javac] symbol  : constructor NameEnvironmentAnswer 
(org.eclipse.jdt.internal.compiler.env.ICompilationUnit,nulltype)
[javac] location: class 
org.eclipse.jdt.internal.compiler.env.NameEnvironmentAnswer
[javac] new 
NameEnvironmentAnswer(compilationUnit, null);
[javac] ^
[javac] 

DO NOT REPLY [Bug 34394] New: - Session lost if more than one JSESSIONID exist in the cookie

2005-04-10 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=34394.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34394

   Summary: Session lost if more than one JSESSIONID exist in the
cookie
   Product: Tomcat 4
   Version: 4.1.27
  Platform: All
OS/Version: Windows XP
Status: NEW
  Severity: blocker
  Priority: P2
 Component: Catalina
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


Hi,

Problem I have is that when using IE 6.0.28, I am loosing my session.
Symtoms are.. each time I refresh the jsp page I get a new session ID.

When looking at the headers my jsp page gets from IE, it gets multiple 
JSESSIONID value pairs.
e.g.
cookie : JSESSIONID=A1F4FDB2DCE970FB5350B0B7E3997C72; 
JSESSIONID=284C19AD5ED2498FE7BFECF838EB47A0

to reproduce this ther are two ways, mind you they are not very consistent, 
but usually after a short while you shold get it.

Method 1: Not necessarily happens in real life
usign the test.jsp page, you create another JSESSIONID by either deleteing the 
ID or setting it by clickign the set button. This test may not be valid, but 
it illustrates what IE does when it calls tomcat.

Then each time you refresh this page, you get a new session id adn a new 
session

Method 2: What happenes in real life
using an application that requires two urls, where when you hit the first url, 
it redirects you to a second url. both urls must be a jsp page.
What happens is that IE will send the cookie from teh first url to teh second 
url, then the seoncd jsp page will then not find this session,as it is a 
different site. So it will then send a new id back to IE. IE then appends this 
new id and so you now have 2 JSESSIONID cookies.
Becasue it appends it, Tomcat doesn't see the second cookie and so when it is 
told to refresh or get a new url, it will then create a new session again, adn 
so the cycle begins.


Appendix test.jsp page used for both scenario
html

script
function getCookie(name)
{
var dc = document.cookie;
alert(dc);
var prefix = wconfig.cname.value + =;
var begin = dc.indexOf(;  + prefix);
if (begin == -1)
{
begin = dc.indexOf(prefix);
if (begin != 0) return null;
}
else
{
begin += 2;
}
var end = document.cookie.indexOf(;, begin);
if (end == -1)
{
end = dc.length;
}
alert( unescape(dc.substring(begin + prefix.length, end)));
return true;
}

function setCookie(name, value, expires, path, domain, secure)
{
document.cookie= name + = + escape(value) +
((expires) ? ; expires= + expires.toGMTString() : ) +
((path) ? ; path= + path : ) +
((domain) ? ; domain= + domain : ) +
((secure) ? ; secure : );
}
function deleteCookie(name, path, domain)
{
if (getCookie(name))
{
document.cookie = name + = + 
((path) ? ; path= + path : ) +
((domain) ? ; domain= + domain : ) +
; expires=Thu, 01-Jan-70 00:00:01 GMT;
}
}
/script
body
%

System.out.println( site index Headers 
*);
System.out.println(*** 
Session  + session.getId());
for (java.util.Enumeration e = request.getHeaderNames
() ; e.hasMoreElements() ;) 
{
String headername = (String) e.nextElement();
System.out.println(headername +  :  + 
request.getHeader(headername));
}

%
%= session.getId() %
form name=wconfig
input type=text name=cname value=JSESSIONID/
input type=button name=view onClick=getCookie()/br

input type=text name=cvalue value=%= session.getId() % /
input type=button name=view onClick=setCookie(wconfig.cname.value, 
wconfig.cvalue.value) value=set/

input type=button name=view onClick=deleteCookie(wconfig.cname.value) 
value=del/

/form
a href=test.jspgoto/a
/body
/html

redirct page to place in jsp

html
% newURL = http://blah.com/test.jsp %
META HTTP-EQUIV=Refresh
  CONTENT=0; URL=%= newURL % /
head
/head  
body
If this page does take you to teh Administration page please click on the this 
link a href=%= newURL%Go to site/a
/body
/html

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]