cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/security SecurityClassLoad.java
billbarker2005/08/03 23:07:46
Modified:catalina/src/share/org/apache/catalina/security
SecurityClassLoad.java
Log:
Fix CNFE when starting in a sandbox.
After the last refactoring, the Jk-Java Connector no longer has need of PAs.
If this changes, the method can always be added back.
Revision ChangesPath
1.18 +1 -12
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/security/SecurityClassLoad.java
Index: SecurityClassLoad.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/security/SecurityClassLoad.java,v
retrieving revision 1.17
retrieving revision 1.18
diff -u -r1.17 -r1.18
--- SecurityClassLoad.java24 Jul 2004 07:07:37 - 1.17
+++ SecurityClassLoad.java4 Aug 2005 06:07:46 - 1.18
@@ -43,7 +43,6 @@
loadJavaxPackage(loader);
loadCoyotePackage(loader);
loadHttp11Package(loader);
-loadJkPackage(loader);
}
@@ -198,15 +197,5 @@
Response$3);
}
-private final static void loadJkPackage(ClassLoader loader)
-throws Exception {
-String basePackage = org.apache.jk.;
-loader.loadClass
-(basePackage +
- server.JkCoyoteHandler$1);
-loader.loadClass
-(basePackage +
- server.JkCoyoteHandler$StatusLinePrivilegedAction);
-}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 35894] - Tomcat does not start with security enabled
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=35894. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=35894 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2005-08-04 08:08 --- This is fixed now in the CVS and will appear in 5.5.11. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml
billbarker2005/08/03 23:17:07 Modified:webapps/docs changelog.xml Log: doc changes Revision ChangesPath 1.351 +3 -0 jakarta-tomcat-catalina/webapps/docs/changelog.xml Index: changelog.xml === RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v retrieving revision 1.350 retrieving revision 1.351 diff -u -r1.350 -r1.351 --- changelog.xml 2 Aug 2005 18:12:05 - 1.350 +++ changelog.xml 4 Aug 2005 06:17:07 - 1.351 @@ -65,6 +65,9 @@ update bug34794/bug: Update connector documentation to include clientAuth attribute. (yoavs) /update + fix +bug35894/bug: Fix CNFE when starting in a sandbox. (billbarker) + /fix /changelog /subsection - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Next Release 5.5.11?
Hello, the current release is 5.5.10-alpha. Are there plans to change this in a 5.5.10 or make a 5.5.11? The bug #35894 (http://issues.apache.org/bugzilla/show_bug.cgi?id=35894) Bill has resolved today is a stopper, because the Tomcat cannot start with SecurityManager enabled. Thorsten -- Thorsten Kamann Email: [EMAIL PROTECTED] ICQ: 40746578 Yahoo: ThorQue - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/security SecurityClassLoad.java
[EMAIL PROTECTED] wrote:
billbarker2005/08/03 23:07:46
Modified:catalina/src/share/org/apache/catalina/security
SecurityClassLoad.java
Log:
Fix CNFE when starting in a sandbox.
After the last refactoring, the Jk-Java Connector no longer has need of PAs. If this changes, the method can always be added back.
This reminds me I need to test security more often.
I look in the preload list for HTTP, and I see a few PAs there. One of
them is:
// End the response status line
if (System.getSecurityManager() != null){
AccessController.doPrivileged(
new PrivilegedAction(){
public Object run(){
buf[pos++] = Constants.CR;
buf[pos++] = Constants.LF;
return null;
}
}
);
} else {
buf[pos++] = Constants.CR;
buf[pos++] = Constants.LF;
}
I think this is fairly funny code. The contents of the PA were a bit
different originally, but I don't see why a PA was ever needed.
Similarly, the other PA is needed because the HttpMessages is a bundle
which will need to be loaded, while the loading should be done during
the init of the connector (like HttpMessages.getMessage(200)).
Rémy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-5 tomcat.nsi
mturk 2005/08/03 23:52:35 Modified:.tomcat.nsi Log: Use tomcat vhost from heanet. Revision ChangesPath 1.82 +3 -3 jakarta-tomcat-5/tomcat.nsi Index: tomcat.nsi === RCS file: /home/cvs/jakarta-tomcat-5/tomcat.nsi,v retrieving revision 1.81 retrieving revision 1.82 diff -u -r1.81 -r1.82 --- tomcat.nsi3 Aug 2005 08:22:39 - 1.81 +++ tomcat.nsi4 Aug 2005 06:52:35 - 1.82 @@ -203,11 +203,11 @@ SectionIn 3 - NSISdl::download /TIMEOUT=3 http://ftp.heanet.ie/pub/tomcat/native/1.1.0/binaries/win32/tcnative-1.dll $INSTDIR\bin\tcnative-1.dll + NSISdl::download /TIMEOUT=3 http://tomcat.heanet.ie/native/1.1.0/binaries/win32/tcnative-1.dll $INSTDIR\bin\tcnative-1.dll Pop $0 StrCmp $0 success success SetDetailsView show -DetailPrint download failed from http://ftp.heanet.ie/pub/tomcat/native/1.1.0/binaries/win32/tcnative-1.dll: $0 +DetailPrint download failed from http://tomcat.heanet.ie/native/1.1.0/binaries/win32/tcnative-1.dll: $0 success: ClearErrors - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 InternalAprOutputBuffer.java Http11AprProcessor.java
remm2005/08/04 00:07:57
Modified:jk/java/org/apache/coyote/ajp AjpAprProcessor.java
http11/src/java/org/apache/coyote/http11
InternalAprOutputBuffer.java
Http11AprProcessor.java
Log:
- Remove useless HTTP/1.1 PAs (which seem to be only there for initial
access to the util package).
- Fix AJP APR when security is enabled (access to the util package was
failing).
Revision ChangesPath
1.17 +7 -4
jakarta-tomcat-connectors/jk/java/org/apache/coyote/ajp/AjpAprProcessor.java
Index: AjpAprProcessor.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/jk/java/org/apache/coyote/ajp/AjpAprProcessor.java,v
retrieving revision 1.16
retrieving revision 1.17
diff -u -r1.16 -r1.17
--- AjpAprProcessor.java 30 Jul 2005 22:22:57 - 1.16
+++ AjpAprProcessor.java 4 Aug 2005 07:07:57 - 1.17
@@ -92,14 +92,17 @@
readTimeout = 100 * 1000;
}
-// Cause loading of HexUtils
-int foo = HexUtils.DEC[0];
-
// Allocate input and output buffers
inputBuffer = ByteBuffer.allocateDirect(16 * 1024);
inputBuffer.limit(0);
outputBuffer = ByteBuffer.allocateDirect(16 * 1024);
+// Cause loading of HexUtils
+int foo = HexUtils.DEC[0];
+
+// Cause loading of HttpMessages
+HttpMessages.getMessage(200);
+
}
@@ -886,7 +889,7 @@
responseHeaderMessage.appendInt(response.getStatus());
String message = response.getMessage();
if (message == null){
-message= HttpMessages.getMessage(response.getStatus());
+message = HttpMessages.getMessage(response.getStatus());
} else {
message = message.replace('\n', ' ').replace('\r', ' ');
}
1.5 +6 -30
jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/InternalAprOutputBuffer.java
Index: InternalAprOutputBuffer.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/InternalAprOutputBuffer.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- InternalAprOutputBuffer.java 18 May 2005 09:25:08 - 1.4
+++ InternalAprOutputBuffer.java 4 Aug 2005 07:07:57 - 1.5
@@ -18,8 +18,6 @@
import java.io.IOException;
import java.nio.ByteBuffer;
-import java.security.AccessController;
-import java.security.PrivilegedAction;
import org.apache.tomcat.jni.Socket;
import org.apache.tomcat.util.buf.ByteChunk;
@@ -78,6 +76,9 @@
committed = false;
finished = false;
+// Cause loading of HttpMessages
+HttpMessages.getMessage(200);
+
}
@@ -428,42 +429,17 @@
// Write message
String message = response.getMessage();
if (message == null) {
-write(getMessage(status));
+write(HttpMessages.getMessage(status));
} else {
write(message);
}
// End the response status line
-if (System.getSecurityManager() != null){
- AccessController.doPrivileged(
-new PrivilegedAction(){
-public Object run(){
-buf[pos++] = Constants.CR;
-buf[pos++] = Constants.LF;
-return null;
-}
-}
- );
-} else {
-buf[pos++] = Constants.CR;
-buf[pos++] = Constants.LF;
-}
+buf[pos++] = Constants.CR;
+buf[pos++] = Constants.LF;
}
-private String getMessage(final int message){
-if (System.getSecurityManager() != null){
- return (String)AccessController.doPrivileged(
-new PrivilegedAction(){
-public Object run(){
-return HttpMessages.getMessage(message);
-}
-}
- );
-} else {
-return HttpMessages.getMessage(message);
-}
-}
/**
* Send a header.
1.31 +4 -15
jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11AprProcessor.java
Index: Http11AprProcessor.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11AprProcessor.java,v
retrieving revision 1.30
retrieving revision 1.31
diff -u -r1.30 -r1.31
--- Http11AprProcessor.java 31 Jul 2005 09:23:02 - 1.30
+++
error? bug?
Yoo, Currently we are running tomcat 5.5.9 on Debian Sarge, with Java JDK 1.5.0.04 http://1.5.0.04, together with apache, apache-common 1.3.33-6 support files for all Apache webservers apache2 2.0.54-4 next generation, scalable, extendable web se apache2-common 2.0.54-4 next generation, scalable, extendable web se apache2-mpm-pr 2.0.54-4 traditional model for Apache2 apache2-utils 2.0.54-4 utility programs for webservers libapache-mod- 4.3.10-15 server-side, HTML-embedded scripting languag libapache2-mod 4.3.9-2 Apache 2 module for MySQL authentication libapache2-mod 2.0.4-3 Apache 2.0 connector for the Tomcat Java ser libapache2-mod 4.3.10-15 server-side, HTML-embedded scripting languag libapache2-mod 0.5.2-3 Apache2 module to run php scripts with the o Unfortunatly tomcat does not respond on monitor check any/every day between 06:26:00 and 06:27:00. message : [CEST Aug 4 06:26:30] 'tomcat' failed, cannot open a connection to INET[pzzl04.pzzl.com:80/manager http://pzzl04.pzzl.com:80/manager] first message from catalina.out log [Aug 4, 2005 6:26:31 AM org.apache.coyote.http11.Http11Protocol pause INFO: Pausing Coyote HTTP/1.1 on http-8080] Now our monitoring system, notices the stop and restarts tomcat, but this is not acceptable in the long run Also restarting tomcat at any moment in the day does not change the time it goes down Any suggestions? Greetings O.
Re: error? bug?
Oto Bossert wrote: Yoo, Currently we are running tomcat 5.5.9 on Debian Sarge, with Java JDK 1.5.0.04 http://1.5.0.04, together with apache, apache-common 1.3.33-6 support files for all Apache webservers apache2 2.0.54-4 next generation, scalable, extendable web se apache2-common 2.0.54-4 next generation, scalable, extendable web se apache2-mpm-pr 2.0.54-4 traditional model for Apache2 apache2-utils 2.0.54-4 utility programs for webservers libapache-mod- 4.3.10-15 server-side, HTML-embedded scripting languag libapache2-mod 4.3.9-2 Apache 2 module for MySQL authentication libapache2-mod 2.0.4-3 Apache 2.0 connector for the Tomcat Java ser libapache2-mod 4.3.10-15 server-side, HTML-embedded scripting languag libapache2-mod 0.5.2-3 Apache2 module to run php scripts with the o Unfortunatly tomcat does not respond on monitor check any/every day between 06:26:00 and 06:27:00. message : [CEST Aug 4 06:26:30] 'tomcat' failed, cannot open a connection to INET[pzzl04.pzzl.com:80/manager http://pzzl04.pzzl.com:80/manager] first message from catalina.out log [Aug 4, 2005 6:26:31 AM org.apache.coyote.http11.Http11Protocol pause INFO: Pausing Coyote HTTP/1.1 on http-8080] Now our monitoring system, notices the stop and restarts tomcat, but this is not acceptable in the long run Also restarting tomcat at any moment in the day does not change the time it goes down Any suggestions? It should be quite obvious: edit the file from where the log is coming, add a trace dump there, and recompile the said class. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Re: error? bug?
I will be out of office until monday 8th August if your inquiry is urgent please contact Mr Phil Day on 07989391974 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: error? bug?
Yoo, Ok, I will do that, thanks for the 'obvious' suggestion Greetings O. On 8/4/05, Remy Maucherat [EMAIL PROTECTED] wrote: Oto Bossert wrote: Yoo, Currently we are running tomcat 5.5.9 on Debian Sarge, with Java JDK 1.5.0.04 http://1.5.0.04 http://1.5.0.04, together with apache, apache-common 1.3.33-6 support files for all Apache webservers apache2 2.0.54-4 next generation, scalable, extendable web se apache2-common 2.0.54-4 next generation, scalable, extendable web se apache2-mpm-pr 2.0.54-4 traditional model for Apache2 apache2-utils 2.0.54-4 utility programs for webservers libapache-mod- 4.3.10-15 server-side, HTML-embedded scripting languag libapache2-mod 4.3.9-2 Apache 2 module for MySQL authentication libapache2-mod 2.0.4-3 Apache 2.0 connector for the Tomcat Java ser libapache2-mod 4.3.10-15 server-side, HTML-embedded scripting languag libapache2-mod 0.5.2-3 Apache2 module to run php scripts with the o Unfortunatly tomcat does not respond on monitor check any/every day between 06:26:00 and 06:27:00. message : [CEST Aug 4 06:26:30] 'tomcat' failed, cannot open a connection to INET[pzzl04.pzzl.com:80/manager http://pzzl04.pzzl.com:80/manager http://pzzl04.pzzl.com:80/manager] first message from catalina.out log [Aug 4, 2005 6:26:31 AM org.apache.coyote.http11.Http11Protocol pause INFO: Pausing Coyote HTTP/1.1 on http-8080] Now our monitoring system, notices the stop and restarts tomcat, but this is not acceptable in the long run Also restarting tomcat at any moment in the day does not change the time it goes down Any suggestions? It should be quite obvious: edit the file from where the log is coming, add a trace dump there, and recompile the said class. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36019] New: - host-manager-howto.html is missing in Host-Manager webapp
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36019. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36019 Summary: host-manager-howto.html is missing in Host-Manager webapp Product: Tomcat 5 Version: 5.5.10 Platform: Other OS/Version: other Status: NEW Severity: normal Priority: P2 Component: Webapps:Manager AssignedTo: tomcat-dev@jakarta.apache.org ReportedBy: [EMAIL PROTECTED] The html-host-manager-howto.html and host-manager-howto.html is missing in the host-manager webapp. An 404-error occurs. If I am clicking on a newly created host the message FAIL - Unknown command /host_name occurs. Thorsten -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36020] New: - Patch for Enhancement of MemoryUserDatabase
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36020. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36020 Summary: Patch for Enhancement of MemoryUserDatabase Product: Tomcat 5 Version: 5.5.10 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P2 Component: Catalina AssignedTo: tomcat-dev@jakarta.apache.org ReportedBy: [EMAIL PROTECTED] As discussed on tomcat-dev I contribute a patch for MemoryUserDatabase that: 1) Logs a warning, if the persistance directory is not writeable (instead of an ugly Exception) 2) Implements an additional attribute readonly (default: false) that one can use to not get the warning in cases, where it's clear, that the directory is not writeable. The patch does not include a changelog-Patch, because that changes too often. CVS Head and 5.5.10 is the same for all files with changes. The Warn message is only contained in the english LocalString.properties. Anyone who could do es/fr/ja ? I think, at the moment there is no documentation for Userdatabase, so no place to add readonly information. If I'm wrong, please correct me. I'll try to add the readonly info to admin too (later). Last question: the close() for the MemoryUserDatabase is never called, especially not during shutdown of tomcat. Anyone with a good hint, where to look for adding a hook to close MemoryUserDatabase during tomcat shutdown? -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36020] - Patch for Enhancement of MemoryUserDatabase
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36020. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36020 --- Additional Comments From [EMAIL PROTECTED] 2005-08-04 11:40 --- Created an attachment (id=15885) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=15885action=view) readonly MemoryUserDatabase and warning instead of exception -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36022] New: - It is not possible to set property 'recover_time' to a value less then 60 seconds (mod_jk)
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36022. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36022 Summary: It is not possible to set property 'recover_time' to a value less then 60 seconds (mod_jk) Product: Tomcat 5 Version: 5.5.9 Platform: Other OS/Version: Linux Status: NEW Severity: normal Priority: P3 Component: Native:JK AssignedTo: tomcat-dev@jakarta.apache.org ReportedBy: [EMAIL PROTECTED] Hi, I've tested it by using the status page and using a test application. I configured a load balancer with 2 workers (tom1 tom2) (linux, apache 2.0.54, mod_jk 1.2.14, tomcat 5.5.9 and jdk_1.5.0 update 3). I configured the property recover_time with a value of 10 seconds. First, I stop one tomcat instance (tom1). The status page immediately shows that this worker is in error state. Then, i restart this tomcat instance (tom1), wait 10 seconds, and then stop tomcat instance 2 (tom2). In most times my application shows a 503 Service Temporarily Unavailable page. However, it may occur that the application is working properly. The status page as well does not show that within 10 seconds a tomcat instance is recovered fully (in most cases). The status page of mod_jk 1.2.14 offers the user to alter the recovery time. However, using a value less then 60 does *not* affect a change. Is it possible for future versions to allow a recovery time less than 60 seconds ? -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36022] - It is not possible to set property 'recover_time' to a value less then 60 seconds (mod_jk)
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36022. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36022 --- Additional Comments From [EMAIL PROTECTED] 2005-08-04 12:40 --- 60 seconds is the defualt. The load balancer code only allows values at least 60 seconds. If you try a short recover_time, it will be set to 60 seconds. Recovery is not cheap, so trying to often will not really help. If you have a load balanced application 1 minute recovery interval looks like a reasonable minimum. I think the parameter is not yet documented, so especially it's minimum value is not in the docs. You might supply a documentation patch, if you like to. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36023] New: - ServletResponse.reset() kills session-cookie
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36023. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36023 Summary: ServletResponse.reset() kills session-cookie Product: Tomcat 5 Version: 5.5.9 Platform: Other OS/Version: other Status: NEW Severity: normal Priority: P2 Component: Servlet JSP API AssignedTo: tomcat-dev@jakarta.apache.org ReportedBy: [EMAIL PROTECTED] Hi, when calling ServletResponse.reset() from within a JSP-page (or even a servlet i guess), the session-cookie get's deleted too. Is this spec compliant? To reproduce, use that JSP-Page: [EMAIL PROTECTED] session=true % % reponse.reset(); % %=asdf% Tomcat will not send a session-cookie. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36023] - ServletResponse.reset() kills session-cookie
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36023. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36023 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Additional Comments From [EMAIL PROTECTED] 2005-08-04 13:23 --- *** This bug has been marked as a duplicate of 26183 *** -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 26183] - ServletResponse#reset() method and cookie session control problem on tomcat4.1.24
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=26183. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=26183 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2005-08-04 13:23 --- *** Bug 36023 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 26183] - ServletResponse#reset() method and cookie session control problem on tomcat4.1.24
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=26183. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=26183 --- Additional Comments From [EMAIL PROTECTED] 2005-08-04 13:40 --- Why is this bug closed? If the specification doesn't say anything about it, do what is most convenient for the users/developers. Other servletcontains add the session-cookie - even if reset() was called. So perhaps Tomcat should do that too. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml
remm2005/08/04 04:54:20 Modified:webapps/docs changelog.xml Log: - Changelog update. Revision ChangesPath 1.352 +11 -0 jakarta-tomcat-catalina/webapps/docs/changelog.xml Index: changelog.xml === RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v retrieving revision 1.351 retrieving revision 1.352 diff -u -r1.351 -r1.352 --- changelog.xml 4 Aug 2005 06:17:07 - 1.351 +++ changelog.xml 4 Aug 2005 11:54:20 - 1.352 @@ -41,6 +41,10 @@ add bug33261/bug: Windows installer now checks the user type and warns non-admins as needed. (yoavs) /add + update +The Windows installer will now optionally download a (32bit) Windows .dll for Tomcat native +from HEAnet (remm) + /update /changelog /subsection @@ -68,6 +72,9 @@ fix bug35894/bug: Fix CNFE when starting in a sandbox. (billbarker) /fix + fix +Add version check for Tomcat native so that incompatible API changes are detected early (remm) + /fix /changelog /subsection @@ -97,6 +104,10 @@ fix Internationalization and code cleanups for APR AJP implementation. (remm) /fix + fix +Security exception in APR AJP implementation when running with the security +manager enabled. (remm) + /fix /changelog /subsection - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/modules/storeconfig/src/share/org/apache/catalina/storeconfig StoreContextAppender.java
remm2005/08/04 05:18:30 Modified:jasper2/src/share/org/apache/jasper/servlet JasperLoader.java catalina/src/share/org/apache/catalina/ssi ByteArrayServletOutputStream.java modules/storeconfig/src/share/org/apache/catalina/storeconfig StoreContextAppender.java Log: - Useless commit of the day: fix some imports. Revision ChangesPath 1.19 +0 -4 jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet/JasperLoader.java Index: JasperLoader.java === RCS file: /home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet/JasperLoader.java,v retrieving revision 1.18 retrieving revision 1.19 diff -u -r1.18 -r1.19 --- JasperLoader.java 29 Mar 2005 18:33:21 - 1.18 +++ JasperLoader.java 4 Aug 2005 12:18:30 - 1.19 @@ -20,12 +20,8 @@ import java.io.InputStream; import java.net.URL; import java.net.URLClassLoader; -import java.security.AccessController; import java.security.CodeSource; import java.security.PermissionCollection; -import java.security.PrivilegedAction; -import java.security.PrivilegedActionException; -import java.security.PrivilegedExceptionAction; import org.apache.jasper.Constants; 1.7 +1 -2 jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/ssi/ByteArrayServletOutputStream.java Index: ByteArrayServletOutputStream.java === RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/ssi/ByteArrayServletOutputStream.java,v retrieving revision 1.6 retrieving revision 1.7 diff -u -r1.6 -r1.7 --- ByteArrayServletOutputStream.java 27 Jul 2005 15:11:22 - 1.6 +++ ByteArrayServletOutputStream.java 4 Aug 2005 12:18:30 - 1.7 @@ -17,7 +17,6 @@ package org.apache.catalina.ssi; import java.io.ByteArrayOutputStream; -import java.io.IOException; import javax.servlet.ServletOutputStream; 1.4 +0 -2 jakarta-tomcat-catalina/modules/storeconfig/src/share/org/apache/catalina/storeconfig/StoreContextAppender.java Index: StoreContextAppender.java === RCS file: /home/cvs/jakarta-tomcat-catalina/modules/storeconfig/src/share/org/apache/catalina/storeconfig/StoreContextAppender.java,v retrieving revision 1.3 retrieving revision 1.4 diff -u -r1.3 -r1.4 --- StoreContextAppender.java 27 Jul 2005 15:11:55 - 1.3 +++ StoreContextAppender.java 4 Aug 2005 12:18:30 - 1.4 @@ -18,8 +18,6 @@ import java.io.File; import java.io.IOException; -import javax.print.DocPrintJob; - import org.apache.catalina.Container; import org.apache.catalina.core.StandardContext; import org.apache.catalina.core.StandardHost; - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Next Release 5.5.11?
Howdy, Probably next weekend, but that's not guaranteed. It will be a 5.5.11. Feel free to use 5.5.9 or build a custom release from HEAD for yourself if you can't wait that long. Yoav Shapira System Design and Management Fellow MIT Sloan School of Management Cambridge, MA USA [EMAIL PROTECTED] / www.yoavshapira.com -Original Message- From: Thorsten Kamann [mailto:[EMAIL PROTECTED] Sent: Thursday, August 04, 2005 2:29 AM To: tomcat-dev@jakarta.apache.org Subject: Next Release 5.5.11? Hello, the current release is 5.5.10-alpha. Are there plans to change this in a 5.5.10 or make a 5.5.11? The bug #35894 (http://issues.apache.org/bugzilla/show_bug.cgi?id=35894) Bill has resolved today is a stopper, because the Tomcat cannot start with SecurityManager enabled. Thorsten -- Thorsten Kamann Email: [EMAIL PROTECTED] ICQ: 40746578 Yahoo: ThorQue - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 35978] - tomcat truncate very big files
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=35978. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=35978 --- Additional Comments From [EMAIL PROTECTED] 2005-08-04 14:39 --- (In reply to comment #1) I think you should plan to investigate the issue yourself, as: - AFAIK large files work on the download direction (all people care about is that when dealing with large files) Do you mean that people split their big files ? It may be a solution but it is not always possible ! - few people care about WebDAV functionality beyond basic stuff I have made some more tests, and it happen also with a simple tomcat app without webdav functionality. Files between 2Gb and 4Gb do not produce the problem, only files 4 Gb. Regards -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 27371] - java.lang.ThreadDeath caused by log4j when reloading Tomcat app
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=27371. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=27371 --- Additional Comments From [EMAIL PROTECTED] 2005-08-04 14:57 --- I found a solution. copy the log4j jar file and rename to another file name, such as log4j-1.2.6.jar. put the both log4j jar files to WEB-INF lib directory. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 35978] - tomcat truncate very big files
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=35978. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=35978 --- Additional Comments From [EMAIL PROTECTED] 2005-08-04 14:58 --- I wrote (which I think was simple to understand): I think you should plan to investigate the issue yourself. This means more than doing tests: start thinking about at least HTTP dumps as the minimum. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml
remm2005/08/04 06:06:56
Modified:catalina/src/share/org/apache/catalina/users
MemoryUserDatabase.java mbeans-descriptors.xml
MemoryUserDatabaseFactory.java
LocalStrings.properties
webapps/docs changelog.xml
Log:
- 36020: MemoryUserDatabase in read only situations.
- Submitted by Rainer Jung.
Revision ChangesPath
1.8 +59 -1
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/users/MemoryUserDatabase.java
Index: MemoryUserDatabase.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/users/MemoryUserDatabase.java,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- MemoryUserDatabase.java 26 Jun 2004 17:41:33 - 1.7
+++ MemoryUserDatabase.java 4 Aug 2005 13:06:56 - 1.8
@@ -31,6 +31,8 @@
import org.apache.catalina.User;
import org.apache.catalina.UserDatabase;
import org.apache.catalina.util.StringManager;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
import org.apache.tomcat.util.digester.Digester;
import org.apache.tomcat.util.digester.ObjectCreationFactory;
import org.xml.sax.Attributes;
@@ -49,6 +51,8 @@
public class MemoryUserDatabase implements UserDatabase {
+private static Log log = LogFactory.getLog(MemoryUserDatabase.class);
+
// ---
Constructors
@@ -113,6 +117,11 @@
/**
+ * A flag, indicating if the user database is read only.
+ */
+protected boolean readonly = false;
+
+/**
* The set of [EMAIL PROTECTED] Role}s defined in this database, keyed by
* role name.
*/
@@ -183,6 +192,28 @@
/**
+ * Returning the readonly status of the user database
+ */
+public boolean getReadonly() {
+
+return (this.readonly);
+
+}
+
+
+/**
+ * Setting the readonly status of the user database
+ *
+ * @param pathname The new pathname
+ */
+public void setReadonly(boolean readonly) {
+
+this.readonly = readonly;
+
+}
+
+
+/**
* Return the set of [EMAIL PROTECTED] Role}s defined in this user
database.
*/
public Iterator getRoles() {
@@ -442,6 +473,24 @@
/**
+ * Check for permissions to save this user database
+ * to persistent storage location
+ *
+ */
+public boolean isPersistable() {
+
+File file = new File(pathname);
+if (!file.isAbsolute()) {
+file = new File(System.getProperty(catalina.base),
+pathname);
+}
+File dir = file.getParentFile();
+return dir.exists() dir.isDirectory() dir.canWrite();
+
+}
+
+
+/**
* Save any updated information to the persistent storage location for
* this user database.
*
@@ -449,6 +498,15 @@
*/
public void save() throws Exception {
+if ( getReadonly() ) {
+return;
+}
+
+if ( ! isPersistable() ) {
+log.warn(sm.getString(memoryUserDatabase.notPersistable));
+return;
+}
+
// Write out contents to a temporary file
File fileNew = new File(pathnameNew);
if (!fileNew.isAbsolute()) {
1.2 +11 -0
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/users/mbeans-descriptors.xml
Index: mbeans-descriptors.xml
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/users/mbeans-descriptors.xml,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- mbeans-descriptors.xml25 Apr 2003 21:14:36 - 1.1
+++ mbeans-descriptors.xml4 Aug 2005 13:06:56 - 1.2
@@ -252,6 +252,17 @@
type=java.lang.String/
/operation
+attribute name=readonly
+ description=No persistant save of the user database
+ type=boolean
+writeable=false/
+
+operation name=isPersistable
+ description=Check if user database is writable
+ impact=INFO
+ returnType=boolean
+/operation
+
operation name=save
description=Save current users and groups to persistent storage
impact=ACTION
1.4 +6 -1
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/users/MemoryUserDatabaseFactory.java
Index: MemoryUserDatabaseFactory.java
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/users MemoryUserDatabase.java mbeans-descriptors.xml
remm2005/08/04 06:12:16
Modified:catalina/src/share/org/apache/catalina/users
MemoryUserDatabase.java mbeans-descriptors.xml
Log:
- I don't quite like persistable.
Revision ChangesPath
1.9 +4 -4
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/users/MemoryUserDatabase.java
Index: MemoryUserDatabase.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/users/MemoryUserDatabase.java,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- MemoryUserDatabase.java 4 Aug 2005 13:06:56 - 1.8
+++ MemoryUserDatabase.java 4 Aug 2005 13:12:16 - 1.9
@@ -477,7 +477,7 @@
* to persistent storage location
*
*/
-public boolean isPersistable() {
+public boolean isWriteable() {
File file = new File(pathname);
if (!file.isAbsolute()) {
@@ -498,11 +498,11 @@
*/
public void save() throws Exception {
-if ( getReadonly() ) {
+if (getReadonly()) {
return;
}
-if ( ! isPersistable() ) {
+if (!isWriteable()) {
log.warn(sm.getString(memoryUserDatabase.notPersistable));
return;
}
1.3 +11 -11
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/users/mbeans-descriptors.xml
Index: mbeans-descriptors.xml
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/users/mbeans-descriptors.xml,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- mbeans-descriptors.xml4 Aug 2005 13:06:56 - 1.2
+++ mbeans-descriptors.xml4 Aug 2005 13:12:16 - 1.3
@@ -159,6 +159,17 @@
type=[Ljava.lang.String;
writeable=false/
+attribute name=readonly
+ description=No persistant save of the user database
+ type=boolean
+writeable=false/
+
+attribute name=writeable
+ description=Check if user database is writeable
+ impact=INFO
+ is=true
+ writeable=false/
+
operation name=createGroup
description=Create new group and return MBean name
impact=ACTION
@@ -252,17 +263,6 @@
type=java.lang.String/
/operation
-attribute name=readonly
- description=No persistant save of the user database
- type=boolean
-writeable=false/
-
-operation name=isPersistable
- description=Check if user database is writable
- impact=INFO
- returnType=boolean
-/operation
-
operation name=save
description=Save current users and groups to persistent storage
impact=ACTION
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36020] - Patch for Enhancement of MemoryUserDatabase
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36020. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36020 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2005-08-04 15:14 --- I applied the patch, but I changed persistable - writeable. Thanks. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 27371] - java.lang.ThreadDeath caused by log4j when reloading Tomcat app
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=27371. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=27371 --- Additional Comments From [EMAIL PROTECTED] 2005-08-04 15:45 --- Your solution seems more like black magic to me. What do you think you've fixed? And what is it about having 2 log4j jars in WEB-INF/lib changes the thread death behavior? You do realize that the thread death stuff is sporadic, right? You've performed an action and have found that you haven't gotten the error. You attribute the success to your action where, in reality, you can't know whether it was your action or dumb luck that led to success... unless you actually do know the real cause/effect relationship. If so, we're all ears! Until then, this is black magic. Jake -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 35978] - tomcat truncate very big files
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=35978.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=35978
[EMAIL PROTECTED] changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution||WORKSFORME
--- Additional Comments From [EMAIL PROTECTED] 2005-08-04 16:02 ---
I uploaded and downloaded (the same file) a 2614816768 byte file without an
issue.
Using winxp and tomcat 5.1.{CVS HEAD}
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 35978] - tomcat truncate very big files
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=35978.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=35978
--- Additional Comments From [EMAIL PROTECTED] 2005-08-04 16:07 ---
idiot ... i meant 5.5.{cvs head}
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 35978] - tomcat truncate very big files
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=35978. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=35978 --- Additional Comments From [EMAIL PROTECTED] 2005-08-04 16:10 --- He said only 4GB was an issue. I think we should wait for at least HTTP dumps before we start testing this issue. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Questions about MemoryUserDatabase
Hi, for the patch 36020 I had a look at MemoryUserDatabase and although the patch is already committed (Thanks!) I wanted to discuss a few things: 1) The close() for the MemoryUserDatabase is never called, especially not during shutdown of tomcat. Anyone with a good hint, where to look for adding a hook to close MemoryUserDatabase during tomcat shutdown? Where should I look for supplying a nice integration into the LifeCycle? The creation comes from org.apache.catalina.users.MemoryUserDatabaseFactory.getObjectInstance(MemoryUserDatabaseFactory.java:113) org.apache.naming.factory.ResourceFactory.getObjectInstance(ResourceFactory.java:129) javax.naming.spi.NamingManager.getObjectInstance(NamingManager.java:304) org.apache.naming.NamingContext.lookup(NamingContext.java:792) org.apache.naming.NamingContext.lookup(NamingContext.java:152) org.apache.catalina.mbeans.GlobalResourcesLifecycleListener.createMBeans(GlobalResourcesLifecycleListener.java:138) org.apache.catalina.mbeans.GlobalResourcesLifecycleListener.createMBeans(GlobalResourcesLifecycleListener.java:108) org.apache.catalina.mbeans.GlobalResourcesLifecycleListener.lifecycleEvent(GlobalResourcesLifecycleListener.java:80) org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:119) org.apache.catalina.core.StandardServer.start(StandardServer.java:673) 2) The new warn message is only contained in the english LocalString.properties. Anyone who could do es/fr/ja ? Original message: User database is not persistable - no write permissions on directory 3) I think, at the moment there is no documentation for UserDatabase at all. I only find docs about MemoryRealm. Where would there be a good place/page to contribute something? I would like to add information about the new property readonly? Thanks for any advice. Regards, Rainer [EMAIL PROTECTED] wrote: DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36020. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36020 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2005-08-04 15:14 --- I applied the patch, but I changed persistable - writeable. Thanks. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml
remm2005/08/04 08:05:31
Modified:catalina/src/share/org/apache/catalina/servlets
DefaultServlet.java
webapps/docs changelog.xml
Log:
- 35978: Bad handling of single range requests greater than 2GB in the
DefaultServlet.
Revision ChangesPath
1.39 +14 -3
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets/DefaultServlet.java
Index: DefaultServlet.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets/DefaultServlet.java,v
retrieving revision 1.38
retrieving revision 1.39
diff -u -r1.38 -r1.39
--- DefaultServlet.java 5 May 2005 07:00:09 - 1.38
+++ DefaultServlet.java 4 Aug 2005 15:05:31 - 1.39
@@ -809,7 +809,12 @@
if (debug 0)
log(DefaultServlet.serveFile: contentLength= +
contentLength);
-response.setContentLength((int) contentLength);
+if (contentLength Integer.MAX_VALUE) {
+response.setContentLength((int) contentLength);
+} else {
+// Set the content-length as String to be able to use a
long
+response.setHeader(content-length, + contentLength);
+}
}
InputStream renderResult = null;
@@ -854,7 +859,13 @@
+ range.start
+ - + range.end + /
+ range.length);
-response.setContentLength((int) (range.end - range.start +
1));
+long length = range.end - range.start + 1;
+if (length Integer.MAX_VALUE) {
+response.setContentLength((int) length);
+} else {
+// Set the content-length as String to be able to use a
long
+response.setHeader(content-length, + length);
+}
if (contentType != null) {
if (debug 0)
1.354 +4 -0 jakarta-tomcat-catalina/webapps/docs/changelog.xml
Index: changelog.xml
===
RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v
retrieving revision 1.353
retrieving revision 1.354
diff -u -r1.353 -r1.354
--- changelog.xml 4 Aug 2005 13:06:56 - 1.353
+++ changelog.xml 4 Aug 2005 15:05:31 - 1.354
@@ -79,6 +79,10 @@
bug36020/bug: Allow MemoryUserDatabase to work better on write
protected mediums,
submitted by Rainer Jung (remm)
/fix
+ fix
+bug35978/bug: Bad handling of single range requests greater than
2GB in the DefaultServlet
+(remm)
+ /fix
/changelog
/subsection
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 35978] - tomcat truncate very big files
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=35978. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=35978 [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME | --- Additional Comments From [EMAIL PROTECTED] 2005-08-04 17:06 --- . -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 35978] - tomcat truncate very big files
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=35978. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=35978 [EMAIL PROTECTED] changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2005-08-04 17:10 --- Although it is not possible to know for sure without appropriate information, there was a rather obvious defect in DefaultServlet, which causes a bad content-length for ranges 2GB. As the only reasonable strategy for transferring such files is to use many single range requests, this was not tested well. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 InternalAprOutputBuffer.java Http11AprProcessor.java
- Original Message - From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Thursday, August 04, 2005 12:07 AM Subject: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 InternalAprOutputBuffer.java Http11AprProcessor.java remm2005/08/04 00:07:57 Modified:jk/java/org/apache/coyote/ajp AjpAprProcessor.java http11/src/java/org/apache/coyote/http11 InternalAprOutputBuffer.java Http11AprProcessor.java Log: - Remove useless HTTP/1.1 PAs (which seem to be only there for initial access to the util package). - Fix AJP APR when security is enabled (access to the util package was failing). It looks like you did the same thing I did with JK: Remove the useless PAs, and then don't bother to test on a clean build (so that SecurityClassLoad can still find the removed classes and doesn't complain). If you don't want BZ 35894 re-opened, you also need to remove the reference to the removed PAs in SecurityClassLoad ;-). This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments. In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 InternalAprOutputBuffer.java Http11AprProcessor.java
Bill Barker wrote: It looks like you did the same thing I did with JK: Remove the useless PAs, and then don't bother to test on a clean build (so that SecurityClassLoad can still find the removed classes and doesn't complain). If you don't want BZ 35894 re-opened, you also need to remove the reference to the removed PAs in SecurityClassLoad ;-). I made the changes only to the APR versions, so it looks ok to me. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
