Re: why is Principal not serialized for clustering replication of ses sion?

2005-08-17 Thread Peter Rossbach

Hey Dirk,

I thing you have found a strange missing feature inside the cluster 
implementation. Currently
all other realm MemoryRealm, DataSourceRealm,JNDIRealm, JAASRealm and 
JDBCRealm  create a GenericPrincipal that used  inside the 
DeltaRequest.setPrincipal method. The UserDatabaseRealm create a 
o.a.c.users.MemoryUser principal. Very bad thing!! Integrate a spezial 
handling for this is easy, but :-(


I have tested with MemoryRealm successfull with basic auth. Sorry, but 
this means that at every request a message is replicated.
The session principal is set at every request. I don't like this 
behaviour. Any ideas to change it are very welcomed!


Please open a bug report that we can work together at this auth topic 
and documened it well at changelog.


Thanks for reporting this.
Peter




Peter Rossbach schrieb:


Hmm,
I have look inside source of DeltaRequest

public void setPrincipal(Principal p) {
   int action = (p==null)?ACTION_REMOVE:ACTION_SET;
   SerializablePrincipal sp = null;
   if ( p != null ) {
   sp = 
SerializablePrincipal.createPrincipal((GenericPrincipal)p);

   }
   addAction(TYPE_PRINCIPAL,action,NAME_PRINCIPAL,sp);
   }

 public synchronized void execute(DeltaSession session, boolean 
notifyListeners) {

...
   Principal p = null;
   if ( info.getAction() == ACTION_SET ) {
   SerializablePrincipal sp = 
(SerializablePrincipal)info.getValue();
   p = 
(Principal)sp.getPrincipal(session.getManager().getContainer().getRealm()); 


   }
   session.setPrincipal(p,false);
   break;
   }//case



and this look like that we explizit replicated the principal.

I will test you use case with the newest 5.5.x code base again and 
describe

the results later.
peter

PS: SingleSignOn is currently not supported at the cluster 
implementation :-(




Dirk de Kok schrieb:


hi all,

we are having a problem with our Tomcat 5.5.9 cluster. We run 2 Tomcat
instances on physically different machines. For security we use normal
container managed security, configured in the web.xml. Session 
replication
works fine, and session id's are same across the two instances. We 
only have

trouble with the authentication.
For instance, if you are logged in on instance1, if in case of error the
load balancer redirects subsequent request to instance2, you have to 
login

again. Turning on Single Signon did not help.
Browsing through the Tomcat source code I noticed that very explicit the
security Principal is not saved in a serialized session. Has anybody 
an idea

why this is not done? What way would we be able to let the security
information propagate throughout the cluster?

Configuration:
- OS: RH 4
- App server: Tomcat 5.5.9
- Session replication: in-memory, pooled
- Load balancing via hardware load balancer (Cisco) with sticky sessions

tia,

Dirk

- Lost Boys creates and delivers internet  mobile solutions -
Dirk de Kok | Java Specialist
Lost Boys B.V. | Joop Geesinkweg 209 | 1096 AV Amsterdam The 
Netherlands |

Tel: +31 20 4604500 | Fax: +31 20 4604501 | [EMAIL PROTECTED] |
www.lostboys.nl
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




 





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]










-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/modules/cluster to-do.txt

2005-08-17 Thread pero
pero2005/08/17 01:10:37

  Modified:modules/cluster to-do.txt
  Log:
  Add replicated principal problem :-(
  
  Revision  ChangesPath
  1.19  +6 -3  jakarta-tomcat-catalina/modules/cluster/to-do.txt
  
  Index: to-do.txt
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/modules/cluster/to-do.txt,v
  retrieving revision 1.18
  retrieving revision 1.19
  diff -u -r1.18 -r1.19
  --- to-do.txt 16 Jul 2005 21:06:34 -  1.18
  +++ to-do.txt 17 Aug 2005 08:10:37 -  1.19
  @@ -101,10 +101,13 @@
   
   
   problems
  -   
  +
  +- MemoryUser principal from UserDatabaseRealm not handled to replicated 
  + - look inside DeltaRequest.setPrincipal(Principal,boolean)
  +  detected by Dirk de Kok (tomdev 16.8.2005)
  + - only GenericPrincipal from all other realms are handled well.
   - We not set SimpleTcpCluster Properties when element exists inside config.
  - Element must have all properties!! - Note inside docs!!   
  - 
  + Element must have all properties!! - Note inside docs!!  
   - How we can stop the request traffic when restart an application?
   currently the jk 1.2.10 can only disable the complete loadbalancer,
   but this detect only the new session request desicion.
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session DeltaManager.java DeltaRequest.java

2005-08-17 Thread pero
pero2005/08/17 01:13:12

  Modified:modules/cluster/src/share/org/apache/catalina/cluster/session
DeltaManager.java DeltaRequest.java
  Log:
  Only replicated GenericPrincipals.
  Please don't use UserDatabaseRelam for clustered applications... (I hope we 
can fix it...)
  
  Revision  ChangesPath
  1.52  +8 -7  
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaManager.java
  
  Index: DeltaManager.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaManager.java,v
  retrieving revision 1.51
  retrieving revision 1.52
  diff -u -r1.51 -r1.52
  --- DeltaManager.java 27 Jul 2005 15:11:38 -  1.51
  +++ DeltaManager.java 17 Aug 2005 08:13:12 -  1.52
  @@ -624,10 +624,12 @@
* @param msg Session message
*/
   protected void send(SessionMessage msg) {
  -if(isSendClusterDomainOnly())
  -cluster.sendClusterDomain(msg);
  -else
  -cluster.send(msg);
  +if(cluster != null) {
  +if(isSendClusterDomainOnly())
  +cluster.sendClusterDomain(msg);
  +else
  +cluster.send(msg);
  +}
   }
   
   /**
  @@ -1128,7 +1130,6 @@
   if (log.isDebugEnabled())
   log.debug(sm.getString(deltaManager.stopped, getName()));
   
  -getCluster().removeManager(getName(),this);
   
   // Validate and update our current component state
   if (!started)
  @@ -1154,7 +1155,7 @@
   
   // Require a new random number generator if we are restarted
   this.random = null;
  -
  +getCluster().removeManager(getName(),this);
   if (initialized) {
   destroy();
   }
  
  
  
  1.14  +8 -3  
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaRequest.java
  
  Index: DeltaRequest.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaRequest.java,v
  retrieving revision 1.13
  retrieving revision 1.14
  diff -u -r1.13 -r1.14
  --- DeltaRequest.java 27 Apr 2005 15:45:55 -  1.13
  +++ DeltaRequest.java 17 Aug 2005 08:13:12 -  1.14
  @@ -26,9 +26,11 @@
* @version 1.0
*/
   
  -import java.util.LinkedList;
   import java.io.Externalizable;
   import java.security.Principal;
  +import java.util.LinkedList;
  +
  +import org.apache.catalina.Realm;
   import org.apache.catalina.realm.GenericPrincipal;
   
   
  @@ -80,12 +82,15 @@
   int action = ACTION_SET;
   addAction(TYPE_MAXINTERVAL,action,NAME_MAXINTERVAL,new 
Integer(interval));
   }
  -
  +
   public void setPrincipal(Principal p) {
   int action = (p==null)?ACTION_REMOVE:ACTION_SET;
   SerializablePrincipal sp = null;
   if ( p != null ) {
  -sp = SerializablePrincipal.createPrincipal((GenericPrincipal)p);
  +if(p instanceof GenericPrincipal)
  +sp = 
SerializablePrincipal.createPrincipal((GenericPrincipal)p);
  +else
  +log.error(Only principal class GenericPrincipal currently 
supported use MemoryRealm );
   }
   addAction(TYPE_PRINCIPAL,action,NAME_PRINCIPAL,sp);
   }
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/common HandlerRequest.java

2005-08-17 Thread pero
pero2005/08/17 01:14:29

  Modified:jk/java/org/apache/jk/common HandlerRequest.java
  Log:
  Reports request secret only at trace level!
  
  Revision  ChangesPath
  1.49  +2 -2  
jakarta-tomcat-connectors/jk/java/org/apache/jk/common/HandlerRequest.java
  
  Index: HandlerRequest.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jk/java/org/apache/jk/common/HandlerRequest.java,v
  retrieving revision 1.48
  retrieving revision 1.49
  diff -u -r1.48 -r1.49
  --- HandlerRequest.java   16 Jul 2005 20:54:05 -  1.48
  +++ HandlerRequest.java   17 Aug 2005 08:14:29 -  1.49
  @@ -519,8 +519,8 @@
   case AjpConstants.SC_A_SECRET  :
   msg.getBytes(tmpMB);
   String secret=tmpMB.toString();
  -if(log.isInfoEnabled())
  -log.info(Secret:  + secret );
  +if(log.isTraceEnabled())
  +log.trace(Secret:  + secret );
   // endpoint note
   ep.setNote( secretNote, secret );
   break;
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 36218] New: - principal replication problem in cluster

2005-08-17 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36218.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36218

   Summary: principal replication problem in cluster
   Product: Tomcat 5
   Version: 5.5.9
  Platform: All
OS/Version: All
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina:Cluster
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


when using clustering the Principal seems not to be replicated correctly
It seems to be linked to the UserDatabaseRealm, using a o.a.c.users.MemoryUser 
principal instead of a GenericPrincipal

see:
http://www.mail-archive.com/tomcat-dev@jakarta.apache.org/msg74250.html

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm UserDatabaseRealm.java

2005-08-17 Thread pero
pero2005/08/17 03:40:37

  Modified:catalina/src/share/org/apache/catalina/realm
UserDatabaseRealm.java
  Log:
  Create GenericPrincipal  instead MemoryUser to eaisier cluster replication 
handling and compatibilty with all other
  standard implementation.
  
  MemoryUser can be found at userPrincipal.
  
  Revision  ChangesPath
  1.13  +27 -3 
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm/UserDatabaseRealm.java
  
  Index: UserDatabaseRealm.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm/UserDatabaseRealm.java,v
  retrieving revision 1.12
  retrieving revision 1.13
  diff -u -r1.12 -r1.13
  --- UserDatabaseRealm.java23 Feb 2005 19:27:56 -  1.12
  +++ UserDatabaseRealm.java17 Aug 2005 10:40:33 -  1.13
  @@ -19,7 +19,9 @@
   
   
   import java.security.Principal;
  +import java.util.ArrayList;
   import java.util.Iterator;
  +import java.util.List;
   
   import javax.naming.Context;
   
  @@ -30,6 +32,7 @@
   import org.apache.catalina.User;
   import org.apache.catalina.UserDatabase;
   import org.apache.catalina.core.StandardServer;
  +import org.apache.catalina.users.MemoryUser;
   import org.apache.catalina.util.StringManager;
   
   
  @@ -200,8 +203,29 @@
*/
   protected Principal getPrincipal(String username) {
   
  -return (database.findUser(username));
  -
  +Principal principal = database.findUser(username);
  +if(principal instanceof GenericPrincipal)
  +return principal ;
  +
  +List roles = new ArrayList();
  +if(principal instanceof MemoryUser) {
  +MemoryUser user = (MemoryUser)principal;
  +Iterator uroles = user.getRoles();
  +while(uroles.hasNext()) {
  +Role role = (Role)uroles.next();
  +roles.add(role.getName());
  +}
  +Iterator groups = user.getGroups();
  +while(groups.hasNext()) {
  +Group group = (Group)groups.next();
  +uroles = user.getRoles();
  +while(uroles.hasNext()) {
  +Role role = (Role)uroles.next();
  +roles.add(role.getName());
  +}
  +}
  +}
  +return new GenericPrincipal(this, username, getPassword(username), 
roles, principal);
   }
   
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session DeltaRequest.java LocalStrings.properties

2005-08-17 Thread pero
pero2005/08/17 03:41:50

  Modified:modules/cluster/src/share/org/apache/catalina/cluster/session
DeltaRequest.java LocalStrings.properties
  Log:
  Only support GenericPrincipals for backup nodes
  
  Revision  ChangesPath
  1.15  +18 -4 
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaRequest.java
  
  Index: DeltaRequest.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaRequest.java,v
  retrieving revision 1.14
  retrieving revision 1.15
  diff -u -r1.14 -r1.15
  --- DeltaRequest.java 17 Aug 2005 08:13:12 -  1.14
  +++ DeltaRequest.java 17 Aug 2005 10:41:50 -  1.15
  @@ -30,8 +30,8 @@
   import java.security.Principal;
   import java.util.LinkedList;
   
  -import org.apache.catalina.Realm;
   import org.apache.catalina.realm.GenericPrincipal;
  +import org.apache.catalina.util.StringManager;
   
   
   public class DeltaRequest implements Externalizable {
  @@ -39,6 +39,12 @@
   public static org.apache.commons.logging.Log log =
   org.apache.commons.logging.LogFactory.getLog( DeltaRequest.class );
   
  +/**
  + * The string manager for this package.
  + */
  +protected static StringManager sm = StringManager
  +.getManager(Constants.Package);
  +
   public static final int TYPE_ATTRIBUTE = 0;
   public static final int TYPE_PRINCIPAL = 1;
   public static final int TYPE_ISNEW = 2;
  @@ -83,14 +89,22 @@
   addAction(TYPE_MAXINTERVAL,action,NAME_MAXINTERVAL,new 
Integer(interval));
   }
   
  +/**
  + * convert principal at SerializablePrincipal for backup nodes.
  + * Only support principals from type [EMAIL PROTECTED] GenericPrincipal 
GenericPrincipal}
  + * @param p Session principal
  + * @see GenericPrincipal
  + */
   public void setPrincipal(Principal p) {
   int action = (p==null)?ACTION_REMOVE:ACTION_SET;
   SerializablePrincipal sp = null;
   if ( p != null ) {
  -if(p instanceof GenericPrincipal)
  +if(p instanceof GenericPrincipal) {
   sp = 
SerializablePrincipal.createPrincipal((GenericPrincipal)p);
  -else
  -log.error(Only principal class GenericPrincipal currently 
supported use MemoryRealm );
  +if(log.isDebugEnabled())
  +log.debug(sm.getString(deltaRequest.showPrincipal, 
p.getName() , getSessionId()));
  +} else
  +
log.error(sm.getString(deltaRequest.wrongPrincipalClass,p.getClass().getName()));
   }
   addAction(TYPE_PRINCIPAL,action,NAME_PRINCIPAL,sp);
   }
  
  
  
  1.11  +2 -0  
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/LocalStrings.properties
  
  Index: LocalStrings.properties
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/LocalStrings.properties,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -r1.10 -r1.11
  --- LocalStrings.properties   1 Jul 2005 16:47:10 -   1.10
  +++ LocalStrings.properties   17 Aug 2005 10:41:50 -  1.11
  @@ -41,6 +41,8 @@
   deltaManager.stopped=Manager [{0}] is stopping
   deltaManager.unloading.ioe=IOException while saving persisted sessions: {0}
   deltaManager.waitForSessionState=Manager [{0}], requesting session state 
from {1}. This operation will timeout if no session state has been received 
within 60 seconds.
  +deltaRequest.showPrincipal=Principal [{0}] is set to session {1}
  +deltaRequest.wrongPrincipalClass=DeltaManager only support GenericPrincipal. 
Your realm used principal class {0}.
   deltaSession.notifying=Notifying cluster of expiration primary={0} sessionId 
[{1}]
   deltaSession.valueBound.ex=Session bound listener throw an exception
   deltaSession.valueBinding.ex=Session binding listener throw an exception
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 36218] - principal replication problem in cluster

2005-08-17 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36218.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36218


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |NEEDINFO




--- Additional Comments From [EMAIL PROTECTED]  2005-08-17 12:46 ---
Now the UserDatabaseRealm also create GenericPrincipal class
and at my test cases with basic login config at web.xml it works.

OK, the set userPrincipal from GenericPrincipal are not transfered and this can
be a problem. 

Please, can you checkout the last tomcat cvs head and test the fix?

Thanks
Peter

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 36121] - Including JSP's changes working directory

2005-08-17 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36121.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36121





--- Additional Comments From [EMAIL PROTECTED]  2005-08-17 14:25 ---
Also reported Bug #36191 to Apache/mod_include but the conclusion was it wasn't
mod_include. Can anyone help us with this issue?

Tom

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 36221] New: - logger ... timestamp=false doesn't work

2005-08-17 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36221.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36221

   Summary: logger ... timestamp=false doesn't work
   Product: Tomcat 5
   Version: 5.0.28
  Platform: PC
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


Although setting timestamp of false, the log files still have a timestamp.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Tomcat 5.5.9 crashes DB server network card?

2005-08-17 Thread David Schnall
The network card of our DB server often freezes and all applications running
on APP are therefore failing. DB hard reboot necessary.
 
Let me first introduce the configuration:
Dell Poweredge 2400 Application server (APP) connected to Dell Poweredge
2400 Database server (DB)
Both are running under Windows NT  SP6a
DB has Oracle 8.1.6
APP has Apache 2.0.52 with mod_jk 1.2.13, Tomcat 5.5.9 and JDK 1_5_0_04
(APP was recently migrated from IBM HTTP Server 2 and Websphere Application
Server 4.0)
DB was running stable for a couple of years.
APP is running 6 applications sharing 3 DBCP connection pooling (masked
connection string):
 
Resource name=db/local scope=Shareable type=javax.sql.DataSource
auth=Container
url=jdbc:oracle:thin:@file_db:1521:DB password=pass maxActive=30
maxWait=-1 
driverClassName=oracle.jdbc.driver.OracleDriver username=xxx
maxIdle=10 /
Resource name=dbnl/local scope=Shareable
type=javax.sql.DataSource auth=Container
url=jdbc:oracle:thin:@file_db:1521:DB password=pass2 maxActive=20
maxWait=-1 
driverClassName=oracle.jdbc.driver.OracleDriver username=xxx2
maxIdle=10 /
Resource name=dbuk/local scope=Shareable
type=javax.sql.DataSource auth=Container
url=jdbc:oracle:thin:@file_db:1521:DB password=pass3 maxActive=30
maxWait=-1 
driverClassName=oracle.jdbc.driver.OracleDriver username=xxx3
maxIdle=10 /
 
Connector port=8009 
 maxThreads=150 minSpareThreads=25 maxSpareThreads=75
   enableLookups=false redirectPort=8443 protocol=AJP/1.3
/

Under certain conditions (seems to be heavier load) the network card of the
DB freezes and all applications running on APP are therefore failing. I've
checked all Oracle logs and Oracle is not crashing. The number of DB
connections is even low (around 30 while 150 permitted) and no new
connections are being created just before the crash.
The Apache 2 server status is not showing an abnormal high number of
connections either leading me to think Apache HTTP and mod_jk are not at
fault.
I am suspecting a race condition with DBCP connection pooling on Tomcat
5.5.9 which increases network traffic causing the network card of the DB
server to crash. Our DB server currently crashes 2 times a week.

I am planning to try installing tomcat 5.5.7 instead as I've seen some
changes logged in 5.5.9 regarding the ms thread pool (but at this stage I am
really guessing)
 
Problem also occurs using the AbandonnedPool option of Commons DBCP, ie with
following extra parameters in the Resource tag
removeAbandoned=true removeAbandonedTimeout=300 logAbandoned=true 

 stdout then contains the only visible error but error might be logical
since network is also interrupted.
 Please note that the connections are well closed programmatically as those
functions are called regularly. 
 It is just that when (before or after) DB crashes connections don't seem to
close. 
 
 All help/suggestions are welcome.
Thanks
 
StdOut:
---
 DBCP object created 2005-08-03 17:42:47 by the following code was never
closed:
java.lang.Exception
 at
org.apache.tomcat.dbcp.dbcp.AbandonedTrace.setStackTrace(AbandonedTrace.java
:157)
 at
org.apache.tomcat.dbcp.dbcp.AbandonedObjectPool.borrowObject(AbandonedObject
Pool.java:76)
 at
org.apache.tomcat.dbcp.dbcp.PoolingDataSource.getConnection(PoolingDataSourc
e.java:95)
 at
org.apache.tomcat.dbcp.dbcp.BasicDataSource.getConnection(BasicDataSource.ja
va:540)
 at com.bobex.dao.BaseDAO.getConnection(BaseDAO.java:176)
 at com.bobex.dao.BidDAO.findFeedbackOfBids(BidDAO.java:742)
 at
com.bobex.servlets.events.BidFeedbackListEventListener.requery(BidFeedbackLi
stEventListener.java:414)
 at
com.bobex.util.list.events.AbstractListModel.fireNext(AbstractListModel.java
:311)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
 at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
 at java.lang.reflect.Method.invoke(Unknown Source)
 at
com.bobex.util.list.events.AbstractListModel.listEventOccured(AbstractListMo
del.java:685)
 at com.bobex.taglibs.list.ListTag.doStartTag(ListTag.java:77)
 at
org.apache.jsp.mybobex.feedback_jsp._jspx_meth_util_list_0(org.apache.jsp.my
bobex.feedback_jsp:141)
 at
org.apache.jsp.mybobex.feedback_jsp._jspService(org.apache.jsp.mybobex.feedb
ack_jsp:103)
 at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:97)
 at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
 at
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:3
22)
 at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:291)
 at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:241)
 at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
 at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Application
FilterChain.java:252)
 at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterCh
ain.java:173)
 at

DO NOT REPLY [Bug 36198] - Class loading/compilation error

2005-08-17 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36198.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36198





--- Additional Comments From [EMAIL PROTECTED]  2005-08-17 15:27 ---
(In reply to comment #1)
 Are your classes in a package?
 Did you review of the documentation include 
 http://jakarta.apache.org/tomcat/faq/classnotfound.html ?

There is a single folder with a collection of classes that are not in a 
package, and then inside that folder there is a package of other classes.  

I have reviewed that documentation and it did not solve the problem.

The oddest part of this problem is that it has been occuring seemingly 
randomly.  I encountered it early in development and then started copying the 
classes into the working directory for the webapp which seemed to fix the 
problem for awhile.  Then after making a few alterations to the existing 
classes the problem has resurfaced.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Thank-You for contacting National Barcode, Inc.

2005-08-17 Thread sales
Thank-You for contacting National Barcode, Inc.

Thanks for emailing your request.  National Barcode is 
commited to providing the best customer service possible.  We 
will attempt to contact you by email or phone within 24 hours 
of receipt of your message.

You can phone us directly at 1-888-311-0834.

Be sure to check our specials page at 
http://www.nationalbarcode.com/main_specials.htm.

Sign up for our newsletter at 
http://www.nationalbarcode.com/NewsletterWebForm1.asp

Talk to you soon.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 36228] New: - (request.getHeaders(key)).nextElement() needs additional Permissions

2005-08-17 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36228.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36228

   Summary: (request.getHeaders(key)).nextElement()  needs
additional Permissions
   Product: Tomcat 5
   Version: 5.5.9
  Platform: Other
OS/Version: other
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


Running tomcat with security manager (request.getHeaders(key)).nextElement()
will cause following exception:

java.security.AccessControlException: access denied (java.lang.RuntimePermission
accessClassInPackage.org.apache.tomcat.util.buf)
at
java.security.AccessControlContext.checkPermission(AccessControlContext.java:264)
at 
java.security.AccessController.checkPermission(AccessController.java:427)
at java.lang.SecurityManager.checkPermission(SecurityManager.java:532)
at 
java.lang.SecurityManager.checkPackageAccess(SecurityManager.java:1512)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:265)
at java.lang.ClassLoader.loadClass(ClassLoader.java:299)
at java.lang.ClassLoader.loadClass(ClassLoader.java:299)
at java.lang.ClassLoader.loadClass(ClassLoader.java:251)
at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:319)
at org.apache.tomcat.util.buf.StringCache.toString(StringCache.java:282)
at org.apache.tomcat.util.buf.ByteChunk.toString(ByteChunk.java:461)
at 
org.apache.tomcat.util.buf.MessageBytes.toString(MessageBytes.java:209)
at
org.apache.tomcat.util.http.ValuesEnumerator.nextElement(MimeHeaders.java:423)

To work properly you have to add
accessClassInPackage.org.apache.tomcat.util.buf RuntimePermission.
Using the core servlet api should not require that internal tomcat packages have
to be exposed to the webapp.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: svn commit: r232600 - /tomcat/watchdog/branches/tc3.3.x/WARNING.txt

2005-08-17 Thread Larry Isaacs
Hi Mark,

I believe the tomcat_32 branch was the last clean build
of watchdog for Tomcat 3.2.x and 3.3.x.  I always used this
branch for testing 3.3.x builds.  Some refactoring was begun
at HEAD for Tomcat 4.x which was never completed before that
work moved to watchdog40.

Larry

 -Original Message-
 From: Bill Barker [mailto:[EMAIL PROTECTED] 
 Sent: Monday, August 15, 2005 3:21 PM
 To: Tomcat Developers List
 Subject: Re: svn commit: r232600 - 
 /tomcat/watchdog/branches/tc3.3.x/WARNING.txt
 
 
 - Original Message -
 From: Mark Thomas [EMAIL PROTECTED]
 To: Tomcat Developers List tomcat-dev@jakarta.apache.org
 Sent: Monday, August 15, 2005 11:00 AM
 Subject: Re: svn commit: r232600 -
 /tomcat/watchdog/branches/tc3.3.x/WARNING.txt
 
 
  Mark Thomas wrote:
   Bill Barker wrote:
  
   As a historical note, this really should be the tc3.2.x branch.  
   This particular watchdog has never worked well with any 
 TC 3.3.x, 
   since it has a lot of bugs related to specific implementation 
   details of TC 3.2.x (and, the Watchdog committers mostly 
 moved on 
   to TC 4.0.x during the Great Flame Wars, so it couldn't 
 be fixed by 
   TC 3.3.x committers
 :).
  
  
   Thanks for the clarification. I'll change it. That's once of the 
   nice things about subversion - renames (files or directories) are 
   easy and you keep the history.
 
  Bill,
 
  I have taken another look at the repository. There is a separate
  tomcat_32 branch so I assumed that the old HEAD in CVS must 
 have been 
  for 3.3.x (even if not much was done with it). Is this assumption 
  correct? If not, what is the correct interpretation?
 
 
 Actually, I haven't been here that long  ;-).  Maybe Larry or 
 Costin can remember why Watchdog was branched.  It was pretty 
 much dead by the time I joined tomcat-dev.  All I know is 
 that it needs quite a few patches to work with TC 3.3.x.
 
  As part of the migration to a TLP we will need to put 
 together our own 
  version control and download pages (rather than use the 
 Jakarta ones).
  I plan to include an explanation of the SVN structure in 
 the version 
  control page. I can include additional information such your note 
  above in this explanation.
 
  Cheers,
 
  mark
 
 
 
  
 -
  To unsubscribe, e-mail: [EMAIL PROTECTED]
  For additional commands, e-mail: [EMAIL PROTECTED]
 
 
 
 
 
 This message is intended only for the use of the person(s) 
 listed above as the intended recipient(s), and may contain 
 information that is PRIVILEGED and CONFIDENTIAL.  If you are 
 not an intended recipient, you may not read, copy, or 
 distribute this message or any attachment. If you received 
 this communication in error, please notify us immediately by 
 e-mail and then delete all copies of this message and any attachments.
 
 In addition you should be aware that ordinary (unencrypted) 
 e-mail sent through the Internet is not secure. Do not send 
 confidential or sensitive information, such as social 
 security numbers, account numbers, personal identification 
 numbers and passwords, to us via ordinary (unencrypted) e-mail.
 
 
 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]
 
 

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 36221] - logger ... timestamp=false doesn't work

2005-08-17 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36221.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36221


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |NEEDINFO




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: tag plugin

2005-08-17 Thread Remy Maucherat
wing lee wrote:
 Hi all,
 I'm working on the JSTL tag plugin for jasper. I don't fin any method in the 
 interface TagPluginContext to get the body content of the tag. But I have to 
 use it. Anyone can help me?

Isn't that supposed to be TagPluginContext.generateBody ? I didn't try
it, though.

Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml

2005-08-17 Thread remm
remm2005/08/17 08:07:19

  Modified:catalina/src/share/org/apache/catalina/connector
Request.java
   util/java/org/apache/tomcat/util/buf StringCache.java
   webapps/docs changelog.xml
  Log:
  - 36228: Some more CNFE.
  
  Revision  ChangesPath
  1.25  +8 -1  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector/Request.java
  
  Index: Request.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector/Request.java,v
  retrieving revision 1.24
  retrieving revision 1.25
  diff -u -r1.24 -r1.25
  --- Request.java  10 May 2005 20:51:43 -  1.24
  +++ Request.java  17 Aug 2005 15:07:19 -  1.25
  @@ -46,6 +46,7 @@
   
   import org.apache.tomcat.util.buf.B2CConverter;
   import org.apache.tomcat.util.buf.MessageBytes;
  +import org.apache.tomcat.util.buf.StringCache;
   import org.apache.tomcat.util.http.Cookies;
   import org.apache.tomcat.util.http.FastHttpDateFormat;
   import org.apache.tomcat.util.http.Parameters;
  @@ -85,6 +86,12 @@
   // --- 
Constructors
   
   
  +static {
  +// Ensure that classes are loaded for SM
  +new StringCache.ByteEntry();
  +new StringCache.CharEntry();
  +}
  +
   public Request() {
   
   formats[0].setTimeZone(GMT_ZONE);
  
  
  
  1.6   +2 -2  
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/buf/StringCache.java
  
  Index: StringCache.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/buf/StringCache.java,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- StringCache.java  27 Jul 2005 15:12:02 -  1.5
  +++ StringCache.java  17 Aug 2005 15:07:19 -  1.6
  @@ -620,7 +620,7 @@
   // -- ByteEntry Inner 
Class
   
   
  -protected static class ByteEntry {
  +public static class ByteEntry {
   
   public byte[] name = null;
   public String enc = null;
  @@ -645,7 +645,7 @@
   // -- CharEntry Inner 
Class
   
   
  -protected static class CharEntry {
  +public static class CharEntry {
   
   public char[] name = null;
   public String value = null;
  
  
  
  1.358 +2 -2  jakarta-tomcat-catalina/webapps/docs/changelog.xml
  
  Index: changelog.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v
  retrieving revision 1.357
  retrieving revision 1.358
  diff -u -r1.357 -r1.358
  --- changelog.xml 16 Aug 2005 16:52:42 -  1.357
  +++ changelog.xml 17 Aug 2005 15:07:19 -  1.358
  @@ -73,7 +73,7 @@
   bug34794/bug: Update connector documentation to include 
clientAuth attribute. (yoavs)
 /update
 fix
  -bug35894/bug: Fix CNFE when starting in a sandbox. (billbarker)
  +bug35894/bug, bug36228/bug: Fix CNFE when starting in a 
sandbox. (billbarker, remm)
 /fix
 fix
   Add version check for Tomcat native so that incompatible API changes 
are detected early (remm)
  @@ -121,7 +121,7 @@
 /fix
 fix
   bug36173/bug: Add missing sync in FastHttpDateFormat.formatDate, 
submitted 
  -by Alexei (remm)
  +by Alexei Krainiouk (remm)
 /fix
/changelog
 /subsection
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-site/xdocs-faq classnotfound.xml

2005-08-17 Thread idarwin
idarwin 2005/08/17 08:09:37

  Modified:.README.txt
   docs/faq classnotfound.html
   xdocs-faq classnotfound.xml
  Log:
  Typos.
  
  Revision  ChangesPath
  1.3   +2 -2  jakarta-tomcat-site/README.txt
  
  Index: README.txt
  ===
  RCS file: /home/cvs/jakarta-tomcat-site/README.txt,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- README.txt3 Jan 2005 20:15:34 -   1.2
  +++ README.txt17 Aug 2005 15:09:37 -  1.3
  @@ -9,7 +9,7 @@
   ***NOTE***
   
   The Tomcat web site is based on .xml files which are transformed
  -into .html files using XLST and Ant. 
  +into .html files using XSLT and Ant. 
   
   In order to make modifications to the Tomcat web site, you need
   to first check out the jakarta-tomcat-site modules from CVS:
  
  
  
  1.14  +12 -12jakarta-tomcat-site/docs/faq/classnotfound.html
  
  Index: classnotfound.html
  ===
  RCS file: /home/cvs/jakarta-tomcat-site/docs/faq/classnotfound.html,v
  retrieving revision 1.13
  retrieving revision 1.14
  diff -u -r1.13 -r1.14
  --- classnotfound.html21 Jul 2005 21:33:47 -  1.13
  +++ classnotfound.html17 Aug 2005 15:09:37 -  1.14
  @@ -1,10 +1,10 @@
  -htmlheadMETA http-equiv=Content-Type content=text/html; 
charset=iso-8859-1titleTomcat FAQ - Class Not Found Issues/titlemeta 
value=Tim Funk name=authormeta value=[EMAIL PROTECTED] 
name=emailstyle
  +htmlheadMETA http-equiv=Content-Type content=text/html; 
charset=iso-8859-1titleTomcat FAQ - Class Not Found Issues/titlemeta 
name=author value=Tim Funkmeta name=email value=[EMAIL 
PROTECTED]style
 dt { font-size : larger;  font-weight : bold }
 dd {padding-bottom : 10px;}
  -/style/headbody vlink=#525D76 alink=#525D76 link=#525D76 
text=#00 bgcolor=#fftable cellspacing=4 width=100% 
border=0!--PAGE HEADER--trtd colspan=2!--JAKARTA LOGO--a 
href=http://jakarta.apache.org/;img border=0 alt=The Jakarta Project 
align=left 
src=http://jakarta.apache.org//images/jakarta-logo.gif;/a!--PROJECT 
LOGO--a href=http://jakarta.apache.org/tomcat/;img border=0 alt=
  +/style/headbody bgcolor=#ff text=#00 link=#525D76 
alink=#525D76 vlink=#525D76table border=0 width=100% 
cellspacing=4!--PAGE HEADER--trtd colspan=2!--JAKARTA LOGO--a 
href=http://jakarta.apache.org/;img 
src=http://jakarta.apache.org//images/jakarta-logo.gif; align=left alt=The 
Jakarta Project border=0/a!--PROJECT LOGO--a 
href=http://jakarta.apache.org/tomcat/;img src=../images/tomcat.gif 
align=right alt=
 Tomcat FAQ
  - align=right src=../images/tomcat.gif/a/td/tr!--HEADER 
SEPARATOR--trtd colspan=2hr size=1 noshade=/td/trtr!--LEFT 
SIDE NAVIGATION--td nowrap=true valign=top 
width=20%pstrongLinks/strong/pullia href=..Tomcat 
Home/a/lilia href=index.htmlFAQ 
Home/a/li/ulpstrongContents/strong/pullia 
href=bugs.htmlBugs/a/lilia href=classnotfound.htmlClass Not 
Found/a/lilia href=connectors.htmlConnectors/a/lilia 
href=database.htmlDatabase/a/lilia 
href=deployment.htmlDeployment/a/lilia 
href=development.htmlDevelopment/a/lilia 
href=fda-validation.htmlFDA Validation/a/lilia 
href=http://wiki.apache.org/jakarta-tomcat/HowTo;How do I/a/lilia 
href=unix.htmlLinux / Unix/a/lilia 
href=otherOperatingSystems.htmlOther Operating Systems/a/lilia 
href=logging.htmlLogging/a/lilia 
href=memory.htmlMemory/a/lilia href=meta.htmlMeta/a/lilia 
href=misc.htmlMiscellaneous/a/lilia 
href=performance.htmlMonitoring / Performance/a/lilia 
href=http://wiki.apache.org/jakarta-tomcat/UsefulLinks;Other 
Resources/a/lilia href=security.htmlSecurity/a/lilia 
href=version.htmlWhich Version/a/lilia href=tomcatuser.htmlTomcat 
User List/a/lilia 
href=http://wiki.apache.org/jakarta-tomcat/;Wiki/a/lilia 
href=windows.htmlWindows/a/li/ul/td!--RIGHT SIDE MAIN BODY--td 
align=left valign=top width=80%table cellspacing=4 width=100% 
border=0trtd nowrap=true valign=top align=lefth1Tomcat 
FAQ/h1h2Class Not Found Issues/h2/tdtd nowrap=true valign=top 
align=rightsmalla href=printer/classnotfound.htmlimg alt=Printer 
Friendly Version border=0 
src=../images/printer.gifbrprint-friendlybrversion
  -/a/small/td/tr/tabletable cellpadding=2 
cellspacing=0 border=0trtd bgcolor=#525D76font 
face=arial,helvetica.sanserif color=#ffa 
name=PrefacestrongPreface/strong/a/font/td/trtrtdblockquote
  + border=0/a/td/tr!--HEADER SEPARATOR--trtd 
colspan=2hr noshade= size=1/td/trtr!--LEFT SIDE 
NAVIGATION--td width=20% valign=top 
nowrap=truepstrongLinks/strong/pullia href=..Tomcat 
Home/a/lilia href=index.htmlFAQ 
Home/a/li/ulpstrongContents/strong/pullia 
href=bugs.htmlBugs/a/lilia href=classnotfound.htmlClass Not 
Found/a/lilia href=connectors.htmlConnectors/a/lilia 
href=database.htmlDatabase/a/lilia 

DO NOT REPLY [Bug 36228] - (request.getHeaders(key)).nextElement() needs additional Permissions

2005-08-17 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36228.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36228


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-08-17 17:11 ---
Ok.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/webapps/ROOT favicon.ico

2005-08-17 Thread remm
remm2005/08/17 08:29:18

  Added:   webapps/ROOT favicon.ico
  Log:
  - No comment.
  
  Revision  ChangesPath
  1.1  jakarta-tomcat-catalina/webapps/ROOT/favicon.ico
  
Binary file
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 36221] - logger ... timestamp=false doesn't work

2005-08-17 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36221.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36221


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution||INVALID




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 36231] New: - getCause() null for ServletException

2005-08-17 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36231.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36231

   Summary: getCause() null for ServletException
   Product: Tomcat 5
   Version: 5.5.9
  Platform: All
OS/Version: other
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


It seems that ServletException was written before getCause() was added to
Throwable (jdk 1.4), and thus has its own getRootCause().  So generic error
handling is unnecessarily harder, stack traces incomplete, etc. when a
ServletException is thrown; e.g. in the ApplicationFilterChain code.

I think ServletException should be changed, but the behavior could be changed
even if thats not possible.  For example, when throwing a ServletException with
a root cause exception, also call the initCause() method.  It returns a
reference to itself, so you could even do throw (ServletException)new
ServletException(msg, e).initCause(e); (or something similar if that doesn't
compile).

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 36198] - Class loading/compilation error

2005-08-17 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36198.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36198





--- Additional Comments From [EMAIL PROTECTED]  2005-08-17 19:17 ---
(In reply to comment #2)
  Did you review of the documentation include 
  http://jakarta.apache.org/tomcat/faq/classnotfound.html ?
 
 There is a single folder with a collection of classes that are not in a 
 package, and then inside that folder there is a package of other classes.  

The FAQ makes clear that all classes should be in a package. I suspect that this
is the root cause of the issue. Please put all your classes in a package and 
retest.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: svn commit: r232600 - /tomcat/watchdog/branches/tc3.3.x/WARNING.txt

2005-08-17 Thread Mark Thomas

Larry Isaacs wrote:

Hi Mark,

I believe the tomcat_32 branch was the last clean build
of watchdog for Tomcat 3.2.x and 3.3.x.  I always used this
branch for testing 3.3.x builds.  Some refactoring was begun
at HEAD for Tomcat 4.x which was never completed before that
work moved to watchdog40.


Larry,

Thanks for the explanation. I'll move the branches around to reflect this.

Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 36231] - getCause() null for ServletException

2005-08-17 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36231.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36231


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2005-08-17 19:26 ---
ServletException is defined by the servlet spec and therefore cannot be changed
by the Tomcat team.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 36231] - getCause() null for ServletException

2005-08-17 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36231.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36231


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |




--- Additional Comments From [EMAIL PROTECTED]  2005-08-17 19:33 ---
Firstly, ServletException could be fixed without a change to its interface, and
it would not violate the Servlet spec.  I don't know if the Tomcat team can do
that or not, sounds like maybe not.
Tomcat can and should be fixed independent of ServletException being fixed, and
I stated my opinion of how in the bug description.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 34840] - updating war - tomcat removes mycontext.xml

2005-08-17 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=34840.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34840


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |




--- Additional Comments From [EMAIL PROTECTED]  2005-08-17 19:48 ---
I am also experiencing this problem when I use the start/stop deployer commands
which worked in version 5.5.7. My normall pattern was to stop the application,
then copy an updated war file then start the application.

With version 5.5.9 it deletes the context.xml file from the
conf\Catalina\host directory for that context when it is stopped, so I can't
start it again.

I guess for a redeploy case I should be using undeploy/redeploy which I am not,
but what about the case where I want to take the application offline say for a
database backup, there is now not a way to start the application again as it
can't find the context.

Also I agree with the other comments that I don't want to define my data sources
within the war file I want to use a per server configuration. I know that I can
always modify the war file after it has been created with the context file
before deploy but that would just be one extra step for someone to forget.

Paul

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 36102] - jk 1.2.14 - Worker actions do not persist

2005-08-17 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36102.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36102





--- Additional Comments From [EMAIL PROTECTED]  2005-08-17 19:50 ---
First off, I am no JK expert.

A quick Google suggests that some people needed to set the isolation mode to get
jk to work whilst others didn't.

I would move this to tomcat-dev list and see what response you get. I'll still
do my test with IIS and contribute to that discussion if I find anything
enlightening.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 36231] - getCause() null for ServletException

2005-08-17 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36231.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36231





--- Additional Comments From [EMAIL PROTECTED]  2005-08-17 20:09 ---
Only the spec team can change the interface or implementation of any
javax.servlet.* classes.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 36231] - getCause() null for ServletException

2005-08-17 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36231.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36231


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2005-08-17 20:22 ---
Servlet v2.4 section SRV.1.2 ends with:

J2SE 1.3 is the minimum version of the underlying Java platform with which
servlet containers must be built.

This minimum prevents using initCause(), which is not available in J2SE 1.3.  
This will be fixable in Servlet v2.5.  Since Tomcat uses the JSR sponsored 
reference implementation, which I think has to stick with the mimimum, I'm 
marking this bug INVALID.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 36231] - getCause() null for ServletException

2005-08-17 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36231.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36231





--- Additional Comments From [EMAIL PROTECTED]  2005-08-17 20:58 ---
From the 5.5.9 release notes:
Tomcat 5.5 is designed to run on J2SE 5.0 and later, and requires
configuration to run on J2SE 1.4.  Make sure to read the RUNNING.txt 
file in this directory if you are using J2SE 1.4.

I take that to mean Tomcat won't run under java 1.3.  I strongly doubt it is
compiled with jdk1.3 either.

Just to be clear, because I think the point is being missed, the fix I proposed
is for Tomcat to invoke initCause(), until ServletException itself is fixed.  I
won't reopen the bug again, but in my opinion it is not invalid and should be 
fixed.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 36198] - Class loading/compilation error

2005-08-17 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36198.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36198


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-08-17 21:06 ---
(In reply to comment #3)
 (In reply to comment #2)
   Did you review of the documentation include 
   http://jakarta.apache.org/tomcat/faq/classnotfound.html ?
  
  There is a single folder with a collection of classes that are not in a 
  package, and then inside that folder there is a package of other classes.  
 The FAQ makes clear that all classes should be in a package. I suspect that 
this
 is the root cause of the issue. Please put all your classes in a package and 
retest.

Thank you for your help, this appears to have fixed the problem.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 36231] - getCause() null for ServletException

2005-08-17 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36231.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36231


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Component|Catalina|Servlet  JSP API




--- Additional Comments From [EMAIL PROTECTED]  2005-08-17 21:30 ---
Tomcat 5.5.9 requires 1.4 or later, but the servlet-api.jar it uses is expected 
to be able to run with 1.3, per the spec.  Thus, isn't not feasible to fix 
servlet-api.jar itself.  Tomcat could call initCause() as you suggest, but if 
someone wrote a webapp that depended on getCause() not returning null, the 
webapp would likely not be portable.  This is a case where unnecessarily 
harder is preferred to help ensure the portability of webapps.

Since I would guess that you likely don't care about portability, you could 
customize your Tomcat to fix this.  Simpler may be just to write a utility 
class with a static method that accepts a ServletException and returns the 
cause from getRootCause() or getCause(), which ever is not null.

Updating the component, since this is where the primary issue lies.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r233248 - in /tomcat/watchdog/branches: other/3.x/tomcat3_prepfor40/ tc3.3.x/

2005-08-17 Thread markt
Author: markt
Date: Wed Aug 17 12:31:06 2005
New Revision: 233248

URL: http://svn.apache.org/viewcvs?rev=233248view=rev
Log:
Better reflect watchdog history

Added:
tomcat/watchdog/branches/other/3.x/tomcat3_prepfor40/
  - copied from r233247, tomcat/watchdog/branches/tc3.3.x/
Removed:
tomcat/watchdog/branches/tc3.3.x/


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r233249 - in /tomcat/watchdog/branches: other/3.x/tomcat_32/ tc3.2.x/

2005-08-17 Thread markt
Author: markt
Date: Wed Aug 17 12:32:03 2005
New Revision: 233249

URL: http://svn.apache.org/viewcvs?rev=233249view=rev
Log:
Better reflect watchdog history

Added:
tomcat/watchdog/branches/tc3.2.x/
  - copied from r233248, tomcat/watchdog/branches/other/3.x/tomcat_32/
Removed:
tomcat/watchdog/branches/other/3.x/tomcat_32/


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33106] - SSI Processing Enhancements (patch provided)

2005-08-17 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33106.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33106


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-08-17 23:15 ---
Fixed in CVS for 5.5.x and will be included in next release.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/ssi ExpressionTokenizer.java SSIFlastmod.java SSIServletExternalResolver.java

2005-08-17 Thread markt
markt   2005/08/17 14:21:37

  Modified:catalina/src/share/org/apache/catalina/ssi
ExpressionTokenizer.java SSIFlastmod.java
SSIServletExternalResolver.java
  Log:
  Fix handling of non-file based includes with SSI
   - Patch submitted by David Becker
  
  Removed unused code in package o.a.c.ssi (Eclipse)
  
  Revision  ChangesPath
  1.3   +1 -2  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/ssi/ExpressionTokenizer.java
  
  Index: ExpressionTokenizer.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/ssi/ExpressionTokenizer.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- ExpressionTokenizer.java  1 Sep 2004 18:33:33 -   1.2
  +++ ExpressionTokenizer.java  17 Aug 2005 21:21:37 -  1.3
  @@ -34,7 +34,6 @@
   public static final int TOKEN_LT = 11;
   public static final int TOKEN_END = 12;
   private char[] expr;
  -private int tokenType = TOKEN_STRING;
   private String tokenVal = null;
   private int index;
   private int length;
  
  
  
  1.6   +1 -2  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/ssi/SSIFlastmod.java
  
  Index: SSIFlastmod.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/ssi/SSIFlastmod.java,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- SSIFlastmod.java  23 Apr 2005 10:22:37 -  1.5
  +++ SSIFlastmod.java  17 Aug 2005 21:21:37 -  1.6
  @@ -33,7 +33,6 @@
   String[] paramNames, String[] paramValues, PrintWriter writer) {
long lastModified = 0;
   String configErrMsg = ssiMediator.getConfigErrMsg();
  -StringBuffer buf = new StringBuffer();
   for (int i = 0; i  paramNames.length; i++) {
   String paramName = paramNames[i];
   String paramValue = paramValues[i];
  
  
  
  1.8   +15 -7 
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/ssi/SSIServletExternalResolver.java
  
  Index: SSIServletExternalResolver.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/ssi/SSIServletExternalResolver.java,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- SSIServletExternalResolver.java   30 Apr 2005 17:20:50 -  1.7
  +++ SSIServletExternalResolver.java   17 Aug 2005 21:21:37 -  1.8
  @@ -244,7 +244,7 @@
   uriEncoding =
   
((Request)req).getConnector().getURIEncoding();
   useBodyEncodingForURI = ((Request)req)
  - 
.getConnector().getUseBodyEncodingForURI();
  +
.getConnector().getUseBodyEncodingForURI();
   }
   
   // If valid, apply settings from request / connector
  @@ -394,7 +394,7 @@
   
   protected ServletContextAndPath getServletContextAndPathFromVirtualPath(
   String virtualPath) throws IOException {
  -String path = null;
  +
   if (!virtualPath.startsWith(/)  !virtualPath.startsWith(\\)) {
   return new ServletContextAndPath(context,
   getAbsolutePath(virtualPath));
  @@ -475,16 +475,24 @@
   public long getFileLastModified(String path, boolean virtual)
   throws IOException {
   long lastModified = 0;
  -URLConnection urlConnection = getURLConnection(path, virtual);
  -lastModified = urlConnection.getLastModified();
  +try {
  +URLConnection urlConnection = getURLConnection(path, virtual);
  +lastModified = urlConnection.getLastModified();
  +} catch (IOException e) {
  +// Ignore this. It will always fail for non-file based includes
  +}
   return lastModified;
   }
   
   
   public long getFileSize(String path, boolean virtual) throws IOException 
{
   long fileSize = -1;
  -URLConnection urlConnection = getURLConnection(path, virtual);
  -fileSize = urlConnection.getContentLength();
  +try {
  +URLConnection urlConnection = getURLConnection(path, virtual);
  +fileSize = urlConnection.getContentLength();
  +} catch (IOException e) {
  +// Ignore this. It will always fail for non-file based includes
  +}
   return fileSize;
   }
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For 

Re: Subversion migration update

2005-08-17 Thread Mark Thomas

Mark Thomas wrote:
snip
The performance comparison between CVS and SVN is in the early stages 
and I will post some results once I have a more complete set.


Tests performed on WinXP SP2, with Tortoise CVS 1.8.18 and Tortoise 
SVN 1.2.1 using the Watchdog repository. For tests using a single file 
I used build.xml.


The results are (averages in seconds):
Operation  CVS  SVN
checkout   38   51
history 45
blame   47
diff42
revert  71

Also, SVN does not support revision graphs. Some tools can derive the 
graph but for the ASF repository this will take hours, possibly days.


See http://subversion.tigris.org/ for a list of other SVN benefits.

I am +1 for moving the remaining Tomcat CVS modules to SVN.

Assuming everyone else is happy to move the remaining tomcat modules 
to SVN I would suggest the following stages (Watchdog was stage 1). 
I'll give people at least a week to comment on this proposal and 
assuming no -1's start the phase 2 towards the end of next week.


2. j-t-service, j-t-site
3. j-servletapi, j-servletapi-4, j-servletapi-5
4. j-tomcat, j-tomcat-4.0
5. j-t-catalina, j-t-5, j-t-jasper, j-t-connectors

Do we need an OK from the spec team before we do stage 3?

Any other comments/concerns?

Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



re:Re: tag plugin

2005-08-17 Thread wing lee
I've tried the generateBody method, but it just generate such code 
write.out(body content), don't return the value of the body content. 


Remy Maucherat [EMAIL PROTECTED] 写道:wing lee wrote:
 Hi all,
 I'm working on the JSTL tag plugin for jasper. I don't fin any method in the 
 interface TagPluginContext to get the body content of the tag. But I have to 
 use it. Anyone can help me?

Isn't that supposed to be TagPluginContext.generateBody ? I didn't try
it, though.

Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
DO YOU YAHOO!?
  雅虎邮箱超强增值服务-2G超大空间、pop3收信、无限量邮件提醒 

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm UserDatabaseRealm.java

2005-08-17 Thread billbarker
billbarker2005/08/17 21:41:02

  Modified:catalina/src/share/org/apache/catalina/realm
UserDatabaseRealm.java
  Log:
  Clean up previous patch so it works with Custom UserDatabases, not just the 
Memory one.
  
  Revision  ChangesPath
  1.14  +22 -18
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm/UserDatabaseRealm.java
  
  Index: UserDatabaseRealm.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm/UserDatabaseRealm.java,v
  retrieving revision 1.13
  retrieving revision 1.14
  diff -u -r1.13 -r1.14
  --- UserDatabaseRealm.java17 Aug 2005 10:40:33 -  1.13
  +++ UserDatabaseRealm.java18 Aug 2005 04:41:02 -  1.14
  @@ -142,6 +142,12 @@
* @param role Security role to be checked
*/
   public boolean hasRole(Principal principal, String role) {
  +if( principal instanceof GenericPrincipal) {
  +GenericPrincipal gp = (GenericPrincipal)principal;
  +if(gp.getUserPrincipal() instanceof User) {
  +principal = gp.getUserPrincipal();
  +}
  +}
   if(! (principal instanceof User) ) {
   //Play nice with SSO and mixed Realms
   return super.hasRole(principal, role);
  @@ -203,29 +209,27 @@
*/
   protected Principal getPrincipal(String username) {
   
  -Principal principal = database.findUser(username);
  -if(principal instanceof GenericPrincipal)
  -return principal ;
  -
  +User user = database.findUser(username);
  +if(user == null) {
  +return null;
  +}
  +
   List roles = new ArrayList();
  -if(principal instanceof MemoryUser) {
  -MemoryUser user = (MemoryUser)principal;
  -Iterator uroles = user.getRoles();
  +Iterator uroles = user.getRoles();
  +while(uroles.hasNext()) {
  +Role role = (Role)uroles.next();
  +roles.add(role.getName());
  +}
  +Iterator groups = user.getGroups();
  +while(groups.hasNext()) {
  +Group group = (Group)groups.next();
  +uroles = user.getRoles();
   while(uroles.hasNext()) {
   Role role = (Role)uroles.next();
   roles.add(role.getName());
   }
  -Iterator groups = user.getGroups();
  -while(groups.hasNext()) {
  -Group group = (Group)groups.next();
  -uroles = user.getRoles();
  -while(uroles.hasNext()) {
  -Role role = (Role)uroles.next();
  -roles.add(role.getName());
  -}
  -}
   }
  -return new GenericPrincipal(this, username, getPassword(username), 
roles, principal);
  +return new GenericPrincipal(this, username, user.getPassword(), 
roles, user);
   }
   
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]