DO NOT REPLY [Bug 36541] - session getAttribute/setAttribute and removeAttribute are NOT Thread safe.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36541. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36541 --- Additional Comments From [EMAIL PROTECTED] 2005-09-14 08:04 --- (In reply to comment #78) Guys, we're in active discussion with the Servlet Spec expert group about resolving this. It's an open issue in the center of everyone's radar and highest on the priority list. It'll get fixed in the best way possible as soon as possible. Let's try to stay professional about it. Thanx Yoav, great news! I hope this issue will get solved, and we all get our I've found a bug in the spec and all I got was this lousy t-shirt t-shirts, and, most important, stable production systems soon. regards Leon -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native/common jk_ajp_common.c jk_connect.h
mturk 2005/09/13 23:45:00 Modified:jk/native/common jk_ajp_common.c jk_connect.h Log: Make jk_sleep_def as nonstatic. Revision ChangesPath 1.120 +2 -2 jakarta-tomcat-connectors/jk/native/common/jk_ajp_common.c Index: jk_ajp_common.c === RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_ajp_common.c,v retrieving revision 1.119 retrieving revision 1.120 diff -u -r1.119 -r1.120 --- jk_ajp_common.c 26 May 2005 14:36:14 - 1.119 +++ jk_ajp_common.c 14 Sep 2005 06:45:00 - 1.120 @@ -36,7 +36,7 @@ #endif /* Sleep for 100ms */ -static void jk_sleep_def(void) +void jk_sleep_def(void) { #ifdef OS2 DosSleep(100); 1.16 +3 -1 jakarta-tomcat-connectors/jk/native/common/jk_connect.h Index: jk_connect.h === RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_connect.h,v retrieving revision 1.15 retrieving revision 1.16 diff -u -r1.15 -r1.16 --- jk_connect.h 24 Apr 2005 09:52:57 - 1.15 +++ jk_connect.h 14 Sep 2005 06:45:00 - 1.16 @@ -55,6 +55,8 @@ int jk_is_socket_connected(int sd); +void jk_sleep_def(); + #ifdef __cplusplus } #endif /* __cplusplus */ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/xdocs changelog.xml
mturk 2005/09/13 23:50:14 Modified:jk/native/common jk_lb_worker.c jk/xdocs changelog.xml Log: Fix lb for worker mpm's with cachesize set to lower number then ThreadsPerChild is. If retries is set to value larger then 3 sleep for 100 ms on each attempt. This enables to tune the connection cache, and serialize incoming connections instead returning busy if connection count is larger then cachesize. Revision ChangesPath 1.93 +14 -6 jakarta-tomcat-connectors/jk/native/common/jk_lb_worker.c Index: jk_lb_worker.c === RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_lb_worker.c,v retrieving revision 1.92 retrieving revision 1.93 diff -u -r1.92 -r1.93 --- jk_lb_worker.c12 Sep 2005 12:53:05 - 1.92 +++ jk_lb_worker.c14 Sep 2005 06:50:14 - 1.93 @@ -652,13 +652,19 @@ * mark the worker as busy rather then * as in error */ -rec-s-is_busy = JK_TRUE; +if (p-worker-s-retries num_of_workers) +rec-s-is_busy = JK_TRUE; jk_log(l, JK_LOG_INFO, - could not get free endpoint for worker %s, - rec-s-name); + could not get free endpoint for worker %s (attempt %d), + rec-s-name, attempt); /* Decrement the worker count and try another worker */ ---num_of_workers; -prec = rec; +if (attempt p-worker-s-retries) +num_of_workers = 0; +/* In case of retries 3 sleep 100 ms + * on each next attempt. + */ +else if (attempt JK_RETRIES) +jk_sleep_def(); continue; } if (service_stat == JK_FALSE) { @@ -725,6 +731,7 @@ jk_log(l, JK_LOG_DEBUG, recoverable error... will try to recover on other host); } +#if 0 else { /* NULL record, no more workers left ... */ jk_log(l, JK_LOG_ERROR, @@ -733,6 +740,7 @@ *is_error = JK_HTTP_SERVER_BUSY; return JK_FALSE; } +#endif --num_of_workers; prec = rec; } 1.42 +7 -0 jakarta-tomcat-connectors/jk/xdocs/changelog.xml Index: changelog.xml === RCS file: /home/cvs/jakarta-tomcat-connectors/jk/xdocs/changelog.xml,v retrieving revision 1.41 retrieving revision 1.42 diff -u -r1.41 -r1.42 --- changelog.xml 12 Sep 2005 14:29:49 - 1.41 +++ changelog.xml 14 Sep 2005 06:50:14 - 1.42 @@ -26,6 +26,13 @@ subsection name=Native changelog fix +Fix lb for worker mpm's with cachesize set to lower number then +ThreadsPerChild is. If retries is set to value larger then 3 sleep for +100 ms on each attempt. This enables to tune the connection cache, +and serialize incoming connections instead returning busy if connection +count is larger then cachesize. (mturk) + /fix + fix bug36525/bug: Solaris core dump. (mturk) /fix fix - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36541] - session getAttribute/setAttribute and removeAttribute are NOT Thread safe.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36541. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36541 --- Additional Comments From [EMAIL PROTECTED] 2005-09-14 10:29 --- Ok, so completely innocently here (despite what people may happen to think - I'm *still* incensed by reading the history on this bug, and still feel well and truly PO'd...) Why does the following not represent an issue in DeltaSession 1.35? http://cvs.apache.org/viewcvs.cgi/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/ catalina/cluster/session/DeltaSession.java?rev=1.35view=markup Access to attributes.put() remains unsynchronized; synchronizing the remainder, especially when other methods are synchronized, strikes me as an oversight - it should cause the exact same problem (albeit less often, because reads are being serialized) as a put can still cause the hashmap to resize, and therefore still hit the problem; those puts are also allowed during retrieval of attributes.keyset() and other long-running actions as a result of this. removeAttributeInternal() also fails to synchronize the removal of the attribute from the map, and thus also creates the issue; attribute removal and insert can both cause a right-timed reader to fail. So it's not just limited to StandardSession, which... http://cvs.apache.org/viewcvs.cgi/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/ session/StandardSession.java?rev=1.60view=markup also fails to synchronize its session data in the current 5.0.11 branch - although it, too, does half the job by performing unsynchronized reads, synchronizing writes, failing to synchronize keyset retrieval, etc. So how is this not a 5.5 bug? StandardSession will definitely exhibit the behavior a lot more often, but the bug is still fundamentally *there* on both. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: cvs commit: jakarta-tomcat-connectors/jk/xdocs changelog.xml
I'm pretty sure this patch is broken looking at it now. The HTTP_ variants used in the extension aren't initialized properly. I'm currently on the road, but I'll be able to fix this up next week. tim From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Tue 13/09/2005 01:46 To: [EMAIL PROTECTED] Subject: cvs commit: jakarta-tomcat-connectors/jk/xdocs changelog.xml mturk 2005/09/12 06:46:01 Modified:jk/native/iis jk_isapi_plugin.c jk/xdocs changelog.xml Log: Fix #35298. Patch provided by Tim Whittington. Revision ChangesPath 1.51 +22 -6 jakarta-tomcat-connectors/jk/native/iis/jk_isapi_plugin.c Index: jk_isapi_plugin.c === RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/iis/jk_isapi_plugin.c,v retrieving revision 1.50 retrieving revision 1.51 diff -u -r1.50 -r1.51 --- jk_isapi_plugin.c 12 Sep 2005 12:54:31 - 1.50 +++ jk_isapi_plugin.c 12 Sep 2005 13:46:00 - 1.51 @@ -51,11 +51,22 @@ * 3. The contents of the Translate header, if any * */ -#define URI_HEADER_NAME (TOMCATURI:) -#define QUERY_HEADER_NAME(TOMCATQUERY:) -#define WORKER_HEADER_NAME (TOMCATWORKER:) -#define TOMCAT_TRANSLATE_HEADER_NAME (TOMCATTRANSLATE:) -#define CONTENT_LENGTH (CONTENT_LENGTH:) +#define URI_HEADER_NAME_BASE (TOMCATURI) +#define QUERY_HEADER_NAME_BASE (TOMCATQUERY) +#define WORKER_HEADER_NAME_BASE (TOMCATWORKER) +#define TOMCAT_TRANSLATE_HEADER_NAME_BASE (TOMCATTRANSLATE) + +static char URI_HEADER_NAME[_MAX_FNAME]; +static char QUERY_HEADER_NAME[_MAX_FNAME]; +static char WORKER_HEADER_NAME[_MAX_FNAME]; +static char TOMCAT_TRANSLATE_HEADER_NAME[_MAX_FNAME]; + +/* The template used to construct our unique headers + * from the base name and module instance + */ +#define HEADER_TEMPLATE (%s_%p:) + +#define CONTENT_LENGTH (CONTENT_LENGTH) #define HTTP_URI_HEADER_NAME (HTTP_TOMCATURI) #define HTTP_QUERY_HEADER_NAME (HTTP_TOMCATQUERY) @@ -1090,6 +1101,11 @@ else { fReturn = JK_FALSE; } +/* Construct redirector headers to use for this redirector instance */ +sprintf(URI_HEADER_NAME, HEADER_TEMPLATE, URI_HEADER_NAME_BASE, hInst); +sprintf(QUERY_HEADER_NAME, HEADER_TEMPLATE, QUERY_HEADER_NAME_BASE, hInst); +sprintf(WORKER_HEADER_NAME, HEADER_TEMPLATE, WORKER_HEADER_NAME_BASE, hInst); +sprintf(TOMCAT_TRANSLATE_HEADER_NAME, HEADER_TEMPLATE, TOMCAT_TRANSLATE_HEADER_NAME_BASE, hInst); break; case DLL_PROCESS_DETACH: __try { 1.39 +3 -0 jakarta-tomcat-connectors/jk/xdocs/changelog.xml Index: changelog.xml === RCS file: /home/cvs/jakarta-tomcat-connectors/jk/xdocs/changelog.xml,v retrieving revision 1.38 retrieving revision 1.39 diff -u -r1.38 -r1.39 --- changelog.xml 12 Sep 2005 13:28:31 - 1.38 +++ changelog.xml 12 Sep 2005 13:46:01 - 1.39 @@ -35,6 +35,9 @@ bug35809/bug: JkMountCopy don't work for Apache 2.0 Patch provided by Christophe Dubach. (mturk) /fix + bug35298/bug: Multiple JK/ISAPI redirectors on a single IIS site are not supported + Patch provided by Tim Whittington. (mturk) + /fix /changelog /subsection /section - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36651] New: - SSI servlet output is always sent as UTF-8
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36651. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36651 Summary: SSI servlet output is always sent as UTF-8 Product: Tomcat 5 Version: 5.5.9 Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: Servlets:SSI AssignedTo: tomcat-dev@jakarta.apache.org ReportedBy: [EMAIL PROTECTED] The SSI servlet of Tomcat always sends its output as UTF-8 even if the outputEncoding and inputEncoding variables for this servlet are set to another encoding (for ex. iso-8859-9) It does not matter if the variables mentioned above are set, or the page has a character encoding set for itself, output is always UTF-8. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: [Vote] (was Re: Top Level Project? Time for Top Level Lists?)
Bugs [X] forward to [EMAIL PROTECTED] [ ] forward to [EMAIL PROTECTED] Commits [X] forward to [EMAIL PROTECTED] [ ] forward to [EMAIL PROTECTED] +ashly -Original Message- From: Ian Darwin [mailto:[EMAIL PROTECTED] Sent: Tuesday, September 13, 2005 8:05 PM To: Tomcat Developers List Subject: Re: [Vote] (was Re: Top Level Project? Time for Top Level Lists?) Bugs [X] forward to [EMAIL PROTECTED] [ ] forward to [EMAIL PROTECTED] Commits [X] forward to [EMAIL PROTECTED] [ ] forward to [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] CAUTION - Disclaimer * This e-mail contains PRIVILEGED AND CONFIDENTIAL INFORMATION intended solely for the use of the addressee(s). If you are not the intended recipient, please notify the sender by e-mail and delete the original message. Further, you are not to copy, disclose, or distribute this e-mail or its contents to any other person and any such actions are unlawful. This e-mail may contain viruses. Infosys has taken every reasonable precaution to minimize this risk, but is not liable for any damage you may sustain as a result of any virus in this e-mail. You should carry out your own virus checks before opening the e-mail or attachment. Infosys reserves the right to monitor and review the content of all messages sent to or from this e-mail address. Messages sent to or from this e-mail address may be stored on the Infosys e-mail system. ***INFOSYS End of Disclaimer INFOSYS*** - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/jk/xdocs changelog.xml
Tim Whittington wrote: I'm pretty sure this patch is broken looking at it now. The HTTP_ variants used in the extension aren't initialized properly. I'm currently on the road, but I'll be able to fix this up next week. You are correct about that. I was presuming the patch is correct (may bad), but it lacks the HTTP_ prefixes. I'll correct that today or tomorrow if you don't provide a patch. Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native/iis jk_isapi_plugin.c
mturk 2005/09/14 03:52:44 Modified:jk/native/iis jk_isapi_plugin.c Log: Fix patch 35298. The patch was lacking the HTTP_ prefix headers with dll instance postfix. Also the postfix is bogus if there is underscore between header names. Probably the IIS issue. Revision ChangesPath 1.53 +29 -21jakarta-tomcat-connectors/jk/native/iis/jk_isapi_plugin.c Index: jk_isapi_plugin.c === RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/iis/jk_isapi_plugin.c,v retrieving revision 1.52 retrieving revision 1.53 diff -u -r1.52 -r1.53 --- jk_isapi_plugin.c 12 Sep 2005 14:10:51 - 1.52 +++ jk_isapi_plugin.c 14 Sep 2005 10:52:43 - 1.53 @@ -51,26 +51,25 @@ * 3. The contents of the Translate header, if any * */ -#define URI_HEADER_NAME_BASE (TOMCATURI) -#define QUERY_HEADER_NAME_BASE (TOMCATQUERY) -#define WORKER_HEADER_NAME_BASE (TOMCATWORKER) +#define URI_HEADER_NAME_BASE (TOMCATURI) +#define QUERY_HEADER_NAME_BASE(TOMCATQUERY) +#define WORKER_HEADER_NAME_BASE (TOMCATWORKER) #define TOMCAT_TRANSLATE_HEADER_NAME_BASE (TOMCATTRANSLATE) +#define CONTENT_LENGTH(CONTENT_LENGTH:) +/* The template used to construct our unique headers + * from the base name and module instance + */ +#define HEADER_TEMPLATE (%s%p:) +#define HTTP_HEADER_TEMPLATE (HTTP_%s%p) static char URI_HEADER_NAME[_MAX_FNAME]; static char QUERY_HEADER_NAME[_MAX_FNAME]; static char WORKER_HEADER_NAME[_MAX_FNAME]; static char TOMCAT_TRANSLATE_HEADER_NAME[_MAX_FNAME]; -/* The template used to construct our unique headers - * from the base name and module instance - */ -#define HEADER_TEMPLATE (%s_%p:) - -#define CONTENT_LENGTH (CONTENT_LENGTH) - -#define HTTP_URI_HEADER_NAME (HTTP_TOMCATURI) -#define HTTP_QUERY_HEADER_NAME (HTTP_TOMCATQUERY) -#define HTTP_WORKER_HEADER_NAME (HTTP_TOMCATWORKER) +static char HTTP_URI_HEADER_NAME[_MAX_FNAME]; +static char HTTP_QUERY_HEADER_NAME[_MAX_FNAME]; +static char HTTP_WORKER_HEADER_NAME[_MAX_FNAME]; #define REGISTRY_LOCATION (Software\\Apache Software Foundation\\Jakarta Isapi Redirector\\1.0) #define EXTENSION_URI_TAG (extension_uri) @@ -133,7 +132,7 @@ static int iis5 = -1; static jk_uri_worker_map_t *uw_map = NULL; -static jk_map_t *wp_map = NULL; /* worker_properties */ +static jk_map_t *workers_map = NULL; static jk_logger_t *logger = NULL; static char *SERVER_NAME = SERVER_NAME; static char *SERVER_SOFTWARE = SERVER_SOFTWARE; @@ -1071,9 +1070,9 @@ uri_worker_map_free(uw_map, logger); is_mapread = JK_FALSE; } -memset(worker_env, 0, sizeof(worker_env)); -if (wp_map) { -jk_map_free(wp_map); +if (workers_map) { +jk_map_free(workers_map); +workers_map = NULL; } wc_close(logger); if (logger) { @@ -,6 +1110,11 @@ sprintf(QUERY_HEADER_NAME, HEADER_TEMPLATE, QUERY_HEADER_NAME_BASE, hInst); sprintf(WORKER_HEADER_NAME, HEADER_TEMPLATE, WORKER_HEADER_NAME_BASE, hInst); sprintf(TOMCAT_TRANSLATE_HEADER_NAME, HEADER_TEMPLATE, TOMCAT_TRANSLATE_HEADER_NAME_BASE, hInst); + +sprintf(HTTP_URI_HEADER_NAME, HTTP_HEADER_TEMPLATE, URI_HEADER_NAME_BASE, hInst); +sprintf(HTTP_QUERY_HEADER_NAME, HTTP_HEADER_TEMPLATE, QUERY_HEADER_NAME_BASE, hInst); +sprintf(HTTP_WORKER_HEADER_NAME, HTTP_HEADER_TEMPLATE, WORKER_HEADER_NAME_BASE, hInst); + break; case DLL_PROCESS_DETACH: __try { @@ -1168,14 +1172,14 @@ } if (rc) { rc = JK_FALSE; -if (jk_map_alloc(wp_map)) { -if (jk_map_read_properties(wp_map, worker_file, NULL)) { +if (jk_map_alloc(workers_map)) { +if (jk_map_read_properties(workers_map, worker_file, NULL)) { /* we add the URI-WORKER MAP since workers using AJP14 will feed it */ worker_env.uri_to_worker = uw_map; worker_env.server_name = serverName; -if (wc_open(wp_map, worker_env, logger)) { +if (wc_open(workers_map, worker_env, logger)) { rc = JK_TRUE; } } @@ -1183,6 +1187,10 @@ jk_log(logger, JK_LOG_EMERG, Unable to read worker file %s., worker_file); } +if (rc != JK_TRUE) { +jk_map_free(workers_map); +workers_map = NULL; +} } } - To unsubscribe, e-mail: [EMAIL
Re: cvs commit: jakarta-tomcat-connectors/jk/xdocs changelog.xml
Tim Whittington wrote: I'm pretty sure this patch is broken looking at it now. The HTTP_ variants used in the extension aren't initialized properly. I'm currently on the road, but I'll be able to fix this up next week. I've just commit the fix for the previous fix :) Can you confirm if it's working for you? Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36655] New: - mod_jk 1.2.12+ does not submit correct request port number to tomcat
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36655. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36655 Summary: mod_jk 1.2.12+ does not submit correct request port number to tomcat Product: Tomcat 4 Version: 4.1.31 Platform: Other OS/Version: Solaris Status: NEW Severity: major Priority: P2 Component: Connector:JK/AJP AssignedTo: tomcat-dev@jakarta.apache.org ReportedBy: [EMAIL PROTECTED] In our infrastructure a https request is handled in this way: https request(port 443) - SSL-accelerator (Nortel/Alteon) - decrypted request port 50443 - Apache-2.0.53 listening on 80, 55443 using virtual hosts - mod_jk 1.2.12, AJP13 port 8200 - Tomcat 4.1.31 with application The application checks wether a request hit the Apache2 on port 55443 or 80. If the port was 80, a warning message is sent back to the client about unencrypted traffic. Now we got the warning message also with a request on port 55443. mod_jk logs in debug mode: [Fri Sep 09 11:28:20 2005] [22238:0006] [debug] init_ws_service::mod_jk.c (510): Service pro tocol=HTTP/1.1 method=GET host=(null) addrr=192.168.70.130 name=jportal1-riat-p.bap.fiducia. de port=80 auth=(null) user=(null) laddr=10.253.52.65 raddr=192.168.70.130 So there is a wrong port number sent to Tomcat/application. I have traced the problem down to jakarta-tomcat-connectors-1.2.12-src/jk/native/apache-2.0/mod_jk.c where I've found the following: /* get the real port (otherwise redirect failed) */ /* XXX: use apache API for getting server port * * Pre 1.2.7 versions used: * s-server_port = r-connection-local_addr-port; */ s-server_port = ap_get_server_port(r); So I uncommented the old code and commented the new line: /* get the real port (otherwise redirect failed) */ /* XXX: use apache API for getting server port * * Pre 1.2.7 versions used: */ s-server_port = r-connection-local_addr-port; /*s-server_port = ap_get_server_port(r); */ Now the mod_jk log says: [Fri Sep 09 13:15:10 2005] [22238:0006] [debug] init_ws_service::mod_jk.c (510): Service pro tocol=HTTP/1.1 method=GET host=(null) addrr=192.168.70.130 name=jportal1-riat-p.bap.fiducia. de port=55443 auth=(null) user=(null) laddr=10.253.52.65 raddr=192.168.70.130 The port is now sent correctly to Tomcat/application. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36655] - mod_jk 1.2.12+ does not submit correct request port number to tomcat
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36655. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36655 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2005-09-14 14:17 --- Hi, You should supply the port with ServerName. This is from ap_get_server_port: /* With UseCanonicalName on (and in all versions prior to 1.3) * Apache will use the hostname and port specified in the * ServerName directive to construct a canonical name for the * server. (If no port was specified in the ServerName * directive, Apache uses the port supplied by the client if * any is supplied, and finally the default port for the protocol * used. So, since probably nothing matched, the 80 (as default) was used. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session DeltaSession.java
pero2005/09/14 05:46:56 Modified:modules/cluster/src/share/org/apache/catalina/cluster/session DeltaSession.java Log: Fix mutli threading issue at session write attributes S. Bug: 36541 Revision ChangesPath 1.36 +12 -6 jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaSession.java Index: DeltaSession.java === RCS file: /home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaSession.java,v retrieving revision 1.35 retrieving revision 1.36 diff -u -r1.35 -r1.36 --- DeltaSession.java 26 Jun 2005 21:21:49 - 1.35 +++ DeltaSession.java 14 Sep 2005 12:46:56 - 1.36 @@ -1003,9 +1003,10 @@ .getString(standardSession.getAttributeNames.ise)); synchronized (attributes) { -return (new Enumerator(attributes.keySet(), true)); +// create a copy from orginal attribute keySet, otherwise internal HaspMap datastructure +// can be inconsistence by other threads. +return (new Enumerator(new ArrayList(attributes.keySet()), true)); } - } /** @@ -1253,8 +1254,10 @@ } // Replace or add this attribute -Object unbound = attributes.put(name, value); - +Object unbound = null ; +synchronized (attributes) { +unbound = attributes.put(name, value); +} // Call the valueUnbound() method if necessary if ((unbound != null) notify (unbound instanceof HttpSessionBindingListener)) { @@ -1577,7 +1580,10 @@ boolean addDeltaRequest) { // Remove this attribute from our collection -Object value = attributes.remove(name); +Object value = null; +synchronized (attributes) { +value = attributes.remove(name); +} if (value == null) return; - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36541] - session getAttribute/setAttribute and removeAttribute are NOT Thread safe.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36541. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36541 --- Additional Comments From [EMAIL PROTECTED] 2005-09-14 14:50 --- (In reply to comment #86) I have fix the unsync write session attribute operation at DeltaSession. Peter -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml
pero2005/09/14 06:25:22 Modified:webapps/docs changelog.xml Log: add: Sync all session attribute access (read and write) at DeltaSession Revision ChangesPath 1.372 +3 -0 jakarta-tomcat-catalina/webapps/docs/changelog.xml Index: changelog.xml === RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v retrieving revision 1.371 retrieving revision 1.372 diff -u -r1.371 -r1.372 --- changelog.xml 8 Sep 2005 15:41:11 - 1.371 +++ changelog.xml 14 Sep 2005 13:25:22 - 1.372 @@ -90,6 +90,9 @@ subsection name=Cluster changelog fix +bug36541/bug: Sync all session attribute access (read and write) at DeltaSession (pero) + /fix + fix bug36518/bug: Classname typos for senders, submitted by Christoph Bachhuber-Haller (remm) /fix /changelog - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/ant/jmx JMXAccessorCreateTask.java JMXAccessorUnregisterTask.java JMXAccessorQueryTask.java JMXAccessorSetTask.java JMXAccessorTask.java antlib.xml jmxaccessor.tasks
pero2005/09/14 06:28:29 Modified:catalina/src/share/org/apache/catalina/ant/jmx JMXAccessorQueryTask.java JMXAccessorSetTask.java JMXAccessorTask.java antlib.xml jmxaccessor.tasks Added: catalina/src/share/org/apache/catalina/ant/jmx JMXAccessorCreateTask.java JMXAccessorUnregisterTask.java Log: Add create remote Mbeans and unregister tasks fix some small typos! Revision ChangesPath 1.6 +2 -2 jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/ant/jmx/JMXAccessorQueryTask.java Index: JMXAccessorQueryTask.java === RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/ant/jmx/JMXAccessorQueryTask.java,v retrieving revision 1.5 retrieving revision 1.6 diff -u -r1.5 -r1.6 --- JMXAccessorQueryTask.java 27 Jul 2005 15:11:17 - 1.5 +++ JMXAccessorQueryTask.java 14 Sep 2005 13:28:29 - 1.6 @@ -106,7 +106,7 @@ * input stream will be closed upon completion of this task, whether it was * executed successfully or not. * - * @exception BuildException + * @exception Exception *if an error occurs */ public String jmxExecute(MBeanServerConnection jmxServerConnection) 1.5 +2 -2 jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/ant/jmx/JMXAccessorSetTask.java Index: JMXAccessorSetTask.java === RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/ant/jmx/JMXAccessorSetTask.java,v retrieving revision 1.4 retrieving revision 1.5 diff -u -r1.4 -r1.5 --- JMXAccessorSetTask.java 27 Jul 2005 15:11:17 - 1.4 +++ JMXAccessorSetTask.java 14 Sep 2005 13:28:29 - 1.5 @@ -152,7 +152,7 @@ * input stream will be closed upon completion of this task, whether it was * executed successfully or not. * - * @exception BuildException + * @exception Exception *if an error occurs */ public String jmxExecute(MBeanServerConnection jmxServerConnection) 1.13 +2 -2 jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/ant/jmx/JMXAccessorTask.java Index: JMXAccessorTask.java === RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/ant/jmx/JMXAccessorTask.java,v retrieving revision 1.12 retrieving revision 1.13 diff -u -r1.12 -r1.13 --- JMXAccessorTask.java 27 Jul 2005 15:11:18 - 1.12 +++ JMXAccessorTask.java 14 Sep 2005 13:28:29 - 1.13 @@ -491,7 +491,7 @@ * input stream will be closed upon completion of this task, whether it was * executed successfully or not. * - * @exception BuildException + * @exception Exception *if an error occurs */ public String jmxExecute(MBeanServerConnection jmxServerConnection) 1.3 +6 -0 jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/ant/jmx/antlib.xml Index: antlib.xml === RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/ant/jmx/antlib.xml,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- antlib.xml30 Jun 2005 13:01:27 - 1.2 +++ antlib.xml14 Sep 2005 13:28:29 - 1.3 @@ -16,6 +16,12 @@ name=query classname=org.apache.catalina.ant.jmx.JMXAccessorQueryTask / typedef +name=create +classname=org.apache.catalina.ant.jmx.JMXAccessorCreateTask / + typedef +name=unregister +classname=org.apache.catalina.ant.jmx.JMXAccessorUnregisterTask / + typedef name=equals classname=org.apache.catalina.ant.jmx.JMXAccessorEqualsCondition / typedef 1.3 +2 -0 jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/ant/jmx/jmxaccessor.tasks Index: jmxaccessor.tasks === RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/ant/jmx/jmxaccessor.tasks,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- jmxaccessor.tasks 30 Jun 2005 13:01:27 - 1.2 +++ jmxaccessor.tasks 14 Sep 2005 13:28:29 - 1.3 @@ -4,3 +4,5 @@ jmxGet=org.apache.catalina.ant.jmx.JMXAccessorGetTask jmxInvoke=org.apache.catalina.ant.jmx.JMXAccessorInvokeTask jmxQuery=org.apache.catalina.ant.jmx.JMXAccessorQueryTask
DO NOT REPLY [Bug 36656] New: - Code too large
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36656. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36656 Summary: Code too large Product: Tomcat 4 Version: 4.1.31 Platform: PC OS/Version: Windows XP Status: NEW Severity: critical Priority: P1 Component: Jasper 2 AssignedTo: tomcat-dev@jakarta.apache.org ReportedBy: [EMAIL PROTECTED] Hi, I´m brazilian and I don't speak english very well. But I´m having problem with a JSP compilation using tomcat 4.1.31. I´m using include:jsp and the error code too large in try continue. I see that in REALESE NOTES that in version 4.1.4 this problem has fixed. I wold like help urgent. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36541] - session getAttribute/setAttribute and removeAttribute are NOT Thread safe.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36541. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36541 --- Additional Comments From [EMAIL PROTECTED] 2005-09-14 16:10 --- (In reply to comment #87) (In reply to comment #86) I have fix the unsync write session attribute operation at DeltaSession. Peter There are other places that have this issue I noticed while going through the Tomcat code such as the StandardSession get/setNote methods which are not synchronized and are used throughout the code without being synchronized. They are used in the authenticators I know and I'm sure they are used in other places because of their nature. Should I file a separate bug for each, or is it enough to give a generic bug which states there are a lot of cases of unsynchronized HashMap in Tomcat so they can be tracked down? I would work on a patch for it as long as I'm not working on it at the same time as anyone else. Are all instances being looked at as a result of issue 36541? -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36541] - session getAttribute/setAttribute and removeAttribute are NOT Thread safe.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36541. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36541 --- Additional Comments From [EMAIL PROTECTED] 2005-09-14 16:45 --- I am sorry if I am too late to push (the issue is already fixed), but in case it's not I have something to say: 1)SRV 15.1.7 says nothing about HttpSession being not thread-safe. And AFAIR this means the interface should be thread-safe. 2)SRV 7.7.1 says about synchronizing access to session resources, but it says nothing about session object itself. If one thinks session itself was meant in it, he should agree that more exact method of synchronizing then as appropriate should be used in the specs: the Developer can choose any way it wishes to synchronize access to it's own resources but the method of synchronizing access to a object (HttpSession) that is used by different Developers (if such a synchronization is needed) MUST be defined. If you read session resources as session, this means anyone can choose any appropriate method of synchronization of session object, that is totally incorrect. As for me, this means that neither 7.7.1 nor any other point of specs does NOT say that session object is unsafe and this means that in any implementation it MUST be safe. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml monitoring.xml
pero2005/09/14 08:05:50 Modified:webapps/docs changelog.xml monitoring.xml Log: Add JMX Remote create and unregister ant tasks Revision ChangesPath 1.373 +3 -0 jakarta-tomcat-catalina/webapps/docs/changelog.xml Index: changelog.xml === RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v retrieving revision 1.372 retrieving revision 1.373 diff -u -r1.372 -r1.373 --- changelog.xml 14 Sep 2005 13:25:22 - 1.372 +++ changelog.xml 14 Sep 2005 15:05:49 - 1.373 @@ -40,6 +40,9 @@ subsection name=Catalina changelog + add +Add JMX Remote create and unregister ant tasks (pero) + /add fix bug36343/bug: Only normalize out backslash on Windows platforms. (billbarker) /fix 1.5 +126 -0jakarta-tomcat-catalina/webapps/docs/monitoring.xml Index: monitoring.xml === RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/monitoring.xml,v retrieving revision 1.4 retrieving revision 1.5 diff -u -r1.4 -r1.5 --- monitoring.xml21 Jul 2005 08:49:32 - 1.4 +++ monitoring.xml14 Sep 2005 15:05:49 - 1.5 @@ -762,6 +762,132 @@ /section +!-- Create # +-- + +section name=JMXAccessorCreateTask: remote create mbean ant task +p +List of Attributesbr/ +table border=1 cellpadding=5 + + tr +th align=center bgcolor=aquaAttribute/th +th align=center bgcolor=aquaDescription/th +th align=center bgcolor=aquaDefault value/th + /tr + + tr +tdname/td +tdFull qualified JMX ObjectName -- emCatalina:type=MBeanFactory/em +/td +td/td + /tr + + tr +tdclassName/td +tdExisting MBean full qualified classname (see Tomcat mbean description above) +/td +td/td + /tr + + tr +tdclassLoader/td +tdObjectName of server or web application classloader br/ +( emCatalina:type=ServerClassLoader,name=[server,common,shared]/em orbr/ + emCatalina:type=WebappClassLoader,path=/myapps,host=localhost/em) +/td +td/td + /tr + + tr +tdref/td +tdJMX Connection reference +/td +tdcodejmx.server/code/td + /tr + + tr +tdecho/td +tdEcho command usage (access and result) +/td +tdcodefalse/code/td + /tr + +/table +/p +p +Example to create remote mbeanbr/ +source +lt;jmx:create + ref=${jmx.reference} + name=Catalina:type=MBeanFactory + className=org.apache.commons.modeler.BaseModelMBean + classLoader=Catalina:type=ServerClassLoader,name=servergt; + lt;Arg value=org.apache.catalina.mbeans.MBeanFactory /gt; +lt;/jmx:creategt; +/source +/p +p +bWarning/b: A lot of tomcat mbeans can't be really create and connect with br/ +the parent. The valve, cluster or realm Mbeans are not autconnect with there parent.br/ +Use emMBeanFacrory/em create operation instead. +/p + +/section + +!-- Unregister # +-- + +section name=JMXAccessorUnregisterTask: remote unregister mbean ant task +p +List of Attributesbr/ +table border=1 cellpadding=5 + + tr +th align=center bgcolor=aquaAttribute/th +th align=center bgcolor=aquaDescription/th +th align=center bgcolor=aquaDefault value/th + /tr + + tr +tdname/td +tdFull qualified JMX ObjectName -- emCatalina:type=MBeanFactory/em +/td +td/td + /tr + + tr +tdref/td +tdJMX Connection reference +/td +tdcodejmx.server/code/td + /tr + + tr +tdecho/td +tdEcho command usage (access and result) +/td +tdcodefalse/code/td + /tr + +/table +/p +p +Example to unregister remote mbeanbr/ +source +lt;jmx:unregister +name=Catalina:type=MBeanFactory +/gt; +/source +/p +p +bWarning/b: A lot of tomcat mbeans can't be really unregister. br/ +The Mbeans are not deregister from parent. Use emMBeanFacrory/em br/ +remove operation instead. +/p + +/section + !-- condition # -- - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session DeltaSession.java
pero2005/09/14 08:28:14 Modified:modules/cluster/src/share/org/apache/catalina/cluster/session DeltaSession.java Log: fix: attribute and notes sync at DeltaSession,recycle() Revision ChangesPath 1.37 +7 -3 jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaSession.java Index: DeltaSession.java === RCS file: /home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaSession.java,v retrieving revision 1.36 retrieving revision 1.37 diff -u -r1.36 -r1.37 --- DeltaSession.java 14 Sep 2005 12:46:56 - 1.36 +++ DeltaSession.java 14 Sep 2005 15:28:13 - 1.37 @@ -789,7 +789,9 @@ public void recycle() { // Reset the instance variables associated with this Session -attributes.clear(); +synchronized (attributes) { +attributes.clear(); +} setAuthType(null); creationTime = 0L; expiring = false; @@ -797,7 +799,9 @@ lastAccessedTime = 0L; maxInactiveInterval = -1; accessCount = 0; -notes.clear(); +synchronized (notes) { +notes.clear(); +} setPrincipal(null); isNew = false; isValid = false; - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r280906 - in /tomcat/site/trunk: docs/ docs/faq/ xdocs/
Author: markt Date: Wed Sep 14 11:48:16 2005 New Revision: 280906 URL: http://svn.apache.org/viewcvs?rev=280906view=rev Log: Fill in more blanks. Update docs with correct menu. Modified: tomcat/site/trunk/docs/contact.html tomcat/site/trunk/docs/download-33.html tomcat/site/trunk/docs/download-41.html tomcat/site/trunk/docs/download-55.html tomcat/site/trunk/docs/download-connectors.html tomcat/site/trunk/docs/faq/classnotfound.html tomcat/site/trunk/docs/findhelp.html tomcat/site/trunk/docs/getinvolved.html tomcat/site/trunk/docs/heritage.html tomcat/site/trunk/docs/index.html tomcat/site/trunk/docs/irc.html tomcat/site/trunk/docs/legal.html tomcat/site/trunk/docs/lists.html tomcat/site/trunk/docs/resources.html tomcat/site/trunk/docs/svn.html tomcat/site/trunk/docs/whichversion.html tomcat/site/trunk/docs/whoweare.html tomcat/site/trunk/xdocs/contact.xml tomcat/site/trunk/xdocs/getinvolved.xml tomcat/site/trunk/xdocs/lists.xml tomcat/site/trunk/xdocs/svn.xml tomcat/site/trunk/xdocs/whoweare.xml Modified: tomcat/site/trunk/docs/contact.html URL: http://svn.apache.org/viewcvs/tomcat/site/trunk/docs/contact.html?rev=280906r1=280905r2=280906view=diff == --- tomcat/site/trunk/docs/contact.html (original) +++ tomcat/site/trunk/docs/contact.html Wed Sep 14 11:48:16 2005 @@ -76,7 +76,7 @@ a href=./faq/FAQ/a /li li -a href=./mail.htmlMailing Lists/a +a href=./lists.html#tomcat-userMailing Lists/a /li li a href=./bugreport.htmlBug Database/a @@ -107,7 +107,7 @@ a href=./getinvolved.htmlOverview/a /li li -a href=./svnindex.htmlSVN Repositories/a +a href=./svn.htmlSVN Repositories/a /li li a href=./lists.htmlMailing Lists/a @@ -143,8 +143,8 @@ tr td bgcolor=#525D76 font face=arial,helvetica,sanserif color=#ff -a name=TODO -strongTODO/strong +a name=Product Support +strongProduct Support/strong /a /font /td @@ -153,10 +153,97 @@ td p blockquote -pCopy and paste from Jakarta/p -pPoint to mailing lists/p -pSecurity issues/p -ppoint to Apache contact details/p + +p +If you have questions or comments about the software or documentation on this site, +please subscribe to the appropriate mailing list: +/p + +p +a href=./lists.htmlMailing lists/a +/p + +/blockquote +/p +/td +/tr +tr +td +br / +/td +/tr +/table +table width=100% cellpadding=2 cellspacing=0 border=0 +tr +td bgcolor=#525D76 +font face=arial,helvetica,sanserif color=#ff +a name=Security Issues +strongSecurity Issues/strong +/a +/font +/td +/tr +tr +td +p +blockquote + +p +If you would like to report a security issues with Apache Tomcat, +you may contact: +/p + +p +a href=mailto:security.AT.apache.DOT.org;security.AT.apache.DOT.org/a +/p + +/blockquote +/p +/td +/tr +tr +td +br / +/td +/tr +/table +table width=100% cellpadding=2 cellspacing=0 border=0 +tr +td bgcolor=#525D76 +font face=arial,helvetica,sanserif color=#ff +a name=The Apache Software Foundation +strongThe Apache Software Foundation/strong +/a +/font +/td +/tr +tr +td +p +blockquote + +p +The Tomcat Project is an effort of the +a href=http://apache.org/foundation/;Apache Software Foundation/a. The +address for general ASF correspondence and licensing questions is: +/p + +p +a href=mailto:apache.AT.apache.DOT.org;apache.AT.apache.DOT.org/a +/p + +p +You can find more contact information for the Apache Software Foundation +on the a href=http://www.apache.org/foundation/contact.html;contact +page of the main Apache site/a. +/p + +p +You may also use +a href=http://search.apache.org/;Apache Site Search/a to scan all the +Apache sites at once. +/p + /blockquote /p /td Modified: tomcat/site/trunk/docs/download-33.html URL: http://svn.apache.org/viewcvs/tomcat/site/trunk/docs/download-33.html?rev=280906r1=280905r2=280906view=diff == --- tomcat/site/trunk/docs/download-33.html (original) +++ tomcat/site/trunk/docs/download-33.html Wed Sep 14 11:48:16 2005 @@ -76,7 +76,7 @@ a href=./faq/FAQ/a /li li -a href=./mail.htmlMailing Lists/a +a href=./lists.html#tomcat-userMailing Lists/a /li li a href=./bugreport.htmlBug Database/a @@ -107,7 +107,7 @@ a href=./getinvolved.htmlOverview/a /li li -a href=./svnindex.htmlSVN Repositories/a +a href=./svn.htmlSVN Repositories/a /li li a href=./lists.htmlMailing Lists/a Modified: tomcat/site/trunk/docs/download-41.html URL: http://svn.apache.org/viewcvs/tomcat/site/trunk/docs/download-41.html?rev=280906r1=280905r2=280906view=diff == --- tomcat/site/trunk/docs/download-41.html (original) +++ tomcat/site/trunk/docs/download-41.html Wed Sep 14 11:48:16 2005 @@ -76,7 +76,7 @@ a href=./faq/FAQ/a /li li -a href=./mail.htmlMailing Lists/a +a href=./lists.html#tomcat-userMailing Lists/a /li li a
Re: svn commit: r280906 - in /tomcat/site/trunk: docs/ docs/faq/ xdocs/
The basic content for the TLP site is now done and can be reviewed at http://people.apache.org/~markt/tomcattlp/index.html Whilst I want to tidy it up (remove duplication, fix typos, etc) and someone who knows more about our history than me needs to write something for the heritage page, I don't see why we could not go live with this. I think the remaining steps to move to TLP are: 1. SVN a) Migrate TC3 TC4 - In progress as I type b) Migrate TC5, Connectors and Jasper - will start once a) is done 2. Website a) Need tomcat.apache.org created b) Load content from SVN (trivial) 3. Lists a) [EMAIL PROTECTED] - [EMAIL PROTECTED] b) [EMAIL PROTECTED]- [EMAIL PROTECTED] c) [EMAIL PROTECTED] - [EMAIL PROTECTED] d) Create [EMAIL PROTECTED] (posts from pmc only) 4. Gump a) Change to use SVN 5. Downloads/Archives a) Move from Jakarta to Tomcat 6. Wiki a) Do we want a Tomcat wiki? What have I missed? Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r280906 - in /tomcat/site/trunk: docs/ docs/faq/ xdocs/
- Original Message - From: Mark Thomas [EMAIL PROTECTED] To: Tomcat Developers List tomcat-dev@jakarta.apache.org Sent: Wednesday, September 14, 2005 12:05 PM Subject: Re: svn commit: r280906 - in /tomcat/site/trunk: docs/ docs/faq/ xdocs/ The basic content for the TLP site is now done and can be reviewed at http://people.apache.org/~markt/tomcattlp/index.html Whilst I want to tidy it up (remove duplication, fix typos, etc) and someone who knows more about our history than me needs to write something for the heritage page, I don't see why we could not go live with this. I think the remaining steps to move to TLP are: 1. SVN a) Migrate TC3 TC4 - In progress as I type b) Migrate TC5, Connectors and Jasper - will start once a) is done 2. Website a) Need tomcat.apache.org created It's been there for a while now :). b) Load content from SVN (trivial) 3. Lists a) [EMAIL PROTECTED] - [EMAIL PROTECTED] b) [EMAIL PROTECTED]- [EMAIL PROTECTED] c) [EMAIL PROTECTED] - [EMAIL PROTECTED] d) Create [EMAIL PROTECTED] (posts from pmc only) 4. Gump a) Change to use SVN Already done for servletapi/*. (e.g. http://vmgump.apache.org/gump/public/jakarta-servletapi-5/gump_work/update_j akarta-servletapi-5.html). Just waiting on the SVN URLs for the rest. 5. Downloads/Archives a) Move from Jakarta to Tomcat 6. Wiki a) Do we want a Tomcat wiki? What have I missed? Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments. In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r280906 - in /tomcat/site/trunk: docs/ docs/faq/ xdocs/
Bill Barker wrote: 2. Website a) Need tomcat.apache.org created It's been there for a while now :). Thanks - hadn't noticed that. 4. Gump a) Change to use SVN Already done for servletapi/*. (e.g. http://vmgump.apache.org/gump/public/jakarta-servletapi-5/gump_work/update_j akarta-servletapi-5.html). Just waiting on the SVN URLs for the rest. Great. Thanks for doing this (I assume you did it). Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[PATCH] immediately observe JMX-driven host alias changes
Heya, I was surprised to discover that the Host object exposed via JMX allows for addAlias/removeAlias operations but that these changes were never communicated to the Mapper. As such, they weren't immediately effective and were only really of use with the Admin application, which can be used to write the new aliases of the host back to server.xml, effective on restart. This patch communicates JMX-driven host alias changes to the mapper so that the alias is immediately available for use without any need for a restart, much like JMX-driven host removals/additions already work. The approach I've taken is to have the StandardHostMBean fire JMX AttributeChangeNotifications after an add/removeAlias operation. I changed MapperListener to observe these notifications and then reflect the change in the the Mapper instance it serves (this required a little more smarts in Mapper). I had to change catalina/core/mbeans-descriptor.xml to reinstate StandardHostMBean as the MBean to be used for StandardHost - I couldn't see where StandardHostMBean was actually being used before.. any reason? I took this approach because MapperListener was already JMX-based; I guess one could choose to do something based more on internal events, but I hope this suffices. The patch follows my signature. Let me know if I've missed something or this solution is unsatisfactory. Hope it works! Thanks, Luke Index: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector/MapperListener.java === RCS file: /home/cvspublic/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector/MapperListener.java,v retrieving revision 1.2 diff -u -r1.2 MapperListener.java --- jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector/MapperListener.java 29 Jan 2005 19:42:27 - 1.2 +++ jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector/MapperListener.java 14 Sep 2005 18:03:31 - @@ -24,6 +24,9 @@ import javax.management.NotificationListener; import javax.management.ObjectInstance; import javax.management.ObjectName; +import javax.management.AttributeChangeNotificationFilter; +import javax.management.AttributeChangeNotification; +import javax.management.ListenerNotFoundException; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; @@ -69,6 +72,13 @@ private String domain=*; private String engine=*; +/** + * The filter for host alias attribute change notifications + */ +private AttributeChangeNotificationFilter hostAliasAttributeNotificationFilter = +new AttributeChangeNotificationFilter(); + + // --- Constructors @@ -77,6 +87,8 @@ */ public MapperListener(Mapper mapper) { this.mapper = mapper; +hostAliasAttributeNotificationFilter.disableAllAttributes(); +hostAliasAttributeNotificationFilter.enableAttribute(aliases); } @@ -159,6 +171,21 @@ ObjectName objectName = new ObjectName( JMImplementation:type=MBeanServerDelegate); mBeanServer.removeNotificationListener(objectName, this); + +// remove listeners from all host objects +Set hostMBeans = mBeanServer.queryMBeans(new ObjectName(domain + :type=Host,*), null); +Iterator hostMBeanIt = hostMBeans.iterator(); +while (hostMBeanIt.hasNext()) +{ +final ObjectInstance hostMBean = (ObjectInstance)hostMBeanIt.next(); +try +{ + mBeanServer.removeNotificationListener(hostMBean.getObjectName(), this); +} catch (Exception e) { +log.warn(Error unregistering host listener, e); +} +} + } catch (Exception e) { log.warn(Error unregistering MBeanServerDelegate, e); } @@ -245,6 +272,25 @@ } } } + +} else if (notification instanceof AttributeChangeNotification) { + +final AttributeChangeNotification attrChangeNotification = (AttributeChangeNotification)notification; + +if (aliases.equals(attrChangeNotification.getAttributeName())) +{ +final ObjectName hostName = (ObjectName) attrChangeNotification.getSource(); +try +{ +reconfigureAliases( +hostName, +(String[])attrChangeNotification.getNewValue()); +} +catch (Throwable t) +{ +log.warn(Error updating aliases for + hostName, t); +} +} } } @@ -252,6 +298,12 @@ // -- Protected Methods +
svn commit: r280951 - in /tomcat/site/trunk: docs/whoweare.html xdocs/whoweare.xml
Author: markt Date: Wed Sep 14 14:57:51 2005 New Revision: 280951 URL: http://svn.apache.org/viewcvs?rev=280951view=rev Log: Add the dormat committers as emeritus. Please review this list and correct as necessary. Modified: tomcat/site/trunk/docs/whoweare.html tomcat/site/trunk/xdocs/whoweare.xml Modified: tomcat/site/trunk/docs/whoweare.html URL: http://svn.apache.org/viewcvs/tomcat/site/trunk/docs/whoweare.html?rev=280951r1=280950r2=280951view=diff == --- tomcat/site/trunk/docs/whoweare.html (original) +++ tomcat/site/trunk/docs/whoweare.html Wed Sep 14 14:57:51 2005 @@ -320,6 +320,90 @@ /td /tr /table +table width=100% cellpadding=2 cellspacing=0 border=0 +tr +td bgcolor=#525D76 +font face=arial,helvetica,sanserif color=#ff +a name=Emeritus Committers +strongEmeritus Committers/strong +/a +/font +/td +/tr +tr +td +p +blockquote + +p +a href=http://www.apache.org/foundation/glossary.html#Emeritus; +Emeritus/a is defined in the Apache glossary./p + +p +bJames Duncan Davidson/b (duncan at apache.org), +bJon Scott Stevens/b (jon at apache.org), +bSam Ruby/b (rubys at apache.org), +bAnil Vijendran/b (akv at apache.org), +bJason Hunter/b (jhunter at apache.org), +bPreston Bannister/b (preston at apache.org), +bDaniel Ferrin/b (shemnon at apache.org), +bGal Shachor/b (shachor at apache.org), +bHans Bergsten/b (bergsten at apache.org), +bJames Todd/b (gonzo at apache.org), +bRain Mordani/b (mode at apache.org), +bHans Granqvist/b (har at apache.org), +bIan P. Springer/b (ishp at apache.org), +bArun Jamwal/b (arun at apache.org), +bCraig R. McClanahan/b (craigmcc at apache.org), +bJean-Luc Rochat/b (jluc at apache.org), +bIgnacio J. Ortega/b (nacho at apache.org), +bAndy Riedel/b (ariedel at apache.org), +bJustyna Horwat/b (horwat at apache.org), +bEd Korthof/b (ed at apache.org), +bAlex Chaffee/b (alex at apache.org), +bVasile Gaburici/b (gaburici at apache.org), +bPetr Jiricka/b (jiricka at apache.org), +bPierre Delisle/b (pierred at apache.org), +bDavid Lawrence Isaacs/b (larryi at apache.org), +bArieh Markel/b (arieh at apache.org), +bMarc Saegesse/b (marcsaeg at apache.org), +bDan Milstein/b (danmil at apache.org), +bShai Fultheim/b (shai at apache.org), +bKief Morris/b (kief at apache.org), +bMel Martinez/b (melaquias at apache.org), +bMike Braden/b (mbraden at apache.org), +bCasey Lucas/b (clucas at apache.org), +bBip Thelin/b (bip at apache.org), +bKevin Seguin/b (seguin at apache.org), +bMichiel M. Anderson/b (mmanders at apache.org), +bAndy Armstrong/b (andya at apache.org), +bChristopher Cain/b (ccain at apache.org), +bBojan Smojver/b (bojan at apache.org), +bPatrick H. Luby/b (patrickl at apache.org), +bJazmin Jonson/b (jazmin at apache.org), +bEric Rescorla/b (ekr at apache.org), +bManveen Kaur/b (manveen at apache.org), +bChristopher K. St. John/b (cks at apache.org), +bDenis Benoit/b (denisb at apache.org), +bDan Sandberg/b (dsandberg at apache.org), +bBob Herrmann/b (bobh at apache.org), +bJohn Turner/b (johnturner at apache.org), +bKeith Eric Carmichael/b (ecarmich at apache.org), +bGuenter Knauf/b (fuankg at apache.org), +bJean-Jacques Clar/b (clar at apache.org), +bWilliam A. Rowe Jr./b (wrowe at apache.org) +/p + +/blockquote +/p +/td +/tr +tr +td +br / +/td +/tr +/table /td /tr !--FOOTER SEPARATOR-- Modified: tomcat/site/trunk/xdocs/whoweare.xml URL: http://svn.apache.org/viewcvs/tomcat/site/trunk/xdocs/whoweare.xml?rev=280951r1=280950r2=280951view=diff == --- tomcat/site/trunk/xdocs/whoweare.xml (original) +++ tomcat/site/trunk/xdocs/whoweare.xml Wed Sep 14 14:57:51 2005 @@ -39,8 +39,6 @@ /section -hgomez,fhanik,jim,luehe,truk,glenn,amyroh,pero,markt,mturk,keith,costin,yoavs - section name=Project Management Committee h3PMC Chair/h3 @@ -105,6 +103,69 @@ pbKeith Wannamaker/b (keith at apache.org)br//p !--Your bio goes here-- + +/section + + +section name=Emeritus Committers + +pa href=http://www.apache.org/foundation/glossary.html#Emeritus; +Emeritus/a is defined in the Apache glossary./p + +p +bJames Duncan Davidson/b (duncan at apache.org), +bJon Scott Stevens/b (jon at apache.org), +bSam Ruby/b (rubys at apache.org), +bAnil Vijendran/b (akv at apache.org), +bJason Hunter/b (jhunter at apache.org), +bPreston Bannister/b (preston at apache.org), +bDaniel Ferrin/b (shemnon at apache.org), +bGal Shachor/b (shachor at apache.org), +bHans Bergsten/b (bergsten at apache.org), +bJames Todd/b (gonzo at apache.org), +bRain Mordani/b (mode at apache.org), +bHans Granqvist/b (har at apache.org), +bIan P. Springer/b (ishp at apache.org), +bArun Jamwal/b (arun at apache.org), +bCraig R. McClanahan/b (craigmcc at apache.org), +bJean-Luc Rochat/b (jluc at apache.org), +bIgnacio J. Ortega/b (nacho at apache.org), +bAndy Riedel/b (ariedel at apache.org), +bJustyna Horwat/b (horwat at apache.org), +bEd Korthof/b (ed at
DO NOT REPLY [Bug 36662] New: - Manager does not load as /manager, only as /manager/html
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36662. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36662 Summary: Manager does not load as /manager, only as /manager/html Product: Tomcat 5 Version: 5.5.11 Platform: PC OS/Version: Linux Status: NEW Severity: minor Priority: P1 Component: Webapps:Manager AssignedTo: tomcat-dev@jakarta.apache.org ReportedBy: [EMAIL PROTECTED] Fresh install of 5.5.11 (or 5.5.9) under Linux (Debian/testing, in case of 5.5.9) or Windows XP (5.5.11). Navigate to /manager and you only get a directory listing (I heard you are supposed to get the simple manager?). /manager/html correctly invokes the html manager. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Why / 1000 * 1000
Hi, While reading the Tomcat's source code, I noticed the following line in the service method of the HttpServlet class: if (ifModifiedSince (lastModified / 1000 * 1000)) What's the point of / 1000 * 1000? To drop off some precision? Thanks, Yaakov. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Why / 1000 * 1000
HTTP headers only send times to the second, so yes, to drop off some precision. - Original Message - From: Yaakov Chaikin [EMAIL PROTECTED] To: tomcat-dev@jakarta.apache.org Sent: Wednesday, September 14, 2005 8:37 PM Subject: Why / 1000 * 1000 Hi, While reading the Tomcat's source code, I noticed the following line in the service method of the HttpServlet class: if (ifModifiedSince (lastModified / 1000 * 1000)) What's the point of / 1000 * 1000? To drop off some precision? Thanks, Yaakov. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments. In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Why / 1000 * 1000
I'm assuming ifModifiedSince is already a multiple of 1000 (these are times in msec). In that case, the following comparison would do the same thing: if (ifModifiedSince (lastModified - 999)) or if (ifModifiedSince = (lastModified - 1000)) But I suppose that /1000*1000 might be considered more intuitive. Okay, I admit that's not exactly intuitive either. But they're both better than the suggestion in bug 33933 (no offense intended). http://issues.apache.org/bugzilla/show_bug.cgi?id=33933 Maybe a comment in the code would have prevented this whole thread altogether. ;-) ~Tom On Sep 14, 2005, at 10:41 PM, Bill Barker wrote: HTTP headers only send times to the second, so yes, to drop off some precision. - Original Message - From: Yaakov Chaikin [EMAIL PROTECTED] To: tomcat-dev@jakarta.apache.org Sent: Wednesday, September 14, 2005 8:37 PM Subject: Why / 1000 * 1000 Hi, While reading the Tomcat's source code, I noticed the following line in the service method of the HttpServlet class: if (ifModifiedSince (lastModified / 1000 * 1000)) What's the point of / 1000 * 1000? To drop off some precision? Thanks, Yaakov. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments. In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: How strongly Tomcat 5.5.x will be committed to JDK 1.4.x in future..
The current servlet spec doesn't requires J2SE 5.0 - only the next one ( another stupid forced, unjustified transition IMO ). I would assume JDK1.4 will be supported for a while, as long as the current version of the servlet spec is in use. Tomcat3.3, which supports JDK1.1, has been maintained for quite a while after switching to JDK1.3 and then JDK1.4. I don't see how anyone who has been around for past upgrades could expect a mass migration to the new servlet spec and JDK1.5. Costin Yoav Shapira wrote: Hi, Tomcat 5.5 will always allow JDK 1.4. Tomcat 6.0, as required by the J2EE 5 specifications, will require J2SE 5.0. I repeat, for emphasis, that this is required by the J2EE 5 Specification itself, which Tomcat 6.0 will support: it is not our decision to drop support for JDK 1.4. Yoav --- Girish Vasvani [EMAIL PROTECTED] wrote: Hi, We'r puzzled between tomcat 5.0.x and 5.5.x. Due to our product restrictions we can't use JDK 1.5. Looked at jakarta web site, it seems that using tomcat 5.5.x seriese compated to 5.0.x is a good idea and recommended. Before committing our product to tomcat 5.5.9, I want to know how much tomcat dev team will be committed to supporting JDK 1.4.x going forward ? thanks in advance for your help, Girish - Yahoo! for Good Click here to donate to the Hurricane Katrina relief effort. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]