Re: [4.1.9] New test milestone released

2002-08-13 Thread Remy Maucherat

Glenn Nielsen wrote:
 [EMAIL PROTECTED] wrote:
 
 On Mon, 12 Aug 2002, Glenn Nielsen wrote:


 JASPER 2 JSP Page Comiles
 -

 I would also like to see Jasper 2 changed so that JSP page compiles 
 occur
 externally outside of the Tomcat4 JVM process.  There are two reasons 
 for
 this:



 What's wrong with that ? It works just fine, just set 'build.compiler' 
 system property ( I think you can do it in web.xml as well ).

 
 I never noticed that in the Ant docs.  Thanks.
 
 It would be nice if there were some docs with Tomcat 4 about
 Jasper.  All there is now are the Jasper API Javadocs.

Yes, indeed :)

Remy


--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




RE: [4.1.9] New test milestone released

2002-08-12 Thread David Shanahan


There is a bug in 4.1.9 (a Jasper bug) that breaks my
application completely.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11552

We use custom tags that do iteration (they implement IterationTag)
but do not modify their content so they do not implement BodyTag.

The latest versions of Jasper2 generates code which only synchronizes
script variables before the first iteration of the tag. (ie before the do {}
while() loop).

There is also another bug whereby if a BodyTag returns EVAL_BODY_INCLUDE,
the script variables will not be synchronized at ALL for the first
iteration.

The problem is in org.apache.jasper.Generator.java. The generated code
for a tag that implements IterationTag synchronizes variables before the tag
loop but not inside it (even for NESTED scoped variables). 

Also for BodyTags that return EVAL_BODY_INCLUDE, the synchronization 
for the first iteration is skipped completely because it gets placed
together
in the same block of code that sets up the BodyContent buffer and that gets
skipped on EVAL_BODY_INCLUDE.

I have submitted some patches that move the variable synchronization into
the body of the loop for IterationTags and BodyTags. I think this should fix
the 
problem but I haven't got round to setting up a build environment yet.
(sorry). 
Doing that now.

If someone could take a look at this it would be much appreciated.
Thanks.


 -Original Message-
 From: Remy Maucherat [mailto:[EMAIL PROTECTED]]
 Sent: Sunday, August 11, 2002 1:21 AM
 To: Tomcat Developers List; Tomcat Users List
 Subject: [4.1.9] New test milestone released
 
 
 A new test milestone of Tomcat 4.1 has just been released.
 
 Downloads:
 http://jakarta.apache.org/builds/jakarta-tomcat-4.0/test/v4.1.9/
 
 Significant changes over 4.1.8 Beta include:
 - Jasper 2 bugfixes
 - Catalina classloader bugfixes
 - Coyote HTTP/1.1 fixes
 - Updated commons-dbcp connection pool
 
 The list of changes is available in the release notes.
 
 Remy
 
 
 --
 To unsubscribe, e-mail:   
 mailto:[EMAIL PROTECTED]
 For additional commands, e-mail: 
 mailto:[EMAIL PROTECTED]
 

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Re: [4.1.9] New test milestone released

2002-08-12 Thread Glenn Nielsen

Because I need features in Tomcat 4.1.x I have been putting each new version into
production.  There are 2 instances running 4.1.9 with Jasper 2, and one instance
running 4.1.8 with Jasper 1.

This last instance gets heavy use, 2-3 million tomcat JSP/Servlet requests per month.
With spikes 4 times a week of 10-20k requests per hour.  This also uses DBCP very
heavily.

Tracking Tomcat 4.1.x releases but using Jasper 1 (customer isn't ready to switch yet)
I haven't been able to get much better than 7-10 days runtime before Tomcat fails or 
Tomcat
requires a restart due to a memory leak.  Several months ago I had a run of 4 weeks w/o
a failure and w/o a memory leak.

MEMORY LEAK
---

I have a sneaking suspicion there is a small memory leak in Tomcat 4.1.x.
This appears to have been introduced sometime in the last couple of months.
This is not due to javac  JSP page compiles because jikes is being used as
an external page compiler.

When I get some time I may try setting up a test server with the customers app
and use optimizeit to try and track down the memory leak.

JASPER 2 JSP Page Comiles
-

I would also like to see Jasper 2 changed so that JSP page compiles occur
externally outside of the Tomcat4 JVM process.  There are two reasons for
this:

1.  The known memory leak with javac.

2.  Removing the extra stress to the Tomcat 4 JVM instance due to javac object
 creation and GC of those objects.

Moving JSP page compiles outside of the Tomcat JVM will improve performance
and reliability.

Regards,

Glenn

[EMAIL PROTECTED] wrote:
 Remy, 
 
 Let's try to make 4.1.10 the 'stable' release ( and consider 4.1.9 as
 the 'release candidate ). I cleaned up some of the jk messages and
 I want to do some more watchdog tests with apache/jk.
 
 If everyone agree, I think we should also tag jk2 as 'jk2.0beta' and
 jk1.2.0 release, even if we don't distribute a standalone package.
 
 
 Costin
 
 
 On Sat, 10 Aug 2002, Remy Maucherat wrote:
 
 
A new test milestone of Tomcat 4.1 has just been released.

Downloads:
http://jakarta.apache.org/builds/jakarta-tomcat-4.0/test/v4.1.9/

Significant changes over 4.1.8 Beta include:
- Jasper 2 bugfixes
- Catalina classloader bugfixes
- Coyote HTTP/1.1 fixes
- Updated commons-dbcp connection pool

The list of changes is available in the release notes.

Remy


--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]


 
 
 --
 To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
 For additional commands, e-mail: mailto:[EMAIL PROTECTED]




--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Re: [4.1.9] New test milestone released

2002-08-12 Thread Kin-Man Chung

There is also this feature/bug in jasper2 regarding the scope of
scripting variables that costin had objected to.  The clarifications
from JSP spec lead inidcates that costin was right.  We should have a
fix this week and that should go into 4.1.10.

  - Kin-man

 Date: Sat, 10 Aug 2002 09:54:02 -0700 (PDT)
 From: [EMAIL PROTECTED]
 Subject: Re: [4.1.9] New test milestone released
 X-X-Sender: [EMAIL PROTECTED]
 To: Tomcat Developers List [EMAIL PROTECTED]
 X-Authentication-warning: costinm.sfo.covalent.net: costin owned process doing 
-bs
 
 Remy, 
 
 Let's try to make 4.1.10 the 'stable' release ( and consider 4.1.9 as
 the 'release candidate ). I cleaned up some of the jk messages and
 I want to do some more watchdog tests with apache/jk.
 
 If everyone agree, I think we should also tag jk2 as 'jk2.0beta' and
 jk1.2.0 release, even if we don't distribute a standalone package.
 
 
 Costin
 
 
 On Sat, 10 Aug 2002, Remy Maucherat wrote:
 
  A new test milestone of Tomcat 4.1 has just been released.
  
  Downloads:
  http://jakarta.apache.org/builds/jakarta-tomcat-4.0/test/v4.1.9/
  
  Significant changes over 4.1.8 Beta include:
  - Jasper 2 bugfixes
  - Catalina classloader bugfixes
  - Coyote HTTP/1.1 fixes
  - Updated commons-dbcp connection pool
  
  The list of changes is available in the release notes.
  
  Remy
  
  
  --
  To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
  For additional commands, e-mail: mailto:[EMAIL PROTECTED]
  
  
 
 
 --
 To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
 For additional commands, e-mail: mailto:[EMAIL PROTECTED]
 


--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Re: [4.1.9] New test milestone released

2002-08-12 Thread costinm

On Mon, 12 Aug 2002, Glenn Nielsen wrote:

 JASPER 2 JSP Page Comiles
 -
 
 I would also like to see Jasper 2 changed so that JSP page compiles occur
 externally outside of the Tomcat4 JVM process.  There are two reasons for
 this:

What's wrong with that ? It works just fine, just set 'build.compiler' 
system property ( I think you can do it in web.xml as well ).


Costin

 
 1.  The known memory leak with javac.
 
 2.  Removing the extra stress to the Tomcat 4 JVM instance due to javac object
  creation and GC of those objects.
 
 Moving JSP page compiles outside of the Tomcat JVM will improve performance
 and reliability.
 
 Regards,
 
 Glenn
 
 [EMAIL PROTECTED] wrote:
  Remy, 
  
  Let's try to make 4.1.10 the 'stable' release ( and consider 4.1.9 as
  the 'release candidate ). I cleaned up some of the jk messages and
  I want to do some more watchdog tests with apache/jk.
  
  If everyone agree, I think we should also tag jk2 as 'jk2.0beta' and
  jk1.2.0 release, even if we don't distribute a standalone package.
  
  
  Costin
  
  
  On Sat, 10 Aug 2002, Remy Maucherat wrote:
  
  
 A new test milestone of Tomcat 4.1 has just been released.
 
 Downloads:
 http://jakarta.apache.org/builds/jakarta-tomcat-4.0/test/v4.1.9/
 
 Significant changes over 4.1.8 Beta include:
 - Jasper 2 bugfixes
 - Catalina classloader bugfixes
 - Coyote HTTP/1.1 fixes
 - Updated commons-dbcp connection pool
 
 The list of changes is available in the release notes.
 
 Remy
 
 
 --
 To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
 For additional commands, e-mail: mailto:[EMAIL PROTECTED]
 
 
  
  
  --
  To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
  For additional commands, e-mail: mailto:[EMAIL PROTECTED]
 
 
 
 
 --
 To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
 For additional commands, e-mail: mailto:[EMAIL PROTECTED]
 
 


--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Re: [4.1.9] New test milestone released

2002-08-12 Thread Glenn Nielsen

[EMAIL PROTECTED] wrote:
 On Mon, 12 Aug 2002, Glenn Nielsen wrote:
 
 
JASPER 2 JSP Page Comiles
-

I would also like to see Jasper 2 changed so that JSP page compiles occur
externally outside of the Tomcat4 JVM process.  There are two reasons for
this:
 
 
 What's wrong with that ? It works just fine, just set 'build.compiler' 
 system property ( I think you can do it in web.xml as well ).
 

I never noticed that in the Ant docs.  Thanks.

It would be nice if there were some docs with Tomcat 4 about
Jasper.  All there is now are the Jasper API Javadocs.

Regards,

Glenn


--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




[4.1.9] New test milestone released

2002-08-10 Thread Remy Maucherat

A new test milestone of Tomcat 4.1 has just been released.

Downloads:
http://jakarta.apache.org/builds/jakarta-tomcat-4.0/test/v4.1.9/

Significant changes over 4.1.8 Beta include:
- Jasper 2 bugfixes
- Catalina classloader bugfixes
- Coyote HTTP/1.1 fixes
- Updated commons-dbcp connection pool

The list of changes is available in the release notes.

Remy


--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Re: [4.1.9] New test milestone released

2002-08-10 Thread costinm

Remy, 

Let's try to make 4.1.10 the 'stable' release ( and consider 4.1.9 as
the 'release candidate ). I cleaned up some of the jk messages and
I want to do some more watchdog tests with apache/jk.

If everyone agree, I think we should also tag jk2 as 'jk2.0beta' and
jk1.2.0 release, even if we don't distribute a standalone package.


Costin


On Sat, 10 Aug 2002, Remy Maucherat wrote:

 A new test milestone of Tomcat 4.1 has just been released.
 
 Downloads:
 http://jakarta.apache.org/builds/jakarta-tomcat-4.0/test/v4.1.9/
 
 Significant changes over 4.1.8 Beta include:
 - Jasper 2 bugfixes
 - Catalina classloader bugfixes
 - Coyote HTTP/1.1 fixes
 - Updated commons-dbcp connection pool
 
 The list of changes is available in the release notes.
 
 Remy
 
 
 --
 To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
 For additional commands, e-mail: mailto:[EMAIL PROTECTED]
 
 


--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]