DO NOT REPLY [Bug 24970] - charset appended to content-type even if not text/*

2005-03-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=24970.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=24970


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24970] - charset appended to content-type even if not text/*

2005-03-04 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=24970.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=24970





--- Additional Comments From [EMAIL PROTECTED]  2005-03-04 16:37 ---
I have a work-around in the form of a Filter. This filter uses a ResponseWrapper
to wrap getWriter:

 public void doFilter(ServletRequest servletRequest, ServletResponse
servletResponse, FilterChain filterChain) 
throws java.io.IOException, ServletException {

HttpServletResponseWrapper wrapper = new
HttpServletResponseWrapper((HttpServletResponse) servletResponse) {
private String contentType;
public void setContentType(String ct) {
contentType = ct;
super.setContentType(ct);
}

/**
 * This is the essence of this whole thing. The idea
 * is to fake the use of getOutputStream(). Then you
 * are in byte-writing mode.  and charset's become
 * irrelevant,and tomcat will not add one any more.
 */

public PrintWriter getWriter() throws IOException {
if (contentTypes.contains(contentType)) {
log.debug(Wrapping outputstream to avoid charset);
try {
// ISO-8859-1 is default for HTTP
return new PrintWriter(new BufferedWriter(new
OutputStreamWriter(getOutputStream(), ISO-8859-1)));
} catch (UnsupportedEncodingException uee) {
// could not happen
return super.getWriter();
}
} else {
if (log.isDebugEnabled()) {
log.debug(  + contentType +  is not contained by
 + contentTypes);
}
return super.getWriter();
}
}
};
filterChain.doFilter(servletRequest, wrapper);

}


So, you can configure a set of contentypes for which no charset is added and
which therefore must be in ISO-8859-1.



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24970] - charset appended to content-type even if not text/*

2005-02-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=24970.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=24970





--- Additional Comments From [EMAIL PROTECTED]  2005-02-22 17:25 ---
(In reply to comment #25)
 OK, I read the JavaServer Pages Specification and it's clear that JSPs are
 servlets only designed to send TEXT data.

I agree that one should not send pdf with a JSP. But how about
text/vnd.rn-realtext. Of course it is silly that Real-Player chokes in the
charset, but well, it does.

So I woudl really like to have some possibility to dynamically create .rt files,
in which realplayer does not choke.

Michiel
 

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24970] - charset appended to content-type even if not text/*

2005-01-14 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=24970.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=24970


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2005-01-14 15:08 ---
*** Bug 33099 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24970] - charset appended to content-type even if not text/*

2005-01-14 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=24970.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=24970





--- Additional Comments From [EMAIL PROTECTED]  2005-01-14 15:30 ---
are you sure Bug 33099 is duplication if this bug?!?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24970] - charset appended to content-type even if not text/*

2004-12-02 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=24970.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=24970


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2004-12-02 20:21 ---
*** Bug 32499 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24970] - charset appended to content-type even if not text/*

2004-08-02 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=24970.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=24970

charset appended to content-type even if not text/*





--- Additional Comments From [EMAIL PROTECTED]  2004-08-02 08:14 ---
OK, I read the JavaServer Pages Specification and it's clear that JSPs are
servlets only designed to send TEXT data.

Trying to send a PDF or other binary data via a JSP should not be done.
A servlet should be written for this kind of things.

The workaroud 'response.reset()' should not be used in a production environment.
It works with the actual Coyote implementation, but nothing can guarantee that
others implementation will accept it.
In facts, the getOutputStream() method should not be allowed in a JSP.

The getWriter() method should be called() as soon as possible in the generated
java code of the JSP. Then a call to getOutputStream() would result in a
IllegalStateException.

Regards

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24970] - charset appended to content-type even if not text/*

2004-07-30 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=24970.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=24970

charset appended to content-type even if not text/*

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
   Priority|Other   |High
 Resolution|FIXED   |



--- Additional Comments From [EMAIL PROTECTED]  2004-07-30 13:11 ---
I agree with Paul Brohman, the bug is still present in 4.1.30.

response.setContentType( application/pdf );
gives Content-Type: application/pdf;charset=ISO-8859-1

I've tried with Response.class from attachment 9309 first in {TOMCAT
INSTALL}/server/classes/org/apache/coyote/Response.class and then by replacing
Response.class in tomcat-coyote.jar with the same result.

So I looked the source of Response.java and found in setContentType :

if (!hasCharset) {
this.contentType = type;
return;
}

In the other case (if hasCharset is true), and if charsetValue is valid, then
charsetSet is set to true.

The problem is the folowing :
- I'm using J2EE 1.3 so the method setCharacterEncoding() can't be used.
- When compiling a JSP, tomcat adds automaticaly
response.setContentType(text/html;charset=ISO-8859-1); in the _jsp.java file.

Doing this, charsetSet is set to true in response and characterEncoding is set
to ISO-8859-1.

Then my own code says :
response.setContentType( application/pdf );
But in this case, charsetSet is NOT reset to false, and characterEncoding keeps
it's old value.

I think the above code should almost be :
if (!hasCharset) {
this.contentType = type;
charsetSet=false;
return;
}

Or charsetSet should be set to false at the begining of setContentType;

But this means for those who can use setCharacterEncoding(), to use it AFTER
setContentType();

So to completely fix the problem, I think that setCharacterEncoding() should set
a special boolean and setContentType() another one.

Then getContentType() should append the charset expression to Content-Type if
one the the two boolean is true.

In this case we will have the folowing results :

response.setCharacterEncoding( ISO-8859-1 );
response.setContentType( application/pdf );
response.getContentType(  ) - Content-Type: 
application/pdf;charset=ISO-8859-1;

response.setCharacterEncoding( ISO-8859-1 );
response.setContentType( plain/text;charset=UTF-8 );
response.getContentType(  ) - Content-Type: plain/text;charset=UTF-8;

response.setContentType( plain/text;charset=UTF-8 );
response.setCharacterEncoding( ISO-8859-1 );
response.getContentType(  ) - Content-Type: plain/text;ISO-8859-1;

response.setContentType(text/html;charset=ISO-8859-1);
response.setContentType( application/pdf );
response.getContentType(  ) - Content-Type: application/pdf



Nevertheless waiting for the bug to be fixed, a workaround is to use the reset()
method who sets charsetSet to false.

response.reset();
response.addHeader( Content-Disposition, inline; filename=\ + strFileName
+ \ ) ;
response.setContentType( application/pdf );
response.setContentLength(data.length);
response.getOutputStream().write( data ) ;
response.getOutputStream().close() ;

Regards

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24970] - charset appended to content-type even if not text/*

2004-07-30 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=24970.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=24970

charset appended to content-type even if not text/*

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||WONTFIX



--- Additional Comments From [EMAIL PROTECTED]  2004-07-30 14:44 ---
The servlet spec expert group has decided that all Servlets that use a Writer 
(and this includes all JSPs) must include a charset in the 2.4 servlet spec.  
Since Tomcat 4 uses the same connectors as Tomcat 5, and Tomcat 5 must set the 
charset, this will certainly not be fixed.

I'm glad to see that you've discovered that you can work around this with 
response.reset.  That is the only way that sending pdfs from a JSP is supported.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24970] - charset appended to content-type even if not text/*

2004-07-06 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=24970.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=24970

charset appended to content-type even if not text/*





--- Additional Comments From [EMAIL PROTECTED]  2004-07-06 20:38 ---
I noticed that this bug is marked as resolved, but i'm not sure it is. I came 
across this situation today when setting the content type to application/pdf.

when i viewed the compiled code i noticed this being set by tomcat:

response.setContentType(application/pdf;charset=ISO-8859-1); 

I set the content type to application/pdf, but i didn't add the charset. 
Tomcat seems to be setting the charset to the default when a content type is 
specified. In the case of application/pdf setting the charset won't work with 
Adobe Reader 6.0, 6.01, and 6.0.2.

Viewing the headers with HTTPWatch, i'm able to see that the content type 
is application/pdf;charset=ISO-8859-1 even though i just set application/pdf

Could someone please let me know if this is still a bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24970] - charset appended to content-type even if not text/*

2004-02-04 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970

charset appended to content-type even if not text/*

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |



--- Additional Comments From [EMAIL PROTECTED]  2004-02-04 16:20 ---
This is still a bug. I have tested it with 4.1.30.
For images is it fixed.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24970] - charset appended to content-type even if not text/*

2004-02-04 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970

charset appended to content-type even if not text/*

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2004-02-04 16:30 ---
How about posting a test case, or, even better, use tomcat-user to resolve this
issue ? It is almost certain that you are doing something wrong.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24970] - charset appended to content-type even if not text/*

2004-01-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970

charset appended to content-type even if not text/*

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]



--- Additional Comments From [EMAIL PROTECTED]  2004-01-25 18:27 ---
*** Bug 26418 has been marked as a duplicate of this bug. ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24970] - charset appended to content-type even if not text/*

2003-12-24 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970

charset appended to content-type even if not text/*





--- Additional Comments From [EMAIL PROTECTED]  2003-12-24 14:00 ---
Sorry Remy, Sven,

Learn my lesson. Will not make the same mistake again by reopening the case.

I will try again, even though actually I've tried to put it into the jar files, 
(*still doesnt work*), but i will check it again after this.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24970] - charset appended to content-type even if not text/*

2003-12-23 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970

charset appended to content-type even if not text/*

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]



--- Additional Comments From [EMAIL PROTECTED]  2003-12-23 16:44 ---
*** Bug 25729 has been marked as a duplicate of this bug. ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24970] - charset appended to content-type even if not text/*

2003-12-23 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970

charset appended to content-type even if not text/*

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |



--- Additional Comments From [EMAIL PROTECTED]  2003-12-24 00:33 ---
Hi,

Try this patch, it doesnt work:

Still encountered the garbage character everytime I open the link with .xls 
file instead of using excel to open the link. This doesnt happen with 4.1.27


-bash-2.05b$ md5 Response.class 
MD5 (Response.class) = 0f47f349c673414045b68d2f5aca430a 
-bash-2.05b$ pwd
/home/www/tomcat/server/classes/org/apache/coyote   
-bash-2.05b$ ls -l Response.class   
-rw-r--r--1 www  www  8853 Jan 28 08:18 Response.class

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24970] - charset appended to content-type even if not text/*

2003-12-23 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970

charset appended to content-type even if not text/*





--- Additional Comments From [EMAIL PROTECTED]  2003-12-24 01:17 ---
Well, i modified my tomcat-coyote.jar. i don't know if putting Response.class in
the class-folder helps. To copy Response.class over the file in
tomcat-coyote.jar you can use WinRAR or WinZIP or any other tool.

Of course i cannot convince people to trust me, but i can assure you that i'm
not an evil person. The patch is used by me in a productive system and i haven't
had any problems yet.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24970] - charset appended to content-type even if not text/*

2003-12-23 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970

charset appended to content-type even if not text/*

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2003-12-24 06:01 ---
Even if you cannot make a binary patch work, you shouldn't reopen this issue, as
the bug has been fixed in CVS.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24970] - charset appended to content-type even if not text/*

2003-12-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970

charset appended to content-type even if not text/*





--- Additional Comments From [EMAIL PROTECTED]  2003-12-19 13:39 ---
*(BIG trusting assumption: the attachment is a valid file for Response.class)*

If one wishes to get a hotfix without compiling the fix themself ...

Take the attachment 9309 in this bug report and save it as Response.class.

Then move Response.class (creating the approprite dirs) to 
{TOMCAT INSTALL}/server/classes/org/apache/coyote/Response.class

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24970] - charset appended to content-type even if not text/*

2003-12-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970

charset appended to content-type even if not text/*

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]



--- Additional Comments From [EMAIL PROTECTED]  2003-12-03 13:27 ---
*** Bug 25162 has been marked as a duplicate of this bug. ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24970] - charset appended to content-type even if not text/*

2003-12-01 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970

charset appended to content-type even if not text/*

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]



--- Additional Comments From [EMAIL PROTECTED]  2003-12-01 15:00 ---
*** Bug 25109 has been marked as a duplicate of this bug. ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24970] - charset appended to content-type even if not text/*

2003-12-01 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970

charset appended to content-type even if not text/*





--- Additional Comments From [EMAIL PROTECTED]  2003-12-01 15:26 ---
It's a shame, that Tomcat-people are unable to release a simple hotfix.
I guess most people will agree. Pointing me to the FAQ where it says:
When will the next version be released? When it is ready. is an impertinence.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24970] - charset appended to content-type even if not text/*

2003-11-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970

charset appended to content-type even if not text/*





--- Additional Comments From [EMAIL PROTECTED]  2003-11-28 10:49 ---
I've some download problems with the attachment. Can you please provide the 
patch again or mail it to me directly?

Thanks!

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24970] - charset appended to content-type even if not text/*

2003-11-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970

charset appended to content-type even if not text/*





--- Additional Comments From [EMAIL PROTECTED]  2003-11-26 19:35 ---
Created an attachment (id=9309)
put it in server/lib/tomcat-coyote.jar to solve this bug

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24970] - charset appended to content-type even if not text/*

2003-11-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970

charset appended to content-type even if not text/*





--- Additional Comments From [EMAIL PROTECTED]  2003-11-26 19:36 ---
The attachement i just uploaded is an updated Response.class build by patching
tomcat 4.1.29 with the patch supplied by Tim Funk

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24970] - charset appended to content-type even if not text/*

2003-11-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970

charset appended to content-type even if not text/*

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2003-11-25 12:55 ---
Already fixed, can't find the commit message but this is close:

http://marc.theaimsgroup.com/?l=tomcat-devm=106870694029743w=2

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24970] - charset appended to content-type even if not text/*

2003-11-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970

charset appended to content-type even if not text/*





--- Additional Comments From [EMAIL PROTECTED]  2003-11-25 12:59 ---
when can i expect the next tomcat 4.1 release?

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24970] - charset appended to content-type even if not text/*

2003-11-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970

charset appended to content-type even if not text/*





--- Additional Comments From [EMAIL PROTECTED]  2003-11-25 13:21 ---
http://jakarta.apache.org/tomcat/faq/version.html#when

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24970] - charset appended to content-type even if not text/*

2003-11-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970

charset appended to content-type even if not text/*





--- Additional Comments From [EMAIL PROTECTED]  2003-11-25 17:58 ---
OK, i tried ...

Well, can you point me at the code/class which needs a fix?
I would have downgrade Tomcat, but i'd like keep 4.1.29 and patch it.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24970] - charset appended to content-type even if not text/*

2003-11-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970

charset appended to content-type even if not text/*





--- Additional Comments From [EMAIL PROTECTED]  2003-11-25 18:16 ---
Here's the patch.

Index: Response.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/Response.java,v
retrieving revision 1.29
retrieving revision 1.31
diff -r1.29 -r1.31
157a158,161
 /**
  * Has the charset been explicitly set.
  */
 protected boolean charsetSet = false;
323a328
 charsetSet = false;
473c478,479
   characterEncoding = charset;
---
 characterEncoding = charset;
 charsetSet=true;
545a552
 charsetSet=true;
555,557c562,565
 if (ret != null  characterEncoding != null) {
 ret += ;charset=;
 ret += characterEncoding;
---
 if (ret != null 
  characterEncoding != null
  charsetSet) {
 ret = ret + ;charset= + characterEncoding;
589a598
 charsetSet = false;

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24970] - charset appended to content-type even if not text/*

2003-11-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24970

charset appended to content-type even if not text/*

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]



--- Additional Comments From [EMAIL PROTECTED]  2003-11-26 00:12 ---
*** Bug 24996 has been marked as a duplicate of this bug. ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]