DO NOT REPLY [Bug 28263] - Tomcat 5 installer Windows detects JRE instead of JDK

2004-04-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28263.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28263

Tomcat 5 installer Windows detects JRE instead of JDK

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||WONTFIX



--- Additional Comments From [EMAIL PROTECTED]  2004-04-25 12:37 ---
What I meant is actually that you should use something reliable (JAVA_HOME, or
select the right path in the dialog). The registry keys depend on the JDK used,
so it will not really work.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 28263] - Tomcat 5 installer Windows detects JRE instead of JDK

2004-04-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28263.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28263

Tomcat 5 installer Windows detects JRE instead of JDK





--- Additional Comments From [EMAIL PROTECTED]  2004-04-25 22:52 ---
Actually the Function findJavaPath, in installation script, already look for 
the JAVA_HOME environment variable as a first try, and this is correct.
The problem is in the second try, when it looks into Windows Registry.
The high-level algorithm for this function is:

1. Try to read JAVA_HOME environment variable.
2. If it exists, JDK is considered found, end function.
3. Else (JAVA_HOME not defined), try to read Windows Registry for JDK 
installation.
4. If Registry key for JDK is found,

The script for Tomcat 4 correctly do the step 3 looking for the SDK 
installation key. But the Tomcat 5 installation script looks for JRE key in 
the step 3, which is obviously wrong. I don't know why the error was 
introduced in Tomcat 5 installation, since it was correct in Tomcat 4.

But it IS a bug. BTW, the registry keys I'm talking about are conformant to 
all versions of Windows installation for Java SDK from Sun Microsystems, 
including the most recent, 1.4.2_04.

I'm sorry, but I can't believe that a basic bug like that will remain existing 
since it can be easily solved and I already sent a patch.

Which Tomcat project commiter is familiar to the Windows installation script?
Does anyone else agree with me, or everybody agree with mr. Remy Maucherat 
that the error should not be fixed?

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 28263] - Tomcat 5 installer Windows detects JRE instead of JDK

2004-04-10 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28263.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28263

Tomcat 5 installer Windows detects JRE instead of JDK

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Priority|Low |Medium

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 28263] - Tomcat 5 installer Windows detects JRE instead of JDK

2004-04-10 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28263.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28263

Tomcat 5 installer Windows detects JRE instead of JDK





--- Additional Comments From [EMAIL PROTECTED]  2004-04-10 18:53 ---
Created an attachment (id=11209)
[PATCH] Correctly detects JDK (and not JRE) in NSI Windows installation script

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 28263] - Tomcat 5 installer Windows detects JRE instead of JDK

2004-04-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28263.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28263

Tomcat 5 installer Windows detects JRE instead of JDK

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |



--- Additional Comments From [EMAIL PROTECTED]  2004-04-09 20:29 ---
I've looked into the installation scripts from Tomcat CVS.

There's a Function findJavaPath in tomcat.nsi file. In Tomcat 4 script,
which correctly find the JDK path, the registry keys for the Java Development
Kit are read, and the JavaHome path value will be put into $1 correctly:

  ReadRegStr $2 HKLM SOFTWARE\JavaSoft\Java Development Kit CurrentVersion
  ReadRegStr $1 HKLM SOFTWARE\JavaSoft\Java Development Kit\$2 JavaHome
  ReadRegStr $3 HKLM SOFTWARE\JavaSoft\Java Runtime Environment CurrentVersion
  ReadRegStr $4 HKLM SOFTWARE\JavaSoft\Java Runtime Environment\$3 RuntimeLib

But, in the Tomcat 5 installation script, this is WRONG, it really gets the
JavaHome from JRE, not from JDK, as show in the current code:

  ReadRegStr $2 HKLM SOFTWARE\JavaSoft\Java Runtime Environment CurrentVersion
  ReadRegStr $1 HKLM SOFTWARE\JavaSoft\Java Runtime Environment\$2 JavaHome
  ReadRegStr $3 HKLM SOFTWARE\JavaSoft\Java Runtime Environment\$2 RuntimeLib

The solution is just replace the installation code I've found for Tomcat 4.

After that, if you still close the bug as invalid, I quit.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 28263] - Tomcat 5 installer Windows detects JRE instead of JDK

2004-04-07 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28263.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28263

Tomcat 5 installer Windows detects JRE instead of JDK

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2004-04-07 16:15 ---
This is not the case.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 28263] - Tomcat 5 installer Windows detects JRE instead of JDK

2004-04-07 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28263.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28263

Tomcat 5 installer Windows detects JRE instead of JDK

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |



--- Additional Comments From [EMAIL PROTECTED]  2004-04-07 16:27 ---
I beg you pardon, but this is a reproducible issue in my Windows XP computer, 
which have the JDK 1.4.2_04 correctly installed. In addition, I maintain a 
Tomcat installation tutorial (in Portuguese) in my site and some other users 
have also contacted me describing the exact same problem. So *why* this is not 
the case?

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 28263] - Tomcat 5 installer Windows detects JRE instead of JDK

2004-04-07 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28263.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28263

Tomcat 5 installer Windows detects JRE instead of JDK

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Priority|Other   |Low

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 28263] - Tomcat 5 installer Windows detects JRE instead of JDK

2004-04-07 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28263.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28263

Tomcat 5 installer Windows detects JRE instead of JDK

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||INVALID

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]