RE: [PATCH TC4] added jndi.jar to classpath in javac task

2001-08-27 Thread Keith Wannamaker

Hi John,
I did not need to do this to build tc4 out of the box.

What was the build error?  Is your build.properties pointing
to jndi OK?  If you do an ant -verbose, does ${jndi.home}
get set correctly?  TC4 will automatically include
${jndi.home}/lib/jndi.jar (see catalina/build.xml:28)

Keith

| -Original Message-
| From: Reilly, John [mailto:[EMAIL PROTECTED]]
| Sent: Monday, August 27, 2001 11:09 AM
| To: Tomcat Dev (E-mail)
| Subject: [PATCH TC4] added jndi.jar to classpath in javac task
| 
| 
| 
| Catalina would not compile without adding jndi.jar to the classpath for
| catalina and the webapp/examples.  Presumably this is not affecting people
| because they have it in there environment classpath.  (I think I submitted
| this a while ago also.)
| 
| diffed against current cvs update
| 
| Cheers,
| jr




RE: [PATCH TC4] added jndi.jar to classpath in javac task

2001-08-27 Thread Reilly, John



 Hi John,
 I did not need to do this to build tc4 out of the box.
 
 What was the build error?  Is your build.properties pointing
 to jndi OK?  If you do an ant -verbose, does ${jndi.home}
 get set correctly?  TC4 will automatically include
 ${jndi.home}/lib/jndi.jar (see catalina/build.xml:28)

The problem is that the javac task on line 138 did not use ${jndi.jar}.  The
build error was that it could not import the javax.naming classes.  Changing
the javac task as per the diff fixed the problem (this would not have worked
if I did not have jndi.home set in my build.properties).

If you do a grep on the build.xml you will see that the unpatched version
only defines ${jndi.jar} and uses it on line 93 to copy jndi.jar to
common/lib

The only way you would be able to compile without the changes I suggested
would be to have jndi.jar in your environment CLASSPATH or in the ext
directory of your jre/jdk. (I think)

 
 Keith
 
 | -Original Message-
 | From: Reilly, John [mailto:[EMAIL PROTECTED]]
 | Sent: Monday, August 27, 2001 11:09 AM
 | To: Tomcat Dev (E-mail)
 | Subject: [PATCH TC4] added jndi.jar to classpath in javac task
 | 
 | 
 | 
 | Catalina would not compile without adding jndi.jar to the 
 classpath for
 | catalina and the webapp/examples.  Presumably this is not 
 affecting people
 | because they have it in there environment classpath.  (I 
 think I submitted
 | this a while ago also.)
 | 
 | diffed against current cvs update
 | 
 | Cheers,
 | jr