RE: [PROPOSAL] Minor fix for servletapi-4 GenericServlet

[GOMEZ Henri]

>> Which make me think we need a stable tarball/jar/zip
>> for servlet-api4
>> 
>
> +1, I dislike having "download the latest nightly
>snapshot" in build docs. But how does that happen?

May be by creating release in :

http://jakarta.apache.org/builds/jakarta-servletapi-4/

And put signed source/binary tarballs and jar here

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: [PROPOSAL] Minor fix for servletapi-4 GenericServlet

[Larry Isaacs]

Before we roll releases, it sure would be nice if
some version info could be included in the MANIFEST.MFs.
It has been difficult tracking various versions of
servlet.jar, especially Servlet 2.2 versions.
I'll work on a patch to submit this weekend.

Larry

> -Original Message-
> From: Craig R. McClanahan [mailto:[EMAIL PROTECTED]] 
> Sent: Friday, June 14, 2002 5:52 PM
> To: Tomcat Developers List
> Subject: Re: [PROPOSAL] Minor fix for servletapi-4 GenericServlet
> 
> 
> 
> 
> On Fri, 14 Jun 2002, Christopher K.  St.  John wrote:
> 
> > Date: Fri, 14 Jun 2002 14:24:58 -0700 (PDT)
> > From: Christopher K.  St.  John <[EMAIL PROTECTED]>
> > Reply-To: Tomcat Developers List <[EMAIL PROTECTED]>
> > To: [EMAIL PROTECTED]
> > Subject: Re: [PROPOSAL] Minor fix for servletapi-4 GenericServlet
> >
> > GOMEZ Henri wrote:
> > >
> > > Did we have to make a general announce about this API
> > > changes ?
> > >
> >
> >  There are only 5 committers for servletapi-4, and
> > none of them appears to be active right at the moment.
> > I agree that there has been way too much discussion
> > about what is basically a trivial fix, but I'm not
> > clear on how bugs (as opposed to actual API changes
> > from the JSR group) are supposed to get fixed.
> >
> >
> > > Which make me think we need a stable tarball/jar/zip
> > > for servlet-api4
> > >
> >
> >  +1, I dislike having "download the latest nightly
> > snapshot" in build docs. But how does that happen?
> >
> 
> I went ahead and updated GenericServlet in both repositories
> (jakarta-servletapi and jakarta-servletapi-4).  Someone else 
> will need to
> take care of rolling a stable release of each, though.
> 
> Craig
> 
> 
> --
> To unsubscribe, e-mail:   
> <mailto:tomcat-dev-> [EMAIL PROTECTED]>
> For 
> additional commands, 
> e-mail: <mailto:[EMAIL PROTECTED]>
> 

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Re: [PROPOSAL] Minor fix for servletapi-4 GenericServlet

[Remy Maucherat]

Christopher K. St. John wrote:
> GOMEZ Henri wrote:
> 
>>Did we have to make a general announce about this API
>>changes ?
>>
> 
> 
>  There are only 5 committers for servletapi-4, and 
> none of them appears to be active right at the moment.
> I agree that there has been way too much discussion
> about what is basically a trivial fix, but I'm not
> clear on how bugs (as opposed to actual API changes
> from the JSR group) are supposed to get fixed.
> 
> 
> 
>>Which make me think we need a stable tarball/jar/zip
>>for servlet-api4
>>
> 
> 
>  +1, I dislike having "download the latest nightly
> snapshot" in build docs. But how does that happen?

I've been using the "tomcat_402_final" tag to build the 4.0.x binaries.

For 4.1.x, I'm now using the HEAD again, as we're about to make some 
tweaks there.

+1 for adding committers to that repository as needed. IMO, one extra 
committer is needed.
+1 to require a vote for every change beforehand (that JAR is used by 
every J2EE vendor, AFAIK, so it impacts lots of people).

As Craig mentioned, we probably need a new tag once we consider all the 
issues are fixed. There are a few javadoc errors when building, I think. 
Maybe we could also address that.

Remy


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: [PROPOSAL] Minor fix for servletapi-4 GenericServlet

[Craig R. McClanahan]

On Fri, 14 Jun 2002, Christopher K.  St.  John wrote:

> Date: Fri, 14 Jun 2002 14:24:58 -0700 (PDT)
> From: Christopher K.  St.  John <[EMAIL PROTECTED]>
> Reply-To: Tomcat Developers List <[EMAIL PROTECTED]>
> To: [EMAIL PROTECTED]
> Subject: Re: [PROPOSAL] Minor fix for servletapi-4 GenericServlet
>
> GOMEZ Henri wrote:
> >
> > Did we have to make a general announce about this API
> > changes ?
> >
>
>  There are only 5 committers for servletapi-4, and
> none of them appears to be active right at the moment.
> I agree that there has been way too much discussion
> about what is basically a trivial fix, but I'm not
> clear on how bugs (as opposed to actual API changes
> from the JSR group) are supposed to get fixed.
>
>
> > Which make me think we need a stable tarball/jar/zip
> > for servlet-api4
> >
>
>  +1, I dislike having "download the latest nightly
> snapshot" in build docs. But how does that happen?
>

I went ahead and updated GenericServlet in both repositories
(jakarta-servletapi and jakarta-servletapi-4).  Someone else will need to
take care of rolling a stable release of each, though.

Craig


--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Re: [PROPOSAL] Minor fix for servletapi-4 GenericServlet

[Christopher K. St. John]

GOMEZ Henri wrote:
> 
> Did we have to make a general announce about this API
> changes ?
> 

 There are only 5 committers for servletapi-4, and 
none of them appears to be active right at the moment.
I agree that there has been way too much discussion
about what is basically a trivial fix, but I'm not
clear on how bugs (as opposed to actual API changes
from the JSR group) are supposed to get fixed.


> Which make me think we need a stable tarball/jar/zip
> for servlet-api4
> 

 +1, I dislike having "download the latest nightly
snapshot" in build docs. But how does that happen?


-- 
Christopher St. John [EMAIL PROTECTED]
DistribuTopia http://www.distributopia.com

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: [PROPOSAL] Minor fix for servletapi-4 GenericServlet

[GOMEZ Henri]

+1.

Did we have to make a general announce about this API
changes ?

Which make me think we need a stable tarball/jar/zip
for servlet-api4

-
Henri Gomez ___[_]
EMAIL : [EMAIL PROTECTED](. .) 
PGP KEY : 697ECEDD...oOOo..(_)..oOOo...
PGP Fingerprint : 9DF8 1EA8 ED53 2F39 DC9B 904A 364F 80E6 



>-Original Message-
>From: Christopher K. St. John [mailto:[EMAIL PROTECTED]]
>Sent: Wednesday, June 12, 2002 7:49 PM
>To: [EMAIL PROTECTED]
>Subject: [PROPOSAL] Minor fix for servletapi-4 GenericServlet
>
>
>GOMEZ Henri wrote:
>>
>> I propose you to make a PROPOSAL for servletapi4 patch
>> to tomcat-dev list.
>> 
>
> In the jakarta-servletapi-4 repository, the class:
>
>   javax.servlet.GenericServlet
>
> has init() and destory() methods that call log(). While
>not specifically prohibited in the 2.3 spec, it results
>in unncessary output into logs. Also, it's annoying.
>
> My proposal is to remove the two log() statements from
>GenericServet.init() and GenericServlet.destory(). If
>somebody needs them for debugging, they can add them
>back into their local copy.
>
> This was reported as bug #7190. I've included a patch
>as an attachment to this message (it just removes the
>two log messages and updates the copyright date)
>
>-- 
>Christopher St. John [EMAIL PROTECTED]
>DistribuTopia http://www.distributopia.com
>

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: [PROPOSAL] Minor fix for servletapi-4 GenericServlet

[costinm]

+1

That log is really annoying. Please make the change in both 
2.2 and 2.3 branches.

Costin

On Thu, 13 Jun 2002, Christopher K.  St.  John wrote:

> "Christopher K. St. John" wrote:
> > 
> > GOMEZ Henri wrote:
> > >
> > > I propose you to make a PROPOSAL for servletapi4 patch
> > > to tomcat-dev list.
> > >
> >  My proposal is ... [delete log() msgs in GenerisServlet]
> >
> 
>  From my reading of the project guidelines, minor fixes like
> this normally go the commit-then-review route, so I'm unclear
> if there need to be 3 +1's before any action is taken. There's
> just been the one (by Remy) so far.
> 
>  I realize it isn't a very exciting patch :-), but minor
> bugs need love too, so a couple more +1's (or a -1 if there
> is some problem) would be nifty.
> 
> 
> 


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: [PROPOSAL] Minor fix for servletapi-4 GenericServlet

[Christopher K. St. John]

"Christopher K. St. John" wrote:
> 
> GOMEZ Henri wrote:
> >
> > I propose you to make a PROPOSAL for servletapi4 patch
> > to tomcat-dev list.
> >
>  My proposal is ... [delete log() msgs in GenerisServlet]
>

 From my reading of the project guidelines, minor fixes like
this normally go the commit-then-review route, so I'm unclear
if there need to be 3 +1's before any action is taken. There's
just been the one (by Remy) so far.

 I realize it isn't a very exciting patch :-), but minor
bugs need love too, so a couple more +1's (or a -1 if there
is some problem) would be nifty.


-- 
Christopher St. John [EMAIL PROTECTED]
DistribuTopia http://www.distributopia.com

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: [PROPOSAL] Minor fix for servletapi-4 GenericServlet

[John Trollinger]

There is another question here.  When log() is called no default log
level is assigned to it so there is no way to prevent log() messages
from cluttering the log files.  What about a change to allow the setting
of the log level for the log() method in server.xml or web.xml (or even
giving it a its own log level) so then all the log() messages can be
turned on and off..



-Original Message-
From: Remy Maucherat [mailto:[EMAIL PROTECTED]] 
Sent: Wednesday, June 12, 2002 3:36 PM
To: Tomcat Developers List
Subject: Re: [PROPOSAL] Minor fix for servletapi-4 GenericServlet

Christopher K. St. John wrote:
>  In the jakarta-servletapi-4 repository, the class:
> 
>javax.servlet.GenericServlet
> 
>  has init() and destory() methods that call log(). While
> not specifically prohibited in the 2.3 spec, it results
> in unncessary output into logs. Also, it's annoying.
> 
>  My proposal is to remove the two log() statements from
> GenericServet.init() and GenericServlet.destory(). If
> somebody needs them for debugging, they can add them
> back into their local copy.
> 
>  This was reported as bug #7190. I've included a patch
> as an attachment to this message (it just removes the
> two log messages and updates the copyright date)

+1. This sounds reasonable to me.

Remy


--
To unsubscribe, e-mail:
<mailto:[EMAIL PROTECTED]>
For additional commands, e-mail:
<mailto:[EMAIL PROTECTED]>


--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Re: [PROPOSAL] Minor fix for servletapi-4 GenericServlet

[Remy Maucherat]

Christopher K. St. John wrote:
>  In the jakarta-servletapi-4 repository, the class:
> 
>javax.servlet.GenericServlet
> 
>  has init() and destory() methods that call log(). While
> not specifically prohibited in the 2.3 spec, it results
> in unncessary output into logs. Also, it's annoying.
> 
>  My proposal is to remove the two log() statements from
> GenericServet.init() and GenericServlet.destory(). If
> somebody needs them for debugging, they can add them
> back into their local copy.
> 
>  This was reported as bug #7190. I've included a patch
> as an attachment to this message (it just removes the
> two log messages and updates the copyright date)

+1. This sounds reasonable to me.

Remy


--
To unsubscribe, e-mail:   
For additional commands, e-mail: