RE: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/startup StopTomcat.java

2002-02-27 Thread GOMEZ Henri 

Let me resume and tag the correct behaviour :

to start/stop with ajp12 :

startup.sh -ajpid /var/spool/tomcat3/ajp12.id -ajp12
shutdown.sh -ajpid /var/spool/tomcat3/ajp12.id -ajp12

to start/stop with ajp13 :

startup.sh -ajpid /var/spool/tomcat3/ajp13.id -ajp13
shutdown.sh -ajpid /var/spool/tomcat3/ajp13.id -ajp13

If tomcat didn't read server.xml at stop time, 
it may be better to remove AjpidFile from server.xml to avoid
such problems and make it setable only in command line ?

-
Henri Gomez ___[_]
EMAIL : [EMAIL PROTECTED](. .)
PGP KEY : 697ECEDD...oOOo..(_)..oOOo...
PGP Fingerprint : 9DF8 1EA8 ED53 2F39 DC9B 904A 364F 80E6


-Original Message-
From: Larry Isaacs [mailto:[EMAIL PROTECTED]]
Sent: Wednesday, February 27, 2002 1:01 AM
To: Tomcat Developers List
Subject: RE: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/startup 
StopTomcat.java


Hi Henri,

With implementation of the ajp12.id file, stopTomcat() quit reading
the server.xml file (StopTomcat.java v1.2).  It appears the comment
about searching for the AJP12 connector has been out of date for a
while.

For situations where the ajp??.id file is in a non-default
location, the -ajpid command line argument must be used to specify
the alternate location.  Specifying the -ajp12 or -ajp13 is also
recommended.  I still need to update the Users Guide to mention these
new arguments.

Cheers,
Larry

-Original Message- 
From: GOMEZ Henri [mailto:[EMAIL PROTECTED]] 
Sent: Tue 2/26/2002 4:38 PM 
To: Tomcat Developers List 
Cc: 
Subject: RE: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/startup 
StopTomcat.java

There is a problem with that patch : 
void stopTomcat() throws Exception { 
// if a parameter isn't set, try to read it from a file 
if( port  0 || host == null || secret == null ) { 
String tchome=getTomcatHome(); 
String defAjp12File=tchome + /conf/ajp12.id; 
String defAjp13File=tchome + /conf/ajp13.id; 
String ajpFile=secretFile; 
int portSave=port; 
String hostSave=host; 
String secretSave=secret; 
boolean pickAjp=(!isAjp13  !isAjp12); 
What happen if you put ajp12.id or ajp13.id, in another location 
using : 
Ajp12Connector address=127.0.0.1 port=8007 
AjpidFile=/var/spool/tomcat3/ajp12.id / 
Ajp13Connector port=8009 AjpidFile=/var/spool/tomcat3/ajp13.id /

RE: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/startup StopTomcat.java

2002-02-26 Thread GOMEZ Henri 

There is a problem with that patch :

void stopTomcat() throws Exception {
// if a parameter isn't set, try to read it from a file
if( port  0 || host == null || secret == null ) {
String tchome=getTomcatHome();

String defAjp12File=tchome + /conf/ajp12.id;
String defAjp13File=tchome + /conf/ajp13.id;
String ajpFile=secretFile;

int portSave=port;
String hostSave=host;
String secretSave=secret;

boolean pickAjp=(!isAjp13  !isAjp12);

What happen if you put ajp12.id or ajp13.id, in another location
using :

Ajp12Connector address=127.0.0.1 port=8007 
AjpidFile=/var/spool/tomcat3/ajp12.id /
Ajp13Connector port=8009 AjpidFile=/var/spool/tomcat3/ajp13.id /

===

Using classpath: /var/tomcat3/lib/tomcat.jar
Using JAVA_HOME: /opt/IBMJava2-13
Using TOMCAT_HOME: /etc/tomcat3
Stopping Tomcat.
Stopping tomcat on null:-1 null
address=nullport=-1secret=null
Guessed home=/var/tomcat3
Exception: java.lang.reflect.InvocationTargetException
java.lang.reflect.InvocationTargetException: java.lang.IllegalArgumentException: port 
out range:-1
at java.net.Socket.init(Socket.java:265)
at java.net.Socket.init(Socket.java:139)
at org.apache.tomcat.startup.StopTomcat.stopTomcat(StopTomcat.java:338)
at org.apache.tomcat.startup.StopTomcat.stopTomcat(StopTomcat.java:307)
at org.apache.tomcat.startup.StopTomcat.execute(StopTomcat.java:185)
at java.lang.reflect.Method.invoke(Native Method)
at org.apache.tomcat.util.IntrospectionUtils.execute(IntrospectionUtils.java:87)
at org.apache.tomcat.startup.Main.execute(Main.java:313)
at org.apache.tomcat.startup.Main.main(Main.java:140)
Root Exception: java.lang.IllegalArgumentException: port out range:-1
java.lang.IllegalArgumentException: port out range:-1
at java.net.Socket.init(Socket.java:265)
at java.net.Socket.init(Socket.java:139)
at org.apache.tomcat.startup.StopTomcat.stopTomcat(StopTomcat.java:338)
at org.apache.tomcat.startup.StopTomcat.stopTomcat(StopTomcat.java:307)
at org.apache.tomcat.startup.StopTomcat.execute(StopTomcat.java:185)
at java.lang.reflect.Method.invoke(Native Method)
at org.apache.tomcat.util.IntrospectionUtils.execute(IntrospectionUtils.java:87)
at org.apache.tomcat.startup.Main.execute(Main.java:313)
at org.apache.tomcat.startup.Main.main(Main.java:140)

===

Debug show that stopTomcat is called with portInt = -1 


/**
 *  This particular implementation will search for an AJP12
 *  connector ( that have a special stop command ).
 */
public void stopTomcat(InetAddress address, int portInt, String secret )
throws IOException 


How could we solve this :

my ajp13.id :

#Automatically generated, don't edit
#Tue Feb 26 21:37:00 CET 2002
port=8009

my ajp12.id :
8007
127.0.0.1

???

-
Henri Gomez ___[_]
EMAIL : [EMAIL PROTECTED](. .) 
PGP KEY : 697ECEDD...oOOo..(_)..oOOo...
PGP Fingerprint : 9DF8 1EA8 ED53 2F39 DC9B 904A 364F 80E6 



-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]
Sent: Friday, February 08, 2002 1:56 PM
To: [EMAIL PROTECTED]
Subject: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/startup
StopTomcat.java


larryi  02/02/08 04:55:55

  Modified:src/share/org/apache/tomcat/startup StopTomcat.java
  Log:
  Added an ajp12 option to go with the new ajp13 option and 
reworked the
  logic a bit.
  
  If either ajp12 or ajp13 is set (or the last one if both are 
set), that protocol
  will be used.  If an ajpid file is not specified, the 
associated default will be
  used.
  
  If neither ajp12 or ajp13 is specified, and no ajpid file is 
specified, then
  ajp13 is tried first with failover to ajp12 if the ajp13 
file is not found or
  shutdown isn't enabled.  If an ajpid file is specified, it 
defaults to using
  ajp12.
  
  Updated the help output.
  
  Revision  ChangesPath
  1.15  +116 -61   
jakarta-tomcat/src/share/org/apache/tomcat/startup/StopTomcat.java
  
  Index: StopTomcat.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/startup/St
opTomcat.java,v
  retrieving revision 1.14
  retrieving revision 1.15
  diff -u -r1.14 -r1.15
  --- StopTomcat.java  7 Feb 2002 05:09:36 -   1.14
  +++ StopTomcat.java  8 Feb 2002 12:55:55 -   1.15
  @@ -84,9 +84,11 @@
   // explicit command line params ( for port, host or secret )
   boolean commandLineParams=false;
   String secretFile=null;
  +String shutdown=null;
   String args[];
   boolean help=false;
   boolean isAjp13=false;
  +boolean isAjp12=false;
   
   public StopTomcat() 
   {
  @@ -157,6 +159,12 @@
   
   public void setAjp13( boolean b ) {
   isAjp13=b;
  +isAjp12=!b;
  +}
  +
  +public

Re: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/startup StopTomcat.java

2002-02-26 Thread Bill Barker 

In your case, you should use:

shutdown.sh -ajpid /var/spool/tomcat3/ajp12.id

I suppose that it could be a bit more user-friendly when you forget.  Feel
free to add in another check that the file was actually found if you want.
- Original Message -
From: GOMEZ Henri [EMAIL PROTECTED]
To: Tomcat Developers List [EMAIL PROTECTED]
Sent: Tuesday, February 26, 2002 1:38 PM
Subject: RE: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/startup
StopTomcat.java


There is a problem with that patch :

void stopTomcat() throws Exception {
// if a parameter isn't set, try to read it from a file
if( port  0 || host == null || secret == null ) {
String tchome=getTomcatHome();

String defAjp12File=tchome + /conf/ajp12.id;
String defAjp13File=tchome + /conf/ajp13.id;
String ajpFile=secretFile;

int portSave=port;
String hostSave=host;
String secretSave=secret;

boolean pickAjp=(!isAjp13  !isAjp12);

What happen if you put ajp12.id or ajp13.id, in another location
using :

Ajp12Connector address=127.0.0.1 port=8007
AjpidFile=/var/spool/tomcat3/ajp12.id /
Ajp13Connector port=8009 AjpidFile=/var/spool/tomcat3/ajp13.id
/

===

Using classpath: /var/tomcat3/lib/tomcat.jar
Using JAVA_HOME: /opt/IBMJava2-13
Using TOMCAT_HOME: /etc/tomcat3
Stopping Tomcat.
Stopping tomcat on null:-1 null
address=nullport=-1secret=null
Guessed home=/var/tomcat3
Exception: java.lang.reflect.InvocationTargetException
java.lang.reflect.InvocationTargetException:
java.lang.IllegalArgumentException: port out range:-1
at java.net.Socket.init(Socket.java:265)
at java.net.Socket.init(Socket.java:139)
at org.apache.tomcat.startup.StopTomcat.stopTomcat(StopTomcat.java:338)
at org.apache.tomcat.startup.StopTomcat.stopTomcat(StopTomcat.java:307)
at org.apache.tomcat.startup.StopTomcat.execute(StopTomcat.java:185)
at java.lang.reflect.Method.invoke(Native Method)
at
org.apache.tomcat.util.IntrospectionUtils.execute(IntrospectionUtils.java:87
)
at org.apache.tomcat.startup.Main.execute(Main.java:313)
at org.apache.tomcat.startup.Main.main(Main.java:140)
Root Exception: java.lang.IllegalArgumentException: port out range:-1
java.lang.IllegalArgumentException: port out range:-1
at java.net.Socket.init(Socket.java:265)
at java.net.Socket.init(Socket.java:139)
at org.apache.tomcat.startup.StopTomcat.stopTomcat(StopTomcat.java:338)
at org.apache.tomcat.startup.StopTomcat.stopTomcat(StopTomcat.java:307)
at org.apache.tomcat.startup.StopTomcat.execute(StopTomcat.java:185)
at java.lang.reflect.Method.invoke(Native Method)
at
org.apache.tomcat.util.IntrospectionUtils.execute(IntrospectionUtils.java:87
)
at org.apache.tomcat.startup.Main.execute(Main.java:313)
at org.apache.tomcat.startup.Main.main(Main.java:140)

===

Debug show that stopTomcat is called with portInt = -1


/**
 *  This particular implementation will search for an AJP12
 * connector ( that have a special stop command ).
 */
public void stopTomcat(InetAddress address, int portInt, String secret )
throws IOException


How could we solve this :

my ajp13.id :

#Automatically generated, don't edit
#Tue Feb 26 21:37:00 CET 2002
port=8009

my ajp12.id :
8007
127.0.0.1

???

-
Henri Gomez ___[_]
EMAIL : [EMAIL PROTECTED](. .)
PGP KEY : 697ECEDD...oOOo..(_)..oOOo...
PGP Fingerprint : 9DF8 1EA8 ED53 2F39 DC9B 904A 364F 80E6


--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]



--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]

RE: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/startup StopTomcat.java

2002-02-26 Thread Larry Isaacs 

Hi Henri,
 
With implementation of the ajp12.id file, stopTomcat() quit reading
the server.xml file (StopTomcat.java v1.2).  It appears the comment
about searching for the AJP12 connector has been out of date for a
while.
 
For situations where the ajp??.id file is in a non-default
location, the -ajpid command line argument must be used to specify
the alternate location.  Specifying the -ajp12 or -ajp13 is also
recommended.  I still need to update the Users Guide to mention these
new arguments.
 
Cheers,
Larry

-Original Message- 
From: GOMEZ Henri [mailto:[EMAIL PROTECTED]] 
Sent: Tue 2/26/2002 4:38 PM 
To: Tomcat Developers List 
Cc: 
Subject: RE: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/startup 
StopTomcat.java

There is a problem with that patch : 
void stopTomcat() throws Exception { 
// if a parameter isn't set, try to read it from a file 
if( port  0 || host == null || secret == null ) { 
String tchome=getTomcatHome(); 
String defAjp12File=tchome + /conf/ajp12.id; 
String defAjp13File=tchome + /conf/ajp13.id; 
String ajpFile=secretFile; 
int portSave=port; 
String hostSave=host; 
String secretSave=secret; 
boolean pickAjp=(!isAjp13  !isAjp12); 
What happen if you put ajp12.id or ajp13.id, in another location 
using : 
Ajp12Connector address=127.0.0.1 port=8007 
AjpidFile=/var/spool/tomcat3/ajp12.id / 
Ajp13Connector port=8009 AjpidFile=/var/spool/tomcat3/ajp13.id / 




msg22619/bin0.bin
Description: application/ms-tnef

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]