Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/authenticator SingleSignOn.java

2003-12-23 Thread Brian Stansberry
Hi,

At 05:55 PM 12/23/2003 +, you wrote:
markt   2003/12/23 09:55:39

  Modified:catalina/src/share/org/apache/catalina/authenticator
SingleSignOn.java
  Log:
  - Fix bug 10372. Prevent NPE if container is null
  - Port of functionality from TC5 implemented by bobh.

A couple weeks back I posted to bugzilla (bug 23881) a patch to TC 4.1 that deals with 
a bunch of SSO issues (bugs 4350, 9077, 10040 and 23881).  The patch was a port of the 
patch that was applied to the TC5 branch.

That patch also had the above NPE fix in it.

I was wondering if there was any interest in committing that patch to TC 4.1 before 
the next release.  If there is, I'll update it so it doesn't conflict with what Mark 
just committed (and anything else committed since I posted it).  If there's no 
interest, I'll go Christmas shopping instead ;-)

Best, 

Brian Stansberry
WAN Concepts, Inc.
www.wanconcepts.com
Tel:(510) 894-0114 x 116
Fax:(510) 797-3005 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/authenticator SingleSignOn.java

2003-12-23 Thread Mark Thomas
Brian,

Sorry I didn't spot the overlap between your patch and my recent commit. If you 
could update your TC4.1 patch I would be happy to commit it. However, I 
wouldn't want your work on the patch to distract you from your Christmas 
shopping ;)

Mark

On Tuesday, December 23, 2003 7:20 PM, Brian Stansberry 
[SMTP:[EMAIL PROTECTED] wrote:
 Hi,

 At 05:55 PM 12/23/2003 +, you wrote:
 markt   2003/12/23 09:55:39
 
   Modified:catalina/src/share/org/apache/catalina/authenticator
 SingleSignOn.java
   Log:
   - Fix bug 10372. Prevent NPE if container is null
   - Port of functionality from TC5 implemented by bobh.

 A couple weeks back I posted to bugzilla (bug 23881) a patch to TC 4.1 that
 deals with a bunch of SSO issues (bugs 4350, 9077, 10040 and 23881).  The
 patch was a port of the patch that was applied to the TC5 branch.

 That patch also had the above NPE fix in it.

 I was wondering if there was any interest in committing that patch to TC 4.1
 before the next release.  If there is, I'll update it so it doesn't conflict
 with what Mark just committed (and anything else committed since I posted
 it).  If there's no interest, I'll go Christmas shopping instead ;-)

 Best,

 Brian Stansberry
 WAN Concepts, Inc.
 www.wanconcepts.com
 Tel:(510) 894-0114 x 116
 Fax:(510) 797-3005


 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/authenticator SingleSignOn.java

2003-12-23 Thread Brian Stansberry
Mark,

At 09:18 PM 12/23/2003 +, Mark wrote:
Sorry I didn't spot the overlap between your patch and my recent commit. 

Oh, no worries.  I should have made a note against all the relevant bug reports 
(partic since I myself posted a bug on the NPE!)

If you could update your TC4.1 patch I would be happy to commit it. However, I 
wouldn't want your work on the patch to distract you from your Christmas 
shopping ;)

Thanks; will do.  Anything to get out of going to the mall!

Best,

Brian Stansberry
WAN Concepts, Inc.
www.wanconcepts.com
Tel:(510) 894-0114 x 116
Fax:(510) 797-3005 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]