Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4 CoyoteAdapter.java
Remy Maucherat wrote: [EMAIL PROTECTED] wrote: markt 2003/12/11 13:35:24 Modified:coyote/src/java/org/apache/coyote/tomcat4 CoyoteAdapter.java Log: - Fix bug 24283. Process uri as characters not bytes to ensure correct handling of unicode characters. -1 for this patch. Character decoding should occur afterwards. Mapping should be done as bytes. Oops, forget it, I thought this was in the TC 5 branch. I need to think before pressing send. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4 CoyoteAdapter.java
De: Remy Maucherat [mailto:[EMAIL PROTECTED]] Enviado el: 29 de septiembre de 2002 19:32 -1 for this unless you explain. The idea was to redirect to the default port for the protocol. Bill can probably give additional information (ignore the -1 if he agrees with the change). Ok, no problem, i feel this code like a swarm :)), but i think that in any case to get the secure flag from the connector is a nonsense in ajp13, in addition the flag is never setted in the connector so i doubt redirections in SSL had worked anytime before with HTTP11, i reviewed the code at the HTTP1Processor and it sets the scheme and port prior to that point, just like ajp13 does, so shouldnt have any problems.. But who knows, waiting for Bill.. Saludos , Ignacio J. Ortega -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4 CoyoteAdapter.java
Ignacio J. Ortega wrote: De: Remy Maucherat [mailto:[EMAIL PROTECTED]] Enviado el: 29 de septiembre de 2002 19:32 -1 for this unless you explain. The idea was to redirect to the default port for the protocol. Bill can probably give additional information (ignore the -1 if he agrees with the change). Ok, no problem, i feel this code like a swarm :)), but i think that in any case to get the secure flag from the connector is a nonsense in ajp13, in addition the flag is never setted in the connector so i doubt redirections in SSL had worked anytime before with HTTP11, i reviewed the code at the HTTP1Processor and it sets the scheme and port prior to that point, just like ajp13 does, so shouldnt have any problems.. But who knows, waiting for Bill.. Well, that particular part of the code was very tricky to get right, so the change is dangerous by itself. I don't have time to look much into it (I'll be away for 3 days; someone please handle bugzilla during that time ;-)). I think we should implement proxyPort and proxyHost if it doesn't work. That's supposed to be there, and would solve the problem I think, so it's better than trying to change working code. Remy -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4 CoyoteAdapter.java
- Original Message - From: Remy Maucherat [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Sunday, September 29, 2002 10:31 AM Subject: Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4 CoyoteAdapter.java [EMAIL PROTECTED] wrote: nacho 2002/09/29 10:07:44 Modified:coyote/src/java/org/apache/coyote/tomcat4 CoyoteAdapter.java Log: Bug#12998 HTTPS gets changed to HTTP://servername:443 Reported by marcus.kellermann at bentley.com The processor (HTTP11 or ajp13) should set the scheme and port prior to this point, in an ajp13 connection doesnt make sense to get the secure flag from the connector secure flag. -1 for this unless you explain. The idea was to redirect to the default port for the protocol. Bill can probably give additional information (ignore the -1 if he agrees with the change). Sorry, I've been out all day. At the moment, for the HTTP11 connector, the Processor sets the ServerPort and the Scheme correctly (even for the Servlet 2.4 spec :). Nacho's patch shouldn't break anything. IMHO, low-level things like ServerPort and Scheme belong in the Processor, and not in the Adapter. I'll give my +1 to Nacho's patch. Remy -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
