Re: PATCH: jakarta-tomcat-connectors build on MSVC6

2001-11-19 Thread costinm

On Mon, 19 Nov 2001, Michael Smith wrote:

 Here's a patch for clean builds on MSVC6 - includes a couple of missing
 headers, and adds JK_METHOD attributes to the neccesary functions
 (otherwise calling conventions are declared differently, and you get
 compilation-fatal errors).

Thanks Michael !

Costin



--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Re: PATCH: jakarta-tomcat-connectors build on MSVC6

2001-11-19 Thread cmanolache

On Mon, 19 Nov 2001, Remy Maucherat wrote:

  On Mon, 19 Nov 2001, Michael Smith wrote:
 
   Here's a patch for clean builds on MSVC6 - includes a couple of missing
   headers, and adds JK_METHOD attributes to the neccesary functions
   (otherwise calling conventions are declared differently, and you get
   compilation-fatal errors).
 
  Thanks Michael !

 How about giving Michael commit access ?
 He already has an account @Jakarta, so he just needs some additional karma.

In general, I think all jakarta commiters should have cross-project
permissions - maybe with the additional requirement that you need a
review-then-commit process when commiting to a project you are not
'regular' commiter.
There are many 'integration' bugs ( project X doesn't work with project Y
) that would be solved much quicker this way. But this is something for
the PMC to decide.

I'll vote +1 for any apache commiter ( i.e. jakarta, xml, httpd... ) who
wants to become a commiter on tomcat.

Costin





--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Re: PATCH: jakarta-tomcat-connectors build on MSVC6

2001-11-19 Thread Remy Maucherat

 On Mon, 19 Nov 2001, Remy Maucherat wrote:

 In general, I think all jakarta commiters should have cross-project
 permissions - maybe with the additional requirement that you need a
 review-then-commit process when commiting to a project you are not
 'regular' commiter.
 There are many 'integration' bugs ( project X doesn't work with project Y
 ) that would be solved much quicker this way. But this is something for
 the PMC to decide.

 I'll vote +1 for any apache commiter ( i.e. jakarta, xml, httpd... ) who
 wants to become a commiter on tomcat.

Good, but according to the current policy, it's not automatic, so I'm
posting a regular vote.

Remy


--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]