Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11Http11Processor.java Http11Protocol.java

2003-06-06 Thread Remy Maucherat 
Bill Barker wrote:
I'm very strongly -1 on this.  The o.a.coyote.Request should not have a
set/getSocket method for the simple reason that there is no reason that
Coyote should be assumed to be tied to a socket transport.
I plan to test the memory only protocol handler someday. The Netbeans 
folks should be happy about that (and the auto reload everything, of 
course).

CertificatesValve doesn't do anything any more with Coyote.  It is only left
around to support the deprecated Http11Connector.
Well, the connector won't work with TC 5 anyway, so ...

Remy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11Http11Processor.java Http11Protocol.java

2003-06-06 Thread Remy Maucherat 
[EMAIL PROTECTED] wrote:
luehe   2003/06/05 09:42:48

  Modified:coyote/src/java/org/apache/coyote Request.java
   http11/src/java/org/apache/coyote/http11
Http11Processor.java Http11Protocol.java
  Log:
  Removed setSocket() method from org.apache.catalina.Request, since it
  was never called in any of the classes implementing this interface.
  
  For example, setSocket() was never called on
  org.apache.coyote.tomcat5.CoyoteRequest, causing its getSocket()
  method to always return null, which broke the CertificatesValve, which
  relies on having access to the (SSL)Socket so that it can reinitiate a
  handshake if necessary.
  
  Instead, added setSocket() and getSocket() methods on org.apache.coyote.Request:
  
  - setSocket() is called as part of
org.apache.coyote.http11.Http11Processor.setSocket(), as follows:
  
  public void setSocket(Socket socket)
  throws IOException {
  this.socket = socket;
  this.request.setSocket(socket); // NEW
  }
  
  - getSocket() is called as part of
org.apache.coyote.tomcat5.CoyoteRequest.getSocket(), as follows:
Ouch, that's one nasty hack.
-1, please revert it.
There are callbacks to the processor to evaluate the SSL related 
attributes. If something is broken, this should be fixed, but using that 
pattern. I believe get/setSocket are useless, and the calls should be 
entierely removed.

Remy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]