Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/buf CharChunk.java
[EMAIL PROTECTED] wrote: remm2004/03/05 05:08:00 Modified:util/java/org/apache/tomcat/util/buf CharChunk.java Log: - Same fix. - Make calls to realReads compatible with marking (which is just for cleaness, as the parameters are not used in our use case). - Make makeSpace compatible with marking, which needs to be supported by char chunks. I hope I didn't break anything with these changes ... Maybe it would be a good idea to tag 3.3.x before these, to be safe. Of course, it should only impact char buffers which are allowed to grow significantly, which aren't used a lot (AFAIK). In Tomcat 5, I believe we play with setLimit dynamically only for char input. Please test it :) Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/buf CharChunk.java
From: Remy Maucherat [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: remm2004/03/05 05:08:00 Modified:util/java/org/apache/tomcat/util/buf CharChunk.java Log: - Same fix. - Make calls to realReads compatible with marking (which is just for cleaness, as the parameters are not used in our use case). - Make makeSpace compatible with marking, which needs to be supported by char chunks. I hope I didn't break anything with these changes ... Maybe it would be a good idea to tag 3.3.x before these, to be safe. If 3.3.x is tagged before this change it probably would be a good idea to pick up the JkInputStream change I committed earlier. It fixes a problem where small packets were getting dropped and causing the last one or two bytes of post data to be lost for certain sized posts. Of course, it should only impact char buffers which are allowed to grow significantly, which aren't used a lot (AFAIK). In Tomcat 5, I believe we play with setLimit dynamically only for char input. Please test it :) Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/buf CharChunk.java
Actually, I had intended to include the fix to JkInputStream with the 3.3.2 release. It's just that you got to it faster than me :). I agree with Remy that the changes to ByteChunk and CharChunk shouldn't do anything, but I also agree with the idea of not risking it with the 3.3.2 release. I'm inclined to tag 3.3.2 Final for these two before Remy's patch. - Original Message - From: Kurt Miller [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Friday, March 05, 2004 8:36 AM Subject: Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/buf CharChunk.java From: Remy Maucherat [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: remm2004/03/05 05:08:00 Modified:util/java/org/apache/tomcat/util/buf CharChunk.java Log: - Same fix. - Make calls to realReads compatible with marking (which is just for cleaness, as the parameters are not used in our use case). - Make makeSpace compatible with marking, which needs to be supported by char chunks. I hope I didn't break anything with these changes ... Maybe it would be a good idea to tag 3.3.x before these, to be safe. If 3.3.x is tagged before this change it probably would be a good idea to pick up the JkInputStream change I committed earlier. It fixes a problem where small packets were getting dropped and causing the last one or two bytes of post data to be lost for certain sized posts. Of course, it should only impact char buffers which are allowed to grow significantly, which aren't used a lot (AFAIK). In Tomcat 5, I believe we play with setLimit dynamically only for char input. Please test it :) Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments. In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/buf CharChunk.java
+
+// Optimize on a common case.
+// If the source is going to fill up all the space in buffer,
may
+// as well write it directly to the output, and avoid an extra
copy
+if ( len == limit end == 0) {
+out.realWriteChars( src, off, len );
+return;
+}
It should be end == start (although start == 0 is the most common case).
This message is intended only for the use of the person(s) listed above as the
intended recipient(s), and may contain information that is PRIVILEGED and
CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or
distribute this message or any attachment. If you received this communication in
error, please notify us immediately by e-mail and then delete all copies of this
message and any attachments.
In addition you should be aware that ordinary (unencrypted) e-mail sent through the
Internet is not secure. Do not send confidential or sensitive information, such as
social security numbers, account numbers, personal identification numbers and
passwords, to us via ordinary (unencrypted) e-mail.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
