Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector Connector.java Response.java
[EMAIL PROTECTED] wrote: billbarker2005/05/20 20:02:25 Modified:catalina/src/share/org/apache/catalina/connector Connector.java Response.java Log: Reverting previous patch in favor of the better one submitted by JFC No idea why but suddenly I'm getting the following when stopping the Tomcat with simple CTRL+C and AJP connector enabled. INFO: Pausing Coyote HTTP/1.1 on http-8080 May 25, 2005 4:46:53 PM org.apache.tomcat.util.threads.ThreadPool$ControlRunnable run SEVERE: Caught exception (java.lang.NoSuchMethodError: org.apache.jk.core.MsgContext.getRequest()Ljava/lang/Object;) executing [EMAIL PROTECTED], terminating thread May 25, 2005 4:46:54 PM org.apache.catalina.core.StandardService stop INFO: Stopping service Catalina Any ideas why? Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector Connector.java Response.java
Mladen Turk wrote: [EMAIL PROTECTED] wrote: billbarker2005/05/20 20:02:25 Modified:catalina/src/share/org/apache/catalina/connector Connector.java Response.java Log: Reverting previous patch in favor of the better one submitted by JFC No idea why but suddenly I'm getting the following when stopping the Tomcat with simple CTRL+C and AJP connector enabled. INFO: Pausing Coyote HTTP/1.1 on http-8080 May 25, 2005 4:46:53 PM org.apache.tomcat.util.threads.ThreadPool$ControlRunnable run SEVERE: Caught exception (java.lang.NoSuchMethodError: org.apache.jk.core.MsgContext.getRequest()Ljava/lang/Object;) executing [EMAIL PROTECTED], terminating thread May 25, 2005 4:46:54 PM org.apache.catalina.core.StandardService stop INFO: Stopping service Catalina Any ideas why? Why do you think the changes in Connector and Response cause the problem? Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector Connector.java Response.java
jean-frederic clere wrote: Mladen Turk wrote: INFO: Pausing Coyote HTTP/1.1 on http-8080 May 25, 2005 4:46:53 PM org.apache.tomcat.util.threads.ThreadPool$ControlRunnable run SEVERE: Caught exception (java.lang.NoSuchMethodError: org.apache.jk.core.MsgContext.getRequest()Ljava/lang/Object;) executing [EMAIL PROTECTED], terminating thread May 25, 2005 4:46:54 PM org.apache.catalina.core.StandardService stop INFO: Stopping service Catalina Any ideas why? Why do you think the changes in Connector and Response cause the problem? If I would have an idea I wouldn't ask 'Any ideas why?' :). Anyhow seems the problem with MsgContext.java when Bill changed the : -public final Object getRequest() +public final Request getRequest() Think that down the classtree getRequest() is still considered to return the Ljava/lang/Object. Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector Connector.java Response.java
- Original Message - From: Mladen Turk [EMAIL PROTECTED] To: Tomcat Developers List tomcat-dev@jakarta.apache.org Sent: Wednesday, May 25, 2005 9:41 AM Subject: Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector Connector.java Response.java jean-frederic clere wrote: Mladen Turk wrote: INFO: Pausing Coyote HTTP/1.1 on http-8080 May 25, 2005 4:46:53 PM org.apache.tomcat.util.threads.ThreadPool$ControlRunnable run SEVERE: Caught exception (java.lang.NoSuchMethodError: org.apache.jk.core.MsgContext.getRequest()Ljava/lang/Object;) executing [EMAIL PROTECTED], terminating thread May 25, 2005 4:46:54 PM org.apache.catalina.core.StandardService stop INFO: Stopping service Catalina Any ideas why? Why do you think the changes in Connector and Response cause the problem? If I would have an idea I wouldn't ask 'Any ideas why?' :). Anyhow seems the problem with MsgContext.java when Bill changed the : -public final Object getRequest() +public final Request getRequest() Think that down the classtree getRequest() is still considered to return the Ljava/lang/Object. Doing a clean build of j-t-c/jk/java should fix it. MsgContext isn't referenced outside of there. This is actually changed as part of Mark's Form-auth POST-replay, not the Connector/Response buffering. Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments. In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector Connector.java Response.java
Bill Barker wrote: Doing a clean build of j-t-c/jk/java should fix it. MsgContext isn't referenced outside of there. I'm doing 'ant checkout ant'. This is actually changed as part of Mark's Form-auth POST-replay, not the Connector/Response buffering. OK. Will try the clean build. Thanks, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector Connector.java Response.java
billbarker2005/05/20 20:02:25
Modified:catalina/src/share/org/apache/catalina/connector
Connector.java Response.java
Log:
Reverting previous patch in favor of the better one submitted by JFC
Revision ChangesPath
1.20 +1 -5
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector/Connector.java
Index: Connector.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector/Connector.java,v
retrieving revision 1.19
retrieving revision 1.20
diff -u -r1.19 -r1.20
--- Connector.java20 May 2005 06:14:36 - 1.19
+++ Connector.java21 May 2005 03:02:25 - 1.20
@@ -899,10 +899,6 @@
Response response = new Response();
response.setConnector(this);
-if(AJP/1.3.equals(getProtocol())) {
-// we can't shrink it, so set to 2*max-ajp-packet-size
-response.setBufferSize(2*8184);
-}
return (response);
}
1.13 +12 -5
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector/Response.java
Index: Response.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector/Response.java,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- Response.java 25 Apr 2005 22:06:30 - 1.12
+++ Response.java 21 May 2005 03:02:25 - 1.13
@@ -125,6 +125,14 @@
*/
public void setConnector(Connector connector) {
this.connector = connector;
+if(AJP/1.3.equals(connector.getProtocol())) {
+// default size to size of one ajp-packet
+outputBuffer = new OutputBuffer(8184);
+} else {
+outputBuffer = new OutputBuffer();
+}
+outputStream = new CoyoteOutputStream(outputBuffer);
+writer = new CoyoteWriter(outputBuffer);
}
@@ -174,20 +182,19 @@
/**
* The associated output buffer.
*/
-protected OutputBuffer outputBuffer = new OutputBuffer();
+protected OutputBuffer outputBuffer;
/**
* The associated output stream.
*/
-protected CoyoteOutputStream outputStream =
-new CoyoteOutputStream(outputBuffer);
+protected CoyoteOutputStream outputStream;
/**
* The associated writer.
*/
-protected CoyoteWriter writer = new CoyoteWriter(outputBuffer);
+protected CoyoteWriter writer;
/**
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
