cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina Manager.java
yoavs 2004/05/26 08:28:21 Modified:catalina/src/share/org/apache/catalina Manager.java Log: Minor JavaDoc fixes (Bugzilla 11212) Revision ChangesPath 1.11 +2 -2 jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/Manager.java Index: Manager.java === RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/Manager.java,v retrieving revision 1.10 retrieving revision 1.11 diff -u -r1.10 -r1.11 --- Manager.java 11 May 2004 00:04:09 - 1.10 +++ Manager.java 26 May 2004 15:28:21 - 1.11 @@ -130,7 +130,7 @@ * Sets the session id length (in bytes) for Sessions created by this * Manager. * - * @param sessionIdLength The session id length + * @param idLength The session id length */ public void setSessionIdLength(int idLength); - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina Manager.java
luehe 2004/05/10 17:04:09 Modified:catalina/src/share/org/apache/catalina Manager.java Log: javadocs correction: getMaxActive() actually returns max number of sessions that have been active at the same time, as opposed to (StandardManager.)getMaxActiveSessions(), which returns the limit (or -1) Revision ChangesPath 1.10 +8 -8 jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/Manager.java Index: Manager.java === RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/Manager.java,v retrieving revision 1.9 retrieving revision 1.10 diff -u -r1.9 -r1.10 --- Manager.java 21 Apr 2004 23:37:07 - 1.9 +++ Manager.java 11 May 2004 00:04:09 - 1.10 @@ -152,20 +152,20 @@ /** - * Gets the maximum number of sessions that may be active at the same time. + * Gets the maximum number of sessions that have been active at the same + * time. * - * pIf this number has been reached, any requests for creating new - * sessions will be rejected. - * - * @return Maximum number of sessions that may be active at the same time + * @return Maximum number of sessions that have been active at the same + * time */ public int getMaxActive(); /** - * Sets the maximum number of sessions that may be active at the same time. + * (Re)sets the maximum number of sessions that have been active at the + * same time. * - * @param maxActive Maximum number of sessions that may be active at + * @param maxActive Maximum number of sessions that have been active at * the same time. */ public void setMaxActive(int maxActive); - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina Manager.java
[EMAIL PROTECTED] wrote: luehe 2004/04/21 16:37:07 Modified:catalina/src/share/org/apache/catalina Manager.java Log: Expose more of the session management methods at the top-level Manager interface This is not a good idea since: - it changes the API (ok, it likely won't break any existing impl) - AFAIK, the basic manager doesn't care about session expiration Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina Manager.java
Hi Remy, Remy Maucherat wrote: [EMAIL PROTECTED] wrote: luehe 2004/04/21 16:37:07 Modified:catalina/src/share/org/apache/catalina Manager.java Log: Expose more of the session management methods at the top-level Manager interface This is not a good idea since: - it changes the API (ok, it likely won't break any existing impl) - AFAIK, the basic manager doesn't care about session expiration the reason I wanted to expose these methods at the Manager level is that it makes using various session manager implementations more seamless, without having to cast to specific impl classes. Also, this will force future manager impls to use consistent method signatures and names (ie., use getExpiredSessions() vs. getExpired() or something like that). You're right that the basic manager does not care about expired sessions, but that's why it is abstract. If a particular manager impl does not care about expired sessions, they can simply return zero. ;-) Jan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina Manager.java
Jan Luehe wrote: the reason I wanted to expose these methods at the Manager level is that it makes using various session manager implementations more seamless, without having to cast to specific impl classes. Yes I agree. I was just poiting out the discrepancies that this change introduced with Craig's original design. Actually, the only real optimization that can be done in the next Tomcat, assuming the current architecture remains, is to remove all the redundant abstract types (interfaces and abstract classes) to optimize away any useless RTTI and casts (now that the architecture has been real world tested for a while, we know what is useful and what is not). Also, this will force future manager impls to use consistent method signatures and names (ie., use getExpiredSessions() vs. getExpired() or something like that). You're right that the basic manager does not care about expired sessions, but that's why it is abstract. If a particular manager impl does not care about expired sessions, they can simply return zero. ;-) Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina Manager.java
luehe 2004/04/21 16:37:07 Modified:catalina/src/share/org/apache/catalina Manager.java Log: Expose more of the session management methods at the top-level Manager interface Revision ChangesPath 1.9 +79 -1 jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/Manager.java Index: Manager.java === RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/Manager.java,v retrieving revision 1.8 retrieving revision 1.9 diff -u -r1.8 -r1.9 --- Manager.java 27 Feb 2004 14:58:38 - 1.8 +++ Manager.java 21 Apr 2004 23:37:07 - 1.9 @@ -135,6 +135,84 @@ public void setSessionIdLength(int idLength); +/** + * Returns the total number of sessions created by this manager. + * + * @return Total number of sessions created by this manager. + */ +public int getSessionCounter(); + + +/** + * Sets the total number of sessions created by this manager. + * + * @param sessionCounter Total number of sessions created by this manager. + */ +public void setSessionCounter(int sessionCounter); + + +/** + * Gets the maximum number of sessions that may be active at the same time. + * + * pIf this number has been reached, any requests for creating new + * sessions will be rejected. + * + * @return Maximum number of sessions that may be active at the same time + */ +public int getMaxActive(); + + +/** + * Sets the maximum number of sessions that may be active at the same time. + * + * @param maxActive Maximum number of sessions that may be active at + * the same time. + */ +public void setMaxActive(int maxActive); + + +/** + * Gets the number of currently active sessions. + * + * @return Number of currently active sessions + */ +public int getActiveSessions(); + + +/** + * Gets the number of sessions that have expired. + * + * @return Number of sessions that have expired + */ +public int getExpiredSessions(); + + +/** + * Sets the number of sessions that have expired. + * + * @param expiredSessions Number of sessions that have expired + */ +public void setExpiredSessions(int expiredSessions); + + +/** + * Gets the number of sessions that were not created because the maximum + * number of active sessions was reached. + * + * @return Number of rejected sessions + */ +public int getRejectedSessions(); + + +/** + * Sets the number of sessions that were not created because the maximum + * number of active sessions was reached. + * + * @param rejectedSessions Number of rejected sessions + */ +public void setRejectedSessions(int rejectedSessions); + + // - Public Methods - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
