cvs commit: jakarta-tomcat-connectors/jni/native configure.in

2005-08-02 Thread mturk 
mturk   2005/08/02 04:33:11

  Modified:jni/native configure.in
  Log:
  Link with libkstat for Solaris
  
  Revision  ChangesPath
  1.9   +9 -0  jakarta-tomcat-connectors/jni/native/configure.in
  
  Index: configure.in
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jni/native/configure.in,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- configure.in  23 Jun 2005 14:49:36 -  1.8
  +++ configure.in  2 Aug 2005 11:33:11 -   1.9
  @@ -150,6 +150,15 @@
   APR_ADDTO(TCNATIVE_LIBS, [$APR_LIBS])
   APR_ADDTO(TCNATIVE_LDFLAGS, [$LDFLAGS])
   
  +# Link libkstat for Solaris
  +case $host in
  +*-solaris2*)
  +APR_ADDTO(TCNATIVE_LIBS, -lkstat)
  +;;
  +*)
  +;;
  +esac
  +
   AC_SUBST(TCNATIVE_EXPORT_LIBS)
   AC_SUBST(TCNATIVE_PRIV_INCLUDES)
   AC_SUBST(TCNATIVE_INCLUDES)
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-connectors/jni/native configure.in

2005-06-23 Thread Mladen Turk 

[EMAIL PROTECTED] wrote:

jfclere 2005/06/21 03:31:41
  Log:
  -Wall is only for gcc.



That's true. But if your 'cc' doesn't support
the -Wall then make CFLASG with some platform
switch rather then interfering with 99% of others that are using gcc.
The -Wall is very valuable when dealing with compile warnings,
and that was the main reason what the --enable-maintainer-mode
was added at the first place. It makes no sense without.



  -CFLAGS=${CFLAGS} -DDEBUG -Wall
  +CFLAGS=${CFLAGS} -DDEBUG


I would prefer that you add some platform case/esac that will
in ReliantUnix case add what ever you wish to the CFLAGS.

Regards,
Mladen.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-connectors/jni/native configure.in

2005-06-23 Thread William A. Rowe, Jr. 
At 02:01 AM 6/23/2005, Mladen Turk wrote:
[EMAIL PROTECTED] wrote:
jfclere 2005/06/21 03:31:41
  Log:
  -Wall is only for gcc.

That's true. But if your 'cc' doesn't support
the -Wall then make CFLASG with some platform
switch rather then interfering with 99% of others that are using gcc.
The -Wall is very valuable when dealing with compile warnings,
and that was the main reason what the --enable-maintainer-mode
was added at the first place. It makes no sense without.


  -CFLAGS=${CFLAGS} -DDEBUG -Wall
  +CFLAGS=${CFLAGS} -DDEBUG

I would prefer that you add some platform case/esac that will
in ReliantUnix case add what ever you wish to the CFLAGS.

Conversely, a compiler case/esac would avoid altogether breaking
AIX, HP/UX, Reliant and a dozen other oddballs.  Forcing users to
play cflags is really a symptom of a weak build system.

Bill (Who's wasted untold hours fighting with auto linux-isms 
  lately and who has no humor left for penguins :)



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-connectors/jni/native configure.in

2005-06-23 Thread Mladen Turk 

William A. Rowe, Jr. wrote:

At 02:01 AM 6/23/2005, Mladen Turk wrote:




-CFLAGS=${CFLAGS} -DDEBUG -Wall
+CFLAGS=${CFLAGS} -DDEBUG


I would prefer that you add some platform case/esac that will
in ReliantUnix case add what ever you wish to the CFLAGS.



Conversely, a compiler case/esac would avoid altogether breaking
AIX, HP/UX, Reliant and a dozen other oddballs.  Forcing users to
play cflags is really a symptom of a weak build system.



Something simple like:

 
   if test $GCC = yes; then
 CFLAGS=${CFLAGS} -DDEBUG -Wall
   elif test $AIX_XLC = yes; then
 CFLAGS=${CFLAGS} -DDEBUG -qfullpath -qinitauto=FE -qcheck=all
   elif test $MYCOMPILER = yes; then
 CFLAGS=${CFLAGS} -DDEBUG my what ever flags
   else
 CFLAGS=${CFLAGS} -DDEBUG
   fi

Would do the trick ;)

Regards,
Mladen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-connectors/jni/native configure.in

2005-06-23 Thread jean-frederic clere 

Mladen Turk wrote:

William A. Rowe, Jr. wrote:


At 02:01 AM 6/23/2005, Mladen Turk wrote:




-CFLAGS=${CFLAGS} -DDEBUG -Wall
+CFLAGS=${CFLAGS} -DDEBUG



I would prefer that you add some platform case/esac that will
in ReliantUnix case add what ever you wish to the CFLAGS.




Conversely, a compiler case/esac would avoid altogether breaking
AIX, HP/UX, Reliant and a dozen other oddballs.  Forcing users to
play cflags is really a symptom of a weak build system.



Something simple like:

 
   if test $GCC = yes; then
 CFLAGS=${CFLAGS} -DDEBUG -Wall
   elif test $AIX_XLC = yes; then
 CFLAGS=${CFLAGS} -DDEBUG -qfullpath -qinitauto=FE -qcheck=all
   elif test $MYCOMPILER = yes; then
 CFLAGS=${CFLAGS} -DDEBUG my what ever flags
   else
 CFLAGS=${CFLAGS} -DDEBUG
   fi

Would do the trick ;)


Yep, even:
+++
 if test $GCC = yes; then
 CFLAGS=${CFLAGS} -DDEBUG -Wall
 else
 CFLAGS=${CFLAGS} -DDEBUG
 fi
+++
gets my +1.



Regards,
Mladen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-connectors/jni/native configure.in

2005-06-23 Thread mturk 
mturk   2005/06/23 07:49:36

  Modified:jni/native configure.in
  Log:
  Use -Wall for maintainer mode if GCC is used.
  
  Revision  ChangesPath
  1.8   +6 -6  jakarta-tomcat-connectors/jni/native/configure.in
  
  Index: configure.in
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jni/native/configure.in,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- configure.in  21 Jun 2005 10:31:41 -  1.7
  +++ configure.in  23 Jun 2005 14:49:36 -  1.8
  @@ -135,12 +135,12 @@
   maintainer-mode,
   [  --enable-maintainer-mode   Turn on debugging and compile time warnings],
   [
  -case ${enableval} in
  -y | Y | YES | yes | TRUE | true )
  -CFLAGS=${CFLAGS} -DDEBUG
  -AC_MSG_RESULT([...Enabling Maintainer mode...])
  -;;
  -esac
  +  if test $GCC = yes; then
  +CFLAGS=${CFLAGS} -DDEBUG -Wall
  +  else
  +CFLAGS=${CFLAGS} -DDEBUG
  +  fi  
  +AC_MSG_RESULT([...Enabling Maintainer mode...])
   ])
   
   dnl
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-connectors/jni/native configure.in

2005-06-21 Thread jean-frederic clere 

[EMAIL PROTECTED] wrote:

mturk   2005/06/18 06:04:42

  Modified:jni/native configure.in
  Log:
  Add --enable-maintainer-mode to the configure options, so that
  statistics gets compiled in when configure is called with that option.
  
  Revision  ChangesPath

  1.6   +20 -5 jakarta-tomcat-connectors/jni/native/configure.in
  
  Index: configure.in

  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jni/native/configure.in,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- configure.in  12 Jun 2005 06:10:13 -  1.5
  +++ configure.in  18 Jun 2005 13:04:42 -  1.6
  @@ -12,7 +12,7 @@
   sinclude(build/find_apr.m4)
   
   dnl Generate ./config.nice for reproducing runs of configure
  -dnl 
  +dnl

   APR_CONFIG_NICE(config.nice)
   
   dnl # Some initial steps for configuration.  We setup the default directory

  @@ -94,11 +94,11 @@
   AC_SUBST(JAVA_OS)
   
   APR_ADDTO(TCNATIVE_PRIV_INCLUDES,[-I$JAVA_HOME/include])
  -APR_ADDTO(TCNATIVE_PRIV_INCLUDES,[-I$JAVA_HOME/include/$JAVA_OS]) 
  +APR_ADDTO(TCNATIVE_PRIV_INCLUDES,[-I$JAVA_HOME/include/$JAVA_OS])
   
   dnl

   dnl Detect openssl toolkit installation
  -dnl 
  +dnl

   TCN_CHECK_SSL_TOOLKIT
   
   so_ext=$APR_SO_EXT

  @@ -113,7 +113,7 @@
   host_alias=`uname -s`
   case $host_alias in
   dnl ### BeOS requires that ALL symbols resolve at LINK time!
  -dnl ### 
  +dnl ###

   dnl ### So, if we're building on BeOS then we need to add in the
   dnl ### apr and expat libraries to the build or it'll die a truly 
horrible
   dnl ### death. We now use the apr-config tool to determine the correct
  @@ -128,6 +128,21 @@
   
   AC_SUBST(EXTRA_OS_LINK)
   
  +dnl CFLAGS for maintainer mode

  +dnl it also allows the CFLAGS environment variable.
  +CFLAGS=${CFLAGS}
  +AC_ARG_ENABLE(
  +maintainer-mode,
  +[  --enable-maintainer-mode   Turn on debugging and compile time warnings],
  +[
  +case ${enableval} in
  +y | Y | YES | yes | TRUE | true )
  +CFLAGS=${CFLAGS} -DDEBUG -Wall



-Wall will not wrong on every machine, for example on ReliantUnix:
+++
$ cc -Wall toto.c   -o toto
cc: [warning]:   CDR9977 invalid option '-Wall' ignored
+++


  +AC_MSG_RESULT([...Enabling Maintainer mode...])
  +;;
  +esac
  +])
  +
   dnl
   dnl Prep all the flags and stuff for compilation and export to other builds
   dnl
  @@ -178,7 +193,7 @@
   fi
   
   dnl
  -dnl everthing is done. 
  +dnl everthing is done.

   MAKEFILES=Makefile
   AC_OUTPUT([
   tcnative.pc
  
  
  


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-connectors/jni/native configure.in

2005-06-21 Thread Remy Maucherat 

jean-frederic clere wrote:

-Wall will not wrong on every machine, for example on ReliantUnix:
+++
$ cc -Wall toto.c   -o toto
cc: [warning]:   CDR9977 invalid option '-Wall' ignored
+++


Mladen is away for two days, so you won't get a reply right away.

Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-connectors/jni/native configure.in

2005-06-21 Thread jean-frederic clere 

Remy Maucherat wrote:

jean-frederic clere wrote:


-Wall will not wrong on every machine, for example on ReliantUnix:
+++
$ cc -Wall toto.c   -o toto
cc: [warning]:   CDR9977 invalid option '-Wall' ignored
+++



Mladen is away for two days, so you won't get a reply right away.


Ok, I will fix it.

Cheers

Jean-Frederic



Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-connectors/jni/native configure.in

2005-06-21 Thread jfclere 
jfclere 2005/06/21 03:31:41

  Modified:jni/native configure.in
  Log:
  -Wall is only for gcc.
  
  Revision  ChangesPath
  1.7   +1 -1  jakarta-tomcat-connectors/jni/native/configure.in
  
  Index: configure.in
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jni/native/configure.in,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- configure.in  18 Jun 2005 13:04:42 -  1.6
  +++ configure.in  21 Jun 2005 10:31:41 -  1.7
  @@ -137,7 +137,7 @@
   [
   case ${enableval} in
   y | Y | YES | yes | TRUE | true )
  -CFLAGS=${CFLAGS} -DDEBUG -Wall
  +CFLAGS=${CFLAGS} -DDEBUG
   AC_MSG_RESULT([...Enabling Maintainer mode...])
   ;;
   esac
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-connectors/jni/native configure.in

2005-06-18 Thread mturk 
mturk   2005/06/18 06:04:42

  Modified:jni/native configure.in
  Log:
  Add --enable-maintainer-mode to the configure options, so that
  statistics gets compiled in when configure is called with that option.
  
  Revision  ChangesPath
  1.6   +20 -5 jakarta-tomcat-connectors/jni/native/configure.in
  
  Index: configure.in
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jni/native/configure.in,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- configure.in  12 Jun 2005 06:10:13 -  1.5
  +++ configure.in  18 Jun 2005 13:04:42 -  1.6
  @@ -12,7 +12,7 @@
   sinclude(build/find_apr.m4)
   
   dnl Generate ./config.nice for reproducing runs of configure
  -dnl 
  +dnl
   APR_CONFIG_NICE(config.nice)
   
   dnl # Some initial steps for configuration.  We setup the default directory
  @@ -94,11 +94,11 @@
   AC_SUBST(JAVA_OS)
   
   APR_ADDTO(TCNATIVE_PRIV_INCLUDES,[-I$JAVA_HOME/include])
  -APR_ADDTO(TCNATIVE_PRIV_INCLUDES,[-I$JAVA_HOME/include/$JAVA_OS]) 
  +APR_ADDTO(TCNATIVE_PRIV_INCLUDES,[-I$JAVA_HOME/include/$JAVA_OS])
   
   dnl
   dnl Detect openssl toolkit installation
  -dnl 
  +dnl
   TCN_CHECK_SSL_TOOLKIT
   
   so_ext=$APR_SO_EXT
  @@ -113,7 +113,7 @@
   host_alias=`uname -s`
   case $host_alias in
   dnl ### BeOS requires that ALL symbols resolve at LINK time!
  -dnl ### 
  +dnl ###
   dnl ### So, if we're building on BeOS then we need to add in the
   dnl ### apr and expat libraries to the build or it'll die a truly 
horrible
   dnl ### death. We now use the apr-config tool to determine the correct
  @@ -128,6 +128,21 @@
   
   AC_SUBST(EXTRA_OS_LINK)
   
  +dnl CFLAGS for maintainer mode
  +dnl it also allows the CFLAGS environment variable.
  +CFLAGS=${CFLAGS}
  +AC_ARG_ENABLE(
  +maintainer-mode,
  +[  --enable-maintainer-mode   Turn on debugging and compile time warnings],
  +[
  +case ${enableval} in
  +y | Y | YES | yes | TRUE | true )
  +CFLAGS=${CFLAGS} -DDEBUG -Wall
  +AC_MSG_RESULT([...Enabling Maintainer mode...])
  +;;
  +esac
  +])
  +
   dnl
   dnl Prep all the flags and stuff for compilation and export to other builds
   dnl
  @@ -178,7 +193,7 @@
   fi
   
   dnl
  -dnl everthing is done. 
  +dnl everthing is done.
   MAKEFILES=Makefile
   AC_OUTPUT([
   tcnative.pc
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]