Re: [PATCH] RE: mod_webapp and other connectors status...

2002-01-09 Thread jean-frederic clere

Martin van den Bemt wrote:
 
 I tried the latest mod_webapp (build from jakarta-tomcat-connectors, head
 branch) and starting up apache before tomcat still gives the error
 Web-aplication not yet deployed (in wa_request.c).
 I thought : what the hack, let's fix this ;)

Great the patch looks  very easy... Checking the result of calling wa_startup()
more than once will take a while.

I am worried by the following (in warp_handle):
+++
/* Check application */
if (((int)(appl-conf))==-1)
return(wa_rerror(WA_MARK,r,404,Application not deployed));
+++

I have already checked that it has no impact on TC (On Already deployed
applications).

 Attached the diff to the current cvs version of wa_request
 Please look at it carefully, because I don't have a clue what I really did,
 so it could mean a lot of memory leaks or bad programming (let's say it's
 bin a while I did c and this is the first time I looked at the source,so..)
 
 Hope it is usefull (for me it is for now btw..)
 
 Mvgr,
 Martin
 
 PS My first patch, and not even a java one ;)
 
 -Original Message-
 From: [EMAIL PROTECTED]
 [mailto:[EMAIL PROTECTED]]On Behalf Of jean-frederic clere
 Sent: Tuesday, January 08, 2002 15:11
 To: Tomcat Developers List
 Subject: Re: mod_webapp and other connectors status...
 
 Martin van den Bemt wrote:
 
  Hi everyone,
 
  I probably missed a couple of threads on mod_webapp, so forgive me ;)
 
  In the release notes of v4.0.2-b1 it states :
 
  * If you restart Tomcat, you must also restart Apache to avoid receiving
Error 400 - Bad Request errors.  This will be handled transparently
in the final release.
 
  Is this dependend on the return of Pier, or is someone else working on
 this
  already ?
 
 I think it is fixed.
 
  And if second applies : Is the mod_webapp code integrated into the tomcat
 4
  cvs already or do I have to get the latest from cvs ?
 
 In jakarta-tomcat-connectors.
 
 
  Also I saw a lot of commits come by for ajp (i think the new ajp14??). Can
 I
  be of any testing assistance in that area ?
 
  I am using tomcat 4 (also have the cvs version of tomcat 3.3 running) and
  both apache 1.3 and apache 2 running on  redhat 7.1 linux boxes.
  I also depend heavily on virtual hosting, so that is the main reason I
 want
  to test this.. (restarting tomcat, without restarting apache and
 everything
  keeps on running ;).
 
  If there are any specific points you want to be tested, just mail me and I
  let you know (have an almost clean server on the internet right, which for
  now hasn't any production stuff on there...
 
  Mvgr,
  Martin van den Bemt
 
  --
  To unsubscribe, e-mail:
 mailto:[EMAIL PROTECTED]
  For additional commands, e-mail:
 mailto:[EMAIL PROTECTED]
 
 --
 To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
 For additional commands, e-mail: mailto:[EMAIL PROTECTED]
 
   
Name: wa_request.patch
wa_request.patchType: unspecified type (application/octet-stream)
Encoding: quoted-printable
 
   
 --
 To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
 For additional commands, e-mail: mailto:[EMAIL PROTECTED]

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Re: [PATCH] RE: mod_webapp and other connectors status...

2002-01-09 Thread jean-frederic clere

Martin van den Bemt wrote:
 
 I tried the latest mod_webapp (build from jakarta-tomcat-connectors, head
 branch) and starting up apache before tomcat still gives the error
 Web-aplication not yet deployed (in wa_request.c).
 I thought : what the hack, let's fix this ;)
 Attached the diff to the current cvs version of wa_request
 Please look at it carefully, because I don't have a clue what I really did,
 so it could mean a lot of memory leaks or bad programming (let's say it's
 bin a while I did c and this is the first time I looked at the source,so..)
 
 Hope it is usefull (for me it is for now btw..)

I have committed it - Many thanks -

 
 Mvgr,
 Martin
 
 PS My first patch, and not even a java one ;)
 
 -Original Message-
 From: [EMAIL PROTECTED]
 [mailto:[EMAIL PROTECTED]]On Behalf Of jean-frederic clere
 Sent: Tuesday, January 08, 2002 15:11
 To: Tomcat Developers List
 Subject: Re: mod_webapp and other connectors status...
 
 Martin van den Bemt wrote:
 
  Hi everyone,
 
  I probably missed a couple of threads on mod_webapp, so forgive me ;)
 
  In the release notes of v4.0.2-b1 it states :
 
  * If you restart Tomcat, you must also restart Apache to avoid receiving
Error 400 - Bad Request errors.  This will be handled transparently
in the final release.
 
  Is this dependend on the return of Pier, or is someone else working on
 this
  already ?
 
 I think it is fixed.
 
  And if second applies : Is the mod_webapp code integrated into the tomcat
 4
  cvs already or do I have to get the latest from cvs ?
 
 In jakarta-tomcat-connectors.
 
 
  Also I saw a lot of commits come by for ajp (i think the new ajp14??). Can
 I
  be of any testing assistance in that area ?
 
  I am using tomcat 4 (also have the cvs version of tomcat 3.3 running) and
  both apache 1.3 and apache 2 running on  redhat 7.1 linux boxes.
  I also depend heavily on virtual hosting, so that is the main reason I
 want
  to test this.. (restarting tomcat, without restarting apache and
 everything
  keeps on running ;).
 
  If there are any specific points you want to be tested, just mail me and I
  let you know (have an almost clean server on the internet right, which for
  now hasn't any production stuff on there...
 
  Mvgr,
  Martin van den Bemt
 
  --
  To unsubscribe, e-mail:
 mailto:[EMAIL PROTECTED]
  For additional commands, e-mail:
 mailto:[EMAIL PROTECTED]
 
 --
 To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
 For additional commands, e-mail: mailto:[EMAIL PROTECTED]
 
   
Name: wa_request.patch
wa_request.patchType: unspecified type (application/octet-stream)
Encoding: quoted-printable

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




RE: [PATCH] RE: mod_webapp and other connectors status...

2002-01-09 Thread Martin van den Bemt

I found an issue I think..
When you stop an webapplication, the application comes available again
through webapp (I tried to stop tomcat-docs and it was still reachable by
mod_webapp.so), so I think it needs some tweaking..

Mvgr,
martin

-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On
Behalf Of jean-frederic clere
Sent: Wednesday, January 09, 2002 11:25
To: Tomcat Developers List
Subject: Re: [PATCH] RE: mod_webapp and other connectors status...


Martin van den Bemt wrote:

 I tried the latest mod_webapp (build from jakarta-tomcat-connectors, head
 branch) and starting up apache before tomcat still gives the error
 Web-aplication not yet deployed (in wa_request.c).
 I thought : what the hack, let's fix this ;)

Great the patch looks  very easy... Checking the result of calling
wa_startup()
more than once will take a while.

I am worried by the following (in warp_handle):
+++
/* Check application */
if (((int)(appl-conf))==-1)
return(wa_rerror(WA_MARK,r,404,Application not deployed));
+++

I have already checked that it has no impact on TC (On Already deployed
applications).

 Attached the diff to the current cvs version of wa_request
 Please look at it carefully, because I don't have a clue what I really
did,
 so it could mean a lot of memory leaks or bad programming (let's say it's
 bin a while I did c and this is the first time I looked at the
source,so..)

 Hope it is usefull (for me it is for now btw..)

 Mvgr,
 Martin

 PS My first patch, and not even a java one ;)

 -Original Message-
 From: [EMAIL PROTECTED]
 [mailto:[EMAIL PROTECTED]]On Behalf Of jean-frederic clere
 Sent: Tuesday, January 08, 2002 15:11
 To: Tomcat Developers List
 Subject: Re: mod_webapp and other connectors status...

 Martin van den Bemt wrote:
 
  Hi everyone,
 
  I probably missed a couple of threads on mod_webapp, so forgive me ;)
 
  In the release notes of v4.0.2-b1 it states :
 
  * If you restart Tomcat, you must also restart Apache to avoid receiving
Error 400 - Bad Request errors.  This will be handled transparently
in the final release.
 
  Is this dependend on the return of Pier, or is someone else working on
 this
  already ?

 I think it is fixed.

  And if second applies : Is the mod_webapp code integrated into the
tomcat
 4
  cvs already or do I have to get the latest from cvs ?

 In jakarta-tomcat-connectors.

 
  Also I saw a lot of commits come by for ajp (i think the new ajp14??).
Can
 I
  be of any testing assistance in that area ?
 
  I am using tomcat 4 (also have the cvs version of tomcat 3.3 running)
and
  both apache 1.3 and apache 2 running on  redhat 7.1 linux boxes.
  I also depend heavily on virtual hosting, so that is the main reason I
 want
  to test this.. (restarting tomcat, without restarting apache and
 everything
  keeps on running ;).
 
  If there are any specific points you want to be tested, just mail me and
I
  let you know (have an almost clean server on the internet right, which
for
  now hasn't any production stuff on there...
 
  Mvgr,
  Martin van den Bemt
 
  --
  To unsubscribe, e-mail:
 mailto:[EMAIL PROTECTED]
  For additional commands, e-mail:
 mailto:[EMAIL PROTECTED]

 --
 To unsubscribe, e-mail:
mailto:[EMAIL PROTECTED]
 For additional commands, e-mail:
mailto:[EMAIL PROTECTED]

   

Name: wa_request.patch
wa_request.patchType: unspecified type (application/octet-stream)
Encoding: quoted-printable

   

 --
 To unsubscribe, e-mail:
mailto:[EMAIL PROTECTED]
 For additional commands, e-mail:
mailto:[EMAIL PROTECTED]

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]



--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Re: mod_webapp and other connectors status...

2002-01-09 Thread Daniel Rall

GOMEZ Henri [EMAIL PROTECTED] writes:

 BTW: How did we get TOMCAT 4.1 and 4.0.2 ? Which is the head ?

I believe that 4.1-dev is the tip of the HEAD, 4.0.2-dev is the tip of
tomcat_40_branch.

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Re: mod_webapp and other connectors status...

2002-01-09 Thread Craig R. McClanahan



On Wed, 9 Jan 2002, Daniel Rall wrote:

 Date: Wed, 09 Jan 2002 15:23:54 -0800
 From: Daniel Rall [EMAIL PROTECTED]
 Reply-To: Tomcat Developers List [EMAIL PROTECTED]
 To: Tomcat Developers List [EMAIL PROTECTED]
 Subject: Re: mod_webapp and other connectors status...

 GOMEZ Henri [EMAIL PROTECTED] writes:

  BTW: How did we get TOMCAT 4.1 and 4.0.2 ? Which is the head ?

 I believe that 4.1-dev is the tip of the HEAD, 4.0.2-dev is the tip of
 tomcat_40_branch.


That's correct.

Currently I'm only building nightly distributions from the HEAD branch,
but it would be fairly straightforward to do nightly builds of the 4.0
branch as well.

Craig


--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Re: mod_webapp and other connectors status...

2002-01-09 Thread Daniel Rall

Craig R. McClanahan [EMAIL PROTECTED] writes:

 I believe that 4.1-dev is the tip of the HEAD, 4.0.2-dev is the tip of
 tomcat_40_branch.

 That's correct.

 Currently I'm only building nightly distributions from the HEAD branch,
 but it would be fairly straightforward to do nightly builds of the 4.0
 branch as well.

I'm currently using nightlies from the HEAD and am running into some
SAX parser class loading issues (ClassCastExceptions due to classes
coming from different loaders).  Have their been any significant
changes to class loading in HEAD which are not in tomcat_40_branch?

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Re: mod_webapp and other connectors status...

2002-01-08 Thread jean-frederic clere

Martin van den Bemt wrote:
 
 Hi everyone,
 
 I probably missed a couple of threads on mod_webapp, so forgive me ;)
 
 In the release notes of v4.0.2-b1 it states :
 
 * If you restart Tomcat, you must also restart Apache to avoid receiving
   Error 400 - Bad Request errors.  This will be handled transparently
   in the final release.
 
 Is this dependend on the return of Pier, or is someone else working on this
 already ?

I think it is fixed.

 And if second applies : Is the mod_webapp code integrated into the tomcat 4
 cvs already or do I have to get the latest from cvs ?

In jakarta-tomcat-connectors.

 
 Also I saw a lot of commits come by for ajp (i think the new ajp14??). Can I
 be of any testing assistance in that area ?
 
 I am using tomcat 4 (also have the cvs version of tomcat 3.3 running) and
 both apache 1.3 and apache 2 running on  redhat 7.1 linux boxes.
 I also depend heavily on virtual hosting, so that is the main reason I want
 to test this.. (restarting tomcat, without restarting apache and everything
 keeps on running ;).
 
 If there are any specific points you want to be tested, just mail me and I
 let you know (have an almost clean server on the internet right, which for
 now hasn't any production stuff on there...
 
 Mvgr,
 Martin van den Bemt
 
 --
 To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
 For additional commands, e-mail: mailto:[EMAIL PROTECTED]

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




RE: mod_webapp and other connectors status...

2002-01-08 Thread GOMEZ Henri

Hi to all and Happy new year.

Slowly back to mail after hollidays ,(

 - the stable jk1.x. We want to release it and it needs 
testing - the code
 is very close to what was released with 4.0.1 and 3.3, with 
few additional
 bug fixes, with the auto-conf generator for 4.x ( the code is there,
 but hasn't been tested too much ).

I'm been using 1.2.0 on my systems for months. Seems OK.

There was a bug in 1.2.0 (jtc) with post mode 
(search for messages about pmsg), corrected by Kevin Seguin 



You're right, the code is correct in tomcat 3.3 mod_jk
and conform with the latest patch I submitted in this branch.
The error was introduced in the J-T-C port

/* the right place to add file storage for upload */
if((len = read_into_msg_buff(ep, r, pmsg, l, len)) = 0) {
r-content_read += len;
return JK_AJP13_HAS_RESPONSE;


BTW: How did we get TOMCAT 4.1 and 4.0.2 ? Which is the head ?

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




[PATCH] RE: mod_webapp and other connectors status...

2002-01-08 Thread Martin van den Bemt

I tried the latest mod_webapp (build from jakarta-tomcat-connectors, head
branch) and starting up apache before tomcat still gives the error
Web-aplication not yet deployed (in wa_request.c).
I thought : what the hack, let's fix this ;)
Attached the diff to the current cvs version of wa_request
Please look at it carefully, because I don't have a clue what I really did,
so it could mean a lot of memory leaks or bad programming (let's say it's
bin a while I did c and this is the first time I looked at the source,so..)

Hope it is usefull (for me it is for now btw..)

Mvgr,
Martin

PS My first patch, and not even a java one ;)


-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED]]On Behalf Of jean-frederic clere
Sent: Tuesday, January 08, 2002 15:11
To: Tomcat Developers List
Subject: Re: mod_webapp and other connectors status...


Martin van den Bemt wrote:

 Hi everyone,

 I probably missed a couple of threads on mod_webapp, so forgive me ;)

 In the release notes of v4.0.2-b1 it states :

 * If you restart Tomcat, you must also restart Apache to avoid receiving
   Error 400 - Bad Request errors.  This will be handled transparently
   in the final release.

 Is this dependend on the return of Pier, or is someone else working on
this
 already ?

I think it is fixed.

 And if second applies : Is the mod_webapp code integrated into the tomcat
4
 cvs already or do I have to get the latest from cvs ?

In jakarta-tomcat-connectors.


 Also I saw a lot of commits come by for ajp (i think the new ajp14??). Can
I
 be of any testing assistance in that area ?

 I am using tomcat 4 (also have the cvs version of tomcat 3.3 running) and
 both apache 1.3 and apache 2 running on  redhat 7.1 linux boxes.
 I also depend heavily on virtual hosting, so that is the main reason I
want
 to test this.. (restarting tomcat, without restarting apache and
everything
 keeps on running ;).

 If there are any specific points you want to be tested, just mail me and I
 let you know (have an almost clean server on the internet right, which for
 now hasn't any production stuff on there...

 Mvgr,
 Martin van den Bemt

 --
 To unsubscribe, e-mail:
mailto:[EMAIL PROTECTED]
 For additional commands, e-mail:
mailto:[EMAIL PROTECTED]

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




wa_request.patch
Description: Binary data

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]


Re: mod_webapp and other connectors status...

2002-01-08 Thread Bojan Smojver

GOMEZ Henri wrote:


I'm been using 1.2.0 on my systems for months. Seems OK.

 
 There was a bug in 1.2.0 (jtc) with post mode 
 (search for messages about pmsg), corrected by Kevin Seguin 
 
 
 
 You're right, the code is correct in tomcat 3.3 mod_jk
 and conform with the latest patch I submitted in this branch.
 The error was introduced in the J-T-C port
 
   /* the right place to add file storage for upload */
   if((len = read_into_msg_buff(ep, r, pmsg, l, len)) = 0) {
   r-content_read += len;
   return JK_AJP13_HAS_RESPONSE;


It must be that I never had more then 8k of data being passed back to 
the server (lucky me :-) and therefore mod_jk 1.2.0 worked fine for me. 
But I'm now on the CVS version, in which all this is fixed, so it should 
be fine.


Thanks for your help. Glad you're back!


Bojan




--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




mod_webapp and other connectors status...

2002-01-07 Thread Martin van den Bemt

Hi everyone,

I probably missed a couple of threads on mod_webapp, so forgive me ;)

In the release notes of v4.0.2-b1 it states :

* If you restart Tomcat, you must also restart Apache to avoid receiving
  Error 400 - Bad Request errors.  This will be handled transparently
  in the final release.

Is this dependend on the return of Pier, or is someone else working on this
already ?
And if second applies : Is the mod_webapp code integrated into the tomcat 4
cvs already or do I have to get the latest from cvs ?

Also I saw a lot of commits come by for ajp (i think the new ajp14??). Can I
be of any testing assistance in that area ?

I am using tomcat 4 (also have the cvs version of tomcat 3.3 running) and
both apache 1.3 and apache 2 running on  redhat 7.1 linux boxes.
I also depend heavily on virtual hosting, so that is the main reason I want
to test this.. (restarting tomcat, without restarting apache and everything
keeps on running ;).

If there are any specific points you want to be tested, just mail me and I
let you know (have an almost clean server on the internet right, which for
now hasn't any production stuff on there...

Mvgr,
Martin van den Bemt


--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Re: mod_webapp and other connectors status...

2002-01-07 Thread costinm

On Mon, 7 Jan 2002, Martin van den Bemt wrote:

 * If you restart Tomcat, you must also restart Apache to avoid receiving
   Error 400 - Bad Request errors.  This will be handled transparently
   in the final release.

This should work fine with jk. We don't support yet 'gracefull'
restart for tomcat workers in lb case, i.e. have apache send only
requests for existing sessions until they expire - this is planned
for jk2.

 Also I saw a lot of commits come by for ajp (i think the new ajp14??). Can I
 be of any testing assistance in that area ?

There are 2 efforts going on:
- the stable jk1.x. We want to release it and it needs testing - the code
is very close to what was released with 4.0.1 and 3.3, with few additional
bug fixes, with the auto-conf generator for 4.x ( the code is there,
but hasn't been tested too much ).

- the new jk2. Things are getting into the right shape, it'll have
few major changes. Right now only apache2.0 adapter is written,
1.3 is easy and iis/nes will follow after everything is stable.
Among the changes - use Location for configuring the mapping
( and the native vhost/location url mapping ), no need for
workers.properties, unix domain sockets where possible
( i.e. better performance ), the java side has been optimized
( char-byte conversion, recycling, etc), more extensibility
and support for multiple protocols/transports. Also we'll
probably have a 'status' page and few more improvements in
lb ( I want to try the 'gracefull' shutdown - if I have time and
nobody does it first ). ( that's coupled with the status/control
worker, which would allow to dynamicly add/remove workers
and get status info )

For jk2 - testing would be good, but coding will be even better
at this stage. I think I'm mostly done with the 'big' refactoring
changes, but I need feedback and review of the new internal interfaces.
( and possible chaneges/enhancements/fixes )

I hope in few days to get it to work so more people can play with it, now
it's a bit challenging, it still have many hardcoded paths, the unix
socket is hardcoded too, etc. But I've got the 'hello world' servlet
working, so it's close :-)

Costin


--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Re: mod_webapp and other connectors status...

2002-01-07 Thread Bojan Smojver

[EMAIL PROTECTED] wrote:


 - the stable jk1.x. We want to release it and it needs testing - the code
 is very close to what was released with 4.0.1 and 3.3, with few additional
 bug fixes, with the auto-conf generator for 4.x ( the code is there,
 but hasn't been tested too much ).

I'm been using 1.2.0 on my systems for months. Seems OK.

Bojan


--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]