submitting a patch
I have found a bug and fixed it in the Tomcat NT service program. How do I submit it? Do you guys take bug fixes from independent people. I had heard from several people that they had submitted bug fixes and you guys told them to f*** off (not necessarily in those terms). __ Do You Yahoo!? Yahoo! Auctions - buy the things you want at great prices http://auctions.yahoo.com/
Re: submitting a patch
Ryan Smith wrote: I have found a bug and fixed it in the Tomcat NT service program. How do I submit it? Do you guys take bug fixes from independent people. I had heard from several people that they had submitted bug fixes and you guys told them to f*** off (not necessarily in those terms). f*** off. sorry, i couldn't resist :) read http://jakarta.apache.org/site/getinvolved.html.
RE: submitting a patch
I have found a bug and fixed it in the Tomcat NT service program. How do I submit it? Do you guys take bug fixes from independent people. I had heard from several people that they had submitted bug fixes and you guys told them to f*** off (not necessarily in those terms). Let's send the diff (mod_jk / nt_service ?) and we'll discuss the patches on the dev list. It's an Open-Source project and contributions are allways welcome. :)
RE: submitting a patch
The guidelines for getting involved in Jakarta projects is described at http://jakarta.apache.org/site/getinvolved.html Submit the patches to the tomcat-dev mailing list and also please create bug report in the bug tracking system and attach your patches there, too. Given the volume of email here, it is too easy for things to slip through the cracks. Sometimes patches won't make it in right away. For example the Tomcat 3.2.2 release if very close to final release. The only things that might go into that code base right now are fixes to show stopper bugs. Once the release is out that code base will be opened up for fixes to less critical bugs. Submitting a bug report will make sure that the fix doesn't get dropped between releases. Keep in mind that this is a volunteer organization and we all have day jobs in addition to working on Tomcat. Sometimes we don't get to things as quickly as we might like, but I don't think we've told anyone to go away. -Original Message- From: Ryan Smith [mailto:[EMAIL PROTECTED]] Sent: Thursday, May 17, 2001 10:13 AM To: [EMAIL PROTECTED] Subject: submitting a patch I have found a bug and fixed it in the Tomcat NT service program. How do I submit it? Do you guys take bug fixes from independent people. I had heard from several people that they had submitted bug fixes and you guys told them to f*** off (not necessarily in those terms). __ Do You Yahoo!? Yahoo! Auctions - buy the things you want at great prices http://auctions.yahoo.com/
Re: submitting a patch
I can hear it coming, so let me try and head it off. Having just recently gone through this same kind of thing on a different (non-Apache) dev list, I can sympathize with this question and applaud it's honesty. So please try and spare the flames. In answer to your question, Ryan, Tomcat accepts patches from anyone willing to help out. Patches should be a unified diff and attached to an e-mail (rather than included in your mail inline). More info is available at jakarta.apache.org/site/getinvolved.html. Most complaints I have seen regarding patches being accepted is a lack of timely feedback to the submitter. Most patches do not simply get ignored. Rather, the list can sometimes be a little slow in reviewing and commenting on patches, depending on the severity of the problem being addressed. In most cases this is simply due to the fact many of the core developers are overworked :-) So please feel free to contribute as much as possible. For all of the legendary flame wars on this list, there are actually only a few tactless and socially-inept people on the list. If you stick around for any length of time at all, you'll find out rather quickly who they are. Most developers here, however, are quite pleasant and will explain any potentional problems with a patch in a polite and professional manner. - Christopher Ryan Smith wrote: I have found a bug and fixed it in the Tomcat NT service program. How do I submit it? Do you guys take bug fixes from independent people. I had heard from several people that they had submitted bug fixes and you guys told them to f*** off (not necessarily in those terms). __ Do You Yahoo!? Yahoo! Auctions - buy the things you want at great prices http://auctions.yahoo.com/