Re: [tor-bugs] #17687 [Tor]: crypto_strongest_rand() failures should be fatal(?)

2015-12-22 Thread Tor Bug Tracker & Wiki
#17687: crypto_strongest_rand() failures should be fatal(?)
-+
 Reporter:  yawning  |  Owner:  yawning
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.2.8.x-final
Component:  Tor  |Version:  Tor: unspecified
 Severity:  Normal   | Resolution:
 Keywords:  crypto tor-core  |  Actual Points:
Parent ID:   | Points:
  Sponsor:   |
-+

Comment (by nickm):

 This was fixed when we merged #17694.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #17602 [Tor]: 'HidServDirectoryV2 0' not disabling HSDir

2015-12-22 Thread Tor Bug Tracker & Wiki
#17602: 'HidServDirectoryV2 0' not disabling HSDir
---+
 Reporter:  seeess |  Owner:
 Type:  defect | Status:  closed
 Priority:  Very Low   |  Milestone:  Tor: 0.2.8.x-final
Component:  Tor|Version:  Tor: 0.2.7.4-rc
 Severity:  Minor  | Resolution:  not a bug
 Keywords:  easy docs  |  Actual Points:
Parent ID: | Points:
  Sponsor: |
---+
Changes (by nickm):

 * status:  new => closed
 * resolution:   => not a bug


Comment:

 HidServDirectoryV2 has been deleted from the manpage a while ago.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #17197 [Tor]: Use CRLF for all text files written on Windows, accept either CRLF or LF on all platforms

2015-12-22 Thread Tor Bug Tracker & Wiki
#17197: Use CRLF for all text files written on Windows, accept either CRLF or 
LF on
all platforms
+
 Reporter:  teor|  Owner:
 Type:  defect  | Status:  new
 Priority:  Low |  Milestone:  Tor: 0.2.8.x-final
Component:  Tor |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  medium
  Sponsor:  |
+
Changes (by nickm):

 * severity:   => Normal


Comment:

 This isn't completely trivial -- for some of these, we want to be able to
 mmap them.  For most, we need byte-by-byte accuracy so that signature
 checking and digest computations work out right.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


[tor-bugs] [Tor Bug Tracker & Wiki] Batch modify: #11542, #9957, #10817, #11145, #11146, #17170, #15380, #13078, #925, #15521, #16070, #16822, #17120, #17197, #17623, #15661, #17665

2015-12-22 Thread Tor Bug Tracker & Wiki
Batch modification to #11542, #9957, #10817, #11145, #11146, #17170, #15380, 
#13078, #925, #15521, #16070, #16822, #17120, #17197, #17623, #15661, #17665 by 
nickm:
milestone to Tor: 0.2.???

Comment:
Move a bunch of (but not all) low-priority items to 0.2.???.  If you write a 
patch, it can still get into 0.2.8

--
Tickets URL: 

Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #17799 [Tor]: Hash All PRNG output before use

2015-12-22 Thread Tor Bug Tracker & Wiki
#17799: Hash All PRNG output before use
+
 Reporter:  teor|  Owner:
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.2.8.x-final
Component:  Tor |Version:  Tor: unspecified
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:
  Sponsor:  |
+
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 I made a couple more changes to shake_prng_v2.  Notably the pointer
 arithmetic is much simpler.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


[tor-bugs] #17920 [Tor]: Release 0.2.8.1-alpha

2015-12-22 Thread Tor Bug Tracker & Wiki
#17920: Release 0.2.8.1-alpha
+
 Reporter:  nickm   |  Owner:
 Type:  task| Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.2.8.x-final
Component:  Tor |Version:
 Severity:  Normal  |   Keywords:  TorCoreTeam201601
Actual Points:  |  Parent ID:
   Points:  |Sponsor:
+


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #17799 [Tor]: Hash All PRNG output before use

2015-12-22 Thread Tor Bug Tracker & Wiki
#17799: Hash All PRNG output before use
+
 Reporter:  teor|  Owner:
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.2.8.x-final
Component:  Tor |Version:  Tor: unspecified
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:
  Sponsor:  |
+

Comment (by nickm):

 Rebased and squashed as shake_prng_v3.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #17843 [Tor]: Confusing double-quotes in config parse failure message

2015-12-22 Thread Tor Bug Tracker & Wiki
#17843: Confusing double-quotes in config parse failure message
+
 Reporter:  arma|  Owner:
 Type:  defect  | Status:  closed
 Priority:  Low |  Milestone:  Tor: 0.2.8.x-final
Component:  Tor |Version:
 Severity:  Minor   | Resolution:  fixed
 Keywords:  easy|  Actual Points:
Parent ID:  | Points:
  Sponsor:  |
+
Changes (by nickm):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Fixed in 45f5e597517abedbf9d650428ac53f03f37089d8

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


[tor-bugs] #17921 [Tor]: OPENSSL_V_SERIES(1, 1, 0) compat guard macro borks LibreSSL

2015-12-22 Thread Tor Bug Tracker & Wiki
#17921: OPENSSL_V_SERIES(1,1,0) compat guard macro borks LibreSSL
-+
 Reporter:  cypherpunks  |  Owner:
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.2.8.x-final
Component:  Tor  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |Sponsor:
-+
 Since LibreSSL didn't adapt the whole 'rename everything' policy, it still
 uses the old names.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #17830 [metrics-lib]: use StringBuilder correctly

2015-12-22 Thread Tor Bug Tracker & Wiki
#17830: use StringBuilder correctly
-+--
 Reporter:  iwakeh   |  Owner:  karsten
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  metrics-lib  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #17822   | Points:
  Sponsor:   |
-+--

Comment (by iwakeh):

 this revision looks fine, see #17824 for more.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #17823 [metrics-lib]: use diamond operator

2015-12-22 Thread Tor Bug Tracker & Wiki
#17823: use diamond operator
-+--
 Reporter:  iwakeh   |  Owner:  karsten
 Type:  enhancement  | Status:  needs_review
 Priority:  Low  |  Milestone:
Component:  metrics-lib  |Version:
 Severity:  Minor| Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #17822   | Points:
  Sponsor:   |
-+--

Comment (by iwakeh):

 this revision looks fine, see #17824 for more.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #17919 [Onionoo]: Document history objects better (was: Implement "example request" for history object in documentation of Onionoo)

2015-12-22 Thread Tor Bug Tracker & Wiki
#17919: Document history objects better
---+---
 Reporter:  seansaito  |  Owner:  karsten
 Type:  task   | Status:  needs_information
 Priority:  Medium |  Milestone:
Component:  Onionoo|Version:
 Severity:  Normal | Resolution:
 Keywords:  documentation  |  Actual Points:
Parent ID: | Points:
  Sponsor: |
---+---
Changes (by karsten):

 * status:  new => needs_information


Comment:

 Hi seansaito,

 Replying to [ticket:17919 seansaito]:
 > * Can I query the history object for individual relays?

 Ah, no.  History objects are part of other documents, like the bandwidth
 document.

 > * What data does a history object contain?

 A history object contains graph data, which can be anything from written
 bytes over consensus weights to uptime.

 > * How far back does a history object go?

 5 years is the upper limit, though we could extend that to 10 or 15 years
 if needed in the future.  But for now, 5 years.

 Would you want to take a look at the various history objects contained in
 the different document types and then suggest how we might be able to
 document this part better in the spec?

 All the best,
 Karsten

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #17824 [metrics-lib]: switch on string instead of many if-else with String comparison

2015-12-22 Thread Tor Bug Tracker & Wiki
#17824: switch on string instead of many if-else with String comparison
-+--
 Reporter:  iwakeh   |  Owner:  karsten
 Type:  enhancement  | Status:  needs_review
 Priority:  Low  |  Milestone:
Component:  metrics-lib  |Version:
 Severity:  Minor| Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #17822   | Points:
  Sponsor:   |
-+--

Comment (by iwakeh):

 Thanks for making all these changes!

 I found some more places where I find the switch-statement more readable
 and attached a patch based on your public repo.

 Please review and if there is a problem it would be great to add a test
 that the patch fails.

 To change DescriptorImpl could cause a bigger rewrite and it is better not
 to include it now.
 But it might be a good idea to keep an issue around for cleaning it up
 next year?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


[tor-bugs] #17924 [Tor]: config.log gets wiped out by make clean instead of make distclean

2015-12-22 Thread Tor Bug Tracker & Wiki
#17924: config.log gets wiped out by make clean instead of make distclean
-+
 Reporter:  cypherpunks  |  Owner:
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.2.8.x-final
Component:  Tor  |Version:  Tor: unspecified
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |Sponsor:
-+
 As someone who likes to make clean, this is troublesome.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #17917 [Tor Browser]: Changelog after the update to 5.5a5-hardened is empty

2015-12-22 Thread Tor Bug Tracker & Wiki
#17917: Changelog after the update to 5.5a5-hardened is empty
-+--
 Reporter:  gk   |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Tor Browser  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
  Sponsor:   |
-+--

Comment (by mikeperry):

 Hrmm. Odd, though, since all 'about:' URLs should be whitelisted by
 NoScript. Maybe whatever we are doing to hide the URL bar is causing
 NoScript to fail to realize the page should be whitelisted?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #17923 [Tor]: Extra unmatched #endif in configure.ac

2015-12-22 Thread Tor Bug Tracker & Wiki
#17923: Extra unmatched #endif in configure.ac
-+
 Reporter:  cypherpunks  |  Owner:
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor: 0.2.7.x-final
Component:  Tor  |Version:  Tor: unspecified
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
  Sponsor:   |
-+
Changes (by nickm):

 * status:  new => closed
 * resolution:   => fixed
 * milestone:  Tor: 0.2.8.x-final => Tor: 0.2.7.x-final


Comment:

 Applied to 0.2.7 and later as d0c209c51d856ee78cca1e4ee337d10155a93916

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #17924 [Tor]: config.log gets wiped out by make clean instead of make distclean

2015-12-22 Thread Tor Bug Tracker & Wiki
#17924: config.log gets wiped out by make clean instead of make distclean
-+
 Reporter:  cypherpunks  |  Owner:
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor: 0.2.8.x-final
Component:  Tor  |Version:  Tor: unspecified
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
  Sponsor:   |
-+
Changes (by nickm):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Looks like we introduced this when we went to a non-recursive build.  I've
 made sure this doesn't mess up distcheck, and applied it to master as
 2b9b694410fb0a6078290ed1652df608950a25cc.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #17921 [Tor]: OPENSSL_V_SERIES(1, 1, 0) compat guard macro borks LibreSSL

2015-12-22 Thread Tor Bug Tracker & Wiki
#17921: OPENSSL_V_SERIES(1,1,0) compat guard macro borks LibreSSL
--+
 Reporter:  cypherpunks   |  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.2.8.x-final
Component:  Tor   |Version:
 Severity:  Normal| Resolution:
 Keywords:  libressl openssl  |  Actual Points:
Parent ID:| Points:
  Sponsor:|
--+
Changes (by nickm):

 * keywords:   => libressl openssl
 * owner:   => nickm
 * status:  new => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #17917 [Tor Browser]: Changelog after the update to 5.5a5-hardened is empty

2015-12-22 Thread Tor Bug Tracker & Wiki
#17917: Changelog after the update to 5.5a5-hardened is empty
-+--
 Reporter:  gk   |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Tor Browser  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
  Sponsor:   |
-+--

Comment (by mikeperry):

 I also experienced this issue. For me, it was because my security level
 blocked Javascript on this page. Enabling Javascript caused the changelog
 to load.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #17917 [Tor Browser]: Changelog after update is empty if JS is disabled

2015-12-22 Thread Tor Bug Tracker & Wiki
#17917: Changelog after update is empty if JS is disabled
-+--
 Reporter:  gk   |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Tor Browser  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
  Sponsor:   |
-+--

Comment (by cypherpunks):

 I'm from comment:3

 My javascript was also off. However turning on javascript didn't make the
 changelog to load for me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #17917 [Tor Browser]: Changelog after update is empty if JS is disabled

2015-12-22 Thread Tor Bug Tracker & Wiki
#17917: Changelog after update is empty if JS is disabled
-+--
 Reporter:  gk   |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Tor Browser  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
  Sponsor:   |
-+--

Comment (by mikeperry):

 Replying to [comment:6 mcs]:
 > Replying to [comment:5 mikeperry]:
 > > Hrmm. Odd, though, since all 'about:' URLs should be whitelisted by
 NoScript. Maybe whatever we are doing to hide the URL bar is causing
 NoScript to fail to realize the page should be whitelisted?
 >
 > Ah ha! Do you know where NoScript gets its list of whitelisted URLs? I
 do not see about:tbupdate there, but I think it needs to be.

 The whitelists are in extension-overrides.js in the gitian repo, under
 Bundle-Data. There's one for each platform. Ex: Bundle-
 Data/linux/Data/Browser/profile.default/preferences/extension-overrides.js

 However, if you list just the scheme in there, it is supposed to cover
 every single page that is a part of that scheme. And we list 'about:',
 which should cover about:tbupdate. I think maybe something else (the url
 bar being blank? just a guess though) is causing scripts to still get
 blocked on this page.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #16940 [Tor Browser]: Implement loading (only) local change notes after a Tor Browser update

2015-12-22 Thread Tor Bug Tracker & Wiki
#16940: Implement loading (only) local change notes after a Tor Browser update
+--
 Reporter:  gk  |  Owner:  tbb-team
 Type:  enhancement | Status:  closed
 Priority:  Medium  |  Milestone:
Component:  Tor Browser |Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  tbb-5.5, TorBrowserTeam201511R  |  Actual Points:
Parent ID:  | Points:
  Sponsor:  |
+--

Comment (by cypherpunks):

 This doesn't work on my Win7 x64. After Changelog: is empty.

 Unless it is a bug, it might be due to manual hardening using EMET and
 similar tools on my side

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #17917 [Tor Browser]: Changelog after the update to 5.5a5-hardened is empty

2015-12-22 Thread Tor Bug Tracker & Wiki
#17917: Changelog after the update to 5.5a5-hardened is empty
-+--
 Reporter:  gk   |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Tor Browser  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
  Sponsor:   |
-+--

Comment (by cypherpunks):

 Same thing happened to me on 5.5a5 not hardened. See
 ticket:16940#comment:15

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


[tor-bugs] #17922 [- Select a component]: Extra unmatched #endif in configure.ac

2015-12-22 Thread Tor Bug Tracker & Wiki
#17922: Extra unmatched #endif in configure.ac
--+
 Reporter:  cypherpunks   |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.2.8.x-final
Component:  - Select a component  |Version:  Tor: unspecified
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|Sponsor:
--+
 Seems to have been responsible for obscuring that I do have struct
 in6_addr.s6_addr32.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


[tor-bugs] #17923 [Tor]: Extra unmatched #endif in configure.ac

2015-12-22 Thread Tor Bug Tracker & Wiki
#17923: Extra unmatched #endif in configure.ac
-+
 Reporter:  cypherpunks  |  Owner:
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.2.8.x-final
Component:  Tor  |Version:  Tor: unspecified
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |Sponsor:
-+
 Seems to have been responsible for obscuring that I do have struct
 in6_addr.s6_addr32.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #17917 [Tor Browser]: Changelog after update is empty if JS is disabled (was: Changelog after the update to 5.5a5-hardened is empty)

2015-12-22 Thread Tor Bug Tracker & Wiki
#17917: Changelog after update is empty if JS is disabled
-+--
 Reporter:  gk   |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Tor Browser  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
  Sponsor:   |
-+--

Comment (by mcs):

 Replying to [comment:5 mikeperry]:
 > Hrmm. Odd, though, since all 'about:' URLs should be whitelisted by
 NoScript. Maybe whatever we are doing to hide the URL bar is causing
 NoScript to fail to realize the page should be whitelisted?

 Ah ha! Do you know where NoScript gets its list of whitelisted URLs? I do
 not see about:tbupdate there, but I think it needs to be.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #17919 [Onionoo]: Document history objects better

2015-12-22 Thread Tor Bug Tracker & Wiki
#17919: Document history objects better
---+---
 Reporter:  seansaito  |  Owner:  karsten
 Type:  task   | Status:  needs_information
 Priority:  Medium |  Milestone:
Component:  Onionoo|Version:
 Severity:  Normal | Resolution:
 Keywords:  documentation  |  Actual Points:
Parent ID: | Points:
  Sponsor: |
---+---

Comment (by virgil):

 `What data does a history object contain?`

   `A history object contains graph data, which can be anything from
 written bytes over consensus weights to uptime.`

 Q: Just to be clear, this means Onionoo provides access to the graph data
 points, but '''does not '''provide access to the raw historical data?

 If the answer is yes: could we start making the historical data available?
 The most we'd ever want to go back is 6-12 months.  If this is too niche a
 need to be on Onionoo we could keep this data on the Roster server itself.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17853 [Tor]: review ed25519 document for dirauths (and curious relay ops)

2015-12-22 Thread Tor Bug Tracker & Wiki
#17853: review ed25519 document for dirauths (and curious relay ops)
---+
 Reporter:  Sebastian  |  Owner:
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.2.8.x-final
Component:  Tor|Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:  nickm
  Sponsor: |
---+
Changes (by nickm):

 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #17687 [Tor]: crypto_strongest_rand() failures should be fatal(?)

2015-12-22 Thread Tor Bug Tracker & Wiki
#17687: crypto_strongest_rand() failures should be fatal(?)
-+
 Reporter:  yawning  |  Owner:  yawning
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor: 0.2.8.x-final
Component:  Tor  |Version:  Tor: unspecified
 Severity:  Normal   | Resolution:  fixed
 Keywords:  crypto tor-core  |  Actual Points:
Parent ID:   | Points:
  Sponsor:   |
-+
Changes (by nickm):

 * status:  new => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #17917 [Tor Browser]: Changelog after the update to 5.5a5-hardened is empty

2015-12-22 Thread Tor Bug Tracker & Wiki
#17917: Changelog after the update to 5.5a5-hardened is empty
-+--
 Reporter:  gk   |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Tor Browser  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
  Sponsor:   |
-+--

Comment (by mcs):

 I am unable to reproduce this problem. I downloaded a fresh copy of
 5.5a4-hardened on a Ubuntu 14.04 LTS system and used the updater to
 upgrade to 5.5a5-hardened. After restart, the about:tbupdate tab with the
 changelog and a link to the blog post was opened, as I would expect. I
 will attach a screenshot.

 I wonder if it sometimes works or what is going on.
 gk - Did the about:tbupdate tab open at all?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


[tor-bugs] #17917 [Tor Browser]: Changelog after the update to 5.5a5-hardened is empty

2015-12-22 Thread Tor Bug Tracker & Wiki
#17917: Changelog after the update to 5.5a5-hardened is empty
-+--
 Reporter:  gk   |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Tor Browser  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |Sponsor:
-+--
 There is no changelog shown after the update to 5.5a5-hardened and no link
 to the changelog on our blog either. I think this happens because it was
 the first changelog ever in this series. We might want to be a bit more
 lenient in this case to have a future-proof mechanism for displaying the
 latest changes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


[tor-bugs] #17919 [- Select a component]: Implement "example request" for history object in documentation of Onionoo

2015-12-22 Thread Tor Bug Tracker & Wiki
#17919: Implement "example request" for history object in documentation of 
Onionoo
--+---
 Reporter:  seansaito |  Owner:  karsten
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  - Select a component  |Version:
 Severity:  Normal|   Keywords:  documentation
Actual Points:|  Parent ID:
   Points:|Sponsor:
--+---
 In the [https://onionoo.torproject.org/protocol.html#history |
 documentation of Onionoo], all objects except for the '''history''' object
 have links to example requests (e.g.,
 [https://onionoo.torproject.org/bandwidth?limit=4 | bandwidth object
 example]).

 I'm wondering if the history object should have an analogous link so that
 people (like myself presently) can understand how to query for and use
 history objects.

 Here are a few questions I have about the history object:
 * Can I query the history object for individual relays?
 * What data does a history object contain?
 * How far back does a history object go?

 Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


[tor-bugs] #17916 [Tor]: Make some GCC versions less sad

2015-12-22 Thread Tor Bug Tracker & Wiki
#17916: Make some GCC versions less sad
+-
 Reporter:  ln5 |  Owner:
 Type:  defect  | Status:  new
 Priority:  High|  Milestone:
Component:  Tor |Version:
 Severity:  Normal  |   Keywords:
Actual Points:  |  Parent ID:
   Points:  |Sponsor:
+-
 GCC 4.9.2 (32bit system) doesn't seem to pick up the fact that the
 default clause in crypto_digest_algorithm_get_length() results in an
 abort() and complains that 'control reaches end of non-void function'.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #17916 [Tor]: Make some GCC versions less sad

2015-12-22 Thread Tor Bug Tracker & Wiki
#17916: Make some GCC versions less sad
+-
 Reporter:  ln5 |  Owner:
 Type:  defect  | Status:  new
 Priority:  High|  Milestone:
Component:  Tor |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:
  Sponsor:  |
+-

Comment (by ln5):

 See branch bug17916 in my public repo for a patch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #17919 [Onionoo]: Implement "example request" for history object in documentation of Onionoo

2015-12-22 Thread Tor Bug Tracker & Wiki
#17919: Implement "example request" for history object in documentation of 
Onionoo
---+-
 Reporter:  seansaito  |  Owner:  karsten
 Type:  task   | Status:  new
 Priority:  Medium |  Milestone:
Component:  Onionoo|Version:
 Severity:  Normal | Resolution:
 Keywords:  documentation  |  Actual Points:
Parent ID: | Points:
  Sponsor: |
---+-
Changes (by seansaito):

 * component:  - Select a component => Onionoo


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


[tor-bugs] #17918 [Tor Browser]: Update release process documentation to check for new Firefox tag immediately before releasing

2015-12-22 Thread Tor Bug Tracker & Wiki
#17918: Update release process documentation to check for new Firefox tag
immediately before releasing
-+--
 Reporter:  gk   |  Owner:  tbb-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Tor Browser  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |Sponsor:
-+--
 To prevent things like #17877 from happening ever again we should mention
 to check the release is built from the proper Mozilla release tag
 immediately before we push the "Go live" button.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #15197 [Tor Browser]: Rebase Tor Browser patches to ESR 45

2015-12-22 Thread Tor Bug Tracker & Wiki
#15197: Rebase Tor Browser patches to ESR 45
-+-
 Reporter:  gk   |  Owner:  arthuredelstein
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Tor Browser  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff45-esr |  Actual Points:
Parent ID:   | Points:
  Sponsor:  SponsorU |
-+-
Description changed by arthuredelstein:

Old description:

> Once Firefox 45 ESR reaches beta state we should start rebasing our
> existing patches. This ticket is tracking that progress + the upcoming
> issues.
>
> For reference:
> * Firefox 45 Alpha: 2015-12-14
> * Firefox 45 Beta: 2016-01-26
> * Firefox 45 Release (and ESR): 2016-03-08
> * Firefox 38 ESR end-of-life: 2016-05-31
>
> See also Mozilla's
> [https://www.google.com/calendar/embed?src=mozilla.com_2d37383433353432352d3939%40resource.calendar.google.com
> Merge/Release schedule],
> [https://mozorg.cdn.mozilla.net/media/img/firefox/organizations/release-
> overview-high-res.9808ec366a94.png Release overview], and
> [https://wiki.mozilla.org/RapidRelease/Calendar Rapid Release Calendar].
>
> Here are TBB5.5a patches upstreamed to Firefox. These will be present in
> ESR45 and so we won't need to be rebase them from TBB 5.5a to TBB 6.0a:
> * Bug #12430: Disable external jar: via preference
> (https://bugzil.la/1173171)
> * TB2: Provide an observer event to close persistent connections
> (https://bugzil.la/962358)
> * Bug #3455.2. Allow RFC1929 authentication (username/password) to SOCKS
> servers (https://bugzil.la/1200802)
> * Bug #2950: Make Permissions Manager memory-only
> (https://bugzil.la/967812)
> * Bug #2949: Make Intermediate Cert Store memory-only.
> (https://bugzil.la/629558)
> * Bug #4755: Return client window coordinates for mouse event screenX/Y
> (for dragend, 0,0 is returned). (https://bugzil.la/418986)
> * Bug #2875: Limit device and system specific CSS Media Queries.
> (https://bugzil.la/418986)
> * Bug #5856: Do not expose physical screen info via window &
> window.screen. (https://bugzil.la/418986)
> * Bug #13016: Hide CSS -moz-osx-font-smoothing values.
> (https://bugzil.la/418986)
> * Bug #13025: Lie about screen orientation. (https://bugzil.la/418986)
> * Bug #6786: Do not expose system colors to CSS or canvas.
> (https://bugzil.la/232227)
> * Bug #13313 Part 2: Fix windows cross-compile for --enable-bundled-fonts
> (https://bugzil.la/1190590)
> * Bug #16906: Don't depend on Windows crypto DLLs.
> (https://bugzil.la/1217985)

New description:

 Once Firefox 45 ESR reaches beta state we should start rebasing our
 existing patches. This ticket is tracking that progress + the upcoming
 issues.

 For reference:
 * Firefox 45 Alpha: 2015-12-14
 * Firefox 45 Beta: 2016-01-26
 * Firefox 45 Release (and ESR): 2016-03-08
 * Firefox 38 ESR end-of-life: 2016-05-31

 See also Mozilla's
 
[https://www.google.com/calendar/embed?src=mozilla.com_2d37383433353432352d3939%40resource.calendar.google.com
 Merge/Release schedule],
 [https://mozorg.cdn.mozilla.net/media/img/firefox/organizations/release-
 overview-high-res.9808ec366a94.png Release overview], and
 [https://wiki.mozilla.org/RapidRelease/Calendar Rapid Release Calendar].

 Here are TBB5.5a patches upstreamed to Firefox. These will be present in
 ESR45 and so we won't need to rebase them from TBB 5.5a to TBB 6.0a:
 * Bug #12430: Disable external jar: via preference
 (https://bugzil.la/1173171)
 * TB2: Provide an observer event to close persistent connections
 (https://bugzil.la/962358)
 * Bug #3455.2. Allow RFC1929 authentication (username/password) to SOCKS
 servers (https://bugzil.la/1200802)
 * Bug #2950: Make Permissions Manager memory-only
 (https://bugzil.la/967812)
 * Bug #2949: Make Intermediate Cert Store memory-only.
 (https://bugzil.la/629558)
 * Bug #4755: Return client window coordinates for mouse event screenX/Y
 (for dragend, 0,0 is returned). (https://bugzil.la/418986)
 * Bug #2875: Limit device and system specific CSS Media Queries.
 (https://bugzil.la/418986)
 * Bug #5856: Do not expose physical screen info via window &
 window.screen. (https://bugzil.la/418986)
 * Bug #13016: Hide CSS -moz-osx-font-smoothing values.
 (https://bugzil.la/418986)
 * Bug #13025: Lie about screen orientation. (https://bugzil.la/418986)
 * Bug #6786: Do not expose system colors to CSS or canvas.
 (https://bugzil.la/232227)
 * Bug #13313 Part 2: Fix windows cross-compile for --enable-bundled-fonts
 (https://bugzil.la/1190590)
 * Bug #16906: Don't depend on Windows crypto DLLs.
 (https://bugzil.la/1217985)

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org

Re: [tor-bugs] #17906 [Tor]: Dannenberg's v3ident needs to change

2015-12-22 Thread Tor Bug Tracker & Wiki
#17906: Dannenberg's v3ident needs to change
-+-
 Reporter:  atagar   |  Owner:
 Type:  defect   | Status:
 Priority:  High |  needs_review
Component:  Tor  |  Milestone:  Tor:
 Severity:  Major|  0.2.8.x-final
 Keywords:  027-backport 026-backport|Version:
  TorCoreTeam201512  | Resolution:
Parent ID:   |  Actual Points:
  Sponsor:   | Points:
-+-

Comment (by arma):

 Answer: the legacy key thing makes you *sign* with your legacy key, but
 you vote with only one key, your main one. So if nobody else thinks that's
 a legit key, then they ignore your vote, so the consensus that you sign
 (with both keys) is the wrong one.

 So yes, we need to do a coordinated shift of a high enough threshold of
 the authorities that we'll get a consensus afterwards too.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #17899 [Service - trac]: Mystery Buttons Appear in Trac Create New Ticket Page

2015-12-22 Thread Tor Bug Tracker & Wiki
#17899: Mystery Buttons Appear in Trac Create New Ticket Page
+-
 Reporter:  huertanix   |  Owner:  qbi
 Type:  defect  | Status:  new
 Priority:  Low |  Milestone:
Component:  Service - trac  |Version:
 Severity:  Minor   | Resolution:
 Keywords:  trac,   |  Actual Points:
Parent ID:  | Points:
  Sponsor:  |
+-

Comment (by cypherpunks):

 Replying to [comment:2 teor]:
 > I see this issue in High security mode in Tor Browser, but it works on
 medium-high, or with JavaScript turned on.
 AFAICT the buttons aren't there when Javascript is off because they can
 only function with JavaScript (for dynamic insertion of Wiki Markup).

 When i posted ticket:17899#comment:1
 https://trac.torproject.org/edit_toolbar.png still returned 404. This is
 no longer the case so the buttons aren't empty anymore.

 IMHO tor.css shouldn't overwrite the URL at all (unless it is really a
 different image, which it isn't) and should only change some colors and
 tweak the layout which seems to be the point of that style sheet. It would
 make the style sheet smaller and easier to maintain.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


[tor-bugs] #17915 [EFF-HTTPS Everywhere]: https everywhere breaks videos on foxnews.com

2015-12-22 Thread Tor Bug Tracker & Wiki
#17915: https everywhere breaks videos on foxnews.com
--+---
 Reporter:  cypherpunks   |  Owner:  jsha
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:
Component:  EFF-HTTPS Everywhere  |Version:
 Severity:  Major |   Keywords:  firefox video
Actual Points:|  Parent ID:
   Points:|Sponsor:
--+---
 Videos on foxnews.com will not play when the extension is enabled.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #17158 [Tor]: Run an opt-in process for fallback directories

2015-12-22 Thread Tor Bug Tracker & Wiki
#17158: Run an opt-in process for fallback directories
+--
 Reporter:  teor|  Owner:  teor
 Type:  task| Status:  assigned
 Priority:  Medium  |  Milestone:  Tor:
Component:  Tor |  0.2.8.x-final
 Severity:  Normal  |Version:
 Keywords:  028-triaged, TorCoreTeam201601  | Resolution:
Parent ID:  |  Actual Points:
  Sponsor:  SponsorU| Points:  medium/large
+--

Comment (by teor):

 As of Tue 22 Dec 2015 11:42 UTC, we have had 29 relay operators opt-in
 their relays as fallback directories. (I think about 23 of those are on
 the list.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #17913 [Tor]: TestingClient option missing from manual

2015-12-22 Thread Tor Bug Tracker & Wiki
#17913: TestingClient option missing from manual
+--
 Reporter:  atagar  |  Owner:  teor
 Type:  defect  | Status:  accepted
 Priority:  Low |  Milestone:
Component:  Tor |Version:
 Severity:  Minor   | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:
  Sponsor:  |
+--
Changes (by teor):

 * status:  new => accepted
 * owner:   => teor


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #17913 [Tor]: TestingClient option missing from manual

2015-12-22 Thread Tor Bug Tracker & Wiki
#17913: TestingClient option missing from manual
+
 Reporter:  atagar  |  Owner:  teor
 Type:  defect  | Status:  accepted
 Priority:  Low |  Milestone:  Tor: 0.2.8.x-final
Component:  Tor |Version:
 Severity:  Minor   | Resolution:
 Keywords:  doc |  Actual Points:
Parent ID:  | Points:
  Sponsor:  |
+
Changes (by teor):

 * keywords:   => doc
 * milestone:   => Tor: 0.2.8.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #17918 [Tor Browser]: Update release process documentation to check for new Firefox tag immediately before releasing

2015-12-22 Thread Tor Bug Tracker & Wiki
#17918: Update release process documentation to check for new Firefox tag
immediately before releasing
-+-
 Reporter:  gk   |  Owner:  tbb-
 Type:  enhancement  |  team
 Priority:  Medium   | Status:
Component:  Tor Browser  |  needs_review
 Severity:  Normal   |  Milestone:
 Keywords:  TorBrowserTeam201512R,   |Version:
  MikePerry201512R   | Resolution:
Parent ID:   |  Actual Points:
  Sponsor:   | Points:
-+-
Changes (by gk):

 * keywords:   => TorBrowserTeam201512R, MikePerry201512R
 * status:  new => needs_review
 * cc: mikeperry (added)


Comment:

 The patch is attached for review and merge.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #12631 [Tor Browser]: Tor Browser for ARM architecture

2015-12-22 Thread Tor Bug Tracker & Wiki
#12631: Tor Browser for ARM architecture
-+-
 Reporter:  mttp |  Owner:
 Type:  project  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Tor Browser  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-gitian   |  Actual Points:
Parent ID:   | Points:
  Sponsor:   |
-+-

Comment (by cypherpunks):

 Ubuntu-vm-builder (python-vm-builder), used by gitian, already supports
 multiple architectures, but lacks the release information for releases of
 ubuntu or debian for any cpu architectures other than i686 and x86_64.

 gitian also supports using LXC, via libvirt, instead of Qemu-KVM. This is
 used by default when the gitian environment is already virtualized.
 libvirt also supports using a qemu backend, for example, qemu-system-arm.

 Debian is also supported as a target by gitian, and debian supports a
 wider variety of architectures than ubuntu. A patch for python-vm-builder
 that includes all flavors of debian releases would be a step towards
 getting gitian to support other target architectures.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #16805 [Tor]: Improve unit-test coverage on old and/or pure-ish functions/modules in src/or

2015-12-22 Thread Tor Bug Tracker & Wiki
#16805: Improve unit-test coverage on old and/or pure-ish functions/modules in
src/or
-+
 Reporter:  nickm|  Owner:
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:  Tor: 0.2.8.x-final
Component:  Tor  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  testing, 028-triage  |  Actual Points:
Parent ID:   | Points:  medium
  Sponsor:  SponsorS |
-+
Changes (by nickm):

 * severity:   => Normal


Comment:

 Update:
 {{{
 rephist.c.gcov 897 343 27.66
 networkstatus.c.gcov 642 253 28.27
 routerlist.c.gcov 1286 838 39.45
 nodelist.c.gcov 385 260 40.31
 buffers.c.gcov 272 510 65.22
 routerparse.c.gcov 676 1668 71.16
 policies.c.gcov 162 718 81.59
 rendcache.c.gcov 23 358 93.96
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #16808 [Tor]: High coverage on connection_edge, addressmap

2015-12-22 Thread Tor Bug Tracker & Wiki
#16808: High coverage on connection_edge, addressmap
-+
 Reporter:  nickm|  Owner:
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.2.8.x-final
Component:  Tor  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  testing, 028-triage  |  Actual Points:
Parent ID:   | Points:  large
  Sponsor:  SponsorS |
-+
Changes (by nickm):

 * severity:   => Normal


Comment:

 Update:
 {{{
 connection_edge.c.gcov 1237 144 10.43
 addressmap.c.gcov 182 211 53.69
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


[tor-bugs] [Tor Bug Tracker & Wiki] Batch modify: #16764, #16826

2015-12-22 Thread Tor Bug Tracker & Wiki
Batch modification to #16764, #16826 by nickm:
milestone to Tor: 0.2.9.x-final

Comment:
Deferring these two to 0.2.9; we have already made big progress in simplifying 
the Blob.

--
Tickets URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #17917 [Tor Browser]: Changelog after the update to 5.5a5-hardened is empty

2015-12-22 Thread Tor Bug Tracker & Wiki
#17917: Changelog after the update to 5.5a5-hardened is empty
-+--
 Reporter:  gk   |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Tor Browser  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
  Sponsor:   |
-+--

Comment (by mcs):

 Screenshot:

 [[Image(tb-5.5a5-hardened.png)]]

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #17823 [metrics-lib]: use diamond operator

2015-12-22 Thread Tor Bug Tracker & Wiki
#17823: use diamond operator
-+--
 Reporter:  iwakeh   |  Owner:  karsten
 Type:  enhancement  | Status:  needs_review
 Priority:  Low  |  Milestone:
Component:  metrics-lib  |Version:
 Severity:  Minor| Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #17822   | Points:
  Sponsor:   |
-+--
Changes (by karsten):

 * status:  accepted => needs_review


Comment:

 Please review commit [https://gitweb.torproject.org/user/karsten/metrics-
 
lib.git/commit/?h=tasks-17823-17824-17830=ce18717907b502dfbc87f4b8567652ffe10fefe5
 ce18717] in [https://gitweb.torproject.org/user/karsten/metrics-
 lib.git/log/?h=tasks-17823-17824-17830 branch tasks-17823-17824-17830 in
 my public repository].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #17901 [Tor]: Tor would bind ControlPort to public ip address if it has no localhost interface

2015-12-22 Thread Tor Bug Tracker & Wiki
#17901: Tor would bind ControlPort to public ip address if it has no localhost
interface
---+---
 Reporter:  s7r|  Owner:
 Type:  defect | Status:  new
 Priority:  High   |  Milestone:  Tor:
Component:  Tor|  0.2.8.x-final
 Severity:  Major  |Version:  Tor: 0.2.7.6
 Keywords:  027-backport 026-backport  | Resolution:
Parent ID: |  Actual Points:
  Sponsor: | Points:
---+---

Comment (by s7r):

 I think we should automatically disable ControlPort, ExtORPort, TransPort
 and DNSPort if we have no `lo` interface (127.0.0.1 localhost address) and
 they are set with just the port number or auto. If the setting for them is
 : we assume it's wanted and expected to be open
 there and proceed, but with loud warnings that it's a terrible idea. Maybe
 we should require authentication for ControlPort if opened on public / nat
 IP or quit otherwise? Not entirely sure if it's worth it.

 For ORPort and DirPort binding to whatever IP address it sees is fine, we
 shouldn't change the behavior for these two, so whatever fixes we apply
 should be related to `ControlPort` `TransPort` `DNSPort` `ExtORPort` and
 `SocksPort`. Hope I didn't miss anything.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #16794 [Tor]: All cryptography unit test coverage should be over 95%; all should have test vectors

2015-12-22 Thread Tor Bug Tracker & Wiki
#16794: All cryptography unit test coverage should be over 95%; all should have
test vectors
-+
 Reporter:  nickm|  Owner:
 Type:  enhancement  | Status:  new
 Priority:  High |  Milestone:  Tor: 0.2.8.x-final
Component:  Tor  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  testing, 028-triage  |  Actual Points:
Parent ID:  #16791   | Points:  medium
  Sponsor:  SponsorS |
-+
Changes (by nickm):

 * severity:   => Normal


Comment:

 Update:
 {{{
 cc/crypto.c.gcov 166 800 82.82
 cc/crypto_ed25519.c.gcov 12 124 91.18
 cc/crypto_curve25519.c.gcov 3 85 96.59
 cc/crypto_pwbox.c.gcov 1 62 98.41
 cc/crypto_s2k.c.gcov 1 131 99.24
 cc/aes.c.gcov 0 20 100.00
 cc/crypto_format.c.gcov 0 91 100.00
 }}}

 Only two under-tested modules remain.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #16795 [Tor]: Process-related utility code should have unit test coverage over 95%

2015-12-22 Thread Tor Bug Tracker & Wiki
#16795: Process-related utility code should have unit test coverage over 95%
-+
 Reporter:  nickm|  Owner:
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.2.8.x-final
Component:  Tor  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  testing, 028-triage  |  Actual Points:
Parent ID:  #16791   | Points:  medium
  Sponsor:  SponsorS |
-+
Changes (by nickm):

 * severity:   => Normal


Comment:

 update:
 {{{
 procmon.c.gcov 13 28 68.29
 util_process.c.gcov 2 38 95.00
 }}}

 We're getting there...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #15638 [Tor]: Document the minimum HeartbeatPeriod

2015-12-22 Thread Tor Bug Tracker & Wiki
#15638: Document the minimum HeartbeatPeriod
-+
 Reporter:  qbi  |  Owner:
 Type:  enhancement  | Status:  closed
 Priority:  Low  |  Milestone:  Tor: 0.2.8.x-final
Component:  Tor  |Version:  Tor: 0.2.6.6
 Severity:  Normal   | Resolution:  fixed
 Keywords:  docs |  Actual Points:
Parent ID:   | Points:  small
  Sponsor:   |
-+
Changes (by nickm):

 * status:  new => closed
 * resolution:   => fixed
 * severity:   => Normal


Comment:

 b9596b8fdf5006d650bba0109e5614b5a387dbdf does this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #17901 [Tor]: Tor would bind ControlPort to public ip address if it has no localhost interface

2015-12-22 Thread Tor Bug Tracker & Wiki
#17901: Tor would bind ControlPort to public ip address if it has no localhost
interface
---+---
 Reporter:  s7r|  Owner:
 Type:  defect | Status:  new
 Priority:  High   |  Milestone:  Tor:
Component:  Tor|  0.2.8.x-final
 Severity:  Major  |Version:  Tor: 0.2.7.6
 Keywords:  027-backport 026-backport  | Resolution:
Parent ID: |  Actual Points:
  Sponsor: | Points:
---+---
Changes (by nickm):

 * priority:  Medium => High
 * severity:  Normal => Major


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #16791 [Tor]: All modules in src/common should have 90-95%+ unit test coverage

2015-12-22 Thread Tor Bug Tracker & Wiki
#16791: All modules in src/common should have 90-95%+ unit test coverage
-+
 Reporter:  nickm|  Owner:
 Type:  project  | Status:  new
 Priority:  High |  Milestone:  Tor: 0.2.8.x-final
Component:  Tor  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  testing, 028-triage  |  Actual Points:
Parent ID:   | Points:  large
  Sponsor:  SponsorS |
-+
Changes (by nickm):

 * severity:   => Normal


Comment:

 Update: here are the current coverage numbers for the unit tests ("make
 check") on common, sorted by percent coverage, on Linux.

 {{{
 cc/sandbox.c.gcov 413 47 10.22
 cc/compat_threads.c.gcov 75 53 41.41
 cc/compat.c.gcov 375 469 55.57
 cc/log.c.gcov 211 346 62.12
 cc/torgzip.c.gcov 73 138 65.40
 cc/procmon.c.gcov 13 28 68.29
 cc/compat_libevent.c.gcov 34 86 71.67
 cc/util.c.gcov 404 1309 76.42
 cc/workqueue.c.gcov 31 123 79.87
 cc/backtrace.c.gcov 11 47 81.03
 cc/compat_pthreads.c.gcov 19 88 82.24
 cc/crypto.c.gcov 166 800 82.82
 cc/memarea.c.gcov 16 91 85.05
 cc/address.c.gcov 67 622 90.28
 cc/crypto_ed25519.c.gcov 12 124 91.18
 cc/util_process.c.gcov 2 38 95.00
 cc/tortls.c.gcov 31 823 96.37
 cc/crypto_curve25519.c.gcov 3 85 96.59
 cc/crypto_pwbox.c.gcov 1 62 98.41
 cc/crypto_s2k.c.gcov 1 131 99.24
 cc/aes.c.gcov 0 20 100.00
 cc/container.c.gcov 0 424 100.00
 cc/crypto_format.c.gcov 0 91 100.00
 cc/di_ops.c.gcov 0 52 100.00
 cc/util_format.c.gcov 0 159 100.00
 TOTAL 1958 6256 76.16
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #16798 [Tor]: Raise compat_* testing to over 80%

2015-12-22 Thread Tor Bug Tracker & Wiki
#16798: Raise compat_* testing to over 80%
-+
 Reporter:  nickm|  Owner:
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.2.8.x-final
Component:  Tor  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  testing, 028-triage  |  Actual Points:
Parent ID:  #16791   | Points:  medium/large
  Sponsor:  SponsorS |
-+
Changes (by nickm):

 * severity:   => Normal


Comment:

 Update:
 {{{
 compat.c.gcov 375 469 55.57
 compat_libevent.c.gcov 34 86 71.67
 compat_pthreads.c.gcov 19 88 82.24
 compat_threads.c.gcov 75 53 41.41
 }}}

 That's a little improvement and a little regression.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #16800 [Tor]: Raise tortls unit test coverage as high as possible

2015-12-22 Thread Tor Bug Tracker & Wiki
#16800: Raise tortls unit test coverage as high as possible
-+
 Reporter:  nickm|  Owner:
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor: 0.2.8.x-final
Component:  Tor  |Version:
 Severity:  Normal   | Resolution:  implemented
 Keywords:  testing, 028-triage  |  Actual Points:
Parent ID:  #16791   | Points:  large
  Sponsor:  SponsorS |
-+
Changes (by nickm):

 * status:  new => closed
 * resolution:   => implemented
 * severity:   => Normal


Comment:

 This is done.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #16799 [Tor]: Raise utility testing over 95%

2015-12-22 Thread Tor Bug Tracker & Wiki
#16799: Raise utility testing over 95%
-+
 Reporter:  nickm|  Owner:
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.2.8.x-final
Component:  Tor  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  testing, 028-triage  |  Actual Points:
Parent ID:  #16791   | Points:  medium/large
  Sponsor:  SponsorS |
-+
Changes (by nickm):

 * severity:   => Normal


Comment:

 Update:
 {{{
 memarea.c.gcov 16 91 85.05
 util.c.gcov 404 1309 76.42
 util_format.c.gcov 0 159 100.00
 workqueue.c.gcov 31 123 79.87
 address.c.gcov 67 622 90.28
 addressmap.c.gcov 182 211 53.69
 log.c.gcov 211 346 62.12
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #17905 [Tor]: Consider removing fallback directory weights

2015-12-22 Thread Tor Bug Tracker & Wiki
#17905: Consider removing fallback directory weights
---+
 Reporter:  teor   |  Owner:
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:  Tor: 0.2.8.x-final
Component:  Tor|Version:
 Severity:  Normal | Resolution:
 Keywords:  CoreTorTeam201602  |  Actual Points:
Parent ID: | Points:
  Sponsor: |
---+

Comment (by nickm):

 I'm inclined to wontfix this one.  IME, back 10 years ago when Tor had no
 weights at all, it was a big mess.  Clients were putting way too much load
 on some relays while others were underused.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #17824 [metrics-lib]: switch on string instead of many if-else with String comparison

2015-12-22 Thread Tor Bug Tracker & Wiki
#17824: switch on string instead of many if-else with String comparison
-+--
 Reporter:  iwakeh   |  Owner:  karsten
 Type:  enhancement  | Status:  needs_review
 Priority:  Low  |  Milestone:
Component:  metrics-lib  |Version:
 Severity:  Minor| Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #17822   | Points:
  Sponsor:   |
-+--
Changes (by karsten):

 * status:  accepted => needs_review


Comment:

 Please review commit [https://gitweb.torproject.org/user/karsten/metrics-
 
lib.git/commit/?h=tasks-17823-17824-17830=2b4d7732f65a8d030f7b747ed9931e5541956332
 2b4d773] in [https://gitweb.torproject.org/user/karsten/metrics-
 lib.git/log/?h=tasks-17823-17824-17830 branch tasks-17823-17824-17830 in
 my public repository].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #17830 [metrics-lib]: use StringBuilder correctly

2015-12-22 Thread Tor Bug Tracker & Wiki
#17830: use StringBuilder correctly
-+--
 Reporter:  iwakeh   |  Owner:  karsten
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  metrics-lib  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #17822   | Points:
  Sponsor:   |
-+--
Changes (by karsten):

 * status:  accepted => needs_review


Comment:

 Please review commit [https://gitweb.torproject.org/user/karsten/metrics-
 
lib.git/commit/?h=tasks-17823-17824-17830=77bea15579e1b4a9c50bbe4fa52afef220459643
 77bea15] in [https://gitweb.torproject.org/user/karsten/metrics-
 lib.git/log/?h=tasks-17823-17824-17830 branch tasks-17823-17824-17830 in
 my public repository].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #17919 [Onionoo]: Document history objects better

2015-12-22 Thread Tor Bug Tracker & Wiki
#17919: Document history objects better
---+---
 Reporter:  seansaito  |  Owner:  karsten
 Type:  task   | Status:  needs_information
 Priority:  Medium |  Milestone:
Component:  Onionoo|Version:
 Severity:  Normal | Resolution:
 Keywords:  documentation  |  Actual Points:
Parent ID: | Points:
  Sponsor: |
---+---

Comment (by karsten):

 Onionoo provides bandwidth data from the last 1 month on the same
 granularity as reported by recent Tor versions, which is 1 data point for
 4 hours.  Earlier data is aggregated to 1 data point for 12 hours, then 2
 days, then 10 days.  This is an effective means to keep Onionoo documents
 at a roughly fixed size.  If there's a good reason to keep details around
 for longer, let's discuss that.  What's your use case here?

 Keeping data on Roster itself is not a good option, as I stated before.
 It should be stateless (except for caching) and rely on Onionoo to keep
 all state it needs.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs