Re: [tor-bugs] #19891 [Applications/Tor Browser]: "Update Firefox" bug in TBB

[Tor Bug Tracker & Wiki]

#19891: "Update Firefox" bug in TBB
--+--
 Reporter:  b_meson   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by mrphs):

 * owner:  Sebastian => tbb-team
 * component:  User Experience/Website => Applications/Tor Browser


Comment:

 gpg sig error worries me. can you please tell us where did you get your
 tor browser from?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #19891 [User Experience/Website]: "Update Firefox" bug in TBB

[Tor Bug Tracker & Wiki]

#19891: "Update Firefox" bug in TBB
-+---
 Reporter:  b_meson  |  Owner:  Sebastian
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  User Experience/Website  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+---
 I was running the latest TBB (6.0.3) and launched it but I was getting an
 error that "Firefox needs an update", which didn't make sense since
 Firefox is not running, the TBB fork of Firefox was. I checked the "Check
 for Tor Broswer Update" but it was not returning anything. I then re-
 downloading 6.0.3 and re-checked GPG keys (valid signatures) but was no
 longer seeing this pop-op.

 Out of an abundance of caution, I took pcaps during the time of the popup
 and I noticed all the traffic was properly routed to nodes in the Tor
 network. I clicked the button and it routed me to the Tor Project webpage
 (no SSL warnings). I can provide pcaps if needed but @mrphs says it might
 be a simple bug in the updater.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19875 [Core Tor/Tor]: shuffle our bridges when we load them from config

[Tor Bug Tracker & Wiki]

#19875: shuffle our bridges when we load them from config
--+--
 Reporter:  arma  |  Owner:
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.2.???
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  easy  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by isis):

 * cc: isis (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] [Tor Bug Tracker & Wiki] Batch modify: #17928

[Tor Bug Tracker & Wiki]

Batch modification to #17928 by isabela:
keywords to isaremoved
milestone to Tor: 0.2.???

--
Tickets URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] [Tor Bug Tracker & Wiki] Batch modify: #13966, #13968, #3259, #8185, ...

[Tor Bug Tracker & Wiki]

Batch modification to #13966, #13968, #3259, #8185, #9241, #14164, #17066, 
#17288, #18306, #19286, #13989, #16809, #16824, #16844, #17275, #17605, #18200, 
#19869, #11624, #12377, #13753, #14921, #15518, #16608, #16798, #16799, #16808, 
#17230, #17233, #17253, #17287, #17636, #17673, #17715, #17750, #17835, #17845, 
#17848, #17849, #17857, #17911, #18082, #18100, #18114, #18307, #18345, #18491, 
#18647, #18665, #1, #18897, #18938, #18961, #19011, #19074, #19173, #19222, 
#19281, #19320, #19321, #19324, #19326, #19327, #19328, #19357, #19418, #19506, 
#19518, #19535, #19572, #19656, #19663, #19678, #19759, #19761, #19762, #19877, 
#19878, #19879, #19880, #19881, #19882, #19883, #19884, #19885, #19886, #19887, 
#19888, #19889, #17765, #17975, #18134, #18140, #18153, #18276, #18839, #19223, 
#19419, #19677, #19743 by isabela:
keywords to isaremoved
milestone to Tor: 0.2.???

--
Tickets URL: 

Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17901 [Core Tor/Tor]: Tor would bind ControlPort to public ip address if it has no localhost interface

[Tor Bug Tracker & Wiki]

#17901: Tor would bind ControlPort to public ip address if it has no localhost
interface
--+---
 Reporter:  s7r   |  Owner:
 Type:  defect| Status:  assigned
 Priority:  High  |  Milestone:  Tor: 0.2.???
Component:  Core Tor/Tor  |Version:  Tor: 0.2.6.10
 Severity:  Major | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  3
 Reviewer:|Sponsor:
--+---
Changes (by teor):

 * milestone:  Tor: 0.2.9.x-final => Tor: 0.2.???


Comment:

 While it would be nice to have this fixed, we need someone with FreeBSD /
 OpenVZ to develop and test it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18982 [Core Tor/Tor]: Tor should log 1-based hop numbers

[Tor Bug Tracker & Wiki]

#18982: Tor should log 1-based hop numbers
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Low  |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.5-alpha
 Severity:  Minor| Resolution:
 Keywords:  easy, logging, 029-nickm-says-yes,   |  Actual Points:  .1
  CoreTorTeam201606, review-group-3  |
Parent ID:   | Points:  .1
 Reviewer:  arma |Sponsor:
-+-

Comment (by teor):

 I could revise this, or someone else could pick it up.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18605 [Core Tor/Tor]: Consider including fallback directry mirrors with multiple IP addresses

[Tor Bug Tracker & Wiki]

#18605: Consider including fallback directry mirrors with multiple IP addresses
--+--
 Reporter:  teor  |  Owner:  teor
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.2.???
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  3
 Reviewer:|Sponsor:
--+--
Changes (by teor):

 * milestone:  Tor: 0.2.9.x-final => Tor: 0.2.???


Comment:

 I'm not sure there's a need for this feature at this time

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17953 [Core Tor/Tor]: Fallback to resolving localhost when interface searches fail

[Tor Bug Tracker & Wiki]

#17953: Fallback to resolving localhost when interface searches fail
--+--
 Reporter:  teor  |  Owner:
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.2.???
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  3
 Reviewer:|Sponsor:
--+--
Changes (by teor):

 * owner:  teor =>
 * status:  new => assigned
 * milestone:  Tor: 0.2.9.x-final => Tor: 0.2.???


Comment:

 I don't have time to do this in 0.2.9.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13953 [Core Tor/Tor]: Self-test reachability test - Listen address from ORPort is ignored, it uses default address unless specified via Address argument

[Tor Bug Tracker & Wiki]

#13953: Self-test reachability test - Listen address from ORPort is ignored, it
uses default address unless specified via Address argument
--+
 Reporter:  s7r   |  Owner:  teor
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.2.5.10
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  3 hours
Parent ID:  #17782| Points:  3
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17066 [Core Tor/Tor]: Avoid assuming relays have a single IPv4/IPv6 address

[Tor Bug Tracker & Wiki]

#17066: Avoid assuming relays have a single IPv4/IPv6 address
-+-
 Reporter:  teor |  Owner:
 Type:  task | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:  Tor: 0.2.7
 Severity:  Normal   | Resolution:
 Keywords:  028-triage, 201512-deferred  |  Actual Points:
Parent ID:  #5788| Points:  3
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * owner:  teor =>


Comment:

 I don't have time to do this in 0.2.9.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17901 [Core Tor/Tor]: Tor would bind ControlPort to public ip address if it has no localhost interface

[Tor Bug Tracker & Wiki]

#17901: Tor would bind ControlPort to public ip address if it has no localhost
interface
--+
 Reporter:  s7r   |  Owner:
 Type:  defect| Status:  assigned
 Priority:  High  |  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.2.6.10
 Severity:  Major | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  3
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * status:  new => assigned
 * owner:  teor =>


Comment:

 I don't have time to revise this in 0.2.9.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7478 [Core Tor/Tor]: Allow routersets to include/exclude nodes by IPv6 address

[Tor Bug Tracker & Wiki]

#7478: Allow routersets to include/exclude nodes by IPv6 address
-+-
 Reporter:  nickm|  Owner:
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, ipv6, TorCoreTeam-   |  Actual Points:
  postponed-201604, review-group-3   |
Parent ID:   | Points:  1
 Reviewer:  mikeperry|Sponsor:
-+-
Changes (by teor):

 * status:  assigned => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7478 [Core Tor/Tor]: Allow routersets to include/exclude nodes by IPv6 address

[Tor Bug Tracker & Wiki]

#7478: Allow routersets to include/exclude nodes by IPv6 address
-+-
 Reporter:  nickm|  Owner:
 Type:  enhancement  | Status:
 |  assigned
 Priority:  High |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, ipv6, TorCoreTeam-   |  Actual Points:
  postponed-201604, review-group-3   |
Parent ID:   | Points:  1
 Reviewer:  mikeperry|Sponsor:
-+-
Changes (by teor):

 * cc: teor (removed)
 * owner:  teor =>
 * status:  needs_revision => assigned


Comment:

 I don't have time to revise this in 0.2.9.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19837 [Applications/Tor Browser]: Audio/video player is blank in 6.5a2

[Tor Bug Tracker & Wiki]

#19837: Audio/video player is blank in 6.5a2
-+-
 Reporter:  dcf  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-regression,  |  Actual Points:
  TorBrowserTeam201608   |
Parent ID:  #8725| Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nord-stream):

 * cc: nord-stream@… (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15434 [Core Tor/Tor]: Tor dies if you send it a HUP before it read its config, and doesn't take PTs with it

[Tor Bug Tracker & Wiki]

#15434: Tor dies if you send it a HUP before it read its config, and doesn't 
take
PTs with it
---+
 Reporter:  TvdW   |  Owner:  arma
 Type:  defect | Status:  accepted
 Priority:  Medium |  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor   |Version:  Tor: 0.2.6.5-rc
 Severity:  Normal | Resolution:
 Keywords:  tor-bridge tor-pt  |  Actual Points:
Parent ID: | Points:  3
 Reviewer: |Sponsor:  SponsorS-can
---+
Changes (by isabela):

 * points:  medium? => 3


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #12600 [Core Tor/Tor]: Save retrieved bridge information in our state file

[Tor Bug Tracker & Wiki]

#12600: Save retrieved bridge information in our state file
-+-
 Reporter:  asn  |  Owner:  isis
 Type:  task | Status:
 |  assigned
 Priority:  High |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-bridge, tails-wants, |  Actual Points:
  028-triage, tor-pt |
Parent ID:   | Points:  4.5
 Reviewer:   |Sponsor:
 |  SponsorS-can
-+-
Changes (by isabela):

 * points:  medium/large => 4.5


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19890 [Applications/Tor Browser]: Tor Browser warning: "Your Firefox is out of date."

[Tor Bug Tracker & Wiki]

#19890: Tor Browser warning: "Your Firefox is out of date."
--+--
 Reporter:  arthuredelstein   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201608  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by mcs):

 Possibly relevant:
 http://gecko.readthedocs.io/en/latest/toolkit/mozapps/extensions/addon-
 manager/SystemAddons.html

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19890 [Applications/Tor Browser]: Tor Browser warning: "Your Firefox is out of date."

[Tor Bug Tracker & Wiki]

#19890: Tor Browser warning: "Your Firefox is out of date."
--+--
 Reporter:  arthuredelstein   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201608  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by arthuredelstein):

 Looks like it came from this bug.
 https://bugzilla.mozilla.org/show_bug.cgi?id=1280378

 I'm not sure yet how it gets into Firefox (or Tor Browser for that
 matter).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #19890 [Applications/Tor Browser]: Tor Browser warning: "Your Firefox is out of date."

[Tor Bug Tracker & Wiki]

#19890: Tor Browser warning: "Your Firefox is out of date."
--+
 Reporter:  arthuredelstein   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
  |  TorBrowserTeam201608
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 On Tor Browser 6.0.3 (up-to-date) I saw the following warning appear below
 the URL bar:

 "Your Firefox is out of date. Please download a fresh copy." On the right
 is a button that says "Get Firefox". Obviously we want to disable this
 warning.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19157 [Core Tor/Tor]: [prop220] Check all new certificate types (incl cross-cert and ed25519)

[Tor Bug Tracker & Wiki]

#19157: [prop220] Check all new certificate types (incl cross-cert and ed25519)
+--
 Reporter:  nickm   |  Owner:  nickm
 Type:  enhancement | Status:  assigned
 Priority:  Medium  |  Milestone:  Tor:
|  0.2.9.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  prop220, TorCoreTeam201608  |  Actual Points:
Parent ID:  #15055  | Points:  1
 Reviewer:  |Sponsor:  SponsorU-must
+--

Comment (by nickm):

 Next steps here:
  * complete the or_handshake_certs_ed25519_ok function.
  * Resolve all XXX items in it.
  * Make it check expiration times.
  * actually call it in the same places we call or_handshake_certs_rsa_ok.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19720 [Metrics/CollecTor]: CollecTor should be re-configurable without restart

[Tor Bug Tracker & Wiki]

#19720: CollecTor should be re-configurable without restart
---+-
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  enhancement| Status:  needs_review
 Priority:  High   |  Milestone:  CollecTor 1.0.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords:  ctip   |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-

Comment (by iwakeh):

 More precisely:
 The java implementations differ and the one on osx reports the same values
 for the test cases, where the linux implementation gives different values.

 * Linux (time printed immediately before and after setting the time in
 testConfigChange)
  {{{
 [junit] c 1 2016-08-10T18:42:22.57207Z
 [junit] c 2 2016-08-10T18:42:22.576Z
  }}}
 * OSX gives two times the same value (not pasted).

 This
 [https://gitweb.torproject.org/user/iwakeh/collector.git/commit/?h=task-19720
 -osx-test=f74557fe53117b53c9bf86c675dcb09392bc338d branch] makes the
 tests work on OS X, too.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #12736 [Applications/Tor Browser]: DLL hijacking vulnerability in TBB

[Tor Bug Tracker & Wiki]

#12736: DLL hijacking vulnerability in TBB
+--
 Reporter:  underdoge   |  Owner:  tbb-team
 Type:  defect  | Status:  new
 Priority:  High|  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-security, TorBrowserTeam201608  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by cypherpunks):

 This is somehow triggered by HTTPS Everywhere. TBB doesn't look for the
 ".DLL", if HTTPS Everywhere is disabled.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19020 [Core Tor/Tor]: RSA cross-certification of ed25519 keys differs from spec

[Tor Bug Tracker & Wiki]

#19020: RSA cross-certification of ed25519 keys differs from spec
-+-
 Reporter:  special  |  Owner:  nickm
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop-220, tor-ed25519-proto, |  Actual Points:  0.5
  TorCoreTeam201608  |
Parent ID:  #15055   | Points:  0.5
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * actualpoints:   => 0.5


Comment:

 I've tweaked the proposal in 7ad026a2d6cec0e8ae7f9b663dcc218f684c52fd to
 include the length field, and my #15055 branch to do the signing as
 specified.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19170 [Metrics/CollecTor]: make parsing more robust (extra-info)

[Tor Bug Tracker & Wiki]

#19170: make parsing more robust (extra-info)
---+-
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  defect | Status:  merge_ready
 Priority:  Medium |  Milestone:  CollecTor 1.0.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords:  ctip   |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-

Comment (by karsten):

 Okay, cool, cherry-picked into [https://gitweb.torproject.org/karsten
 /metrics-db.git/log/?h=task-19720 my task-19720 branch] that I'll merge
 into master as soon as #19720 is ready to be merged.  (And yes, writing a
 test for this is indeed tricky.  Not for 1.0.0, at least not if we're
 still planning to release today.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #12736 [Applications/Tor Browser]: DLL hijacking vulnerability in TBB

[Tor Bug Tracker & Wiki]

#12736: DLL hijacking vulnerability in TBB
+--
 Reporter:  underdoge   |  Owner:  tbb-team
 Type:  defect  | Status:  new
 Priority:  High|  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-security, TorBrowserTeam201608  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by cypherpunks):

 I tested TBB 6.0.3 on a clean Windows 7 system. Per procmon, TBB is
 looking for a .DLL, searching in the Browser dir, system dirs and Path:

 firefox.exe 1920CreateFile  C:\Tor Browser\Browser\.DLL
 NAME NOT FOUND
 firefox.exe 1920CreateFile  C:\Windows\SysWOW64\.DLL
 NAME NOT FOUND
 firefox.exe 1920CreateFile  C:\Windows\system\.DLL  NAME NOT
 FOUND
 firefox.exe 1920CreateFile  C:\Windows\.DLL NAME NOT FOUND
 firefox.exe 1920CreateFile  C:\Windows\SysWOW64\.DLL
 NAME NOT FOUND
 firefox.exe 1920CreateFile  C:\Windows\.DLL NAME NOT FOUND
 firefox.exe 1920CreateFile  C:\Windows\SysWOW64\wbem\.DLL
 NAME NOT FOUND
 firefox.exe 1920CreateFile
 C:\Windows\SysWOW64\WindowsPowerShell\v1.0\.DLL NAME NOT FOUND

 If ".DLL" exists, it is loaded and executed (DllMain is called):
 firefox.exe 2412CreateFile  C:\Tor Browser\Browser\.DLL
 SUCCESS
 firefox.exe 2412QueryBasicInformationFile   C:\Tor
 Browser\Browser\.DLL SUCCESS
 firefox.exe 2412CloseFile   C:\Tor Browser\Browser\.DLL
 SUCCESS
 firefox.exe 2412CreateFile  C:\Tor Browser\Browser\.DLL
 SUCCESS
 firefox.exe 2412CreateFileMapping   C:\Tor
 Browser\Browser\.DLL SUCCESS
 firefox.exe 2412Load Image  C:\Tor Browser\Browser\.DLL
 SUCCESS
 firefox.exe 2412CloseFile   C:\Tor Browser\Browser\.DLL
 SUCCESS

 A "normal" Firefox doesn't look for a ".DLL". So TBB presumably somewhere
 constructs a DLL name with a blank base name.

 At least with a current Windows version, the problem doesn't seem too bad.
 It doesn't look in the current directory for a ".DLL".

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3875 [Applications/Tor Browser]: TBB's Firefox shouldn't use optimistic data socks handshake variant (was: TBB's Firefox should use optimistic data socks handshake variant)

[Tor Bug Tracker & Wiki]

#3875: TBB's Firefox shouldn't use optimistic data socks handshake variant
-+-
 Reporter:  arma |  Owner:  mikeperry
 Type:  defect   | Status:  reopened
 Priority:  High |  Milestone:  TorBrowserBundle
Component:  Applications/Tor |  2.3.x-stable
  Browser|Version:
 Severity:  Normal   | Resolution:
 Keywords:  performance roundtrip|  Actual Points:
  MikePerry201304 tbb-bounty |
  SponsorF20131101   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by cypherpunks):

 * status:  closed => reopened
 * severity:   => Normal
 * parent:  #3890 =>
 * resolution:  fixed =>
 * component:  Firefox Patch Issues => Applications/Tor Browser
 * type:  project => defect


Comment:

 Tor Browser shouldn't use optimistic data socks handshake variant as
 totally incompatible with Firefox code and total broken.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19720 [Metrics/CollecTor]: CollecTor should be re-configurable without restart

[Tor Bug Tracker & Wiki]

#19720: CollecTor should be re-configurable without restart
---+-
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  enhancement| Status:  needs_review
 Priority:  High   |  Milestone:  CollecTor 1.0.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords:  ctip   |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-

Comment (by karsten):

 Okay, after looking very briefly into the issue, I don't quite understand
 your statement that "hfs always reports creation time as modified time".
 I'm using `File.lastModified()` in other places without issues where it
 gives me the modified time, not the creation time.  Can you give a minimal
 example that works on Linux and doesn't work on OS X?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19835 [Applications/Tor Browser]: Put "Tor Browser" and version on the upper right of the changelog page too

[Tor Bug Tracker & Wiki]

#19835: Put "Tor Browser" and version on the upper right of the changelog page 
too
-+-
 Reporter:  arma |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability,TorBrowserTeam201608R  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by mcs):

 * keywords:   => tbb-usability,TorBrowserTeam201608R


Comment:

 This seems like a reasonable request. See ticket:19336#comment:2 for a
 fix.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19336 [Applications/Tor Browser]: Make text stand out in about:tbupdate

[Tor Bug Tracker & Wiki]

#19336: Make text stand out in about:tbupdate
-+-
 Reporter:  cypherpunks  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability,TorBrowserTeam201608R  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by mcs):

 * keywords:   => tbb-usability,TorBrowserTeam201608R
 * status:  new => needs_review


Comment:

 We went ahead and made some text bold as was suggested. We also fixed
 #19835. Please review:

 https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug19336-01=219b21731bec577b8797a8914612f0ae9e55d1ad

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19336 [Applications/Tor Browser]: Make text stand out in about:tbupdate

[Tor Bug Tracker & Wiki]

#19336: Make text stand out in about:tbupdate
--+--
 Reporter:  cypherpunks   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by mcs):

 Replying to [ticket:19336 cypherpunks]:
 > Secondly may not be related, but on tor browser startup the url bar is
 empty and it doesn't say whether it is about:tor or about:tbupdate why is
 this?

 It is common practice to hide the URL for built-in pages. This makes it
 easier for users to enter a different URL and also hides ugly names like
 about:tbupdate from users.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19720 [Metrics/CollecTor]: CollecTor should be re-configurable without restart

[Tor Bug Tracker & Wiki]

#19720: CollecTor should be re-configurable without restart
---+-
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  enhancement| Status:  needs_review
 Priority:  High   |  Milestone:  CollecTor 1.0.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords:  ctip   |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-

Comment (by karsten):

 Hmm.  I didn't have time to look into the issue yet, but is there a
 workaround that fixes this issue on OS X?  It's one thing to say that
 operating instructions are written for a specific operating system.  But
 it's another thing to knowingly break, or not fix, the development
 environment on a previously working operating system.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19720 [Metrics/CollecTor]: CollecTor should be re-configurable without restart

[Tor Bug Tracker & Wiki]

#19720: CollecTor should be re-configurable without restart
---+-
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  enhancement| Status:  needs_review
 Priority:  High   |  Milestone:  CollecTor 1.0.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords:  ctip   |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-

Comment (by iwakeh):

 Suspicion confirmed MacOSX hfs always reports creation time as modified
 time.  Thus, the update is not triggered and the tests fail correctly.

 Verified on OS X Lion hfs using ugly System.err to print
 `Files.getLastModifiedTime(confFile.toPath())` inside the tests.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16324 [Applications/Tor Browser]: Focusing the search bar is already creating/using a catchall circuit

[Tor Bug Tracker & Wiki]

#16324: Focusing the search bar is already creating/using a catchall circuit
--+---
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  not a bug
 Keywords:  tbb-linkability   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by gk):

 * status:  reopened => closed
 * resolution:   => not a bug


Comment:

 Nothing special. I am closing this bug as the issue *I* had and which was
 the reason why *I* created this bug is a non-issue. The other one Arthur
 has found is dealt with in #19741.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16324 [Applications/Tor Browser]: Focusing the search bar is already creating/using a catchall circuit

[Tor Bug Tracker & Wiki]

#16324: Focusing the search bar is already creating/using a catchall circuit
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  reopened
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-linkability   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by bugzilla):

 * status:  closed => reopened
 * resolution:  not a bug =>


Comment:

 So, Arthur creates a new ticket for "a favicon is displayed in the
 searchbar popup which causes a connection over the catchall circuit" and
 you closes the ticket about the same for the searchbar!
 What the hell is going on here?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16324 [Applications/Tor Browser]: Focusing the search bar is already creating/using a catchall circuit

[Tor Bug Tracker & Wiki]

#16324: Focusing the search bar is already creating/using a catchall circuit
--+---
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  not a bug
 Keywords:  tbb-linkability   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by gk):

 * status:  reopened => closed
 * resolution:   => not a bug


Comment:

 As I said, see #18762, in particular comment:3:ticket:18762.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19646 [Obfuscation/meek]: Mac OS: wrong location for meek browser profile

[Tor Bug Tracker & Wiki]

#19646: Mac OS: wrong location for meek browser profile
-+-
 Reporter:  mcs  |  Owner:  dcf
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Obfuscation/meek |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201608,tbb-|  Actual Points:
  regression,tbb-6.0-issues,meek |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by mcs):

 * keywords:  tbb-regression,tbb-6.0-issues,meek => TorBrowserTeam201608
 ,tbb-regression,tbb-6.0-issues,meek


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16324 [Applications/Tor Browser]: Focusing the search bar is already creating/using a catchall circuit (was: Focusing the search bar is already creating/using a circuit)

[Tor Bug Tracker & Wiki]

#16324: Focusing the search bar is already creating/using a catchall circuit
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  reopened
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-linkability   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by bugzilla):

 * keywords:   => tbb-linkability
 * status:  closed => reopened
 * resolution:  not a bug =>


Comment:

 TBB 6.5a2, no favicons, new tab, focus to the search bar and
 {{{
 getFirstPartyURI failed for
 
https://search.disconnect.me/searchTerms/search?ses=Google_option=US=tor:
 0x80070057
 }}}
 then messages from comment:2 and the description.
 Why not a bug?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16324 [Applications/Tor Browser]: Focusing the search bar is already creating/using a circuit

[Tor Bug Tracker & Wiki]

#16324: Focusing the search bar is already creating/using a circuit
--+---
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  not a bug
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by gk):

 * status:  new => closed
 * resolution:   => not a bug


Comment:

 We use a proxy and it turns out speculative connects are not issues if
 that's the case. This is not a bug. For a more detailed analysis, see
 #18762.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18762 [Applications/Tor Browser]: implement first-party isolation for OCSP generated by speculative connect

[Tor Bug Tracker & Wiki]

#18762: implement first-party isolation for OCSP generated by speculative 
connect
--+
 Reporter:  arthuredelstein   |  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  worksforme
 Keywords:  tbb-linkability   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by gk):

 * status:  new => closed
 * resolution:   => worksforme


Comment:

 Setting this to `WORKSFORME`. However, this still needs to get done on
 Mozilla's side when upstreaming our patches.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19875 [Core Tor/Tor]: shuffle our bridges when we load them from config

[Tor Bug Tracker & Wiki]

#19875: shuffle our bridges when we load them from config
--+--
 Reporter:  arma  |  Owner:
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.2.???
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  easy  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by hdevalence):

 Hi, a first patch is here:
 
https://code.ciph.re/hdevalence/tor/commit/4fda92e51bc5c69f5ba4c19c22184a1e0b87d9c1

 I'm not really sure what the right way to write a test for it is -- the
 description of the intended behaviour above relies on a bunch of other
 parts of tor behaving in a certain way (e.g., interaction with the
 statefile).  Testing just that `shuffle_bridge_list()` actually shuffles
 the list doesn't ensure the behaviour in the top of the ticket -- is that
 OK?

 Also, should this behaviour be configurable, instead of always-on?  Do
 people rely on bridge ordering?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19813 [Metrics/CollecTor]: define release process and do release of milestone 1.0.0

[Tor Bug Tracker & Wiki]

#19813: define release process and do release of milestone 1.0.0
---+-
 Reporter:  iwakeh |  Owner:  karsten
 Type:  task   | Status:  needs_review
 Priority:  Medium |  Milestone:  CollecTor 1.0.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-
Changes (by iwakeh):

 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19813 [Metrics/CollecTor]: define release process and do release of milestone 1.0.0

[Tor Bug Tracker & Wiki]

#19813: define release process and do release of milestone 1.0.0
---+-
 Reporter:  iwakeh |  Owner:  karsten
 Type:  task   | Status:  new
 Priority:  Medium |  Milestone:  CollecTor 1.0.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-

Comment (by iwakeh):

 This
 [https://gitweb.torproject.org/user/iwakeh/collector.git/commit/?h=task-19813
 README] should be added here.  I adapted it from metrics-lib and hope the
 steps will be the same.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18734 [Metrics/CollecTor]: Installation Guide for Operators

[Tor Bug Tracker & Wiki]

#18734: Installation Guide for Operators
---+-
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  task   | Status:  closed
 Priority:  Medium |  Milestone:  CollecTor 1.0.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:  implemented
 Keywords:  ctip   |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-
Changes (by iwakeh):

 * status:  assigned => closed
 * resolution:   => implemented


Comment:

 Replying to [comment:11 karsten]:
 > Both patches look good.  Rebased and pushed to
 [https://gitweb.torproject.org/karsten/metrics-db.git/log/?h=task-19720 my
 task-19720 branch] on top of other changes that are supposed to go into
 1.0.0 today (whee!).  Thanks!

 Great! Thanks!
 All done in this ticket.
 Closing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19170 [Metrics/CollecTor]: make parsing more robust (extra-info)

[Tor Bug Tracker & Wiki]

#19170: make parsing more robust (extra-info)
---+-
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  defect | Status:  merge_ready
 Priority:  Medium |  Milestone:  CollecTor 1.0.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords:  ctip   |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-
Changes (by iwakeh):

 * status:  needs_revision => merge_ready


Comment:

 Indeed, I overlooked something obvious and you're right. Sorry for the
 confusion, for some reason I though a different class was responsible.  I
 luckily still had the old log file were I could see which class logged.

 So, ready for merge, all fine.
 (Except that a test documenting the change is lacking, but that might be
 tricky to implement currently?)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19720 [Metrics/CollecTor]: CollecTor should be re-configurable without restart

[Tor Bug Tracker & Wiki]

#19720: CollecTor should be re-configurable without restart
---+-
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  enhancement| Status:  needs_review
 Priority:  High   |  Milestone:  CollecTor 1.0.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords:  ctip   |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-

Comment (by iwakeh):

 Here the
 
[https://docs.oracle.com/javase/7/docs/api/java/nio/file/attribute/BasicFileAttributes.html#lastModifiedTime%28%29
 api doc] from Oracle.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19720 [Metrics/CollecTor]: CollecTor should be re-configurable without restart

[Tor Bug Tracker & Wiki]

#19720: CollecTor should be re-configurable without restart
---+-
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  enhancement| Status:  needs_review
 Priority:  High   |  Milestone:  CollecTor 1.0.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords:  ctip   |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-

Comment (by iwakeh):

 Well, as is said in the INSTALL.md your on your own when not on Debian
 stable.

 Could you verify that the tests w/o the above changes pass on the target
 server environment?
 If that is the case, it's fine.

 The modified time is apparently set differently or the implementation
 between Java/hsf is different on OSX/hfs than on Linux/ext.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17053 [HTTPS Everywhere/EFF-HTTPS Everywhere]: add always try https:// option

[Tor Bug Tracker & Wiki]

#17053: add always try https:// option
---+--
 Reporter:  elypter|  Owner:  jsha
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:
Component:  HTTPS Everywhere/EFF-HTTPS Everywhere  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by bugzilla):

 * severity:   => Normal


Comment:

 Good replacement for "Block all unencrypted requests" menu option
 (especially, looking at the name of the add-on).

 (Is this bug tracker still functioning?)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19720 [Metrics/CollecTor]: CollecTor should be re-configurable without restart

[Tor Bug Tracker & Wiki]

#19720: CollecTor should be re-configurable without restart
---+-
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  enhancement| Status:  needs_review
 Priority:  High   |  Milestone:  CollecTor 1.0.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords:  ctip   |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-

Comment (by karsten):

 File system is `/dev/disk1 on / (hfs, local, journaled)` on Mac OS X El
 Capitan 10.11.6.  Applying both diffs manually fixes
 `testConfigUnreadable()` but still doesn't fix `testConfigChange()`.  Hmm.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19720 [Metrics/CollecTor]: CollecTor should be re-configurable without restart

[Tor Bug Tracker & Wiki]

#19720: CollecTor should be re-configurable without restart
---+-
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  enhancement| Status:  needs_review
 Priority:  High   |  Milestone:  CollecTor 1.0.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords:  ctip   |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-

Comment (by iwakeh):

 A change for testConfigChange; now really writing to the file.

 {{{
 @@ -19,6 +19,7 @@ import org.junit.rules.TemporaryFolder;
  import java.io.ByteArrayInputStream;
  import java.io.File;
  import java.lang.reflect.Field;
 +import java.nio.file.Files;
  import java.nio.file.Paths;
  import java.util.Arrays;
  import java.util.Observable;
 @@ -173,7 +174,6 @@ public class ConfigurationTest {
  conf.setWatchableSourceAndLoad(Paths.get("/tmp/phantom.path"));
}

 -  @Ignore("Test fails: Update was not called.")
@Test()
public void testConfigChange() throws Exception {
  Configuration conf = new Configuration();
 @@ -183,17 +183,17 @@ public class ConfigurationTest {
called.set(true);
  }
});
 -File confFile = tmpf.newFile("empty");
 +File confFile = tmpf.newFile("emptyConf");
  conf.setWatchableSourceAndLoad(confFile.toPath());
  confFile.setLastModified(System.currentTimeMillis());
 -MainTest.waitSec(6);
 +Files.write(confFile.toPath(), "##".getBytes());
 +MainTest.waitSec(10);
  assertTrue("Update was not called.", called.get());
  called.set(false);
 -MainTest.waitSec(6);
 +MainTest.waitSec(10);
  assertFalse("Update was called.", called.get());
}
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19720 [Metrics/CollecTor]: CollecTor should be re-configurable without restart

[Tor Bug Tracker & Wiki]

#19720: CollecTor should be re-configurable without restart
---+-
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  enhancement| Status:  needs_review
 Priority:  High   |  Milestone:  CollecTor 1.0.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords:  ctip   |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-

Comment (by iwakeh):

 What file system are you testing on?

 Does the following make the second test work?

 {{{
 diff --git
 a/src/test/java/org/torproject/collector/conf/ConfigurationTest.java
 b/src/test/java/org/torproject/collector/conf/ConfigurationTest.java
 index 6013d09..24ab17d 100644
 --- a/src/test/java/org/torproject/collector/conf/ConfigurationTest.java
 +++ b/src/test/java/org/torproject/collector/conf/ConfigurationTest.java
 @@ -173,7 +173,6 @@ public class ConfigurationTest {
  conf.setWatchableSourceAndLoad(Paths.get("/tmp/phantom.path"));
}

 -  @Ignore("Test fails: Update was not called.")
@Test()
public void testConfigChange() throws Exception {
  Configuration conf = new Configuration();
 @@ -193,7 +192,6 @@ public class ConfigurationTest {
  assertFalse("Update was called.", called.get());
}

 -  @Ignore("Test fails: expected:<0> but was:<2>")
@Test()
public void testConfigUnreadable() throws Exception {
  Configuration conf = new Configuration();
 @@ -206,17 +204,19 @@ public class ConfigurationTest {
  File confFile = tmpf.newFile("empty");
  conf.setWatchableSourceAndLoad(confFile.toPath());
  confFile.delete();
 -conf.setProperty(Key.CompressRelayDescriptorDownloads.name(),
 "false");
 -conf.setProperty(Key.ImportDirectoryArchives.name(), "false");
  Dummy dummy = new Dummy(conf);
 +Field confField = CollecTorMain.class.getDeclaredField("config");
 +confField.setAccessible(true);
 +Configuration dummiesConf = (Configuration)(confField.get(dummy));
 +dummiesConf.setProperty(Key.CompressRelayDescriptorDownloads.name(),
 +"false");
 +dummiesConf.setProperty(Key.ImportDirectoryArchives.name(), "false");
 +assertEquals(2, dummiesConf.size());
  tmpf.newFolder("empty");
  MainTest.waitSec(6);
  assertFalse("Update was called.", called.get());
  assertEquals(0, conf.size());
 -Field confField = CollecTorMain.class.getDeclaredField("config");
 -confField.setAccessible(true);
 -int size = ((Configuration)(confField.get(dummy))).size();
 -assertEquals(2, size);
 +assertEquals(2, dummiesConf.size());
}

  }

 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19720 [Metrics/CollecTor]: CollecTor should be re-configurable without restart

[Tor Bug Tracker & Wiki]

#19720: CollecTor should be re-configurable without restart
---+-
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  enhancement| Status:  needs_review
 Priority:  High   |  Milestone:  CollecTor 1.0.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords:  ctip   |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-

Comment (by karsten):

 Hmm, no, that doesn't fix the tests.  Here's what I get after reverting
 that `Ignore` temp commit:

 {{{
 [junit] Testcase: testBoolValues took 0.513 sec
 [junit] Testcase: testPathValueException took 0.006 sec
 [junit] Testcase: testArrayValueException took 0.001 sec
 [junit] Testcase: testConfigUnreadable took 6.015 sec
 [junit] FAILED
 [junit] expected:<0> but was:<2>
 [junit] junit.framework.AssertionFailedError: expected:<0> but was:<2>
 [junit] at
 
org.torproject.collector.conf.ConfigurationTest.testConfigUnreadable(ConfigurationTest.java:212)
 [junit]
 [junit] Testcase: testConfiguration took 0 sec
 [junit] Testcase: testIntValueException took 0.001 sec
 [junit] Testcase: testSetWatchableSourceAndLoad took 0.002 sec
 [junit] Testcase: testArrayArrayValueException took 0.001 sec
 [junit] Testcase: testArrayValues took 0.004 sec
 [junit] Testcase: testIntValues took 0.001 sec
 [junit] Testcase: testConfigChange took 6.006 sec
 [junit] FAILED
 [junit] Update was not called.
 [junit] junit.framework.AssertionFailedError: Update was not called.
 [junit] at
 
org.torproject.collector.conf.ConfigurationTest.testConfigChange(ConfigurationTest.java:188)
 [junit]
 [junit] Testcase: testFileValues took 0.001 sec
 [junit] Testcase: testBoolValueException took 0.001 sec
 [junit] Testcase: testKeyCount took 0.001 sec
 [junit] Testcase: testArrayArrayValues took 0.001 sec
 [junit] Testcase: testUrlValueException took 0.001 sec
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19720 [Metrics/CollecTor]: CollecTor should be re-configurable without restart

[Tor Bug Tracker & Wiki]

#19720: CollecTor should be re-configurable without restart
---+-
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  enhancement| Status:  needs_review
 Priority:  High   |  Milestone:  CollecTor 1.0.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords:  ctip   |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-

Comment (by iwakeh):

 That's odd, I checked out your merged branch, removed the `Ignore`
 annotations from `ConfigurationTest` and everything worked fine.

 Maybe, let the tests wait longer, i.e. set the lines
 `MainTest.waitSec(6);` of the respective tests to `MainTest.waitSec(10);`.
 Could you try if that works?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19170 [Metrics/CollecTor]: make parsing more robust (extra-info)

[Tor Bug Tracker & Wiki]

#19170: make parsing more robust (extra-info)
---+-
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  defect | Status:  needs_revision
 Priority:  Medium |  Milestone:  CollecTor 1.0.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords:  ctip   |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-

Comment (by karsten):

 I believe that descriptor will not be skipped and stored.  What makes you
 think otherwise?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19170 [Metrics/CollecTor]: make parsing more robust (extra-info)

[Tor Bug Tracker & Wiki]

#19170: make parsing more robust (extra-info)
---+-
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  defect | Status:  needs_revision
 Priority:  Medium |  Milestone:  CollecTor 1.0.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords:  ctip   |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-

Comment (by iwakeh):

 You're change [https://gitweb.torproject.org/karsten/metrics-
 db.git/log/?h=task-19170 in here] is fine and can go into 1.0.0.

 It's just not sufficiently solving this ticket.  The extra-info could be
 read, all information necessary for storing is ascii and readable, just
 these few country codes are non-ascii.
 Or, am I overlooking something?

 The following will be skipped and not stored:

 {{{
 @type extra-info 1.0

 extra-info SweTor247 4FF069CA2B2D1A76C7AB451EFB7117F29AEF750A
 published 2016-05-22 16:43:55
 write-history 2016-05-22 16:32:25 (900 s)
 
1357860864,1486376960,1279031296,1351328768,1743697920,2200178688,1234156544,1523289088,1551633408,1621464064,1254597632,1775264768,1689665536,1753520128,1103904768,1434341376,1150939136,967985152,895990784,1302690816,1300997120,947147776,1441388544,1407930368,1558607872,1063849984,916183040,1294087168,1107414016,1026692096,1144520704,1861045248,1282239488,1273192448,1158875136,1321010176,945436672,720959488,723689472,1121559552,1056056320,746829824,705452032,910871552,1741348864,809389056,817775616,1078247424,1004999680,1189643264,705234944,1284806656,1980861440,1514937344,838163456,1152607232,1203712000,1020697600,906333184,1218160640,1198831616,835339264,1586464768,2203707392,1559570432,1039450112,1134445568,1238086656,1253769216,1233560576,1691033600,1659950080,1356476416,1166150656,889988096,1218139136,1569614848,1237613568,1162537984,1312793600,1228486656,1187644416,1113488384,1428703232,1186930688,998151168,1278302208,1259377664,1092085760,1001015296,1191922688,1477314560,133
 7351168,1455647744,974535680,1528930304
 read-history 2016-05-22 16:32:25 (900 s)
 
1332578304,1448282112,1254513664,1324864512,1714417664,2170276864,1203768320,1480467456,1523788800,1583406080,1221485568,1746613248,1660780544,1711060992,1076665344,1403919360,1125062656,931348480,868599808,1276554240,1274421248,923617280,1413637120,1372585984,1531207680,1032589312,898709504,1270477824,1081565184,1002877952,1121116160,1838573568,1259815936,1247204352,1134850048,1294400512,920386560,693218304,710129664,1097239552,1029796864,715806720,690363392,885669888,1722977280,782941184,789390336,1056364544,981941248,1157256192,674372608,1265626112,1953830912,1484488704,815069184,1126297600,1173146624,989871104,883805184,1192287232,1172829184,808004608,1563955200,2174199808,1531340800,1005859840,1106042880,1209826304,1215944704,1204684800,1657624576,1623773184,1321722880,1129592832,859763712,1191492608,1539031040,1200889856,1137287168,1283620864,1196333056,1147316224,1086354432,1395887104,1154003968,975105024,1249856512,1233748992,1061946368,968668160,1165745152,1449252864,130211
 3280,1418886144,941774848,1504149504
 dirreq-write-history 2016-05-22 16:38:42 (900 s)
 
26721280,26181632,22713344,18153472,30959616,27491328,23710720,33908736,30176256,29278208,26059776,23006208,31754240,32760832,26696704,19438592,26868736,30183424,19349504,20831232,20793344,20324352,35196928,19519488,23652352,23080960,14424064,17801216,22862848,16696320,19476480,17430528,21992448,21087232,18184192,23530496,23248896,17436672,12994560,19902464,25379840,23402496,10625024,18203648,19986432,20084736,23708672,17466368,19121152,30393344,16679936,14265344,27670528,21859328,23498752,22908928,21556224,25786368,16757760,23324672,20441088,21089280,19623936,22488064,26152960,26180608,23634944,25591808,25244672,26862592,26347520,32198656,31865856,26145792,23252992,24669184,29142016,20024320,22441984,25981952,26183680,31656960,23510016,28493824,26350592,21965824,20175872,27035648,23478272,25636864,23432192,23070720,33317888,23294976,28601344,27546624
 dirreq-read-history 2016-05-22 16:38:42 (900 s)
 
1080320,988160,893952,980992,803840,1124352,1157120,522240,451584,670720,1185792,701440,845824,804864,617472,487424,409600,909312,688128,741376,381952,664576,1137664,591872,783360,539648,562176,498688,319488,802816,352256,1174528,293888,785408,299008,1057792,389120,432128,291840,414720,657408,318464,351232,724992,330752,365568,648192,856064,930816,601088,514048,332800,381952,486400,753664,768000,588800,633856,472064,621568,693248,582656,687104,483328,508928,835584,675840,1278976,832512,596992,728064,1417216,1032192,706560,791552,623616,710656,568320,901120,917504,1327104,1090560,954368,1106944,1076224,946176,679936,1252352,1022976,1053696,1033216,536576,933888,32,885760,1418240
 geoip-db-digest 

Re: [tor-bugs] #18734 [Metrics/CollecTor]: Installation Guide for Operators

[Tor Bug Tracker & Wiki]

#18734: Installation Guide for Operators
---+-
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  task   | Status:  assigned
 Priority:  Medium |  Milestone:  CollecTor 1.0.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords:  ctip   |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-
Changes (by karsten):

 * status:  needs_review => assigned


Comment:

 Both patches look good.  Rebased and pushed to
 [https://gitweb.torproject.org/karsten/metrics-db.git/log/?h=task-19720 my
 task-19720 branch] on top of other changes that are supposed to go into
 1.0.0 today (whee!).  Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19170 [Metrics/CollecTor]: make parsing more robust (extra-info)

[Tor Bug Tracker & Wiki]

#19170: make parsing more robust (extra-info)
---+-
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  defect | Status:  needs_revision
 Priority:  Medium |  Milestone:  CollecTor 1.0.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords:  ctip   |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-

Comment (by karsten):

 I'm still unclear what you refer to.  I believe we're now accepting those
 descriptors with non-ASCII country codes in extra-info descriptors that we
 rejected earlier.  What case do you have in mind where we're not accepting
 descriptors because of ASCII conversion failures?  Note that we need to
 perform some basic checks and computations to parse the descriptor
 publication time, find out the descriptor digest, etc., so that we can
 store it.  Part of the requirements are an ASCII string at the beginning
 and the end of the descriptor that tells us what part to compute the
 digest of.  If those are not ASCII, we cannot process the descriptor.  And
 if anything in between is not ASCII, we shouldn't complain, well, after
 applying this patch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19691 [Obfuscation/BridgeDB]: does not re-open logfiles properly

[Tor Bug Tracker & Wiki]

#19691: does not re-open logfiles properly
--+--
 Reporter:  weasel|  Owner:  isis
 Type:  defect| Status:  reopened
 Priority:  High  |  Milestone:
Component:  Obfuscation/BridgeDB  |Version:
 Severity:  Normal| Resolution:
 Keywords:  bridgedb-0.3.7|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by weasel):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 {{{
 tor-nagios: [polyanthum] upgraded libraries is WARNING: The following
 processes have libs linked that were upgraded: bridgedb: flog (20566)
 }}}

 I suspect the logrotate configuration should include a postrotate snippet
 to send a SIGHUP to flog.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19720 [Metrics/CollecTor]: CollecTor should be re-configurable without restart

[Tor Bug Tracker & Wiki]

#19720: CollecTor should be re-configurable without restart
---+-
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  enhancement| Status:  needs_review
 Priority:  High   |  Milestone:  CollecTor 1.0.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords:  ctip   |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-

Comment (by karsten):

 Please review [https://gitweb.torproject.org/karsten/metrics-
 db.git/log/?h=task-19720 my task-19720 branch] which contains your
 patches, rebased to master.  And please take a look at the temp commit
 that ignores two tests that somehow don't pass.  We should fix those
 tests.  Happy to apply a fixup commit and revert that temp commit.  (I'll
 also add more commits to that same branch in preparation of the release.
 Feel free to ignore those in the context of this ticket.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19170 [Metrics/CollecTor]: make parsing more robust (extra-info)

[Tor Bug Tracker & Wiki]

#19170: make parsing more robust (extra-info)
---+-
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  defect | Status:  needs_revision
 Priority:  Medium |  Milestone:  CollecTor 1.0.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords:  ctip   |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-
Changes (by iwakeh):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:18 karsten]:
 > Replying to [comment:16 iwakeh]:
 > > The patch doesn't correct the extra-info descriptor part
 
[https://gitweb.torproject.org/collector.git/tree/src/main/java/org/torproject/collector/relaydescs/RelayDescriptorParser.java#n272
 here and below] (afaict)?
 >
 > Hmm, I don't yet see what you mean.  The only place where we're using
 metrics-lib's `DescriptorParser` to parse a byte array is
 `ArchiveWriter#store()`.  The `haveParsed...` method called below the
 place you referenced only tells the downloader that we have parsed a
 descriptor and that it should attempt to fetch any descriptors referenced
 from it.  And the ASCII conversion above is only there to find descriptor
 start and end, though we're computing the digest on the non-converted byte
 array.  Can you give an example of a case where we're still rejecting a
 descriptor only because of metrics-lib?

 Not because of metrics-lib, but this ticket is mostly about these extra-
 info descriptors that are not stored, b/c of ascii conversion failure.
 The metrics-lib part is fine, but a different reason.
 So, only half is fixed.

 Can this be fixed for 1.0.0?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #12736 [Applications/Tor Browser]: DLL hijacking vulnerability in TBB

[Tor Bug Tracker & Wiki]

#12736: DLL hijacking vulnerability in TBB
+--
 Reporter:  underdoge   |  Owner:  tbb-team
 Type:  defect  | Status:  new
 Priority:  High|  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-security, TorBrowserTeam201608  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * keywords:  tbb-security => tbb-security, TorBrowserTeam201608
 * severity:   => Normal


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19170 [Metrics/CollecTor]: make parsing more robust (extra-info)

[Tor Bug Tracker & Wiki]

#19170: make parsing more robust (extra-info)
---+-
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:  CollecTor 1.0.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords:  ctip   |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-
Changes (by karsten):

 * milestone:   => CollecTor 1.0.0


Comment:

 Should this go into 1.0.0?  Assigning to the milestone just to make sure
 we don't forget about it, but feel free to move to another milestone if
 1.0.0 won't work.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19837 [Applications/Tor Browser]: Audio/video player is blank in 6.5a2

[Tor Bug Tracker & Wiki]

#19837: Audio/video player is blank in 6.5a2
-+-
 Reporter:  dcf  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-regression,  |  Actual Points:
  TorBrowserTeam201608   |
Parent ID:  #8725| Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * parent:   => #8725


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs