Re: [tor-bugs] #20030 [Obfuscation/meek]: meek-http-helper doesn't shutdown cleanly in 6.5a1

[Tor Bug Tracker & Wiki]

#20030: meek-http-helper doesn't shutdown cleanly in 6.5a1
--+--
 Reporter:  arlolra   |  Owner:  dcf
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Obfuscation/meek  |Version:
 Severity:  Normal| Resolution:
 Keywords:  regression|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by dcf):

 * keywords:   => regression
 * status:  new => needs_review


Comment:

 attachment:0001-Ignore-SIGPIPE-in-meek-client-torbrowser.patch works
 around the problem by ignoring SIGPIPE. I found I had to call
 signal.Notify with a dummy channel; calling signal.Ignore didn't work.

 I think we're fine with ignoring logging errors. The log package ignores
 them anyway. I'm a bit worried that because Go's SIGPIPE rule affects both
 stdin and stdout, something might go wrong with the PT negotiation on
 stdout. goptlib doesn't report errors that may arise from its writes to
 stdout. But I couldn't think of a way it would cause a problem, and even
 if it does it should be rare.

 arlolra, if you want to test this, you can just `go build` in the meek-
 client-torbrowser subdirectory, then copy meek-client-torbrowser into your
 bundle directory.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20215 [Applications/Tor Browser]: Tor Browser fails to load on macOS Sierra 10.12 release

[Tor Bug Tracker & Wiki]

#20215: Tor Browser fails to load on macOS Sierra 10.12 release
-+-
 Reporter:  sighmon  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:  Tor:
 |  0.2.9.2-alpha
 Severity:  Blocker  | Resolution:
 Keywords:  torbrowser, macOS, sierra, 10.12,|  duplicate
  control, port  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sighmon):

 Replying to [comment:3 mcs]:
 > A quick fix is to edit ~/Library/Application Support/TorBrowser-
 Data/Browser/*.default/prefs.js using your favorite text editor and add
 this line:
 >  user_pref("extensions.torlauncher.control_port_use_socket", false);

 Awesome, thank you. :-)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20030 [Obfuscation/meek]: meek-http-helper doesn't shutdown cleanly in 6.5a1

[Tor Bug Tracker & Wiki]

#20030: meek-http-helper doesn't shutdown cleanly in 6.5a1
--+-
 Reporter:  arlolra   |  Owner:  dcf
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Obfuscation/meek  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-

Comment (by dcf):

 I tested compiling with various versions of Go and the earliest version
 that doesn't work is 1.6. 1.5.4 works, 1.6 doesn't.

 > Strangely enough, if I add `-log meek-client-torbrowser.log` after
 `meek-client-torbrowser` in Browser/TorBrowser/Data/Tor/torrc-defaults,
 then it kills the process cleanly.

 Here's what's going wrong: once it receives a signal, meek-client-
 torbrowser writes to its log as it shuts down. By default the log lines go
 to stderr. But meek-client-torbrowser's stderr is the same as its parent
 process's (tor's) stderr. Once tor terminates, trying to write to the log
 results in a SIGPIPE that kills meek-client-torbrowser before it can
 terminate its subprocesses.

 Why this only started happening with Go 1.6? See this
 [https://golang.org/doc/go1.6#minor_library_changes excerpt from the
 release notes]:
   On Unix-like systems, when a write to `os.Stdout` or `os.Stderr` (more
 precisely, an `os.File` opened for file descriptor 1 or 2) fails due to a
 broken pipe error, the program will raise a `SIGPIPE` signal. By default
 this will cause the program to exit; this may be changed by calling the
 `os/signal` `Notify` function for `syscall.SIGPIPE`. A write to a broken
 pipe on a file descriptor other 1 or 2 will simply return `syscall.EPIPE`
 (possibly wrapped in `os.PathError` and/or `os.SyscallError`) to the
 caller. The old behavior of raising an uncatchable `SIGPIPE` signal after
 10 consecutive writes to a broken pipe no longer occurs.

 That's why logging to a file avoided the error: the output pipe was no
 longer being broken.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #2045 [Core Tor/Tor]: Make tor_check_port_forwarding handle incomplete lines

[Tor Bug Tracker & Wiki]

#2045: Make tor_check_port_forwarding handle incomplete lines
--+--
 Reporter:  sjmurdoch |  Owner:  sjmurdoch
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.2.???
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-relay |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by pingl):

 * severity:   => Normal


Comment:

 What about using `getline` instead of `fgets`? I've modified
 `tor_read_all_handle` to use `getline` instead of `fgets`

 Here it is the link of the branch

 https://github.com/aigna/tor/tree/defect-2045

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20030 [Obfuscation/meek]: meek-http-helper doesn't shutdown cleanly in 6.5a1

[Tor Bug Tracker & Wiki]

#20030: meek-http-helper doesn't shutdown cleanly in 6.5a1
--+-
 Reporter:  arlolra   |  Owner:  dcf
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Obfuscation/meek  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-

Comment (by dcf):

 I've isolated the problem to the meek-client-torbrowser file. If you take
 a fresh installation of 6.0a5 (which does not have this bug), and copy
 Browser/TorBrowser/Tor/PluggableTransports/meek-client-torbrowser from
 6.5a1, then the bug occurs.

 The meek-client-torbrowser in 6.0a5 and 6.5a1 are built from slightly
 different sources: [https://gitweb.torproject.org/pluggable-
 transports/meek.git/diff/?id=0.22-18371-3=0.22-18371-2 0.22-18371-2
 versus 0.22-18371-3]. That, however, doesn't seem to be the cause of the
 problem.

 The actual problem seems to be changed Go version,
 [https://gitweb.torproject.org/builders/tor-browser-
 bundle.git/commit/?id=778fd2d07bc40c0458ad7a477b6079a99305071d from 1.4.2
 to 1.6.2]. If I recompile meek-client-torbrowser 0.22-18371-3 with go1.3.3
 from Debian stable, then the error does not occur. If I compile it with
 go1.7.1 from Debian testing, the error does occur.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20242 [Core Tor/Tor]: update changelog to say how many fallbacks we removed and how many remain

[Tor Bug Tracker & Wiki]

#20242: update changelog to say how many fallbacks we removed and how many 
remain
-+-
 Reporter:  arma |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.2.???
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  029-proposed, TorCoreTeam201609  |  Actual Points:  0.1
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * keywords:  029-proposed => 029-proposed, TorCoreTeam201609


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20242 [Core Tor/Tor]: update changelog to say how many fallbacks we removed and how many remain

[Tor Bug Tracker & Wiki]

#20242: update changelog to say how many fallbacks we removed and how many 
remain
--+
 Reporter:  arma  |  Owner:  teor
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.2.???
Component:  Core Tor/Tor  |Version:  Tor: 0.2.9.3-alpha
 Severity:  Normal| Resolution:
 Keywords:  029-proposed  |  Actual Points:  0.1
Parent ID:| Points:  0.1
 Reviewer:|Sponsor:
--+

Comment (by teor):

 I also added example changelog entries to the fallback update
 instructions, so we should write better messages in future:

 
https://trac.torproject.org/projects/tor/wiki/doc/UpdatingFallbackDirectoryMirrors#FormattingChangesFiles

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20242 [Core Tor/Tor]: update changelog to say how many fallbacks we removed and how many remain

[Tor Bug Tracker & Wiki]

#20242: update changelog to say how many fallbacks we removed and how many 
remain
--+
 Reporter:  arma  |  Owner:  teor
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.2.???
Component:  Core Tor/Tor  |Version:  Tor: 0.2.9.3-alpha
 Severity:  Normal| Resolution:
 Keywords:  029-proposed  |  Actual Points:  0.1
Parent ID:| Points:  0.1
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * status:  assigned => needs_review
 * version:   => Tor: 0.2.9.3-alpha
 * milestone:   => Tor: 0.2.???
 * points:   => 0.1
 * actualpoints:   => 0.1
 * keywords:   => 029-proposed


Comment:

 Please see the branch rewrite-fallback-changelog on my github.
 I don't know how to reflow changelog entries, hopefully the spacing isn't
 too far off.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20243 [Core Tor/Tor]: Update fallback directories for 0.2.8.9

[Tor Bug Tracker & Wiki]

#20243: Update fallback directories for 0.2.8.9
--+
 Reporter:  teor  |  Owner:
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.2.8.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.2.8.8
 Severity:  Normal| Resolution:
 Keywords:  must-fix-before-0289  |  Actual Points:
Parent ID:  #20170| Points:  0.2
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * type:  defect => enhancement


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #20243 [Core Tor/Tor]: Update fallback directories for 0.2.8.9

[Tor Bug Tracker & Wiki]

#20243: Update fallback directories for 0.2.8.9
--+--
 Reporter:  teor  |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.2.8.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.2.8.8
 Severity:  Normal|   Keywords:  must-fix-before-0289
Actual Points:|  Parent ID:  #20170
   Points:  0.2   |   Reviewer:
  Sponsor:|
--+--
 I fully expect this ticket to be obsoleted by the 0.2.9 fallback list in
 #18828 & #20170.

 But there will soon be a branch on my github where I'm removing fallbacks
 just in case we do a 0.2.8.9: fallbacks-0289.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #20242 [Core Tor/Tor]: update changelog to say how many fallbacks we removed and how many remain

[Tor Bug Tracker & Wiki]

#20242: update changelog to say how many fallbacks we removed and how many 
remain
--+-
 Reporter:  arma  |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+-
 I just talked to teor about an idea where, when we say things like
 {{{
 - Remove broken entries from the hard-coded fallback directory list.
   Closes ticket 20190; patch by teor.
 }}}
 we should say how many we removed and how many remain.

 This will be useful in the short term for reassuring ourselves that enough
 remain, and in the longer term for analyzing patterns in how our working
 fallback sets decay.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19858 [Core Tor/Tor]: Move guard state out of globals per new guard plan

[Tor Bug Tracker & Wiki]

#19858: Move guard state out of globals per new guard plan
--+
 Reporter:  andrea|  Owner:  andrea
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  6
Parent ID:  #19877| Points:  3
 Reviewer:|Sponsor:  SponsorU-must
--+

Comment (by nickm):

 Thanks!  Would you like to make a gitlab pull request for this so it's
 easier for me to review? Or should I?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20030 [Obfuscation/meek]: meek-http-helper doesn't shutdown cleanly in 6.5a1 (was: meek-http-helper doesn't shutdown cleanly in 6.5a2)

[Tor Bug Tracker & Wiki]

#20030: meek-http-helper doesn't shutdown cleanly in 6.5a1
--+-
 Reporter:  arlolra   |  Owner:  dcf
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Obfuscation/meek  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-

Comment (by dcf):

 The first release that has a problem is 6.5a1. I tested:
 {{{
 6.0.3 - ok
 6.0.4 - ok
 6.0.5 - ok

 6.0a5 - ok
 6.5a1 - bad
 6.5a2 - bad
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #12774 [Obfuscation/meek]: "Firefox is already running" when you select meek after bootstrapping

[Tor Bug Tracker & Wiki]

#12774: "Firefox is already running" when you select meek after bootstrapping
--+-
 Reporter:  dcf   |  Owner:  dcf
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Obfuscation/meek  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-
Changes (by dcf):

 * severity:   => Normal


Comment:

 Replying to [comment:1 dcf]:
 > So we should try starting the helper with either "-allow-remote -new-
 instance" or "-allow-remote".

 Mozilla bug [https://bugzilla.mozilla.org/show_bug.cgi?id=855899 855899]
 says that -new-instance doesn't work on Windows.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20228 [Metrics/CollecTor]: Append all votes with same valid-after time to a single file in `recent/`

[Tor Bug Tracker & Wiki]

#20228: Append all votes with same valid-after time to a single file in 
`recent/`
---+-
 Reporter:  karsten|  Owner:
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-

Comment (by karsten):

 Hmm, here's something we still need to decide: it may happen that we're
 learning about a vote out of band.  For example, we may only receive six
 votes for a given valid-after time and learn about a seventh vote in the
 next run when synchronizing from other CollecTor instances.  We could do
 two things in that situation: store votes under the time when we stored
 them (e.g., `2016-09-23-15-05-03-votes`) or append to an existing votes
 file and hence modifying its size and last-modified time (e.g.,
 `2016-09-23-15-00-00-votes`).  We're doing the second variant for server
 descriptors and other descriptors where we're appending descriptors.
 That's also my favorite solution, except there are benefits of the first
 variant (or a third variant) that I didn't see.  Hmm.

 Regarding the notice, how about we send something to tor-dev@ and give two
 weeks time (because everyone's busy with the meeting)?  Or would that
 delay other things too much?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20234 [Metrics/CollecTor]: Define CollecTor's file-structure protocol 1.0 (was: Agree on common directory structure for CollecTor's web page)

[Tor Bug Tracker & Wiki]

#20234: Define CollecTor's file-structure protocol 1.0
---+-
 Reporter:  karsten|  Owner:
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-

Comment (by karsten):

 Works for me!  Want to make it happen?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13893 [Applications/Tor Browser]: Torbrowser crashes on start when using MS EMET 5.x

[Tor Bug Tracker & Wiki]

#13893: Torbrowser crashes on start when using MS EMET 5.x
-+-
 Reporter:  Diapolo  |  Owner:  gk
 Type:  defect   | Status:
 |  needs_information
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-security, tbb-crash, tbb-|  Actual Points:
  usability-stoppoint-app, fuck-mingw-gcc,   |
  GeorgKoppen201609, TorBrowserTeam201609|
Parent ID:  #12820   | Points:
 Reviewer:   |Sponsor:
 |  SponsorU
-+-
Changes (by gk):

 * status:  needs_revision => needs_information


Comment:

 Okay, I seem to have a test build that fixes things for me. Could other
 EMET users that got hit by crashes test that one as well and report back
 whether there are still issues? It can be found on:

 https://people.torproject.org/~gk/testbuilds/torbrowser-install-tbb-
 nightly_62_ALL.exe
 https://people.torproject.org/~gk/testbuilds/torbrowser-install-tbb-
 nightly_62_ALL.exe.asc

 It uses the latest mingw-w64 and underneath GCC 6.2.0. I got it to compile
 our stuff after some pain and my current hypothesis is that the
 optimization bug got fixed in the GCC's 6.x series. I tested that with
 EMET 5.51 on a Windows 7 machine.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs