Re: [tor-bugs] #25886 [Core Tor/Tor]: Have frac_nodes_with_descriptors() take and use for_direct_connect

[Tor Bug Tracker & Wiki]

#25886: Have frac_nodes_with_descriptors() take and use for_direct_connect
-+-
 Reporter:  nickm|  Owner:  neel
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-bridge-client, tor-guard,|  Actual Points:
  bootstrap  |
Parent ID:   | Points:
 Reviewer:  dgoulet  |Sponsor:
-+-

Comment (by teor):

 Replying to [comment:11 neel]:
 > I have made the changes in a new GitHub PR:
 https://github.com/torproject/tor/pull/145
 >
 > This sets `f_guard` to 1.0 on bridges by checking if `UseBridges` is set
 and if the original `f_guard` is greater than 0 in
 `compute_frac_paths_available()`. I do understand that this may not be a
 perfect solution, and may also be rejected, but it is an alternative (that
 I thought of) to putting a ugly hack in `frac_nodes_with_descriptors()`
 that dgoulet had mentioned.

 We can't check if f_guard is non-zero, because most bridges don't have the
 guard flag.

 > I suggest we make f_guard = 1.0 in compute_frac_paths_available() if we
 are using bridges, and have at least one bridge with ~~the preferred~~ a
 full descriptor.

 Instead, we need to check the number of bridges with full descriptors.
 There is an existing function in bridges.h that does this check.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26304 [Applications/Tor Browser]: Update zlib to latest version (currently 1.2.11)

[Tor Bug Tracker & Wiki]

#26304: Update zlib to latest version (currently 1.2.11)
+--
 Reporter:  gk  |  Owner:  tbb-team
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201806R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * keywords:  tbb-rbm => tbb-rbm, TorBrowserTeam201806R
 * status:  new => needs_review


Comment:

 See `bug_26304` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_26304&id=b9a2dfe610121f88be74d8569ee2b9f904132670)
 for a version bump for review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26250 [Applications/Tor Browser]: Firefox 60 ESR compilation fails intermittently with Rust 1.25

[Tor Bug Tracker & Wiki]

#26250: Firefox 60 ESR compilation fails intermittently with Rust 1.25
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff60-esr, tbb-rbm,   |  Actual Points:
  TorBrowserTeam201806R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 `bug_26250_v5` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_26250_v5&id=61aac87c00ca7a1da9a1be9f2d181c7841769d4c)
 is what we want (I forgot the Linux bits in the previous branch).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24197 [Applications/Tor Browser]: Building Windows 64 firefox with the sandbox enabled fails

[Tor Bug Tracker & Wiki]

#24197: Building Windows 64 firefox with the sandbox enabled fails
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-rbm, GeorgKoppen201805,  |  Actual Points:
  TorBrowserTeam201806   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:15 tom]:
 > Mozilla bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1461421

 We cherry-picked the proposed fix (commit
 a64a7c2de648ad87f392e407a92589515a72b0ef on `tor-browser-60.0.1esr-8.0-1)
 and are good for now. We'll backport later on the fix that actually
 landed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26250 [Applications/Tor Browser]: Firefox 60 ESR compilation fails intermittently with Rust 1.25

[Tor Bug Tracker & Wiki]

#26250: Firefox 60 ESR compilation fails intermittently with Rust 1.25
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff60-esr, tbb-rbm,   |  Actual Points:
  TorBrowserTeam201806R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Okay, I've rebased my patch against `master` and updated neersighted's
 patch (the original patch applies cleanly now as it was against 1.26.1
 code). `bug_26250_v4` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_26250_v4&id=c62728741e6ebc6df4190b7c00d78b34a7789c2d)
 has all the changes for review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23231 [Applications/Tor Browser]: Error in STL wrappers when building Firefox 64-bit for Windows

[Tor Bug Tracker & Wiki]

#23231: Error in STL wrappers when building Firefox 64-bit for Windows
-+-
 Reporter:  boklm|  Owner:  tbb-team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201806R  |  Actual Points:
Parent ID:  #26203   | Points:
 Reviewer:   |Sponsor:  Sponsor4
-+-
Changes (by gk):

 * status:  new => needs_review
 * keywords:  ff60-esr, TorBrowserTeam201806 => ff60-esr,
 TorBrowserTeam201806R


Comment:

 `bug_23231` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_23231&id=aa79addec263ad31bad46f589e5964173b07d24f)
 removes out workaround as it got solved upstream.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26341 [Applications/Tor Browser]: Enable setting torbutton.use_nontor_proxy with an environment variable

[Tor Bug Tracker & Wiki]

#26341: Enable setting torbutton.use_nontor_proxy with an environment variable
--+---
 Reporter:  eyedeekay |  Owner:  tbb-team
 Type:  enhancement   | Status:  needs_information
 Priority:  Low   |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Trivial   | Resolution:
 Keywords:  tbb-torbutton |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by eyedeekay):

 Thanks for getting back to me. I didn't mean to imply that I would leave
 Tor Project strings and images in place, I understand how that
 misunderstanding arose and want to make sure that you know before anything
 I do reaches any upstream projects or distributions, I promise to remove
 misleading branding. Anything on my personal github should be considered a
 prototype or working copy. What I meant was that I would prefer to not
 introduce any new code if I could reasonably help it. On that subject, I
 had thought that the existing environment variables would be adequate to
 accomplish the removal of Tor Project markings, however, upon closer
 examination, this isn't the case. I'm going to put in some time this
 weekend to figure out exactly what I would need to do to accomplish this
 more thoroughly. Besides that, in Whonix, the Tor Browser is downloaded
 and started by two scripts, in the packages tb-updater and tb-starter.
 These are configured using environment variables that affect the settings
 in the Tor Browser Bundle at runtime. That way they can guarantee that the
 settings are not accidentally overwritten by an update, As they are stored
 outside the TBB itself and set at runtime, and they don't have to ship a
 different prefs.js. I had actually taken the prefs.js approach in a
 previous attempt to produce an i2p browser.

 As for domain isolation, i2p doesn't really provide a way to do it the way
 TBB does it. I think I remember reading somewhere, long ago, that the
 argument is that it isn't the core i2p router's job to do that, it should
 be done by an application that talks to the i2p API's(I am working on such
 an application). What it does instead is rotates the destination used for
 the http proxy, refreshing the destination when the router is restarted or
 after a configurable amount of idle time. It's obviously very simple to
 link people's browsing behavior across multiple eepSites if you own
 multiple eepSites, and it's also very easy to spin up multiple eepSites
 from anywhere. I can't speak for anyone else but the way I think about it
 is that, at least on i2p, I am the same person in every single browser
 tab. I'd personally like things to be more automatic, but I don't think
 this is an unreasonable mental model, as long I keep my promise to remove
 all TPO related labeling and provide adequate documentation. But in order
 to follow a path where the default i2p http proxy is used, I know this is
 the reason use_nontor_proxy must be set.

 So I shall reconsider my approach and get back to you.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25895 [Core Tor/Tor]: Cross-compiling tor rust for Windows is broken

[Tor Bug Tracker & Wiki]

#25895: Cross-compiling tor rust for Windows is broken
-+-
 Reporter:  gk   |  Owner:  Hello71
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, 034-proposed, tbb-wants,   |  Actual Points:
  033-backport, 034-roadmap-proposed,  034-must  |
Parent ID:  #25849   | Points:
 Reviewer:  catalyst |Sponsor:
-+-

Comment (by Hello71):

 Replying to [comment:19 catalyst]:
 > Replying to [comment:18 Hello71]:
 > > summary (for reviewing): https://cgit.alxu.ca/tor.git/diff/?id=rust-
 cross&id2=fix-rust-tests
 > Thanks for the patches! Could you please rebase them on the latest
 master? (without the fix-rust-tests patches?) They don't seem to apply
 cleanly. Also a GitHub pull request would help us to review the changes
 more effectively.

 Rebased. https://cgit.alxu.ca/tor.git/diff/?id=rust-cross&id2=master. I
 don't like GitHub. I use Travis grudgingly. https://travis-
 ci.org/Hello71/tor/builds/392516161

 > Please use some other variable like `RUST_TARGET` instead of `TARGET`
 because the variable `target` is set by autoconf someone passes the
 `--target=` option on the `./configure` command line. Or maybe an option
 like `--with-rust-target=` would be better? I'm not sure which would be
 more idiomatic.

 I renamed it to RUST_TARGET.

 > I think `CHOST` and `CBUILD` aren't standard autoconf terminology; what
 system uses those terms? `HOST` and `BUILD` would be better. (These are
 the terms that the help text in `./configure` uses to refer to the
 arguments passed to the `--host=` and `--build=` options.)

 Gentoo calls it CHOST (presumably because of this namespacing issue), I
 thought autoconf did too.

 As an aside, I researched how Firefox handles this, and it appears that
 they hardcode a list of targets: https://dxr.mozilla.org/mozilla-
 central/source/layout/style/ServoBindings.toml. I think this solution is
 ugly, especially since we aim for Tor to be as compatible as possible
 rather than limiting to Windows, Mac, Linux.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26376 [Core Tor/Tor]: add cross compiling docs

[Tor Bug Tracker & Wiki]

#26376: add cross compiling docs
--+--
 Reporter:  Hello71   |  Owner:  Hello71
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:  catalyst
  Sponsor:|
--+--
 since apparently nobody on #tor-dev knows, I wrote a document.

 https://cgit.alxu.ca/tor.git/commit/?h=building-tor-mingw-docs

 setting catalyst as reviewer since they say they tried it and it works.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26128 [Applications/Tor Browser]: Make security slider work with NoScript for ESR60

[Tor Bug Tracker & Wiki]

#26128: Make security slider work with NoScript for ESR60
-+-
 Reporter:  arthuredelstein  |  Owner:  tbb-team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201806R  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by ma1):

 Replying to [comment:8 arthuredelstein]:
 > Replying to [comment:5 mcs]:
 >
 > > * Do we have any kind of commitment from the NoScript author (Giorgio)
 that the IPC message we are using will continue to work with future
 releases of NoScript?

 Yes, the updateSettings responder is going to work for the foreseeable
 future.

 > But it would be better if we could define the protocol more formally.
 And what do you think about idea of NoScript accepting diffs to Settings
 (see comment:7)?


 If I understand correctly you need it to accept diffs to the default
 Policy object, rather than to the updateSettings argument (which already
 expects a subset or just one of the supported settings to be actually
 defined, and therefore modified).

 > Is that already possible in some way or could we add this capability to
 NoScript?
 It's not possible yet from the UI or the content script, and so far I
 didn't have a compelling reason to do it.

 > Also, I used a hack to treat http and https domain differently (using a
 "site" whose "domain" is the string "http:". Is there a cleaner way to do
 this?

 I don't consider it a hack: "just by protocol" is explicitly supported by
 the Policy site matching algorithm. However if by "cleaner" you mean an
 ad-hoc switch, no there's none.

 Regarding both the enhancements, if they're really needed, have you got
 any design proposal?

 Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25895 [Core Tor/Tor]: Cross-compiling tor rust for Windows is broken

[Tor Bug Tracker & Wiki]

#25895: Cross-compiling tor rust for Windows is broken
-+-
 Reporter:  gk   |  Owner:  Hello71
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, 034-proposed, tbb-wants,   |  Actual Points:
  033-backport, 034-roadmap-proposed,  034-must  |
Parent ID:  #25849   | Points:
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by catalyst):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:18 Hello71]:
 > summary (for reviewing): https://cgit.alxu.ca/tor.git/diff/?id=rust-
 cross&id2=fix-rust-tests
 Thanks for the patches! Could you please rebase them on the latest master?
 (without the fix-rust-tests patches?) They don't seem to apply cleanly.
 Also a GitHub pull request would help us to review the changes more
 effectively.

 Please use some other variable like `RUST_TARGET` instead of `TARGET`
 because the variable `target` is set by autoconf someone passes the
 `--target=` option on the `./configure` command line. Or maybe an option
 like `--with-rust-target=` would be better? I'm not sure which would be
 more idiomatic.

 I think `CHOST` and `CBUILD` aren't standard autoconf terminology; what
 system uses those terms? `HOST` and `BUILD` would be better. (These are
 the terms that the help text in `./configure` uses to refer to the
 arguments passed to the `--host=` and `--build=` options.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26375 [Applications/Tor Browser]: On Mac, cannot have Tor Browser and Tor Browser Alpha side by side

[Tor Bug Tracker & Wiki]

#26375: On Mac, cannot have Tor Browser and Tor Browser Alpha side by side
--+---
 Reporter:  tom   |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by tom):

 Replying to [comment:2 mcs]:
 > In my experience, you can run as many copies of Tor Browser as you like
 as long as:
 > 1. Each browser uses a separate profile. The easiest way to make sure
 that is the case is to not install in /Applications; instead put each
 browser in its own folder so each will have its own TorBrowser-Data
 directory.

 No, I had stuck it in Applications.

 > 2. Each browser is configured with different SOCKS and control ports, or
 is using UNIX domain sockets.
 >
 > Have you met those conditions? Or maybe you want the different "flavors"
 of Tor Browser to use different profiles by default? I know Firefox does
 that automatically for Developer Edition; I am not sure about the Firefox
 Nightly or ESR (I don't think so).

 For FF, I have the profile selector running on startup and different
 profiles for each browser so that explains that.


 Okay so it sounds like this is either an enhancement (so one can put it in
 Applications and that everything 'just works' by using a different
 port/profile) or a wontfix!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26205 [Applications/Tor Browser]: Don't build the uninstaller for Windows during Firefox compilation

[Tor Bug Tracker & Wiki]

#26205: Don't build the uninstaller for Windows during Firefox compilation
-+--
 Reporter:  gk   |  Owner:  tbb-team
 Type:  defect   | Status:  closed
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff60-esr, TorBrowserTeam201806R  |  Actual Points:
Parent ID:  #26203   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Let's take that one for now to get the build going and think about a
 better patch later on. I committed the fix in commit
 0f6ebe396fad0834388fd2424218582b32493816. on `master`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26375 [Applications/Tor Browser]: On Mac, cannot have Tor Browser and Tor Browser Alpha side by side

[Tor Bug Tracker & Wiki]

#26375: On Mac, cannot have Tor Browser and Tor Browser Alpha side by side
--+---
 Reporter:  tom   |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by mcs):

 * status:  new => needs_information


Comment:

 In my experience, you can run as many copies of Tor Browser as you like as
 long as:
 1. Each browser uses a separate profile. The easiest way to make sure that
 is the case is to not install in /Applications; instead put each browser
 in its own folder so each will have its own TorBrowser-Data directory.
 2. Each browser is configured with different SOCKS and control ports, or
 is using UNIX domain sockets.

 Have you met those conditions? Or maybe you want the different "flavors"
 of Tor Browser to use different profiles by default? I know Firefox does
 that automatically for Developer Edition; I am not sure about the Firefox
 Nightly or ESR (I don't think so).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26375 [Applications/Tor Browser]: On Mac, cannot have Tor Browser and Tor Browser Alpha side by side

[Tor Bug Tracker & Wiki]

#26375: On Mac, cannot have Tor Browser and Tor Browser Alpha side by side
--+--
 Reporter:  tom   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * cc: mcs, brade (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26375 [Applications/Tor Browser]: On Mac, cannot have Tor Browser and Tor Browser Alpha side by side

[Tor Bug Tracker & Wiki]

#26375: On Mac, cannot have Tor Browser and Tor Browser Alpha side by side
--+--
 Reporter:  tom   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 On Mac, I can have FF Beta/Dev Edition/Nightly/ESR all as separate apps
 and run them simultaneously.

 I cannot do that with Tor Browser and Tor Browser Alpha.

 Even if I rename the Alpha to a different name so they're both in my
 Applications folder, trying to run a second one says "Tor Browser is
 already running"

 I haven't tried Nightly.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26374 [Core Tor/Tor]: MacOS Sandbox

[Tor Bug Tracker & Wiki]

#26374: MacOS Sandbox
--+--
 Reporter:  ahf   |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by sysrqb):

 (For reference, #20121 was the Tor Browser ticket)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26374 [Core Tor/Tor]: MacOS Sandbox

[Tor Bug Tracker & Wiki]

#26374: MacOS Sandbox
--+--
 Reporter:  ahf   |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 Maybe we should have a sandbox for little-t-tor for MacOS.

 Here are some documents that might be relevant:

 - https://reverse.put.as/wp-content/uploads/2011/09/Apple-Sandbox-
 Guide-v1.0.pdf
 - https://www.unix.com/man-page/osx/7/sandbox/
 - https://dl.packetstormsecurity.net/papers/general/apple-sandbox.pdf
 -
 
https://developer.apple.com/library/archive/documentation/Security/Conceptual/AppSandboxDesignGuide/DesigningYourSandbox/DesigningYourSandbox.html

 Some slides:
 - http://newosxbook.com/files/HITSB.pdf

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26373 [Core Tor/Tor]: test_rust.sh should detect when it's being invoked improperly and error out

[Tor Bug Tracker & Wiki]

#26373: test_rust.sh should detect when it's being invoked improperly and error 
out
--+--
 Reporter:  catalyst  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  rust, testing, tor-tests
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 While attempting to test #26258, I noticed that running
 src/test/test_rust.sh from the top of the source tree exited with status 0
 and no output.  It should probably detect that it failed to find any
 Cargo.toml files and exit with a failure status with an error message.
 (This seems to happen because some necessary environment variables aren't
 set.)

 Prior to #26258, the find invocation failing would probably have taken
 care of this, so this change should probably get back ported to the same
 releases.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26258 [Core Tor/Tor]: Rust tests don't fail on failure

[Tor Bug Tracker & Wiki]

#26258: Rust tests don't fail on failure
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  033-backport regression 034-must  |  Actual Points:
Parent ID:| Points:
 Reviewer:  catalyst  |Sponsor:
--+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Woo; merged to 0.3.3 and forward!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26367 [Core Tor/Tor]: Consider removing tor2web mode

[Tor Bug Tracker & Wiki]

#26367: Consider removing tor2web mode
--+--
 Reporter:  ahf   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal| Resolution:
 Keywords:  035-proposed  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by nickm):

 * keywords:   => 035-proposed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26372 [Core Tor/Tor]: Search for python3 with a better list of names.

[Tor Bug Tracker & Wiki]

#26372: Search for python3 with a better list of names.
--+
 Reporter:  nickm |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  fast-fix
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 Right now we search with:
 {{{
 AC_CHECK_PROGS(PYTHON, [python python2 python2.7 python3 python3.3])
 }}}

 But we'd like to prefer python3, and we'd like to prefer more recent
 versions. Ben McGinnes, who reported this bug, recommends
 {{{
 AC_CHECK_PROGS(PYTHON, [python3.6 python3.5 python3.4 python3.3 python3
 python2.7 python2])
 }}}

 As an alternative, he suggests that we have a look at the GPGME Python
 binding M4 files, modulo license issues.

 Personally, I'm thinking we'd like something like "python3, then known
 python3.x versions in descending order, then python, then python2, then
 python 2.7".

 Having typed this ticket out, "Python" no longer looks like a word to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #4700 [Core Tor/Tor]: Tor should provide a mechanism for hidden services to differentiate authorized clients and circuits

[Tor Bug Tracker & Wiki]

#4700: Tor should provide a mechanism for hidden services to differentiate
authorized clients and circuits
-+-
 Reporter:  katmagic |  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-control, needs-proposal, tor-hs  |  Actual Points:
  needs-design, 035-proposed |
Parent ID:   | Points:  10
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  tor-control, needs-proposal, tor-hs needs-design => tor-
 control, needs-proposal, tor-hs needs-design, 035-proposed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26326 [Applications/Tor Browser]: wine error when building Firefox ESR60 Windows x86_64

[Tor Bug Tracker & Wiki]

#26326: wine error when building Firefox ESR60 Windows x86_64
+--
 Reporter:  sukhbir |  Owner:  tbb-team
 Type:  defect  | Status:  closed
 Priority:  Very High   |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  ff60-esr, TorBrowserTeam201806  |  Actual Points:
Parent ID:  #26203  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 The wine error is solved with commit
 57693e01837f0fc7c60bb056e5b752f5f67a987b on `tor-browser-build`'s `master`
 branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26204 [Applications/Tor Browser]: Bundle d3dcompiler_47.dll for Tor Browser 8

[Tor Bug Tracker & Wiki]

#26204: Bundle d3dcompiler_47.dll for Tor Browser 8
+--
 Reporter:  gk  |  Owner:  tbb-team
 Type:  defect  | Status:  closed
 Priority:  Very High   |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  ff60-esr, TorBrowserTeam201806  |  Actual Points:
Parent ID:  #26203  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * status:  needs_revision => closed
 * resolution:   => fixed


Comment:

 Fixed with commit 57693e01837f0fc7c60bb056e5b752f5f67a987b on `tor-
 browser-build`'s `master` branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25837 [Applications/Tor Browser]: Integrate fxc2 into our build setup for Windows Tor Browser builds

[Tor Bug Tracker & Wiki]

#25837: Integrate fxc2 into our build setup for Windows Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-rbm, ff60-esr,   |  Actual Points:
  TorBrowserTeam201806R  |
Parent ID:  #26203   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:9 boklm]:
 > Branch `bug_25837_v3` has the some commit rebased on master:
 > https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_25837_v3&id=1689bd25bb1edc62c25cb11846bc0dd5b9a8e30c

 Looks good. I merged sukhe's commit and your fixups to master with commit
 `57693e01837f0fc7c60bb056e5b752f5f67a987b`. We are done here, I think.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26338 [Applications/Tor Browser]: Rebase Orfox patches onto mozilla-beta for TBA

[Tor Bug Tracker & Wiki]

#26338: Rebase Orfox patches onto mozilla-beta for TBA
--+--
 Reporter:  sysrqb|  Owner:  sysrqb
 Type:  task  | Status:  accepted
 Priority:  Very High |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile|  Actual Points:
Parent ID:  #25741| Points:
 Reviewer:|Sponsor:
--+--
Changes (by sysrqb):

 * owner:  tbb-team => sysrqb
 * status:  new => accepted


Comment:

 In
 [[https://trac.torproject.org/projects/tor/ticket/26233#comment:5|#26233]]
 I mentioned I have a branch available for review, but it is based on the
 initial 61 rebase (Arthur's 26233 branch). I'll update my branch so it
 uses Arthur's 26233+1 branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7349 [Core Tor/Tor]: Obfsbridges should be able to "disable" their ORPort

[Tor Bug Tracker & Wiki]

#7349: Obfsbridges should be able to "disable" their ORPort
-+-
 Reporter:  asn  |  Owner:  isis
 Type:  project  | Status:
 |  assigned
 Priority:  Very High|  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-bridge, SponsorZ, tor-pt,|  Actual Points:
  proposal-needed censorship, 035-proposed   |
Parent ID:   | Points:  10
 Reviewer:   |Sponsor:
 |  SponsorM-can
-+-
Changes (by phoul):

 * cc: phoul (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25837 [Applications/Tor Browser]: Integrate fxc2 into our build setup for Windows Tor Browser builds

[Tor Bug Tracker & Wiki]

#25837: Integrate fxc2 into our build setup for Windows Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff60-esr,   |  Actual Points:
  TorBrowserTeam201806R  |
Parent ID:  #26203   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 Branch `bug_25837_v3` has the some commit rebased on master:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_25837_v3&id=1689bd25bb1edc62c25cb11846bc0dd5b9a8e30c

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26329 [Applications/Tor Browser]: Rust invocation for Firefox on 32bit Windows is failing

[Tor Bug Tracker & Wiki]

#26329: Rust invocation for Firefox on 32bit Windows is failing
-+--
 Reporter:  gk   |  Owner:  tbb-team
 Type:  defect   | Status:  closed
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff60-esr, TorBrowserTeam201806R  |  Actual Points:
Parent ID:  #26203   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by boklm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 This looks good to me. I pushed the patch to master as commit
 `3751474686ba0d2cc7b8a4086114332cbc36e29c`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26203 [Applications/Tor Browser]: Adapt tor-browser-build firefox and tor-browser project for ESR 60 Windows build

[Tor Bug Tracker & Wiki]

#26203: Adapt tor-browser-build firefox and tor-browser project for ESR 60 
Windows
build
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  task | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201806R  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 I pushed an updated version of the `tor-browser-build` patches in branch
 `bug_26203_v6`:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/log/?h=bug_26203_v6

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25552 [Core Tor/Tor]: prop224: Onion service rev counters are useless and actually harmful for scalability

[Tor Bug Tracker & Wiki]

#25552: prop224: Onion service rev counters are useless and actually harmful for
scalability
---+---
 Reporter:  asn|  Owner:  dgoulet
 Type:  defect | Status:
   |  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.5.x-final
Component:  Core Tor/Tor   |Version:  Tor:
   |  0.3.1.9
 Severity:  Normal | Resolution:
 Keywords:  tor-hs prop224 034-roadmap-master  |  Actual Points:
Parent ID: | Points:  6+++
 Reviewer:  asn|Sponsor:
---+---
Changes (by asn):

 * status:  new => needs_review
 * points:  4 => 6+++


Comment:

 Oooff! I have a branch that implements the OPE design for HSv3! It seems
 to work on my onion service for the past week just fine, and tests pass.
 This was much harder than I thought, because the `hs_service` unittests
 are a mess that depend on too many time sources. I fixed them all and
 tested them with various kinds of local time using
 [https://gist.github.com/asn-d6/41f3beefffb255904627f341cf34e5cc a crazy
 bash script] I hacked up.

 You can find a fixup for the spec branch at `ope_spec` in my github
 torspec repo. It explains why we cannot use "seconds since TP", and why we
 have to use "seconds since SRV".

 You can find the code at my branch `bug25552_ope_draft`. It seems to work
 fine and the code is decent, but I labeled it as draft because there might
 be some trivial code-style improvements that can be done (in particular im
 thinking the `is_current` func argument). I also '''need to make sure that
 HSes will not burp if they have an obsolete rev-counter left in their
 state file'''. Please check it out and if you like it I will make it real
 proper: https://github.com/torproject/tor/pull/150

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26233 [Applications/Tor Browser]: Rebase Tor Browser patches for FF61

[Tor Bug Tracker & Wiki]

#26233: Rebase Tor Browser patches for FF61
---+---
 Reporter:  sysrqb |  Owner:
   |  arthuredelstein
 Type:  enhancement| Status:  closed
 Priority:  Very High  |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  TorBrowserTeam201806R, tbb-mobile  |  Actual Points:
Parent ID:  #26338 | Points:
 Reviewer: |Sponsor:
---+---
Changes (by gk):

 * status:  reopened => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26233 [Applications/Tor Browser]: Rebase Tor Browser patches for FF61

[Tor Bug Tracker & Wiki]

#26233: Rebase Tor Browser patches for FF61
---+---
 Reporter:  sysrqb |  Owner:
   |  arthuredelstein
 Type:  enhancement| Status:  reopened
 Priority:  Very High  |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  TorBrowserTeam201806R, tbb-mobile  |  Actual Points:
Parent ID:  #26338 | Points:
 Reviewer: |Sponsor:
---+---
Changes (by gk):

 * parent:  #25741 => #26338


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26233 [Applications/Tor Browser]: Rebase Tor Browser patches for FF61

[Tor Bug Tracker & Wiki]

#26233: Rebase Tor Browser patches for FF61
---+---
 Reporter:  sysrqb |  Owner:
   |  arthuredelstein
 Type:  enhancement| Status:  reopened
 Priority:  Very High  |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  TorBrowserTeam201806R, tbb-mobile  |  Actual Points:
Parent ID:  #25741 | Points:
 Reviewer: |Sponsor:
---+---
Changes (by gk):

 * status:  closed => reopened
 * resolution:  fixed =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25834 [Applications/Tor Browser]: Use compiler dependent spec files for mingw-w64

[Tor Bug Tracker & Wiki]

#25834: Use compiler dependent spec files for mingw-w64
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff60-esr,   |  Actual Points:
  TorBrowserTeam201806R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * parent:  #26203 =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26239 [Applications/Tor Browser]: Backport patch for bug 1448748 to fix Windows 64bit builds

[Tor Bug Tracker & Wiki]

#26239: Backport patch for bug 1448748 to fix Windows 64bit builds
+--
 Reporter:  gk  |  Owner:  tbb-team
 Type:  task| Status:  closed
 Priority:  Very High   |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  ff60-esr, TorBrowserTeam201806  |  Actual Points:
Parent ID:  #26203  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 That's done with commit bf1450d9a5dc8d1bd0ee217acb61b7e488333102 on `tor-
 browser-60.0.1esr-8.0-1`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26203 [Applications/Tor Browser]: Adapt tor-browser-build firefox and tor-browser project for ESR 60 Windows build

[Tor Bug Tracker & Wiki]

#26203: Adapt tor-browser-build firefox and tor-browser project for ESR 60 
Windows
build
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  task | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201806R  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 I looked over https://github.com/azadi/gecko-dev and all the cherry-picked
 patches. I omitted the following patches when pushing the changes to `tor-
 browser-60.0.1esr-8.0-1`:

 1411401: That's only for Mozilla infra and we are essentially getting this
 patch by using mingw-w64's ee9fc3d0b8c8868280e38384edd968067b8e71fc.
 1434316: That's only for Mozilla infra.
 1460620: Let's leave this out for now and bundle the dll ourselves (as
 your patch is doing)
 1461421: just cherry-pick the actual fix (the other two commits are
 stricly speaking not needed and I want to keep the patch number as small
 as possible)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26203 [Applications/Tor Browser]: Adapt tor-browser-build firefox and tor-browser project for ESR 60 Windows build

[Tor Bug Tracker & Wiki]

#26203: Adapt tor-browser-build firefox and tor-browser project for ESR 60 
Windows
build
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  task | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201806R  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 Replying to [comment:12 sukhbir]:

 >
 > OK, if that's the case and it does compile without it, we should remove
 it. Should I update the patch?

 I posted a new version of the patch, including this change and a few other
 changes in #25837 for review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26203 [Applications/Tor Browser]: Adapt tor-browser-build firefox and tor-browser project for ESR 60 Windows build

[Tor Bug Tracker & Wiki]

#26203: Adapt tor-browser-build firefox and tor-browser project for ESR 60 
Windows
build
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  task | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201806R  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sukhbir):

 Replying to [comment:11 boklm]:
 > Replying to [comment:10 sukhbir]:
 > > Replying to [comment:9 gk]:
 > > > sukhbir: Why do we need `pre_pkginst: dpkg --add-architecture i386`
 for the 64bit case? Compiling without it works for me.
 > >
 > > Without adding it, I was getting something like `it looks like
 multiarch needs to be enabled.` Also, I based this on
 https://wiki.debian.org/Wine, which says:
 > >
 > > {{{
 > > On 64-bit systems you should enable a 32-bit architecture for
 multiarch. This is needed for running 32-bit Windows applications (many
 modern apps are still 32-bit), but also for large parts of the Windows
 subsystem itself. If in doubt, you do need it!
 > > }}}
 > >
 > > But maybe `Wine64` is all we need if it works without that.
 >
 > Isn't that the error that you were having when you were trying to use
 the 32bit `d3dcompiler_47.dll`?
 > When using the 64bit version of `d3dcompiler_47.dll` I don't think we
 need the 32bit version of wine.

 OK, if that's the case and it does compile without it, we should remove
 it. Should I update the patch?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26203 [Applications/Tor Browser]: Adapt tor-browser-build firefox and tor-browser project for ESR 60 Windows build

[Tor Bug Tracker & Wiki]

#26203: Adapt tor-browser-build firefox and tor-browser project for ESR 60 
Windows
build
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  task | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201806R  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 Replying to [comment:10 sukhbir]:
 > Replying to [comment:9 gk]:
 > > sukhbir: Why do we need `pre_pkginst: dpkg --add-architecture i386`
 for the 64bit case? Compiling without it works for me.
 >
 > Without adding it, I was getting something like `it looks like multiarch
 needs to be enabled.` Also, I based this on https://wiki.debian.org/Wine,
 which says:
 >
 > {{{
 > On 64-bit systems you should enable a 32-bit architecture for multiarch.
 This is needed for running 32-bit Windows applications (many modern apps
 are still 32-bit), but also for large parts of the Windows subsystem
 itself. If in doubt, you do need it!
 > }}}
 >
 > But maybe `Wine64` is all we need if it works without that.

 Isn't that the error that you were having when you were trying to use the
 32bit `d3dcompiler_47.dll`?
 When using the 64bit version of `d3dcompiler_47.dll` I don't think we need
 the 32bit version of wine.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25837 [Applications/Tor Browser]: Integrate fxc2 into our build setup for Windows Tor Browser builds

[Tor Bug Tracker & Wiki]

#25837: Integrate fxc2 into our build setup for Windows Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff60-esr,   |  Actual Points:
  TorBrowserTeam201806R  |
Parent ID:  #26203   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * keywords:  tbb-rbm, ff60-esr, TorBrowserTeam201806 => tbb-rbm, ff60-esr,
 TorBrowserTeam201806R


Comment:

 Replying to [comment:7 boklm]:
 > I am now testing a build with the following changes compared to the
 patch from branch `azadi/bug-26203`:

 The build finished correctly. I have now squashed the changes listed in
 comment 7 in a commit in branch `bug_25837_v2`:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_25837_v2&id=fdfd5600c985d1aff96a6e822c8138fb4a5dbe95

 I also checked that the `d3dcompiler_47.dll` included in commit
 `079f5c7b9f6ea0b7e5504bb53abf8709cc92835d` from
 `https://github.com/azadi/fxc2.git` are the same that I get after
 downloading the win32 and win64 versions of firefox 60.0.2esr.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26203 [Applications/Tor Browser]: Adapt tor-browser-build firefox and tor-browser project for ESR 60 Windows build

[Tor Bug Tracker & Wiki]

#26203: Adapt tor-browser-build firefox and tor-browser project for ESR 60 
Windows
build
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  task | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201806R  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sukhbir):

 Replying to [comment:9 gk]:
 > sukhbir: Why do we need `pre_pkginst: dpkg --add-architecture i386` for
 the 64bit case? Compiling without it works for me.

 Without adding it, I was getting something like `it looks like multiarch
 needs to be enabled.` Also, I based this on https://wiki.debian.org/Wine,
 which says:

 {{{
 On 64-bit systems you should enable a 32-bit architecture for multiarch.
 This is needed for running 32-bit Windows applications (many modern apps
 are still 32-bit), but also for large parts of the Windows subsystem
 itself. If in doubt, you do need it!
 }}}

 But maybe `Wine64` is all we need if it works without that.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26329 [Applications/Tor Browser]: Rust invocation for Firefox on 32bit Windows is failing

[Tor Bug Tracker & Wiki]

#26329: Rust invocation for Firefox on 32bit Windows is failing
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201806R  |  Actual Points:
Parent ID:  #26203   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * cc: boklm (added)
 * keywords:  ff60-esr, TorBrowserTeam201806 => ff60-esr,
 TorBrowserTeam201806R
 * status:  new => needs_review


Comment:

 Okay, this works for me and I get a functional 32bit Windows Tor Browser.
 `bug_26329` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_26329&id=3751474686ba0d2cc7b8a4086114332cbc36e29c)
 in my public `tor-browser-build` repo has a fix for review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25837 [Applications/Tor Browser]: Integrate fxc2 into our build setup for Windows Tor Browser builds

[Tor Bug Tracker & Wiki]

#25837: Integrate fxc2 into our build setup for Windows Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff60-esr,   |  Actual Points:
  TorBrowserTeam201806   |
Parent ID:  #26203   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 I am now testing a build with the following changes compared to the patch
 from branch `azadi/bug-26203`:
 * remove the line `pre_pkginst: dpkg --add-architecture i386` as it builds
 fine without it. https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_26203&id=e172a942f2abf3553f14f2de7be20840f5f77334
 * don't use xvfb as it seems it is not really needed.
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_26203&id=ecea9b7944aa0ea22faf72776e0050c6d9ca1bad
 * copy d3dcompiler_47.dll (this change was part of commit `Bug 26206: Ship
 pthread related dll (libwinpthread-1.dll) where needed` before)
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_26203&id=74da109534fe4c5470a7653ddcba83398c1ac7f4
 * Simplify a little the copy of the libwinpthread-1.dll file.
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_25837&id=b0f30a7078c145916e0e89b255dd2262fc757730
 * Remove the `&` after `wine wineboot -i` as I am not sure it is needed.
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_25837&id=9d4ab9c0a171be5c38d9f440bb855d92c9b0faa2

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26203 [Applications/Tor Browser]: Adapt tor-browser-build firefox and tor-browser project for ESR 60 Windows build

[Tor Bug Tracker & Wiki]

#26203: Adapt tor-browser-build firefox and tor-browser project for ESR 60 
Windows
build
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  task | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201806R  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 sukhbir: Why do we need `pre_pkginst: dpkg --add-architecture i386` for
 the 64bit case? Compiling without it works for me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26371 [Community/Relays]: Missing Information to correctly start tor relay

[Tor Bug Tracker & Wiki]

#26371: Missing Information to correctly start tor relay
--+
 Reporter:  cypherpunks   |  Owner:  Nusenu
 Type:  defect| Status:  closed
 Priority:  High  |  Milestone:  Tor: 0.2.9.x-final
Component:  Community/Relays  |Version:  Tor: 0.2.9.15
 Severity:  Trivial   | Resolution:  worksforme
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by cypherpunks):

 * status:  new => closed
 * resolution:   => worksforme


Comment:

 The 'Address' torrc parameter is not needed in most cases.
 Listening on IP 0.0.0.0 will work just fine in most cases.

 The guide is written to work in most cases.

 Weird NAT and multi-instance setups are not covered in the guide.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26206 [Applications/Tor Browser]: Ship pthread related dll where needed

[Tor Bug Tracker & Wiki]

#26206: Ship pthread related dll where needed
-+--
 Reporter:  gk   |  Owner:  tbb-team
 Type:  defect   | Status:  closed
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff60-esr, TorBrowserTeam201806R  |  Actual Points:
Parent ID:  #26203   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Looks good. Merged to `master` with commit
 907be0ba29c55bac51f47afe1cf8777c5037ffe6.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26371 [Community/Relays]: Missing Information to correctly start tor relay

[Tor Bug Tracker & Wiki]

#26371: Missing Information to correctly start tor relay
--+
 Reporter:  cypherpunks   |  Owner:  Nusenu
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:  Tor: 0.2.9.x-final
Component:  Community/Relays  |Version:  Tor: 0.2.9.15
 Severity:  Trivial   | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by cypherpunks):

 Speaking about this guide:
 https://trac.torproject.org/projects/tor/wiki/TorRelayGuide

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24977 [Core Tor/Tor]: Non-fatal assertion !(tor_mem_is_zero((const char*)node->hsdir_index->fetch, DIGEST256_LEN))

[Tor Bug Tracker & Wiki]

#24977: Non-fatal assertion !(tor_mem_is_zero((const
char*)node->hsdir_index->fetch, DIGEST256_LEN))
-+-
 Reporter:  asn  |  Owner:  asn
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224, |  Actual Points:
  034-triage-20180328, 034-removed-20180502  |
Parent ID:   | Points:  1
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by asn):

 * status:  needs_revision => needs_review


Comment:

 Addressed dgoulet's review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26371 [Community/Relays]: Missing Information to correctly start tor relay

[Tor Bug Tracker & Wiki]

#26371: Missing Information to correctly start tor relay
--+
 Reporter:  cypherpunks   |  Owner:  Nusenu
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:  Tor: 0.2.9.x-final
Component:  Community/Relays  |Version:  Tor: 0.2.9.15
 Severity:  Trivial   |   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 When new users want to support the tor network and are planning to build a
 tor relay, they'll face a Major issue which newer users may not stumble
 across and therefore stop with the task and never create a relay for the
 network.

 The "Address" option should be added in the Guide's step 2, where the
 torrc config file is shown.

 Without the Address option the service listens on IP 0.0.0.0, which is, as
 you may agree, not working.

 After adding the Address option and inserting the public IP (or DNS name),
 the tor service can successfully introduce itself to network.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26206 [Applications/Tor Browser]: Ship pthread related dll where needed

[Tor Bug Tracker & Wiki]

#26206: Ship pthread related dll where needed
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201806R  |  Actual Points:
Parent ID:  #26203   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * status:  new => needs_review
 * keywords:  ff60-esr, TorBrowserTeam201806 => ff60-esr,
 TorBrowserTeam201806R


Comment:

 There is a patch for review in branch `bug_26206`:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_26206&id=907be0ba29c55bac51f47afe1cf8777c5037ffe6

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26370 [Applications/Tor Browser]: Don't copy msvcr100.dll and libssp-0.dll twice

[Tor Bug Tracker & Wiki]

#26370: Don't copy msvcr100.dll and libssp-0.dll twice
+--
 Reporter:  boklm   |  Owner:  tbb-team
 Type:  defect  | Status:  closed
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  tbb-rbm, TorBrowserTeam201806R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Looks good. Merged to `master` with commit
 37d406206a0d7ec43ae4bcd35889a97fc85eff32.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26203 [Applications/Tor Browser]: Adapt tor-browser-build firefox and tor-browser project for ESR 60 Windows build

[Tor Bug Tracker & Wiki]

#26203: Adapt tor-browser-build firefox and tor-browser project for ESR 60 
Windows
build
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  task | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201806R  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Replying to [comment:7 gk]:
 > We actually need `libwinpthread-1.dll` in Browser\TorBrowser\Tor it
 seems and not in Browser. Which means we need it for the expert bundle as
 well.
 This is #26206. And you need to ship it with every executable you built
 with your patched gcc. But that's not great, and you don't do that for
 `msvcr100.dll`, fwiw.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26370 [Applications/Tor Browser]: Don't copy msvcr100.dll and libssp-0.dll twice

[Tor Bug Tracker & Wiki]

#26370: Don't copy msvcr100.dll and libssp-0.dll twice
+--
 Reporter:  boklm   |  Owner:  tbb-team
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201806R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by boklm):

 * keywords:  tbb-rbm, TorBrowserTeam201806 => tbb-rbm,
   TorBrowserTeam201806R
 * status:  new => needs_review


Comment:

 There is a patch for review in branch `bug_26370`:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_26370&id=37d406206a0d7ec43ae4bcd35889a97fc85eff32

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26370 [Applications/Tor Browser]: Don't copy msvcr100.dll and libssp-0.dll twice

[Tor Bug Tracker & Wiki]

#26370: Don't copy msvcr100.dll and libssp-0.dll twice
-+-
 Reporter:  boklm|  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  tbb-rbm,
 Severity:  Normal   |  TorBrowserTeam201806
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 It seems that in `projects/firefox/build` we copy `msvcr100.dll` and
 `libssp-0.dll` to the `Browser/` directory twice.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26203 [Applications/Tor Browser]: Adapt tor-browser-build firefox and tor-browser project for ESR 60 Windows build

[Tor Bug Tracker & Wiki]

#26203: Adapt tor-browser-build firefox and tor-browser project for ESR 60 
Windows
build
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  task | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201806R  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 We actually need `libwinpthread-1.dll` in Browser\TorBrowser\Tor it seems
 and not in Browser. Which means we need it for the expert bundle as well.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #11249 [Applications/Tor Browser]: Publish logs from failed TBB builds

[Tor Bug Tracker & Wiki]

#11249: Publish logs from failed TBB builds
--+--
 Reporter:  ln5   |  Owner:  tbb-team
 Type:  enhancement   | Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  wontfix
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by ln5):

 * status:  assigned => closed
 * resolution:   => wontfix


Comment:

 Nightlies are not built using this set of scripts any more.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26233 [Applications/Tor Browser]: Rebase Tor Browser patches for FF61

[Tor Bug Tracker & Wiki]

#26233: Rebase Tor Browser patches for FF61
---+---
 Reporter:  sysrqb |  Owner:
   |  arthuredelstein
 Type:  enhancement| Status:  closed
 Priority:  Very High  |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  TorBrowserTeam201806R, tbb-mobile  |  Actual Points:
Parent ID:  #25741 | Points:
 Reviewer: |Sponsor:
---+---
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Looks good to me. I think we are done here.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs