Re: [tor-bugs] #31616 [Applications/Tor Browser]: Tor Browser on Android based on 60.9.0 is crashing on every launch

[Tor Bug Tracker & Wiki]

#31616: Tor Browser on Android based on 60.9.0 is crashing on every launch
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-mobile, tbb-crash,   |  Actual Points:
  TorBrowserTeam201909   |
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
-+-

Comment (by billybob55):

 This started since the latest update (published on Google Play store on
 the Sept 3)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31616 [Applications/Tor Browser]: Tor Browser on Android based on 60.9.0 is crashing on every launch

[Tor Bug Tracker & Wiki]

#31616: Tor Browser on Android based on 60.9.0 is crashing on every launch
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-mobile, tbb-crash,   |  Actual Points:
  TorBrowserTeam201909   |
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
-+-

Comment (by billybob55):

 I am facing the same issue, the Tor Browser crashes on startuo, I do not
 even have the time to press "Start". My device is a Samsung Galaxy S8
 running Android 9.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31593 [Core Tor/Stem]: Add an alias to run_tests that runs all the tests that use tor

[Tor Bug Tracker & Wiki]

#31593: Add an alias to run_tests that runs all the tests that use tor
---+
 Reporter:  teor   |  Owner:  atagar
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-wants  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by teor):

 * parent:  #31554 =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31554 [Core Tor/Tor]: Restrict "make test-stem" to tests that actually use tor

[Tor Bug Tracker & Wiki]

#31554: Restrict "make test-stem" to tests that actually use tor
-+-
 Reporter:  teor |  Owner:  teor
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tor-ci, fast-fix, 041-backport,  |  Actual Points:  0.2
  040-backport, 035-backport, dgoulet-merge  |
Parent ID:   | Points:  0.1
 Reviewer:  nickm|Sponsor:
 |  Sponsor31-can
-+-
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed
 * milestone:  Tor: 0.4.0.x-final => Tor: 0.3.5.x-final


Comment:

 Merged to maint-0.3.5 and later.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30279 [Core Tor/Chutney]: Test IPv6-only v3 onion services in Chutney's CI, once homebrew tor stable supports them

[Tor Bug Tracker & Wiki]

#30279: Test IPv6-only v3 onion services in Chutney's CI, once homebrew tor 
stable
supports them
-+-
 Reporter:  teor |  Owner:  teor
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Low  |  Milestone:
Component:  Core Tor/Chutney |Version:
 Severity:  Normal   | Resolution:
 Keywords:  merge-after-041-stable-in-homebrew,  |  Actual Points:  0.2
  tor-hs, ipv6, single-onion, fast-fix,  |
  chutney-ci, network-team-roadmap-2019-Q1Q2,|
  041-deferred-20190530  |
Parent ID:   | Points:  0.1
 Reviewer:  nickm|Sponsor:
 |  Sponsor19-can
-+-

Comment (by teor):

 I'll merge this as soon as CI passes, and CI on #31639 fails. (We expect
 it to fail.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31554 [Core Tor/Tor]: Restrict "make test-stem" to tests that actually use tor

[Tor Bug Tracker & Wiki]

#31554: Restrict "make test-stem" to tests that actually use tor
-+-
 Reporter:  teor |  Owner:  teor
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-ci, fast-fix, 041-backport,  |  Actual Points:  0.2
  040-backport, 035-backport, dgoulet-merge  |
Parent ID:   | Points:  0.1
 Reviewer:  nickm|Sponsor:
 |  Sponsor31-can
-+-

Comment (by teor):

 We need to merge this CI fix to avoid conflicts with #30901, so I'll do it
 as soon as CI is free and green.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31639 [Core Tor/Chutney]: When Travis updates the homebrew cache in their images, stop updating it in .travis.yml

[Tor Bug Tracker & Wiki]

#31639: When Travis updates the homebrew cache in their images, stop updating 
it in
.travis.yml
-+-
 Reporter:  teor |  Owner:  teor
 Type:  task | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Chutney |Version:
 Severity:  Normal   | Resolution:
 Keywords:  merge-after-travis-image-update, |  Actual Points:  0
  tor-hs, ipv6, single-onion, fast-fix,  |
  chutney-ci |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * sponsor:  Sponsor19-can =>
 * parent:  #30279 =>


Old description:

> In #30279, we added a homebrew update to .travis.yml.
>
> This ticket removes that update.

New description:

 In #30928, we added a homebrew update to .travis.yml for shellcheck.
 #30279 also uses an updated tor for the IPv6 v3 single onion service job.

 This ticket removes that update.

--

Comment:

 Turns out we need to revert #30928.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30967 [Core Tor/Tor]: Make shellcheck ignore user-created directories, and run it during pre-commit

[Tor Bug Tracker & Wiki]

#30967: Make shellcheck ignore user-created directories, and run it during pre-
commit
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Major| Resolution:
 Keywords:  fast-fix, teor-backlog-ci,   |  Actual Points:  0.2
  042-should, tor-ci-fail-sometimes, asn-merge,  |
  dgoulet-merge, nickm-merge |
Parent ID:   | Points:  0.1
 Reviewer:  catalyst |Sponsor:
 |  Sponsor31-can
-+-
Changes (by teor):

 * status:  assigned => merge_ready


Comment:

 The CI passed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30967 [Core Tor/Tor]: Make shellcheck ignore user-created directories, and run it during pre-commit

[Tor Bug Tracker & Wiki]

#30967: Make shellcheck ignore user-created directories, and run it during pre-
commit
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Major| Resolution:
 Keywords:  fast-fix, teor-backlog-ci,   |  Actual Points:  0.2
  042-should, tor-ci-fail-sometimes, asn-merge,  |
  dgoulet-merge, nickm-merge |
Parent ID:   | Points:  0.1
 Reviewer:  catalyst |Sponsor:
 |  Sponsor31-can
-+-
Changes (by teor):

 * owner:  (none) => teor
 * status:  merge_ready => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30894 [Core Tor/Tor]: Memory leak on invalid CSV_INTERVAL value

[Tor Bug Tracker & Wiki]

#30894: Memory leak on invalid CSV_INTERVAL value
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  consider-backport-after-0415,|  Actual Points:  0.1
  035-backport 040-backport 041-backport |
Parent ID:   | Points:  0.1
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor31-can
-+-
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31003 [Core Tor/Tor]: heap-use-after-free src/feature/nodelist/routerlist.c:704 in router_get_by_descriptor_digest

[Tor Bug Tracker & Wiki]

#31003: heap-use-after-free src/feature/nodelist/routerlist.c:704 in
router_get_by_descriptor_digest
-+-
 Reporter:  dgoulet  |  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  consider-backport-after-0415, tor-   |  Actual Points:  .1
  crash, tor-hs, 041-backport, 040-backport, |
  035-backport, 041-regression?  |
Parent ID:   | Points:
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30871 [Core Tor/Tor]: circuit_mark_for_close_(): Bug: Duplicate call to circuit_mark_for_close at ../src/feature/hs/hs_service.c:3166 (first at ../src/feature/hs/hs_service.c:2385)

[Tor Bug Tracker & Wiki]

#30871: circuit_mark_for_close_(): Bug: Duplicate call to 
circuit_mark_for_close at
../src/feature/hs/hs_service.c:3166 (first at
../src/feature/hs/hs_service.c:2385)
-+-
 Reporter:  s7r  |  Owner:  dgoulet
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.2-alpha
 Severity:  Normal   | Resolution:  fixed
 Keywords:  consider-backport-after-0415, tor-   |  Actual Points:  0.4
  hs double-mark 035-backport 040-backport   |
  041-backport   |
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
 |  Sponsor27
-+-
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.1-alpha
 Severity:  Normal   | Resolution:  fixed
 Keywords:  teor-merge, consider-backport-   |  Actual Points:  1
  after-0415, 040-backport, tor-relay,   |
  circuitpadding, wtf-pad|
Parent ID:   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor2
-+-
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed
 * actualpoints:   => 1


Comment:

 This was a complex merge.
 There were some trivial conflicts, which I fixed, see the merge commit
 messages for details.

 Thanks for making it happen!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30279 [Core Tor/Chutney]: Test IPv6-only v3 onion services in Chutney's CI, once homebrew tor stable supports them

[Tor Bug Tracker & Wiki]

#30279: Test IPv6-only v3 onion services in Chutney's CI, once homebrew tor 
stable
supports them
-+-
 Reporter:  teor |  Owner:  teor
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Low  |  Milestone:
Component:  Core Tor/Chutney |Version:
 Severity:  Normal   | Resolution:
 Keywords:  merge-after-041-stable-in-homebrew,  |  Actual Points:  0.2
  tor-hs, ipv6, single-onion, fast-fix,  |
  chutney-ci, network-team-roadmap-2019-Q1Q2,|
  041-deferred-20190530  |
Parent ID:   | Points:  0.1
 Reviewer:  nickm|Sponsor:
 |  Sponsor19-can
-+-
Changes (by teor):

 * status:  needs_revision => merge_ready


Comment:

 I added a homebrew update, let's see if CI passes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31639 [Core Tor/Chutney]: When Travis updates the homebrew cache in their images, stop updating it in .travis.yml

[Tor Bug Tracker & Wiki]

#31639: When Travis updates the homebrew cache in their images, stop updating 
it in
.travis.yml
-+-
 Reporter:  teor |  Owner:  teor
 Type:  task | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Chutney |Version:
 Severity:  Normal   | Resolution:
 Keywords:  merge-after-travis-image-update, |  Actual Points:  0
  tor-hs, ipv6, single-onion, fast-fix,  |
  chutney-ci |
Parent ID:  #30279   | Points:  0.1
 Reviewer:   |Sponsor:
 |  Sponsor19-can
-+-
Changes (by teor):

 * status:  assigned => needs_revision
 * actualpoints:  0.1 => 0


Comment:

 The CI will fail on this pull request, until Travis updates its macOS
 images:
 https://github.com/torproject/chutney/pull/37

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31639 [Core Tor/Chutney]: When Travis updates the homebrew cache in their images, stop updating it in .travis.yml

[Tor Bug Tracker & Wiki]

#31639: When Travis updates the homebrew cache in their images, stop updating 
it in
.travis.yml
-+-
 Reporter:  teor |  Owner:  teor
 Type:  task | Status:  assigned
 Priority:  Medium   |  Milestone:
Component:  Core |Version:
  Tor/Chutney|   Keywords:  merge-after-travis-image-update,
 Severity:  Normal   |  tor-hs, ipv6, single-onion, fast-fix, chutney-
 |  ci
Actual Points:  0.1  |  Parent ID:  #30279
   Points:  0.1  |   Reviewer:
  Sponsor:   |
  Sponsor19-can  |
-+-
 In #30279, we added a homebrew update to .travis.yml.

 This ticket removes that update.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30967 [Core Tor/Tor]: Make shellcheck ignore user-created directories, and run it during pre-commit

[Tor Bug Tracker & Wiki]

#30967: Make shellcheck ignore user-created directories, and run it during pre-
commit
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Major| Resolution:
 Keywords:  fast-fix, teor-backlog-ci,   |  Actual Points:  0.2
  042-should, tor-ci-fail-sometimes, asn-merge,  |
  dgoulet-merge, nickm-merge |
Parent ID:   | Points:  0.1
 Reviewer:  catalyst |Sponsor:
 |  Sponsor31-can
-+-
Changes (by teor):

 * keywords:  fast-fix, teor-backlog-ci, 042-should, tor-ci-fail-sometimes
 =>
 fast-fix, teor-backlog-ci, 042-should, tor-ci-fail-sometimes, asn-
 merge, dgoulet-merge, nickm-merge
 * status:  needs_revision => merge_ready


Comment:

 See my pull request:
 * master: ​https://github.com/torproject/tor/pull/1278

 I fixed the merge conflict by rebasing on master, and force-pushing the
 result.

 We added two files to EXTRA_DIST, and the lines were next to each other.
 I put the lines in the correct order.

 Please check CI passes before merging.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] [Tor Bug Tracker & Wiki] Batch modify: #31529, #31532, #31624, #31629

[Tor Bug Tracker & Wiki]

Batch modification to #31529, #31532, #31624, #31629 by teor:


Comment:
There might be some minor merge conflicts with these tickets, feel free to put 
back in needs_revision, or ask nickm how to fix the conflict.

--
Tickets URL: 

Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31532 [Core Tor/Tor]: Use ptrdiff_t for struct_member_t.offset, etc

[Tor Bug Tracker & Wiki]

#31532: Use ptrdiff_t for struct_member_t.offset, etc
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Trivial  | Resolution:
 Keywords:  network-team-roadmap-august  |  Actual Points:
Parent ID:  #29211   | Points:
 Reviewer:   |Sponsor:  Sponsor31-can
-+-
Changes (by teor):

 * status:  needs_review => merge_ready


Comment:

 Looks fine to me. I also did a quick check of the remaining off_t
 instances in the code: they all correspond to files.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31529 [Core Tor/Tor]: config refactoring: fix redundant reset logic

[Tor Bug Tracker & Wiki]

#31529: config refactoring: fix redundant reset logic
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-august  |  Actual Points:  0
Parent ID:  #29211   | Points:  0
 Reviewer:   |Sponsor:  Sponsor31-can
-+-
Changes (by teor):

 * status:  needs_review => merge_ready


Comment:

 Looks fine to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31624 [Core Tor/Tor]: Explain config_type_extended usage and purpose

[Tor Bug Tracker & Wiki]

#31624: Explain config_type_extended usage and purpose
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  doc internal  |  Actual Points:  0
Parent ID:  #29211| Points:  .1
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * status:  needs_review => merge_ready


Comment:

 Seems fine to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31627 [Core Tor/Tor]: Fill in all missing documentation in config, confparse, etc.

[Tor Bug Tracker & Wiki]

#31627: Fill in all missing documentation in config, confparse, etc.
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .1
Parent ID:  #29211| Points:  .2
 Reviewer:|Sponsor:
--+

Comment (by teor):

 I opened up #31638, because it looks like argument validity is a more
 general issue. Feel free to make code changes in that ticket instead.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31638 [Core Tor/Tor]: config: Always check for valid function arguments at the start of each function

[Tor Bug Tracker & Wiki]

#31638: config: Always check for valid function arguments at the start of each
function
--+-
 Reporter:  teor  |  Owner:  nickm
 Type:  task  | Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  network-team-roadmap-august
Actual Points:|  Parent ID:  #29211
   Points:|   Reviewer:
  Sponsor:|
--+-
 Some of the new and refactored config functions check if their arguments
 are NULL (or otherwise valid). Others don't.

 We should consistently check for valid arguments at the start of every
 function. If there are any unusual validity conditions, we should explain
 them in a function comment.

 If we skip validation, we should explain why in a comment, where we would
 usually do validation.

 I'm also open to general exceptions. I'm not sure if we have coding
 standards here. But it would be nice to catch as many future bugs as we
 can, as early as we can.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31627 [Core Tor/Tor]: Fill in all missing documentation in config, confparse, etc.

[Tor Bug Tracker & Wiki]

#31627: Fill in all missing documentation in config, confparse, etc.
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .1
Parent ID:  #29211| Points:  .2
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 I added one comment: the new documentation made me think about some error
 conditions that we're not catching.

 Feel free to update the comment and put this branch in merge_ready.
 If you think we should make code changes, they can go in another ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31629 [Core Tor/Tor]: Remove non-_ex typedvar.c function

[Tor Bug Tracker & Wiki]

#31629: Remove non-_ex typedvar.c function
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  task | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-august, asn-|  Actual Points:
  merge, dgoulet-merge   |
Parent ID:  #29211   | Points:  0
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * keywords:  network-team-roadmap-august => network-team-roadmap-august,
 asn-merge, dgoulet-merge
 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:1 nickm]:
 > I have a branch `ticket31629` with a PR at
 https://github.com/torproject/tor/pull/1295 .
 >
 > There is no changes file here, since it contains no changes beyond those
 already contained in earlier commits.  There are two commits: one is pure
 code removal, and the other is automatically generated function renaming.
 >
 > I'll put this in needs_review once CI passes.

 Looks fine to me, I confirmed the second commit using the script:
 {{{
 $ find src -name *.c -o -name *.h | xargs /usr/bin/perl -w -i -p -e
 
's{typed_var_(assign|free|encode|copy|eq|ok|kvassign|kvencode|mark_fragile)_ex}{typed_var_$1}g;'
 $ git diff nickm/ticket31629
 }}}

 CI passed, and I am also happy with the coverage:
 > 24 of 26 (92.31%) changed or added relevant lines in 2 files are
 covered.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31637 [Core Tor/Tor]: Make sure we have test coverage for Option, +Option and /Option across defaults, torrc, command line

[Tor Bug Tracker & Wiki]

#31637: Make sure we have test coverage for Option, +Option and /Option across
defaults, torrc, command line
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-august  |  Actual Points:
Parent ID:  #29211   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 Maybe we should also test %include?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31631 [Core Tor/Tor]: Write a test for round-trip encode/decode operations on configuration objects.

[Tor Bug Tracker & Wiki]

#31631: Write a test for round-trip encode/decode operations on configuration
objects.
--+
 Reporter:  nickm |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #29211| Points:
 Reviewer:|Sponsor:  Sponsor31-can
--+

Comment (by teor):

 The torrc test should also handle interactions between command-line,
 torrc, and defaults. And Option, +Option, and /Option. And maybe %include?

 I opened #31637 for this test.

 I don't know how to get sample files for this test. Maybe a small example
 is enough?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31631 [Core Tor/Tor]: Write a test for round-trip encode/decode operations on configuration objects.

[Tor Bug Tracker & Wiki]

#31631: Write a test for round-trip encode/decode operations on configuration
objects.
--+
 Reporter:  nickm |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #29211| Points:
 Reviewer:|Sponsor:  Sponsor31-can
--+

Comment (by teor):

 Here's what I suggest:
 1. Run chutney on master
 2. Take copies of the torrc, state, and sr_disk_state files
 3. Run them through file -> object -> file
 4. Use the output files as inputs to unit tests
 5. Make the unit tests do file -> object -> file -> object
 6. Check that both files and both objects match
 7. If the files don't match, and the differences aren't meaningful,
 either:
   * mock the functions that return variable content, or
   * exclude the variable content from the test

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31594 [Core Tor/Tor]: Close all the log fds before aborting

[Tor Bug Tracker & Wiki]

#31594: Close all the log fds before aborting
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, 042-should, android,|  Actual Points:  0.5
  macos, 035-backport, 040-backport, |
  041-backport   |
Parent ID:  #31571   | Points:  0.3
 Reviewer:  nickm|Sponsor:
-+-

Comment (by teor):

 Replying to [comment:6 teor]:
 > Replying to [comment:5 nickm]:
 > > I've left a couple of comments on the review. I've not reviewed the
 fsync commit, and I haven't checked that the new list of levels on the
 subsystems matches their dependency order or their order in
 subsystem_list.c.
 >
 > I didn't modify subsystem_list.c, I'll fix it when I revise the branch.
 > The subsystem levels vs subsystem_list.c order could be a unit test?
 > I'll see if I can make that happen.

 They are already a test on tor startup:
 https://trac.torproject.org/projects/tor/ticket/31634#comment:3

 So our CI won't pass if we mess this order up. (Any check that launches
 tor should fail, including keys, zero-length files, rebind, chutney and
 stem.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31634 [Core Tor/Tor]: Check .may_include order and tor subsystem init order are compatible

[Tor Bug Tracker & Wiki]

#31634: Check .may_include order and tor subsystem init order are compatible
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, 042-should, |  Actual Points:
  practracker|
Parent ID:  #31615   | Points:  2
 Reviewer:   |Sponsor:
 |  Sponsor31-can
-+-

Comment (by teor):

 Replying to [comment:2 nickm]:
 > Replying to [comment:1 teor]:
 > > We might also want to check against the order in subsystem_list.c.
 >
 > Yes, but have a look at check_and_setup() in subsysmgr.c -- that causes
 tor to exit with an assertion failure on startup if the subsystems are not
 sorted by priority.

 So we don't need to check the order in subsystem_list.c, because tor does
 it for us. That's good.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31625 [Core Tor/Tor]: config refactoring: fix hierarchy of configuration variable flags

[Tor Bug Tracker & Wiki]

#31625: config refactoring: fix hierarchy of configuration variable flags
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-august  |  Actual Points:
Parent ID:  #29211   | Points:  .5
 Reviewer:  teor |Sponsor:
-+-
Changes (by teor):

 * status:  needs_review => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31625 [Core Tor/Tor]: config refactoring: fix hierarchy of configuration variable flags

[Tor Bug Tracker & Wiki]

#31625: config refactoring: fix hierarchy of configuration variable flags
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-august  |  Actual Points:
Parent ID:  #29211   | Points:  .5
 Reviewer:  teor |Sponsor:
-+-

Comment (by teor):

 Replying to [comment:1 nickm]:
 > Here's a proposed design -- what do you think?

 Overall, it looks good.

 I'd like this documentation to turn into module comment(s) in the
 appropriate module(s).

 I have some suggestions about names.
 But naming is hard, so I am happy to go with whatever you decide.

 > == The current situation ==
 >
 > Currently we have two kinds of flags:
 >* flags for types
 >* flags for variables.
 >
 > If a flag is set on a type, it applies to every variable of that type.
 > If a flag is set on a variable, it applies only to that variable.

 I hadn't really noticed this, it's helpful to have it explained.

 > The type flags are:
 >
 >unsettable -- cannot be set directly by name. (LINELIST_V, OBSOLETE)
 >
 >contained -- addresses part of another type. (LINELIST_S, OBSOLETE)

 Can we renamed "contained" to "derived"?

 I am still confused when I read "contained", because it means a lot of
 different things, particularly when we have a containers module.

 >cumulative -- setting a variable of this type does not override older
 >   values set to this type. (all LINELIST, LINELIST_V, LINELIST_S)


 In the man page, we say "append", I think that's a clearer name.
 But the grammar of "is_append" also feels weird to me. "is_appended"?
 So I don't have a strong opinion either way.

 > The variable flags are:
 >
 >invisible -- does not show up on lists of variables, does not get
 written to disk, and is not visible to the controller.
 >
 >obsolete -- produce a warning on any attempt to set or fetch the
 option. Do not list it as a valid option.

 What does setting or fetching an obsolete option do? Nothing?

 >nodump -- do not write to disk.  These are mostly testing options.
 >
 > == The refactoring ==
 >
 > The new orthogonal low-level options are:

 In general, I like this set of names.
 But negatives are hard: most of these options start with "NO".

 There's a design conflict here:
 * we want the defaults to be 0x
 * we want the option names to be easy to understand

 I think this design's use of "NO" is a good compromise.
 But if you can think of a better one, I would be happy to review it.

 >   * NOSET -- cannot be set by name.
 >
 >   * NOLIST -- does not appear in lists of options.
 >
 >   * NODUMP -- do not dump this option to disk from config_dump() --
 either because it is a testing option, or because it is contained in
 another option.

 derived from another option?

 >   * NOCOPY -- do not try to copy this option in config_dup, because it
 is contained in another option, or has no storage.

 derived from another option?

 >   * NOGET -- cannot be fetched by the controller.
 >
 >   * CUMULATIVE -- remains unchanged.  We might call it NOREPLACE or
 > NOOVERWRITE if that's clearer?

 I like NOREPLACE for consistency with the other options: it's weird to
 have a single option that is not inverted.

 > With this set of options:
 >
 >   "cumulative" remains CUMULATIVE.

 Might be renamed to "append" / NOREPLACE.

 >   "nodump" remains "NODUMP".
 >
 >   "unsettable" becomes NOSET.
 >
 >   "contained" becomes NODUMP + NOCOPY

 "contained" is renamed to "derived", and becomes NODUMP + NOCOPY

 >   "invisible" becomes NOGET + NOSET + NODUMP + NOLIST
 >
 >   "obsolete" becomes NOGET + NOSET + NODUMP + NOCOPY + NOLIST.
 >
 > == How flags are set ==
 >
 > Flags can be set either on a type or on a variable.  Variable flags are
 or'd with the flags of their type before checking them.

 How do the struct_var_is_* functions change?
 Do we make matching changes in both the typed var and struct var modules?

 I also opened #31637 to check that we have test coverage for:
 * Option, +Option, and /Option,
 * across command-line, torrc, and defaults,
 since we're changing the "cumulative" implementation.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31637 [Core Tor/Tor]: Make sure we have test coverage for Option, +Option and /Option across defaults, torrc, command line

[Tor Bug Tracker & Wiki]

#31637: Make sure we have test coverage for Option, +Option and /Option across
defaults, torrc, command line
--+-
 Reporter:  teor  |  Owner:  nickm
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  network-team-roadmap-august
Actual Points:|  Parent ID:  #29211
   Points:|   Reviewer:
  Sponsor:|
--+-
 The tor man page says:

 By default, an option on the command line overrides an option found in
 the configuration file, and an option in a configuration file overrides
 one in the defaults file.

 This rule is simple for options that take a single value, but it can
 become complicated for options that are allowed to occur more than once:
 if you specify four SocksPorts in your configuration file, and one more
 SocksPort on the command line, the option on the command line will replace
 all of the SocksPorts in the configuration file. If this isn’t what you
 want, prefix the option name with a plus sign (+), and it will be appended
 to the previous set of options instead. For example, setting SocksPort
 9100 will use only port 9100, but setting +SocksPort 9100 will use ports
 9100 and 9050 (because this is the default).

 Alternatively, you might want to remove every instance of an option in
 the configuration file, and not replace it at all: you might want to say
 on the command line that you want no SocksPorts at all. To do that, prefix
 the option name with a forward slash (/). You can use the plus sign (+)
 and the forward slash (/) in the configuration file and on the command
 line.

 Where are our tests for this specification, and do they have the coverage
 we need to test this refactor?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31634 [Core Tor/Tor]: Check .may_include order and tor subsystem init order are compatible

[Tor Bug Tracker & Wiki]

#31634: Check .may_include order and tor subsystem init order are compatible
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, 042-should, |  Actual Points:
  practracker|
Parent ID:  #31615   | Points:  2
 Reviewer:   |Sponsor:
 |  Sponsor31-can
-+-

Comment (by nickm):

 Replying to [comment:1 teor]:
 > We might also want to check against the order in subsystem_list.c.

 Yes, but have a look at check_and_setup() in subsysmgr.c -- that causes
 tor to exit with an assertion failure on startup if the subsystems are not
 sorted by priority.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31636 [Core Tor/Tor]: Circuit padding: Add meta probability distribution type

[Tor Bug Tracker & Wiki]

#31636: Circuit padding: Add meta probability distribution type
--+-
 Reporter:  mikeperry |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  wtf-pad
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+-
 Tobias Pulls pointed out that his APE system actually randomized the
 *parameters* of the probability distributions that he used, for each
 circuit.

 If this is indeed helpful (it probably is), we should find out which form
 or forms of per-circuit parameter randomization is best to use, and get it
 supported by the circuit padding framework.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31594 [Core Tor/Tor]: Close all the log fds before aborting

[Tor Bug Tracker & Wiki]

#31594: Close all the log fds before aborting
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, 042-should, android,|  Actual Points:  0.5
  macos, 035-backport, 040-backport, |
  041-backport   |
Parent ID:  #31571   | Points:  0.3
 Reviewer:  nickm|Sponsor:
-+-

Comment (by teor):

 Replying to [comment:5 nickm]:
 > I've left a couple of comments on the review. I've not reviewed the
 fsync commit, and I haven't checked that the new list of levels on the
 subsystems matches their dependency order or their order in
 subsystem_list.c.

 I didn't modify subsystem_list.c, I'll fix it when I revise the branch.
 The subsystem levels vs subsystem_list.c order could be a unit test?
 I'll see if I can make that happen.

 > Here are my current thoughts on your questions, but for all of these
 cases, I'll defer to your judgment.
 >
 > > when we clear the list of error fds, should we use -1 or 0 as the
 placeholder value?
 >
 > If the n_sigsafe_log_fds value is zero, it should not matter what the
 empty entries contain.
 >
 > That said, -1 is more commonly used in our code for "not a valid FD."
 (''That'' said, we already use 0 here, and it might be better to leave
 that unchanged in this branch.)

 I opened #31635 for follow up. I wonder if we should do it on this branch,
 so we don't end up with backport conflicts, if we decide to backport.

 > > are any of these bugs serious? Do they need a backport?
 >
 > IMO they don't currently warrant a backport, but they might warrant a
 backport some day.  They strike me as the kind of issue that we might
 change our mind about and really wish we had backported at some point in
 the future.  On the other hand, they also strike me as subtle enough to
 warrant extensive testing before we think of a backport.

 I'll do them on 0.3.5, mark them as "test in 0.4.2-stable before
 backport", and mark them as a "maybe-not" backport.

 > > should I split this PR up into multiple PRs?
 >
 > I don't think so, unless you want to. Maybe. (At first I thought that if
 we are considering a backport, we might want to backport only part of this
 branch.  But on the other hand, if we backport only part of this branch,
 we risk backporting something unstable that has not had testing.)

 I think I want a clean_up_backtrace_handler() / subsystem / log split.
 These sets of changes are pretty independent, so backporting them
 independently should be ok.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31635 [Core Tor/Tor]: Initialise and reset the sigsafe error fds to -1

[Tor Bug Tracker & Wiki]

#31635: Initialise and reset the sigsafe error fds to -1
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.4.2.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  diagnostics, 042-should, android,
 Severity:  Normal   |  macos, 035-backport, 040-backport, 041-backport
Actual Points:   |  Parent ID:  #31594
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 We currently initialise and reset them to zero, which is stdin or
 /dev/null. So this is a future correctness change.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31634 [Core Tor/Tor]: Check .may_include order and tor subsystem init order are compatible

[Tor Bug Tracker & Wiki]

#31634: Check .may_include order and tor subsystem init order are compatible
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, 042-should, |  Actual Points:
  practracker|
Parent ID:  #31615   | Points:  2
 Reviewer:   |Sponsor:
 |  Sponsor31-can
-+-

Comment (by teor):

 We might also want to check against the order in subsystem_list.c.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31628 [Internal Services/Tor Sysadmin Team]: please update the following alias

[Tor Bug Tracker & Wiki]

#31628: please update the following alias
-+-
 Reporter:  isabela  |  Owner:  anarcat
 Type:  task | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by isabela):

 Replying to [comment:5 anarcat]:
 > i removed maria from grants, but i already see alison@tpo on
 fundraising, now i need to *also* add smith@ (and not alsmith@)?

 There is Alison and there is Al, we are asking to add Al, who has the
 email sm...@torproject.org

 tx!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22029 [Core Tor/Tor]: Allow ed25519 keys to be banned in the approved-routers file

[Tor Bug Tracker & Wiki]

#22029: Allow ed25519 keys to be banned in the approved-routers file
-+-
 Reporter:  teor |  Owner:  neel
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-triage-20180328, |  Actual Points:
  034-removed-20180328   |
Parent ID:   | Points:  1
 Reviewer:  nickm|Sponsor:
-+-
Changes (by teor):

 * reviewer:  teor => nickm


Comment:

 Hi nickm, if you could do a review of this branch, that would be great.

 I've made a few child tickets for tests, I think we should at least test
 on chutney or moria1 before merging.
 It would also be nice for relay operators to have a file with the ed25519
 identity in their data directory, but that can be a separate PR.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30642 [Core Tor/Tor]: Add an ed25519_identity file to the data directory

[Tor Bug Tracker & Wiki]

#30642: Add an ed25519_identity file to the data directory
--+--
 Reporter:  teor  |  Owner:  (none)
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-relay |  Actual Points:
Parent ID:  #22029| Points:  1
 Reviewer:|Sponsor:
--+--
Changes (by teor):

 * owner:  neel => (none)


Comment:

 This ticket hasn't made progress, so I'm un-assigning it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30992 [Core Tor/Tor]: circpadding machines have shutdown sync issues (with intro circ NACKs and other cases)

[Tor Bug Tracker & Wiki]

#30992: circpadding machines have shutdown sync issues (with intro circ NACKs 
and
other cases)
--+
 Reporter:  asn   |  Owner:  (none)
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor:
  |  unspecified
Component:  Core Tor/Tor  |Version:  Tor:
  |  0.4.1.1-alpha
 Severity:  Normal| Resolution:
 Keywords:  wtf-pad circpad 042-proposed  |  Actual Points:
Parent ID:| Points:  3
 Reviewer:|Sponsor:
--+
Changes (by gaba):

 * owner:  mikeperry => (none)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31631 [Core Tor/Tor]: Write a test for round-trip encode/decode operations on configuration objects.

[Tor Bug Tracker & Wiki]

#31631: Write a test for round-trip encode/decode operations on configuration
objects.
--+
 Reporter:  nickm |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #29211| Points:
 Reviewer:|Sponsor:  Sponsor31-can
--+

Comment (by teor):

 Yes, I think that the objects should be the same, even if the file content
 differs in in minor ways.

 Maybe the fuzzer test could do file -> object -> file -> object, and then
 compare the objects.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31625 [Core Tor/Tor]: config refactoring: fix hierarchy of configuration variable flags

[Tor Bug Tracker & Wiki]

#31625: config refactoring: fix hierarchy of configuration variable flags
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-august  |  Actual Points:
Parent ID:  #29211   | Points:  .5
 Reviewer:  teor |Sponsor:
-+-

Comment (by teor):

 At the higher level, we could use is_derived() rather than is_contained().

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31494 [Core Tor/Tor]: config refactoring: follow-ups from merged commits

[Tor Bug Tracker & Wiki]

#31494: config refactoring: follow-ups from merged commits
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  network-team-roadmap-august  |  Actual Points:  0
Parent ID:  #29211   | Points:
 Reviewer:   |Sponsor:  Sponsor31-must
-+-
Changes (by teor):

 * status:  needs_review => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31571 [Core Tor/Tor]: Add the tor version and a newline to raw_assert()

[Tor Bug Tracker & Wiki]

#31571: Add the tor version and a newline to raw_assert()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, 042-should, android,|  Actual Points:  0.1
  macos, 035-backport, 040-backport, |
  041-backport   |
Parent ID:  #31570   | Points:  0.1
 Reviewer:  nickm|Sponsor:
 |  Sponsor31-can
-+-
Changes (by teor):

 * status:  needs_revision => merge_ready


Comment:

 Replying to [comment:8 nickm]:
 > The return-value checking looks okay to me.
 >
 > I don't see any additional refactoring or comment changes on the master
 branch, however.  Did they get eaten by a force-push?  If you still want
 to do them, please put this back in needs_review when you're done.
 Otherwise this branch can go into merge_ready.

 I split the comment changes into #31612, they were unrelated to this PR.
 The refactoring wasn't possible due to layering issues with strlcpy().
 So I just checked the return values in the 0.3.5 branch instead.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31615 [Core Tor/Tor]: Reorder the early subsystems based on their dependencies

[Tor Bug Tracker & Wiki]

#31615: Reorder the early subsystems based on their dependencies
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, 042-should, android,|  Actual Points:
  macos, 035-backport, 040-backport, |
  041-backport   |
Parent ID:  #31594   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 Yeah and we can't parse it out of the logs, because the buggy module order
 was in modules that were initialised before the logs.

 I opened #31634 for that change. It's a big one, so I'm not going to do
 anything about it now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31634 [Core Tor/Tor]: Check .may_include order and tor subsystem init order are compatible

[Tor Bug Tracker & Wiki]

#31634: Check .may_include order and tor subsystem init order are compatible
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.4.2.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  diagnostics, 042-should,
 Severity:  Normal   |  practracker
Actual Points:   |  Parent ID:  #31615
   Points:  2|   Reviewer:
  Sponsor:   |
  Sponsor31-can  |
-+-
 In #31615, we discovered that our module init order doesn't match their
 dependency order.

 Let's use practracker and tor to make sure that doesn't happen again.
 We'll probably need a new make check target,  because we'll need a
 compiled tor and practracker output. See #31615 for details.

 Gaba, this is Sponsor 31-can, because it helps us catch refactoring bugs
 when we create new modules.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31633 [Internal Services/Tor Sysadmin Team]: publish HTML documentation of our puppet source

[Tor Bug Tracker & Wiki]

#31633: publish HTML documentation of our puppet source
-+
 Reporter:  anarcat  |  Owner:  tpa
 Type:  enhancement  | Status:  new
 Priority:  Low  |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:  #29387
   Points:   |   Reviewer:
  Sponsor:   |
-+
 there are ways of generating HTML versions of Puppet source code, based on
 the docstrings littering the source code. i've done some tentative runs of
 this and it looks ... interesting. the utility of this is currently
 limited by the fact that only 35% of the source is documented, according
 to `puppet strings`, but i figured I would document the efforts I've done
 so far already.

 Koumbit uses the following Rakefile to generate the docs for their
 monorepo:

 {{{
 #require 'bundler/gem_tasks'

 task :default do
   # nothing
   puts('no action')
 end

 task :doc do
   require 'puppet-strings/tasks/generate'
   # This doesn't seem to really process node files, but
   # an exclude of manifests/ might be interesting.
   Rake::Task['strings:generate'].invoke(
 # This list of included files was taken from
 # https://github.com/puppetlabs/puppet-strings#generating-
 documentation-with-puppet-strings
 # and should correspond to what puppet-strings does by default, but
 spanned
 # over all of the code directories in the control repos.
 # It's possible that some directories might include .rb files that
 were not
 # specified.. We'll have to fix this if we ever encounter such an
 issue.
 '**/manifests/**/*.pp **/functions/**/*.pp **/types/**/*.pp
 **/tasks/**/*.pp **/lib/**/*.rb',
 'false',
 'false',
 'markdown'
   )
 end

 # Generate documentation only for manifests in site/
 # This will help to verify if there's anything in our own code that's
 missing
 # comments for documentation. The run will be faster and less noisy than
 when
 # we generate everything.
 # Note, though, that it will create an index only for things in site/
 task :doc_site do
   require 'puppet-strings/tasks/generate'
   # This doesn't seem to really process node files, but
   # an exclude of manifests/ might be interesting.
   Rake::Task['strings:generate'].invoke(
 'site/**/*.pp site/**/*.rb',
 'false',
 'false',
 'markdown'
   )
 end

 task :doc_clean do
   system("rm -rf doc")
 end

 task :doc_upload, [:ftp_host, :ftp_port, :ftp_user, :ftp_pass, :ftp_dir]
 do |t, args|
   puts "lftp -e \"mirror -R doc #{args[:ftp_dir]}\" -u
 #{args[:ftp_user]},#{args[:ftp_pass]} -p #{args[:ftp_port]}
 #{args[:ftp_host]}"
   system("lftp -e \"mirror -R doc #{args[:ftp_dir]}; quit\" -u
 #{args[:ftp_user]},#{args[:ftp_pass]} -p #{args[:ftp_port]}
 #{args[:ftp_host]}")
 end
 }}}

 Notice the two different jobs for `site` (private) and `modules` (public).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31628 [Internal Services/Tor Sysadmin Team]: please update the following alias

[Tor Bug Tracker & Wiki]

#31628: please update the following alias
-+-
 Reporter:  isabela  |  Owner:  anarcat
 Type:  task | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by anarcat):

 * status:  assigned => needs_information


Comment:

 i removed maria from grants, but i already see alison@tpo on fundraising,
 now i need to *also* add smith@ (and not alsmith@)?

 sorry for the delay, i'm slightly confused :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31407 [Circumvention/Snowflake]: Create a broker spec for metrics collection

[Tor Bug Tracker & Wiki]

#31407: Create a broker spec for metrics collection
-+
 Reporter:  cohosh   |  Owner:  cohosh
 Type:  enhancement  | Status:  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-spec |  Actual Points:
Parent ID:   | Points:
 Reviewer:  phw  |Sponsor:
-+
Changes (by phw):

 * status:  needs_review => needs_revision


Comment:

 I added a bunch of comments
 
[https://github.com/cohosh/snowflake/commit/6262246c31a6be49c12c6d55809ba7768aaca6f9
 to the patch]. The location looks good to me and is consistent with obfs4,
 which has its spec in doc/obfs4-spec.txt.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28942 [Circumvention/Snowflake]: Evaluate pion WebRTC

[Tor Bug Tracker & Wiki]

#28942: Evaluate pion WebRTC
+--
 Reporter:  backkem |  Owner:  cohosh
 Type:  enhancement | Status:  accepted
 Priority:  Medium  |  Milestone:
Component:  Circumvention/Snowflake |Version:
 Severity:  Normal  | Resolution:
 Keywords:  anti-censorship-roadmap-august  |  Actual Points:
Parent ID:  | Points:  5
 Reviewer:  |Sponsor:
|  Sponsor28-must
+--

Comment (by cohosh):

 Replying to [comment:55 cohosh]:
 > Now I'm back to the issues found in comment:49. The client successfully
 completes the rendezvous/signaling and then is failing to open the data
 channel (which causes the proxy to eventually time out and keep polling).

 Okay it seems to be working fine for me now (with this patch).

 I enabled logging of pion trace and debug messages to the snowflake logger
 with
 
[https://github.com/cohosh/snowflake/commit/ee8ddfe579092a126434bae4cf83203caf1d818b
 this commit] but this caused a race condition that prevented the client
 from opening a data channel.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19757 [Applications/Tor Browser]: Make a menu to add onion and auth-cookie to TB

[Tor Bug Tracker & Wiki]

#19757: Make a menu to add onion and auth-cookie to TB
+--
 Reporter:  mrphs   |  Owner:  tbb-team
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ux-team, tbb-usability, tor-hs  |  Actual Points:
Parent ID:  #3  | Points:
 Reviewer:  |Sponsor:
|  Sponsor27-must
+--
Changes (by gaba):

 * keywords:  ux-team, tbb-usability, tor-hs, network-team-roadmap-september
 => ux-team, tbb-usability, tor-hs


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31628 [Internal Services/Tor Sysadmin Team]: please update the following alias

[Tor Bug Tracker & Wiki]

#31628: please update the following alias
-+-
 Reporter:  isabela  |  Owner:  anarcat
 Type:  task | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by anarcat):

 * status:  new => assigned
 * owner:  tpa => anarcat


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19757 [Applications/Tor Browser]: Make a menu to add onion and auth-cookie to TB

[Tor Bug Tracker & Wiki]

#19757: Make a menu to add onion and auth-cookie to TB
-+-
 Reporter:  mrphs|  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team, tbb-usability, tor-hs,  |  Actual Points:
  network-team-roadmap-september |
Parent ID:  #3   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor27-must
-+-
Changes (by gaba):

 * keywords:  ux-team, tbb-usability, tor-hs => ux-team, tbb-usability, tor-
 hs, network-team-roadmap-september


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31608 [Core Tor/Tor]: circuit_state_publish() never triggers when a new origin circuit is created

[Tor Bug Tracker & Wiki]

#31608: circuit_state_publish() never triggers when a new origin circuit is 
created
+
 Reporter:  dgoulet |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-circuit tor-pubsub  |  Actual Points:
Parent ID:  #31609  | Points:  0.1
 Reviewer:  |Sponsor:
+

Comment (by catalyst):

 Replying to [comment:3 dgoulet]:
 > For now, I'm leaning towards "pubsubs setup at all time for all tests"
 since initializing a new origin circuit is very basic use case in tests
 and shouldn't require us to do extra work.
 I think I was planning to have the general test setup configure pubsub,
 but Nick talked me out of it. I'll have to dig around for details.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31616 [Applications/Tor Browser]: Tor Browser on Android based on 60.9.0 is crashing on every launch

[Tor Bug Tracker & Wiki]

#31616: Tor Browser on Android based on 60.9.0 is crashing on every launch
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-mobile, tbb-crash,   |  Actual Points:
  TorBrowserTeam201909   |
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:14 sysrqb]:
 > Replying to [comment:13 sysrqb]:
 > > Google Play shows this is primarily affecting Android 9 on aarch64.
 `signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x2aae` is
 interesting. This is the same fault address (and same code) as #31140.
 >
 > This is the same bug as #31140. acat found there was a syntax error on
 [ticket:31140#comment:30 #31140] in the original patch and corrected that.
 I didn't notice the syntax error while I was testing the original patch
 and I incorrectly assumed the patch avoided the gecko crash, instead the
 syntax error preventing the code from executing.
 >
 > After some more testing now, it does seems like
 `javascript.options.native_regexp` is the correct pref we should disable.
 `ion` is not the cause and it is enable by default (and it does not cause
 a crash).

 I am wary having those JIT options on. Cypherpunks mentioned a meta bug
 about baseline JIT issues e.g. and there might be other ones as well (with
 `ion` as well although it might not be available on aarch64 on esr60?).
 I'd really like to avoid playing whack-a-mole here by us doing release
 after release to deal with those crash bugs one-by-one. We don't have the
 time and capacity for that.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31628 [Internal Services/Tor Sysadmin Team]: please update the following alias

[Tor Bug Tracker & Wiki]

#31628: please update the following alias
-+-
 Reporter:  isabela  |  Owner:  tpa
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Old description:

> change Al email on fundrais...@torproject.org
> from: h...@azsmith.info
> to: sm...@torproject.org
>
> remove Maria from gra...@torproject.org
> email: ma...@openobservatory.org

New description:

 add Al email on fundrais...@torproject.org
 email: sm...@torproject.org

 remove Maria from gra...@torproject.org
 email: ma...@openobservatory.org

--

Comment (by isabela):

 updated the ticket following Al's clarification :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31628 [Internal Services/Tor Sysadmin Team]: please update the following alias

[Tor Bug Tracker & Wiki]

#31628: please update the following alias
-+-
 Reporter:  isabela  |  Owner:  tpa
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by isabela):

 * type:  defect => task


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31629 [Core Tor/Tor]: Remove non-_ex typedvar.c function

[Tor Bug Tracker & Wiki]

#31629: Remove non-_ex typedvar.c function
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  task | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-august  |  Actual Points:
Parent ID:  #29211   | Points:  0
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23971 [Applications/Tor Launcher]: implement multi-step progress bar for new Tor Launcher UI

[Tor Bug Tracker & Wiki]

#23971: implement multi-step progress bar for new Tor Launcher UI
---+---
 Reporter:  mcs|  Owner:  brade
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Launcher  |Version:
 Severity:  Normal | Resolution:
 Keywords:  ux-team|  Actual Points:
Parent ID:  #21951 | Points:
 Reviewer: |Sponsor:
---+---

Comment (by antonela):

 Maybe we can incorporate this idea during S30 work. #31283 could hold this
 one as a child.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31632 [Core Tor/Tor]: hs-v3: Service doesn't re-upload descriptor on circuit failure

[Tor Bug Tracker & Wiki]

#31632: hs-v3: Service doesn't re-upload descriptor on circuit failure
+
 Reporter:  dgoulet |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  |   Keywords:  tor-hs
Actual Points:  |  Parent ID:  #30200
   Points:  |   Reviewer:  asn
  Sponsor:  Sponsor27-must  |
+
 I'm observing, quite often actually, a service posting its descriptor to
 an HSDir but the circuit collapses due to remote reason `CHANNEL_CLOSED`.

 This is possible for many reasons where a link between two relays
 failed/disconnected/closed/...

 However, we do not retry the upload after that which means that we can end
 up with HSDir(s) without our descriptor even though we think they are
 there.

 Solution is unclear but it appears that we probably want to hook this case
 into `hs_circ_cleanup()` which is called from the mark for close function.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31627 [Core Tor/Tor]: Fill in all missing documentation in config, confparse, etc.

[Tor Bug Tracker & Wiki]

#31627: Fill in all missing documentation in config, confparse, etc.
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .1
Parent ID:  #29211| Points:  .2
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31494 [Core Tor/Tor]: config refactoring: follow-ups from merged commits

[Tor Bug Tracker & Wiki]

#31494: config refactoring: follow-ups from merged commits
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  task | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-august  |  Actual Points:  0
Parent ID:  #29211   | Points:
 Reviewer:   |Sponsor:  Sponsor31-must
-+-
Changes (by nickm):

 * status:  accepted => needs_review
 * actualpoints:   => 0


Comment:

 I think that all of the issues described above now have their own ticket.
 If you agree, let's close this ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31631 [Core Tor/Tor]: Write a test for round-trip encode/decode operations on configuration objects.

[Tor Bug Tracker & Wiki]

#31631: Write a test for round-trip encode/decode operations on configuration
objects.
---+
 Reporter:  nickm  |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal |   Keywords:
Actual Points: |  Parent ID:  #29211
   Points: |   Reviewer:
  Sponsor:  Sponsor31-can  |
---+
 We should have tests to round-trip through torrc, state, and sr_disk_state
 objects.  We should make sure that encoding a configuration object and
 then parsing it again gives us the same result.

 We might be able to turn this into a fuzzer test.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31516 [Core Tor/Tor]: config refactor: every function table entry should be documented and unit tested

[Tor Bug Tracker & Wiki]

#31516: config refactor: every function table entry should be documented and 
unit
tested
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-august  |  Actual Points:
Parent ID:  #29211   | Points:
 Reviewer:   |Sponsor:  Sponsor31-must
-+-

Comment (by nickm):

 In current git-master, I think that every function pointer is called from
 the unit tests, based on inspection of the coverage.  I'll make sure that
 my future branches test all of our function pointers.

 (While I was looking at the coverage, I found some unused APIs, however. I
 opened #31629 and #31630 to remove them.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31630 [Core Tor/Tor]: Remove unused assign/encode functions in structvar.

[Tor Bug Tracker & Wiki]

#31630: Remove unused assign/encode functions in structvar.
---+
 Reporter:  nickm  |  Owner:  nickm
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal |   Keywords:
Actual Points: |  Parent ID:  #29211
   Points:  0  |   Reviewer:
  Sponsor:  Sponsor31-can  |
---+
 The "assign" and "encode" functions in structvar are never used, since
 they operate on strings, and all of our config code uses config_line_t.
 We can safely remove them.

 We can only do this once #31629 is merged, or else we will get conflicts.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31629 [Core Tor/Tor]: Remove non-_ex typedvar.c function

[Tor Bug Tracker & Wiki]

#31629: Remove non-_ex typedvar.c function
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  task | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-august  |  Actual Points:
Parent ID:  #29211   | Points:  0
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 I have a branch `ticket31629` with a PR at
 https://github.com/torproject/tor/pull/1295 .

 There is no changes file here, since it contains no changes beyond those
 already contained in earlier commits.  There are two commits: one is pure
 code removal, and the other is automatically generated function renaming.

 I'll put this in needs_review once CI passes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28942 [Circumvention/Snowflake]: Evaluate pion WebRTC

[Tor Bug Tracker & Wiki]

#28942: Evaluate pion WebRTC
+--
 Reporter:  backkem |  Owner:  cohosh
 Type:  enhancement | Status:  accepted
 Priority:  Medium  |  Milestone:
Component:  Circumvention/Snowflake |Version:
 Severity:  Normal  | Resolution:
 Keywords:  anti-censorship-roadmap-august  |  Actual Points:
Parent ID:  | Points:  5
 Reviewer:  |Sponsor:
|  Sponsor28-must
+--

Comment (by cohosh):

 Replying to [comment:54 cohosh]:
 > In addition to the issues above, which can be solved with the attached
 patch, the proxy is very slow to generate SDP answers causing the broker
 to timeout. Here are some logs:
 >
 > {{{
 > 2019/09/04 18:01:04 broker returns: 504
 > 2019/09/04 18:01:04 Received offer.
 > 2019/09/04 18:01:24 Setting remote description
 > 2019/09/04 18:01:24 sdp offer successfully received.
 > 2019/09/04 18:01:24 Generating answer...
 > 2019/09/04 18:01:24 error sending answer to client through broker:
 broker returned 410
 > }}}
 >
 > I added the {Received offer} log message
 [https://github.com/cohosh/snowflake/blob/pion/proxy-go/snowflake.go#L349
 here] as a local change.
 >
 > You can see that it takes 20 seconds between receiving the offer and
 generating an answer and after further instrumenting, it appears to be
 caused by the `NewPeerConnection` function
 [https://github.com/cohosh/snowflake/blob/pion/proxy-go/snowflake.go#L280
 here].

 > To be honest, starting ICE gathering in `NewPeerConnection` doesn't make
 sense to me from a design point of view. I would expect it to occur in
 `CreateAnswer` instead (with the trickle method it starts in
 `SetLocalDescription` which I also find unintuitive). The patch above also
 removes a call to `Gather` from `SetRemoteDescription` which also confused
 me.

 This turned out to be a local issue, but I still think it's a weird
 design.

 Now I'm back to the issues found in comment:49. The client successfully
 completes the rendezvous/signaling and then is failing to open the data
 channel (which causes the proxy to eventually time out and keep polling).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31629 [Core Tor/Tor]: Remove non-_ex typedvar.c function

[Tor Bug Tracker & Wiki]

#31629: Remove non-_ex typedvar.c function
--+-
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  network-team-roadmap-august
Actual Points:|  Parent ID:  #29211
   Points:  0 |   Reviewer:
  Sponsor:|
--+-
 This API is unused and untested: we may as well remove it entirely before
 it accumulates technical debt.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31539 [Applications/Tor Browser]: FAQ page (esp connection troubleshoooting) should be available offline in TB

[Tor Bug Tracker & Wiki]

#31539: FAQ page (esp connection troubleshoooting) should be available offline 
in
TB
--+---
 Reporter:  mrphs |  Owner:  tbb-team
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  censorship, support,  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:  Sponsor30-can
--+---

Comment (by phw):

 I'm a fan of this, thanks mrphs! This is a good reminder that we will have
 to overhaul our circumvention-related documentation a bit because it's
 outdated.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31628 [Internal Services/Tor Sysadmin Team]: please update the following alias

[Tor Bug Tracker & Wiki]

#31628: please update the following alias
-+-
 Reporter:  isabela  |  Owner:  tpa
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by alsmith):

 To clarify, I'm not actually on fundraising@ at all (not as hi@..., not as
 smith@...). I just need to be added as smith@...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31628 [Internal Services/Tor Sysadmin Team]: please update the following alias

[Tor Bug Tracker & Wiki]

#31628: please update the following alias
-+-
 Reporter:  isabela  |  Owner:  tpa
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 change Al email on fundrais...@torproject.org
 from: h...@azsmith.info
 to: sm...@torproject.org

 remove Maria from gra...@torproject.org
 email: ma...@openobservatory.org

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31539 [Applications/Tor Browser]: FAQ page (esp connection troubleshoooting) should be available offline in TB

[Tor Bug Tracker & Wiki]

#31539: FAQ page (esp connection troubleshoooting) should be available offline 
in
TB
--+---
 Reporter:  mrphs |  Owner:  tbb-team
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  censorship, support,  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:  Sponsor30-can
--+---

Comment (by boklm):

 Replying to [comment:7 ggus]:
 > Replying to [comment:6 antonela]:
 > > Replying to [comment:5 gk]:
 > > > Maybe this ticket is a duplicate of #20639, too?
 > >
 > > Since we are using Lektor for TB Manual, all the content is available
 in a markdown format. We could find a way to render an offline Lektor and
 ship it with Tor Browser, or we might want to pick the relevant content
 for censored users to config Tor Browser successfully and render a local
 HTML page. Either of those are worth for S30.
 >
 > Lektor can generate static HTML for us :)

 Can it generate pdf? Maybe having to open a separate browser to look at
 the manual can be confusing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28533 [Circumvention/BridgeDB]: bridgesdb: replace the message to mail support with a link to the documentation

[Tor Bug Tracker & Wiki]

#28533: bridgesdb: replace the message to mail support with a link to the
documentation
+---
 Reporter:  emmapeel|  Owner:  phw
 Type:  defect  | Status:  needs_review
 Priority:  High|  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  ex-sponsor-19   |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  cohosh  |Sponsor:  Sponsor30-can
+---
Changes (by phw):

 * status:  assigned => needs_review
 * reviewer:   => cohosh


Comment:

 Removing the frontdesk@tp.o email sounds good to me. In the paragraph
 above, we already have instructions on how to request bridges by emailing
 bridges@tp.o. I would rather not list these instructions twice  – besides,
 I wouldn't want to suggest that emailing bridges@tp.o is going to fix the
 users' issues. Here's what the patch looks like:
 [[Image(new-landing-page.png)]]

 I pushed a fix to my
 
[https://github.com/NullHypothesis/bridgedb/commit/bfec33e7b1a387688d8236a9e4ebf2a95e60061d
 fix/28533 branch]. Cecylia, can you please take a look at it?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28533 [Circumvention/BridgeDB]: bridgesdb: replace the message to mail support with a link to the documentation

[Tor Bug Tracker & Wiki]

#28533: bridgesdb: replace the message to mail support with a link to the
documentation
+---
 Reporter:  emmapeel|  Owner:  phw
 Type:  defect  | Status:  assigned
 Priority:  High|  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  ex-sponsor-19   |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:  Sponsor30-can
+---
Changes (by phw):

 * Attachment "new-landing-page.png" added.

 New BridgeDB landing page

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31539 [Applications/Tor Browser]: FAQ page (esp connection troubleshoooting) should be available offline in TB

[Tor Bug Tracker & Wiki]

#31539: FAQ page (esp connection troubleshoooting) should be available offline 
in
TB
--+---
 Reporter:  mrphs |  Owner:  tbb-team
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  censorship, support,  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:  Sponsor30-can
--+---

Comment (by ggus):

 Replying to [comment:6 antonela]:
 > Replying to [comment:5 gk]:
 > > Maybe this ticket is a duplicate of #20639, too?
 >
 > Since we are using Lektor for TB Manual, all the content is available in
 a markdown format. We could find a way to render an offline Lektor and
 ship it with Tor Browser, or we might want to pick the relevant content
 for censored users to config Tor Browser successfully and render a local
 HTML page. Either of those are worth for S30.

 Lektor can generate static HTML for us :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28942 [Circumvention/Snowflake]: Evaluate pion WebRTC

[Tor Bug Tracker & Wiki]

#28942: Evaluate pion WebRTC
+--
 Reporter:  backkem |  Owner:  cohosh
 Type:  enhancement | Status:  accepted
 Priority:  Medium  |  Milestone:
Component:  Circumvention/Snowflake |Version:
 Severity:  Normal  | Resolution:
 Keywords:  anti-censorship-roadmap-august  |  Actual Points:
Parent ID:  | Points:  5
 Reviewer:  |Sponsor:
|  Sponsor28-must
+--

Comment (by cohosh):

 In addition to the issues above, which can be solved with the attached
 patch, the proxy is very slow to generate SDP answers causing the broker
 to timeout. Here are some logs:

 {{{
 2019/09/04 18:01:04 broker returns: 504
 2019/09/04 18:01:04 Received offer.
 2019/09/04 18:01:24 Setting remote description
 2019/09/04 18:01:24 sdp offer successfully received.
 2019/09/04 18:01:24 Generating answer...
 2019/09/04 18:01:24 error sending answer to client through broker: broker
 returned 410
 }}}

 I added the {Received offer} log message
 [https://github.com/cohosh/snowflake/blob/pion/proxy-go/snowflake.go#L349
 here] as a local change.

 You can see that it takes 20 seconds between receiving the offer and
 generating an answer and after further instrumenting, it appears to be
 caused by the `NewPeerConnection` function
 [https://github.com/cohosh/snowflake/blob/pion/proxy-go/snowflake.go#L280
 here].

 Note that the proxy-go instances don't use the trickle method and so ICE
 gathering needs to complete before this function returns. I'll try using
 the trickle method and setting an `OnICEGatheringStateChange` callback to
 set the answer when it completes.

 To be honest, starting ICE gathering in `NewPeerConnection` doesn't make
 sense to me from a design point of view. I would expect it to occur in
 `CreateAnswer` instead (with the trickle method it starts in
 `SetLocalDescription` which I also find unintuitive). The patch above also
 removes a call to `Gather` from `SetRemoteDescription` which also confused
 me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31627 [Core Tor/Tor]: Fill in all missing documentation in config, confparse, etc.

[Tor Bug Tracker & Wiki]

#31627: Fill in all missing documentation in config, confparse, etc.
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .1
Parent ID:  #29211| Points:  .2
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * actualpoints:   => .1


Comment:

 Branch is `ticket31627`; PR at https://github.com/torproject/tor/pull/1294

 I anticipate a minor merge conflict between this branch and #31532 ("Use
 ptrdiff_t for struct_member_t.offset, etc") -- this branch adds
 documentation for a field whose type is changed in the other branch.

 I'll put this in needs_review once the CI passes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31627 [Core Tor/Tor]: Fill in all missing documentation in config, confparse, etc.

[Tor Bug Tracker & Wiki]

#31627: Fill in all missing documentation in config, confparse, etc.
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:  #29211
   Points:  .2|   Reviewer:
  Sponsor:|
--+
 There are a few undocumented or underdocumented items in lib/config,
 lib/confmgt, and confparse.[ch].  I should fill in documentation for them
 before proceeding.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28942 [Circumvention/Snowflake]: Evaluate pion WebRTC

[Tor Bug Tracker & Wiki]

#28942: Evaluate pion WebRTC
+--
 Reporter:  backkem |  Owner:  cohosh
 Type:  enhancement | Status:  accepted
 Priority:  Medium  |  Milestone:
Component:  Circumvention/Snowflake |Version:
 Severity:  Normal  | Resolution:
 Keywords:  anti-censorship-roadmap-august  |  Actual Points:
Parent ID:  | Points:  5
 Reviewer:  |Sponsor:
|  Sponsor28-must
+--
Changes (by cohosh):

 * Attachment "0001-Allow-gathering-of-candidates-to-generate-offer.patch"
 added.

 Patch for pion/webrtc bug

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31516 [Core Tor/Tor]: config refactor: every function table entry should be documented and unit tested

[Tor Bug Tracker & Wiki]

#31516: config refactor: every function table entry should be documented and 
unit
tested
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-august  |  Actual Points:
Parent ID:  #29211   | Points:
 Reviewer:   |Sponsor:  Sponsor31-must
-+-

Comment (by nickm):

 In the current git-master, I think that every config-related function-
 table point is documented,  except for validate_fn_t.  I will handle the
 missing documentation for that as part of #31078.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31616 [Applications/Tor Browser]: Tor Browser on Android based on 60.9.0 is crashing on every launch

[Tor Bug Tracker & Wiki]

#31616: Tor Browser on Android based on 60.9.0 is crashing on every launch
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-mobile, tbb-crash,   |  Actual Points:
  TorBrowserTeam201909   |
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
-+-

Comment (by sysrqb):

 Replying to [comment:13 sysrqb]:
 > Google Play shows this is primarily affecting Android 9 on aarch64.
 `signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x2aae` is
 interesting. This is the same fault address (and same code) as #31140.

 This is the same bug as #31140. acat found there was a syntax error on
 [ticket:31140#comment:30 #31140] in the original patch and corrected that.
 I didn't notice the syntax error while I was testing the original patch
 and I incorrectly assumed the patch avoided the gecko crash, instead the
 syntax error preventing the code from executing.

 After some more testing now, it does seems like
 `javascript.options.native_regexp` is the correct pref we should disable.
 `ion` is not the cause and it is enable by default (and it does not cause
 a crash).

 From there it gets more interesting:
 {{{
 09-04 17:50:42.045  4803  4821 I GeckoThread: preparing to run Gecko
 09-04 17:50:42.048  4803  4821 D GeckoThread: State changed to
 MOZGLUE_READY
 [...]
 09-04 17:50:42.234  4803  4821 E GeckoLibLoad: Load sqlite start
 09-04 17:50:42.236  4803  4821 E GeckoLinker: /system/lib64/libc.so:
 Missing or broken DT_HASH
 09-04 17:50:42.236  4803  4821 E GeckoLinker: /system/lib64/libc.so:
 Missing or broken DT_HASH
 [...]
 09-04 17:50:46.360  4803  4829 D : HostConnection::get() New Host
 Connection established 0x79d891ea80, tid 4829
 09-04 17:50:46.389  4803  4829 I OpenGLRenderer: Initialized EGL, version
 1.4
 09-04 17:50:46.390  4803  4829 D OpenGLRenderer: Swap behavior 1
 09-04 17:50:46.391  4803  4829 W OpenGLRenderer: Failed to choose config
 with EGL_SWAP_BEHAVIOR_PRESERVED, retrying without...
 09-04 17:50:46.391  4803  4829 D OpenGLRenderer: Swap behavior 0
 09-04 17:50:46.402  4803  4829 D EGL_emulation: eglCreateContext:
 0x79d89140e0: maj 2 min 0 rcv 2
 09-04 17:50:46.406  4803  4829 D EGL_emulation: eglMakeCurrent:
 0x79d89140e0: ver 2 0 (tinfo 0x79d892ae80)
 09-04 17:50:46.511  4803  4821 F libc: Fatal signal 11 (SIGSEGV), code
 2, fault addr 0x79e8078108 in tid 4821 (Gecko)
 09-04 17:50:46.519  4803  4803 D GeckoToolbar: onTabChanged: SELECTED
 09-04 17:50:46.551  4803  4803 D GeckoBrowserApp: BrowserApp.onTabChanged:
 0: SELECTED
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31624 [Core Tor/Tor]: Explain config_type_extended usage and purpose

[Tor Bug Tracker & Wiki]

#31624: Explain config_type_extended usage and purpose
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  doc internal  |  Actual Points:  0
Parent ID:  #29211| Points:  .1
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24956 [Internal Services/Tor Sysadmin Team]: put labs.tp.o on hiatus?

[Tor Bug Tracker & Wiki]

#24956: put labs.tp.o on hiatus?
-+-
 Reporter:  arma |  Owner:  anarcat
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by anarcat):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 this was removed from the torproject.org zone:

 {{{
 ; "external" services
 ; ===

 labs300 IN  A   161.47.6.182
 300 IN  2001:4801:7903:100:aff8:a2d8::ab4
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31539 [Applications/Tor Browser]: FAQ page (esp connection troubleshoooting) should be available offline in TB

[Tor Bug Tracker & Wiki]

#31539: FAQ page (esp connection troubleshoooting) should be available offline 
in
TB
--+---
 Reporter:  mrphs |  Owner:  tbb-team
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  censorship, support,  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:  Sponsor30-can
--+---

Comment (by antonela):

 Replying to [comment:5 gk]:
 > Maybe this ticket is a duplicate of #20639, too?

 Since we are using Lektor for TB Manual, all the content is available in a
 markdown format. We could find a way to render an offline Lektor and ship
 it with Tor Browser, or we might want to pick the relevant content for
 censored users to config Tor Browser successfully and render a local HTML
 page. Either of those are worth for S30.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31494 [Core Tor/Tor]: config refactoring: follow-ups from merged commits

[Tor Bug Tracker & Wiki]

#31494: config refactoring: follow-ups from merged commits
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  task | Status:  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-august  |  Actual Points:
Parent ID:  #29211   | Points:
 Reviewer:   |Sponsor:  Sponsor31-must
-+-

Comment (by nickm):

 Replying to [comment:5 teor]:
 > Move confparse.ch into lib/confmgt.

 This is now #31626.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31626 [Core Tor/Tor]: Move confparse.[ch] into lib/confmgt

[Tor Bug Tracker & Wiki]

#31626: Move confparse.[ch] into lib/confmgt
---+
 Reporter:  nickm  |  Owner:  nickm
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal |   Keywords:
Actual Points: |  Parent ID:  #29211
   Points:  0  |   Reviewer:
  Sponsor:  Sponsor31-can  |
---+
 This should now be a simple task, since confparse.[ch] no longer depends
 on anything higher-level than lib.  But it will conflict with other
 things, so we should do it at some point when there are not other pending
 commits.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30865 [Core Tor/Tor]: Move option-listing, setting, validation code out of confparse.c

[Tor Bug Tracker & Wiki]

#30865: Move option-listing, setting, validation code out of confparse.c
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  implemented
 Keywords:|  Actual Points:  0
Parent ID:  #29211| Points:  2
 Reviewer:|Sponsor:  Sponsor31-can
--+
Changes (by nickm):

 * status:  assigned => closed
 * resolution:   => implemented


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30865 [Core Tor/Tor]: Move option-listing, setting, validation code out of confparse.c

[Tor Bug Tracker & Wiki]

#30865: Move option-listing, setting, validation code out of confparse.c
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  0
Parent ID:  #29211| Points:  2
 Reviewer:|Sponsor:  Sponsor31-can
--+
Changes (by nickm):

 * actualpoints:   => 0


Comment:

 This is accomplished by other refactorings already merged.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31532 [Core Tor/Tor]: Use ptrdiff_t for struct_member_t.offset, etc

[Tor Bug Tracker & Wiki]

#31532: Use ptrdiff_t for struct_member_t.offset, etc
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Trivial  | Resolution:
 Keywords:  network-team-roadmap-august  |  Actual Points:
Parent ID:  #29211   | Points:
 Reviewer:   |Sponsor:  Sponsor31-can
-+-
Changes (by nickm):

 * status:  assigned => needs_review


Comment:

 (The original version of this branch failed to compile with clang. I
 force-pushed an updated version, which passed CI.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30967 [Core Tor/Tor]: Make shellcheck ignore user-created directories, and run it during pre-commit

[Tor Bug Tracker & Wiki]

#30967: Make shellcheck ignore user-created directories, and run it during pre-
commit
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Major| Resolution:
 Keywords:  fast-fix, teor-backlog-ci,   |  Actual Points:  0.2
  042-should, tor-ci-fail-sometimes  |
Parent ID:   | Points:  0.1
 Reviewer:  catalyst |Sponsor:
 |  Sponsor31-can
-+-
Changes (by catalyst):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:4 teor]:
 > This PR failed distcheck, I pushed a fix to the PR.
 >
 > Please check that CI passed before merging.
 Thanks! Mostly looks good. There's now a `Makefile.am` merge conflict.
 Please fix up the merge conflict and ensure that CI passes before merging.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31622 [Internal Services/Tor Sysadmin Team]: puppet: a static_mirror should not include static_mirror_source (was: puppet: webmirror should not include static_mirror_source)

[Tor Bug Tracker & Wiki]

#31622: puppet: a static_mirror should not include static_mirror_source
-+-
 Reporter:  anarcat  |  Owner:  anarcat
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28822 [Applications/Tor Browser]: re-implement desktop onboarding for ESR 68

[Tor Bug Tracker & Wiki]

#28822: re-implement desktop onboarding for ESR 68
-+-
 Reporter:  mcs  |  Owner:  tbb-team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, TorBrowserTeam201909R  |  Actual Points:
Parent ID:  #30429   | Points:  4
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-
Changes (by acat):

 * status:  needs_revision => needs_review
 * keywords:  ff68-esr, TorBrowserTeam201909 => ff68-esr,
 TorBrowserTeam201909R


Comment:

 Addressed comments in https://github.com/acatarineu/torbutton/commit/28822
 and https://github.com/acatarineu/tor-browser/commits/28822+1 (last 5
 commits).

 Replying to [comment:6 gk]:


 > Okay, I took the commits from your `30429+9` and here are my comments:
 >
 > ea5f8c2c9ccc0130944f05a6e31ebb2a9322041c - I think it's mostly good. Two
 things:
 > {{{
 > +const {Services}
 > }}}
 > I think we settled for space between name and braces in Torbutton? Would
 be good
 > here as well.

 Fixed.

 > {{{
 > +@$(MAKE) -C ../extensions/onboarding/locales chrome AB_CD=$*
 > }}}
 > It's really just one level up here, right? While all the other items are
 two
 > levels up?

 We could change it to

 {{{
 +   @$(MAKE) -C ../../browser/extensions/onboarding/locales chrome
 AB_CD=$*
 }}}
 but I think it's the same as the current one, since the file is already in
 browser `browser/locales/Makefile.in`.

 > 1c9eb3993c5b505c0894b13634b09690bfb97791 - not okay (not sure about the
 changed `onboarding-overlay-button` but we'll see I guess while testing)

 I changed the css to match the old patch, since the `onboarding-overlay-
 attention-dot` was not showing properly.

 > The images are the wrong ones. We want to have those from #30560.

 Fixed.

 > 6f05a139b387c072a63bfae3a086aee2cee95875 - okay
 > e19e128476f48278911656db735739f0526f12ce - not okay
 > {{{
 > -/* The primary button gets the same color as the customize button. */
 > }}}
 > in `browser/themes/shared/UITour.inc.css` is missing

 Fixed.



 > 742fccfcbb7a19ba9daee44335e9962639773d13 - not okay
 > {{{
 > -  OnboardingTelemetry:
 "resource://onboarding/modules/OnboardingTelemetry.jsm",
 > }}}
 > in `browser/extensions/onboarding/bootstrap.js` is missing

 Fixed.

 > aeb0b6678e61fd282825610ca29a225eb0991281 - I think this is okay, but are
 we affected by https://bugzilla.mozilla.org/show_bug.cgi?id=1498378?

 We are, nice catch. Reverted that one too.

 > Additionally, upon further testing it seems to me that the details part
 of the circuit level and the security settings is not working as expected.
 While clicking on the former opens the DDG .onion, no tour through the
 display shows up trying to make the menu behind the security settings
 button visible by clicking on the option does not do anything either.

 It seems there were several recent patches which did not like the
 onboarding. The security settings not opening is a regression due to
 #31322 and then #31251. The first one prevents UITour-lib.js from loading,
 and the second one makes `window.document.getElementById("security-level-
 button").doCommand()` not open the security level anymore (not sure why).

 The circuit path problem seems to be a regression caused by the FPI
 permissions patches. I tried reverting `Bug 1330467 - part 1. Don't strip
 first party domain from permissions key; r=johannh,Ehsan` and it works. It
 also works if you disable `firstparty.isolate`.

 The problem is that the permission check in [https://searchfox.org
 /mozilla-
 
central/rev/9bb55ae4d808fc48afcf93f99da6a685265b86c6/browser/components/uitour/UITourChild.jsm#91
 UITourChild.jsm] returns `false` after that patch is applied. I think this
 is because the `uitour` permission for the DDG onion page is not being
 loaded in the content process (where this is called). These are loaded in
 [https://searchfox.org/mozilla-
 
central/rev/9bb55ae4d808fc48afcf93f99da6a685265b86c6/dom/ipc/ContentParent.cpp#5450
 ContentParent.cpp] (for the principal). Before the FPI permission patch
 (or when disabling `firstparty.isolate`, this is called with key
 `https://3g2upl4pq6kufc4m.onion`, which loads the permission properly.
 After the patch it's called with key
 `https://3g2upl4pq6kufc4m.onion^firstPartyDomain=3g2upl4pq6kufc4m.onion`,
 which apparently does not work. This issue does not occur with `about:tor`
 `uitour` permission: this is always loaded because
 `nsPermissionManager::GetKeyForOrigin` returns empty keys for origins not
 

Re: [tor-bugs] #31529 [Core Tor/Tor]: config refactoring: fix redundant reset logic

[Tor Bug Tracker & Wiki]

#31529: config refactoring: fix redundant reset logic
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-august  |  Actual Points:  0
Parent ID:  #29211   | Points:  0
 Reviewer:   |Sponsor:  Sponsor31-can
-+-
Changes (by nickm):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31625 [Core Tor/Tor]: config refactoring: fix hierarchy of configuration variable flags

[Tor Bug Tracker & Wiki]

#31625: config refactoring: fix hierarchy of configuration variable flags
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-august  |  Actual Points:
Parent ID:  #29211   | Points:  .5
 Reviewer:  teor |Sponsor:
-+-

Comment (by nickm):

 (I've set this to needs_review : there is no code yet, but I'd like your
 opinion on the set of options I listed above before I go ahead.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31625 [Core Tor/Tor]: config refactoring: fix hierarchy of configuration variable flags

[Tor Bug Tracker & Wiki]

#31625: config refactoring: fix hierarchy of configuration variable flags
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-august  |  Actual Points:
Parent ID:  #29211   | Points:  .5
 Reviewer:  teor |Sponsor:
-+-
Changes (by nickm):

 * status:  assigned => needs_review
 * reviewer:   => teor


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31625 [Core Tor/Tor]: config refactoring: fix hierarchy of configuration variable flags

[Tor Bug Tracker & Wiki]

#31625: config refactoring: fix hierarchy of configuration variable flags
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-august  |  Actual Points:
Parent ID:  #29211   | Points:  .5
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 Here's a proposed design -- what do you think?

 == The current situation ==

 Currently we have two kinds of flags:
* flags for types
* flags for variables.

 If a flag is set on a type, it applies to every variable of that type.
 If a flag is set on a variable, it applies only to that variable.


 The type flags are:

unsettable -- cannot be set directly by name. (LINELIST_V, OBSOLETE)

contained -- addresses part of another type. (LINELIST_S, OBSOLETE)

cumulative -- setting a variable of this type does not override older
   values set to this type. (all LINELIST, LINELIST_V, LINELIST_S)

 The variable flags are:

invisible -- does not show up on lists of variables, does not get
 written to disk, and is not visible to the controller.

obsolete -- produce a warning on any attempt to set or fetch the
 option. Do not list it as a valid option.

nodump -- do not write to disk.  These are mostly testing options.

 == The refactoring ==

 The new orthogonal low-level options are:

   * NOSET -- cannot be set by name.

   * NOLIST -- does not appear in lists of options.

   * NODUMP -- do not dump this option to disk from config_dump() -- either
 because it is a testing option, or because it is contained in another
 option.

   * NOCOPY -- do not try to copy this option in config_dup, because it is
 contained in another option, or has no storage.

   * NOGET -- cannot be fetched by the controller.

   * CUMULATIVE -- remains unchanged.  We might call it NOREPLACE or
 NOOVERWRITE if that's clearer?

 With this set of options:

   "cumulative" remains CUMULATIVE.

   "nodump" remains "NODUMP".

   "unsettable" becomes NOSET.

   "contained" becomes NODUMP + NOCOPY

   "invisible" becomes NOGET + NOSET + NODUMP + NOLIST

   "obsolete" becomes NOGET + NOSET + NODUMP + NOCOPY + NOLIST.

 == How flags are set ==

 Flags can be set either on a type or on a variable.  Variable flags are
 or'd with the flags of their type before checking them.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31457 [Applications/Tor Browser]: disable per-installation profiles

[Tor Bug Tracker & Wiki]

#31457: disable per-installation profiles
-+-
 Reporter:  mcs  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201909R  |
Parent ID:   | Points:  0.25
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-

Comment (by cypherpunks):

 Hah, good protection, added in: https://hg.mozilla.org/mozilla-
 central/rev/d4dc16a12cb1

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31624 [Core Tor/Tor]: Explain config_type_extended usage and purpose

[Tor Bug Tracker & Wiki]

#31624: Explain config_type_extended usage and purpose
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  doc internal  |  Actual Points:  0
Parent ID:  #29211| Points:  .1
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * actualpoints:   => 0


Comment:

 Branch is `ticket31624`; PR at
 https://github.com/nmathewson/tor/pull/new/ticket31624 .

 I did not add a changes file, since this is a comment-only change.

 I will put this needs_review once CI passes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs