Re: [tor-bugs] #33192 [Core Tor/Tor]: Stop assuming that /usr/bin/python exists

[Tor Bug Tracker & Wiki]

#33192: Stop assuming that /usr/bin/python exists
--+
 Reporter:  alwayslivid   |  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  extra-review  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by alwayslivid):

 I checked some of the scripts and changed "python" to "python2" wherever
 the syntax wouldn't allow using Python 3. I also imported print_function
 from __future__ in some cases.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33192 [Core Tor/Tor]: Stop assuming that /usr/bin/python exists

[Tor Bug Tracker & Wiki]

#33192: Stop assuming that /usr/bin/python exists
--+
 Reporter:  alwayslivid   |  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  extra-review  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by alwayslivid):

 I probably misinterpreted something in the documentation, excuse me for
 that one.

 I could close the pull request and make the change again on top of the
 master or another desired branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33187 [Webpages/Website]: Please add job description to website

[Tor Bug Tracker & Wiki]

#33187: Please add job description to website
--+--
 Reporter:  ewyatt|  Owner:  hiro
 Type:  task  | Status:  new
 Priority:  Very High |  Milestone:
Component:  Webpages/Website  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by teor):

 Hi Erin, it looks like there's a small typo in the introduction:

 "This position is full-time and remote; someone in the Eastern time zone
 strongly preferred. This position will be performed remotely, preferably
 by someone in the Eastern time zone."

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33192 [Core Tor/Tor]: Stop assuming that /usr/bin/python exists

[Tor Bug Tracker & Wiki]

#33192: Stop assuming that /usr/bin/python exists
--+
 Reporter:  alwayslivid   |  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  extra-review  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by teor):

 Also, when we merge, we should cherry-pick this change, because merging
 from a user branch called "maint-0.4.2" will confuse developers.

 Usually, we name branches after the ticket number, or after the feature or
 bug they fix.

 Our maint-0.4.2 branch is for maintenance changes only, and I don't think
 this change qualifies. It's too risky.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33192 [Core Tor/Tor]: Stop assuming that /usr/bin/python exists

[Tor Bug Tracker & Wiki]

#33192: Stop assuming that /usr/bin/python exists
--+
 Reporter:  alwayslivid   |  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  extra-review  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * cc: nickm (added)
 * keywords:   => extra-review
 * version:  Tor: 0.4.2.5 =>
 * status:  new => needs_review
 * milestone:   => Tor: 0.4.3.x-final


Comment:

 Looks good to me, but I think the bugfix version in the changes file
 should be much earlier.

 We use the earliest version that the bug was introduced in, so you want
 the first commit that used the path "/usr/bin/python". Here are some
 instructions for finding it:
 https://gitweb.torproject.org/tor.git/tree/doc/HACKING/CodingStandards.md#n121

 I'd also like to check with Nick (another maintainer), to see if this
 change go in 0.4.3, or 0.4.4,

 Here are the tradeoffs:
   * It's a long-standing bug on BSD, so it's not urgent
   * We still haven't checked if all of our scripts work on python 3 (see
 #33196), and this change could make more scripts use python 3 on more
 machines

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33196 [Core Tor/Tor]: Make flake8 test Python 3 syntax

[Tor Bug Tracker & Wiki]

#33196: Make flake8 test Python 3 syntax
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #33193| Points:  1
 Reviewer:|Sponsor:
--+

Comment (by teor):

 Nick, I'm not sure if this ticket should go in 0.4.3 or 0.4.4.

 It would be nice to check our python 3 syntax in 0.4.3.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33196 [Core Tor/Tor]: Make flake8 test Python 3 syntax

[Tor Bug Tracker & Wiki]

#33196: Make flake8 test Python 3 syntax
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:  #33193
   Points:  1 |   Reviewer:
  Sponsor:|
--+
 Follow up to #33193.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33195 [Core Tor/Tor]: Require IPv6 tests in Travis CI

[Tor Bug Tracker & Wiki]

#33195: Require IPv6 tests in Travis CI
+
 Reporter:  teor|  Owner:  teor
 Type:  task| Status:  assigned
 Priority:  Medium  |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  |   Keywords:  tor-ci, chutney
Actual Points:  |  Parent ID:  #33194
   Points:  0.1 |   Reviewer:
  Sponsor:  Sponsor55-must  |
+
 While we're actively changing our IPv6 code, we should make sure that the
 macOS chutney IPv6 tests pass in Travis CI.

 While I'm doing this change, I will see if there are:
 * some redundant jobs I can delete, or
 * some inactive areas that I can make fast_finish.

 I think our Rust build might be a good candidate for fast_finish, we
 haven't changed that code much in about a year. But I should check with
 the team before making this change.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33194 [Core Tor/Tor]: Sort Travis jobs in speed order

[Tor Bug Tracker & Wiki]

#33194: Sort Travis jobs in speed order
+
 Reporter:  teor|  Owner:  teor
 Type:  task| Status:  assigned
 Priority:  Medium  |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  |   Keywords:  tor-ci, chutney
Actual Points:  |  Parent ID:  #33193
   Points:  0.1 |   Reviewer:
  Sponsor:  Sponsor55-must  |
+
 We try to put the slowest Travis jobs first, so CI finishes as early as
 possible.

 But we put the optional macOS chutney / IPv6 job last, because it's very
 very slow, so we don't wait for it to finish.

 This ticket is required for Sponsor 55, because we need to do it to make
 IPv6 tests mandatory.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33193 [Core Tor/Tor]: Travis CI: Use flake8 to find Python syntax errors

[Tor Bug Tracker & Wiki]

#33193: Travis CI: Use flake8 to find Python syntax errors
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  extra-review  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * status:  new => needs_revision


Comment:

 I'm still working on revisions with the author of the PR.

 But I have a question for Nick:
 Does this change belong in 0.4.3 or 0.4.4?

 I think catching python syntax errors is a good idea.

 And this change could enforce python 3 compatibility in all our scripts,
 if we change the python version to a recent python 3. (But I think we
 should do that in a separate ticket, in case there are any errors we need
 to fix.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33193 [Core Tor/Tor]: Travis CI: Use flake8 to find Python syntax errors

[Tor Bug Tracker & Wiki]

#33193: Travis CI: Use flake8 to find Python syntax errors
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  extra-review
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 Here's a PR from a new contributor:
 https://github.com/torproject/tor/pull/1686

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27194 [Core Tor/Tor]: Reject protover extra commas in protover

[Tor Bug Tracker & Wiki]

#27194: Reject protover extra commas in protover
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.4-alpha
 Severity:  Normal   | Resolution:
 Keywords:  needs-consensus-method, rust,|  Actual Points:  0.2
  security-low, 035-backport, 040-backport,  |
  041-backport, 032-unreached-backport,  |
  035-deferred-20190115, 041-proposed, 033   |
  -unreached-backport|
Parent ID:   | Points:  0.2
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by cypherpunks):

 Replying to [comment:22 teor]:
 > 2. in networkstatus_parse_vote_from_string(), reject votes that have
 malformed:
 >   * recommended/required_client/server_protocols
 >   * relay protocol lines, as parsed by
 routerstatus_parse_entry_from_string()

 Apologies for the delay.
 https://gitgud.io/onionk/tor/compare/master...protocommas2

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33141 [Internal Services/Tor Sysadmin Team]: migrate sysadmin roadmap in trac wiki

[Tor Bug Tracker & Wiki]

#33141: migrate sysadmin roadmap in trac wiki
-+-
 Reporter:  anarcat  |  Owner:  anarcat
 Type:  task | Status:  closed
 Priority:  High |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Minor| Resolution:  fixed
 Keywords:  tpa-roadmap-february |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by anarcat):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 interesting - i notice that the other teams don't use per-month
 milestones, is that something new we're trying with tpa?

 anyawys, i've moved everything to the trac wiki, see if it looks alright
 to you.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33141 [Internal Services/Tor Sysadmin Team]: migrate sysadmin roadmap in trac wiki

[Tor Bug Tracker & Wiki]

#33141: migrate sysadmin roadmap in trac wiki
-+-
 Reporter:  anarcat  |  Owner:  anarcat
 Type:  task | Status:
 |  assigned
 Priority:  High |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Minor| Resolution:
 Keywords:  tpa-roadmap-february |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gaba):

 Right. That would makes sense too.

 For other teams I'm trying to add roadmap to its wiki page:

 anti-censorship by component with its goals with a section for the active
 sponsors :
 https://trac.torproject.org/projects/tor/wiki/org/teams/AntiCensorshipTeam

 network team by active sponsors/projects:
 https://trac.torproject.org/projects/tor/wiki/org/teams/NetworkTeam

 metrics team with its priorities:
 https://trac.torproject.org/projects/tor/wiki/org/teams/MetricsTeam

 network health team with the priorities and tickets by owner
 https://trac.torproject.org/projects/tor/wiki/org/teams/NetworkHealthTeam

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33138 [Internal Services/Services Admin Team]: New RT queue and alias iff@tpo

[Tor Bug Tracker & Wiki]

#33138: New RT queue and alias iff@tpo
---+--
 Reporter:  ggus   |  Owner:  ggus
 Type:  defect | Status:  new
 Priority:  High   |  Milestone:
Component:  Internal Services/Services Admin Team  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by ggus):

 Anarcat, I'm not an RT admin. If you give me permission, I can create the
 Queue.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33138 [Internal Services/Services Admin Team]: New RT queue and alias iff@tpo

[Tor Bug Tracker & Wiki]

#33138: New RT queue and alias iff@tpo
---+--
 Reporter:  ggus   |  Owner:  ggus
 Type:  defect | Status:  new
 Priority:  High   |  Milestone:
Component:  Internal Services/Services Admin Team  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by anarcat):

 i think pili can give you those perms, that would be a good exercise as
 well. :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33157 [Circumvention/Snowflake]: Client generates SDP with "IN IP4 0.0.0.0", causing proxy to send "client_ip=0.0.0.0" and bridge to send "USERADDR 0.0.0.0:1"

[Tor Bug Tracker & Wiki]

#33157: Client generates SDP with "IN IP4 0.0.0.0", causing proxy to send
"client_ip=0.0.0.0" and bridge to send "USERADDR 0.0.0.0:1"
-+
 Reporter:  dcf  |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by arlolra):

 > I found it while testing proxy-go with a localhost client and a patch
 like:

 Something like that patch was useful when working on #19026 so would you
 consider merging,
 
https://github.com/keroserene/snowflake/commit/dbd733e4b1430c046ec11e8052efdbac6010e58a

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19026 [Circumvention/Snowflake]: Remove local LAN address ICE candidates

[Tor Bug Tracker & Wiki]

#19026: Remove local LAN address ICE candidates
-+--
 Reporter:  dcf  |  Owner:  arlolra
 Type:  enhancement  | Status:  assigned
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  cohosh   |Sponsor:
-+--
Changes (by arlolra):

 * status:  needs_review => assigned


Comment:

 Ok, merged starting at,
 https://gitweb.torproject.org/pluggable-
 transports/snowflake.git/commit/?id=0fae4ee8ea487c3b4384217e193e5b9a9088e7de

 What's left to do is a follow up for the proxies, as suggested in
 comment:10

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33141 [Internal Services/Tor Sysadmin Team]: migrate sysadmin roadmap in trac wiki

[Tor Bug Tracker & Wiki]

#33141: migrate sysadmin roadmap in trac wiki
-+-
 Reporter:  anarcat  |  Owner:  anarcat
 Type:  task | Status:
 |  assigned
 Priority:  High |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Minor| Resolution:
 Keywords:  tpa-roadmap-february |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by anarcat):

 i was thinking of just moving the entire roadmap in the trac wiki page,
 actually, instead of having it in two places.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33141 [Internal Services/Tor Sysadmin Team]: migrate sysadmin roadmap in trac wiki

[Tor Bug Tracker & Wiki]

#33141: migrate sysadmin roadmap in trac wiki
-+-
 Reporter:  anarcat  |  Owner:  anarcat
 Type:  task | Status:
 |  assigned
 Priority:  High |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Minor| Resolution:
 Keywords:  tpa-roadmap-february |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gaba):

 The pads are always temporary (I have been trying to add the word temporal
 to the name of the pad to remind people of that).

 Agree that we should have the roadmap for next couple of months here:

 https://trac.torproject.org/projects/tor/wiki/org/teams/SysadminTeam

 and keep the free form text for the year at

 help.torproject.org/tsa/roadmap/2020/

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33162 [Community]: Create a "torproject" Docker organisation

[Tor Bug Tracker & Wiki]

#33162: Create a "torproject" Docker organisation
---+--
 Reporter:  phw|  Owner:  phw
 Type:  task   | Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Community  |Version:
 Severity:  Normal | Resolution:
 Keywords:  docker, trademark  |  Actual Points:
Parent ID: | Points:  0.5
 Reviewer: |Sponsor:
---+--

Comment (by gaba):

 For github we also have "thetorproject" . It would be great to be
 consistent.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs