Re: [tor-bugs] #31422 [Circumvention/BridgeDB]: Make BridgeDB report internal metrics

2020-06-04 Thread Tor Bug Tracker & Wiki
#31422: Make BridgeDB report internal metrics
-+-
 Reporter:  phw  |  Owner:  phw
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Circumvention/BridgeDB   |Version:
 Severity:  Normal   | Resolution:
 Keywords:  s30-o21a1, anti-censorship-  |  Actual Points:
  roadmap-2020   |
Parent ID:  #31274   | Points:  2
 Reviewer:  agix |Sponsor:
 |  Sponsor30-can
-+-

Comment (by arma):

 Nice! In general for these metrics situations, my advice is to try to
 frame it in terms of questions you want to learn the answers to, rather
 than data sources you could track.

 So for example, less "how many bridges have property X" and more "how many
 of the people trying to get a bridge with property X are getting a working
 one?"

 Or said another way, if we just track data sources, then it's likely to
 remain unclear how to actually assess whether we're succeeding.

 Backing up even farther: it would be great to pick some (quantifiable)
 goals and then set about figuring out what we need to measure to know how
 we're doing at achieving them.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #19774 [Circumvention/BridgeDB]: bridges.torproject.org could use a favicon

2020-06-04 Thread Tor Bug Tracker & Wiki
#19774: bridges.torproject.org could use a favicon
--+
 Reporter:  isis  |  Owner:  phw
 Type:  enhancement   | Status:  closed
 Priority:  Very Low  |  Milestone:
Component:  Circumvention/BridgeDB|Version:
 Severity:  Minor | Resolution:  implemented
 Keywords:  ux-team, easy, s30-o22a2  |  Actual Points:  0.2
Parent ID:  #31279| Points:  1
 Reviewer:  cohosh|Sponsor:  Sponsor30-must
--+
Changes (by phw):

 * status:  merge_ready => closed
 * resolution:   => implemented
 * actualpoints:   => 0.2


Comment:

 Merged into develop in commit
 
[https://gitweb.torproject.org/bridgedb.git/commit/?h=develop=6d3e899925854b0994d66551fef25678e6f36561
 6d3e899].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #27984 [Circumvention/BridgeDB]: bridgedb verifyHostname doesn't check subjectAltName extension

2020-06-04 Thread Tor Bug Tracker & Wiki
#27984: bridgedb verifyHostname doesn't check subjectAltName extension
-+
 Reporter:  kaie |  Owner:  agix
 Type:  defect   | Status:  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Circumvention/BridgeDB   |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ex-sponsor-19, ex-sponsor19  |  Actual Points:
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
-+
Changes (by phw):

 * status:  needs_review => needs_revision


Comment:

 I like your second approach, great work! I left a few minor comments in
 the commit. Do you mind addressing them?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34350 [Applications/GetTor]: Stop logging all successful databse queries in GetTor

2020-06-04 Thread Tor Bug Tracker & Wiki
#34350: Stop logging all successful databse queries in GetTor
-+-
 Reporter:  cohosh   |  Owner:  cohosh
 Type:  defect   | Status:  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  phw  |Sponsor:
-+-
Changes (by phw):

 * status:  needs_review => merge_ready


Comment:

 LGTM!

 (For what it's worth, I think it's fine to skip our review process for
 microscopic fixes like these.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #19774 [Circumvention/BridgeDB]: bridges.torproject.org could use a favicon

2020-06-04 Thread Tor Bug Tracker & Wiki
#19774: bridges.torproject.org could use a favicon
--+
 Reporter:  isis  |  Owner:  phw
 Type:  enhancement   | Status:  merge_ready
 Priority:  Very Low  |  Milestone:
Component:  Circumvention/BridgeDB|Version:
 Severity:  Minor | Resolution:
 Keywords:  ux-team, easy, s30-o22a2  |  Actual Points:
Parent ID:  #31279| Points:  1
 Reviewer:  cohosh|Sponsor:  Sponsor30-must
--+
Changes (by cohosh):

 * status:  needs_review => merge_ready


Comment:

 Looks good!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #29502 [Webpages/Support]: Glossary on the support portal should be moved to the main menu

2020-06-04 Thread Tor Bug Tracker & Wiki
#29502: Glossary on the support portal should be moved to the main menu
--+
 Reporter:  emmapeel  |  Owner:  hiro
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Webpages/Support  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  glossary  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by ggus):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 This was done by Hiro.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #31069 [Webpages/Support]: Create onion auth entries in portals

2020-06-04 Thread Tor Bug Tracker & Wiki
#31069: Create onion auth entries in portals
--+---
 Reporter:  antonela  |  Owner:  ggus
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Webpages/Support  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:  antonela, stephw  |Sponsor:  Sponsor27
--+---
Changes (by ggus):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 I reviewed Cleo's work and published.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33454 [Community/Tor Browser Manual]: Update Tor Browser Manual Onion Services Section with HSv3 Client Authorization

2020-06-04 Thread Tor Bug Tracker & Wiki
#33454: Update Tor Browser Manual Onion Services Section with HSv3 Client
Authorization
--+
 Reporter:  pili  |  Owner:  ggus
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Community/Tor Browser Manual  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:|  Actual Points:
Parent ID:  #31069| Points:
 Reviewer:|Sponsor:
--+
Changes (by ggus):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Done!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33456 [Webpages/Support]: Update Support Portal Onion Services section to include a question on HSv3 client authorization

2020-06-04 Thread Tor Bug Tracker & Wiki
#33456: Update Support Portal Onion Services section to include a question on 
HSv3
client authorization
--+
 Reporter:  pili  |  Owner:  hiro
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Webpages/Support  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:|  Actual Points:
Parent ID:  #31069| Points:
 Reviewer:|Sponsor:
--+
Changes (by ggus):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Done!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34265 [Circumvention/Snowflake]: Library selection for WebSocket communication with Tor relay.

2020-06-04 Thread Tor Bug Tracker & Wiki
#34265: Library selection for WebSocket communication with Tor relay.
-+
 Reporter:  HashikD  |  Owner:  (none)
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake-mobile |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by cohosh):

 * status:  needs_information => new


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34265 [Circumvention/Snowflake]: Library selection for WebSocket communication with Tor relay.

2020-06-04 Thread Tor Bug Tracker & Wiki
#34265: Library selection for WebSocket communication with Tor relay.
-+---
 Reporter:  HashikD  |  Owner:  (none)
 Type:  task | Status:  needs_information
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake-mobile |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+---

Comment (by cohosh):

 Replying to [ticket:34265 HashikD]:
 > For WebSocket libraries here are some mentions: \\
 > https://github.com/Tinder/Scarlet - Designed for Android, hence
 preferred.\\
 > https://github.com/TooTallNate/Java-WebSocket - Popular Java lib.\\
 No strong opinions here, just a first impression that `TooTallNate/Java-
 WebSocket` looks more actively maintained to me. I'd go with that and we
 can always update later as you said :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33835 [Circumvention/BridgeDB]: Gmail's quoted response confuses BridgeDB's email autoresponder

2020-06-04 Thread Tor Bug Tracker & Wiki
#33835: Gmail's quoted response confuses BridgeDB's email autoresponder
+---
 Reporter:  phw |  Owner:  agix
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o22a2   |  Actual Points:
Parent ID:  #31279  | Points:  1
 Reviewer:  |Sponsor:  Sponsor30-can
+---

Comment (by phw):

 Hmm. I think the right way forward is to discard message parts whose
 content type is not text/plain. In both my and agix's example, the
 text/html part shouldn't reach the parser and the text/plain part should
 be fine.

 We won't be able to support every single email client but at the very
 least, we should be able to support emails from Gmail's and Riseup's web
 interface.

 What do you think?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34375 [Core Tor/Tor]: Remove 0.4.1 from git-list-tor-branches.sh

2020-06-04 Thread Tor Bug Tracker & Wiki
#34375: Remove 0.4.1 from git-list-tor-branches.sh
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  044-should|  Actual Points:
Parent ID:| Points:  0
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * keywords:   => 044-should


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #28280 [Core Tor/Tor]: control: Add a key to GETINFO to get the DoS subsystem stats

2020-06-04 Thread Tor Bug Tracker & Wiki
#28280: control: Add a key to GETINFO to get the DoS subsystem stats
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Low  |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-control, tor-spec, needs-spec,   |  Actual Points:  0.1
  043-deferred 044-can   |
Parent ID:   | Points:
 Reviewer:  teor, dgoulet|Sponsor:
-+-
Changes (by nickm):

 * keywords:  tor-control, tor-spec, needs-spec, 043-deferred => tor-
 control, tor-spec, needs-spec, 043-deferred 044-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34382 [Core Tor/Tor]: Don't require M_SYSCALL in sandbox.c

2020-06-04 Thread Tor Bug Tracker & Wiki
#34382: Don't require M_SYSCALL in sandbox.c
---+
 Reporter:  nickm  |  Owner:  nickm
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  easy fast-fix 044-can  |  Actual Points:  0
Parent ID: | Points:  0.1
 Reviewer: |Sponsor:
---+
Changes (by nickm):

 * keywords:  easy fast-fix => easy fast-fix 044-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34278 [Circumvention/Snowflake]: Handling connection failures.

2020-06-04 Thread Tor Bug Tracker & Wiki
#34278: Handling connection failures.
-+
 Reporter:  HashikD  |  Owner:  (none)
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake-mobile |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by cohosh):

 * status:  needs_information => new


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34278 [Circumvention/Snowflake]: Handling connection failures.

2020-06-04 Thread Tor Bug Tracker & Wiki
#34278: Handling connection failures.
-+---
 Reporter:  HashikD  |  Owner:  (none)
 Type:  task | Status:  needs_information
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake-mobile |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+---

Comment (by cohosh):

 This is a really good question, and one that we've worked on with the
 other proxy implementations.

 There are a few things we can look for to close a connection. In the
 Google API, there should be an `OnClose` event: https://webrtc.org
 /getting-started/data-channels#open_and_close_events
 that we can add a listener to. You can see that in our Javascript proxy
 code [https://gitweb.torproject.org/pluggable-transports/snowflake-
 webext.git/tree/proxypair.js#n91 here].

 We also want to close if there is an error (see
 [https://gitweb.torproject.org/pluggable-transports/snowflake-
 webext.git/tree/proxypair.js#n175 here]).

 We also added a timeout as an extra check. We can do this because the
 underlying layer is sending keep-alive messages every 10 seconds. You can
 see that in the existing code [https://gitweb.torproject.org/pluggable-
 transports/snowflake-webext.git/tree/proxypair.js#n160 here].

 We also want to close the connection if it is closed or we receive an
 error from the WebSocket side. See [https://gitweb.torproject.org
 /pluggable-transports/snowflake-webext.git/tree/proxypair.js#n131 here].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33686 [Core Tor/Tor]: Tor 0.4.2.7 wont get past bootstrap phase with Sandbox 1 enabled

2020-06-04 Thread Tor Bug Tracker & Wiki
#33686: Tor 0.4.2.7 wont get past bootstrap phase with Sandbox 1 enabled
-+-
 Reporter:  cypherpunks  |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.2.7
 Severity:  Normal   | Resolution:  user
 Keywords:  tor-sandbox, 035-backport,   |  disappeared
  041-backport, 042-backport, 043-backport   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  new => closed
 * resolution:   => user disappeared


Comment:

 no response in 2 months; closing :(

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33503 [Core Tor/Tor]: LeakSanitizer detected memory leak with Tor 0.4.4.0-alpha-dev (git-6472d9cfdf1198cf)

2020-06-04 Thread Tor Bug Tracker & Wiki
#33503: LeakSanitizer detected memory leak with Tor 0.4.4.0-alpha-dev (git-
6472d9cfdf1198cf)
-+-
 Reporter:  gk   |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  regresssion memleak tor-hs   |  Actual Points:
  044-should |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  regresssion memleak tor-hs => regresssion memleak tor-hs
 044-should


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33527 [Core Tor/Tor]: Write walking onions specification

2020-06-04 Thread Tor Bug Tracker & Wiki
#33527: Write walking onions specification
-+-
 Reporter:  gaba |  Owner:  nickm
 Type:  project  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  walking-onions network-team- |  implemented
  roadmap-2020Q2 |  Actual Points:
Parent ID:   | Points:  16
 Reviewer:   |Sponsor:
 |  Sponsor69
-+-
Changes (by nickm):

 * status:  accepted => closed
 * resolution:   => implemented


Comment:

 This is done as proposal 313.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33527 [Core Tor/Tor]: Write walking onions specification

2020-06-04 Thread Tor Bug Tracker & Wiki
#33527: Write walking onions specification
-+-
 Reporter:  gaba |  Owner:  nickm
 Type:  project  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  walking-onions network-team- |  implemented
  roadmap-2020Q2 |  Actual Points:  20
Parent ID:   | Points:  16
 Reviewer:   |Sponsor:
 |  Sponsor69
-+-
Changes (by nickm):

 * actualpoints:   => 20


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33346 [Core Tor/Tor]: Seccomp soft fail (no write) in 0.4.2.6

2020-06-04 Thread Tor Bug Tracker & Wiki
#33346: Seccomp soft fail (no write) in 0.4.2.6
-+-
 Reporter:  subjectfrosting  |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:  0.4.2.6
 Severity:  Normal   | Resolution:
 Keywords:  easy?, 035-backport, 041-backport,   |  Actual Points:  .1
  042-backport, 043-backport, regression |
  044-should |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:
 easy?, 035-backport, 041-backport, 042-backport, 043-backport,
 regression
 =>
 easy?, 035-backport, 041-backport, 042-backport, 043-backport,
 regression 044-should


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33118 [Core Tor/Tor]: Investigate clusterfuzz timeouts

2020-06-04 Thread Tor Bug Tracker & Wiki
#33118: Investigate clusterfuzz timeouts
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  clusterfuzz   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 This was done succesfully, and turned up TROVE-2020-002

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #32815 [Core Tor/Tor]: Move all directory authority options into the dirauth man page section

2020-06-04 Thread Tor Bug Tracker & Wiki
#32815: Move all directory authority options into the dirauth man page section
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  doc, tor-design, 044-can  |  Actual Points:
Parent ID:  #32139| Points:  0.2
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * keywords:  doc, tor-design, 043-can => doc, tor-design, 044-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #32661 [Core Tor/Tor]: Document that we avoid changing src/ext

2020-06-04 Thread Tor Bug Tracker & Wiki
#32661: Document that we avoid changing src/ext
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  easy, doc, fast-fix, teor-backlog|  Actual Points:
  044-can|
Parent ID:   | Points:  0.2
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  easy, doc, fast-fix, teor-backlog 043-can => easy, doc, fast-
 fix, teor-backlog 044-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #32816 [Core Tor/Tor]: Move the relay options into the correct man page sections

2020-06-04 Thread Tor Bug Tracker & Wiki
#32816: Move the relay options into the correct man page sections
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  doc, tor-design, 044-can  |  Actual Points:
Parent ID:  #32395| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * keywords:  doc, tor-design, 043-can => doc, tor-design, 044-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #32830 [Core Tor]: Relay_extended - hash and padding - specs are wrong or unclear

2020-06-04 Thread Tor Bug Tracker & Wiki
#32830: Relay_extended - hash and padding - specs are wrong or unclear
--+
 Reporter:  Aymeric   |  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  044-can   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * keywords:  043-can => 044-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #32306 [Core Tor/Tor]: check-local target to enforce doxygen-correctness

2020-06-04 Thread Tor Bug Tracker & Wiki
#32306: check-local target to enforce doxygen-correctness
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  s31-docs 044-can  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * keywords:  s31-docs, 043-can => s31-docs 044-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #32088 [Core Tor/Tor]: Proposal 310 - choose guards in sampled order

2020-06-04 Thread Tor Bug Tracker & Wiki
#32088: Proposal 310 - choose guards in sampled order
-+-
 Reporter:  Jaym |  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-spec prop271 prop310 044-should  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  nickm, asn   |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 Oh!  It sounds like this is ready for a fresh review then.  I'll put it
 back in needs_review.

 (Yeah, I agree about testing.  It's gotten to the point where when I write
 a test that passes the first time, I am suspicious that it isn't really
 testing the code.)

 As for the tests, it looks like you're getting this compilation error:
 {{{
 x86_64-w64-mingw32-gcc -DHAVE_CONFIG_H -I. -I..
 -DSHARE_DATADIR="\"/mingw64/share\"" -DLOCALSTATEDIR="\"/mingw64/var\""
 -DBINDIR="\"/mingw64/bin\"" -DTOR_UNIT_TESTS -I../src -I../src/ext
 -I../src/ext/trunnel -I../src/trunnel -I../src/ext -Isrc/ext
 -DSHARE_DATADIR="\"/mingw64/share\"" -DLOCALSTATEDIR="\"/mingw64/var\""
 -DBINDIR="\"/mingw64/bin\"" -DTOR_UNIT_TESTS  -DHAVE_MODULE_RELAY=1
 -DHAVE_MODULE_DIRAUTH=1 -DHAVE_MODULE_DIRCACHE=1 -I/mingw64/include
 -IC:/msys64/mingw64/include -L/mingw64/include  -g -O2 -fasynchronous-
 unwind-tables -Wall -fno-strict-aliasing -Werror  -Waddress -Warray-bounds
 -Wdate-time -Wdouble-promotion -Wduplicate-decl-specifier -Wduplicated-
 cond -Wenum-conversion -Wextra -Wfloat-conversion -Wignored-attributes
 -Wimplicit-fallthrough -Winit-self -Wlogical-op -Wmissing-field-
 initializers -Wmissing-format-attribute -Wmissing-noreturn
 -Wnormalized=nfkc -Wnull-dereference -Woverlength-strings -Woverride-init
 -Wshadow -Wshift-count-negative -Wshift-count-overflow -Wshift-negative-
 value -Wshift-overflow=2 -Wsizeof-array-argument -Wstrict-overflow=1
 -Wstring-compare -Wsuggest-attribute=format -Wsuggest-attribute=noreturn
 -Wswitch-bool -Wsync-nand -Wtrampolines -Wunused-but-set-parameter
 -Wunused-but-set-variable -Wunused-const-variable=2 -Wunused-local-
 typedefs -Wvariadic-macros  -W -Wfloat-equal -Wundef -Wpointer-arith
 -Wstrict-prototypes -Wmissing-prototypes -Wwrite-strings -Wredundant-decls
 -Wchar-subscripts -Wcomment -Wformat=2 -Wwrite-strings -Wnested-externs
 -Wbad-function-cast -Wswitch-enum -Waggregate-return -Wpacked -Wunused
 -Wunused-parameter  -Wold-style-definition -Wmissing-declarations -MT
 src/test/test-test_geoip.o -MD -MP -MF src/test/.deps/test-test_geoip.Tpo
 -c -o src/test/test-test_geoip.o `test -f 'src/test/test_geoip.c' || echo
 '../'`src/test/test_geoip.c
 bash.exe : In file included from ../src/lib/container/smartlist.h:18,
 At line:2 char:5
 + & $commandPath $args 2>&1
 + ~
 + CategoryInfo  : NotSpecified: (In file
 include...smartlist.h:18,:String) [], RemoteException
 + FullyQualifiedErrorId : NativeCommandError

  from ../src/core/or/or.h:29,
  from ../src/test/test_entrynodes.c:14:
 ../src/test/test_entrynodes.c: In function
 'test_entry_guard_correct_cascading_order':
 ../src/lib/smartlist_core/smartlist_core.h:40:55: error:
 'old_primary_guards' may be used uninitialized in this function [-Werror
 =maybe-uninitialized]
40 | #define smartlist_free(sl) FREE_AND_NULL(smartlist_t,
 smartlist_free_, (sl))
   |
 ^~~
 ../src/test/test_entrynodes.c:1825:16: note: 'old_primary_guards' was
 declared here
  1825 |   smartlist_t *old_primary_guards = smartlist_new();
   |^~
 mv -f src/test/.deps/test-test_geoip.Tpo src/test/.deps/test-test_geoip.Po
 }}}

 The issue here is that all of the `tt_...()` macros will run `goto done;`
 on failure.  The `done` block of
 `test_entry_guard_correct_cascading_order` is calling
 `smartlist_free(old_primary_guards)`... but that variable isn't actually
 declared until half-way through the function.  You can fix this error by
 declaring it earlier.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #32314 [Core Tor/Tor]: Can't connect to literal IPv6 address containing double colon

2020-06-04 Thread Tor Bug Tracker & Wiki
#32314: Can't connect to literal IPv6 address containing double colon
-+-
 Reporter:  liberat  |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.6
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, tor-exit, ipv6,  |  Actual Points:  0.1
  BugSmashFund, 042-backport, 043-should,|
  044-can|
Parent ID:  #26664   | Points:  0.5
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  tor-client, tor-exit, ipv6, BugSmashFund, 042-backport,
 043-should =>
 tor-client, tor-exit, ipv6, BugSmashFund, 042-backport, 043-should,
 044-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #32088 [Core Tor/Tor]: Proposal 310 - choose guards in sampled order

2020-06-04 Thread Tor Bug Tracker & Wiki
#32088: Proposal 310 - choose guards in sampled order
-+-
 Reporter:  Jaym |  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-spec prop271 prop310 044-should  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  nickm, asn   |Sponsor:
-+-

Comment (by Jaym):

 Replying to [comment:28 nickm]:
 > Hi, how is this going?  I'd love to take a version of this in 0.4.4 if
 we can, to improve our security, but it might make more sense to take it
 early in 0.4.5 if it's not going to be done by the deadline (Jun 15).

 I'd love to see it in 0.4.4. I've made the requested unit test last Sunday
 and replied to asn's comment on the github pull request
 (https://github.com/torproject/tor/pull/1873). Btw asn, that was a good
 call, I caught a corner case issue.

 So currently, I am missing a patch in guard-spec.txt and I can workout the
 commit structure as soon as the code is flagged ok. I am sure all of this
 can be done this week :)

 Also, Travis and AppVeyor are complaining but I did not understand why (I
 found the logs hard to deciphers).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #31913 [Core Tor/Tor]: Add more robust Tor API documentation

2020-06-04 Thread Tor Bug Tracker & Wiki
#31913: Add more robust Tor API documentation
-+
 Reporter:  chelseakomlo |  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  api doc 043-can 044-can  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by nickm):

 * keywords:  api doc 043-can => api doc 043-can 044-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #31699 [Core Tor/Tor]: Remove unused configure.ac checks

2020-06-04 Thread Tor Bug Tracker & Wiki
#31699: Remove unused configure.ac checks
--+
 Reporter:  nickm |  Owner:  (none)
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  easy 044-can  |  Actual Points:
Parent ID:  #31698| Points:
 Reviewer:  catalyst  |Sponsor:
--+
Changes (by nickm):

 * keywords:  easy => easy 044-can


Comment:

 Any updates here?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #30642 [Core Tor/Tor]: Add an ed25519-identity file to the data directory

2020-06-04 Thread Tor Bug Tracker & Wiki
#30642: Add an ed25519-identity file to the data directory
+
 Reporter:  teor|  Owner:  neel
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-relay easy 044-can  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  dgoulet |Sponsor:
+
Changes (by nickm):

 * keywords:  tor-relay easy 043-can => tor-relay easy 044-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33788 [Core Tor/Tor]: Check the return value of tor_inet_ntop() and tor_inet_ntoa()

2020-06-04 Thread Tor Bug Tracker & Wiki
#33788: Check the return value of tor_inet_ntop() and tor_inet_ntoa()
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  extra-review, 044-should, security-  |  Actual Points:
  low, 035-backport, 041-backport,   |
  042-backport, 043-backport, outreachy-ipv6,|
  ipv6, 044-must |
Parent ID:  #33768   | Points:  1
 Reviewer:  nickm|Sponsor:
 |  Sponsor55-can
-+-
Changes (by nickm):

 * sponsor:  Sponsor55-must => Sponsor55-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #30642 [Core Tor/Tor]: Add an ed25519-identity file to the data directory

2020-06-04 Thread Tor Bug Tracker & Wiki
#30642: Add an ed25519-identity file to the data directory
+
 Reporter:  teor|  Owner:  neel
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-relay easy 043-can  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  dgoulet |Sponsor:
+
Changes (by nickm):

 * keywords:  tor-relay easy => tor-relay easy 043-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34369 [Applications/Tor Browser]: Fix learn more link in Onion Auth prompt

2020-06-04 Thread Tor Bug Tracker & Wiki
#34369: Fix learn more link in Onion Auth prompt
--+--
 Reporter:  antonela  |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-9.5-issues|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by antonela):

 Thanks mcs; that works for me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #29217 [Core Tor/Tor]: Script to add new tor files and modules in rust and/or C

2020-06-04 Thread Tor Bug Tracker & Wiki
#29217: Script to add new tor files and modules in rust and/or C
--+
 Reporter:  nickm |  Owner:  (none)
 Type:  enhancement   | Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  worksforme
 Keywords:  043-deferred  |  Actual Points:
Parent ID:| Points:  2
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  new => closed
 * resolution:   => worksforme


Comment:

 We have add_c_file, and we can add a rust version of it once we're
 seriously working on Rust again.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33533 [Applications/Tor Browser]: Rebase Tor Browser esr68 patches on top of mozilla-central

2020-06-04 Thread Tor Bug Tracker & Wiki
#33533: Rebase Tor Browser esr68 patches on top of mozilla-central
--+
 Reporter:  acat  |  Owner:  acat
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202006R |  Actual Points:  14
Parent ID:  #33661| Points:
 Reviewer:  sysrqb, gk|Sponsor:  Sponsor58-must
--+

Comment (by gk):

 Replying to [comment:1 acat]:

 [snip]

 > == [dropped-not needed]
 > {{{
 > d6fc4d6753fd Bug 31344: Actually register SecurityLevelPreference's
 'unload' callback in pr..
 >   [Fixed in securitylevel first patch.]
 > }}}

 Looks good to me.

 [snip]

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #29226 [Core Tor/Tor]: Automate application of C formatting to code

2020-06-04 Thread Tor Bug Tracker & Wiki
#29226: Automate application of C formatting to code
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-2020Q1, |  Actual Points:
  042-deferred-20190918, 043-deferred|
Parent ID:   | Points:  5
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * milestone:  Tor: 0.4.4.x-final => Tor: 0.4.5.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33898 [Core Tor/Tor]: Stop modifying addr on connections, and delete real_addr

2020-06-04 Thread Tor Bug Tracker & Wiki
#33898: Stop modifying addr on connections, and delete real_addr
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, technical-debt, prop311|  Actual Points:
  044-can|
Parent ID:  #33048   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor55-can
-+-
Changes (by nickm):

 * keywords:  ipv6, technical-debt, prop311 => ipv6, technical-debt, prop311
 044-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33533 [Applications/Tor Browser]: Rebase Tor Browser esr68 patches on top of mozilla-central

2020-06-04 Thread Tor Bug Tracker & Wiki
#33533: Rebase Tor Browser esr68 patches on top of mozilla-central
--+
 Reporter:  acat  |  Owner:  acat
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202006R |  Actual Points:  14
Parent ID:  #33661| Points:
 Reviewer:  sysrqb, gk|Sponsor:  Sponsor58-must
--+

Comment (by gk):

 Replying to [comment:1 acat]:

 [snip]

 > == [dropped-included in central]
 > {{{
 > 19fa956d545b Revert "Bug 31764: Fix for error when navigating via 'Paste
 and go'"
 >   [Fixed in https://bugzilla.mozilla.org/show_bug.cgi?id=1590538.]
 > 944a06831375 Bug 31573: Catch SessionStore.jsm exception
 >   [Fixed in https://bugzilla.mozilla.org/show_bug.cgi?id=1591259.]
 > 991ca736be20 Bug 31764: Fix for error when navigating via 'Paste and go'
 >   [Fixed in https://bugzilla.mozilla.org/show_bug.cgi?id=1590538]
 > 5aff5deef248 Bug 1330467 - part 12. FPI isolation of translation
 permissions; r=johannh
 > a35270cfc712 Bug 1330467 - part 11. Use principal for permissions in
 webrtc UI; r=johannh
 > 237353e6979c Bug 1330467 - part 10. Use principal for permissions in
 browser site-identity;..
 > 0e0410581635 Bug 1330467 - part 9. Use principal with mobile
 permissions; r=johannh,snorp
 > 09e3a7e741d2 Bug 1330467 - part 8. Make canvas permission respect FPI;
 r=johannh,jrmuizel
 > 3b7c44a13a4b Bug 1330467 - part 7. Confirm FPI in permission manager
 tests; r=Ehsan
 > 967603b18514 Bug 1330467 - part 6. Use principal for permissions in
 sitePermissions.js; r=j..
 > 0295727507bd Bug 1330467 - part 5. Access permissions by principal in
 PermissionUI.jsm; r=j..
 > 1cdc080d08f1 Bug 1330467 - part 3. Use principal for permissions in
 pageinfo/permissions.js..
 > 17f811e34af6 Bug 1330467 - part 2. Add SitePermissions APIs functions to
 accept principal; ..
 > 2ed45e021fe0 Bug 1330467 - part 1. Don't strip first party domain from
 permissions key; r=j..
 > 767012d2dfae Bug 1474659 Add dedicated AllocKinds just for
 ArrayBufferObjects. r?sfink
 > a2fc76be99de Bug 1561322 - Allow spoofing strings in HTML forms
 r=baku,Pike
 > 5705089f0a11 Bug 1560574 - use FormatPRExplodedTime to display GMT;
 r=kershaw
 > 8ff568d9f802 Bug 467035 - Avoid leaking browser language via DTD
 r=Gijs,bzbarsky
 > 0db2161d0c38 Bug 467035 - Add new internal DTD content types r=ckerschb
 > 84f9b4ce58f3 Bug 1557729 - Use principal for permission post prompts
 instead of URI. r=xeon..
 > b6701121f90c Bug 1573276 - Always allow localization in error pages
 r=johannh,peterv
 > 468cb520dc26 Bug 1585351 - Bug 1460357 disabled AVX instructions for the
 mingw build; this ..
 > be19b7d3bed7 Bug 1534339 - make OriginAttributes deserializable; r=baku
 > 9003a3f749c3 Bug 1546832 - Adjust letterboxing to take the FindBar and
 Devtools into accoun..
 > 33c51442838a Bug 1556017 - Fixing the off-by-one-pixel issue of find bar
 and devtool iframe..
 > 4773175a1c43 Bug 1581537 - Avoid several browser language leaks r=smaug
 > de5a72279416 Bug 1598647 - Set Origin to null with
 network.http.referer.hideOnionSource r=J..
 > 3f1c2b0337b6 Bug 1554805 - Never set firstPartyDomain on origin
 attributes for moz-extensio..
 > e6a7cccd8623 Bug 1467970 - Unsupport cross docGroup adoption r=smaug
 > 058f7553389c Bug 1590526 - Temporarily allow node adoption across
 different docGroups for t..
 > a83411dfd84f Bug 1590538 - Don't pass an empty object to urlbar-user-
 start-navigation becau..
 > ac96b77c70e6 Bug 461204 - Improve the random number generator for the
 boundaries in multipa..
 > 6c093eda44d7 Bug 29120: Enable media cache in memory
 >

 This looks good overall. The patch for #29120, though, needs a fixup to
 set `browser.privatebrowsing.forceMediaMemoryCache` to `true`. We have
 #33856 for that, so this is okay.

 [snip]

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #25140 [Core Tor/Tor]: Parse only .torrc files in torrc.d directory

2020-06-04 Thread Tor Bug Tracker & Wiki
#25140: Parse only .torrc files in torrc.d directory
-+-
 Reporter:  iry  |  Owner:
 |  Jigsaw52
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.1-alpha
 Severity:  Major| Resolution:
 Keywords:  034-triage-20180328, |  Actual Points:
  035-removed-20180711, 042-deferred-20190918,   |
  043-deferred, 044-can  |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by nickm):

 * keywords:
 034-triage-20180328, 035-removed-20180711, 042-deferred-20190918,
 043-deferred
 =>
 034-triage-20180328, 035-removed-20180711, 042-deferred-20190918,
 043-deferred, 044-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #32088 [Core Tor/Tor]: Proposal 310 - choose guards in sampled order

2020-06-04 Thread Tor Bug Tracker & Wiki
#32088: Proposal 310 - choose guards in sampled order
-+-
 Reporter:  Jaym |  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-spec prop271 prop310 044-should  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  nickm, asn   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  tor-spec prop271 prop310 => tor-spec prop271 prop310
   044-should


Comment:

 Hi, how is this going?  I'd love to take a version of this in 0.4.4 if we
 can, to improve our security, but it might make more sense to take it
 early in 0.4.5 if it's not going to be done by the deadline (Jun 15).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #29136 [Core Tor/Tor]: PT_LOG and PT_STATUS event fields unspecifed

2020-06-04 Thread Tor Bug Tracker & Wiki
#29136: PT_LOG and PT_STATUS event fields unspecifed
-+-
 Reporter:  atagar   |  Owner:  atagar
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-spec, tor-pt, 040-must   |  Actual Points:
  documentation 044-should   |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
 |  Sponsor19-can
-+-
Changes (by nickm):

 * keywords:  tor-spec, tor-pt, 040-must documentation => tor-spec, tor-pt,
 040-must documentation 044-should


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #31483 [Core Tor/Tor]: token_bucket_ctr_adjust() does not convert rate to step

2020-06-04 Thread Tor Bug Tracker & Wiki
#31483: token_bucket_ctr_adjust() does not convert rate to step
--+
 Reporter:  teor  |  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal| Resolution:
 Keywords:  043-deferred  |  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:  asn   |Sponsor:
--+
Changes (by nickm):

 * priority:  Very High => Medium


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #32907 [Core Tor/Tor]: Remove or_options_t dependencies from module config headers

2020-06-04 Thread Tor Bug Tracker & Wiki
#32907: Remove or_options_t dependencies from module config headers
--+
 Reporter:  teor  |  Owner:  nickm
 Type:  enhancement   | Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  043-deferred 044-can  |  Actual Points:
Parent ID:  #32798| Points:  0.5
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * owner:  (none) => nickm
 * keywords:  043-deferred => 043-deferred 044-can
 * status:  new => accepted
 * type:  defect => enhancement


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #32910 [Core Tor/Tor]: trace: Add tracepoints and userspace tracer support

2020-06-04 Thread Tor Bug Tracker & Wiki
#32910: trace: Add tracepoints and userspace tracer support
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tracing 044-can  |  Actual Points:
Parent ID:   | Points:  3
 Reviewer:  nickm|Sponsor:
-+
Changes (by nickm):

 * keywords:  tracing => tracing 044-can


Comment:

 (if revisions are done on this by the deadline, it can go in. else it
 should wait for 0.4.5)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33856 [Applications/Tor Browser]: Set browser.privatebrowsing.forceMediaMemoryCache=true

2020-06-04 Thread Tor Bug Tracker & Wiki
#33856: Set browser.privatebrowsing.forceMediaMemoryCache=true
--+--
 Reporter:  pospeselr |  Owner:  mcs
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202006R |  Actual Points:
Parent ID:  #33533| Points:
 Reviewer:|Sponsor:  Sponsor58
--+--
Changes (by gk):

 * parent:  #33534 => #33533


Comment:

 I think that's actually a rebase issue, thus reparenting

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33097 [Core Tor/Tor]: outbuf_flushlen seems to serve no purpose

2020-06-04 Thread Tor Bug Tracker & Wiki
#33097: outbuf_flushlen seems to serve no purpose
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.4.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  assigned => accepted
 * milestone:  Tor: 0.4.4.x-final => Tor: 0.4.5.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33533 [Applications/Tor Browser]: Rebase Tor Browser esr68 patches on top of mozilla-central

2020-06-04 Thread Tor Bug Tracker & Wiki
#33533: Rebase Tor Browser esr68 patches on top of mozilla-central
--+
 Reporter:  acat  |  Owner:  acat
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202006R |  Actual Points:  14
Parent ID:  #33661| Points:
 Reviewer:  sysrqb, gk|Sponsor:  Sponsor58-must
--+

Comment (by gk):

 Replying to [comment:1 acat]:
 > Rebased patches for review in https://github.com/acatarineu/tor-
 browser/commits/33533.
 >
 > Some changes to torbutton and tor-launcher were needed:
 https://github.com/acatarineu/torbutton/commit/33533 and
 https://github.com/acatarineu/tor-launcher/commit/33533
 >
 > I used commits `7d21cd26ee65..6046d1d58280` from `tor-
 browser-68.5.0esr-9.5-1`.
 >
 > Similarly to #30429, I put the commits/patches in different categories.
 For some of them I added comments, which I hope will make reviewing
 slightly easier.
 >
 > Regarding mobile patches, most of them have empty intersection with the
 files that are currently in central (all of [mobile-gone], unless I missed
 any). I only picked the mobile patches in [mobile-picked], most of them
 just partially as some of the files are not in central anymore. I guess
 the parts that could not be applied will have to be ported to Fenix.
 >
 > == [mobile-gone]
 >
 >
 > c2da27fca068 Revert "Bug 1603270 - Add telemetry for
 FirefoxPromoBannerRow user actions. r=..
 > eb88d8eea02d Bug #32405: Crash immediately after bootstrap on Android
 > 517624ea7f34 Bug 26529 - Prompt before opening external app

 I opened #34378 for that.

 > 9dab64fe2f20 Bug 31144 - Do not switching apps from CustomTabs without
 consent
 > c2cc5044c4ff Bug 31720: Enable website suggestions in address bar
 > e661977d1bb5 Bug 1568521 Tracking protection doorhanger's Enable/Disable
 states don't work ..
 > a1d645909b33 Load torbutton in BrowserApp.startup on Android
 > 3e871c620796 Bug 30573 - Sanitize old tabs and wait for tor before
 opening new tabs
 > 83137febd5bb Bug 31058: Remove Linus' default bridges
 > 136bd95b705e Bug 24920 - Only create Private tabs if
 browser.privatebrowsing.autostart is t..
 > 75e9943e8ec9 Continue using non-adaptive icons and don't allow clear-
 text traffic
 > a8bcc8eb823e Bug 29238 - Prevent crash on Android after update
 > 5a270452946c Bug 26690: Port padlock states for .onion services to
 mobile
 >   [Part of this is probably in
 mobile/android/modules/geckoview/GeckoViewProgress.jsm, but I
 >   guess this would be more like porting rather than cherry-picking
 patch.]

 Yep. I opened #34377 for that.

 > d479cc5c77e9 Bug 28329 - Part 4. Add new Tor Bootstrapping and
 configuration screens
 > 7b18ef3cccbd Bug 28329 - Part 1. Add new Tor resources
 > 2cd5f4f5b512 Bug 25696 - Implement alpha onboarding for Tor Browser for
 Android
 > 888a81d2198d Bug 27016 - Create proxy connection during image download
 > 16345563997f Orfox: hook up default panic trigger to "quit and clear"
 > a4f9c85167c1 Orfox: quit button added
 > 5e0596ff3e30 Orfox: disable screenshots and prevent page from being in
 "recent apps"
 > 37c77b37cdeb Bug 25741 - TBA: Adjust the User Agent String so it doesn't
 leak Android version
 > 0e9127b09627 Bug 25741 - TBA: top sites changed, used bookmarks icon
 temporarily.
 > 06e93e8c45c7 Bug 25741 - TBA: Always Quit, do not restore the last
 session
 > 1f103a7c4166 Bug 25741 - TBA: Disable all data reporting by default
 > b1349fb511c2 Bug 25741 - TBA: Clear state when the app exits, by default
 > 9a6409fa58fb Bug 25741 - TBA: Do not import bookmarks and history from
 native browser by de..
 > 8b7ae6bcbd5c Bug 25741 - TBA: Do not save browsing history by default
 > 81e402b80cc3 Bug 25741 - TBA: Disable QR Code reader by default
 > 0f40171a057b Bug 25741 - TBA: Disable the microphone by default
 > 268f04897c90 Bug 25741 - TBA: Disable telemetry and experiments
 > 3729f4263efe Bug 25741 - TBA: Remove sync option from preferences
 > dda2781bf72e Bug 25741 - TBA: Do not register Stumbler listener at start
 up
 > 4c70c3e1546b Bug 25741 - TBA: Exclude unwanted Stumbler tests
 > 66d133b41794 Bug 28640 - Try showing the homepage after the Distribution
 loads
 > 94b9527157ed Bug 28640 - Reload distribution preferences on update
 > 03b1e4c88e3a Revert "Bug 1570878 - Add sign-in buttons to onboarding.
 r=petru a=RyanVM"
 > c895b8c77c0d Revert "Bug 1576170 - Onboarding Sign up strings. r=flod
 a=RyanVM"
 > d6165a9a6b36 Revert "Bug 1585132 - Fix lint failures from sign up button
 patches. r=petru, ..
 > 54ab76fb79f6 Revert "Bug 1570880 - Added Sign in buttons in
 Awesomescreen. r=petru a=RyanVM"
 > 970ebbc553ab Revert "Bug 1570878 - 

Re: [tor-bugs] #34381 [Core Tor/Tor]: Shellcheck warnings for no-longer-existent contrib scripts

2020-06-04 Thread Tor Bug Tracker & Wiki
#34381: Shellcheck warnings for no-longer-existent contrib scripts
--+
 Reporter:  c |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  044-can   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * keywords:   => 044-can
 * milestone:   => Tor: 0.4.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34381 [Core Tor/Tor]: Shellcheck warnings for contrib scripts

2020-06-04 Thread Tor Bug Tracker & Wiki
#34381: Shellcheck warnings for contrib scripts
--+
 Reporter:  c |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 Those files don't actually exist in our repository any more -- they may
 have been left around from building with an older version of Tor, which
 did have them?

 They used to be generated from `tor.sh.in` files by autoconf.

 Maybe we should update "scripts/maint/checkShellScripts.sh" so that it
 deletes these files if they are present and not in version control?

 Probably we should edit .gitignore so that these files are no longer
 ignored.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34381 [Core Tor/Tor]: Shellcheck warnings for no-longer-existent contrib scripts (was: Shellcheck warnings for contrib scripts)

2020-06-04 Thread Tor Bug Tracker & Wiki
#34381: Shellcheck warnings for no-longer-existent contrib scripts
--+
 Reporter:  c |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #11151 [Core Tor/Tor]: Drop support for 0.2.2 clients

2020-06-04 Thread Tor Bug Tracker & Wiki
#11151: Drop support for 0.2.2 clients
---+--
 Reporter:  nickm  |  Owner:  (none)
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:  worksforme
 Keywords:  tor-relay deprecation  |  Actual Points:
Parent ID:  #9476  | Points:  medium
 Reviewer: |Sponsor:
---+--
Changes (by nickm):

 * status:  new => closed
 * resolution:   => worksforme


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #31422 [Circumvention/BridgeDB]: Make BridgeDB report internal metrics

2020-06-04 Thread Tor Bug Tracker & Wiki
#31422: Make BridgeDB report internal metrics
-+-
 Reporter:  phw  |  Owner:  phw
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Circumvention/BridgeDB   |Version:
 Severity:  Normal   | Resolution:
 Keywords:  s30-o21a1, anti-censorship-  |  Actual Points:
  roadmap-2020   |
Parent ID:  #31274   | Points:  2
 Reviewer:  agix |Sponsor:
 |  Sponsor30-can
-+-
Changes (by phw):

 * reviewer:   => agix


Comment:

 Agix generously agreed to review this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #29834 [Applications/Tor Browser]: Update Google Play screenshots

2020-06-04 Thread Tor Bug Tracker & Wiki
#29834: Update Google Play screenshots
--+---
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  enhancement   | Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:  Sponsor58
--+---
Changes (by gaba):

 * sponsor:   => Sponsor58


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33202 [Applications/Tor Browser]: Update Tor Browser for Android's Google Play description

2020-06-04 Thread Tor Bug Tracker & Wiki
#33202: Update Tor Browser for Android's Google Play description
--+---
 Reporter:  PROTechThor   |  Owner:  tbb-team
 Type:  enhancement   | Status:  new
 Priority:  Low   |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Trivial   | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:  Sponsor58
--+---
Changes (by gaba):

 * sponsor:   => Sponsor58


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #19774 [Circumvention/BridgeDB]: bridges.torproject.org could use a favicon

2020-06-04 Thread Tor Bug Tracker & Wiki
#19774: bridges.torproject.org could use a favicon
--+
 Reporter:  isis  |  Owner:  phw
 Type:  enhancement   | Status:  needs_review
 Priority:  Very Low  |  Milestone:
Component:  Circumvention/BridgeDB|Version:
 Severity:  Minor | Resolution:
 Keywords:  ux-team, easy, s30-o22a2  |  Actual Points:
Parent ID:  #31279| Points:  1
 Reviewer:  cohosh|Sponsor:  Sponsor30-must
--+
Changes (by cohosh):

 * reviewer:   => cohosh


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #20346 [Core Tor/Tor]: Do we need Tor unstable binary releases for Windows, OS X, BSD?

2020-06-04 Thread Tor Bug Tracker & Wiki
#20346: Do we need Tor unstable binary releases for Windows, OS X, BSD?
+--
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  closed
 Priority:  Medium  |  Milestone:  Tor:
|  unspecified
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:  not a bug
 Keywords:  testing, qa, integration-tests  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by nickm):

 * status:  new => closed
 * resolution:   => not a bug


Comment:

 Would be a good idea, but doesn't need a ticket unless we're actually
 doing it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34382 [Core Tor/Tor]: Don't require M_SYSCALL in sandbox.c

2020-06-04 Thread Tor Bug Tracker & Wiki
#34382: Don't require M_SYSCALL in sandbox.c
---+
 Reporter:  nickm  |  Owner:  nickm
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  easy fast-fix  |  Actual Points:  0
Parent ID: | Points:  0.1
 Reviewer: |Sponsor:
---+
Changes (by nickm):

 * actualpoints:   => 0


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34382 [Core Tor/Tor]: Don't require M_SYSCALL in sandbox.c

2020-06-04 Thread Tor Bug Tracker & Wiki
#34382: Don't require M_SYSCALL in sandbox.c
---+
 Reporter:  nickm  |  Owner:  nickm
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  easy fast-fix  |  Actual Points:
Parent ID: | Points:  0.1
 Reviewer: |Sponsor:
---+
Changes (by nickm):

 * status:  assigned => needs_review


Comment:

 See branch `ticket34382` with PR at
 https://github.com/torproject/tor/pull/1919

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


[tor-bugs] #34382 [Core Tor/Tor]: Don't require M_SYSCALL in sandbox.c

2020-06-04 Thread Tor Bug Tracker & Wiki
#34382: Don't require M_SYSCALL in sandbox.c
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  easy fast-fix
Actual Points:|  Parent ID:
   Points:  0.1   |   Reviewer:
  Sponsor:|
--+
 In sandbox.c, we have a platform-dependent M_SYSCALL macro that is used to
 extract the syscall from a ucontext_t pointer.

 But we only use this value for debugging.  Perhaps instead we should make
 it optional, so that platforms where we don't have it defined can still
 build with m_syscall.

 See also #32904 and #30987

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34380 [Internal Services/Service - trac]: Add GSoC and Outreachy interns to GRP_user group

2020-06-04 Thread Tor Bug Tracker & Wiki
#34380: Add GSoC and Outreachy interns to GRP_user group
--+
 Reporter:  pili  |  Owner:  qbi
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Internal Services/Service - trac  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by qbi):

 * status:  new => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #32904 [Core Tor/Tor]: Tor build fails with -enable-seccomp on mips

2020-06-04 Thread Tor Bug Tracker & Wiki
#32904: Tor build fails with -enable-seccomp on mips
--+--
 Reporter:  pa-ja |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:  Tor: 0.4.2.5
 Severity:  Normal| Resolution:
 Keywords:  mips  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by nickm):

 So, this is going to require somebody who knows the linux ABI on MIPS.  In
 theory, there should be some register in which the syscall is stored when
 we hit the signal handler.  That's different on each platform.  If you add
 a definition for that at the start of sandbox.c, it should make
 compilation work.

 We can take patches for this to work better, but we don't have the
 resources to work on MIPS ourselves.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #32808 [Core Tor/Tor]: I can't connect anymore to tor 2

2020-06-04 Thread Tor Bug Tracker & Wiki
#32808: I can't connect anymore to tor 2
--+--
 Reporter:  rlko  |  Owner:  (none)
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  worksforme
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by nickm):

 * status:  new => closed
 * resolution:   => worksforme


Comment:

 Looks like this got resolved?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33432 [Metrics/Onionperf]: Multiple downloads for oneshot mode

2020-06-04 Thread Tor Bug Tracker & Wiki
#33432: Multiple downloads for oneshot mode
-+-
 Reporter:  acute|  Owner:
 |  metrics-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionperf|Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-team-roadmap-2020, metrics-  |  Actual Points:
  team-roadmap-2020-june |
Parent ID:  #33321   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor59-must
-+-
Changes (by gaba):

 * keywords:   => metrics-team-roadmap-2020, metrics-team-roadmap-2020-june
 * sponsor:  Sponsor59 => Sponsor59-must


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


[tor-bugs] [Tor Bug Tracker & Wiki] Batch modify: #28271, #29365, #29368, #29369, ...

2020-06-04 Thread Tor Bug Tracker & Wiki
Batch modification to #28271, #29365, #29368, #29369, #33257, #33397, #33399, 
#33420, #33421, #33422, #33974, #29370 by gaba:


Comment:
Adding all this tickets to the OnionPerf roadmap for June.

--
Tickets URL: 

Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33399 [Metrics/Onionperf]: Measure static guard nodes with OnionPerf

2020-06-04 Thread Tor Bug Tracker & Wiki
#33399: Measure static guard nodes with OnionPerf
---+
 Reporter:  acute  |  Owner:  metrics-team
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:  0.1
Parent ID:  #33325 | Points:  4
 Reviewer: |Sponsor:  Sponsor59-must
---+

Comment (by karsten):

 Replying to [comment:10 mikeperry]:
 > One additional wrinkle: circuit_build_times_reset() does not emit a
 BUILDTIMEOUT_SET RESET event by itself. For sanity, I am guessing the
 DROPTIMEOUTS command should cause this RESET event to get emitted.
 >
 > This DROPTIMEOUTS command should be a relatively simple patch. If you
 need it, I can probably hack that up in an hour or two.

 That would be awesome. Yes, please!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34257 [Metrics/Onionperf]: Analyze unusual distribution of time to extend to first hop in circuit

2020-06-04 Thread Tor Bug Tracker & Wiki
#34257: Analyze unusual distribution of time to extend to first hop in circuit
-+-
 Reporter:  karsten  |  Owner:
 |  metrics-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionperf|Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-team-roadmap-2020, metrics-  |  Actual Points:  1.5
  team-roadmap-2020-june |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor59-must
-+-
Changes (by gaba):

 * keywords:   => metrics-team-roadmap-2020, metrics-team-roadmap-2020-june


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34303 [Core Tor/Tor]: Find out why onion service measurements have gotten slower

2020-06-04 Thread Tor Bug Tracker & Wiki
#34303: Find out why onion service measurements have gotten slower
-+-
 Reporter:  karsten  |  Owner:  karsten
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-team-roadmap-2020, metrics-  |  Actual Points:  1.1
  team-roadmap-2020-june |
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
 |  Sponsor59-must
-+-
Changes (by gaba):

 * keywords:  035-backport? => metrics-team-roadmap-2020, metrics-team-
 roadmap-2020-june


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34316 [Metrics/Onionperf]: Make -o/-i arguments mutually exclusive

2020-06-04 Thread Tor Bug Tracker & Wiki
#34316: Make -o/-i arguments mutually exclusive
-+-
 Reporter:  karsten  |  Owner:  karsten
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionperf|Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-team-roadmap-2020, metrics-  |  Actual Points:
  team-roadmap-2020-june |
Parent ID:   | Points:  0.2
 Reviewer:   |Sponsor:
 |  Sponsor59-must
-+-
Changes (by gaba):

 * keywords:   => metrics-team-roadmap-2020, metrics-team-roadmap-2020-june
 * sponsor:  Sponsor59 => Sponsor59-must


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #32888 [Core Tor/Tor]: Log address config info when tor starts up

2020-06-04 Thread Tor Bug Tracker & Wiki
#32888: Log address config info when tor starts up
+
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  reopened
 Priority:  Medium  |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ipv6, 043-deferred  |  Actual Points:
Parent ID:  #5940   | Points:  1
 Reviewer:  nickm   |Sponsor:
+
Changes (by c):

 * status:  closed => reopened
 * resolution:  implemented =>


Comment:

 Reopening because my PR does not meet the IPv6 debugging requirements
 described in the ticket

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33399 [Metrics/Onionperf]: Measure static guard nodes with OnionPerf

2020-06-04 Thread Tor Bug Tracker & Wiki
#33399: Measure static guard nodes with OnionPerf
---+
 Reporter:  acute  |  Owner:  metrics-team
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:  0.1
Parent ID:  #33325 | Points:  4
 Reviewer: |Sponsor:  Sponsor59-must
---+

Comment (by mikeperry):

 One additional wrinkle: circuit_build_times_reset() does not emit a
 BUILDTIMEOUT_SET RESET event by itself. For sanity, I am guessing the
 DROPTIMEOUTS command should cause this RESET event to get emitted.

 This DROPTIMEOUTS command should be a relatively simple patch. If you need
 it, I can probably hack that up in an hour or two.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #23079 [Core Tor/Tor]: Support 80-bit Onion Model In Perpetuity

2020-06-04 Thread Tor Bug Tracker & Wiki
#23079: Support 80-bit Onion Model In Perpetuity
--+--
 Reporter:  cypherpunks   |  Owner:  (none)
 Type:  project   | Status:  closed
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  wontfix
 Keywords:  tor-hs|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by nickm):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 (As noted, this is not something we plan to do.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33421 [Metrics/Onionperf]: Track which Guard is used for experimental measurements

2020-06-04 Thread Tor Bug Tracker & Wiki
#33421: Track which Guard is used for experimental measurements
---+---
 Reporter:  acute  |  Owner:  metrics-team
 Type:  enhancement| Status:  needs_information
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID:  #33321 | Points:  3
 Reviewer: |Sponsor:  Sponsor59-must
---+---

Comment (by mikeperry):

 Yes. Tracking the GUARD event and marking CIRC events with match/mismatch
 will indeed solve the issue, and will help us diagnose other weird guard
 usage problems as well.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33076 [Metrics/Analysis]: Graph onionperf and consensus information from Rob's experiments

2020-06-04 Thread Tor Bug Tracker & Wiki
#33076: Graph onionperf and consensus information from Rob's experiments
-+-
 Reporter:  mikeperry|  Owner:
 |  metrics-team
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Analysis |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-team-roadmap-2020, sbws- |  Actual Points:  3
  roadmap|
Parent ID:  #33327   | Points:  6
 Reviewer:   |Sponsor:
 |  Sponsor59-must
-+-
Changes (by gaba):

 * keywords:  metrics-team-roadmap-2020Q1, sbws-roadmap => metrics-team-
 roadmap-2020, sbws-roadmap


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34086 [Core Tor/Tor]: HSv3: Bug Non-fatal assertion in hs_client.c:776: client_rendezvous_circ_has_opened

2020-06-04 Thread Tor Bug Tracker & Wiki
#34086: HSv3: Bug Non-fatal assertion in hs_client.c:776:
client_rendezvous_circ_has_opened
---+
 Reporter:  s7r|  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor   |Version:  Tor: 0.4.4.0-alpha-dev
 Severity:  Normal | Resolution:
 Keywords:  tor-hs 044-should  |  Actual Points:
Parent ID:  #34082 | Points:
 Reviewer: |Sponsor:
---+

Comment (by asn):

 This is an edge-case bug that should only occur when a client bombards a
 service with requests. So it's not super high severity.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34084 [Core Tor/Tor]: HSv3: Bug at setup_intro_circ_auth_key at ../src/feature/hs/hs_client.c:739

2020-06-04 Thread Tor Bug Tracker & Wiki
#34084: HSv3: Bug at setup_intro_circ_auth_key at 
../src/feature/hs/hs_client.c:739
---+
 Reporter:  s7r|  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor   |Version:  Tor: 0.4.4.0-alpha-dev
 Severity:  Normal | Resolution:
 Keywords:  tor-hs 044-should  |  Actual Points:
Parent ID:  #34082 | Points:
 Reviewer: |Sponsor:
---+

Comment (by asn):

 This is an edge-case bug that should only occur when a client bombards a
 service with requests. So it's not super high severity.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34087 [Core Tor/Tor]: HSv3: Bug: Non-fatal assertion in hs_client.c:981: close_or_reextend_intro_circ

2020-06-04 Thread Tor Bug Tracker & Wiki
#34087: HSv3: Bug: Non-fatal assertion in hs_client.c:981:
close_or_reextend_intro_circ
---+
 Reporter:  s7r|  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor   |Version:  Tor: 0.4.4.0-alpha-dev
 Severity:  Normal | Resolution:
 Keywords:  tor-hs 044-should  |  Actual Points:
Parent ID:  #34082 | Points:
 Reviewer: |Sponsor:
---+

Comment (by asn):

 This is an edge-case bug that should only occur when a client bombards a
 service with requests. So it's not super high severity.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34279 [Circumvention/Snowflake]: Building a workable UI.

2020-06-04 Thread Tor Bug Tracker & Wiki
#34279: Building a workable UI.
-+-
 Reporter:  HashikD  |  Owner:  (none)
 Type:  task | Status:  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake-mobile |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by cohosh):

 * status:  needs_review => merge_ready


Comment:

 Looks good to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34381 [Core Tor/Tor]: Shellcheck warnings for contrib scripts

2020-06-04 Thread Tor Bug Tracker & Wiki
#34381: Shellcheck warnings for contrib scripts
--+
 Reporter:  c |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by c):

 * Attachment "make-check.log" added.

 Output of `make check`, shellcheck begins at line 61

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


[tor-bugs] #34381 [Core Tor/Tor]: Shellcheck warnings for contrib scripts

2020-06-04 Thread Tor Bug Tracker & Wiki
#34381: Shellcheck warnings for contrib scripts
--+
 Reporter:  c |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 {{{
 % shellcheck --version
 ShellCheck - shell script analysis tool
 version: 0.7.1
 }}}

 Running `make check` results in a few warnings for both
 `contrib/dist/suse/tor.sh` and `contrib/dist/tor.sh`, namely SC2034
 (unused variables) and SC2039 (POSIX incompatibilities). If shellcheck is
 right, then I can gladly go ahead and address these warnings in a PR.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33260 [Metrics/Onionperf]: Add option to filter graphed OnionPerf results by relay fingerprint

2020-06-04 Thread Tor Bug Tracker & Wiki
#33260: Add option to filter graphed OnionPerf results by relay fingerprint
---+
 Reporter:  karsten|  Owner:  metrics-team
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID:  #33328 | Points:  3
 Reviewer: |Sponsor:  Sponsor59-must
---+

Comment (by karsten):

 Note from today's meeting: We should add an include as well as an exclude
 filter here.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #29370 [Metrics/Onionperf]: Measure mode with arbitrary tgen traffic models

2020-06-04 Thread Tor Bug Tracker & Wiki
#29370: Measure mode with arbitrary tgen traffic models
---+--
 Reporter:  irl|  Owner:  metrics-team
 Type:  enhancement| Status:  reopened
 Priority:  Low|  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:  0.1
Parent ID:  #33321 | Points:  1
 Reviewer: |Sponsor:  Sponsor59
---+--
Changes (by acute):

 * Attachment "0001-Removes-unused-traffic-model-argument.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34278 [Circumvention/Snowflake]: Handling connection failures.

2020-06-04 Thread Tor Bug Tracker & Wiki
#34278: Handling connection failures.
-+---
 Reporter:  HashikD  |  Owner:  (none)
 Type:  task | Status:  needs_information
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake-mobile |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+---
Changes (by cohosh):

 * status:  new => needs_information


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34316 [Metrics/Onionperf]: Make -o/-i arguments mutually exclusive

2020-06-04 Thread Tor Bug Tracker & Wiki
#34316: Make -o/-i arguments mutually exclusive
---+-
 Reporter:  karsten|  Owner:  karsten
 Type:  defect | Status:  merge_ready
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:  0.2
 Reviewer: |Sponsor:  Sponsor59
---+-
Changes (by acute):

 * status:  needs_review => merge_ready


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34265 [Circumvention/Snowflake]: Library selection for WebSocket communication with Tor relay.

2020-06-04 Thread Tor Bug Tracker & Wiki
#34265: Library selection for WebSocket communication with Tor relay.
-+---
 Reporter:  HashikD  |  Owner:  (none)
 Type:  task | Status:  needs_information
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake-mobile |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+---
Changes (by cohosh):

 * status:  new => needs_information


Comment:

 Note to self to provide some feedback on this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34316 [Metrics/Onionperf]: Make -o/-i arguments mutually exclusive

2020-06-04 Thread Tor Bug Tracker & Wiki
#34316: Make -o/-i arguments mutually exclusive
---+--
 Reporter:  karsten|  Owner:  karsten
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:  0.2
 Reviewer: |Sponsor:  Sponsor59
---+--

Comment (by acute):

 TIL about `add_mutually_exclusive_group()` in `argparse`, thanks! This
 works nicely and the code reads well, setting to merge_ready.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34380 [Internal Services/Service - trac]: Add GSoC and Outreachy interns to GRP_user group

2020-06-04 Thread Tor Bug Tracker & Wiki
#34380: Add GSoC and Outreachy interns to GRP_user group
--+-
 Reporter:  pili  |  Owner:  qbi
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Internal Services/Service - trac  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-
Description changed by pili:

Old description:

> Hi,
>
> Can we please get the following trac users added to the GRP_user group?
>
> ayahany
> c
> HashikD
> nicoleiocana
> woswos
>
> (Some of these may have been done already...)
>
> Thank you!

New description:

 Hi,

 Can we please get the following trac users added to the GRP_user group?

 ayahany
 c
 HashikD
 krona
 nicoleiocana
 woswos

 (Some of these may have been done already...)

 Thank you!

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


[tor-bugs] #34380 [Internal Services/Service - trac]: Add GSoC and Outreachy interns to GRP_user group

2020-06-04 Thread Tor Bug Tracker & Wiki
#34380: Add GSoC and Outreachy interns to GRP_user group
--+-
 Reporter:  pili  |  Owner:  qbi
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Internal Services/Service - trac  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+-
 Hi,

 Can we please get the following trac users added to the GRP_user group?

 ayahany
 c
 HashikD
 nicoleiocana
 woswos

 (Some of these may have been done already...)

 Thank you!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #29370 [Metrics/Onionperf]: Measure mode with arbitrary tgen traffic models

2020-06-04 Thread Tor Bug Tracker & Wiki
#29370: Measure mode with arbitrary tgen traffic models
---+--
 Reporter:  irl|  Owner:  metrics-team
 Type:  enhancement| Status:  reopened
 Priority:  Low|  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:  0.1
Parent ID:  #33321 | Points:  1
 Reviewer: |Sponsor:  Sponsor59
---+--

Comment (by karsten):

 Agreed with what you write, robgjansen.

 Replying to [comment:13 acute]:
 > > If researchers need to change parts of a model that cannot be
 configured using the OnionPerf command line interface, they will have to
 change the OnionPerf sources to do what they want. I'd say that that's
 still easier than editing a TGen XML file. If the missing piece is better
 documentation, we should provide that.
 > That is exactly what I had in mind for doing this.

 Great!

 > > My suggestions are that we:
 > >  - make the current bulk transfer model more configurable by adding
 parameters like initial pause, transfer count, or filesize as part of
 #33432;
 > >  - develop a ping model as internal model where OnionPerf generates
 TGen files, plus analysis and visualization code, as part of #30798,
 assuming there's need for developing such a model; and
 > >  - remove the `-m/--traffic-model` parameter from the codebase and
 close this ticket as something we considered carefully but decided
 against.
 >
 > This all sounds good, but I'd add to this writing some documentation for
 using other models we don't support as proposed above.

 Yes, good point! Updated next steps are:
  - make the current bulk transfer model more configurable by adding
 parameters like initial pause, transfer count, or filesize as part of
 #33432;
  - develop a ping model as internal model where OnionPerf generates TGen
 files, plus analysis and visualization code, as part of #30798, assuming
 there's need for developing such a model;
  - write documentation for using other models we don't support as proposed
 above; and
  - remove the `-m/--traffic-model` parameter from the codebase and close
 this ticket as something we considered carefully but decided against.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #32888 [Core Tor/Tor]: Log address config info when tor starts up

2020-06-04 Thread Tor Bug Tracker & Wiki
#32888: Log address config info when tor starts up
+
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  closed
 Priority:  Medium  |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:  implemented
 Keywords:  ipv6, 043-deferred  |  Actual Points:
Parent ID:  #5940   | Points:  1
 Reviewer:  nickm   |Sponsor:
+
Changes (by nickm):

 * status:  needs_revision => closed
 * resolution:   => implemented


Comment:

 Merged, and added a changes file in `b335ef178156e2`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


[tor-bugs] #34379 [Applications/Tor Browser]: Fix learn more for Onion-Location

2020-06-04 Thread Tor Bug Tracker & Wiki
#34379: Fix learn more for Onion-Location
--+
 Reporter:  acat  |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  tbb-9.5-issues
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 Similar to #34369, we have to fix the learn more links in the doorhanger
 and in about:preferences to point to https://tb-
 manual.torproject.org/[locale]/onion-services/

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #29370 [Metrics/Onionperf]: Measure mode with arbitrary tgen traffic models

2020-06-04 Thread Tor Bug Tracker & Wiki
#29370: Measure mode with arbitrary tgen traffic models
---+--
 Reporter:  irl|  Owner:  metrics-team
 Type:  enhancement| Status:  reopened
 Priority:  Low|  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:  0.1
Parent ID:  #33321 | Points:  1
 Reviewer: |Sponsor:  Sponsor59
---+--

Comment (by acute):

 > If researchers need to change parts of a model that cannot be configured
 using the OnionPerf command line interface, they will have to change the
 OnionPerf sources to do what they want. I'd say that that's still easier
 than editing a TGen XML file. If the missing piece is better
 documentation, we should provide that.
 That is exactly what I had in mind for doing this.

 >
 > My suggestions are that we:
 >  - make the current bulk transfer model more configurable by adding
 parameters like initial pause, transfer count, or filesize as part of
 #33432;
 >  - develop a ping model as internal model where OnionPerf generates TGen
 files, plus analysis and visualization code, as part of #30798, assuming
 there's need for developing such a model; and
 >  - remove the `-m/--traffic-model` parameter from the codebase and close
 this ticket as something we considered carefully but decided against.

 This all sounds good, but I'd add to this writing some documentation as
 proposed above.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33384 [Webpages/Support]: Create entry in support.torproject.org for Onion-Location automatic redirects.

2020-06-04 Thread Tor Bug Tracker & Wiki
#33384: Create entry in support.torproject.org for Onion-Location automatic
redirects.
--+---
 Reporter:  acat  |  Owner:  hiro
 Type:  task  | Status:  closed
 Priority:  Medium|  Milestone:
Component:  Webpages/Support  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:|  Actual Points:
Parent ID:  #33512| Points:
 Reviewer:|Sponsor:  Sponsor27
--+---
Changes (by acat):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Yes :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33516 [Webpages]: [Community Portal] Add an article under Onion Services with different options for redirecting to Onion Services

2020-06-04 Thread Tor Bug Tracker & Wiki
#33516: [Community Portal] Add an article under Onion Services with different
options for redirecting to Onion Services
-+---
 Reporter:  pili |  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Webpages |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team, tor-hs  |  Actual Points:
Parent ID:  #33512   | Points:
 Reviewer:   |Sponsor:  Sponsor27-can
-+---

Comment (by sysrqb):

 Done? https://community.torproject.org/onion-services/advanced/onion-
 location/

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33384 [Webpages/Support]: Create entry in support.torproject.org for Onion-Location automatic redirects.

2020-06-04 Thread Tor Bug Tracker & Wiki
#33384: Create entry in support.torproject.org for Onion-Location automatic
redirects.
--+---
 Reporter:  acat  |  Owner:  hiro
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Webpages/Support  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #33512| Points:
 Reviewer:|Sponsor:  Sponsor27
--+---

Comment (by sysrqb):

 Done? https://support.torproject.org/onionservices/onion-location/

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33420 [Metrics/Onionperf]: Add CBT events to Onionperf result files

2020-06-04 Thread Tor Bug Tracker & Wiki
#33420: Add CBT events to Onionperf result files
---+---
 Reporter:  acute  |  Owner:  karsten
 Type:  enhancement| Status:  needs_information
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:  0.3
Parent ID:  #33321 | Points:  1
 Reviewer: |Sponsor:  Sponsor59-must
---+---

Comment (by karsten):

 Thanks for the clarification!

 I think that not performing measurements between `BUILDTIMEOUT_SET RESET`
 and `BUILDTIMEOUT_SET COMPUTED` will be difficult. But we can exclude
 those measurements in the visualization step. We'll likely want to add a
 command-line switch for that. It might be easier to first do #34231 and
 #33260 and then work on this ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33399 [Metrics/Onionperf]: Measure static guard nodes with OnionPerf

2020-06-04 Thread Tor Bug Tracker & Wiki
#33399: Measure static guard nodes with OnionPerf
---+
 Reporter:  acute  |  Owner:  metrics-team
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:  0.1
Parent ID:  #33325 | Points:  4
 Reviewer: |Sponsor:  Sponsor59-must
---+

Comment (by karsten):

 Thanks for the input, mikeperry!

 The idea of using a controller command for dropping timeouts rather than
 removing the `state` file came from robgjansen who was thinking about
 running similar experiments in Shadow. I'd say we should at least give it
 a try and see how complicated it is to implement such a command. Maybe
 we'll get help from friendly network team people.

 Still leaving this ticket assigned to metrics-team to be picked up. It's
 certainly not a tiny amount of work, but that's already reflected in the
 4.0 points estimated for this ticket. If somebody picks it up, please
 remember to release early and often by sharing intermediate results on
 this ticket. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


  1   2   >