Re: [tor-bugs] #29370 [Metrics/Onionperf]: Measure mode with arbitrary tgen traffic models

[Tor Bug Tracker & Wiki]

#29370: Measure mode with arbitrary tgen traffic models
-+-
 Reporter:  irl  |  Owner:  acute
 Type:  enhancement  | Status:
 |  accepted
 Priority:  Low  |  Milestone:
Component:  Metrics/Onionperf|Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-team-roadmap-2020, metrics-  |  Actual Points:  0.1
  team-roadmap-2020-june |
Parent ID:  #33321   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor59
-+-

Comment (by phw):

 Replying to [comment:16 karsten]:
 > Thanks for the patch! I applied it together with another minor patch to
 also remove the `--traffic-model` parameter from the documentation.
 [[br]]
 I think we also need to remove the
 
[https://gitweb.torproject.org/onionperf.git/tree/onionperf/onionperf?id=17b0cf422adc81d356d1db4aba46b495e9487d0b#n331
 if condition] that checks for `args.model`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34389 [Applications/Tor Browser]: Multi-Account Container extension "corrupt" upon installation

[Tor Bug Tracker & Wiki]

#34389: Multi-Account Container extension "corrupt" upon installation
--+---
 Reporter:  TechyGrue |  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  not a bug
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by Thorin):

 * status:  new => closed
 * resolution:   => not a bug


Comment:

 Container OA's (origin atributes) are not compatible in PB Mode (which Tor
 Browser is always in)

 Tor Browser ships with FPI (First Party Isolation). Your cookies, local
 storage and IDB (and favicons, OCSP cache, workers, SSL session cache,
 media cache, HSTS, HPKP, HTTP Alt Services, HTTP2, DNS cache, blob URIs
 and more) are already isolated.

 You don't need containers

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33222 [Core Tor/Tor]: Prop 311: 4.2. Implement IPv6 ORPort Reachability Self-Tests

[Tor Bug Tracker & Wiki]

#33222: Prop 311: 4.2. Implement IPv6 ORPort Reachability Self-Tests
---+
 Reporter:  teor   |  Owner:  teor
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  ipv6, prop311  |  Actual Points:  4
Parent ID:  #33221 | Points:  6
 Reviewer:  nickm  |Sponsor:  Sponsor55-must
---+

Comment (by nickm):

 I don't see any remaining blockers to merge this.  The only thing I need
 to do first is make 100% sure I understand what is changing, so I can
 maintain and extend it going forward.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33626 [Applications/Tor Browser]: Add TBB project for GeckoView

[Tor Bug Tracker & Wiki]

#33626: Add TBB project for GeckoView
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  GeorgKoppen202006, TorBrowserTeam202006|
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb, ahf  |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * keywords:  tbb-mobile, tbb-rbm, GeorgKoppen202005, TorBrowserTeam202006
 => tbb-mobile, tbb-rbm, GeorgKoppen202006, TorBrowserTeam202006


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34011 [Applications/Tor Browser]: Bump clang version to 9.0.1

[Tor Bug Tracker & Wiki]

#34011: Bump clang version to 9.0.1
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  GeorgKoppen202006, TorBrowserTeam202006|
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * keywords:  tbb-mobile, tbb-rbm, GeorgKoppen202005, TorBrowserTeam202006R
 => tbb-mobile, tbb-rbm, GeorgKoppen202006, TorBrowserTeam202006
 * status:  needs_review => needs_revision


Comment:

 This needs a small fixup at least.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33626 [Applications/Tor Browser]: Add TBB project for GeckoView

[Tor Bug Tracker & Wiki]

#33626: Add TBB project for GeckoView
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  GeorgKoppen202005, TorBrowserTeam202006|
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb, ahf  |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * status:  merge_ready => needs_revision
 * keywords:  tbb-mobile, tbb-rbm, GeorgKoppen202005, TorBrowserTeam202006R
 => tbb-mobile, tbb-rbm, GeorgKoppen202005, TorBrowserTeam202006


Comment:

 This needs a small fixup at least.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #34391 [Applications/Tor Browser]: Remove --enable-signmar from .mozconfig files

[Tor Bug Tracker & Wiki]

#34391: Remove --enable-signmar from .mozconfig files
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  ff78-esr, tbb-rbm,
 Severity:  Normal   |  TorBrowserTeam202006,
 |  GeorgKoppen202006
Actual Points:   |  Parent ID:  #34228
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 Since https://bugzilla.mozilla.org/show_bug.cgi?id=1562952 landed there is
 no `--enable-signmar` anymore. We should remove it from our Linux
 .mozconfig files.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #34390 [Applications/Tor Browser]: Update build script to remove copying libnssdbm3.so around

[Tor Bug Tracker & Wiki]

#34390: Update build script to remove copying libnssdbm3.so around
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  ff78-esr, tbb-rbm,
 Severity:  Normal   |  TorBrowserTeam202006,
 |  GeorgKoppen202006
Actual Points:   |  Parent ID:  #34228
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 Since https://bugzilla.mozilla.org/show_bug.cgi?id=1594933 landed there is
 no `libnssdbm3.so` file built anymore by default.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #34388 [Applications/Tor Browser]: Update lucetc and wasi-sdk projects to latest ESR 78 code

[Tor Bug Tracker & Wiki]

#34388: Update lucetc and wasi-sdk projects to latest ESR 78 code
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  ff78-esr, tbb-rbm,
 Severity:  Normal   |  TorBrowserTeam202006,
 |  GeorgKoppen202006
Actual Points:   |  Parent ID:  #34228
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 In order to properly enable WASM sandboxing we should update our `lucetc`
 and `wasi-sdk` projects to what Mozilla ships in ESR 78.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34389 [Applications/Tor Browser]: Multi-Account Container extension "corrupt" upon installation

[Tor Bug Tracker & Wiki]

#34389: Multi-Account Container extension "corrupt" upon installation
--+--
 Reporter:  TechyGrue |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by TechyGrue):

 * Attachment "multi_account_containers_TB_error.png" added.

 Screenshot of failure

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #34389 [Applications/Tor Browser]: Multi-Account Container extension "corrupt" upon installation

[Tor Bug Tracker & Wiki]

#34389: Multi-Account Container extension "corrupt" upon installation
---+--
 Reporter:  TechyGrue  |  Owner:  tbb-team
 Type:  defect | Status:  new
 Priority:  Medium |  Component:  Applications/Tor Browser
  Version: |   Severity:  Normal
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
 Hi. I'm running TB 9.5 on Ubuntu 20.04. To further improve my privacy, I'd
 like to install Multi-Account Containers extension to have cookie
 (session) isolation between tabs. I've tried installing versions that I
 verified work in vanilla Firefox. All attempts fail with same error "The
 add-on downloaded from this site could not be installed because it appears
 to be corrupt." Screenshot here: https://i.imgur.com/zlCxx2I.png

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #34387 [Applications/Tor Browser]: Fix Namecoin patches for ESR 78

[Tor Bug Tracker & Wiki]

#34387: Fix Namecoin patches for ESR 78
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  ff78-esr, tbb-rbm,
 Severity:  Normal   |  TorBrowserTeam202006,
 |  GeorgKoppen202006
Actual Points:   |  Parent ID:  #34228
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 We need to adapt our Namecoin patches to ESR 78

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #34386 [Applications/Tor Browser]: Fixup clang compilation for Linux

[Tor Bug Tracker & Wiki]

#34386: Fixup clang compilation for Linux
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  ff78-esr, tbb-rbm,
 Severity:  Normal   |  TorBrowserTeam202006,
 |  GeorgKoppen202006
Actual Points:   |  Parent ID:  #34228
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 We need to fix up our clang compilation for Linux. Right now, with 9.0.1
 we get:
 {{{
 /var/tmp/build/llvm/projects/compiler-rt/lib/crt/crtbegin.c:86:16: error:
 section type conflict with '__EH_FRAME_LIST__'
86 |used)) static void (*__fini)(void) = __do_fini;
   |^~~~
 /var/tmp/build/llvm/projects/compiler-rt/lib/crt/crtbegin.c:13:28: note:
 '__EH_FRAME_LIST__' was declared here
13 | __extension__ static void *__EH_FRAME_LIST__[]
   |^
 make[2]: *** [lib/clang/9.0.1/lib/linux/clang_rt.crtbegin-i386.o] Error 1
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33432 [Metrics/Onionperf]: Multiple downloads for oneshot mode

[Tor Bug Tracker & Wiki]

#33432: Multiple downloads for oneshot mode
-+-
 Reporter:  acute|  Owner:  phw
 Type:  enhancement  | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionperf|Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-team-roadmap-2020, metrics-  |  Actual Points:
  team-roadmap-2020-june |
Parent ID:  #33321   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor59-must
-+-
Changes (by phw):

 * owner:  metrics-team => phw
 * status:  new => assigned
 * cc: metrics-team (added)


Comment:

 I'm snatching this ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29369 [Metrics/Onionperf]: Fix message logging and filtering

[Tor Bug Tracker & Wiki]

#29369: Fix message logging and filtering
-+-
 Reporter:  irl  |  Owner:  phw
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionperf|Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-team-roadmap-2020, metrics-  |  Actual Points:  1
  team-roadmap-2020-june |
Parent ID:  #33321   | Points:  1.0
 Reviewer:  phw  |Sponsor:
 |  Sponsor59-must
-+-
Changes (by phw):

 * status:  needs_review => merge_ready
 * actualpoints:  0.5 => 1


Comment:

 Two comments:
 * `-MM-YY` should probably be `-MM-DD`.
 * The string "onionperf.analysis.json.xz" shows up thrice in the save
 function. We could use a variable instead, e.g., `base_filename =
 "onionperf.analysis.json.xz"`.

 Feel free to address these comments as you see fit. I don't think this
 patch requires another review round, so I'm setting it to merge ready and
 adding my 0.5 points.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34118 [Applications/Tor Browser]: Onion-Location banner isn't shown when using subdomains in the onion address

[Tor Bug Tracker & Wiki]

#34118: Onion-Location banner isn't shown when using subdomains in the onion
address
--+---
 Reporter:  ahf   |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by ahf):

 It looks like it's a problem when you mix Onion-Location with alt-svc:
 https://mastodon.social/web/statuses/104287008389695002

 I'm not too sure if this is something we should special case handling for.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34280 [Circumvention/Snowflake]: Building a workable Notification UI Design.

[Tor Bug Tracker & Wiki]

#34280: Building a workable Notification UI Design.
-+
 Reporter:  HashikD  |  Owner:  (none)
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  snowflake-mobile |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by cohosh):

 * status:  needs_information => closed
 * resolution:   => fixed


Comment:

 Ah okay so it's been merged already. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34280 [Circumvention/Snowflake]: Building a workable Notification UI Design.

[Tor Bug Tracker & Wiki]

#34280: Building a workable Notification UI Design.
-+---
 Reporter:  HashikD  |  Owner:  (none)
 Type:  task | Status:  needs_information
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake-mobile |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+---

Comment (by HashikD):

 Hey! update? this ticket specific code can be found at Commit
 ID:9c39e6bdb79a92f8c3c76f1be90f6ef04a410968

 Is this what you are asking for Cohosh? or If you were asking if this
 ticket needs an updated description to accompany the additional features I
 added to the notification.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34280 [Circumvention/Snowflake]: Building a workable Notification UI Design.

[Tor Bug Tracker & Wiki]

#34280: Building a workable Notification UI Design.
-+---
 Reporter:  HashikD  |  Owner:  (none)
 Type:  task | Status:  needs_information
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake-mobile |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+---
Changes (by cohosh):

 * status:  needs_review => needs_information


Comment:

 Does this need to be updated?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34268 [Circumvention/Snowflake]: Creating a service to do the work in the background and implementing a wakelock.

[Tor Bug Tracker & Wiki]

#34268: Creating a service to do the work in the background and implementing a
wakelock.
-+-
 Reporter:  HashikD  |  Owner:  (none)
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:  implemented
 Keywords:  snowflake-mobile |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by cohosh):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Done. You probably want to make sure your own master branch is up to date
 with origin/master now :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34268 [Circumvention/Snowflake]: Creating a service to do the work in the background and implementing a wakelock.

[Tor Bug Tracker & Wiki]

#34268: Creating a service to do the work in the background and implementing a
wakelock.
-+-
 Reporter:  HashikD  |  Owner:  (none)
 Type:  task | Status:  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake-mobile |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by cohosh):

 * status:  needs_review => merge_ready


Comment:

 Nice, I'll merge this to master.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33854 [Applications/Tor Browser]: Spoof Network ID

[Tor Bug Tracker & Wiki]

#33854: Spoof Network ID
--+---
 Reporter:  pospeselr |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #33534| Points:
 Reviewer:|Sponsor:  Sponsor58
--+---

Comment (by acat):

 I agree that `networkID` is currently not exposed to (non-privileged)
 WebExtensions or web content, and I would also say we don't have to spoof
 it right now. This might change in the future (e.g. the API being
 available to all WebExtensions), but I hope we'll be able to catch that if
 it happens.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29368 [Metrics/Onionperf]: Add single onion service mode

[Tor Bug Tracker & Wiki]

#29368: Add single onion service mode
-+-
 Reporter:  irl  |  Owner:  phw
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionperf|Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-team-roadmap-2020, metrics-  |  Actual Points:  0.6
  team-roadmap-2020-june |
Parent ID:  #33321   | Points:  2
 Reviewer:   |Sponsor:
 |  Sponsor59-must
-+-
Changes (by phw):

 * status:  needs_revision => merge_ready
 * actualpoints:  0.2 => 0.6


Comment:

 Thanks acute, I like your changes and applied your patch. (I also revised
 my patch and removed the extra newlines that I added to the configuration
 file because it broke some unit tests.)

 All tests now pass and the ready-to-merge branch is available here:
 https://github.com/NullHypothesis/onionperf/compare/enhancement/29368

 Adding my 0.4 points.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29223 [Core Tor/Tor]: List canonical abbreviations to use in Tor functions and identifiers

[Tor Bug Tracker & Wiki]

#29223: List canonical abbreviations to use in Tor functions and identifiers
---+
 Reporter:  nickm  |  Owner:  nickm
 Type:  task   | Status:  closed
 Priority:  Medium |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:  wontfix
 Keywords:  doc, s31-docs 042-can  |  Actual Points:  0.9
Parent ID: | Points:  1
 Reviewer:  asn|Sponsor:
---+
Changes (by nickm):

 * status:  needs_information => closed
 * resolution:   => wontfix


Comment:

 Okay, I think you're right here.  I don't know how to use this, but I'll
 remember how to find it in case we someday decide to resurrect the effort.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34385 [Applications/Tor Browser]: Be consistent with onion service terms

[Tor Bug Tracker & Wiki]

#34385: Be consistent with onion service terms
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202010  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by gk):

 Yes, I think "onion site" is better. However, I don't think fixing that
 needs to wait until October. I feel we can include that change into 9.5.1
 if we take like 10-15 min now and fix the strings outlined above. We can
 look for other strings that need changing later on in different tickets.

 I mean even if we are afraid of not all strings getting re-translated
 again for 9.5.1 we could get that change going now and just wait for
 stable getting the results until we feel comfortable enough.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15043 [Core Tor/Tor]: Use acx_pthread.m4 to find pthreads library

[Tor Bug Tracker & Wiki]

#15043: Use acx_pthread.m4 to find pthreads library
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  easy tor-relay build autoconf|  worksforme
  pthreads   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  new => closed
 * resolution:   => worksforme


Comment:

 This hasn't proved to be necessary, though we could do it someday if we
 come up with a need for it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #4320 [Core Tor/Tor]: Audit functions called during options_act_reversible()

[Tor Bug Tracker & Wiki]

#4320: Audit functions called during options_act_reversible()
-+-
 Reporter:  Sebastian|  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  audit tor-client reliability torrc   |  duplicate
  configuration  |  Actual Points:
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 This is better tracked as #32408.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13508 [Core Tor/Tor]: Add messaging protocol that is resistant to traffic analysis

[Tor Bug Tracker & Wiki]

#13508: Add messaging protocol that is resistant to traffic analysis
-+-
 Reporter:  Alan |  Owner:  (none)
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  wontfix
 Keywords:  messaging protocol store-and-|  Actual Points:
  forward traffic-analysis needs-proposal hard   |
  mixnet research-program|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 This is still a decent idea, but this ticket isn't the right place to do
 it.  First step would be a bunch of scoping and design work and proposal
 writing.  Also have a look at Loopix for a recent deployed mixnet-type
 system.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13590 [Core Tor/Tor]: Extend HiddenServicePort VIRTPORT semantics

[Tor Bug Tracker & Wiki]

#13590: Extend HiddenServicePort VIRTPORT semantics
-+-
 Reporter:  grarpamp |  Owner:  (none)
 Type:  enhancement  | Status:  closed
 Priority:  Low  |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.5.10
 Severity:  Normal   | Resolution:  wontfix
 Keywords:  tor-hs, shoot-self-in-foot honeypot  |  Actual Points:
  cfg|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  new => closed
 * resolution:   => wontfix


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34385 [Applications/Tor Browser]: Be consistent with onion service terms

[Tor Bug Tracker & Wiki]

#34385: Be consistent with onion service terms
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202010  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by sysrqb):

 * keywords:   => TorBrowserTeam202010


Comment:

 Putting it someone on the radar.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #12990 [Core Tor/Tor]: route certificate errors

[Tor Bug Tracker & Wiki]

#12990: route certificate errors
--+--
 Reporter:  saint |  Owner:  (none)
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  user disappeared
 Keywords:  tor-client|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by nickm):

 * status:  new => closed
 * resolution:   => user disappeared


Comment:

 No feedback from saint in 2 years, and this does appear to be a MITM
 attempt

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34385 [Applications/Tor Browser]: Be consistent with onion service terms

[Tor Bug Tracker & Wiki]

#34385: Be consistent with onion service terms
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by sysrqb):

 * cc: alsmith (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #11542 [Core Tor/Tor]: Add a new logging domain for transport proxies

[Tor Bug Tracker & Wiki]

#11542: Add a new logging domain for transport proxies
--+
 Reporter:  wfn   |  Owner:  yawning
 Type:  defect| Status:  closed
 Priority:  Low   |  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  duplicate
 Keywords:  tor-pt intro logging  |  Actual Points:
Parent ID:| Points:  small
 Reviewer:|Sponsor:  SponsorT
--+
Changes (by nickm):

 * status:  assigned => closed
 * resolution:   => duplicate
 * milestone:  Tor: unspecified => Tor: 0.4.0.x-final


Comment:

 There is an LD_PT, and has been since 0.4.0. (See also #28179)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #11595 [Core Tor/Tor]: Use smarter data structures for keeping track of circuit IDs per channel

[Tor Bug Tracker & Wiki]

#11595: Use smarter data structures for keeping track of circuit IDs per channel
-+-
 Reporter:  andrea   |  Owner:  (none)
 Type:  enhancement  | Status:  closed
 Priority:  Low  |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.5.3-alpha
 Severity:  Normal   | Resolution:  wontfix
 Keywords:  tor-relay data-structure maybe-not-  |  Actual Points:
  good-idea  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 We can revisit this if it comes up in profiles.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #11145 [Core Tor/Tor]: coverage utility should merge multiple output files

[Tor Bug Tracker & Wiki]

#11145: coverage utility should merge multiple output files
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Very Low |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7
 Severity:  Normal   | Resolution:  wontfix
 Keywords:  tor-client, coverage, tools, |  Actual Points:
  testing, SponsorS-deferred |
Parent ID:   | Points:  small
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 We now use coveralls for this, and it seems to work well.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34385 [Applications/Tor Browser]: Be consistent with onion service terms

[Tor Bug Tracker & Wiki]

#34385: Be consistent with onion service terms
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by sysrqb):

 see also ticket:19251#comment:25 and ticket:19251#comment:26

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #34385 [Applications/Tor Browser]: Be consistent with onion service terms

[Tor Bug Tracker & Wiki]

#34385: Be consistent with onion service terms
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 Recently Gus, Al, and I had a conversation about whether we should use
 "onionsite" or "onion site". We decided "onion site" is better for new
 users, and that is the better option. I noticed we use "onionsite" in Tor
 Browser. We should correct those instances. Are there other terms we
 should correct?

 torbutton:
 {{{
 $ git grep -n onionsite chrome/locale/en-US/
 chrome/locale/en-US/torbutton.properties:75:onionServices.descNotFound=The
 most likely cause is that the onionsite is offline. Contact the onionsite
 administrator.
 chrome/locale/en-US/torbutton.properties:80:onionServices.descInvalid=The
 onionsite is unreachable due an internal error.
 chrome/locale/en-US/torbutton.properties:85:onionServices.introFailed=The
 most likely cause is that the onionsite is offline. Contact the onionsite
 administrator.
 chrome/locale/en-
 US/torbutton.properties:90:onionServices.rendezvousFailed=The onionsite is
 busy or the Tor network is overloaded. Try again later.
 chrome/locale/en-
 US/torbutton.properties:95:onionServices.clientAuthMissing=Access to the
 onionsite requires a key but none was provided.
 chrome/locale/en-
 US/torbutton.properties:100:onionServices.clientAuthIncorrect=The provided
 key is incorrect or has been revoked. Contact the onionsite administrator.
 chrome/locale/en-US/torbutton.properties:105:onionServices.badAddress=The
 provided onionsite address is invalid. Please check that you entered it
 correctly.
 chrome/locale/en-
 US/torbutton.properties:110:onionServices.introTimedOut=Failed to connect
 to the onionsite, possibly due to a poor network connection.
 chrome/locale/en-
 US/torbutton.properties:124:onionServices.authPreferences.dialogIntro=Keys
 for the following onionsites are stored on your computer
 }}}

 tor browser:
 {{{
 $ git grep -n onionsite browser/modules/TorStrings.jsm
 browser/modules/TorStrings.jsm:397:dialogIntro:
 getString("authPreferences.dialogIntro", "Keys for the following
 onionsites are stored on your computer"),
 browser/modules/TorStrings.jsm:442:"Prioritize onionsites when
 they are available."
 }}}

 Any other places?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34384 [Core Tor/Tor]: AppVeyor builds are failing

[Tor Bug Tracker & Wiki]

#34384: AppVeyor builds are failing
--+--
 Reporter:  ahf   |  Owner:  (none)
 Type:  defect| Status:  closed
 Priority:  Very High |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal| Resolution:  fixed
 Keywords:  ci|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Cherry-picked to 0.3.5 and merged forward.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #11146 [Core Tor/Tor]: cov-diff utility should handle new source files

[Tor Bug Tracker & Wiki]

#11146: cov-diff utility should handle new source files
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Very Low |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7
 Severity:  Normal   | Resolution:  wontfix
 Keywords:  tor-client, coverage, tools, |  Actual Points:
  testing, SponsorS-deferred |
Parent ID:   | Points:  small
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 We're now mostly using coveralls in preference to cov-diff.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #11325 [Core Tor/Tor]: RFE: Adhere to XDB base directory specification

[Tor Bug Tracker & Wiki]

#11325: RFE: Adhere to XDB base directory specification
-+-
 Reporter:  jamielinux   |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Low  |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:  wontfix
 Keywords:  tor-client xdg-compliance intro  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 We're not planning to do this by default, though you can emulate it with
 the KeyDir, DataDir, and CacheDir options.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34384 [Core Tor/Tor]: AppVeyor builds are failing

[Tor Bug Tracker & Wiki]

#34384: AppVeyor builds are failing
--+--
 Reporter:  ahf   |  Owner:  (none)
 Type:  defect| Status:  merge_ready
 Priority:  Very High |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal| Resolution:
 Keywords:  ci|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by ahf):

 * status:  new => merge_ready


Comment:

 CI is happy.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29370 [Metrics/Onionperf]: Measure mode with arbitrary tgen traffic models

[Tor Bug Tracker & Wiki]

#29370: Measure mode with arbitrary tgen traffic models
-+-
 Reporter:  irl  |  Owner:  acute
 Type:  enhancement  | Status:
 |  accepted
 Priority:  Low  |  Milestone:
Component:  Metrics/Onionperf|Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-team-roadmap-2020, metrics-  |  Actual Points:  0.1
  team-roadmap-2020-june |
Parent ID:  #33321   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor59
-+-
Changes (by acute):

 * owner:  metrics-team => acute
 * status:  new => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #4712 [Core Tor/Tor]: Review and update any existing patches for proposal 182 ("credit buckets")

[Tor Bug Tracker & Wiki]

#4712: Review and update any existing patches for proposal 182 ("credit 
buckets")
-+-
 Reporter:  karsten  |  Owner:  (none)
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  wontfix
 Keywords:  tor-relay network performance|  Actual Points:
  credit-bucket  |
Parent ID:   | Points:  5
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 proposal 182 is marked obsolete.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34279 [Circumvention/Snowflake]: Building a workable UI.

[Tor Bug Tracker & Wiki]

#34279: Building a workable UI.
-+-
 Reporter:  HashikD  |  Owner:  (none)
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:  implemented
 Keywords:  snowflake-mobile |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by cohosh):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 merged.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #1299 [Core Tor/Tor]: Tor should verify signatures before parsing

[Tor Bug Tracker & Wiki]

#1299: Tor should verify signatures before parsing
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 |  0.2.1.24
 Severity:  Normal   | Resolution:  wontfix
 Keywords:  tor-security, tor-crypto, tor-   |  Actual Points:
  client, parse, safety, 035-removed-20180711|
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  new => closed
 * resolution:  None => wontfix


Comment:

 We've got to wontfix this one: too many of our document formats are
 specified in a way where you can't know what the keys are until _after_
 you do the parsing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #925 [Core Tor/Tor]: Tor fails badly when accept(2) returns EMFILE or ENFILE

[Tor Bug Tracker & Wiki]

#925: Tor fails badly when accept(2) returns EMFILE or ENFILE
-+-
 Reporter:  riastradh|  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Low  |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 |  0.2.0.33
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, oos, sponsor8-maybe,  |  worksforme
  tor-dos|  Actual Points:
Parent ID:  #19984   | Points:  medium
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  new => closed
 * resolution:  None => worksforme


Comment:

 I believe our out-of-sockets code should handle most of this; at least,
 all the original code that was here 10 years ago has been rewritten.

 Closing this ticket as no-longer-live.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #469 [Core Tor/Tor]: please limit connections by client

[Tor Bug Tracker & Wiki]

#469: please limit connections by client
+--
 Reporter:  weasel  |  Owner:  (none)
 Type:  defect  | Status:  closed
 Priority:  Low |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor|Version:  0.2.0.2-alpha
 Severity:  Normal  | Resolution:  worksforme
 Keywords:  tor-relay, tor-dos  |  Actual Points:
Parent ID:  | Points:  3
 Reviewer:  |Sponsor:  SponsorV-can
+--
Changes (by nickm):

 * status:  needs_revision => closed
 * resolution:  None => worksforme


Comment:

 This is now somewhat implemented as part of our out-of-sockets dos code, I
 believe.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #966 [Core Tor/Tor]: Do positive DNS tests

[Tor Bug Tracker & Wiki]

#966: Do positive DNS tests
---+--
 Reporter:  Sebastian  |  Owner:  (none)
 Type:  defect | Status:  closed
 Priority:  Low|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor   |Version:  0.2.1.13-alpha
 Severity:  Normal | Resolution:  worksforme
 Keywords:  dns tor-relay  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by nickm):

 * status:  reopened => closed
 * resolution:   => worksforme


Comment:

 I think we solved whatever DNS issues brought this up.  Also, we do make
 sure we can resolve google, I believe.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20832 [Core Tor/Tor]: Design proposals to further improve guard security

[Tor Bug Tracker & Wiki]

#20832: Design proposals to further improve guard security
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-guard, TorCoreTeam201705,|  worksforme
  034-triage-20180328, 034-removed-20180328  |  Actual Points:
Parent ID:  #20822   | Points:  2
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  new => closed
 * resolution:   => worksforme


Comment:

 These proposal ideas are no longer fresh; if we want to improve guard
 selection more, we should build on prop310

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34384 [Core Tor/Tor]: AppVeyor builds are failing

[Tor Bug Tracker & Wiki]

#34384: AppVeyor builds are failing
--+--
 Reporter:  ahf   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Very High |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal| Resolution:
 Keywords:  ci|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by ahf):

 Let's see what CI says to: https://github.com/torproject/tor/pull/1922

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20825 [Core Tor/Tor]: User-named guard selections

[Tor Bug Tracker & Wiki]

#20825: User-named guard selections
--+--
 Reporter:  nickm |  Owner:  (none)
 Type:  enhancement   | Status:  closed
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  wontfix
 Keywords:  tor-guard |  Actual Points:
Parent ID:  #20822| Points:
 Reviewer:|Sponsor:
--+--
Changes (by nickm):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 This is a would-be-cool thing, but nobody has asked for it and we haven't
 come up with a usecase. Calling it wontfix.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20719 [Core Tor/Tor]: prop271 -- make parameters configurable

[Tor Bug Tracker & Wiki]

#20719: prop271 -- make parameters configurable
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  intro tor-client guard torrc |  implemented
  configuration  |  Actual Points:
Parent ID:  #20822   | Points:  .5
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  new => closed
 * resolution:   => implemented


Comment:

 Wait, I think this happened as part of the prop271 work.  We should open
 new tickets at this point if we need to add new configuration parameters.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20353 [Core Tor/Tor]: evutil_ersatz_socketpair: use AF_INET6 if AF_INET bind fails

[Tor Bug Tracker & Wiki]

#20353: evutil_ersatz_socketpair: use AF_INET6 if AF_INET bind fails
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Very Low |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Trivial  | Resolution:  wontfix
 Keywords:  tor-client maybe-pointless easy  |  Actual Points:
Parent ID:   | Points:  .5
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 I think I was correct to label this as `maybe-pointless` :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33866 [Applications/Tor Browser]: Add Onion Service info to new cert viewer

[Tor Bug Tracker & Wiki]

#33866: Add Onion Service info to new cert viewer
--+---
 Reporter:  pospeselr |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #33534| Points:
 Reviewer:|Sponsor:  Sponsor58
--+---

Comment (by acat):

 Replying to [comment:1 mcs]:
 > As Kathy and I understand it, the patch for #23247 added "Onion Service"
 to the "Technical Details" section of the Page Info window's Security
 panel and did not modify the certificate viewer itself. If that is
 accurate, there is nothing to do here because that panel appears to be
 unchanged in post-ESR68 Firefox... at least for now.

 Yes, that's also my understanding.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20165 [Core Tor/Tor]: When a relay advertises a new, unreachable address, OR reachability can succeed via the old address

[Tor Bug Tracker & Wiki]

#20165: When a relay advertises a new, unreachable address, OR reachability can
succeed via the old address
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor:
  |  unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-dirauth testing reachability  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
  |  Sponsor55-can
--+
Changes (by nickm):

 * sponsor:   => Sponsor55-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20164 [Core Tor/Tor]: Warn relay operators when we guess an address from several equally valid alternatives

[Tor Bug Tracker & Wiki]

#20164: Warn relay operators when we guess an address from several equally valid
alternatives
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay usability logging warning  |  Actual Points:
  intro  |
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
 |  Sponsor55-can
-+-
Changes (by nickm):

 * sponsor:   => Sponsor55-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20061 [Core Tor/Tor]: When unit testing in Tor2web mode, set the config correctly

[Tor Bug Tracker & Wiki]

#20061: When unit testing in Tor2web mode, set the config correctly
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  wontfix
 Keywords:  tor2web, easy, intro, testing,   |  Actual Points:
  unit-tests |
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 Tor2web mode is no longer a thing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20021 [Core Tor/Tor]: Require ntor-onion-key in microdescriptors, descriptors

[Tor Bug Tracker & Wiki]

#20021: Require ntor-onion-key in microdescriptors, descriptors
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  wontfix
 Keywords:  034-triage-20180328, |  Actual Points:
  034-removed-20180328   |
Parent ID:   | Points:  1.1
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-
Changes (by nickm):

 * status:  needs_revision => closed
 * resolution:   => wontfix


Comment:

 This is deprecated in favor of proposal 315

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #34384 [Core Tor/Tor]: AppVeyor builds are failing

[Tor Bug Tracker & Wiki]

#34384: AppVeyor builds are failing
--+--
 Reporter:  ahf   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Very High |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal|   Keywords:  ci
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 Our AppVeyor builds are failing. It looks like the issue is related to us
 not updating Pacman before we install our dependencies.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29365 [Metrics/Onionperf]: Add digests and sizes to index.xml

[Tor Bug Tracker & Wiki]

#29365: Add digests and sizes to index.xml
-+-
 Reporter:  irl  |  Owner:  karsten
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionperf|Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-team-roadmap-2020, metrics-  |  Actual Points:  0.3
  team-roadmap-2020-june |
Parent ID:  #33321   | Points:  0.5
 Reviewer:  acute|Sponsor:
 |  Sponsor59-must
-+-
Changes (by acute):

 * status:  needs_review => needs_revision
 * actualpoints:  0.2 => 0.3


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29365 [Metrics/Onionperf]: Add digests and sizes to index.xml

[Tor Bug Tracker & Wiki]

#29365: Add digests and sizes to index.xml
-+-
 Reporter:  irl  |  Owner:  karsten
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionperf|Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-team-roadmap-2020, metrics-  |  Actual Points:  0.2
  team-roadmap-2020-june |
Parent ID:  #33321   | Points:  0.5
 Reviewer:  acute|Sponsor:
 |  Sponsor59-must
-+-

Comment (by acute):

 Replying to [comment:9 karsten]:
 > Even though CollecTor is currently not using this file, we should add
 more information about files being served than just the filename.
 >
 > However, I think that computing file digests is too much, because we'd
 either have to recompute these digests for all files once per day or store
 them somewhere. If we really need these digests on the consuming side,
 then let's consider adding them. But until that's the case, let's try
 something simpler.
 >
 > I wrote a patch that includes sizes and last-modified times along with
 filenames. These can be looked up really quickly while writing the XML
 file. While touching this code I also made sure that the index.xml file
 itself is not contained and I fixed the encoding issue introduced by the
 Python 3 upgrade.
 >
 > Please review
 
[https://gitweb.torproject.org/user/karsten/onionperf.git/commit/?h=task-29365=011359d0ed6580bd8cb00f3ce8c510c4948accb7
 commit 011359d in my task-29365 branch].

 Thank you for the patch! I have read and tested it - no issues there and
 it can be merged.

 Also, I did a quick check  - it takes ~1 second to compute all sha256
 digests for one years' worth of OP data downloaded from Collector on my
 old Lenovo x220 - I don't think recomputing these is an issue on
 processors nowadays.

 Adding sha256 hashes would be a small change (have attached a patch), up
 to you if you want to go ahead with it :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29365 [Metrics/Onionperf]: Add digests and sizes to index.xml

[Tor Bug Tracker & Wiki]

#29365: Add digests and sizes to index.xml
-+-
 Reporter:  irl  |  Owner:  karsten
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionperf|Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-team-roadmap-2020, metrics-  |  Actual Points:  0.2
  team-roadmap-2020-june |
Parent ID:  #33321   | Points:  0.5
 Reviewer:  acute|Sponsor:
 |  Sponsor59-must
-+-
Changes (by acute):

 * Attachment "0001-Adds-file-SHA-256-digests-to-index.xml.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32088 [Core Tor/Tor]: Proposal 310 - choose guards in sampled order

[Tor Bug Tracker & Wiki]

#32088: Proposal 310 - choose guards in sampled order
-+-
 Reporter:  Jaym |  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-spec prop271 prop310 044-should  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  nickm, asn   |Sponsor:
-+-
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 As discussed in IRC we asked for some documentation on the smartlist_sort
 pattern,.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33788 [Core Tor/Tor]: Check the return value of tor_inet_ntop() and tor_inet_ntoa()

[Tor Bug Tracker & Wiki]

#33788: Check the return value of tor_inet_ntop() and tor_inet_ntoa()
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  extra-review, 044-should, security-  |  implemented
  low, 035-backport, 041-backport,   |  Actual Points:
  042-backport, 043-backport, outreachy-ipv6,|
  ipv6, 044-must |
Parent ID:  #33768   | Points:  1
 Reviewer:  nickm|Sponsor:
 |  Sponsor55-can
-+-
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => implemented


Comment:

 Looks good now. Merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34381 [Core Tor/Tor]: Shellcheck warnings for no-longer-existent contrib scripts

[Tor Bug Tracker & Wiki]

#34381: Shellcheck warnings for no-longer-existent contrib scripts
--+
 Reporter:  c |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  044-can   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 I think maybe checkShellScripts would make more sense, but I'm not
 absolutely sure.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33788 [Core Tor/Tor]: Check the return value of tor_inet_ntop() and tor_inet_ntoa()

[Tor Bug Tracker & Wiki]

#33788: Check the return value of tor_inet_ntop() and tor_inet_ntoa()
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  extra-review, 044-should, security-  |  Actual Points:
  low, 035-backport, 041-backport,   |
  042-backport, 043-backport, outreachy-ipv6,|
  ipv6, 044-must |
Parent ID:  #33768   | Points:  1
 Reviewer:  nickm|Sponsor:
 |  Sponsor55-can
-+-
Changes (by rl1987):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34381 [Core Tor/Tor]: Shellcheck warnings for no-longer-existent contrib scripts

[Tor Bug Tracker & Wiki]

#34381: Shellcheck warnings for no-longer-existent contrib scripts
--+
 Reporter:  c |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  044-can   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by c):

 Ah, that would explain it, seeing as I have needed to build a previous
 release in the same repository.

 I'll make the appropriate change to gitignore. However, is
 checkShellScripts.sh the ideal place to remove these temporary files or
 should we stick them in the `make clean` target? I'm not sure of the best
 way to handle this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34383 [Applications/Tor Browser]: Accept request if GetHost() in mixed content blocking check fails

[Tor Bug Tracker & Wiki]

#34383: Accept request if GetHost() in mixed content blocking check fails
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202006  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Description changed by gk:

Old description:

> While reviewing acat's rebase work in #33533 I noticed the following
> block in our patch for #23247:
> {{{
>if (!parentIsHttps) {
> +nsAutoCString parentHost;
> +rv = innerRequestingLocation->GetHost(parentHost);
> +if (NS_FAILED(rv)) {
> +  NS_ERROR("requestingLocation->GetHost failed");
> +  *aDecision = REJECT_REQUEST;
> +  return NS_OK;
> +}
> +
> +bool parentIsOnion =
> +StringEndsWith(parentHost, NS_LITERAL_CSTRING(".onion"));
> +if (!parentIsOnion) {
> +  *aDecision = ACCEPT;
> +  return NS_OK;
> +}
> +  }
> }}}
> The corresponding part in Mozilla's code looks like
> [https://searchfox.org/mozilla-
> esr68/source/dom/security/nsMixedContentBlocker.cpp#748 this]:
> {{{
>   if (!parentIsHttps) {
> *aDecision = ACCEPT;
> return NS_OK;
>   }
> }}}
> Mozilla does not even check the host but is accepting requests at this
> point outright while we reject them if `GetHost()` fails.
>
> I wonder whether we should follow them here because I am a little worried
> that we might introduce a subtle bug by diverging from them.
>
> I guess the question is whether it can be the case that we have a .onion
> URL but the `GetHost()` call is failing. Mozilla does not care as there
> is no decision to be made depending on the *host* but the scheme alone in
> this check. However, we do care.
>
> Let's look at that from a different angle: the code block we added is
> essentially a check for a .onion domain: if we don't have one, accept the
> request otherwise pass it on for further checks. Let's look what we do
> elsewhere when checking for a .onion domain, e.g. in
> `IsPotentiallyTrustworthyOnion()`. [https://searchfox.org/mozilla-
> esr68/source/dom/security/nsMixedContentBlocker.cpp#401 There] we have:
> {{{
>  nsAutoCString host;
>   nsresult rv = aURL->GetHost(host);
>   NS_ENSURE_SUCCESS(rv, false);
>   return StringEndsWith(host, NS_LITERAL_CSTRING(".onion"));
> }}}
> This means if the `GetHost()` check fails we say "no, that's not a
> .onion". Following that logic we would get to `parentIsOnion = false` in
> our code block in question and we should `ACCEPT` the request as well in
> case the `GetHost()` call fails.

New description:

 While reviewing acat's rebase work in #33533 I noticed the following block
 in our patch for #23247:
 {{{
if (!parentIsHttps) {
 +nsAutoCString parentHost;
 +rv = innerRequestingLocation->GetHost(parentHost);
 +if (NS_FAILED(rv)) {
 +  NS_ERROR("requestingLocation->GetHost failed");
 +  *aDecision = REJECT_REQUEST;
 +  return NS_OK;
 +}
 +
 +bool parentIsOnion =
 +StringEndsWith(parentHost, NS_LITERAL_CSTRING(".onion"));
 +if (!parentIsOnion) {
 +  *aDecision = ACCEPT;
 +  return NS_OK;
 +}
 +  }
 }}}
 The corresponding part in Mozilla's code looks like [https://searchfox.org
 /mozilla-esr68/source/dom/security/nsMixedContentBlocker.cpp#748 this]:
 {{{
   if (!parentIsHttps) {
 *aDecision = ACCEPT;
 return NS_OK;
   }
 }}}
 Mozilla does not even check the host but is accepting requests at this
 point outright while we reject them if `GetHost()` fails.

 I wonder whether we should follow them here because I am a little worried
 that we might introduce a subtle bug by diverging from them.

 I guess the question is whether it can be the case that we have a .onion
 URL but the `GetHost()` call is failing. Mozilla does not care as there is
 no decision to be made depending on the *host* but the scheme alone in
 this check. However, we do care.

 Let's look at that from a different angle: the code block we added is
 essentially a check for a .onion domain: if we don't have one, accept the
 request otherwise pass it on for further checks. Let's look what we do
 elsewhere when checking for a .onion domain, e.g. in
 `IsPotentiallyTrustworthyOnion()`. [https://searchfox.org/mozilla-
 esr68/source/dom/security/nsMixedContentBlocker.cpp#401 There] we have:
 {{{
   nsAutoCString host;
   nsresult rv = aURL->GetHost(host);
   NS_ENSURE_SUCCESS(rv, false);
   return StringEndsWith(host, NS_LITERAL_CSTRING(".onion"));
 }}}
 This means if the `GetHost()` check fails we say "no, that's not a
 .onion". Following that logic we would get to `parentIsOnion = false` in
 

[tor-bugs] #34383 [Applications/Tor Browser]: Accept request if GetHost() in mixed content blocking check fails

[Tor Bug Tracker & Wiki]

#34383: Accept request if GetHost() in mixed content blocking check fails
--+
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
  |  TorBrowserTeam202006
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 While reviewing acat's rebase work in #33533 I noticed the following block
 in our patch for #23247:
 {{{
if (!parentIsHttps) {
 +nsAutoCString parentHost;
 +rv = innerRequestingLocation->GetHost(parentHost);
 +if (NS_FAILED(rv)) {
 +  NS_ERROR("requestingLocation->GetHost failed");
 +  *aDecision = REJECT_REQUEST;
 +  return NS_OK;
 +}
 +
 +bool parentIsOnion =
 +StringEndsWith(parentHost, NS_LITERAL_CSTRING(".onion"));
 +if (!parentIsOnion) {
 +  *aDecision = ACCEPT;
 +  return NS_OK;
 +}
 +  }
 }}}
 The corresponding part in Mozilla's code looks like [https://searchfox.org
 /mozilla-esr68/source/dom/security/nsMixedContentBlocker.cpp#748 this]:
 {{{
   if (!parentIsHttps) {
 *aDecision = ACCEPT;
 return NS_OK;
   }
 }}}
 Mozilla does not even check the host but is accepting requests at this
 point outright while we reject them if `GetHost()` fails.

 I wonder whether we should follow them here because I am a little worried
 that we might introduce a subtle bug by diverging from them.

 I guess the question is whether it can be the case that we have a .onion
 URL but the `GetHost()` call is failing. Mozilla does not care as there is
 no decision to be made depending on the *host* but the scheme alone in
 this check. However, we do care.

 Let's look at that from a different angle: the code block we added is
 essentially a check for a .onion domain: if we don't have one, accept the
 request otherwise pass it on for further checks. Let's look what we do
 elsewhere when checking for a .onion domain, e.g. in
 `IsPotentiallyTrustworthyOnion()`. [https://searchfox.org/mozilla-
 esr68/source/dom/security/nsMixedContentBlocker.cpp#401 There] we have:
 {{{
  nsAutoCString host;
   nsresult rv = aURL->GetHost(host);
   NS_ENSURE_SUCCESS(rv, false);
   return StringEndsWith(host, NS_LITERAL_CSTRING(".onion"));
 }}}
 This means if the `GetHost()` check fails we say "no, that's not a
 .onion". Following that logic we would get to `parentIsOnion = false` in
 our code block in question and we should `ACCEPT` the request as well in
 case the `GetHost()` call fails.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29365 [Metrics/Onionperf]: Add digests and sizes to index.xml

[Tor Bug Tracker & Wiki]

#29365: Add digests and sizes to index.xml
-+-
 Reporter:  irl  |  Owner:  karsten
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionperf|Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-team-roadmap-2020, metrics-  |  Actual Points:  0.2
  team-roadmap-2020-june |
Parent ID:  #33321   | Points:  0.5
 Reviewer:  acute|Sponsor:
 |  Sponsor59-must
-+-
Changes (by karsten):

 * reviewer:   => acute


Comment:

 acute kindly said that she'd be happy to review this ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33257 [Metrics/Onionperf]: Add CDF-DL graph

[Tor Bug Tracker & Wiki]

#33257: Add CDF-DL graph
-+-
 Reporter:  karsten  |  Owner:  karsten
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionperf|Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-team-roadmap-2020, metrics-  |  Actual Points:  0.3
  team-roadmap-2020-june |
Parent ID:  #33327   | Points:  3
 Reviewer:  acute|Sponsor:
 |  Sponsor59-must
-+-
Changes (by karsten):

 * reviewer:   => acute


Comment:

 acute kindly said that she'd be happy to review this ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29370 [Metrics/Onionperf]: Measure mode with arbitrary tgen traffic models

[Tor Bug Tracker & Wiki]

#29370: Measure mode with arbitrary tgen traffic models
-+-
 Reporter:  irl  |  Owner:
 |  metrics-team
 Type:  enhancement  | Status:  new
 Priority:  Low  |  Milestone:
Component:  Metrics/Onionperf|Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-team-roadmap-2020, metrics-  |  Actual Points:  0.1
  team-roadmap-2020-june |
Parent ID:  #33321   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor59
-+-
Changes (by karsten):

 * status:  reopened => new


Comment:

 Thanks for the patch! I applied it together with another minor patch to
 also remove the `--traffic-model` parameter from the documentation.

 I also added comments to #33432 and #30798 with references to this ticket.

 What remains is to '''write documentation for using other models we don't
 support as proposed above'''. I think we can keep this ticket open until
 that is done. Setting ticket status to new for that last part.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30798 [Metrics/Onionperf]: Develop and deploy tgen model resembling ping

[Tor Bug Tracker & Wiki]

#30798: Develop and deploy tgen model resembling ping
---+--
 Reporter:  karsten|  Owner:  metrics-team
 Type:  enhancement| Status:  reopened
 Priority:  High   |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID:  #33324 | Points:  5
 Reviewer: |Sponsor:  Sponsor59
---+--

Comment (by karsten):

 We briefly discussed the ping model as a possible use case for #29370, but
 then decided against implementing that ticket and instead develop a ping
 model as internal model where OnionPerf generates TGen files, plus
 analysis and visualization code, as part of this ticket, assuming there's
 need for developing such a model.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33432 [Metrics/Onionperf]: Multiple downloads for oneshot mode

[Tor Bug Tracker & Wiki]

#33432: Multiple downloads for oneshot mode
-+-
 Reporter:  acute|  Owner:
 |  metrics-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionperf|Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-team-roadmap-2020, metrics-  |  Actual Points:
  team-roadmap-2020-june |
Parent ID:  #33321   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor59-must
-+-

Comment (by karsten):

 We decided against implementing #29370 and concluded that we should make
 the current bulk transfer model more configurable by adding parameters
 like initial pause, transfer count, or filesize as part of this ticket.

 In theory, this could mean that we can get rid of the oneshot mode, too,
 if the default model can be parameterized enough to do what we wanted the
 oneshot mode to do as part of this ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34316 [Metrics/Onionperf]: Make -o/-i arguments mutually exclusive

[Tor Bug Tracker & Wiki]

#34316: Make -o/-i arguments mutually exclusive
-+-
 Reporter:  karsten  |  Owner:  karsten
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionperf|Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  metrics-team-roadmap-2020, metrics-  |  Actual Points:  0.1
  team-roadmap-2020-june |
Parent ID:   | Points:  0.2
 Reviewer:   |Sponsor:
 |  Sponsor59-must
-+-
Changes (by karsten):

 * status:  merge_ready => closed
 * resolution:   => fixed
 * actualpoints:   => 0.1


Comment:

 Thanks for the review! Rebased and pushed to master. Closing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs