Re: [tor-bugs] #10059 [Core Tor/Tor]: capture tor log messages before control connection is opened

[Tor Bug Tracker & Wiki]

#10059: capture tor log messages before control connection is opened
-+-
 Reporter:  mcs  |  Owner:  (none)
 Type:  enhancement  | Status:
 |  assigned
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, extdev-interview, |  Actual Points:
  tbb-needs, 034-triage-20180328,|
  035-removed-20180711   |
Parent ID:  #9675| Points:  3
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 We may also need a setting that limits the number of stored log messages,
 and the log level that is stored.

 For example:
 {{{
 ControlSaveLogEvents Notice 1000
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #10059 [Core Tor/Tor]: capture tor log messages before control connection is opened

[Tor Bug Tracker & Wiki]

#10059: capture tor log messages before control connection is opened
-+-
 Reporter:  mcs  |  Owner:  (none)
 Type:  enhancement  | Status:
 |  assigned
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, extdev-interview, |  Actual Points:
  tbb-needs, 034-triage-20180328,|
  035-removed-20180711   |
Parent ID:  #9675| Points:  3
 Reviewer:   |Sponsor:
-+-

Comment (by arma):

 Tor Browser now has a more accessible "View the Tor logs" feature, which
 is great. But when I start my Tor Browser, and ask it to show me my logs,
 it starts in mid-boot, at
 {{{
 10/20/19, 08:33:45.270 [NOTICE] DisableNetwork is set. Tor will not make
 or accept non-control network connections. Shutting down all existing
 connections.
 10/20/19, 08:33:45.270 [NOTICE] DisableNetwork is set. Tor will not make
 or accept non-control network connections. Shutting down all existing
 connections.
 10/20/19, 08:33:45.270 [NOTICE] DisableNetwork is set. Tor will not make
 or accept non-control network connections. Shutting down all existing
 connections.
 10/20/19, 08:33:45.270 [NOTICE] Opening Socks listener on 127.0.0.1:9150
 10/20/19, 08:33:45.271 [NOTICE] Opened Socks listener on 127.0.0.1:9150
 }}}
 That is, it loses the log lines from before the race between "start up"
 and "Tor browser finishes its controller connection".

 It would be cool to have a feature where Tor stores up these initial log
 lines, and then gives them to the controller when it's ready for them.

 comment:17 here describes a plausible way to do that, using mostly
 machinery that is already in place from #6938. We're close!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #10059 [Core Tor/Tor]: capture tor log messages before control connection is opened

[Tor Bug Tracker & Wiki]

#10059: capture tor log messages before control connection is opened
-+-
 Reporter:  mcs  |  Owner:  nickm
 Type:  enhancement  | Status:  new
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, extdev-interview, |  Actual Points:
  tbb-needs, 034-triage-20180328,|
  035-removed-20180711   |
Parent ID:  #9675| Points:  3
 Reviewer:   |Sponsor:
-+-
Changes (by gaba):

 * sponsor:  Sponsor8 =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #10059 [Core Tor/Tor]: capture tor log messages before control connection is opened

[Tor Bug Tracker & Wiki]

#10059: capture tor log messages before control connection is opened
-+-
 Reporter:  mcs  |  Owner:  nickm
 Type:  enhancement  | Status:  new
 Priority:  High |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, extdev-interview, |  Actual Points:
  tbb-needs, 034-triage-20180328 |
Parent ID:  #9675| Points:  3
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by nickm):

 * keywords:
 tbb-usability, extdev-interview, tbb-needs, 034-triage-20180328,
 034-removed-20180328
 => tbb-usability, extdev-interview, tbb-needs, 034-triage-20180328


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #10059 [Core Tor/Tor]: capture tor log messages before control connection is opened

[Tor Bug Tracker & Wiki]

#10059: capture tor log messages before control connection is opened
-+-
 Reporter:  mcs  |  Owner:  nickm
 Type:  enhancement  | Status:  new
 Priority:  High |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, extdev-interview, |  Actual Points:
  tbb-wants  |
Parent ID:  #9675| Points:  3
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by nickm):

 * priority:  Medium => High
 * sponsor:   => Sponsor8


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #10059 [Core Tor/Tor]: capture tor log messages before control connection is opened

[Tor Bug Tracker & Wiki]

#10059: capture tor log messages before control connection is opened
-+-
 Reporter:  mcs  |  Owner:  nickm
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, extdev-interview, |  Actual Points:
  tbb-wants  |
Parent ID:  #9675| Points:  3
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * milestone:  Tor: 0.3.2.x-final => Tor: 0.3.3.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #10059 [Core Tor/Tor]: capture tor log messages before control connection is opened

[Tor Bug Tracker & Wiki]

#10059: capture tor log messages before control connection is opened
-+-
 Reporter:  mcs  |  Owner:  nickm
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, extdev-interview, |  Actual Points:
  tbb-wants  |
Parent ID:  #9675| Points:  3
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * priority:  Low => Medium
 * points:   => 3
 * type:  defect => enhancement
 * milestone:  Tor: unspecified => Tor: 0.3.2.x-final


Comment:

 If this is still tbb-wants, we can do it in 0.3.2.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #10059 [Core Tor/Tor]: capture tor log messages before control connection is opened

[Tor Bug Tracker & Wiki]

#10059: capture tor log messages before control connection is opened
-+-
 Reporter:  mcs  |  Owner:  nickm
 Type:  defect   | Status:  new
 Priority:  Low  |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, extdev-interview, |  Actual Points:
  tor-03-unspecified-201612, tbb-wants   |
Parent ID:  #9675| Points:
 Reviewer:   |Sponsor:
-+-

Comment (by arma):

 Replying to [comment:9 nickm]:
 > I'm okay with doing an in-tor solution for this if you decide one is
 necessary; just let me know.  It would probably involve adding a log type
 that lets you store the last N kb of log messages in a queue, and later
 query them via the control port.

 For historical context, check out #6938 where we built something quite
 similar. So a lot of the structure for this goal already exists, should we
 choose to proceed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #10059 [Core Tor/Tor]: capture tor log messages before control connection is opened

[Tor Bug Tracker & Wiki]

#10059: capture tor log messages before control connection is opened
-+-
 Reporter:  mcs  |  Owner:  nickm
 Type:  defect   | Status:  new
 Priority:  Low  |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, extdev-interview, |  Actual Points:
  tor-03-unspecified-201612, tbb-wants   |
Parent ID:  #9675| Points:
 Reviewer:   |Sponsor:
-+-
Changes (by catalyst):

 * priority:  Medium => Low


Comment:

 Lowering priority for now; if #21542 turns out to not be suitable, we can
 bump it back up.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #10059 [Core Tor/Tor]: capture tor log messages before control connection is opened

[Tor Bug Tracker & Wiki]

#10059: capture tor log messages before control connection is opened
-+-
 Reporter:  mcs  |  Owner:  nickm
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, extdev-interview, |  Actual Points:
  tor-03-unspecified-201612, tbb-wants   |
Parent ID:  #9675| Points:
 Reviewer:   |Sponsor:
-+-

Comment (by mcs):

 If this is only needed by Tor Browser / Tor Launcher, please do not spend
 any time on it yet. We will come back and explore this solution if #21542
 does not work out.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #10059 [Core Tor/Tor]: capture tor log messages before control connection is opened

[Tor Bug Tracker & Wiki]

#10059: capture tor log messages before control connection is opened
-+-
 Reporter:  mcs  |  Owner:  nickm
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, extdev-interview, |  Actual Points:
  tor-03-unspecified-201612, tbb-wants   |
Parent ID:  #9675| Points:
 Reviewer:   |Sponsor:
-+-
Changes (by catalyst):

 * cc: catalyst (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #10059 [Core Tor/Tor]: capture tor log messages before control connection is opened

[Tor Bug Tracker & Wiki]

#10059: capture tor log messages before control connection is opened
-+-
 Reporter:  mcs  |  Owner:  nickm
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, extdev-interview, |  Actual Points:
  tor-03-unspecified-201612, tbb-wants   |
Parent ID:  #9675| Points:
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 Based on the way control events are queued today, I think it might be
 easiest to have tree command line option list which events are to be
 queued?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #10059 [Core Tor/Tor]: capture tor log messages before control connection is opened

[Tor Bug Tracker & Wiki]

#10059: capture tor log messages before control connection is opened
-+-
 Reporter:  mcs  |  Owner:  nickm
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, extdev-interview, |  Actual Points:
  tor-03-unspecified-201612, tbb-wants   |
Parent ID:  #9675| Points:
 Reviewer:   |Sponsor:
-+-
Changes (by asn):

 * cc: asn (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #10059 [Core Tor/Tor]: capture tor log messages before control connection is opened

[Tor Bug Tracker & Wiki]

#10059: capture tor log messages before control connection is opened
-+-
 Reporter:  mcs  |  Owner:  nickm
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, extdev-interview, |  Actual Points:
  tor-03-unspecified-201612, tbb-wants   |
Parent ID:  #9675| Points:
 Reviewer:   |Sponsor:
-+-

Comment (by arma):

 Replying to [comment:12 mcs]:
 > For Tor Launcher, it would be convenient to have a mechanism in tor such
 as the one you described. One tricky thing is that we would want to be
 sure Tor Launcher receives the entire, correct stream of messages (without
 duplicates or gaps), so we would need to figure out how to merge the
 queued messages with the ones we receive in response to SETEVENTS NOTICE
 WARN ERR. I am not sure how to do that unless tor assigns a sequence
 number or something similar to each message. Or it might work for tor to
 provide an option to send the queued messages as events as soon as the
 SETEVENTS command is received.

 In discussions with catalyst today, I think we hit upon a plausible
 approach: you start Tor with a config setting to enable this behavior, and
 then there's a single atomic controller command that a) pastes out all the
 queued messages to the controller, and b) stops queueing messages.

 So the controller would connect, issue SETEVENTS commands the way it
 wants, possibly getting a few new events, and then it would request the
 old events. It would know that the old events came before the new ones,
 and it would also know that there aren't any duplicates.

 Then Tor could keep on logging, sending events, etc just as it does now,
 but it would keep copies of them for when the controller comes asking.

 Plausible?

 For simplicity, we probably want to hard-code the types of events that get
 queued, rather than having the config option be flexible enough to hear
 which events you wanted. Or we could queue them all, and let the
 controller pick through them, but that could potentially get really big
 really quickly if it includes e.g. debug log events.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #10059 [Core Tor/Tor]: capture tor log messages before control connection is opened

[Tor Bug Tracker & Wiki]

#10059: capture tor log messages before control connection is opened
-+-
 Reporter:  mcs  |  Owner:  nickm
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, extdev-interview, |  Actual Points:
  tor-03-unspecified-201612, tbb-wants   |
Parent ID:  #9675| Points:
 Reviewer:   |Sponsor:
-+-

Comment (by mcs):

 Another solution would be for Tor Launcher to capture tor's stderr.
 Recently, Mozilla added a new "subprocess" module that may allow us to do
 that. I created #21542 to track this idea.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #10059 [Core Tor/Tor]: capture tor log messages before control connection is opened

[Tor Bug Tracker & Wiki]

#10059: capture tor log messages before control connection is opened
-+-
 Reporter:  mcs  |  Owner:  nickm
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, extdev-interview, |  Actual Points:
  tor-03-unspecified-201612, tbb-wants   |
Parent ID:  #9675| Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-usability, extdev-interview, tor-03-unspecified-201612 =>
 tbb-usability, extdev-interview, tor-03-unspecified-201612, tbb-wants


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs