Re: [tor-bugs] #12700 [Tor]: relay_command_to_string() doesn't know about EXTEND2 / EXTENDED2
#12700: relay_command_to_string() doesn't know about EXTEND2 / EXTENDED2 -+- Reporter: arma | Owner: Type: defect | Status: closed Priority: normal | Milestone: Tor: 0.2.5.x-final Component: Tor |Version: Resolution: fixed| Keywords: tor-relay 026-triaged-1 easy Actual Points: | 025-backport 024-backport Points: | Parent ID: -+- Changes (by nickm): * status: needs_review = closed * resolution: = fixed Comment: Merged to 0.2.5. -- Ticket URL: https://trac.torproject.org/projects/tor/ticket/12700#comment:8 Tor Bug Tracker Wiki https://trac.torproject.org/ The Tor Project: anonymity online ___ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
Re: [tor-bugs] #12700 [Tor]: relay_command_to_string() doesn't know about EXTEND2 / EXTENDED2
#12700: relay_command_to_string() doesn't know about EXTEND2 / EXTENDED2 -+- Reporter: arma | Owner: Type: defect | Status: needs_review Priority: normal | Milestone: Tor: 0.2.5.x-final Component: Tor |Version: Resolution: | Keywords: tor-relay 026-triaged-1 easy Actual Points: | 025-backport 024-backport Points: | Parent ID: -+- Changes (by nickm): * milestone: Tor: 0.2.6.x-final = Tor: 0.2.5.x-final Comment: merged to master; marking for possible backport. -- Ticket URL: https://trac.torproject.org/projects/tor/ticket/12700#comment:7 Tor Bug Tracker Wiki https://trac.torproject.org/ The Tor Project: anonymity online ___ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
Re: [tor-bugs] #12700 [Tor]: relay_command_to_string() doesn't know about EXTEND2 / EXTENDED2
#12700: relay_command_to_string() doesn't know about EXTEND2 / EXTENDED2 -+- Reporter: arma | Owner: Type: defect | Status: needs_review Priority: normal | Milestone: Tor: 0.2.6.x-final Component: Tor |Version: Resolution: | Keywords: tor-relay 026-triaged-1 easy Actual Points: | 025-backport 024-backport Points: | Parent ID: -+- Comment (by Sebastian): lgtm -- Ticket URL: https://trac.torproject.org/projects/tor/ticket/12700#comment:6 Tor Bug Tracker Wiki https://trac.torproject.org/ The Tor Project: anonymity online ___ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
Re: [tor-bugs] #12700 [Tor]: relay_command_to_string() doesn't know about EXTEND2 / EXTENDED2
#12700: relay_command_to_string() doesn't know about EXTEND2 / EXTENDED2 -+- Reporter: arma | Owner: Type: defect | Status: needs_review Priority: normal | Milestone: Tor: 0.2.6.x-final Component: Tor |Version: Resolution: | Keywords: tor-relay 026-triaged-1 easy Actual Points: | 025-backport 024-backport Points: | Parent ID: -+- Changes (by nickm): * status: new = needs_review Comment: Trivial fix in branch bug12700_024. -- Ticket URL: https://trac.torproject.org/projects/tor/ticket/12700#comment:5 Tor Bug Tracker Wiki https://trac.torproject.org/ The Tor Project: anonymity online ___ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
Re: [tor-bugs] #12700 [Tor]: relay_command_to_string() doesn't know about EXTEND2 / EXTENDED2
#12700: relay_command_to_string() doesn't know about EXTEND2 / EXTENDED2 -+- Reporter: arma | Owner: Type: defect | Status: new Priority: normal | Milestone: Tor: 0.2.6.x-final Component: Tor |Version: Resolution: | Keywords: tor-relay 026-triaged-1 easy Actual Points: | 025-backport 024-backport Points: | Parent ID: -+- Comment (by nickm): To be clear, the static char buffer would be for the `default:` case only, like we do in `conn_type_to_string()` and some other functions. (Somebody asked about this on IRC.) -- Ticket URL: https://trac.torproject.org/projects/tor/ticket/12700#comment:4 Tor Bug Tracker Wiki https://trac.torproject.org/ The Tor Project: anonymity online ___ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
Re: [tor-bugs] #12700 [Tor]: relay_command_to_string() doesn't know about EXTEND2 / EXTENDED2
#12700: relay_command_to_string() doesn't know about EXTEND2 / EXTENDED2 -+- Reporter: arma | Owner: Type: defect | Status: new Priority: normal | Milestone: Tor: 0.2.6.x-final Component: Tor |Version: Resolution: | Keywords: tor-relay 026-triaged-1 easy Actual Points: | 025-backport 024-backport Points: | Parent ID: -+- Changes (by nickm): * keywords: = tor-relay 026-triaged-1 easy 025-backport 024-backport -- Ticket URL: https://trac.torproject.org/projects/tor/ticket/12700#comment:3 Tor Bug Tracker Wiki https://trac.torproject.org/ The Tor Project: anonymity online ___ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
Re: [tor-bugs] #12700 [Tor]: relay_command_to_string() doesn't know about EXTEND2 / EXTENDED2
#12700: relay_command_to_string() doesn't know about EXTEND2 / EXTENDED2 + Reporter: arma| Owner: Type: defect | Status: new Priority: normal | Milestone: Tor: 0.2.6.x-final Component: Tor |Version: Resolution: | Keywords: Actual Points: | Parent ID: Points: | + Comment (by nickm): Right now it does `default: return (unrecognized);`. To make it a little more future-proof, you could add a static char buffer and sprintf into it on default? -- Ticket URL: https://trac.torproject.org/projects/tor/ticket/12700#comment:2 Tor Bug Tracker Wiki https://trac.torproject.org/ The Tor Project: anonymity online ___ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
[tor-bugs] #12700 [Tor]: relay_command_to_string() doesn't know about EXTEND2 / EXTENDED2
#12700: relay_command_to_string() doesn't know about EXTEND2 / EXTENDED2 + Reporter: arma| Owner: Type: defect | Status: new Priority: normal | Milestone: Tor: 0.2.6.x-final Component: Tor |Version: Keywords: | Actual Points: Parent ID: | Points: + Apparently we left them out on the big switch statement when we introduced them. We could add the two lines in -- that would be easy, and somebody should. The slightly more complicated question: is there a way to rephrase this function to future-proof it better against the next time we add a new relay command? -- Ticket URL: https://trac.torproject.org/projects/tor/ticket/12700 Tor Bug Tracker Wiki https://trac.torproject.org/ The Tor Project: anonymity online ___ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
Re: [tor-bugs] #12700 [Tor]: relay_command_to_string() doesn't know about EXTEND2 / EXTENDED2
#12700: relay_command_to_string() doesn't know about EXTEND2 / EXTENDED2 + Reporter: arma| Owner: Type: defect | Status: new Priority: normal | Milestone: Tor: 0.2.6.x-final Component: Tor |Version: Resolution: | Keywords: Actual Points: | Parent ID: Points: | + Description changed by arma: Old description: Apparently we left them out on the big switch statement when we introduced them. We could add the two lines in -- that would be easy, and somebody should. The slightly more complicated question: is there a way to rephrase this function to future-proof it better against the next time we add a new relay command? New description: Apparently we left EXTEND2 and EXTENDED2 out of this function's big switch statement when we introduced these relay commands. We could add the two lines in -- that would be easy, and somebody should. The slightly more complicated question: is there a way to rephrase this function to future-proof it better against the next time we add a new relay command? -- -- Ticket URL: https://trac.torproject.org/projects/tor/ticket/12700#comment:1 Tor Bug Tracker Wiki https://trac.torproject.org/ The Tor Project: anonymity online ___ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
