[tor-bugs] #12860 [Tor]: Couldn't format create cell warning can be triggered remotely for relayed cells
#12860: Couldn't format create cell warning can be triggered remotely for relayed cells -+- Reporter: cypherpunks | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: Tor |Version: Keywords: tor-relay| Actual Points: Parent ID: | Points: -+- If relay process extent request then it can to fill logs by warnings about wrongly formatted create cells. It's easy to reproduce such cells and to trigger logs for relay. {{{ if (r 0) { log_warn(LD_CIRC,Couldn't format create cell); return -1; } }}} It need lower logs level or rate limiting or LOG_PROTOCOL_WARN (preferable) for relayed cells. -- Ticket URL: https://trac.torproject.org/projects/tor/ticket/12860 Tor Bug Tracker Wiki https://trac.torproject.org/ The Tor Project: anonymity online ___ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
Re: [tor-bugs] #12860 [Tor]: Couldn't format create cell warning can be triggered remotely for relayed cells
#12860: Couldn't format create cell warning can be triggered remotely for relayed cells -+--- Reporter: cypherpunks | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: Tor |Version: Resolution: | Keywords: tor-relay Actual Points: | Parent ID: Points: | -+--- Comment (by cypherpunks): Unless it checked before by circuit_extend() {{{ if (extend_cell_parse(ec, rh.command, cell-payload+RELAY_HEADER_SIZE, rh.length) 0) { log_fn(LOG_PROTOCOL_WARN, LD_PROTOCOL, Can't parse extend cell. Closing circuit.); return -1; } }}} Then bug is invalid. -- Ticket URL: https://trac.torproject.org/projects/tor/ticket/12860#comment:1 Tor Bug Tracker Wiki https://trac.torproject.org/ The Tor Project: anonymity online ___ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
Re: [tor-bugs] #12860 [Tor]: Couldn't format create cell warning can be triggered remotely for relayed cells
#12860: Couldn't format create cell warning can be triggered remotely for relayed cells -+--- Reporter: cypherpunks | Owner: Type: defect | Status: closed Priority: normal | Milestone: Component: Tor |Version: Resolution: invalid | Keywords: tor-relay Actual Points: | Parent ID: Points: | -+--- Changes (by cypherpunks): * status: new = closed * resolution: = invalid Comment: Seems so. Sorry. check_create_cell() called by extend_cell_parse() which is generates create cell. -- Ticket URL: https://trac.torproject.org/projects/tor/ticket/12860#comment:2 Tor Bug Tracker Wiki https://trac.torproject.org/ The Tor Project: anonymity online ___ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs