Re: [tor-bugs] #13221 [Core Tor/Tor]: Misleading error messages about bind_ipv4_only and bind_ipv6_only?

[Tor Bug Tracker & Wiki]

#13221: Misleading error messages about bind_ipv4_only and bind_ipv6_only?
-+-
 Reporter:  arma |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Low  |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:  fixed
 Keywords:  041-proposed, tor-client, easy,  |  Actual Points:  .1
  logging, message, usability, 035-backport, |
  040-backport, consider-backport-after-0404 |
Parent ID:   | Points:  .1
 Reviewer:  teor |Sponsor:
-+-
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged to 0.3.5 and merged forward.

 Merged #23790, #29665, #29017, #27199, #29144, #13221, #28698.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13221 [Core Tor/Tor]: Misleading error messages about bind_ipv4_only and bind_ipv6_only?

[Tor Bug Tracker & Wiki]

#13221: Misleading error messages about bind_ipv4_only and bind_ipv6_only?
-+-
 Reporter:  arma |  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Low  |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  041-proposed, tor-client, easy,  |  Actual Points:  .1
  logging, message, usability, 035-backport, |
  040-backport, consider-backport-after-0404 |
Parent ID:   | Points:  .1
 Reviewer:  teor |Sponsor:
-+-
Changes (by teor):

 * keywords:
 041-proposed, tor-client, easy, logging, message, usability, 029
 -backport-maybe, 034-backport-maybe, 035-backport, 040-backport,
 consider-backport-after-0404
 =>
 041-proposed, tor-client, easy, logging, message, usability,
 035-backport, 040-backport, consider-backport-after-0404


Comment:

 UX issues only go back to the latest LTS.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13221 [Core Tor/Tor]: Misleading error messages about bind_ipv4_only and bind_ipv6_only?

[Tor Bug Tracker & Wiki]

#13221: Misleading error messages about bind_ipv4_only and bind_ipv6_only?
-+-
 Reporter:  arma |  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Low  |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  041-proposed, tor-client, easy,  |  Actual Points:  .1
  logging, message, usability, 029-backport- |
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport   |
Parent ID:   | Points:  .1
 Reviewer:  teor |Sponsor:
-+-
Changes (by nickm):

 * milestone:  Tor: 0.4.1.x-final => Tor: 0.3.5.x-final


Comment:

 merged to 0.4.0 and forward; marking for possible backport

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13221 [Core Tor/Tor]: Misleading error messages about bind_ipv4_only and bind_ipv6_only?

[Tor Bug Tracker & Wiki]

#13221: Misleading error messages about bind_ipv4_only and bind_ipv6_only?
-+-
 Reporter:  arma |  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Low  |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  041-proposed, tor-client, easy,  |  Actual Points:  .1
  logging, message, usability, 029-backport- |
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport   |
Parent ID:   | Points:  .1
 Reviewer:  teor |Sponsor:
-+-

Comment (by kjak):

 Awesome.  Thanks for reviewing!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13221 [Core Tor/Tor]: Misleading error messages about bind_ipv4_only and bind_ipv6_only?

[Tor Bug Tracker & Wiki]

#13221: Misleading error messages about bind_ipv4_only and bind_ipv6_only?
-+-
 Reporter:  arma |  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Low  |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  041-proposed, tor-client, easy,  |  Actual Points:  .1
  logging, message, usability, 029-backport- |
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport   |
Parent ID:   | Points:  .1
 Reviewer:  teor |Sponsor:
-+-
Changes (by teor):

 * status:  needs_review => merge_ready


Comment:

 Thanks! Looks good to me, and CI likes it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13221 [Core Tor/Tor]: Misleading error messages about bind_ipv4_only and bind_ipv6_only?

[Tor Bug Tracker & Wiki]

#13221: Misleading error messages about bind_ipv4_only and bind_ipv6_only?
-+-
 Reporter:  arma |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Low  |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  041-proposed, tor-client, easy,  |  Actual Points:  .1
  logging, message, usability, 029-backport- |
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport   |
Parent ID:   | Points:  .1
 Reviewer:  teor |Sponsor:
-+-
Changes (by kjak):

 * cc: katterjohn@… (added)
 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:10 teor]:
 > Would you mind rebasing your patch on our maint-0.2.9 branch?
 > If you can't, just let us know, and we'll do it eventually.

 This taught me that my git-fu is even weaker than I thought it was, but it
 looks like I managed to do it.  I rebased on maint-0.2.9 and here is a new
 PR:

 https://github.com/torproject/tor/pull/726

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13221 [Core Tor/Tor]: Misleading error messages about bind_ipv4_only and bind_ipv6_only?

[Tor Bug Tracker & Wiki]

#13221: Misleading error messages about bind_ipv4_only and bind_ipv6_only?
-+-
 Reporter:  arma |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Low  |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  041-proposed, tor-client, easy,  |  Actual Points:  .1
  logging, message, usability, 029-backport- |
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport   |
Parent ID:   | Points:  .1
 Reviewer:  teor |Sponsor:
-+-
Changes (by teor):

 * status:  needs_review => needs_revision
 * keywords:  041-proposed, tor-client, easy, logging, message, usability =>
 041-proposed, tor-client, easy, logging, message, usability, 029
 -backport-maybe, 034-backport-maybe, 035-backport, 040-backport
 * milestone:  Tor: unspecified => Tor: 0.4.1.x-final
 * version:   => Tor: 0.2.3.9-alpha
 * actualpoints:   => .1


Comment:

 Hi,

 Thanks for this pull request.

 Sorry it's taken a while for us to get to it: many of us were at a
 hackfest in January, then on leave.

 Replying to [comment:8 kjak]:
 > Here is a PR to fix this: https://github.com/torproject/tor/pull/669
 >
 > I didn't change the overall wording of the error message because
 personally I think it's fine (aside from the IP version mixup).  I think
 it's short and clear and means "You told me to only bind to an IPv4
 address but I couldn't interpret the address as IPv4."
 >
 > I took the liberty of also cleaning up the error-checking logic to make
 it a little more precise about what is being checked.  I hope that's OK.

 It looks good to me.

 > (I'm also adding the keyword 041-proposed, which my other recent tickets
 got.  Is it OK for me to do that or is adding a keyword like that reserved
 for core team members?)

 Yes, that's fine. We're still experimenting with our proposed tickets
 process.

 Review:

 There was a failure in one of the jobs due to our stochastic random tests.
 I re-ran the job and it was fine.

 This patch fixes an error that's been around since 2011.
 It's confusing to relay operators, so it is a backport candidate.

 Would you mind rebasing your patch on our maint-0.2.9 branch?
 If you can't, just let us know, and we'll do it eventually.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13221 [Core Tor/Tor]: Misleading error messages about bind_ipv4_only and bind_ipv6_only?

[Tor Bug Tracker & Wiki]

#13221: Misleading error messages about bind_ipv4_only and bind_ipv6_only?
-+-
 Reporter:  arma |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Low  |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  041-proposed, tor-client, easy,  |  Actual Points:
  logging, message, usability|
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-
Changes (by kjak):

 * status:  new => needs_review
 * keywords:  tor-client, easy, logging, message, usability => 041-proposed,
 tor-client, easy, logging, message, usability


Comment:

 Here is a PR to fix this: https://github.com/torproject/tor/pull/669

 I didn't change the overall wording of the error message because
 personally I think it's fine (aside from the IP version mixup).  I think
 it's short and clear and means "You told me to only bind to an IPv4
 address but I couldn't interpret the address as IPv4."

 I took the liberty of also cleaning up the error-checking logic to make it
 a little more precise about what is being checked.  I hope that's OK.

 (I'm also adding the keyword 041-proposed, which my other recent tickets
 got.  Is it OK for me to do that or is adding a keyword like that reserved
 for core team members?)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13221 [Core Tor/Tor]: Misleading error messages about bind_ipv4_only and bind_ipv6_only?

[Tor Bug Tracker & Wiki]

#13221: Misleading error messages about bind_ipv4_only and bind_ipv6_only?
-+-
 Reporter:  arma |  Owner:
 Type:  defect   | Status:  new
 Priority:  Low  |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, easy, logging, message,  |  Actual Points:
  usability  |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  tor-client, lorax => tor-client, easy, logging, message,
 usability
 * points:   => .1
 * severity:   => Normal


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs