Re: [tor-bugs] #13893 [Applications/Tor Browser]: Torbrowser crashes on start when using MS EMET 5.x

[Tor Bug Tracker & Wiki]

#13893: Torbrowser crashes on start when using MS EMET 5.x
-+-
 Reporter:  Diapolo  |  Owner:  gk
 Type:  defect   | Status:
 |  reopened
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-security, tbb-crash, tbb-|  Actual Points:
  usability-stoppoint-app, fuck-mingw-gcc,   |
  GeorgKoppen201609, TorBrowserTeam201610,   |
  ff52-esr   |
Parent ID:  #12820   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Malwarebytes terminates Firefox 58 due to "RET ROP Gadget detection" too.
 https://bugzilla.mozilla.org/show_bug.cgi?id=1418594
 But MoCo still thinks "the problem is on your side", heh.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13893 [Applications/Tor Browser]: Torbrowser crashes on start when using MS EMET 5.x

[Tor Bug Tracker & Wiki]

#13893: Torbrowser crashes on start when using MS EMET 5.x
-+-
 Reporter:  Diapolo  |  Owner:  gk
 Type:  defect   | Status:
 |  reopened
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-security, tbb-crash, tbb-|  Actual Points:
  usability-stoppoint-app, fuck-mingw-gcc,   |
  GeorgKoppen201609, TorBrowserTeam201610,   |
  ff52-esr   |
Parent ID:  #12820   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Microsoft uses Application Compatibility shims (DLL injection) to
 implement most of the functionality in products such as the Enhanced
 Mitigation Experience Toolkit (EMET):
 https://www.blackhat.com/docs/eu-15/materials/eu-15-Pierce-Defending-
 Against-Malicious-Application-Compatibility-Shims-wp.pdf

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13893 [Applications/Tor Browser]: Torbrowser crashes on start when using MS EMET 5.x

[Tor Bug Tracker & Wiki]

#13893: Torbrowser crashes on start when using MS EMET 5.x
-+-
 Reporter:  Diapolo  |  Owner:  gk
 Type:  defect   | Status:
 |  reopened
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-security, tbb-crash, tbb-|  Actual Points:
  usability-stoppoint-app, fuck-mingw-gcc,   |
  GeorgKoppen201609, TorBrowserTeam201610,   |
  ff52-esr   |
Parent ID:  #12820   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by cypherpunks):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Replying to [comment:94 gk]:
 > We'll update the compiler to GCC 6.4.0 in the next alpha (8.0a6) which
 should fix this issue.
 Wrong. See comment:87.
 > Please, open a new one if there are still outstanding problems.
 It would make sense if you were talking about new problems.
 But here we deal with the old problem which now also causes a startup
 crash of sandboxed firefox.exe.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13893 [Applications/Tor Browser]: Torbrowser crashes on start when using MS EMET 5.x

[Tor Bug Tracker & Wiki]

#13893: Torbrowser crashes on start when using MS EMET 5.x
-+-
 Reporter:  Diapolo  |  Owner:  gk
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:  fixed
 Keywords:  tbb-security, tbb-crash, tbb-|  Actual Points:
  usability-stoppoint-app, fuck-mingw-gcc,   |
  GeorgKoppen201609, TorBrowserTeam201610,   |
  ff52-esr   |
Parent ID:  #12820   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 We'll update the compiler to GCC 6.4.0 in the next alpha (8.0a6) which
 should fix this issue. Please, open a new one if there are still
 outstanding problems.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13893 [Applications/Tor Browser]: Torbrowser crashes on start when using MS EMET 5.x

[Tor Bug Tracker & Wiki]

#13893: Torbrowser crashes on start when using MS EMET 5.x
-+-
 Reporter:  Diapolo  |  Owner:  gk
 Type:  defect   | Status:
 |  reopened
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-security, tbb-crash, tbb-|  Actual Points:
  usability-stoppoint-app, fuck-mingw-gcc,   |
  GeorgKoppen201609, TorBrowserTeam201610,   |
  ff52-esr   |
Parent ID:  #12820   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:91 gk]:
 > Replying to [comment:90 bugzilla]:
 > > WOW, something happened with gk, and he decided to build 7.0a3 with
 `-fno-omit-frame-pointer` to stop messing with CPU register, and it
 helped!!!
 > > (Of course, AvailableMemoryTracker continues to be a crap, and
 WindowsDllInterceptor should be analyzed for creating RWX holes, but it is
 another story ;)
 >
 > Mozilla did that, not I. Have a look at:
 https://bugzilla.mozilla.org/show_bug.cgi?id=1322735. That said it won't
 help with 64bit builds which we hope to get started soon.

 Not only that. There seems to be the e10s/sandboxing part breaking EMET
 (again), see: https://blog.torproject.org/tor-
 browser-75-released?page=1#comment-273658.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13893 [Applications/Tor Browser]: Torbrowser crashes on start when using MS EMET 5.x

[Tor Bug Tracker & Wiki]

#13893: Torbrowser crashes on start when using MS EMET 5.x
-+-
 Reporter:  Diapolo  |  Owner:  gk
 Type:  defect   | Status:
 |  reopened
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-security, tbb-crash, tbb-|  Actual Points:
  usability-stoppoint-app, fuck-mingw-gcc,   |
  GeorgKoppen201609, TorBrowserTeam201610,   |
  ff52-esr   |
Parent ID:  #12820   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by cypherpunks):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Reopen then.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13893 [Applications/Tor Browser]: Torbrowser crashes on start when using MS EMET 5.x

[Tor Bug Tracker & Wiki]

#13893: Torbrowser crashes on start when using MS EMET 5.x
-+-
 Reporter:  Diapolo  |  Owner:  gk
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:  fixed
 Keywords:  tbb-security, tbb-crash, tbb-|  Actual Points:
  usability-stoppoint-app, fuck-mingw-gcc,   |
  GeorgKoppen201609, TorBrowserTeam201610,   |
  ff52-esr   |
Parent ID:  #12820   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:90 bugzilla]:
 > WOW, something happened with gk, and he decided to build 7.0a3 with
 `-fno-omit-frame-pointer` to stop messing with CPU register, and it
 helped!!!
 > (Of course, AvailableMemoryTracker continues to be a crap, and
 WindowsDllInterceptor should be analyzed for creating RWX holes, but it is
 another story ;)

 Mozilla did that, not I. Have a look at:
 https://bugzilla.mozilla.org/show_bug.cgi?id=1322735. That said it won't
 help with 64bit builds which we hope to get started soon.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13893 [Applications/Tor Browser]: Torbrowser crashes on start when using MS EMET 5.x

[Tor Bug Tracker & Wiki]

#13893: Torbrowser crashes on start when using MS EMET 5.x
-+-
 Reporter:  Diapolo  |  Owner:  gk
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:  fixed
 Keywords:  tbb-security, tbb-crash, tbb-|  Actual Points:
  usability-stoppoint-app, fuck-mingw-gcc,   |
  GeorgKoppen201609, TorBrowserTeam201610,   |
  ff52-esr   |
Parent ID:  #12820   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by bugzilla):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 WOW, something happened with gk, and he decided to build 7.0a3 with `-fno-
 omit-frame-pointer` to stop messing with CPU register, and it helped!!!
 (Of course, AvailableMemoryTracker continues to be a crap, and
 WindowsDllInterceptor should be analyzed for creating RWX holes, but it is
 another story ;)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13893 [Applications/Tor Browser]: Torbrowser crashes on start when using MS EMET 5.x

[Tor Bug Tracker & Wiki]

#13893: Torbrowser crashes on start when using MS EMET 5.x
-+-
 Reporter:  Diapolo  |  Owner:  gk
 Type:  defect   | Status:
 |  reopened
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-security, tbb-crash, tbb-|  Actual Points:
  usability-stoppoint-app, fuck-mingw-gcc,   |
  GeorgKoppen201609, TorBrowserTeam201610,   |
  ff52-esr   |
Parent ID:  #12820   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by Diapolo):

 * cc: phil.kaufmann@… (removed)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13893 [Applications/Tor Browser]: Torbrowser crashes on start when using MS EMET 5.x

[Tor Bug Tracker & Wiki]

#13893: Torbrowser crashes on start when using MS EMET 5.x
-+-
 Reporter:  Diapolo  |  Owner:  gk
 Type:  defect   | Status:
 |  reopened
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-security, tbb-crash, tbb-|  Actual Points:
  usability-stoppoint-app, fuck-mingw-gcc,   |
  GeorgKoppen201609, TorBrowserTeam201610,   |
  ff52-esr   |
Parent ID:  #12820   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:87 bugzilla]:
 > Replying to [comment:86 gk]:
 > > Replying to [comment:85 bugzilla]:
 > > > Replying to [comment:84 gk]:
 > > > > I think Tor Browser started for all of them (see comment:73,
 comment:75 and I tested it on my machines as well) and it worked with GCC
 6 while it did not without it.
 > > > Have you reverted https://hg.mozilla.org/releases/mozilla-
 aurora/rev/7d7176ca2470 to test `IOInterposer`?
 > > No.
 > > > Have you seen the requirements for invoking
 `AvailableMemoryTracker`?
 > > Yes. Not sure what you want to point out.
 > That you didn't make the conditions to properly test for
 VirtualProtectEx calls.
 > >
 > > No. But what I did was compiling our latest 45.4.0esr code once with
 GCC < 6 and once with GCC 6 and the latter allowed me to run Tor Browser
 with EMET while the former not. *All* other things were equal.
 > If EMET can't detect vulnerabilities at startup, it doesn't mean they
 are gone.

 Not sure what you mean. The difference I outlined is the one between a not
 working Tor Browser (compiled with GCC < 6) with EMET protections enabled
 and one that does work (compiled with GCC 6) while *all* other conditions
 are equal. And it is not about start-up only I tested the build while
 surfing for a while.

 > > > TBB freezes with EAF, nothing to discuss.
 > >
 > > You mean the nightly build I pointed you to? That worked pretty fine
 for me with all the EMET features enabled. Others reported that as well
 (and I assume they had all features enabled, too).
 > >
 > It's about security, not bells and whistles with shiny checkboxes to
 enable them all. You can't activate some features without entering custom
 values.
 > Any app freezes with EAF, even M$ sees it (see
 https://support.microsoft.com/en-us/kb/3175024).
 > Here is your nightly (plugin-container.exe):
 > {{{
 >   CodeAddress : 0x5B387DC7
 >   CodeStackPtr: 0x51ECA0
 >   CalledAddress   : 0x75BF0479
 >   API name: kernel32.VirtualProtectEx
 >   StackPtr: 0x0051EC20
 >   FramePtr: 0x5CCE3324
 > }}}

 Works fine for me on my testing machines while the versions compiled with
 GCC < 6 are broken. EAF *is* enabled for what it is worth. So, maybe my
 machines are missing the Microsoft update that breaks EMET? But if that's
 the case and this is indeed affecting *any* application as you mentioned
 then there is nothing we can do from Tor Browser land to fix that. We can
 only mention it in #12820 I guess.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13893 [Applications/Tor Browser]: Torbrowser crashes on start when using MS EMET 5.x

[Tor Bug Tracker & Wiki]

#13893: Torbrowser crashes on start when using MS EMET 5.x
-+-
 Reporter:  Diapolo  |  Owner:  gk
 Type:  defect   | Status:
 |  reopened
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-security, tbb-crash, tbb-|  Actual Points:
  usability-stoppoint-app, fuck-mingw-gcc,   |
  GeorgKoppen201609, TorBrowserTeam201610,   |
  ff52-esr   |
Parent ID:  #12820   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by bugzilla):

 Replying to [comment:86 gk]:
 > Replying to [comment:85 bugzilla]:
 > > Replying to [comment:84 gk]:
 > > > I think Tor Browser started for all of them (see comment:73,
 comment:75 and I tested it on my machines as well) and it worked with GCC
 6 while it did not without it.
 > > Have you reverted https://hg.mozilla.org/releases/mozilla-
 aurora/rev/7d7176ca2470 to test `IOInterposer`?
 > No.
 > > Have you seen the requirements for invoking `AvailableMemoryTracker`?
 > Yes. Not sure what you want to point out.
 That you didn't make the conditions to properly test for VirtualProtectEx
 calls.
 >
 > No. But what I did was compiling our latest 45.4.0esr code once with GCC
 < 6 and once with GCC 6 and the latter allowed me to run Tor Browser with
 EMET while the former not. *All* other things were equal.
 If EMET can't detect vulnerabilities at startup, it doesn't mean they are
 gone.
 > > TBB freezes with EAF, nothing to discuss.
 >
 > You mean the nightly build I pointed you to? That worked pretty fine for
 me with all the EMET features enabled. Others reported that as well (and I
 assume they had all features enabled, too).
 >
 It's about security, not bells and whistles with shiny checkboxes to
 enable them all. You can't activate some features without entering custom
 values.
 Any app freezes with EAF, even M$ sees it (see
 https://support.microsoft.com/en-us/kb/3175024).
 Here is your nightly (plugin-container.exe):
 {{{
   CodeAddress   : 0x5B387DC7
   CodeStackPtr  : 0x51ECA0
   CalledAddress : 0x75BF0479
   API name  : kernel32.VirtualProtectEx
   StackPtr  : 0x0051EC20
   FramePtr  : 0x5CCE3324
 }}}
 (You haven't answered why you use debug `-g` on Windows stable.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13893 [Applications/Tor Browser]: Torbrowser crashes on start when using MS EMET 5.x

[Tor Bug Tracker & Wiki]

#13893: Torbrowser crashes on start when using MS EMET 5.x
-+-
 Reporter:  Diapolo  |  Owner:  gk
 Type:  defect   | Status:
 |  reopened
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-security, tbb-crash, tbb-|  Actual Points:
  usability-stoppoint-app, fuck-mingw-gcc,   |
  GeorgKoppen201609, TorBrowserTeam201610,   |
  ff52-esr   |
Parent ID:  #12820   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:85 bugzilla]:
 > Replying to [comment:84 gk]:
 > > I think Tor Browser started for all of them (see comment:73,
 comment:75 and I tested it on my machines as well) and it worked with GCC
 6 while it did not without it.
 > Have you seen the requirements for invoking `AvailableMemoryTracker`?

 Yes. Not sure what you want to point out.

 > Have you reverted https://hg.mozilla.org/releases/mozilla-
 aurora/rev/7d7176ca2470 to test `IOInterposer`?

 No. But what I did was compiling our latest 45.4.0esr code once with GCC <
 6 and once with GCC 6 and the latter allowed me to run Tor Browser with
 EMET while the former not. *All* other things were equal.

 > TBB freezes with EAF, nothing to discuss.

 You mean the nightly build I pointed you to? That worked pretty fine for
 me with all the EMET features enabled. Others reported that as well (and I
 assume they had all features enabled, too).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13893 [Applications/Tor Browser]: Torbrowser crashes on start when using MS EMET 5.x

[Tor Bug Tracker & Wiki]

#13893: Torbrowser crashes on start when using MS EMET 5.x
-+-
 Reporter:  Diapolo  |  Owner:  gk
 Type:  defect   | Status:
 |  reopened
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-security, tbb-crash, tbb-|  Actual Points:
  usability-stoppoint-app, fuck-mingw-gcc,   |
  GeorgKoppen201609, TorBrowserTeam201610,   |
  ff52-esr   |
Parent ID:  #12820   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by bugzilla):

 Replying to [comment:84 gk]:
 > I think Tor Browser started for all of them (see comment:73, comment:75
 and I tested it on my machines as well) and it worked with GCC 6 while it
 did not without it.
 Have you seen the requirements for invoking `AvailableMemoryTracker`?
 Have you reverted https://hg.mozilla.org/releases/mozilla-
 aurora/rev/7d7176ca2470 to test `IOInterposer`?
 TBB freezes with EAF, nothing to discuss.
 GCC could improve optimized code with `-g`, but it's not suitable for
 release.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13893 [Applications/Tor Browser]: Torbrowser crashes on start when using MS EMET 5.x

[Tor Bug Tracker & Wiki]

#13893: Torbrowser crashes on start when using MS EMET 5.x
-+-
 Reporter:  Diapolo  |  Owner:  gk
 Type:  defect   | Status:
 |  reopened
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-security, tbb-crash, tbb-|  Actual Points:
  usability-stoppoint-app, fuck-mingw-gcc,   |
  GeorgKoppen201609, TorBrowserTeam201610,   |
  ff52-esr   |
Parent ID:  #12820   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:83 bugzilla]:
 > Newer GCC is a good way to reveal bugs, not to fix, and it's not needed
 if nobody is going to fix them. So nothing has changed, it didn't work
 anyways.
 > It wasn't discovered by testers as
 > > the application freezes very early in the process and does not
 completely start
 > because of ticket:18935#comment:24

 I think Tor Browser started for all of them (see comment:73, comment:75
 and I tested it on my machines as well) and it worked with GCC 6 while it
 did not without it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13893 [Applications/Tor Browser]: Torbrowser crashes on start when using MS EMET 5.x

[Tor Bug Tracker & Wiki]

#13893: Torbrowser crashes on start when using MS EMET 5.x
-+-
 Reporter:  Diapolo  |  Owner:  gk
 Type:  defect   | Status:
 |  reopened
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-security, tbb-crash, tbb-|  Actual Points:
  usability-stoppoint-app, fuck-mingw-gcc,   |
  GeorgKoppen201609, TorBrowserTeam201610,   |
  ff52-esr   |
Parent ID:  #12820   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by bugzilla):

 OK, as nobody cares, then some updates on my comments only:
 `AvailableMemoryTracker` appeared to be a bad thing, despite the
 underlying bug was fixed. Moz devs wondered why they got so few report
 from it by their Telemetry, that's because it hangs the browser reliably
 after several calls.
 Newer GCC is a good way to reveal bugs, not to fix, and it's not needed if
 nobody is going to fix them. So nothing has changed, it didn't work
 anyways.
 It wasn't discovered by testers as
 > the application freezes very early in the process and does not
 completely start
 because of ticket:18935#comment:24
 About `LoadLibraryW`: `PR_LD_LAZY`
 P.S. default for FF is `-Os` or without `-g`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13893 [Applications/Tor Browser]: Torbrowser crashes on start when using MS EMET 5.x

[Tor Bug Tracker & Wiki]

#13893: Torbrowser crashes on start when using MS EMET 5.x
-+-
 Reporter:  Diapolo  |  Owner:  gk
 Type:  defect   | Status:
 |  reopened
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-security, tbb-crash, tbb-|  Actual Points:
  usability-stoppoint-app, fuck-mingw-gcc,   |
  GeorgKoppen201609, TorBrowserTeam201610,   |
  ff52-esr   |
Parent ID:  #12820   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * sponsor:  SponsorU =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13893 [Applications/Tor Browser]: Torbrowser crashes on start when using MS EMET 5.x

[Tor Bug Tracker & Wiki]

#13893: Torbrowser crashes on start when using MS EMET 5.x
-+-
 Reporter:  Diapolo  |  Owner:  gk
 Type:  defect   | Status:
 |  reopened
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-security, tbb-crash, tbb-|  Actual Points:
  usability-stoppoint-app, fuck-mingw-gcc,   |
  GeorgKoppen201609, TorBrowserTeam201610,   |
  ff52-esr   |
Parent ID:  #12820   | Points:
 Reviewer:   |Sponsor:
 |  SponsorU
-+-
Changes (by gk):

 * status:  closed => reopened
 * keywords:
 tbb-security, tbb-crash, tbb-usability-stoppoint-app, fuck-mingw-gcc,
 GeorgKoppen201609, TorBrowserTeam201610R
 =>
 tbb-security, tbb-crash, tbb-usability-stoppoint-app, fuck-mingw-gcc,
 GeorgKoppen201609, TorBrowserTeam201610, ff52-esr
 * resolution:  fixed =>


Comment:

 We need to wait for switching to GCC 6 as Firefox is not ready yet. :( See
 #20381 for more details. We should revisit the state of GCC 6 support when
 we switch to Firefox 52 ESR.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13893 [Applications/Tor Browser]: Torbrowser crashes on start when using MS EMET 5.x

[Tor Bug Tracker & Wiki]

#13893: Torbrowser crashes on start when using MS EMET 5.x
-+-
 Reporter:  Diapolo  |  Owner:  gk
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:  fixed
 Keywords:  tbb-security, tbb-crash, tbb-|  Actual Points:
  usability-stoppoint-app, fuck-mingw-gcc,   |
  GeorgKoppen201609, TorBrowserTeam201610R   |
Parent ID:  #12820   | Points:
 Reviewer:   |Sponsor:
 |  SponsorU
-+-

Comment (by bugzilla):

 Do you want to see the truth?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13893 [Applications/Tor Browser]: Torbrowser crashes on start when using MS EMET 5.x

[Tor Bug Tracker & Wiki]

#13893: Torbrowser crashes on start when using MS EMET 5.x
-+-
 Reporter:  Diapolo  |  Owner:  gk
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:  fixed
 Keywords:  tbb-security, tbb-crash, tbb-|  Actual Points:
  usability-stoppoint-app, fuck-mingw-gcc,   |
  GeorgKoppen201609, TorBrowserTeam201610R   |
Parent ID:  #12820   | Points:
 Reviewer:   |Sponsor:
 |  SponsorU
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 I applied the tor-browser-bundle patch to master
 (0348263efd1cb8a9eca8737f3dc7734ef75e0966) and the tor browser ones to
 tor-browser-45.4.0esr-6.5-1 (ef6b1ceff3996006497ebbdbd02104031eaf64f5,
 e2e11538f13e7eb4aa8bd9daf8f3d89c1434c1ef, and
 08136fae2fb1fb6b6713b0821c8cf6ea5666d192).

 Thanks to all who followed along and helped fixing this bug!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13893 [Applications/Tor Browser]: Torbrowser crashes on start when using MS EMET 5.x

[Tor Bug Tracker & Wiki]

#13893: Torbrowser crashes on start when using MS EMET 5.x
-+-
 Reporter:  Diapolo  |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-security, tbb-crash, tbb-|  Actual Points:
  usability-stoppoint-app, fuck-mingw-gcc,   |
  GeorgKoppen201609, TorBrowserTeam201610R   |
Parent ID:  #12820   | Points:
 Reviewer:   |Sponsor:
 |  SponsorU
-+-

Comment (by mcs):

 r=mcs
 Both the tor-browser and tor-browser-bundle changes look okay as far as I
 can tell.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13893 [Applications/Tor Browser]: Torbrowser crashes on start when using MS EMET 5.x

[Tor Bug Tracker & Wiki]

#13893: Torbrowser crashes on start when using MS EMET 5.x
-+-
 Reporter:  Diapolo  |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-security, tbb-crash, tbb-|  Actual Points:
  usability-stoppoint-app, fuck-mingw-gcc,   |
  GeorgKoppen201609, TorBrowserTeam201610R   |
Parent ID:  #12820   | Points:
 Reviewer:   |Sponsor:
 |  SponsorU
-+-

Comment (by cypherpunx):

 Your nightly works also on Windows 7 32 bit with EMET 5.1.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13893 [Applications/Tor Browser]: Torbrowser crashes on start when using MS EMET 5.x

[Tor Bug Tracker & Wiki]

#13893: Torbrowser crashes on start when using MS EMET 5.x
-+-
 Reporter:  Diapolo  |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-security, tbb-crash, tbb-|  Actual Points:
  usability-stoppoint-app, fuck-mingw-gcc,   |
  GeorgKoppen201609, TorBrowserTeam201609R   |
Parent ID:  #12820   | Points:
 Reviewer:   |Sponsor:
 |  SponsorU
-+-
Changes (by gk):

 * keywords:
 tbb-security, tbb-crash, tbb-usability-stoppoint-app, fuck-mingw-gcc,
 GeorgKoppen201609, TorBrowserTeam201609
 =>
 tbb-security, tbb-crash, tbb-usability-stoppoint-app, fuck-mingw-gcc,
 GeorgKoppen201609, TorBrowserTeam201609R
 * status:  needs_revision => needs_review


Comment:

 Alright, the tor-browser patches have not changed. They can still be found
 at

 https://gitweb.torproject.org/user/gk/tor-browser.git/log/?h=bug_13893_v3

 The tor-browser-bundle commit up for review is now

 https://gitweb.torproject.org/user/gk/tor-browser-
 bundle.git/commit/?h=bug_13893_v5=70ea13b3e3dc09c317be02d8d07eb175547f2d2b

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13893 [Applications/Tor Browser]: Torbrowser crashes on start when using MS EMET 5.x

[Tor Bug Tracker & Wiki]

#13893: Torbrowser crashes on start when using MS EMET 5.x
-+-
 Reporter:  Diapolo  |  Owner:  gk
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-security, tbb-crash, tbb-|  Actual Points:
  usability-stoppoint-app, fuck-mingw-gcc,   |
  GeorgKoppen201609, TorBrowserTeam201609|
Parent ID:  #12820   | Points:
 Reviewer:   |Sponsor:
 |  SponsorU
-+-
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:
 tbb-security, tbb-crash, tbb-usability-stoppoint-app, fuck-mingw-gcc,
 GeorgKoppen201609, TorBrowserTeam201609R
 =>
 tbb-security, tbb-crash, tbb-usability-stoppoint-app, fuck-mingw-gcc,
 GeorgKoppen201609, TorBrowserTeam201609


Comment:

 \o/ and thanks for the report back. Let me produce a proper patch then...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13893 [Applications/Tor Browser]: Torbrowser crashes on start when using MS EMET 5.x

[Tor Bug Tracker & Wiki]

#13893: Torbrowser crashes on start when using MS EMET 5.x
-+-
 Reporter:  Diapolo  |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-security, tbb-crash, tbb-|  Actual Points:
  usability-stoppoint-app, fuck-mingw-gcc,   |
  GeorgKoppen201609, TorBrowserTeam201609R   |
Parent ID:  #12820   | Points:
 Reviewer:   |Sponsor:
 |  SponsorU
-+-

Comment (by Diapolo):

 @gk I verified that you were able to fix this bug, by testing your nightly
 on Win7 EMET 5.2 and Win8.1 EMET 5.51. 6.5a3 (based on Mozilla Firefox
 45.4.0) is still suffering the bug, I cross-verified that also.

 Thanks for your work :)!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13893 [Applications/Tor Browser]: Torbrowser crashes on start when using MS EMET 5.x

[Tor Bug Tracker & Wiki]

#13893: Torbrowser crashes on start when using MS EMET 5.x
-+-
 Reporter:  Diapolo  |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-security, tbb-crash, tbb-|  Actual Points:
  usability-stoppoint-app, fuck-mingw-gcc,   |
  GeorgKoppen201609, TorBrowserTeam201609R   |
Parent ID:  #12820   | Points:
 Reviewer:   |Sponsor:
 |  SponsorU
-+-
Changes (by gk):

 * keywords:
 tbb-security, tbb-crash, tbb-usability-stoppoint-app, fuck-mingw-gcc,
 GeorgKoppen201609, TorBrowserTeam201609
 =>
 tbb-security, tbb-crash, tbb-usability-stoppoint-app, fuck-mingw-gcc,
 GeorgKoppen201609, TorBrowserTeam201609R
 * status:  needs_information => needs_review


Comment:

 I prepared branches for review. The tor-browser one is:

 https://gitweb.torproject.org/user/gk/tor-browser.git/log/?h=bug_13893_v3

 which contains three fixes for GCC 6 compat. The relevant tor-browser-
 bundle commit is:

 https://gitweb.torproject.org/user/gk/tor-browser-
 bundle.git/commit/?h=bug_13893_v4=ce775578f0dcdf79d4517c90b3c39804d1dea4e0

 (Note: the latter is missing the pointer to the tor-browser bug_13893_v3
 branch in my repo. That needs to get adjusted while testing).

 I'd still like to hear feedback about whether my nightly build in
 comment:71 fixes the problem.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13893 [Applications/Tor Browser]: Torbrowser crashes on start when using MS EMET 5.x

[Tor Bug Tracker & Wiki]

#13893: Torbrowser crashes on start when using MS EMET 5.x
-+-
 Reporter:  Diapolo  |  Owner:  gk
 Type:  defect   | Status:
 |  needs_information
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-security, tbb-crash, tbb-|  Actual Points:
  usability-stoppoint-app, fuck-mingw-gcc,   |
  GeorgKoppen201609, TorBrowserTeam201609|
Parent ID:  #12820   | Points:
 Reviewer:   |Sponsor:
 |  SponsorU
-+-
Changes (by gk):

 * status:  needs_revision => needs_information


Comment:

 Okay, I seem to have a test build that fixes things for me. Could other
 EMET users that got hit by crashes test that one as well and report back
 whether there are still issues? It can be found on:

 https://people.torproject.org/~gk/testbuilds/torbrowser-install-tbb-
 nightly_62_ALL.exe
 https://people.torproject.org/~gk/testbuilds/torbrowser-install-tbb-
 nightly_62_ALL.exe.asc

 It uses the latest mingw-w64 and underneath GCC 6.2.0. I got it to compile
 our stuff after some pain and my current hypothesis is that the
 optimization bug got fixed in the GCC's 6.x series. I tested that with
 EMET 5.51 on a Windows 7 machine.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13893 [Applications/Tor Browser]: Torbrowser crashes on start when using MS EMET 5.x

[Tor Bug Tracker & Wiki]

#13893: Torbrowser crashes on start when using MS EMET 5.x
-+-
 Reporter:  Diapolo  |  Owner:  gk
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-security, tbb-crash, tbb-|  Actual Points:
  usability-stoppoint-app, fuck-mingw-gcc,   |
  TorBrowserTeam201608, GeorgKoppen201608|
Parent ID:  #12820   | Points:
 Reviewer:   |Sponsor:
 |  SponsorU
-+-

Comment (by gk):

 It seems that disabling code optimization by using `--disable-optimize`
 would solve this again.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13893 [Applications/Tor Browser]: Torbrowser crashes on start when using MS EMET 5.x

[Tor Bug Tracker & Wiki]

#13893: Torbrowser crashes on start when using MS EMET 5.x
-+-
 Reporter:  Diapolo  |  Owner:  gk
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-security, tbb-crash, tbb-|  Actual Points:
  usability-stoppoint-app, fuck-mingw-gcc,   |
  TorBrowserTeam201608, GeorgKoppen201608|
Parent ID:  #12820   | Points:
 Reviewer:   |Sponsor:
 |  SponsorU
-+-

Comment (by gk):

 Getting back to this bug it seems with the switch to ESR45 the issues with
 `VirtualProtectEx()` are gone. My guess is this is due to
 https://bugzilla.mozilla.org/show_bug.cgi?id=1201205 (in particular due to
 {{{
 -// restore protection; if this fails we can't really do anything
 about it
 -VirtualProtectEx(GetCurrentProcess(), aOrigFunction, nBytes, op,
 );
 }}}
 . Now we seem to have only issues with `kernel32.LoadLibraryW` (see e.g.
 https://blog.torproject.org/blog/tor-0287-released-important-
 fixes#comment-203173). Not sure yet, where this exactly is coming from but
 it matches my test results done with EMET and Tor Browser 5.5.5/6.0.4.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13893 [Applications/Tor Browser]: Torbrowser crashes on start when using MS EMET 5.x

[Tor Bug Tracker & Wiki]

#13893: Torbrowser crashes on start when using MS EMET 5.x
-+-
 Reporter:  Diapolo  |  Owner:  gk
 Type:  defect   | Status:
 Priority:  High |  needs_revision
Component:  Applications/Tor Browser |  Milestone:
 Severity:  Major|Version:
 Keywords:  tbb-security, tbb-crash, tbb-| Resolution:
  usability-stoppoint-app, fuck-mingw-gcc,   |  Actual Points:
  TorBrowserTeam201605, GeorgKoppen201605| Points:
Parent ID:  #12820   |Sponsor:
 Reviewer:   |  SponsorU
-+-
Changes (by gk):

 * cc: bugzilla (added)


Comment:

 Resolved #18935 as duplicate.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13893 [Applications/Tor Browser]: Torbrowser crashes on start when using MS EMET 5.x

[Tor Bug Tracker & Wiki]

#13893: Torbrowser crashes on start when using MS EMET 5.x
-+-
 Reporter:  Diapolo  |  Owner:  gk
 Type:  defect   | Status:
 Priority:  High |  needs_revision
Component:  Applications/Tor Browser |  Milestone:
 Severity:  Major|Version:
 Keywords:  tbb-security, tbb-crash, tbb-| Resolution:
  usability-stoppoint-app, fuck-mingw-gcc,   |  Actual Points:
  GeorgKoppen201604, TorBrowserTeam201604| Points:
Parent ID:  #12820   |Sponsor:
 Reviewer:   |  SponsorU
-+-

Comment (by bugzilla):

 Good news. TBB 6.0a5 seems to have only these four identical calls in a
 row:
 {{{
   CodeAddress   : 0x6A3894B6
   CodeStackPtr  : 0x2EDC70
   CalledAddress : 0x7657F0F2
   API name  : kernel32.LoadLibraryW
   StackPtr  : 0x002EDA30
   FramePtr  : 0x2EDE1C
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs