Re: [tor-bugs] #15015 [Core Tor/Tor]: tor --verify-config should not bind to ports

[Tor Bug Tracker & Wiki]

#15015: tor --verify-config should not bind to ports
-+-
 Reporter:  cypherpunks  |  Owner:  rl1987
 Type:  defect   | Status:  closed
 Priority:  Low  |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, intro, startup,   |  worksforme
  configuration, torrc, bootstrap, refactor, |  Actual Points:
  technical-debt |
Parent ID:   | Points:
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by catalyst):

 * status:  needs_information => closed
 * resolution:   => worksforme


Comment:

 No one I've asked seems to be able to reproduce this on a modern tor.
 There's some evidence that such a bug might have existed back before
 0.2.0, but it seems like it's gone in supported releases.

 rl1987, thanks again for working on this patch.  I'm sorry it turns out to
 be unnecessary.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15015 [Core Tor/Tor]: tor --verify-config should not bind to ports

[Tor Bug Tracker & Wiki]

#15015: tor --verify-config should not bind to ports
-+-
 Reporter:  cypherpunks  |  Owner:  rl1987
 Type:  defect   | Status:
 |  needs_information
 Priority:  Low  |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, intro, startup,   |  Actual Points:
  configuration, torrc, bootstrap, refactor, |
  technical-debt |
Parent ID:   | Points:
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by catalyst):

 * status:  needs_review => needs_information
 * priority:  High => Low


Comment:

 Thanks for the patch!  The code looks good.  Like teor, I wonder if tests
 are needed.

 Right now I'm not sure whether the originally reported problem still
 exists.  I can't seem to get a "permission denied" error when setting
 `SOCKSPort 88` on the command line with `--verify-config` on master, even
 though I do get that error without the `--verify-config` option.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15015 [Core Tor/Tor]: tor --verify-config should not bind to ports

[Tor Bug Tracker & Wiki]

#15015: tor --verify-config should not bind to ports
-+-
 Reporter:  cypherpunks  |  Owner:  rl1987
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, intro, startup,   |  Actual Points:
  configuration, torrc, bootstrap, refactor, |
  technical-debt |
Parent ID:   | Points:
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by dgoulet):

 * reviewer:   => catalyst


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15015 [Core Tor/Tor]: tor --verify-config should not bind to ports

[Tor Bug Tracker & Wiki]

#15015: tor --verify-config should not bind to ports
-+-
 Reporter:  cypherpunks  |  Owner:  rl1987
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, intro, startup,   |  Actual Points:
  configuration, torrc, bootstrap, refactor, |
  technical-debt |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 Thanks. Looks good to me.

 I'd like someone else to review this next, and check it against CI.
 They can decide if we need unit test scripts for --parse-config and
 --verify-config.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15015 [Core Tor/Tor]: tor --verify-config should not bind to ports

[Tor Bug Tracker & Wiki]

#15015: tor --verify-config should not bind to ports
-+-
 Reporter:  cypherpunks  |  Owner:  rl1987
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, intro, startup,   |  Actual Points:
  configuration, torrc, bootstrap, refactor, |
  technical-debt |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by rl1987):

 * status:  needs_revision => needs_review


Comment:

 Pushed c1c5970ac83ad804739bd2515b297195df927956 that improves the manpage.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15015 [Core Tor/Tor]: tor --verify-config should not bind to ports

[Tor Bug Tracker & Wiki]

#15015: tor --verify-config should not bind to ports
-+-
 Reporter:  cypherpunks  |  Owner:  rl1987
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, intro, startup,   |  Actual Points:
  configuration, torrc, bootstrap, refactor, |
  technical-debt |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  needs_review => needs_revision
 * points:  small =>
 * milestone:  Tor: unspecified => Tor: 0.3.4.x-final


Comment:

 Thanks for this patch.

 The code looks good, but I think we can improve the man page:
 * please put parse-config immediately after verify-config
 * please explicitly document the different use cases for verify and parse:
   * verify may fail if the tor service is already running
   * parse should be used if the tor service is running

 If you'd like, you can also set up Travis CI on your branch, or open a
 pull request on https://github.com/torproject/tor
 https://trac.torproject.org/projects/tor/ticket/23883#comment:3
 It's the first thing the next reviewer will do.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15015 [Core Tor/Tor]: tor --verify-config should not bind to ports

[Tor Bug Tracker & Wiki]

#15015: tor --verify-config should not bind to ports
-+-
 Reporter:  cypherpunks  |  Owner:  rl1987
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, intro, startup,   |  Actual Points:
  configuration, torrc, bootstrap, refactor, |
  technical-debt |
Parent ID:   | Points:  small
 Reviewer:   |Sponsor:
-+-
Changes (by rl1987):

 * status:  assigned => needs_review


Comment:

 Added `--parse-config` CLI option:
 * https://github.com/rl1987/tor/compare/ticket15015

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15015 [Core Tor/Tor]: tor --verify-config should not bind to ports

[Tor Bug Tracker & Wiki]

#15015: tor --verify-config should not bind to ports
-+-
 Reporter:  cypherpunks  |  Owner:  rl1987
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, intro, startup,   |  Actual Points:
  configuration, torrc, bootstrap, refactor, |
  technical-debt |
Parent ID:   | Points:  small
 Reviewer:   |Sponsor:
-+-
Changes (by rl1987):

 * owner:  (none) => rl1987
 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15015 [Core Tor/Tor]: tor --verify-config should not bind to ports

[Tor Bug Tracker & Wiki]

#15015: tor --verify-config should not bind to ports
-+-
 Reporter:  cypherpunks  |  Owner:
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, intro, startup,   |  Actual Points:
  configuration, torrc, bootstrap, refactor, |
  technical-debt |
Parent ID:   | Points:  small
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * priority:  Medium => High
 * keywords:  tor-relay, intro =>
 tor-relay, intro, startup, configuration, torrc, bootstrap, refactor,
 technical-debt


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15015 [Core Tor/Tor]: tor --verify-config should not bind to ports

[Tor Bug Tracker & Wiki]

#15015: tor --verify-config should not bind to ports
-+-
 Reporter:  cypherpunks  |  Owner:
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.???
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, 027-triaged-1-out, intro  |  Actual Points:
Parent ID:   | Points:  small
 Reviewer:   |Sponsor:
-+-
Changes (by jryans):

 * cc: jryans@… (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15015 [Core Tor/Tor]: tor --verify-config should not bind to ports

[Tor Bug Tracker & Wiki]

#15015: tor --verify-config should not bind to ports
-+-
 Reporter:  cypherpunks  |  Owner:
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.???
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, 027-triaged-1-out, intro  |  Actual Points:
Parent ID:   | Points:  small
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 Hmm, there are two different use cases here:
 1) I am not running a relay, and I'm about to start one, and I want to
 know if it will work,
 2) I am running a relay, and I'm about to change the config, and I want to
 know if it will work

 We can bind to ports in case 1), but not case 2).

 I think we should add a new option `--parse-config` that just does an
 options_verify().
 Of course, the risk is that it will succeed, and then when it gets to
 options_act(), it will fail because it suddenly finds out it can't do what
 it wanted to do.

 But for `--verify-config`, the risk is that it will fail unnecessarily,
 because it could do the things if only it were the existing tor process.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15015 [Core Tor/Tor]: tor --verify-config should not bind to ports

[Tor Bug Tracker & Wiki]

#15015: tor --verify-config should not bind to ports
-+-
 Reporter:  cypherpunks  |  Owner:
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.???
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, 027-triaged-1-out, intro  |  Actual Points:
Parent ID:   | Points:  small
 Reviewer:   |Sponsor:
-+-

Comment (by jryans):

 Should a new option (such as `--parse-config`) be added for the more
 minimal step of parsing only and `--verify-config` left as is to preserve
 compatibility?  Or is it okay to change the behavior of `--verify-config`
 directly?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs