Re: [tor-bugs] #15055 [Core Tor/Tor]: Implement ed25519 link handshake

[Tor Bug Tracker & Wiki]

#15055: Implement ed25519 link handshake
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:  closed
 Priority:  High |  Milestone:  Tor:
 |  0.3.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, prop-220, |  implemented
  027-triaged-1-in, 028-triaged, |  Actual Points:
  201511-deferred, 201512-deferred, tor-crypto-  |
  identity, tor-ed25519-proto,   |
  TorCoreTeam201609, nickm-deferred-20161005,|
  review-group-11|
Parent ID:  #15054   | Points:  parent
 Reviewer:  isis |Sponsor:
 |  SponsorU-must
-+-

Comment (by teor):

 The LinkAuth protover was not updated in this patch, and it should have
 been. I opened #20578 to address that.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15055 [Core Tor/Tor]: Implement ed25519 link handshake

[Tor Bug Tracker & Wiki]

#15055: Implement ed25519 link handshake
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.3.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, prop-220, |  Actual Points:
  027-triaged-1-in, 028-triaged, |
  201511-deferred, 201512-deferred, tor-crypto-  |
  identity, tor-ed25519-proto,   |
  TorCoreTeam201609, nickm-deferred-20161005,|
  review-group-11|
Parent ID:  #15054   | Points:  parent
 Reviewer:  isis |Sponsor:
 |  SponsorU-must
-+-

Comment (by nickm):

 I've added comments there, and squashed the branch into a feature15055_v2,
 and merged it.  Tests pass!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15055 [Core Tor/Tor]: Implement ed25519 link handshake

[Tor Bug Tracker & Wiki]

#15055: Implement ed25519 link handshake
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:  closed
 Priority:  High |  Milestone:  Tor:
 |  0.3.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, prop-220, |  implemented
  027-triaged-1-in, 028-triaged, |  Actual Points:
  201511-deferred, 201512-deferred, tor-crypto-  |
  identity, tor-ed25519-proto,   |
  TorCoreTeam201609, nickm-deferred-20161005,|
  review-group-11|
Parent ID:  #15054   | Points:  parent
 Reviewer:  isis |Sponsor:
 |  SponsorU-must
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15055 [Core Tor/Tor]: Implement ed25519 link handshake

[Tor Bug Tracker & Wiki]

#15055: Implement ed25519 link handshake
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.3.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, prop-220, |  Actual Points:
  027-triaged-1-in, 028-triaged, |
  201511-deferred, 201512-deferred, tor-crypto-  |
  identity, tor-ed25519-proto,   |
  TorCoreTeam201609, nickm-deferred-20161005,|
  review-group-11|
Parent ID:  #15054   | Points:  parent
 Reviewer:  isis |Sponsor:
 |  SponsorU-must
-+-
Changes (by isis):

 * status:  needs_review => merge_ready


Comment:

 Okay, review complete: https://gitlab.com/nickm_tor/tor/merge_requests/7

 There's some minor complaints about documenting that we expect future
 AUTHCHALLENGE types to always be better than previously defined types,
 which is probably true, but if we're depending on that maybe we should
 note it?

 Overall, it looks good and can be merged.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15055 [Core Tor/Tor]: Implement ed25519 link handshake

[Tor Bug Tracker & Wiki]

#15055: Implement ed25519 link handshake
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, prop-220, |  Actual Points:
  027-triaged-1-in, 028-triaged, |
  201511-deferred, 201512-deferred, tor-crypto-  |
  identity, tor-ed25519-proto,   |
  TorCoreTeam201609, review-group-9  |
Parent ID:  #15054   | Points:  parent
 Reviewer:  isis |Sponsor:
 |  SponsorU-must
-+-

Comment (by nickm):

 I just cherry-picked those commits onto my branch

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15055 [Core Tor/Tor]: Implement ed25519 link handshake

[Tor Bug Tracker & Wiki]

#15055: Implement ed25519 link handshake
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, prop-220, |  Actual Points:
  027-triaged-1-in, 028-triaged, |
  201511-deferred, 201512-deferred, tor-crypto-  |
  identity, tor-ed25519-proto,   |
  TorCoreTeam201609, review-group-9  |
Parent ID:  #15054   | Points:  parent
 Reviewer:  isis |Sponsor:
 |  SponsorU-must
-+-

Comment (by isis):

 There's some docstrings for functions in `src/or/routerkeys.c`, which
 didn't have any before and which I ran into during my review, in my
 `feature/15055`
 [https://gitweb.torproject.org/user/isis/tor.git/log/?h=feature/15055
 branch]. (I also marked some other functions in that module with DOCDOC,
 because I didn't need to figure out what they do at the moment.)

 I'm about halfway done with review (on gitlab).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15055 [Core Tor/Tor]: Implement ed25519 link handshake

[Tor Bug Tracker & Wiki]

#15055: Implement ed25519 link handshake
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, prop-220, |  Actual Points:
  027-triaged-1-in, 028-triaged, |
  201511-deferred, 201512-deferred, tor-crypto-  |
  identity, tor-ed25519-proto,   |
  TorCoreTeam201609, review-group-9  |
Parent ID:  #15054   | Points:  parent
 Reviewer:  isis |Sponsor:
 |  SponsorU-must
-+-
Changes (by isis):

 * status:  needs_revision => needs_review
 * reviewer:   => isis


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15055 [Core Tor/Tor]: Implement ed25519 link handshake

[Tor Bug Tracker & Wiki]

#15055: Implement ed25519 link handshake
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, prop-220, |  Actual Points:
  027-triaged-1-in, 028-triaged, |
  201511-deferred, 201512-deferred, tor-crypto-  |
  identity, tor-ed25519-proto,   |
  TorCoreTeam201609, review-group-9  |
Parent ID:  #15054   | Points:  parent
 Reviewer:   |Sponsor:
 |  SponsorU-must
-+-
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 Review can be found in gitlab. Hope this help.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15055 [Core Tor/Tor]: Implement ed25519 link handshake

[Tor Bug Tracker & Wiki]

#15055: Implement ed25519 link handshake
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, prop-220, |  Actual Points:
  027-triaged-1-in, 028-triaged, |
  201511-deferred, 201512-deferred, tor-crypto-  |
  identity, tor-ed25519-proto,   |
  TorCoreTeam201609, review-group-9  |
Parent ID:  #15054   | Points:  parent
 Reviewer:   |Sponsor:
 |  SponsorU-must
-+-
Changes (by nickm):

 * keywords:
 tor-relay, prop-220, 027-triaged-1-in, 028-triaged, 201511-deferred,
 201512-deferred, tor-crypto-identity, tor-ed25519-proto,
 TorCoreTeam201609, nickm-check-done-20160905, review-group-9
 =>
 tor-relay, prop-220, 027-triaged-1-in, 028-triaged, 201511-deferred,
 201512-deferred, tor-crypto-identity, tor-ed25519-proto,
 TorCoreTeam201609, review-group-9


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15055 [Core Tor/Tor]: Implement ed25519 link handshake

[Tor Bug Tracker & Wiki]

#15055: Implement ed25519 link handshake
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, prop-220, |  Actual Points:
  027-triaged-1-in, 028-triaged, |
  201511-deferred, 201512-deferred, tor-crypto-  |
  identity, tor-ed25519-proto,   |
  TorCoreTeam201609, nickm-check-done-20160905   |
Parent ID:  #15054   | Points:  parent
 Reviewer:   |Sponsor:
 |  SponsorU-must
-+-
Changes (by nickm):

 * status:  assigned => needs_review


Comment:

 Now at long last ready for review.

 My branch is `feature_15055` in my public repository.

 There is a gitlab PR to put comments on at:
 https://gitlab.com/nickm_tor/tor/merge_requests/7/commits

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15055 [Core Tor/Tor]: Implement ed25519 link handshake

[Tor Bug Tracker & Wiki]

#15055: Implement ed25519 link handshake
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  assigned
 Priority:  High |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, prop-220, |  Actual Points:
  027-triaged-1-in, 028-triaged, |
  201511-deferred, 201512-deferred, tor-crypto-  |
  identity, tor-ed25519-proto,   |
  TorCoreTeam201609, nickm-check-done-20160905   |
Parent ID:  #15054   | Points:  parent
 Reviewer:   |Sponsor:
 |  SponsorU-must
-+-

Comment (by nickm):

 My unit tests now test the success cases of the code. Next, to test the
 failing cases (all of them).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15055 [Core Tor/Tor]: Implement ed25519 link handshake

[Tor Bug Tracker & Wiki]

#15055: Implement ed25519 link handshake
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  assigned
 Priority:  High |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, prop-220, |  Actual Points:
  027-triaged-1-in, 028-triaged, |
  201511-deferred, 201512-deferred, tor-crypto-  |
  identity, tor-ed25519-proto TorCoreTeam201609  |
Parent ID:  #15054   | Points:  parent
 Reviewer:   |Sponsor:
 |  SponsorU-must
-+-
Changes (by nickm):

 * keywords:
 tor-relay, prop-220, 027-triaged-1-in, 028-triaged, 201511-deferred,
 201512-deferred, tor-crypto-identity, tor-ed25519-proto
 =>
 tor-relay, prop-220, 027-triaged-1-in, 028-triaged, 201511-deferred,
 201512-deferred, tor-crypto-identity, tor-ed25519-proto
 TorCoreTeam201609


Comment:

 Implementation is done here; more testing needed, though.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15055 [Core Tor/Tor]: Implement ed25519 link handshake

[Tor Bug Tracker & Wiki]

#15055: Implement ed25519 link handshake
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  assigned
 Priority:  High |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, prop-220, |  Actual Points:
  027-triaged-1-in, 028-triaged, |
  201511-deferred, 201512-deferred, tor-crypto-  |
  identity, tor-ed25519-proto|
Parent ID:  #15054   | Points:  parent
 Reviewer:   |Sponsor:
 |  SponsorU-must
-+-

Comment (by nickm):

 Status: I believe I will finish the core implementation today or tomorrow.
 The testing and debugging and reviewing will take a bit longer.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15055 [Core Tor/Tor]: Implement ed25519 link handshake

[Tor Bug Tracker & Wiki]

#15055: Implement ed25519 link handshake
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 Priority:  High |  assigned
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Normal   |  0.2.9.x-final
 Keywords:  tor-relay, prop-220, |Version:  Tor:
  027-triaged-1-in, 028-triaged, |  0.2.7
  201511-deferred, 201512-deferred, tor-crypto-  | Resolution:
  identity, tor-ed25519-proto,   |  Actual Points:
  TorCoreTeam201605  | Points:  parent
Parent ID:  #15054   |Sponsor:
 Reviewer:   |  SponsorU-must
-+-
Changes (by nickm):

 * points:  6 => parent


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15055 [Core Tor/Tor]: Implement ed25519 link handshake

[Tor Bug Tracker & Wiki]

#15055: Implement ed25519 link handshake
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 Priority:  High |  assigned
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Normal   |  0.2.9.x-final
 Keywords:  tor-relay, prop-220, |Version:  Tor:
  027-triaged-1-in, 028-triaged, |  0.2.7
  201511-deferred, 201512-deferred, tor-crypto-  | Resolution:
  identity, tor-ed25519-proto,   |  Actual Points:
  TorCoreTeam201605  | Points:  6
Parent ID:  #15054   |Sponsor:
 Reviewer:   |  SponsorU-must
-+-

Comment (by nickm):

 Okay, going to try to wrap all this up next week. That will be a
 challenge.  Here are the pieces of it, to break it down into little edible
 bites:
   * Fix #19020.
   * Servers connecting to servers send all correct authentication
 information when protocol permits.
   * Servers receiving connections send all certificates (when protocol
 permits?)
   * Servers receiving connections from servers check authentication
 information, make correct decisions.
   * Anyone connecting to a server checks all certs (if provided)
   * Add an ed25519_id_key item to or_connection_t / channel_t.
   * Index those by ed25519 id.
   * (non)profit.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15055 [Core Tor/Tor]: Implement ed25519 link handshake

[Tor Bug Tracker & Wiki]

#15055: Implement ed25519 link handshake
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 Priority:  High |  assigned
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Normal   |  0.2.9.x-final
 Keywords:  tor-relay, prop-220, |Version:  Tor:
  027-triaged-1-in, 028-triaged, |  0.2.7
  201511-deferred, 201512-deferred, tor-crypto-  | Resolution:
  identity, tor-ed25519-proto,   |  Actual Points:
  TorCoreTeam201605  | Points:  large
Parent ID:  #15054   |Sponsor:
 Reviewer:   |  SponsorU-must
-+-
Changes (by nickm):

 * severity:   => Normal


Comment:

 I'm now working in `15055_wip`, which I am rebasing a LOT.  You probably
 don't want to look yet.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs