Re: [tor-bugs] #16674 [Tor]: Allow FQDNs ending with a single '.' in our SOCKS host name checks.
#16674: Allow FQDNs ending with a single '.' in our SOCKS host name checks. -+- Reporter: yawning | Owner: Type: defect | Status: closed Priority: normal | Milestone: Tor: 0.2.7.x-final Component: Tor |Version: Tor: 0.2.6.2-alpha Resolution: fixed| Keywords: tor-core, socks, tbb-5.0a4, Actual Points: | TorBrowserTeam201507R Points: | Parent ID: -+- Comment (by starlight): Applied https://gitweb.torproject.org/tor.git/commit/?id=da6aa7bfa5014b980a93b38024d16b32720dc67a to 0.2.6.10 with https://gitweb.torproject.org/tor.git/commit/?id=3f336966a264d7cd7c6dab08fb85d85273f06d68 already in tree, rebuilt deployed and tested. Works no problem, no log warnings with the two NYT links from these tickets as well as another one that popped up today. -- Ticket URL: https://trac.torproject.org/projects/tor/ticket/16674#comment:6 Tor Bug Tracker Wiki https://trac.torproject.org/ The Tor Project: anonymity online ___ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
Re: [tor-bugs] #16674 [Tor]: Allow FQDNs ending with a single '.' in our SOCKS host name checks.
#16674: Allow FQDNs ending with a single '.' in our SOCKS host name checks. -+- Reporter: yawning | Owner: Type: defect | Status: closed Priority: normal | Milestone: Tor: 0.2.7.x-final Component: Tor |Version: Tor: 0.2.6.2-alpha Resolution: fixed| Keywords: tor-core, socks, tbb-5.0a4, Actual Points: | TorBrowserTeam201507R Points: | Parent ID: -+- Comment (by yawning): That url seems to load fine with master, so hopefully this is fixed once and for all, or at least till someone else decides to start serving interesting A records that need workarounds. -- Ticket URL: https://trac.torproject.org/projects/tor/ticket/16674#comment:5 Tor Bug Tracker Wiki https://trac.torproject.org/ The Tor Project: anonymity online ___ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
Re: [tor-bugs] #16674 [Tor]: Allow FQDNs ending with a single '.' in our SOCKS host name checks.
#16674: Allow FQDNs ending with a single '.' in our SOCKS host name checks. -+- Reporter: yawning | Owner: Type: defect | Status: needs_review Priority: normal | Milestone: Tor: 0.2.7.x-final Component: Tor |Version: Tor: 0.2.6.2-alpha Resolution: | Keywords: tor-core, socks, tbb-5.0a4, Actual Points: | TorBrowserTeam201507R Points: | Parent ID: -+- Changes (by yawning): * cc: mikeperry, gk (added) * keywords: tor-core, socks = tor-core, socks, tbb-5.0a4, TorBrowserTeam201507R Comment: Added the Tor Browser folks/Tags, since they cherrypicked #16430, and they may want this assuming I didn't mess up (similar risk, similarly tested). -- Ticket URL: https://trac.torproject.org/projects/tor/ticket/16674#comment:2 Tor Bug Tracker Wiki https://trac.torproject.org/ The Tor Project: anonymity online ___ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
[tor-bugs] #16674 [Tor]: Allow FQDNs ending with a single '.' in our SOCKS host name checks.
#16674: Allow FQDNs ending with a single '.' in our SOCKS host name checks.
-+
Reporter: yawning | Owner:
Type: defect | Status: new
Priority: normal | Milestone: Tor: 0.2.7.x-final
Component: Tor |Version: Tor: 0.2.6.2-alpha
Keywords: tor-core, socks | Actual Points:
Parent ID: | Points:
-+
Brought up as part of #16430. A single `.` is allowed by RFC 3986 (URI
Generic Syntax) in URIs to specify that a domain name is absolute rather
than relative. In practice not many sites use this, but right now since
we unilaterally reject the syntax, it breaks things.
Relevant portion of RFC 3986:
{{{
Such a name consists of a sequence of domain labels separated by .,
each domain label starting and ending with an alphanumeric character
and possibly also containing - characters. The rightmost domain
label of a fully qualified domain name in DNS may be followed by a
single . and should be if it is necessary to distinguish between
the complete domain name and some local domain.
}}}
RFC 1928 specifies that all `DOMAINNAME` type addresses are `fully-
qualified domain name`(s), so I personally think that the `.` is
redundant, but accepting it will increase compatibility, and being
somewhat tolerant here is a good thing.
--
Ticket URL: https://trac.torproject.org/projects/tor/ticket/16674
Tor Bug Tracker Wiki https://trac.torproject.org/
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
Re: [tor-bugs] #16674 [Tor]: Allow FQDNs ending with a single '.' in our SOCKS host name checks.
#16674: Allow FQDNs ending with a single '.' in our SOCKS host name checks. -+- Reporter: yawning | Owner: Type: defect | Status: closed Priority: normal | Milestone: Tor: 0.2.7.x-final Component: Tor |Version: Tor: 0.2.6.2-alpha Resolution: fixed| Keywords: tor-core, socks, tbb-5.0a4, Actual Points: | TorBrowserTeam201507R Points: | Parent ID: -+- Changes (by nickm): * status: needs_review = closed * resolution: = fixed Comment: Merged! TBB can cherry-pick it if they like it. -- Ticket URL: https://trac.torproject.org/projects/tor/ticket/16674#comment:3 Tor Bug Tracker Wiki https://trac.torproject.org/ The Tor Project: anonymity online ___ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
Re: [tor-bugs] #16674 [Tor]: Allow FQDNs ending with a single '.' in our SOCKS host name checks.
#16674: Allow FQDNs ending with a single '.' in our SOCKS host name checks. -+ Reporter: yawning | Owner: Type: defect | Status: needs_review Priority: normal | Milestone: Tor: 0.2.7.x-final Component: Tor |Version: Tor: 0.2.6.2-alpha Resolution: | Keywords: tor-core, socks Actual Points: | Parent ID: Points: | -+ Changes (by yawning): * status: new = needs_review Comment: https://github.com/Yawning/tor/compare/bug16674 -- Ticket URL: https://trac.torproject.org/projects/tor/ticket/16674#comment:1 Tor Bug Tracker Wiki https://trac.torproject.org/ The Tor Project: anonymity online ___ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
Re: [tor-bugs] #16674 [Tor]: Allow FQDNs ending with a single '.' in our SOCKS host name checks.
#16674: Allow FQDNs ending with a single '.' in our SOCKS host name checks. -+- Reporter: yawning | Owner: Type: defect | Status: closed Priority: normal | Milestone: Tor: 0.2.7.x-final Component: Tor |Version: Tor: 0.2.6.2-alpha Resolution: fixed| Keywords: tor-core, socks, tbb-5.0a4, Actual Points: | TorBrowserTeam201507R Points: | Parent ID: -+- Changes (by starlight): * cc: starlight.2015q2@… (added) Comment: Active link that may be used to test both this and #16430: http://www.nytimes.com/interactive/2015/07/22/arts/dance/20150726-vogue.html Should last for at least a week. JavaScript must be enabled. -- Ticket URL: https://trac.torproject.org/projects/tor/ticket/16674#comment:4 Tor Bug Tracker Wiki https://trac.torproject.org/ The Tor Project: anonymity online ___ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
