Re: [tor-bugs] #16679 [Tor]: Ed25519 --keygen won't work
#16679: Ed25519 --keygen won't work -+- Reporter: s7r | Owner: nickm Type: defect | Status: needs_revision Priority: major| Milestone: Tor: 0.2.7.x-final Component: Tor |Version: Tor: 0.2.7.2-alpha Resolution: | Keywords: ed25519, identity, keys, Actual Points: | TorCoreTeam201508 Points: | Parent ID: -+- Changes (by dgoulet): * status: needs_review = needs_revision Comment: 844ba78660819effabc28c21010d71f1c0114855 * in src/or/or.h (duper bikeshed color) * The new enum in `or_options_t` would be great to have each value on different line and assigned with its value (= 1, = 2,). * Extra newline right after `TestingAuthKeySlop` * `puts(E);` is removed in c0e89863ca354dac163c87d61a213466eff2c96f so good! * All fixup and the rest lgtm; 71257e22392eedbe10aca4345b22e8c5cab1a795 * In src/or/routerkeys.c * Missing dot at the end of both sentences of the new `log_notice` introduced. The rest lgtm; However, documentation is missing for some key things like the new arguments added to tor (`--no-passphrase` and `--passphrase-fd`, both in or.h and man page). -- Ticket URL: https://trac.torproject.org/projects/tor/ticket/16679#comment:6 Tor Bug Tracker Wiki https://trac.torproject.org/ The Tor Project: anonymity online ___ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
Re: [tor-bugs] #16679 [Tor]: Ed25519 --keygen won't work
#16679: Ed25519 --keygen won't work -+- Reporter: s7r | Owner: nickm Type: defect | Status: closed Priority: major| Milestone: Tor: 0.2.7.x-final Component: Tor |Version: Tor: 0.2.7.2-alpha Resolution: fixed| Keywords: ed25519, identity, keys, Actual Points: | TorCoreTeam201508 Points: | Parent ID: -+- Changes (by nickm): * status: needs_revision = closed * resolution: = fixed -- Ticket URL: https://trac.torproject.org/projects/tor/ticket/16679#comment:8 Tor Bug Tracker Wiki https://trac.torproject.org/ The Tor Project: anonymity online ___ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
Re: [tor-bugs] #16679 [Tor]: Ed25519 --keygen won't work
#16679: Ed25519 --keygen won't work -+- Reporter: s7r | Owner: nickm Type: defect | Status: needs_revision Priority: major| Milestone: Tor: 0.2.7.x-final Component: Tor |Version: Tor: 0.2.7.2-alpha Resolution: | Keywords: ed25519, identity, keys, Actual Points: | TorCoreTeam201508 Points: | Parent ID: -+- Comment (by nickm): Cleaned up and merged! I'm opening a new ticket for the doc issues. -- Ticket URL: https://trac.torproject.org/projects/tor/ticket/16679#comment:7 Tor Bug Tracker Wiki https://trac.torproject.org/ The Tor Project: anonymity online ___ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
Re: [tor-bugs] #16679 [Tor]: Ed25519 --keygen won't work
#16679: Ed25519 --keygen won't work -+- Reporter: s7r | Owner: nickm Type: defect | Status: assigned Priority: major| Milestone: Tor: 0.2.7.x-final Component: Tor |Version: Tor: 0.2.7.2-alpha Resolution: | Keywords: ed25519, identity, keys, Actual Points: | TorCoreTeam201508 Points: | Parent ID: -+- Comment (by s7r): This is fixed in git-018082ef88b688e2 (ed25519_keygen branch @ nickm). Tried on the same system where the error initially appeared. We can close this when we merge the changes into master. -- Ticket URL: https://trac.torproject.org/projects/tor/ticket/16679#comment:4 Tor Bug Tracker Wiki https://trac.torproject.org/ The Tor Project: anonymity online ___ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
Re: [tor-bugs] #16679 [Tor]: Ed25519 --keygen won't work
#16679: Ed25519 --keygen won't work -+- Reporter: s7r | Owner: nickm Type: defect | Status: needs_review Priority: major| Milestone: Tor: 0.2.7.x-final Component: Tor |Version: Tor: 0.2.7.2-alpha Resolution: | Keywords: ed25519, identity, keys, Actual Points: | TorCoreTeam201508 Points: | Parent ID: -+- Changes (by nickm): * status: assigned = needs_review Comment: For this and other stuff, please review my `ed25519_keygen` branch. -- Ticket URL: https://trac.torproject.org/projects/tor/ticket/16679#comment:5 Tor Bug Tracker Wiki https://trac.torproject.org/ The Tor Project: anonymity online ___ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
Re: [tor-bugs] #16679 [Tor]: Ed25519 --keygen won't work
#16679: Ed25519 --keygen won't work +--- Reporter: s7r | Owner: Type: defect | Status: new Priority: normal | Milestone: Tor: 0.2.7.x-final Component: Tor |Version: Tor: 0.2.7.2-alpha Resolution: | Keywords: ed25519 identity keys Actual Points: | Parent ID: Points: | +--- Comment (by s7r): Even this error makes it look like the process fails to generate keys, it actually generates a master ID key, signing key and key-cert in $HOME/.tor/keys. We should configure it that it would save the master id key to working directory (where the command is run) and not in $HOME/.tor/keys, unless otherwise specified via --datadirectory argument. Secondly, why does it also generate automatically a signing key and key- cert? With what validity period, since it never asks? I assume it is just using the defaults of 30 days. When --keygen command is run manually, Tor should just create an ed25519 master ID key. Signing key and key-cert should be generated with a second command, which would require the master ID key and a SigningKeyLifetime argument. When the master ID key is in /datadirectory/keys, it is not password protected and Tor service is started, then Tor can automatically create a signing key and key-cert with the validity period in torrc's SigningKeyLifetime (30 days unless specified otherwise). -- Ticket URL: https://trac.torproject.org/projects/tor/ticket/16679#comment:1 Tor Bug Tracker Wiki https://trac.torproject.org/ The Tor Project: anonymity online ___ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
Re: [tor-bugs] #16679 [Tor]: Ed25519 --keygen won't work
#16679: Ed25519 --keygen won't work +--- Reporter: s7r | Owner: Type: defect | Status: new Priority: major | Milestone: Tor: 0.2.7.x-final Component: Tor |Version: Tor: 0.2.7.2-alpha Resolution: | Keywords: ed25519 identity keys Actual Points: | Parent ID: Points: | +--- Changes (by nickm): * priority: normal = major Comment: Very odd; I'm not seeing that error when I try. I wonder what's going wrong. -- Ticket URL: https://trac.torproject.org/projects/tor/ticket/16679#comment:2 Tor Bug Tracker Wiki https://trac.torproject.org/ The Tor Project: anonymity online ___ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
[tor-bugs] #16679 [Tor]: Ed25519 --keygen won't work
#16679: Ed25519 --keygen won't work ---+ Reporter: s7r| Owner: Type: defect | Status: new Priority: normal | Milestone: Tor: 0.2.7.x-final Component: Tor|Version: Tor: 0.2.7.2-alpha Keywords: ed25519 identity keys | Actual Points: Parent ID: | Points: ---+ Playing with Ed25519 keys to write the documentation and identify bugs or issues. First one: tor --keygen and/or tor --datadirectory /var/lib/tor/keys --keygen will not work. It asks me for the password 2 times and aborts. Here is the output (using Debian Wheezy 64 bit and Tor 0.2.7.2-alpha installed from deb.tp.o tor-nightly-master-wheezy; checked permissions on directories): Jul 27 21:03:21.080 [err] tor_assertion_failed_(): Bug: ../src/or/router.c:229: get_server_identity_key: Assertion server_identitykey failed; aborting. (on Tor 0.2.7.2-alpha-dev ) Jul 27 21:03:21.080 [err] Bug: Assertion server_identitykey failed in get_server_identity_key at ../src/or/router.c:229. Stack trace: (on Tor 0.2.7.2-alpha-dev ) Jul 27 21:03:21.080 [err] Bug: tor(log_backtrace+0x41) [0x7f6227482311] (on Tor 0.2.7.2-alpha-dev ) Jul 27 21:03:21.080 [err] Bug: tor(tor_assertion_failed_+0x9f) [0x7f622748fd9f] (on Tor 0.2.7.2-alpha-dev ) Jul 27 21:03:21.080 [err] Bug: tor(get_server_identity_key+0x93) [0x7f62273cb0d3] (on Tor 0.2.7.2-alpha-dev ) Jul 27 21:03:21.080 [err] Bug: tor(load_ed_keys+0x525) [0x7f62273d2075] (on Tor 0.2.7.2-alpha-dev ) Jul 27 21:03:21.080 [err] Bug: tor(tor_main+0x180a) [0x7f622739975a] (on Tor 0.2.7.2-alpha-dev ) Jul 27 21:03:21.080 [err] Bug: /lib/x86_64-linux- gnu/libc.so.6(__libc_start_main+0xfd) [0x7f6225c81ead] (on Tor 0.2.7.2 -alpha-dev ) Jul 27 21:03:21.080 [err] Bug: tor(+0x3cc9d) [0x7f6227392c9d] (on Tor 0.2.7.2-alpha-dev ) Aborted -- Ticket URL: https://trac.torproject.org/projects/tor/ticket/16679 Tor Bug Tracker Wiki https://trac.torproject.org/ The Tor Project: anonymity online ___ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
