Re: [tor-bugs] #17242 [Core Tor/Tor]: prop224: Implement client support

[Tor Bug Tracker & Wiki]

#17242: prop224: Implement client support
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  enhancement   | Status:  closed
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  tor-hs, prop224, review-group-22  |  Actual Points:
Parent ID:  #12424| Points:  parent
 Reviewer:  nickm |Sponsor:  SponsorR-
  |  must
--+
Changes (by dgoulet):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 It is upstream! Lagavulin 16 for everyone! :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17242 [Core Tor/Tor]: prop224: Implement client support

[Tor Bug Tracker & Wiki]

#17242: prop224: Implement client support
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  enhancement   | Status:
  |  merge_ready
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-hs, prop224, review-group-22  |  Actual Points:
Parent ID:  #12424| Points:  parent
 Reviewer:  nickm |Sponsor:  SponsorR-
  |  must
--+
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 Ok, squashed branch is in: `ticket17242_032_03-squashed`

 Git diff with `ticket17242_032_03` is empty.

 Test passes as well as integration test with chutney and real network.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17242 [Core Tor/Tor]: prop224: Implement client support

[Tor Bug Tracker & Wiki]

#17242: prop224: Implement client support
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  enhancement   | Status:
  |  needs_review
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-hs, prop224, review-group-22  |  Actual Points:
Parent ID:  #12424| Points:  parent
 Reviewer:  nickm |Sponsor:  SponsorR-
  |  must
--+
Changes (by dgoulet):

 * status:  needs_revision => needs_review


Comment:

 I've pushed and fixed the comment of nickm's second pass.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17242 [Core Tor/Tor]: prop224: Implement client support

[Tor Bug Tracker & Wiki]

#17242: prop224: Implement client support
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  enhancement   | Status:
  |  needs_revision
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-hs, prop224, review-group-22  |  Actual Points:
Parent ID:  #12424| Points:  parent
 Reviewer:  nickm |Sponsor:  SponsorR-
  |  must
--+
Changes (by nickm):

 * reviewer:   => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17242 [Core Tor/Tor]: prop224: Implement client support

[Tor Bug Tracker & Wiki]

#17242: prop224: Implement client support
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  enhancement   | Status:
  |  needs_revision
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-hs, prop224, review-group-22  |  Actual Points:
Parent ID:  #12424| Points:  parent
 Reviewer:|Sponsor:  SponsorR-
  |  must
--+
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Okay; I've finished the review and left comments on the merge request.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17242 [Core Tor/Tor]: prop224: Implement client support

[Tor Bug Tracker & Wiki]

#17242: prop224: Implement client support
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  enhancement   | Status:
  |  needs_review
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-hs, prop224, review-group-22  |  Actual Points:
Parent ID:  #12424| Points:  parent
 Reviewer:|Sponsor:  SponsorR-
  |  must
--+

Comment (by nickm):

 status: I have reviewed up to but not including a3d7f53b

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17242 [Core Tor/Tor]: prop224: Implement client support

[Tor Bug Tracker & Wiki]

#17242: prop224: Implement client support
-+
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  enhancement  | Status:  needs_review
 Priority:  Very High|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #12424   | Points:  parent
 Reviewer:   |Sponsor:  SponsorR-must
-+
Changes (by asn):

 * status:  new => needs_review


Comment:

 OK! I'm glad to present you the first reviewable branch of client-side
 prop224!
 You can find it in branch `ticket17242_032_03`!

 I also opened an oniongit MR here:
 https://oniongit.eu/asn/tor/merge_requests/3

 Please note that the first few commits of that branch (up to `3e593f0`)
 fix various issues with the service-side code (#20657). We have currently
 squashed both client and service changes in the same branch so that we can
 test them all at once. If you'd like to only see the service-side changes
 to begin with, I pushed a branch `ticket20657_032_05` and also opened an
 oniongit MR: https://oniongit.eu/asn/tor/merge_requests/4

 FWIW, there are still a few bugs here and there on the client-side code
 and we are actively working on finding & fixing them, so after this
 initial review finishes, we will have some more commits for you!

 Let us know if you need help or have any questions while reviewing this
 branch! Cheers!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17242 [Core Tor/Tor]: prop224: Implement client support

[Tor Bug Tracker & Wiki]

#17242: prop224: Implement client support
-+
 Reporter:  dgoulet  |  Owner:
 Type:  enhancement  | Status:  new
 Priority:  Very High|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #12424   | Points:  parent
 Reviewer:   |Sponsor:  SponsorR-must
-+

Comment (by asn):

 I made an oniongit MR to do some initial code review here:
 https://oniongit.eu/asn/tor/merge_requests/2/commits

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17242 [Core Tor/Tor]: prop224: Implement client support

[Tor Bug Tracker & Wiki]

#17242: prop224: Implement client support
-+
 Reporter:  dgoulet  |  Owner:
 Type:  enhancement  | Status:  new
 Priority:  Very High|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #12424   | Points:  parent
 Reviewer:   |Sponsor:  SponsorR-must
-+
Changes (by asn):

 * milestone:  Tor: 0.3.1.x-final => Tor: 0.3.2.x-final


Comment:

 Triaging this into 0.3.2 after amsterdam discussion.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17242 [Core Tor/Tor]: prop224: Implement client support (was: prop224: Implement client and service support)

[Tor Bug Tracker & Wiki]

#17242: prop224: Implement client support
-+---
 Reporter:  dgoulet  |  Owner:
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.2.???
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #12424   | Points:  parent
 Reviewer:   |Sponsor:  SponsorR-must
-+---
Description changed by dgoulet:

Old description:

> Only client and service support for next generation hidden service. Be
> able to post/get descriptor, establish IP and RP, etc... This also should
> also include all control port support on both client and service side.
>
> I'm imagining this ticket will have *many* child tickets in the future.

New description:

 This ticket is the parent one for anything related to client
 implementation for proposal 224.

 As we break down functionalities and needed features, we'll add more child
 tickets.

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs