Re: [tor-bugs] #19429 [Core Tor/Tor]: Clean up our OpenSSL 1.1 support.

[Tor Bug Tracker & Wiki]

#19429: Clean up our OpenSSL 1.1 support.
-+-
 Reporter:  yawning  |  Owner:  nickm
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.8.4-rc
 Severity:  Normal   | Resolution:
 Keywords:  tor-crypto openssl refactor future-  |  implemented
  proof  |  Actual Points:
Parent ID:   | Points:  3
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Merging!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19429 [Core Tor/Tor]: Clean up our OpenSSL 1.1 support.

[Tor Bug Tracker & Wiki]

#19429: Clean up our OpenSSL 1.1 support.
-+-
 Reporter:  yawning  |  Owner:  nickm
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.8.4-rc
 Severity:  Normal   | Resolution:
 Keywords:  tor-crypto openssl refactor future-  |  Actual Points:
  proof  |
Parent ID:   | Points:  3
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by catalyst):

 * status:  needs_review => merge_ready


Comment:

 Thanks! Works for me now on 1.1.0 and 1.1.0-nodep.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19429 [Core Tor/Tor]: Clean up our OpenSSL 1.1 support.

[Tor Bug Tracker & Wiki]

#19429: Clean up our OpenSSL 1.1 support.
-+-
 Reporter:  yawning  |  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.8.4-rc
 Severity:  Normal   | Resolution:
 Keywords:  tor-crypto openssl refactor future-  |  Actual Points:
  proof  |
Parent ID:   | Points:  3
 Reviewer:  catalyst |Sponsor:
-+-

Comment (by nickm):

 okay.  Tests pass for me now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19429 [Core Tor/Tor]: Clean up our OpenSSL 1.1 support.

[Tor Bug Tracker & Wiki]

#19429: Clean up our OpenSSL 1.1 support.
-+-
 Reporter:  yawning  |  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.8.4-rc
 Severity:  Normal   | Resolution:
 Keywords:  tor-crypto openssl refactor future-  |  Actual Points:
  proof  |
Parent ID:   | Points:  3
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19429 [Core Tor/Tor]: Clean up our OpenSSL 1.1 support.

[Tor Bug Tracker & Wiki]

#19429: Clean up our OpenSSL 1.1 support.
-+-
 Reporter:  yawning  |  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.8.4-rc
 Severity:  Normal   | Resolution:
 Keywords:  tor-crypto openssl refactor future-  |  Actual Points:
  proof  |
Parent ID:   | Points:  3
 Reviewer:  catalyst |Sponsor:
-+-

Comment (by nickm):

 whoops. Should have tested with my regular openssl after testing with
 1.1.1.

 Revising, and testing with 1.1.0, 1.1.1, and 1.1.1-nodep.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19429 [Core Tor/Tor]: Clean up our OpenSSL 1.1 support.

[Tor Bug Tracker & Wiki]

#19429: Clean up our OpenSSL 1.1 support.
-+-
 Reporter:  yawning  |  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.8.4-rc
 Severity:  Normal   | Resolution:
 Keywords:  tor-crypto openssl refactor future-  |  Actual Points:
  proof  |
Parent ID:   | Points:  3
 Reviewer:  catalyst |Sponsor:
-+-

Comment (by catalyst):

 Confirmed that without `--enable-fatal-warnings`, the building using the
 default build of openssl-1.1.0h seems to only have warnings in that one
 file.  All of these are built on Ubuntu 16.04.04 amd64.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19429 [Core Tor/Tor]: Clean up our OpenSSL 1.1 support.

[Tor Bug Tracker & Wiki]

#19429: Clean up our OpenSSL 1.1 support.
-+-
 Reporter:  yawning  |  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.8.4-rc
 Severity:  Normal   | Resolution:
 Keywords:  tor-crypto openssl refactor future-  |  Actual Points:
  proof  |
Parent ID:   | Points:  3
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by catalyst):

 * status:  needs_review => needs_revision


Comment:

 Looks like it works with openssl-1.1.0h built with `no-deprecated`, so
 it's 1.1.0h with deprecated APIs that's the problem.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19429 [Core Tor/Tor]: Clean up our OpenSSL 1.1 support.

[Tor Bug Tracker & Wiki]

#19429: Clean up our OpenSSL 1.1 support.
-+-
 Reporter:  yawning  |  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.8.4-rc
 Severity:  Normal   | Resolution:
 Keywords:  tor-crypto openssl refactor future-  |  Actual Points:
  proof  |
Parent ID:   | Points:  3
 Reviewer:  catalyst |Sponsor:
-+-

Comment (by catalyst):

 I get
 {{{
 src/common/tortls.c:64:0: error: "X509_get_notBefore" redefined [-Werror]
  #define X509_get_notBefore(cert) \
  ^
 In file included from /home/tlyu/ssl/include/openssl/ssl.h:50:0,
  from src/common/tortls.c:41:
 /home/tlyu/ssl/include/openssl/x509.h:635:0: note: this is the location of
 the previous definition
  #  define X509_get_notBefore X509_getm_notBefore
  ^
 src/common/tortls.c:66:0: error: "X509_get_notAfter" redefined [-Werror]
  #define X509_get_notAfter(cert) \
  ^
 In file included from /home/tlyu/ssl/include/openssl/ssl.h:50:0,
  from src/common/tortls.c:41:
 /home/tlyu/ssl/include/openssl/x509.h:636:0: note: this is the location of
 the previous definition
  #  define X509_get_notAfter X509_getm_notAfter
  ^
 }}}
 with a freshly built openssl-1.1.0h and default options (except for
 `--prefix`).  I'll check against a `--no-deprecated` build to see if
 there's any difference.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19429 [Core Tor/Tor]: Clean up our OpenSSL 1.1 support.

[Tor Bug Tracker & Wiki]

#19429: Clean up our OpenSSL 1.1 support.
-+-
 Reporter:  yawning  |  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.8.4-rc
 Severity:  Normal   | Resolution:
 Keywords:  tor-crypto openssl refactor future-  |  Actual Points:
  proof  |
Parent ID:   | Points:  3
 Reviewer:  catalyst |Sponsor:
-+-

Comment (by catalyst):

 Discovered some possible coverage indeterminacy shown by coveralls.  See
 #25908.  All the coverage decreases seem independent of the changes.

 Changes look good by visual inspection.  I still would like to try
 building with differently configured openssl versions to confirm the
 intended functionality.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19429 [Core Tor/Tor]: Clean up our OpenSSL 1.1 support.

[Tor Bug Tracker & Wiki]

#19429: Clean up our OpenSSL 1.1 support.
-+-
 Reporter:  yawning  |  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.8.4-rc
 Severity:  Normal   | Resolution:
 Keywords:  tor-crypto openssl refactor future-  |  Actual Points:
  proof  |
Parent ID:   | Points:  3
 Reviewer:  catalyst |Sponsor:
-+-

Comment (by nickm):

 This patch also covers that ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19429 [Core Tor/Tor]: Clean up our OpenSSL 1.1 support.

[Tor Bug Tracker & Wiki]

#19429: Clean up our OpenSSL 1.1 support.
-+-
 Reporter:  yawning  |  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.8.4-rc
 Severity:  Normal   | Resolution:
 Keywords:  tor-crypto openssl refactor future-  |  Actual Points:
  proof  |
Parent ID:   | Points:  3
 Reviewer:  catalyst |Sponsor:
-+-

Comment (by catalyst):

 #19981 is still listed as a child ticket; does it need a separate patch or
 does this patch cover that ticket as well?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19429 [Core Tor/Tor]: Clean up our OpenSSL 1.1 support.

[Tor Bug Tracker & Wiki]

#19429: Clean up our OpenSSL 1.1 support.
-+-
 Reporter:  yawning  |  Owner:  nickm
 Type:  enhancement  | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.8.4-rc
 Severity:  Normal   | Resolution:
 Keywords:  tor-crypto openssl refactor future-  |  Actual Points:
  proof  |
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * owner:  yawning => nickm
 * status:  new => accepted
 * milestone:  Tor: unspecified => Tor: 0.3.4.x-final


Comment:

 I've adapted the patch on https://bugs.gentoo.org/630380 to support this,
 along with the patch from #25353.  See branch `ticket19429_034`.  Since
 this is a new feature, I suggest no backport.  Pull request at
 https://github.com/torproject/tor/pull/55

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19429 [Core Tor/Tor]: Clean up our OpenSSL 1.1 support.

[Tor Bug Tracker & Wiki]

#19429: Clean up our OpenSSL 1.1 support.
-+-
 Reporter:  yawning  |  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.8.4-rc
 Severity:  Normal   | Resolution:
 Keywords:  tor-crypto openssl refactor future-  |  Actual Points:
  proof  |
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  accepted => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19429 [Core Tor/Tor]: Clean up our OpenSSL 1.1 support.

[Tor Bug Tracker & Wiki]

#19429: Clean up our OpenSSL 1.1 support.
-+-
 Reporter:  yawning  |  Owner:  yawning
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.8.4-rc
 Severity:  Normal   | Resolution:
 Keywords:  tor-crypto openssl refactor future-  |  Actual Points:
  proof  |
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
-+-
Changes (by laomaiweng):

 * cc: quentin@… (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19429 [Core Tor/Tor]: Clean up our OpenSSL 1.1 support.

[Tor Bug Tracker & Wiki]

#19429: Clean up our OpenSSL 1.1 support.
-+-
 Reporter:  yawning  |  Owner:  yawning
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.8.4-rc
 Severity:  Normal   | Resolution:
 Keywords:  tor-crypto openssl refactor future-  |  Actual Points:
  proof  |
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
-+-

Comment (by laomaiweng):

 FWIW, Tor 0.3.3.1_alpha fails to build against Gentoo's OpenSSL 1.1.0g
 (masked, only enabled at user's own risk) because these deprecated APIs
 are disabled. :(

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19429 [Core Tor/Tor]: Clean up our OpenSSL 1.1 support.

[Tor Bug Tracker & Wiki]

#19429: Clean up our OpenSSL 1.1 support.
-+-
 Reporter:  yawning  |  Owner:  yawning
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.8.4-rc
 Severity:  Normal   | Resolution:
 Keywords:  tor-crypto openssl refactor future-  |  Actual Points:
  proof  |
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  tor-crypto => tor-crypto openssl refactor future-proof


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19429 [Core Tor/Tor]: Clean up our OpenSSL 1.1 support.

[Tor Bug Tracker & Wiki]

#19429: Clean up our OpenSSL 1.1 support.
-+-
 Reporter:  yawning  |  Owner:  yawning
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.3.???
Component:  Core Tor/Tor |Version:  Tor: 0.2.8.4-rc
 Severity:  Normal   | Resolution:
 Keywords:  tor-core tor-crypto  |  Actual Points:
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * milestone:  Tor: 0.3.0.x-final => Tor: 0.3.???


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19429 [Core Tor/Tor]: Clean up our OpenSSL 1.1 support.

[Tor Bug Tracker & Wiki]

#19429: Clean up our OpenSSL 1.1 support.
-+
 Reporter:  yawning  |  Owner:  yawning
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor |Version:  Tor: 0.2.8.4-rc
 Severity:  Normal   | Resolution:
 Keywords:  tor-core tor-crypto  |  Actual Points:
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
-+

Comment (by nickm):

 Of the new functions listed above, none was available in OpenSSL 1.0.2.  I
 believe we should defer this ticket until we no longer want to support
 OpenSSL 1.0.2.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19429 [Core Tor/Tor]: Clean up our OpenSSL 1.1 support.

[Tor Bug Tracker & Wiki]

#19429: Clean up our OpenSSL 1.1 support.
-+
 Reporter:  yawning  |  Owner:  yawning
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor |Version:  Tor: 0.2.8.4-rc
 Severity:  Normal   | Resolution:
 Keywords:  tor-core tor-crypto  |  Actual Points:
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
-+

Comment (by nickm):

 These functions are replaced by no-ops in OpenSSL 1.1:
 {{{
 CRYPTO_cleanup_all_ex_data
 ENGINE_cleanup
 ERR_free_strings
 EVP_cleanup
 }}}

 These are replaced with variants of `OPENSSL_init_crypto()`:
 {{{
 ERR_load_crypto_strings
 OpenSSL_add_all_algorithms
 }}}

 These are replaced with variants of `OPENSSL_init_ssl()`:
 {{{
 SSL_library_init
 SSL_load_error_strings
 }}}

 These have new names:
 `EVP_CIPHER_CTX_cleanup()` becomes `EVP_CIPHER_CTX_reset()`.
 `X509_get_notAfter()` becomes `X509_get0_notAfter` or
 `X509_getm_notAfter`.
 `X509_get_notBefore()` becomes `X509_get0_notBefore` or
 `X509_getm_notBefore`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19429 [Core Tor/Tor]: Clean up our OpenSSL 1.1 support.

[Tor Bug Tracker & Wiki]

#19429: Clean up our OpenSSL 1.1 support.
-+
 Reporter:  yawning  |  Owner:  yawning
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor |Version:  Tor: 0.2.8.4-rc
 Severity:  Normal   | Resolution:
 Keywords:  tor-core tor-crypto  |  Actual Points:
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
-+

Comment (by nickm):

 These are the deprecated functions we use:
 {{{
 CRYPTO_cleanup_all_ex_data
 ENGINE_cleanup
 ERR_free_strings
 ERR_load_crypto_strings
 EVP_CIPHER_CTX_cleanup
 EVP_cleanup
 OpenSSL_add_all_algorithms
 SSL_library_init
 SSL_load_error_strings
 X509_get_notAfter
 X509_get_notBefore
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19429 [Core Tor/Tor]: Clean up our OpenSSL 1.1 support.

[Tor Bug Tracker & Wiki]

#19429: Clean up our OpenSSL 1.1 support.
-+
 Reporter:  yawning  |  Owner:  yawning
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor |Version:  Tor: 0.2.8.4-rc
 Severity:  Normal   | Resolution:
 Keywords:  tor-core tor-crypto  |  Actual Points:
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
-+

Comment (by cypherpunks):

 FYI, Tor 0.2.9.3-alpha doesn't compile with OpenSSL 1.1.0b with all
 deprecated features disabled.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #19429 [Core Tor/Tor]: Clean up our OpenSSL 1.1 support.

[Tor Bug Tracker & Wiki]

#19429: Clean up our OpenSSL 1.1 support.
--+-
 Reporter:  yawning   |  Owner:  yawning
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.2.8.4-rc
 Severity:  Normal|   Keywords:  tor-core tor-crypto
Actual Points:|  Parent ID:
   Points:  3 |   Reviewer:
  Sponsor:|
--+-
 In an ideal world, we should support OpenSSL 1.1 built with the deprecated
 APIs entirely disabled.  Additionally while the code that uses the new
 opaque wrappers for the RSA stuff is functional and maintainable, it would
 be cleaner if we provided our own wrappers for a more unified codepath.

 Neither of these are high priority as the current code works, the changes
 suggested would just make things better.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs