Re: [tor-bugs] #19665 [Core Tor/Tor]: Should *Port_set count sockets?

[Tor Bug Tracker & Wiki]

#19665: Should *Port_set count sockets?
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-control technical-debt config|  Actual Points:
  torrc startup  |
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
-+-
Changes (by gaba):

 * sponsor:  Sponsor8 =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19665 [Core Tor/Tor]: Should *Port_set count sockets?

[Tor Bug Tracker & Wiki]

#19665: Should *Port_set count sockets?
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-control technical-debt config|  Actual Points:
  torrc startup  |
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by dgoulet):

 * status:  needs_revision => new
 * reviewer:  nickm =>
 * parent:  #25500 =>
 * milestone:  Tor: 0.3.4.x-final => Tor: unspecified


Comment:

 Unparenting and the fix needed for #25550 is now in ticket #26062.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19665 [Core Tor/Tor]: Should *Port_set count sockets?

[Tor Bug Tracker & Wiki]

#19665: Should *Port_set count sockets?
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-control technical-debt config|  Actual Points:
  torrc startup  |
Parent ID:  #25500   | Points:  0.5
 Reviewer:  nickm|Sponsor:
 |  Sponsor8
-+-

Comment (by teor):

 We should split off 59a32e5b4ff210b95bbed294cdc787cb75539da5 into a
 separate ticket and backport it to 0.2.9 and later. Otherwise, relays with
 the control port open will warn based on the client required protocols
 list.

 And I agree with nickm, we should make ControlPort_set count sockets.
 Maybe we should make all the *Port_set options count sockets, for
 consistency. Otherwise, weird things will happen in test networks that use
 sockets.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19665 [Core Tor/Tor]: Should *Port_set count sockets?

[Tor Bug Tracker & Wiki]

#19665: Should *Port_set count sockets?
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-control technical-debt config|  Actual Points:
  torrc startup  |
Parent ID:  #25500   | Points:  0.5
 Reviewer:  nickm|Sponsor:
 |  Sponsor8
-+-
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Needs a changes file.

 Also, I don't understand what exactly the fix in this patch has to do with
 the original issue report above.  It seems like this patch is fixing
 "ControlPort doesn't mean you're a client!" but the ticket is asking for
 something else.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19665 [Core Tor/Tor]: Should *Port_set count sockets?

[Tor Bug Tracker & Wiki]

#19665: Should *Port_set count sockets?
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-control technical-debt config|  Actual Points:
  torrc startup  |
Parent ID:  #25500   | Points:  0.5
 Reviewer:  nickm|Sponsor:
 |  Sponsor8
-+-
Changes (by dgoulet):

 * status:  new => needs_review
 * reviewer:   => nickm


Comment:

 See branch `ticket19665_034_01`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19665 [Core Tor/Tor]: Should *Port_set count sockets?

[Tor Bug Tracker & Wiki]

#19665: Should *Port_set count sockets?
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-control technical-debt config|  Actual Points:
  torrc startup  |
Parent ID:  #25500   | Points:  0.5
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by nickm):

 * parent:  #25762 => #25500


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19665 [Core Tor/Tor]: Should *Port_set count sockets?

[Tor Bug Tracker & Wiki]

#19665: Should *Port_set count sockets?
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-control technical-debt config|  Actual Points:
  torrc startup  |
Parent ID:  #25762   | Points:  0.5
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by dgoulet):

 * sponsor:   => Sponsor8
 * parent:   => #25762
 * milestone:  Tor: unspecified => Tor: 0.3.4.x-final


Comment:

 Parenting this ticket because we need to properly identify a "tor client"
 and using those `*_Set` variables is what should be done.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19665 [Core Tor/Tor]: Should *Port_set count sockets?

[Tor Bug Tracker & Wiki]

#19665: Should *Port_set count sockets?
-+-
 Reporter:  teor |  Owner:
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-control technical-debt config|  Actual Points:
  torrc startup  |
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  030-proposed => tor-control technical-debt config torrc
   startup


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19665 [Core Tor/Tor]: Should *Port_set count sockets?

[Tor Bug Tracker & Wiki]

#19665: Should *Port_set count sockets?
--+--
 Reporter:  teor  |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.2.???
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  030-proposed  |  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+--

Comment (by nickm):

 Agreed that we should refactor. I'd love to remove the count_sockets
 argument from count_real_listeners.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #19665 [Core Tor/Tor]: Should *Port_set count sockets?

[Tor Bug Tracker & Wiki]

#19665: Should *Port_set count sockets?
--+--
 Reporter:  teor  |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.2.???
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  030-proposed
Actual Points:|  Parent ID:
   Points:  0.5   |   Reviewer:
  Sponsor:|
--+--
 In parse_ports in 0.2.8-stable and earlier, we didn't count sockets as
 listeners when setting options->*Port_set.

 This makes sense for server ports, is confusing for
 ControlPort/ControlSocket (because you can set a control socket using the
 ControlPort option, can't you?), and didn't matter for client ports,
 because those values were never used.

 In #17178 I modified the client port options to count sockets.
 But we should definitely review the control port situation some time.
 I don't think it's serious, because the current code warns on ControlPorts
 and ControlSockets.
 But it makes it easy to introduce subtle bugs.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs