Re: [tor-bugs] #20217 [Applications/Tor Browser]: Make sure that all .mar files required for generating incremental ones on OS X contain code-signed bits

[Tor Bug Tracker & Wiki]

#20217: Make sure that all .mar files required for generating incremental ones 
on
OS X contain code-signed bits
---+--
 Reporter:  gk |  Owner:  tbb-team
 Type:  enhancement| Status:  closed
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  tbb-gitian, TorBrowserTeam201610R  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by gk):

 * status:  needs_revision => closed
 * resolution:   => fixed


Comment:

 Looks good, thanks. Merged to master (commit
 9836227e4ae27123a3eb27167dc6dca13b5d1027).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20217 [Applications/Tor Browser]: Make sure that all .mar files required for generating incremental ones on OS X contain code-signed bits

[Tor Bug Tracker & Wiki]

#20217: Make sure that all .mar files required for generating incremental ones 
on
OS X contain code-signed bits
---+---
 Reporter:  gk |  Owner:  tbb-team
 Type:  enhancement| Status:
   |  needs_revision
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-gitian, TorBrowserTeam201610R  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---
Changes (by boklm):

 * keywords:  tbb-gitian, TorBrowserTeam201610 => tbb-gitian,
 TorBrowserTeam201610R
 * status:  new => needs_revision


Comment:

 The branch `bug_20217` in my git repo has a patch for this:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 bundle.git/commit/?h=bug_20217

 When generating the OSX incremental MARs from `make dmg2mars` or `make
 dmg2mars-alpha`, we are now checking that both the new and the old MAR
 files contain a file in
 `TorBrowser.app/Contents/_CodeSignature/CodeResources`.

 I checked that it fails with an error when the mar file from the old
 version is not code signed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #20217 [Applications/Tor Browser]: Make sure that all .mar files required for generating incremental ones on OS X contain code-signed bits

[Tor Bug Tracker & Wiki]

#20217: Make sure that all .mar files required for generating incremental ones 
on
OS X contain code-signed bits
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  tbb-gitian,
 Severity:  Normal   |  TorBrowserTeam201609
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 While doing the 6.5a3 release it occurred to me we need to make sure every
 time we create the incrementals for OS X all involved full .mar files
 contain the code-signed bits. Otherwise the incremental files will fail.

 We should have a check for this as this is easily forgotten, especially if
 different people are creating the .incremental mar files.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs