Re: [tor-bugs] #21349 [Core Tor/Tor]: Split up very long functions in entrynodes.c

[Tor Bug Tracker & Wiki]

#21349: Split up very long functions in entrynodes.c
-+-
 Reporter:  nickm|  Owner:  rl1987
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  refactor, technical-debt, tor-   |  implemented
  client, 035-triaged-in-20180711|  Actual Points:
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Awesome!  Merged `ticket21349_4` to master.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21349 [Core Tor/Tor]: Split up very long functions in entrynodes.c

[Tor Bug Tracker & Wiki]

#21349: Split up very long functions in entrynodes.c
-+-
 Reporter:  nickm|  Owner:  rl1987
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  refactor, technical-debt, tor-   |  Actual Points:
  client, 035-triaged-in-20180711|
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
-+-
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 Fixes in `ticket21349_3_clean` LGTM and seem to follow Nick's review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21349 [Core Tor/Tor]: Split up very long functions in entrynodes.c

[Tor Bug Tracker & Wiki]

#21349: Split up very long functions in entrynodes.c
-+-
 Reporter:  nickm|  Owner:  rl1987
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  refactor, technical-debt, tor-   |  Actual Points:
  client, 035-triaged-in-20180711|
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
-+-

Comment (by rl1987):

 Squashed and rebased again: https://github.com/torproject/tor/pull/246

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21349 [Core Tor/Tor]: Split up very long functions in entrynodes.c

[Tor Bug Tracker & Wiki]

#21349: Split up very long functions in entrynodes.c
-+-
 Reporter:  nickm|  Owner:  rl1987
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  refactor, technical-debt, tor-   |  Actual Points:
  client, 035-triaged-in-20180711|
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
-+-
Changes (by rl1987):

 * status:  needs_revision => needs_review


Comment:

 Pushed some fixups to branch corresponding to !202 in response to comments
 from Nick. Please see if it's ready to merge now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21349 [Core Tor/Tor]: Split up very long functions in entrynodes.c

[Tor Bug Tracker & Wiki]

#21349: Split up very long functions in entrynodes.c
-+-
 Reporter:  nickm|  Owner:  rl1987
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  refactor, technical-debt, tor-   |  Actual Points:
  client, 035-triaged-in-20180711|
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
-+-
Changes (by asn):

 * status:  merge_ready => needs_revision


Comment:

 Marking as `needs_revision` while waiting for rl1987 to answer. rl1987,
 let me know if you want us to take over here. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21349 [Core Tor/Tor]: Split up very long functions in entrynodes.c

[Tor Bug Tracker & Wiki]

#21349: Split up very long functions in entrynodes.c
-+-
 Reporter:  nickm|  Owner:  rl1987
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  refactor, technical-debt, tor-   |  Actual Points:
  client, 035-triaged-in-20180711|
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
-+-

Comment (by nickm):

 I have a few questions on the ticket -- please let me know if you want to
 make the suggested changes, or if you think any of them aren't a good
 idea.  Otherwise I will make the changes when I merge.

 Thanks again!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21349 [Core Tor/Tor]: Split up very long functions in entrynodes.c

[Tor Bug Tracker & Wiki]

#21349: Split up very long functions in entrynodes.c
+--
 Reporter:  nickm   |  Owner:  rl1987
 Type:  defect  | Status:
|  merge_ready
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.5.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Minor   | Resolution:
 Keywords:  refactor technical-debt tor-client  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  asn |Sponsor:
+--
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 LGTM! :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21349 [Core Tor/Tor]: Split up very long functions in entrynodes.c

[Tor Bug Tracker & Wiki]

#21349: Split up very long functions in entrynodes.c
+--
 Reporter:  nickm   |  Owner:  rl1987
 Type:  defect  | Status:
|  needs_review
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.5.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Minor   | Resolution:
 Keywords:  refactor technical-debt tor-client  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  asn |Sponsor:
+--
Changes (by rl1987):

 * status:  needs_revision => needs_review


Comment:

 https://github.com/torproject/tor/pull/202

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21349 [Core Tor/Tor]: Split up very long functions in entrynodes.c

[Tor Bug Tracker & Wiki]

#21349: Split up very long functions in entrynodes.c
+--
 Reporter:  nickm   |  Owner:  rl1987
 Type:  defect  | Status:
|  needs_revision
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.5.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Minor   | Resolution:
 Keywords:  refactor technical-debt tor-client  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  asn |Sponsor:
+--
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Thanks for the revisions! They look good to me, modulo the two minor
 things I pointed out in the new PR.

 IMO, you should also squash the three latest commits (122ad11, 5453dd8,
 d3fcbcb) in the previous commits so that it's easier for nickm to review
 and merge.

 I'm switching this to needs_revision for the above but we are almost done
 here!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21349 [Core Tor/Tor]: Split up very long functions in entrynodes.c

[Tor Bug Tracker & Wiki]

#21349: Split up very long functions in entrynodes.c
+--
 Reporter:  nickm   |  Owner:  rl1987
 Type:  defect  | Status:
|  needs_review
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.5.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Minor   | Resolution:
 Keywords:  refactor technical-debt tor-client  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  asn |Sponsor:
+--
Changes (by nickm):

 * milestone:  Tor: unspecified => Tor: 0.3.5.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21349 [Core Tor/Tor]: Split up very long functions in entrynodes.c

[Tor Bug Tracker & Wiki]

#21349: Split up very long functions in entrynodes.c
+--
 Reporter:  nickm   |  Owner:  rl1987
 Type:  defect  | Status:
|  needs_review
 Priority:  Medium  |  Milestone:  Tor:
|  unspecified
Component:  Core Tor/Tor|Version:
 Severity:  Minor   | Resolution:
 Keywords:  refactor technical-debt tor-client  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  asn |Sponsor:
+--
Changes (by rl1987):

 * status:  needs_revision => needs_review


Comment:

 Rebased and with fixups: https://github.com/torproject/tor/pull/200

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21349 [Core Tor/Tor]: Split up very long functions in entrynodes.c

[Tor Bug Tracker & Wiki]

#21349: Split up very long functions in entrynodes.c
+--
 Reporter:  nickm   |  Owner:  rl1987
 Type:  defect  | Status:
|  needs_revision
 Priority:  Medium  |  Milestone:  Tor:
|  unspecified
Component:  Core Tor/Tor|Version:
 Severity:  Minor   | Resolution:
 Keywords:  refactor technical-debt tor-client  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  asn |Sponsor:
+--
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Review done in the PR!

 Extremely good work here by rl1987 and really good simplifications all
 around!

 My review comments are mainly code-style and code-improvements, since I
 didn't manage to find a bug. The branch also needs to be rebased to latest
 master, since it doesn't merge cleanly currently because of all the
 various modularization improvements.

 Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21349 [Core Tor/Tor]: Split up very long functions in entrynodes.c

[Tor Bug Tracker & Wiki]

#21349: Split up very long functions in entrynodes.c
+--
 Reporter:  nickm   |  Owner:  rl1987
 Type:  defect  | Status:
|  needs_review
 Priority:  Medium  |  Milestone:  Tor:
|  unspecified
Component:  Core Tor/Tor|Version:
 Severity:  Minor   | Resolution:
 Keywords:  refactor technical-debt tor-client  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  asn |Sponsor:
+--
Changes (by asn):

 * reviewer:   => asn


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21349 [Core Tor/Tor]: Split up very long functions in entrynodes.c

[Tor Bug Tracker & Wiki]

#21349: Split up very long functions in entrynodes.c
+--
 Reporter:  nickm   |  Owner:  rl1987
 Type:  defect  | Status:
|  needs_review
 Priority:  Medium  |  Milestone:  Tor:
|  unspecified
Component:  Core Tor/Tor|Version:
 Severity:  Minor   | Resolution:
 Keywords:  refactor technical-debt tor-client  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by rl1987):

 * status:  accepted => needs_review


Comment:

 https://github.com/torproject/tor/pull/173

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21349 [Core Tor/Tor]: Split up very long functions in entrynodes.c

[Tor Bug Tracker & Wiki]

#21349: Split up very long functions in entrynodes.c
+--
 Reporter:  nickm   |  Owner:  rl1987
 Type:  defect  | Status:  accepted
 Priority:  Medium  |  Milestone:  Tor:
|  unspecified
Component:  Core Tor/Tor|Version:
 Severity:  Minor   | Resolution:
 Keywords:  refactor technical-debt tor-client  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by rl1987):

 * owner:  (none) => rl1987
 * status:  new => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21349 [Core Tor/Tor]: Split up very long functions in entrynodes.c

[Tor Bug Tracker & Wiki]

#21349: Split up very long functions in entrynodes.c
+--
 Reporter:  nickm   |  Owner:
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:  Tor:
|  unspecified
Component:  Core Tor/Tor|Version:
 Severity:  Minor   | Resolution:
 Keywords:  refactor technical-debt tor-client  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by nickm):

 * keywords:   => refactor technical-debt tor-client


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21349 [Core Tor/Tor]: Split up very long functions in entrynodes.c

[Tor Bug Tracker & Wiki]

#21349: Split up very long functions in entrynodes.c
--+--
 Reporter:  nickm |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Minor |   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 Some functions in entrynodes.c are now pretty huge, especially:
   * sampled_guards_update_from_consensus()
   * entry_guards_update_primary()
   * select_entry_guard_for_circuit()

 It would be good for testing and maintenance to split them up.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs