Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:  closed
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  authority-test-done, tor-dirauth,|  Actual Points:  0.3
  metrics-needs, tor-bwauth, |
  035-removed-20180711, 040-roadmap-proposed,|
  040-backport   |
Parent ID:  #25925   | Points:  0.2
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by teor):

 * keywords:
 authority-test-done, consider-backport-after-040-stable, tor-dirauth,
 metrics-needs, tor-bwauth, 035-removed-20180711, 040-roadmap-proposed,
 035-backport-maybe, 040-backport
 =>
 authority-test-done, tor-dirauth, metrics-needs, tor-bwauth,
 035-removed-20180711, 040-roadmap-proposed, 040-backport
 * status:  merge_ready => closed
 * milestone:  Tor: 0.3.5.x-final => Tor: 0.4.0.x-final
 * resolution:   => fixed
 * actualpoints:  0.2 => 0.3


Comment:

 This feature is too risky to backport: it caused #30001. And it looks like
 0.4.0 will be stable before metrics has finished their bandwidth file
 archiving and analysis code.

 Directory authorities that want their bandwidth files archived should
 upgrade to 0.4.0 when it is stable.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  authority-test-done, consider-   |  Actual Points:  0.2
  backport-after-040-stable, tor-dirauth,|
  metrics-needs, tor-bwauth, |
  035-removed-20180711, 040-roadmap-proposed,|
  035-backport-maybe, 040-backport   |
Parent ID:  #25925   | Points:  0.2
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by teor):

 * keywords:
 consider-backport-after-authority-test, consider-backport-
 after-040-stable, tor-dirauth, metrics-needs, tor-bwauth,
 035-removed-20180711, 040-roadmap-proposed, 035-backport-maybe,
 040-backport
 =>
 authority-test-done, consider-backport-after-040-stable, tor-dirauth,
 metrics-needs, tor-bwauth, 035-removed-20180711, 040-roadmap-proposed,
 035-backport-maybe, 040-backport


Comment:

 We have tested this code on moria1 and longclaw.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-authority-   |  Actual Points:  0.2
  test, consider-backport-after-040-stable,  |
  tor-dirauth, metrics-needs, tor-bwauth,|
  035-removed-20180711, 040-roadmap-proposed,|
  035-backport-maybe, 040-backport   |
Parent ID:  #25925   | Points:  0.2
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by teor):

 Actually, we decided not to backport #29897.

 So we need to backport https://github.com/torproject/tor/pull/852 and
 #30001.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-authority-   |  Actual Points:  0.2
  test, consider-backport-after-040-stable,  |
  tor-dirauth, metrics-needs, tor-bwauth,|
  035-removed-20180711, 040-roadmap-proposed,|
  035-backport-maybe, 040-backport   |
Parent ID:  #25925   | Points:  0.2
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by teor):

 We also need to backport #30001 if we backport this feature.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-authority-   |  Actual Points:  0.2
  test, consider-backport-after-040-stable,  |
  tor-dirauth, metrics-needs, tor-bwauth,|
  035-removed-20180711, 040-roadmap-proposed,|
  035-backport-maybe, 040-backport   |
Parent ID:  #25925   | Points:  0.2
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by teor):

 Once #29897 is reviewed and merged, we should backport:
 https://github.com/torproject/tor/pull/858

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-authority-   |  Actual Points:  0.2
  test, consider-backport-after-040-stable,  |
  tor-dirauth, metrics-needs, tor-bwauth,|
  035-removed-20180711, 040-roadmap-proposed,|
  035-backport-maybe, 040-backport   |
Parent ID:  #25925   | Points:  0.2
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by teor):

 * keywords:
 consider-backport-after-authority-test, consider-backport-
 after-040-stable, tor-dirauth, metrics-needs, tor-bwauth,
 035-removed-20180711, 040-roadmap-proposed, 035-backport-maybe, 040
 -backport-maybe
 =>
 consider-backport-after-authority-test, consider-backport-
 after-040-stable, tor-dirauth, metrics-needs, tor-bwauth,
 035-removed-20180711, 040-roadmap-proposed, 035-backport-maybe,
 040-backport
 * points:   => 0.2
 * actualpoints:   => 0.2
 * milestone:  Tor: 0.4.1.x-final => Tor: 0.3.5.x-final


Comment:

 The CI passed. Practracker is ok.

 Merged to 0.4.0 and later, marking for backport to 0.3.5, to be considered
 after 0.4.0 stable and an authority test.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-authority-   |  Actual Points:
  test, consider-backport-after-040-stable,  |
  tor-dirauth, metrics-needs, tor-bwauth,|
  035-removed-20180711, 040-roadmap-proposed,|
  035-backport-maybe, 040-backport-maybe |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by teor):

 ​https://github.com/torproject/tor/pull/852 failed due to #28229,
 rebuilding.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-authority-   |  Actual Points:
  test, consider-backport-after-040-stable,  |
  tor-dirauth, metrics-needs, tor-bwauth,|
  035-removed-20180711, 040-roadmap-proposed,|
  035-backport-maybe, 040-backport-maybe |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by teor):

 The refactor is in #29897, it's one simple commit, if we want to review
 and merge that PR instead.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-authority-   |  Actual Points:
  test, consider-backport-after-040-stable,  |
  tor-dirauth, metrics-needs, tor-bwauth,|
  035-removed-20180711, 040-roadmap-proposed,|
  035-backport-maybe, 040-backport-maybe |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by teor):

 * status:  needs_revision => merge_ready
 * keywords:
 consider-backport-after-authority-test, consider-backport-
 after-040-stable, tor-dirauth, metrics-needs, tor-bwauth,
 035-removed-20180711, 040-roadmap-proposed, 034-backport-maybe, 035
 -backport-maybe, 040-backport-maybe
 =>
 consider-backport-after-authority-test, consider-backport-
 after-040-stable, tor-dirauth, metrics-needs, tor-bwauth,
 035-removed-20180711, 040-roadmap-proposed, 035-backport-maybe, 040
 -backport-maybe


Comment:

 I think we should merge the code in this branch to 0.4.0 and master, then
 do the connection_dir_buf_add() refactor and backports in #29896 and
 #29897.

 Here are the pull requests, any merger can merge after CI passes:
 0.3.5: https://github.com/torproject/tor/pull/852
 master: https://github.com/torproject/tor/pull/853 (clean merge, testing
 only, I wonder if practracker will error)

 I tried rebasing to 0.3.4, and it wasn't clean, so we won't backport to
 0.3.4.
 (By the time we backport this feature, most authorities should be on
 0.3.5, or the new 0.4.0 stable.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-authority-   |  Actual Points:
  test, consider-backport-after-040-stable,  |
  tor-dirauth, metrics-needs, tor-bwauth,|
  035-removed-20180711, 040-roadmap-proposed,|
  034-backport-maybe, 035-backport-maybe, 040|
  -backport-maybe|
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by teor):

 * status:  needs_review => needs_revision
 * keywords:
 tor-dirauth, metrics-needs, tor-bwauth, 035-removed-20180711, 040
 -roadmap-proposed
 =>
 consider-backport-after-authority-test, consider-backport-
 after-040-stable, tor-dirauth, metrics-needs, tor-bwauth,
 035-removed-20180711, 040-roadmap-proposed, 034-backport-maybe, 035
 -backport-maybe, 040-backport-maybe


Comment:

 Replying to [comment:66 juga]:
 > I was asked in
 https://github.com/torproject/tor/pull/654/files#r258582166 to use the
 #28816 refactor that was just introduced.
 > I realized that it was not backported to 0.3.5, so i don't know how to
 do in this case:
 > - should i cherry pick that in 0.3.5?
 > - should this ticket code not use #28816 patch and create a ticket to
 refactor that in 0.4?

 I will backport connection_dir_buf_add() to 0.3.4 in #29896, without the
 other refactoring.
 Then you can rebase this branch on #29896.

 I don't know if we will backport this change to 0.3.4 yet.
 It is a new feature, and we usually do not backport features.
 But it is well-contained, so it is low-risk.

 Replying to [comment:67 juga]:
 > I also don't know why with #28816 patch it seems there is no need
 anymore to flush the compression state with
 `connection_buf_add_compress("", 0, conn, 1)`.

 connection_dir_buf_add() takes a Boolean "done" parameter, and passes it
 to connection_buf_add_compress().
 Since you are only adding one item to the buffer, done should be 1.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics-needs, tor- |  Actual Points:
  bwauth, 035-removed-20180711, 040-roadmap- |
  proposed   |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by juga):

 I also don't know why with #28816 patch it seems there is no need anymore
 to flush the compression state with `connection_buf_add_compress("", 0,
 conn, 1)`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics-needs, tor- |  Actual Points:
  bwauth, 035-removed-20180711, 040-roadmap- |
  proposed   |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by juga):

 * status:  needs_revision => needs_review


Comment:

 I was asked in https://github.com/torproject/tor/pull/654/files#r258582166
 to use the #28816 refactor that was just introduced.
 I realized that it was not backported to 0.3.5, so i don't know how to do
 in this case:
 - should i cherry pick that in 0.3.5?
 - should this ticket code not use #28816 patch and create a ticket to
 refactor that in 0.4?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics-needs, tor- |  Actual Points:
  bwauth, 035-removed-20180711, 040-roadmap- |
  proposed   |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by teor):

 * keywords:
 tor-dirauth, metrics, tor-bwauth, 035-removed-20180711, 040-roadmap-
 proposed
 =>
 tor-dirauth, metrics-needs, tor-bwauth, 035-removed-20180711, 040
 -roadmap-proposed


Comment:

 We need to get this code in 0.4.1, so that we can archive bandwidth files
 from authorities.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by teor):

 Replying to [comment:63 juga]:
 > Oh, do the children tickets need to be closed before?.
 > (In this case i thought that they were improvements that could be solved
 later and would need to be unparented to close this ticket first.)
 > In that case i would wait for #28815 before adapting the code to #28816,
 unless there's a better strategy.

 We can do #28815 later, and #26694 after we merge this ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by juga):

 Oh, do the children tickets need to be closed before?.
 (In this case i thought that they were improvements that could be solved
 later and would need to be unparented to close this ticket first.)
 In that case i would wait for #28815 before adapting the code to #28816,
 unless there's a better strategy.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by dgoulet):

 * status:  merge_ready => needs_revision


Comment:

 See comments on the PR. Don't hesitate to rebase on master here to use the
 new function as I pointed out.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by nickm):

 * milestone:  Tor: 0.4.0.x-final => Tor: 0.4.1.x-final


Comment:

 Okay, looks reasonable to me. Let's take it first thing in 0.4.1.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by juga):

 Replying to [comment:58 nickm]:
 > Could someone please prepare a squashed branch for me to merge?  When I
 try to use "git-rebase" to squash all the fixup commits, I get conflicts.

 https://github.com/torproject/tor/pull/654

 Probably it's better you also squash all the commits in one, since most of
 them are small fixes to the previous commits.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by teor):

 Replying to [comment:57 juga]:
 > Replying to [comment:51 teor]:
 > > Maybe the best place for this test is in stem?
 > > We could open a ticket for a stem integration test that tests
 bandwidth files.
 > > Do you think this test is worth adding? Will it catch future bugs?
 >
 > I talked with atagar in #tor-dev, and there'd be the same problem in
 stem, it does not run a test network. Maybe it can be mocked all that
 dirauth needs before serving the bandwidth file, but i didn't see and easy
 way to do it.

 Why do you think we need a test network?

 Replying to [comment:51 teor]:
 > We don't need a test network, we just need a single tor instance.
 > We have some tor integration tests already:
 > https://gitweb.torproject.org/tor.git/tree/src/test/test_rebind.sh
 >
 > But we would need to configure the tor instance as a directory
 authority. So we would need to run tor-gencert to generate the authority
 keys. And require stem.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by nickm):

 Could someone please prepare a squashed branch for me to merge?  When I
 try to use "git-rebase" to squash all the fixup commits, I get conflicts.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by juga):

 Replying to [comment:51 teor]:
 > Maybe the best place for this test is in stem?
 > We could open a ticket for a stem integration test that tests bandwidth
 files.
 > Do you think this test is worth adding? Will it catch future bugs?

 I talked with atagar in #tor-dev, and there'd be the same problem in stem,
 it does not run a test network. Maybe it can be mocked all that dirauth
 needs before serving the bandwidth file, but i didn't see and easy way to
 do it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by juga):

 Replying to [comment:55 nickm]:
 > Fine by me -- only, which PR do I merge here?  I'm looking for links,
 but this is a looong ticket :)

 https://github.com/torproject/tor/pull/468

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by nickm):

 Fine by me -- only, which PR do I merge here?  I'm looking for links, but
 this is a looong ticket :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 LGTM, let's get it in :-)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by juga):

 * status:  needs_revision => needs_review


Comment:

 I added the comment and change the log message.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by ahf):

 * status:  needs_review => needs_revision


Comment:

 Two minor comments added, but other than that I think it looks good.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by teor):

 Replying to [comment:50 juga]:
 > Replying to [comment:49 teor]:
 > > > You think this is valid test and this can be merged?.
 > >
 > > As long as we can get stem 1.7, it seems like a good test.
 >
 > Hmm, i didn't mean to include the python code as a test in tor code,
 since the test in C already checks the header
 (https://github.com/torproject/tor/pull/468/files#diff-
 a63a60330b655aa123b096768848f5bfR2552), but to manually extra check that i
 can actually get the bandwidth file in a test network.
 > I currently don't know how it'd be possible to run a test network when
 running tor tests and include this code as an stem test.

 We don't need a test network, we just need a single tor instance.
 We have some tor integration tests already:
 https://gitweb.torproject.org/tor.git/tree/src/test/test_rebind.sh

 But we would need to configure the tor instance as a directory authority.
 So we would need to run tor-gencert to generate the authority keys. And
 require stem.

 Maybe the best place for this test is in stem?
 We could open a ticket for a stem integration test that tests bandwidth
 files.
 Do you think this test is worth adding? Will it catch future bugs?

 > So the question is then, is it fine the PR as it is?.

 I think the PR is ok without the test.
 But ahf still needs to review your changes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by juga):

 Replying to [comment:49 teor]:
 > > You think this is valid test and this can be merged?.
 >
 > As long as we can get stem 1.7, it seems like a good test.

 Hmm, i didn't mean to include the python code as a test in tor code, since
 the test in C already checks the header
 (https://github.com/torproject/tor/pull/468/files#diff-
 a63a60330b655aa123b096768848f5bfR2552), but to manually extra check that i
 can actually get the bandwidth file in a test network.
 I currently don't know how it'd be possible to run a test network when
 running tor tests and include this code as an stem test.

 So the question is then, is it fine the PR as it is?.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by teor):

 > You think this is valid test and this can be merged?.

 As long as we can get stem 1.7, it seems like a good test.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by juga):

 Replying to [comment:47 teor]:
 > I think nickm's comments might be the cause of your issue:

 yes, that makes sense

 > is the test actually running the compression code?

 the test is using the compression code implemented in
 `directory_handle_command_get`, but because the file is wrote with
 `connection_write_to_buf_mock` (`connection_buf_add_compress` is not
 mocked), `fetch_from_buf_http` gets the content uncompressed (the headers
 are fine).

 I'm not sure how difficult would be to mock `connection_buf_add_compress`.
 For now i added fixups to the non-wip PR
 (https://github.com/torproject/tor/pull/468) with the mistakes in the
 implementation. Then run a test network and retrieved the bandwidth file
 from an authority using stem:
 {{{
 >>>
 ... import stem.descriptor
 ... import stem.descriptor.remote
 ... import stem.directory
 >>> downloader = stem.descriptor.remote.DescriptorDownloader(
 ...   document_handler = stem.descriptor.DocumentHandler.DOCUMENT,
 ... )
 >>> resource = '/tor/status-vote/next/bandwidth'
 >>> query_args = {'endpoints': [('127.10.0.1', 2003)]}
 >>> bw = downloader.query(resource, **query_args)
 >>> bw.content
 
b'1544811454\nversion=1.2.0\nearliest_bandwidth=2018-12-12T15:02:35\nfile_created=2018-12-15T08:09:48\ngenerator_started=2018-12-15T08:06:50\nlatest_bandwidth=2018-12-14T18:17:34\nminimum_number_eligible_relays=3820\nminimum_percent_eligible_relays=60\nnumber_consensus_relays=6366\nnumber_eligible_relays=0\npercent_eligible_relays=0\nsoftware=sbws\nsoftware_version=1.0.3-dev0\n='
 >>> bw.compression
 ['identity']
 >>> resource = '/tor/status-vote/next/bandwidth.z'
 >>> bw = downloader.query(resource, **query_args)
 >>> bw.content
 
b'1544811454\nversion=1.2.0\nearliest_bandwidth=2018-12-12T15:02:35\nfile_created=2018-12-15T08:09:48\ngenerator_started=2018-12-15T08:06:50\nlatest_bandwidth=2018-12-14T18:17:34\nminimum_number_eligible_relays=3820\nminimum_percent_eligible_relays=60\nnumber_consensus_relays=6366\nnumber_eligible_relays=0\npercent_eligible_relays=0\nsoftware=sbws\nsoftware_version=1.0.3-dev0\n='
 >>> bw.compression
 ['gzip']
 }}}

 You think this is valid test and this can be merged?.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by teor):

 Replying to [comment:45 juga]:
 > Replying to [comment:44 teor]:
 > [...]
 > > Please open pull requests for code questions and CI, even if the code
 doesn't work yet.
 >
 > is this a net-team preference or your personal preference?.

 It's common practice within the team.

 > I'm sorry that i learn about preferred working methods by try/error. I
 don't think this is documented anywhere and IRC questions don't work well
 with our timezones.

 That's ok, we are all still working out how we want to use GitHub.

 > > > i've left new comments after setting the compression state.
 > >
 > > I'm not sure how to find the new code, or the CI for that code.
 >
 > Sorry, there was not new code pushed to the branch, i thought it was
 possible to follow the comments without the code.
 > > When you ask questions, please open a pull request.
 >
 > ~~https://github.com/juga0/tor/commits/ticket21377_035_01_work~~
 > https://github.com/torproject/tor/pull/610
 >
 > Because it's the same branch, the previous comments/questions can be
 seen in the PR.
 >
 > Edit: link to the PR, not the branch

 Thanks!

 I think nickm's comments might be the cause of your issue: is the test
 actually running the compression code?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by juga):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by juga):

 Replying to [comment:44 teor]:
 [...]
 > Please open pull requests for code questions and CI, even if the code
 doesn't work yet.

 is this a net-team preference or your personal preference?.
 I'm sorry that i learn about preferred working methods by try/error. I
 don't think this is documented anywhere and IRC questions don't work well
 with our timezones.

 > > i've left new comments after setting the compression state.
 >
 > I'm not sure how to find the new code, or the CI for that code.

 Sorry, there was not new code pushed to the branch, i thought it was
 possible to follow the comments without the code.

 > When you ask questions, please open a pull request.

 https://github.com/juga0/tor/commits/ticket21377_035_01_work

 Because it's the same branch, the previous comments/questions can be seen
 in the PR.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by teor):

 Replying to [comment:43 juga]:
 > Replying to [comment:42 teor]:
 > > It looks like you're setting the compression state, then adding the
 data uncompressed.
 > >
 > > You didn't open a pull request, so I commented on the commit:
 > >
 
https://github.com/torproject/tor/commit/b03091842bc4590e11e3ac026daae8ed6d8f7554#r31629291
 > >
 
https://github.com/torproject/tor/commit/b03091842bc4590e11e3ac026daae8ed6d8f7554#r31629096
 >
 > I didn't create a PR, cause i knew that code fails, but wanted to ask
 about it.

 Please open pull requests for code questions and CI, even if the code
 doesn't work yet.

 When you open a pull request:
 * comments are easier to make and easier to find
 * new commits get handled better
 * the CI is done on a merge with master, so any bugs fixed in master are
 fixed in the CI

 If you don't want a pull request merged, put the ticket in needs_review,
 and say that the code doesn't work.

 Some people also put "WIP" or "work in progress" in the pull request
 title:
 https://stackoverflow.com/a/39741877

 > i've left new comments after setting the compression state.

 I'm not sure how to find the new code, or the CI for that code.

 I tried looking at your branches, but they haven't changed:
 https://github.com/juga0/tor/branches

 When you ask questions, please open a pull request.
 (Or link to a branch, or a commit. But a pull request is better.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by juga):

 Replying to [comment:42 teor]:
 > It looks like you're setting the compression state, then adding the data
 uncompressed.
 >
 > You didn't open a pull request, so I commented on the commit:
 >
 
https://github.com/torproject/tor/commit/b03091842bc4590e11e3ac026daae8ed6d8f7554#r31629291
 >
 
https://github.com/torproject/tor/commit/b03091842bc4590e11e3ac026daae8ed6d8f7554#r31629096

 I didn't create a PR, cause i knew that code fails, but wanted to ask
 about it.
 i've left new comments after setting the compression state.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by teor):

 It looks like you're setting the compression state, then adding the data
 uncompressed.

 You didn't open a pull request, so I commented on the commit:
 
https://github.com/torproject/tor/commit/b03091842bc4590e11e3ac026daae8ed6d8f7554#r31629291
 
https://github.com/torproject/tor/commit/b03091842bc4590e11e3ac026daae8ed6d8f7554#r31629096

 I also opened:
 * #28815 to clean up the copied code,
 * #28816 to log a bug warning when uncompressed data is added to a
 compressed connection
 You don't have to do these tickets: they are not on the roadmap.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by juga):

 Replying to [comment:40 juga]:
 > I put them in code comments. Created also a pastebin with logs only for
 that test and log level debug: https://paste.debian.net/1054163/

 Now in https://paste.debian.net/hidden/23b3c78e/

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by juga):

 I put them in code comments. Created also a pastebin with logs only for
 that test and log level debug: https://paste.debian.net/1054163/

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by teor):

 Ah, the tests are here:
 https://travis-ci.org/juga0/tor/builds/462787217

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by teor):

 Replying to [comment:37 juga]:
 > Replying to [comment:36 teor]:
 >
 > > > If i call detect_compression_method, as
 test_dir_handle_get_status_vote_current_consensus_ns is doing:
 
https://github.com/torproject/tor/blob/8020d6fb05d9477e77c6ca554dc1288873f6115c/src/test/test_dir_handle_get.c#L1875,
 it will say the compression method is UNKNOWN_METHOD, instead of
 ZLIB_METHOD. What i'm doing wroing?
 > >
 > > I don't understand what you mean here.
 > > If you're calling the new code in the test, you have to add headers to
 the request.
 > > Otherwise, the new code should return NO_METHOD.
 > >
 > > I don't understand how you are getting UNKNOWN_METHOD.
 > > Please show me the code you are using, and the logs of the results.
 >
 >
 
https://github.com/torproject/tor/commit/b03091842bc4590e11e3ac026daae8ed6d8f7554

 I can't find the logs of the results. Can you put them in a pastebin?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by juga):

 Replying to [comment:36 teor]:

 > > If i call detect_compression_method, as
 test_dir_handle_get_status_vote_current_consensus_ns is doing:
 
https://github.com/torproject/tor/blob/8020d6fb05d9477e77c6ca554dc1288873f6115c/src/test/test_dir_handle_get.c#L1875,
 it will say the compression method is UNKNOWN_METHOD, instead of
 ZLIB_METHOD. What i'm doing wroing?
 >
 > I don't understand what you mean here.
 > If you're calling the new code in the test, you have to add headers to
 the request.
 > Otherwise, the new code should return NO_METHOD.
 >
 > I don't understand how you are getting UNKNOWN_METHOD.
 > Please show me the code you are using, and the logs of the results.

 
https://github.com/torproject/tor/commit/b03091842bc4590e11e3ac026daae8ed6d8f7554

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by teor):

 Replying to [comment:35 juga]:
 > Replying to [comment:34 teor]:
 > > >   * Should we be passing "len" to write_http_response_header when
 compression is in use?  I'm not sure what is correct here.
 > >
 > > If it is present, Content-Length must be the length of the encoded
 data.
 > >
 > > > Maybe we're supposed to send the compressed length if compression is
 in use?
 > >
 > > When we deliver compressed replies in other code, we don't provide
 Content-Length:
 > >
 
https://github.com/torproject/tor/blob/8020d6fb05d9477e77c6ca554dc1288873f6115c/src/feature/dircache/dircache.c#L1293
 >
 > I verified that there's not Content-Length in the header doing that.

 I don't understand what you mean.
 If you pass a zero or positive length, then the code sets Content-Length.
 I added a suggested fix on the pull request.

 > If i call detect_compression_method, as
 test_dir_handle_get_status_vote_current_consensus_ns is doing:
 
https://github.com/torproject/tor/blob/8020d6fb05d9477e77c6ca554dc1288873f6115c/src/test/test_dir_handle_get.c#L1875,
 it will say the compression method is UNKNOWN_METHOD, instead of
 ZLIB_METHOD. What i'm doing wroing?

 I don't understand what you mean here.
 If you're calling the new code in the test, you have to add headers to the
 request.
 Otherwise, the new code should return NO_METHOD.

 I don't understand how you are getting UNKNOWN_METHOD.
 Please show me the code you are using, and the logs of the results.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by juga):

 Replying to [comment:34 teor]:
 > >   * Should we be passing "len" to write_http_response_header when
 compression is in use?  I'm not sure what is correct here.
 >
 > If it is present, Content-Length must be the length of the encoded data.
 >
 > > Maybe we're supposed to send the compressed length if compression is
 in use?
 >
 > When we deliver compressed replies in other code, we don't provide
 Content-Length:
 >
 
https://github.com/torproject/tor/blob/8020d6fb05d9477e77c6ca554dc1288873f6115c/src/feature/dircache/dircache.c#L1293

 I verified that there's not Content-Length in the header doing that.

 If i call detect_compression_method, as
 test_dir_handle_get_status_vote_current_consensus_ns is doing:
 
https://github.com/torproject/tor/blob/8020d6fb05d9477e77c6ca554dc1288873f6115c/src/test/test_dir_handle_get.c#L1875,
 it will say the compression method is UNKNOWN_METHOD, instead of
 ZLIB_METHOD. What i'm doing wroing?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by teor):

 Replying to [comment:33 nickm]:
 > This looks solid, but I have some requests and questions:
 >   * Could we please have a changes file?
 >   * Should we be passing "len" to write_http_response_header when
 compression is in use?  I'm not sure what is correct here.

 If it is present, Content-Length must be the length of the encoded data.

 > Maybe we're supposed to send the compressed length if compression is in
 use?

 When we deliver compressed replies in other code, we don't provide
 Content-Length:
 
https://github.com/torproject/tor/blob/8020d6fb05d9477e77c6ca554dc1288873f6115c/src/feature/dircache/dircache.c#L1293

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => needs_revision


Comment:

 This looks solid, but I have some requests and questions:
   * Could we please have a changes file?
   * Should we be passing "len" to write_http_response_header when
 compression is in use?  I'm not sure what is correct here.  Maybe we're
 supposed to send the compressed length if compression is in use?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 LGTM now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by juga):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by ahf):

 * status:  needs_review => needs_revision


Comment:

 Left some minor stylistic comments on the PR, but code looks overall very
 good.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by asn):

 * reviewer:   => ahf


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * milestone:  Tor: unspecified => Tor: 0.4.0.x-final


Comment:

 This is a new feature with code: it belongs in the next feature release.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 036-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by starlight):

 * cc: starlight@… (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 036-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by juga):

 * status:  needs_revision => needs_review


Comment:

 New commits

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 036-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by dgoulet):

 * status:  needs_review => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 036-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by juga):

 * status:  needs_revision => needs_review


Comment:

 Fixed CI

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 036-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by juga):

 Replying to [comment:21 teor]:
 > juga, I'm not sure if you get emails from appveyor or travis when builds
 fail? Or if you're in the #tor-ci channel?

 yes i do. I just was not going to work on it at the moment i saw it, but i
 should have removed "need_review".

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 036-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 All the CI on this branch failed.

 juga, I'm not sure if you get emails from appveyor or travis when builds
 fail? Or if you're in the #tor-ci channel?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 036-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 Note for the review assigner:

 ahf wants to review tor bandwidth authority patches.

 Note for the reviewer:

 Let's get a simple version of this patch working first. The simplest
 version sends the bandwidth file that is on disk right now.

 Then we can follow up with:
 * #27047: authorities should keep recent consensuses, votes, and bandwidth
 files
 * #26797: read the file once per vote, and use the cached file for votes
 and bandwidth file requests
 * #26698: put a hash of the bandwidth file in the vote

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 036-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by juga):

 * cc: teor (removed)
 * status:  accepted => needs_review


Comment:

 https://github.com/torproject/tor/pull/468

 I'm not sure i've implemented in the right way, maybe it should be call
 from handle_get_next_vote, or somehow check that the bandwidth file that
 used in the vote is the same being read from options->V3BandwidthsFile.
 Maybe the hash of the file should be stored somewhere?.
 Should some maximum size be check?.
 Would be the timeline of the file working as expected?.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  accepted
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 036-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * keywords:
 tor-dirauth, metrics, tor-bwauth, 035-removed-20180711, 035-roadmap-
 proposed
 =>
 tor-dirauth, metrics, tor-bwauth, 035-removed-20180711, 036-roadmap-
 proposed


Comment:

 0.3.5 is closed to new features, moving to 0.3.6 proposed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  accepted
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 035-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 The refactor in #26797 will involve storing a copy of the bandwidth file
 in RAM or on disk, so let's do it first.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  accepted
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 035-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * keywords:  tor-dirauth, metrics, tor-bwauth, 035-removed-20180711 =>
 tor-dirauth, metrics, tor-bwauth, 035-removed-20180711, 035-roadmap-
 proposed


Comment:

 We would like to implement this ticket in 0.3.5, but we want a working
 bandwidth scanner first.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
+--
 Reporter:  tom |  Owner:  juga
 Type:  enhancement | Status:  accepted
 Priority:  High|  Milestone:  Tor:
|  0.3.5.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-dirauth metrics tor-bwauth  |  Actual Points:
Parent ID:  #25925  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by cypherpunks):

 (diff)
 11:08 AM Ticket #21377 (DirAuths should expose bwauth bandwidth files)
 updated by juga
 Status changed
 11:07 AM Ticket #21377 (DirAuths should expose bwauth bandwidth files)
 updated by juga
 Changes to dir-spec commented …
 10:30 AM Tickets #25242,25673,25861 batch updated by irl
 Owner, Status changed
 Working on this this week.
 10:23 AM Ticket #24153 (Make DescriptorCollector resume previously aborted
 downloads) updated by irl
 Status changed
 Looks good to me. For the new ticket: Files.createTempFile only …
 10:20 AM Ticket #3723 (Report version of bwscanners in votes) updated by
 juga
 Sorry, there were new commits on master touching parts of that code …
 10:14 AM Ticket #24546 (Use tor_addr_is_v4() rather than family, or reject
 all v6-mapped IPv4 ...) updated by ahf
 Status changed
 The patches looks good to me, but there is a big merge conflict right
 …
 10:09 AM Ticket #26374 (MacOS Sandbox) updated by ahf
 Started some early refactoring work for this to be possible in …
 10:07 AM Ticket #20224 (Fix `BridgeDescriptorMappingsLimit` config option)
 updated by irl
 Status changed
 Looks good to me.
 9:42 AM Ticket #26193 (Tarballs are not compressed in a run following an
 aborted run) updated by irl
 Status changed
 Looks good to me. I don't think there is a need to combine the tar …
 9:34 AM Ticket #24291 (Rename CollecTor packages) updated by irl
 Status changed
 Looks good to me.
 9:31 AM Ticket #18342 (Provide more accurate reverse DNS results) updated
 by irl
 Status changed

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
+--
 Reporter:  tom |  Owner:  juga
 Type:  enhancement | Status:  accepted
 Priority:  High|  Milestone:  Tor:
|  0.3.5.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-dirauth metrics tor-bwauth  |  Actual Points:
Parent ID:  #25925  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by cypherpunks):

 12:34 PM Ticket #21377 (DirAuths should expose bwauth bandwidth files)
 updated by teor
 Parent ID changed
 12:34 PM Ticket #26692 (sbws must not overwrite the bandwidth file, to
 avoid race conditions) updated by teor
 Parent ID changed
 12:34 PM Ticket #26193 (Tarballs are not compressed in a run following an
 aborted run) closed by karsten
 fixed: Great! Fixed in master. Closing. Thanks!
 12:33 PM Ticket #26692 (sbws must not overwrite the bandwidth file, to
 avoid race conditions) updated by teor
 Parent ID changed
 12:24 PM Ticket #24291 (Rename CollecTor packages) closed by karsten
 fixed: Thanks for checking! Merged to master. Closing.
 12:20 PM Ticket #18342 (Provide more accurate reverse DNS results) updated
 by karsten
 Status changed
 Please find …
 12:19 PM Ticket #25164 (Reproducible Tor Browser for Android builds)
 updated by boklm
 Parent ID changed
 12:18 PM Ticket #26693 (Integrate Tor Browser for Android into tor-
 browser-build) updated by boklm
 Parent ID changed
 12:16 PM Ticket #26697 (Add Android toolchain) created by boklm
 We need to add a projects/android-toolchain directory which will …
 12:10 PM Ticket #26696 (Add definition for new platform in rbm.conf)
 created by boklm
 In order to be able to integrate Tor Browser for Android into …
 12:07 PM org/meetings/2018MexicoCity edited by karsten
 (diff)
 12:06 PM Ticket #25533 (Relay properties page: Link all properties and
 flags in page) updated by irl
 Status changed
 Fixed in f439a7dc in my relaysearch-dev branch.
 12:05 PM Ticket #26695 (List components required to build Tor Browser for
 Android) created by boklm
 In order to integrate Tor Browser for Android into tor-browser-build,
 …
 12:02 PM Ticket #21377 (DirAuths should expose bwauth bandwidth files)
 updated by juga
 Created #26694 for the spec changes.
 12:02 PM Ticket #26694 (dir-spec: DirAuths should expose bwauth bandwidth
 files) created by juga
 This ticket is for changing dir-spec to implement #21377

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
+--
 Reporter:  tom |  Owner:  juga
 Type:  enhancement | Status:  accepted
 Priority:  High|  Milestone:  Tor:
|  0.3.5.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-dirauth metrics tor-bwauth  |  Actual Points:
Parent ID:  #25925  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by juga):

 * owner:  (none) => juga
 * status:  needs_revision => accepted


Comment:

 Changing status since the ticket for the spec is #26694

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
+--
 Reporter:  tom |  Owner:  (none)
 Type:  enhancement | Status:
|  needs_revision
 Priority:  High|  Milestone:  Tor:
|  0.3.5.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-dirauth metrics tor-bwauth  |  Actual Points:
Parent ID:  #25925  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by teor):

 * parent:   => #25925


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
+--
 Reporter:  tom |  Owner:  (none)
 Type:  enhancement | Status:
|  needs_revision
 Priority:  High|  Milestone:  Tor:
|  0.3.5.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-dirauth metrics tor-bwauth  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by juga):

 Created #26694 for the spec changes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
+--
 Reporter:  tom |  Owner:  (none)
 Type:  enhancement | Status:
|  needs_revision
 Priority:  High|  Milestone:  Tor:
|  0.3.5.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-dirauth metrics tor-bwauth  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by teor):

 * status:  needs_review => needs_revision
 * milestone:  Tor: unspecified => Tor: 0.3.5.x-final


Comment:

 Replying to [comment:9 juga]:
 > Changes to dir-spec commented
 https://trac.torproject.org/projects/tor/ticket/21378#comment:7
 implemented in my branch.

 I think the pull request is:
 https://github.com/torproject/torspec/pull/21

 In future, please link to the branch or pull request, so I know which one
 you want me to review.

 > Please let me know if i should create a different ticket for the spec.

 Yes, please open a different ticket, otherwise this ticket will close when
 we merge the spec.

 Please see my comments on the pull request.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
+--
 Reporter:  tom |  Owner:  (none)
 Type:  enhancement | Status:  needs_review
 Priority:  High|  Milestone:  Tor:
|  unspecified
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-dirauth metrics tor-bwauth  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by juga):

 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
+--
 Reporter:  tom |  Owner:  (none)
 Type:  enhancement | Status:  new
 Priority:  High|  Milestone:  Tor:
|  unspecified
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-dirauth metrics tor-bwauth  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by juga):

 Changes to dir-spec commented
 
https://trac.torproject.org/projects/tor/timeline?from=2018-06-15T23%3A07%3A13Z=second
 implemented in my branch.
 Please let me know if i should create a different ticket for the spec.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
+--
 Reporter:  tom |  Owner:  (none)
 Type:  enhancement | Status:  new
 Priority:  High|  Milestone:  Tor:
|  unspecified
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-dirauth metrics tor-bwauth  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by juga):

 My mistake, didn't re-read the title of the ticket.
 No, sbws does not fix this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files (was: DirAuths should expose bwauth votes)

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
+--
 Reporter:  tom |  Owner:  (none)
 Type:  enhancement | Status:  new
 Priority:  High|  Milestone:  Tor:
|  unspecified
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-dirauth metrics tor-bwauth  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by teor):

 Replying to [comment:4 juga]:
 > This is now fixed in `sbws`, though is still not being use by any
 DirAuth.
 >
 > It is not planned to add this to `Torflow`.

 This ticket is about archiving the entire v3bw file, not just the headers.

 Can you explain how this is fixed in sbws?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs