Re: [tor-bugs] #21641 [Core Tor/Tor]: Prop274: Rotate onion keys less frequently

[Tor Bug Tracker & Wiki]

#21641: Prop274: Rotate onion keys less frequently
---+
 Reporter:  nickm  |  Owner:  ahf
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:  implemented
 Keywords:  TorCoreTeam201703  |  Actual Points:  2.1
Parent ID: | Points:  2
 Reviewer:  nickm  |Sponsor:  Sponsor4
---+
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => implemented


Comment:

 LGTM; Squashed and merged.  This should begin having a modest effect on
 directory bandwidth immediately, which will grow as more relays upgrade.
 We should keep an eye on upgraded relays, of course, to make sure that
 they don't have any weird side effects from the increased interval.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21641 [Core Tor/Tor]: Prop274: Rotate onion keys less frequently

[Tor Bug Tracker & Wiki]

#21641: Prop274: Rotate onion keys less frequently
---+
 Reporter:  nickm  |  Owner:  ahf
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  TorCoreTeam201703  |  Actual Points:  2.1
Parent ID: | Points:  2
 Reviewer:  nickm  |Sponsor:  Sponsor4
---+
Changes (by ahf):

 * status:  needs_revision => needs_review


Comment:

 I've updated my branch with a set of fixup commits and one additional
 "real" commit.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21641 [Core Tor/Tor]: Prop274: Rotate onion keys less frequently

[Tor Bug Tracker & Wiki]

#21641: Prop274: Rotate onion keys less frequently
---+
 Reporter:  nickm  |  Owner:  ahf
 Type:  defect | Status:  needs_revision
 Priority:  Medium |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  TorCoreTeam201703  |  Actual Points:  2.1
Parent ID: | Points:  2
 Reviewer:  nickm  |Sponsor:  Sponsor4
---+
Changes (by nickm):

 * status:  needs_review => needs_revision
 * reviewer:   => nickm


Comment:

 Looks good!

 Suggestions:
* When a time interval (like MIN/MAX/DEFAULT_ONION_KEY_LIFETIME) has a
 unit other than seconds, put the unit in the name.  (eg,
 "MIN_ONION_KEY_LIFETIME_DAYS").  Otherwise people tend to assume seconds.
 Same for DEFAULT/MIN onion_key_grace_period.
* Maybe we should check whether the onion key is expired more
 frequently than the get_onion_key_lifetime() interval? -- otherwise, if
 the interval changes in the consensus, we won't reach the interior of
 rotate_onion_key_callback().  Same for the other callback.
* The documentation for expire_old_onion_keys should make it clear that
 the function doesn't perform a grace period check.
* This branch needs a changes file.

 (Also please remember when you make these changes, fixup commits are
 easier to review than a completely new or rebased branch.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21641 [Core Tor/Tor]: Prop274: Rotate onion keys less frequently

[Tor Bug Tracker & Wiki]

#21641: Prop274: Rotate onion keys less frequently
---+
 Reporter:  nickm  |  Owner:  ahf
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  TorCoreTeam201703  |  Actual Points:  2.1
Parent ID: | Points:  2
 Reviewer: |Sponsor:  Sponsor4
---+
Changes (by ahf):

 * status:  accepted => needs_review
 * actualpoints:   => 2.1


Comment:

 I've added a patch set that is ready for review in my Gitlab branch
 'bugs/21641': https://gitlab.com/ahf/tor/commits/bugs/21641

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21641 [Core Tor/Tor]: Prop274: Rotate onion keys less frequently

[Tor Bug Tracker & Wiki]

#21641: Prop274: Rotate onion keys less frequently
---+
 Reporter:  nickm  |  Owner:  ahf
 Type:  defect | Status:  accepted
 Priority:  Medium |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  TorCoreTeam201703  |  Actual Points:
Parent ID: | Points:  2
 Reviewer: |Sponsor:  Sponsor4
---+
Changes (by ahf):

 * status:  assigned => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21641 [Core Tor/Tor]: Prop274: Rotate onion keys less frequently

[Tor Bug Tracker & Wiki]

#21641: Prop274: Rotate onion keys less frequently
---+
 Reporter:  nickm  |  Owner:  ahf
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  TorCoreTeam201703  |  Actual Points:
Parent ID: | Points:  2
 Reviewer: |Sponsor:  Sponsor4
---+
Changes (by nickm):

 * keywords:   => TorCoreTeam201703


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21641 [Core Tor/Tor]: Prop274: Rotate onion keys less frequently

[Tor Bug Tracker & Wiki]

#21641: Prop274: Rotate onion keys less frequently
--+
 Reporter:  nickm |  Owner:  ahf
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  2
 Reviewer:|Sponsor:  Sponsor4
--+
Changes (by nickm):

 * status:  new => assigned
 * owner:   => ahf


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21641 [Core Tor/Tor]: Prop274: Rotate onion keys less frequently

[Tor Bug Tracker & Wiki]

#21641: Prop274: Rotate onion keys less frequently
--+
 Reporter:  nickm |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:  2 |   Reviewer:
  Sponsor:  Sponsor4  |
--+
 Let's implement proposal 274: This proposal will save a fair amount of
 bandwidth now, and even more once we have consensus diffs.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs