Re: [tor-bugs] #21643 [Core Tor/Tor]: Prop140: Extract, test, revise, and clean the diff code

[Tor Bug Tracker & Wiki]

#21643: Prop140: Extract, test, revise, and clean the diff code
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  TorCoreTeam201703, prop140, review-  |  Actual Points:  2
  group-17   |
Parent ID:  #13339   | Points:  3
 Reviewer:  ahf  |Sponsor:
 |  Sponsor4
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Okay -- I've squashed this and merged it into tor, and I've added the
 fuzzing corpora to the tor-fuzzing-corpora repository.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21643 [Core Tor/Tor]: Prop140: Extract, test, revise, and clean the diff code

[Tor Bug Tracker & Wiki]

#21643: Prop140: Extract, test, revise, and clean the diff code
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorCoreTeam201703, prop140, review-  |  Actual Points:  2
  group-17   |
Parent ID:  #13339   | Points:  3
 Reviewer:  ahf  |Sponsor:
 |  Sponsor4
-+-
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 Looks like all GL issues have been resolved. Looks good to me.

 I don't know if we have other code that could benefit from doing base64
 comparison without first decoding the base64 encoded buffer and then do a
 `memcmp()`, but if we have then it could be useful to lift that code out
 of the consdiff specific code.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21643 [Core Tor/Tor]: Prop140: Extract, test, revise, and clean the diff code

[Tor Bug Tracker & Wiki]

#21643: Prop140: Extract, test, revise, and clean the diff code
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorCoreTeam201703, prop140, review-  |  Actual Points:  2
  group-17   |
Parent ID:  #13339   | Points:  3
 Reviewer:  ahf  |Sponsor:
 |  Sponsor4
-+-
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 I believe I've addressed all the gitlab comments.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21643 [Core Tor/Tor]: Prop140: Extract, test, revise, and clean the diff code

[Tor Bug Tracker & Wiki]

#21643: Prop140: Extract, test, revise, and clean the diff code
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorCoreTeam201703, prop140, review-  |  Actual Points:  2
  group-17   |
Parent ID:  #13339   | Points:  3
 Reviewer:  ahf  |Sponsor:
 |  Sponsor4
-+-
Changes (by ahf):

 * status:  needs_review => needs_revision


Comment:

 Code review is progressing on Gitlab - still a few minor things to fix
 there. Marking this `needs_revision` for now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21643 [Core Tor/Tor]: Prop140: Extract, test, revise, and clean the diff code

[Tor Bug Tracker & Wiki]

#21643: Prop140: Extract, test, revise, and clean the diff code
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorCoreTeam201703, prop140, review-  |  Actual Points:  2
  group-17   |
Parent ID:  #13339   | Points:  3
 Reviewer:  ahf  |Sponsor:
 |  Sponsor4
-+-

Comment (by nickm):

 https://gitlab.com/nickm_tor/tor/merge_requests/12

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21643 [Core Tor/Tor]: Prop140: Extract, test, revise, and clean the diff code

[Tor Bug Tracker & Wiki]

#21643: Prop140: Extract, test, revise, and clean the diff code
+--
 Reporter:  nickm   |  Owner:  nickm
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.1.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  TorCoreTeam201703, prop140  |  Actual Points:  2
Parent ID:  #13339  | Points:  3
 Reviewer:  |Sponsor:  Sponsor4
+--
Changes (by nickm):

 * status:  accepted => needs_review
 * actualpoints:   => 2


Comment:

 Also it's fuzzed and profiled now, and optimized a bit.  I'll fuzz more
 with the new optimizations.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21643 [Core Tor/Tor]: Prop140: Extract, test, revise, and clean the diff code

[Tor Bug Tracker & Wiki]

#21643: Prop140: Extract, test, revise, and clean the diff code
---+
 Reporter:  nickm  |  Owner:  nickm
 Type:  defect | Status:  accepted
 Priority:  Medium |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  TorCoreTeam201703  |  Actual Points:
Parent ID:  #13339 | Points:  3
 Reviewer: |Sponsor:  Sponsor4
---+

Comment (by nickm):

 Okay, now the branch is up to 100% coverage.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21643 [Core Tor/Tor]: Prop140: Extract, test, revise, and clean the diff code

[Tor Bug Tracker & Wiki]

#21643: Prop140: Extract, test, revise, and clean the diff code
---+
 Reporter:  nickm  |  Owner:  nickm
 Type:  defect | Status:  accepted
 Priority:  Medium |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  TorCoreTeam201703  |  Actual Points:
Parent ID:  #13339 | Points:  3
 Reviewer: |Sponsor:  Sponsor4
---+

Comment (by nickm):

 After some tweaks, I can measure coverage again.  Coverage on consdiff.c
 is at 90%, which isn't bad, but we should get it higher.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21643 [Core Tor/Tor]: Prop140: Extract, test, revise, and clean the diff code

[Tor Bug Tracker & Wiki]

#21643: Prop140: Extract, test, revise, and clean the diff code
---+
 Reporter:  nickm  |  Owner:  nickm
 Type:  defect | Status:  accepted
 Priority:  Medium |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  TorCoreTeam201703  |  Actual Points:
Parent ID:  #13339 | Points:  3
 Reviewer: |Sponsor:  Sponsor4
---+

Comment (by nickm):

 I've extracted the diff/patch code (and only the diff/patch code) from the
 rebased consdiff branch into a new branch, `prop140_21643_diff_only`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21643 [Core Tor/Tor]: Prop140: Extract, test, revise, and clean the diff code

[Tor Bug Tracker & Wiki]

#21643: Prop140: Extract, test, revise, and clean the diff code
--+
 Reporter:  nickm |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  TorCoreTeam201703
Actual Points:|  Parent ID:  #13339
   Points:  3 |   Reviewer:
  Sponsor:  Sponsor4  |
--+
 Step one of getting the consensus diff support of prop140 completed is to
 get the diff and patch code merged.  Let's do this separately from the
 directory code, since that code is hairier, and may need more work.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21643 [Core Tor/Tor]: Prop140: Extract, test, revise, and clean the diff code

[Tor Bug Tracker & Wiki]

#21643: Prop140: Extract, test, revise, and clean the diff code
---+
 Reporter:  nickm  |  Owner:  nickm
 Type:  defect | Status:  accepted
 Priority:  Medium |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  TorCoreTeam201703  |  Actual Points:
Parent ID:  #13339 | Points:  3
 Reviewer: |Sponsor:  Sponsor4
---+
Changes (by nickm):

 * owner:   => nickm
 * status:  new => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs